-- MySQL dump 10.15 Distrib 10.0.23-MariaDB, for Linux (x86_64) -- -- Host: localhost Database: gerrit -- ------------------------------------------------------ -- Server version 10.0.23-MariaDB /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */; /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */; /*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */; /*!40101 SET NAMES utf8 */; /*!40103 SET @OLD_TIME_ZONE=@@TIME_ZONE */; /*!40103 SET TIME_ZONE='+00:00' */; /*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */; /*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0 */; /*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */; /*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */; -- -- Current Database: `gerrit` -- CREATE DATABASE /*!32312 IF NOT EXISTS*/ `gerrit` /*!40100 DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci */; USE `gerrit`; -- -- Table structure for table `account_external_ids` -- DROP TABLE IF EXISTS `account_external_ids`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_external_ids` ( `account_id` int(11) NOT NULL DEFAULT '0', `email_address` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL, `password` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL, `external_id` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', PRIMARY KEY (`external_id`), KEY `account_external_ids_byAccount` (`account_id`), KEY `account_external_ids_byEmail` (`email_address`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_external_ids` -- LOCK TABLES `account_external_ids` WRITE; /*!40000 ALTER TABLE `account_external_ids` DISABLE KEYS */; INSERT INTO `account_external_ids` VALUES (49,'ciat@baserock.org',NULL,'https://openid.baserock.org/openid/CIAT/'),(42,'richard.maw@gmail.com',NULL,'https://openid.baserock.org/openid/RichardMaw/'),(37,'richard.maw@codethink.co.uk',NULL,'https://openid.baserock.org/openid/RichardMawCT/'),(16,'adam.coldrick@codethink.co.uk',NULL,'https://openid.baserock.org/openid/SotK/'),(34,'zara.zaimeche@codethink.co.uk',NULL,'https://openid.baserock.org/openid/Zara/'),(57,'al.grant@arm.com',NULL,'https://openid.baserock.org/openid/algrant-arm/'),(53,'ana.huelamo@codethink.co.uk',NULL,'https://openid.baserock.org/openid/anahuelamo/'),(55,'andrew.leeming@codethink.co.uk',NULL,'https://openid.baserock.org/openid/andrewleeming/'),(11,'bob.mottram@codethink.co.uk',NULL,'https://openid.baserock.org/openid/bashrc/'),(50,'ben.brown@codethink.co.uk',NULL,'https://openid.baserock.org/openid/benbrown/'),(46,'ben.hutchings@codethink.co.uk',NULL,'https://openid.baserock.org/openid/benhutchings/'),(17,'samthursfield@codethink.co.uk',NULL,'https://openid.baserock.org/openid/chaosmonkey/'),(56,'christopher.phang@codethink.co.uk',NULL,'https://openid.baserock.org/openid/cphang/'),(32,'daniel.silverstone@codethink.co.uk',NULL,'https://openid.baserock.org/openid/danielsilverstone/'),(26,'edward.cragg@codethink.co.uk',NULL,'https://openid.baserock.org/openid/edwardcragg/'),(8,'francisco.marchena@codethink.co.uk',NULL,'https://openid.baserock.org/openid/franred/'),(10,'gary.perkins@codethink.co.uk',NULL,'https://openid.baserock.org/openid/garyperkins'),(52,'gary.perkins@codethink.co.uk',NULL,'https://openid.baserock.org/openid/garyperkins/'),(25,'james@seriousinternetbusiness.com',NULL,'https://openid.baserock.org/openid/james/'),(19,'jim.macarthur@codethink.co.uk',NULL,'https://openid.baserock.org/openid/jimmacarthur/'),(15,'jjardon@gnome.org',NULL,'https://openid.baserock.org/openid/jjardon/'),(41,'jonathan.maw@codethink.co.uk',NULL,'https://openid.baserock.org/openid/jonathan.maw/'),(38,'dan.firth@codethink.co.uk',NULL,'https://openid.baserock.org/openid/locallycompact/'),(47,'mark.doffman@codethink.co.uk',NULL,'https://openid.baserock.org/openid/markdoffman/'),(27,'mike.smith@codethink.co.uk',NULL,'https://openid.baserock.org/openid/mikesmith/'),(22,'mike.williams@codethink.co.uk',NULL,'https://openid.baserock.org/openid/mwilliams/'),(40,'paul.martin@codethink.co.uk',NULL,'https://openid.baserock.org/openid/paulmartin/'),(18,'paul.sherwood@codethink.co.uk',NULL,'https://openid.baserock.org/openid/paulsherwood/'),(51,'paulsherwood@codethink.co.uk',NULL,'https://openid.baserock.org/openid/paulsherwood2/'),(44,'paul.waters@codethink.co.uk',NULL,'https://openid.baserock.org/openid/paulwaters/'),(43,'patrick.darley@codethink.co.uk',NULL,'https://openid.baserock.org/openid/pdar/'),(7,'pedro.alvarez@codethink.co.uk',NULL,'https://openid.baserock.org/openid/pedroalvarez/'),(39,'lauren.perry@codethink.co.uk',NULL,'https://openid.baserock.org/openid/perryl/'),(20,'pete.fotheringham@codethink.co.uk',NULL,'https://openid.baserock.org/openid/petefoth'),(23,'pete.fotheringham@codethink.co.uk',NULL,'https://openid.baserock.org/openid/petefoth/'),(35,'james.thomas@codethink.co.uk',NULL,'https://openid.baserock.org/openid/radiofree/'),(54,'ravi.s@lge.com',NULL,'https://openid.baserock.org/openid/raviss/'),(24,'richard.dale@codethink.co.uk',NULL,'https://openid.baserock.org/openid/rdale/'),(29,'richard.ipsum@codethink.co.uk',NULL,'https://openid.baserock.org/openid/richardipsum/'),(45,'rob.kendrick@codethink.co.uk',NULL,'https://openid.baserock.org/openid/rjek/'),(6,'sam.thursfield@codethink.co.uk',NULL,'https://openid.baserock.org/openid/samthursfield/'),(21,'simon.hoinkis@codethink.co.uk',NULL,'https://openid.baserock.org/openid/simonhoinkis/'),(33,'richardipsum@fastmail.co.uk',NULL,'https://openid.baserock.org/openid/straycat/'),(30,'kejia.hu@codethink.co.uk',NULL,'https://openid.baserock.org/openid/terry/'),(28,'tiago.gomes@codethink.co.uk',NULL,'https://openid.baserock.org/openid/tiagogomes/'),(31,'michael.drake@codethink.co.uk',NULL,'https://openid.baserock.org/openid/tlsa/'),(48,'tristan.vanberkom@codethink.co.uk',NULL,'https://openid.baserock.org/openid/tristanvb/'),(36,'william.holland@codethink.co.uk',NULL,'https://openid.baserock.org/openid/williamholland/'),(16,'adam@sotk.co.uk',NULL,'mailto:adam@sotk.co.uk'),(12,'firehose@baserock.org',NULL,'mailto:firehose@baserock.org'),(14,'lorry@baserock.org',NULL,'mailto:lorry@baserock.org'),(13,'mason@baserock.org',NULL,'mailto:mason@baserock.org'),(42,NULL,'N/jJtQPIuC26F0pOb5ngCrsD7qjnW+hdayarVE3hHA','username:RichardMaw'),(37,NULL,'DmaPLcmXXmtyXyk5TSBE2sRVVtjR9F7VpEvYwXfxwQ','username:RichardMawCT'),(16,NULL,NULL,'username:SotK'),(34,NULL,'JFcfn0NQ8whfeGFWEA6b8Kepr2Re198e0cMUwzA7Iw','username:Zara'),(53,NULL,NULL,'username:anahuelamo'),(11,NULL,'+Df4lPHPdzEXcOz0a7PYR/fPeFjeFS64y4jSzKgisw','username:bashrc'),(50,NULL,NULL,'username:benbrown'),(46,NULL,NULL,'username:benhutchings'),(17,NULL,'VX5MNZkavhdRDt257i+Bjn54sQLJjZpsHTA/ERYzsQ','username:chaosmonkey'),(56,NULL,NULL,'username:christopherphang'),(32,NULL,'z8WQhIWPJQ6vKn2WMmjk4J85XWveWiLQR6ZgRTytTA','username:danielsilverstone'),(18,NULL,NULL,'username:devcurmudgeon'),(47,NULL,NULL,'username:doffm'),(26,NULL,NULL,'username:edwardcragg'),(12,NULL,NULL,'username:firehose'),(8,NULL,NULL,'username:franred'),(10,NULL,NULL,'username:garyperkins'),(25,NULL,NULL,'username:james'),(19,NULL,NULL,'username:jimmacarthur'),(15,NULL,'enWO/OIogX4TLuijVbsL0doAUXuDNLZKi/KGbxfhJA','username:jjardon'),(41,NULL,NULL,'username:jonathanmaw'),(55,NULL,NULL,'username:leeming'),(38,NULL,NULL,'username:locallycompact'),(14,NULL,NULL,'username:lorry'),(13,NULL,'7890dsdfg07890987','username:mason'),(27,NULL,NULL,'username:mikesmith'),(22,NULL,NULL,'username:mwilliams'),(40,NULL,'b8LORsz19WK29kyToQQa3VMVSG6VxBLJkfJaiFQ80Q','username:nowster'),(44,NULL,NULL,'username:paulwaters'),(43,NULL,'42/5YAeb4G7wuSDWqHtrfXOX5JFAb1OJAC0pJ2gI9Q','username:pdar'),(7,NULL,'CmnpMyGfdd3V1TPI4l3G9MCjx6grkjeSgSQzM+GiKg','username:pedroalvarez'),(39,NULL,NULL,'username:perryl'),(20,NULL,NULL,'username:petefoth'),(35,NULL,NULL,'username:radiofree'),(24,NULL,NULL,'username:rdale'),(29,NULL,'WWL65gSkGFIj0bubCNm77N7YZwu0NJsH38nrnPBiQw','username:ripsum'),(6,NULL,'8woD62mFthpW7FahCyJ6ZIoJfRfcUK/bqw7zagqBQg','username:samthursfield'),(33,NULL,NULL,'username:straycat'),(30,NULL,NULL,'username:terry'),(28,NULL,NULL,'username:tiagogomes'),(31,NULL,NULL,'username:tlsa'),(48,NULL,NULL,'username:tristanvb'),(36,NULL,NULL,'username:williamholland'); /*!40000 ALTER TABLE `account_external_ids` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_group_by_id` -- DROP TABLE IF EXISTS `account_group_by_id`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_group_by_id` ( `group_id` int(11) NOT NULL DEFAULT '0', `include_uuid` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', PRIMARY KEY (`group_id`,`include_uuid`), KEY `account_group_id_byInclude` (`include_uuid`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_group_by_id` -- LOCK TABLES `account_group_by_id` WRITE; /*!40000 ALTER TABLE `account_group_by_id` DISABLE KEYS */; INSERT INTO `account_group_by_id` VALUES (3,'global:Registered-Users'),(5,'b8fc45c681b94669fe3fa965c48d5221a515a3a6'),(7,'global:Registered-Users'); /*!40000 ALTER TABLE `account_group_by_id` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_group_by_id_aud` -- DROP TABLE IF EXISTS `account_group_by_id_aud`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_group_by_id_aud` ( `added_by` int(11) NOT NULL DEFAULT '0', `removed_by` int(11) DEFAULT NULL, `removed_on` timestamp NULL DEFAULT NULL, `group_id` int(11) NOT NULL DEFAULT '0', `include_uuid` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', `added_on` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00', PRIMARY KEY (`group_id`,`include_uuid`,`added_on`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_group_by_id_aud` -- LOCK TABLES `account_group_by_id_aud` WRITE; /*!40000 ALTER TABLE `account_group_by_id_aud` DISABLE KEYS */; INSERT INTO `account_group_by_id_aud` VALUES (6,NULL,NULL,3,'global:Registered-Users','2015-03-09 15:33:46'),(6,6,'2015-03-13 14:28:04',4,'a7a9cc6639bd943e47da0d20b39267a08b43cd91','2015-03-09 15:34:58'),(6,NULL,NULL,5,'b8fc45c681b94669fe3fa965c48d5221a515a3a6','2015-03-13 14:27:43'),(6,NULL,NULL,7,'global:Registered-Users','2015-03-09 15:34:59'); /*!40000 ALTER TABLE `account_group_by_id_aud` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_group_id` -- DROP TABLE IF EXISTS `account_group_id`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_group_id` ( `s` bigint(20) unsigned NOT NULL AUTO_INCREMENT, UNIQUE KEY `s` (`s`) ) ENGINE=InnoDB AUTO_INCREMENT=9 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_group_id` -- LOCK TABLES `account_group_id` WRITE; /*!40000 ALTER TABLE `account_group_id` DISABLE KEYS */; INSERT INTO `account_group_id` VALUES (1),(2),(3),(4),(5),(6),(7),(8); /*!40000 ALTER TABLE `account_group_id` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_group_members` -- DROP TABLE IF EXISTS `account_group_members`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_group_members` ( `account_id` int(11) NOT NULL DEFAULT '0', `group_id` int(11) NOT NULL DEFAULT '0', PRIMARY KEY (`account_id`,`group_id`), KEY `account_group_members_byGroup` (`group_id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_group_members` -- LOCK TABLES `account_group_members` WRITE; /*!40000 ALTER TABLE `account_group_members` DISABLE KEYS */; INSERT INTO `account_group_members` VALUES (6,1),(6,3),(6,4),(6,5),(6,6),(6,7),(6,8),(7,1),(7,2),(7,4),(7,5),(8,4),(10,1),(12,2),(13,2),(13,8),(14,2),(14,6),(15,4),(16,4),(18,4),(26,4),(28,4),(29,4),(33,4),(37,4),(38,2),(48,4); /*!40000 ALTER TABLE `account_group_members` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_group_members_audit` -- DROP TABLE IF EXISTS `account_group_members_audit`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_group_members_audit` ( `added_by` int(11) NOT NULL DEFAULT '0', `removed_by` int(11) DEFAULT NULL, `removed_on` timestamp NULL DEFAULT NULL, `account_id` int(11) NOT NULL DEFAULT '0', `group_id` int(11) NOT NULL DEFAULT '0', `added_on` timestamp NOT NULL DEFAULT '0000-00-00 00:00:00', PRIMARY KEY (`account_id`,`group_id`,`added_on`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_group_members_audit` -- LOCK TABLES `account_group_members_audit` WRITE; /*!40000 ALTER TABLE `account_group_members_audit` DISABLE KEYS */; INSERT INTO `account_group_members_audit` VALUES (6,NULL,NULL,6,1,'2015-01-29 14:27:22'),(6,NULL,NULL,6,3,'2015-03-09 15:33:45'),(6,NULL,NULL,6,4,'2015-03-09 15:33:46'),(6,NULL,NULL,6,5,'2015-03-09 15:34:57'),(6,NULL,NULL,6,6,'2015-03-09 15:34:58'),(6,NULL,NULL,6,7,'2015-03-09 15:34:59'),(6,NULL,NULL,6,8,'2015-03-09 15:35:00'),(6,NULL,NULL,7,1,'2015-01-29 14:43:33'),(7,NULL,NULL,7,2,'2016-02-29 14:44:51'),(7,NULL,NULL,7,4,'2015-03-18 13:05:55'),(7,NULL,NULL,7,5,'2015-08-13 10:48:29'),(6,7,'2015-12-14 13:33:17',8,1,'2015-01-29 15:00:37'),(8,NULL,NULL,8,4,'2015-03-18 12:42:21'),(6,NULL,NULL,10,1,'2015-03-13 14:28:36'),(6,NULL,NULL,12,2,'2015-03-09 15:59:42'),(6,NULL,NULL,13,2,'2015-03-09 16:05:35'),(6,NULL,NULL,13,8,'2015-03-09 16:05:36'),(6,NULL,NULL,14,2,'2015-03-09 16:05:35'),(6,NULL,NULL,14,6,'2015-03-09 16:05:35'),(6,6,'2015-03-13 10:14:04',15,4,'2015-03-13 10:06:40'),(6,NULL,NULL,15,4,'2015-03-13 14:24:03'),(6,6,'2015-03-17 14:20:02',16,3,'2015-03-17 14:18:03'),(6,NULL,NULL,16,4,'2015-03-18 13:04:01'),(6,NULL,NULL,18,4,'2015-03-18 13:03:58'),(7,NULL,NULL,26,4,'2016-03-14 10:06:36'),(7,NULL,NULL,28,4,'2015-08-12 16:59:46'),(7,NULL,NULL,29,4,'2015-03-27 17:45:11'),(7,NULL,NULL,33,4,'2015-03-27 18:06:01'),(8,NULL,NULL,37,4,'2015-03-31 14:44:02'),(7,NULL,NULL,38,2,'2016-02-29 14:49:51'),(6,NULL,NULL,48,4,'2015-11-09 13:27:59'); /*!40000 ALTER TABLE `account_group_members_audit` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_group_names` -- DROP TABLE IF EXISTS `account_group_names`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_group_names` ( `group_id` int(11) NOT NULL DEFAULT '0', `name` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', PRIMARY KEY (`name`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_group_names` -- LOCK TABLES `account_group_names` WRITE; /*!40000 ALTER TABLE `account_group_names` DISABLE KEYS */; INSERT INTO `account_group_names` VALUES (1,'Administrators'),(3,'Developers'),(4,'Mergers'),(6,'Mirroring Tools'),(2,'Non-Interactive Users'),(5,'Release Team'),(7,'Reviewers'),(8,'Testers'); /*!40000 ALTER TABLE `account_group_names` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_groups` -- DROP TABLE IF EXISTS `account_groups`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_groups` ( `name` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', `description` text COLLATE utf8_unicode_ci, `visible_to_all` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `group_uuid` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', `owner_group_uuid` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', `group_id` int(11) NOT NULL DEFAULT '0', PRIMARY KEY (`group_id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_groups` -- LOCK TABLES `account_groups` WRITE; /*!40000 ALTER TABLE `account_groups` DISABLE KEYS */; INSERT INTO `account_groups` VALUES ('Administrators','Gerrit Site Administrators','Y','b660c33b68509db9dbd9578ae00035da90c0d5eb','b660c33b68509db9dbd9578ae00035da90c0d5eb',1),('Non-Interactive Users','Users who perform batch actions on Gerrit','Y','8e467a11f116bb716a65ac85e28bf09ebfeb0d63','b660c33b68509db9dbd9578ae00035da90c0d5eb',2),('Developers','Registered users who choose to submit changes for consideration.','Y','898d9c4232b8fcac6a3b128f7264c5d4c8b1eead','b660c33b68509db9dbd9578ae00035da90c0d5eb',3),('Mergers','Developers who can trigger the actual merging of a change.','Y','b8fc45c681b94669fe3fa965c48d5221a515a3a6','b660c33b68509db9dbd9578ae00035da90c0d5eb',4),('Release Team','Developers who can tag releases','Y','a7a9cc6639bd943e47da0d20b39267a08b43cd91','b660c33b68509db9dbd9578ae00035da90c0d5eb',5),('Mirroring Tools','Programs that pull changes from external repositories into Gerrit\'s Git server','Y','8c788c828285c3dd0a8c1cc152de6735085def9f','b660c33b68509db9dbd9578ae00035da90c0d5eb',6),('Reviewers','Registered users who choose to give +1 / -1 reviews to proposed changes.','Y','d643abb0ad6e9d5ac33093af5cd3a3d4e484d95d','b660c33b68509db9dbd9578ae00035da90c0d5eb',7),('Testers','Testers that can give +1 / -1 Verified to proposed changes.','Y','cea6c19a08e11b74e63a567e050bec2c6eeb14dc','b660c33b68509db9dbd9578ae00035da90c0d5eb',8); /*!40000 ALTER TABLE `account_groups` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_id` -- DROP TABLE IF EXISTS `account_id`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_id` ( `s` bigint(20) unsigned NOT NULL AUTO_INCREMENT, UNIQUE KEY `s` (`s`) ) ENGINE=InnoDB AUTO_INCREMENT=58 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_id` -- LOCK TABLES `account_id` WRITE; /*!40000 ALTER TABLE `account_id` DISABLE KEYS */; INSERT INTO `account_id` VALUES (6),(7),(8),(9),(10),(11),(12),(13),(14),(15),(16),(17),(18),(19),(20),(21),(22),(23),(24),(25),(26),(27),(28),(29),(30),(31),(32),(33),(34),(35),(36),(37),(38),(39),(40),(41),(42),(43),(44),(45),(46),(47),(48),(49),(50),(51),(52),(53),(54),(55),(56),(57); /*!40000 ALTER TABLE `account_id` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `account_project_watches` -- DROP TABLE IF EXISTS `account_project_watches`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `account_project_watches` ( `notify_new_changes` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `notify_all_comments` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `notify_submitted_changes` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `notify_new_patch_sets` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `notify_abandoned_changes` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `account_id` int(11) NOT NULL DEFAULT '0', `project_name` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', `filter` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', PRIMARY KEY (`account_id`,`project_name`,`filter`), KEY `account_project_watches_byP` (`project_name`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `account_project_watches` -- LOCK TABLES `account_project_watches` WRITE; /*!40000 ALTER TABLE `account_project_watches` DISABLE KEYS */; INSERT INTO `account_project_watches` VALUES ('N','N','N','Y','N',7,'baserock/baserock/definitions','branch:master'),('N','N','N','Y','N',7,'baserock/baserock/infrastructure','branch:master'),('N','N','Y','N','N',15,'baserock/baserock/baserock-chroot','*'),('N','N','Y','N','N',15,'baserock/baserock/definitions','*'),('N','N','Y','N','N',15,'baserock/baserock/morph','*'),('N','N','Y','N','N',15,'local-config/lorries','*'),('N','N','N','N','N',16,'baserock/baserock/definitions','*'),('N','N','N','N','N',16,'baserock/baserock/firehose','*'),('N','N','N','N','N',16,'baserock/baserock/infrastructure','*'),('N','N','N','N','N',16,'baserock/baserock/lorry','*'),('N','N','N','N','N',16,'baserock/baserock/lorry-controller','*'),('N','N','N','N','N',16,'baserock/baserock/morph','*'),('N','N','N','N','N',16,'baserock/baserock/trove-setup','*'),('N','N','N','N','N',18,'baserock/baserock/definitions','*'),('N','N','N','N','N',18,'baserock/baserock/morph','*'),('N','N','N','N','N',18,'local-config/lorries','*'),('Y','Y','N','Y','N',19,'baserock/baserock/definitions','*'),('Y','N','N','Y','N',43,'baserock/baserock/definitions','*'),('Y','N','N','Y','N',43,'baserock/baserock/morph','*'),('Y','N','N','Y','N',43,'baserock/local-config/lorries','*'); /*!40000 ALTER TABLE `account_project_watches` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `accounts` -- DROP TABLE IF EXISTS `accounts`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `accounts` ( `registered_on` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, `full_name` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL, `preferred_email` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL, `inactive` char(1) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'N', `account_id` int(11) NOT NULL DEFAULT '0', PRIMARY KEY (`account_id`), KEY `accounts_byPreferredEmail` (`preferred_email`), KEY `accounts_byFullName` (`full_name`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `accounts` -- LOCK TABLES `accounts` WRITE; /*!40000 ALTER TABLE `accounts` DISABLE KEYS */; INSERT INTO `accounts` VALUES ('2015-11-03 23:32:25','Sam Thursfield','sam.thursfield@codethink.co.uk','N',6),('2015-11-03 23:32:25','Pedro Alvarez','pedro.alvarez@codethink.co.uk','N',7),('2015-11-03 23:32:25','Francisco Redondo','francisco.marchena@codethink.co.uk','N',8),('2015-11-03 23:32:25','Gary Perkins','gary.perkins@codethink.co.uk','N',10),('2015-11-03 23:32:25','Bob Mottram','bob.mottram@codethink.co.uk','N',11),('2015-11-03 23:32:25','Firehose integration bot','firehose@baserock.org','N',12),('2015-11-03 23:32:25','Mason automated tester','mason@baserock.org','N',13),('2015-11-03 23:32:25','Lorry mirroring service','lorry@baserock.org','N',14),('2015-11-03 23:32:25','Javier Jardón','jjardon@gnome.org','N',15),('2015-11-03 23:32:25','Adam Coldrick','adam.coldrick@codethink.co.uk','N',16),('2015-11-03 23:32:25','Chaos Monkey','samthursfield@codethink.co.uk','N',17),('2015-11-03 23:32:25','Paul Sherwood','paul.sherwood@codethink.co.uk','N',18),('2015-11-03 23:32:25','Jim MacArthur','jim.macarthur@codethink.co.uk','N',19),('2015-11-03 23:32:25','Pete Fotheringham','pete.fotheringham@codethink.co.uk','N',20),('2015-11-03 23:32:25','Simon Hoinkis','simon.hoinkis@codethink.co.uk','N',21),('2015-11-03 23:32:25','Mike Williams','mike.williams@codethink.co.uk','N',22),('2015-11-03 23:32:25','Pete Fotheringham','pete.fotheringham@codethink.co.uk','N',23),('2015-11-03 23:32:25','Richard Dale','richard.dale@codethink.co.uk','N',24),('2015-11-03 23:32:25','James Thomas','james@seriousinternetbusiness.com','N',25),('2015-11-03 23:32:25','Edward Cragg','edward.cragg@codethink.co.uk','N',26),('2015-11-03 23:32:25','Michael Peter Smith','mike.smith@codethink.co.uk','N',27),('2015-11-03 23:32:25','Tiago Gomes','tiago.gomes@codethink.co.uk','N',28),('2015-11-03 23:32:25','Richard Ipsum','richard.ipsum@codethink.co.uk','N',29),('2015-11-03 23:32:25','Kejia Hu','kejia.hu@codethink.co.uk','N',30),('2015-11-03 23:32:25','Michael Drake','michael.drake@codethink.co.uk','N',31),('2015-11-03 23:32:25','Daniel Silverstone','daniel.silverstone@codethink.co.uk','N',32),('2015-11-03 23:32:25','VLetrmx','richardipsum@fastmail.co.uk','N',33),('2015-11-03 23:32:25','Zara Zaimeche','zara.zaimeche@codethink.co.uk','N',34),('2015-11-03 23:32:25','James Thomas','james.thomas@codethink.co.uk','N',35),('2015-11-03 23:32:25','William Holland','william.holland@codethink.co.uk','N',36),('2015-11-03 23:32:25','Richard Maw','richard.maw@codethink.co.uk','N',37),('2015-11-03 23:32:25','Daniel Firth','dan.firth@codethink.co.uk','N',38),('2015-11-03 23:32:25','Lauren Perry','lauren.perry@codethink.co.uk','N',39),('2015-11-03 23:32:25','Paul Martin','paul.martin@codethink.co.uk','N',40),('2015-11-03 23:32:25','Jonathan Maw','jonathan.maw@codethink.co.uk','N',41),('2015-11-03 23:32:25','Richard Maw','richard.maw@gmail.com','N',42),('2015-11-03 23:32:25','Patrick Darley','patrick.darley@codethink.co.uk','N',43),('2015-11-03 23:32:25','Paul Waters','paul.waters@codethink.co.uk','N',44),('2015-11-03 23:32:25','Rob Kendrick','rob.kendrick@codethink.co.uk','N',45),('2015-11-03 23:32:25','Ben Hutchings','ben.hutchings@codethink.co.uk','N',46),('2015-11-03 23:32:25','Mark Doffman','mark.doffman@codethink.co.uk','N',47),('2015-11-03 23:32:25','Tristan Van Berkom','tristan.vanberkom@codethink.co.uk','N',48),('2015-11-03 23:32:25','Continuous Integration and Testing','ciat@baserock.org','N',49),('2015-12-10 11:39:50','Ben Brown','ben.brown@codethink.co.uk','N',50),('2015-12-14 17:42:02','Paul Sherwood','paulsherwood@codethink.co.uk','N',51),('2016-03-16 16:32:08','Gary Perkins','gary.perkins@codethink.co.uk','N',52),('2016-03-21 16:32:32','Ana Huelamo','ana.huelamo@codethink.co.uk','N',53),('2016-05-25 09:20:06','Ravi S','ravi.s@lge.com','N',54),('2016-06-09 14:33:16','Andrew Leeming','andrew.leeming@codethink.co.uk','N',55),('2016-09-26 14:04:22','Chris Phang','christopher.phang@codethink.co.uk','N',56),('2017-05-18 11:47:35','Al Grant','al.grant@arm.com','N',57); /*!40000 ALTER TABLE `accounts` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `change_id` -- DROP TABLE IF EXISTS `change_id`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `change_id` ( `s` bigint(20) unsigned NOT NULL AUTO_INCREMENT, UNIQUE KEY `s` (`s`) ) ENGINE=InnoDB AUTO_INCREMENT=2350 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `change_id` -- LOCK TABLES `change_id` WRITE; /*!40000 ALTER TABLE `change_id` DISABLE KEYS */; INSERT INTO `change_id` VALUES (1),(2),(3),(4),(5),(6),(7),(8),(9),(10),(11),(12),(13),(14),(15),(16),(17),(18),(19),(20),(21),(22),(23),(24),(25),(26),(27),(28),(29),(30),(31),(32),(33),(34),(35),(36),(37),(38),(39),(40),(41),(42),(43),(44),(45),(46),(47),(48),(49),(50),(51),(52),(53),(54),(55),(56),(57),(58),(59),(60),(61),(62),(63),(64),(65),(66),(67),(68),(69),(70),(71),(72),(73),(74),(75),(76),(77),(78),(79),(80),(81),(82),(83),(84),(85),(86),(87),(88),(89),(90),(91),(92),(93),(94),(95),(96),(97),(98),(99),(100),(101),(102),(103),(104),(105),(106),(107),(108),(109),(110),(111),(112),(113),(114),(115),(116),(117),(118),(119),(120),(121),(122),(123),(124),(125),(126),(127),(128),(129),(130),(131),(132),(133),(134),(135),(136),(137),(138),(139),(140),(141),(142),(143),(144),(145),(146),(147),(148),(149),(150),(151),(152),(153),(154),(155),(156),(157),(158),(159),(160),(161),(162),(163),(164),(165),(166),(167),(168),(169),(170),(171),(172),(173),(174),(175),(176),(177),(178),(179),(180),(181),(182),(183),(184),(185),(186),(187),(188),(189),(190),(191),(192),(193),(194),(195),(196),(197),(198),(199),(200),(201),(202),(203),(204),(205),(206),(207),(208),(209),(210),(211),(212),(213),(214),(215),(216),(217),(218),(219),(220),(221),(222),(223),(224),(225),(226),(227),(228),(229),(230),(231),(232),(233),(234),(235),(236),(237),(238),(239),(240),(241),(242),(243),(244),(245),(246),(247),(248),(249),(250),(251),(252),(253),(254),(255),(256),(257),(258),(259),(260),(261),(262),(263),(264),(265),(266),(267),(268),(269),(270),(271),(272),(273),(274),(275),(276),(277),(278),(279),(280),(281),(282),(283),(284),(285),(286),(287),(288),(289),(290),(291),(292),(293),(294),(295),(296),(297),(298),(299),(300),(301),(302),(303),(304),(305),(306),(307),(308),(309),(310),(311),(312),(313),(314),(315),(316),(317),(318),(319),(320),(321),(322),(323),(324),(325),(326),(327),(328),(329),(330),(331),(332),(333),(334),(335),(336),(337),(338),(339),(340),(341),(342),(343),(344),(345),(346),(347),(348),(349),(350),(351),(352),(353),(354),(355),(356),(357),(358),(359),(360),(361),(362),(363),(364),(365),(366),(367),(368),(369),(370),(371),(372),(373),(374),(375),(376),(377),(378),(379),(380),(381),(382),(383),(384),(385),(386),(387),(388),(389),(390),(391),(392),(393),(394),(395),(396),(397),(398),(399),(400),(401),(402),(403),(404),(405),(406),(407),(408),(409),(410),(411),(412),(413),(414),(415),(416),(417),(418),(419),(420),(421),(422),(423),(424),(425),(426),(427),(428),(429),(430),(431),(432),(433),(434),(435),(436),(437),(438),(439),(440),(441),(442),(443),(444),(445),(446),(447),(448),(449),(450),(451),(452),(453),(454),(455),(456),(457),(458),(459),(460),(461),(462),(463),(464),(465),(466),(467),(468),(469),(470),(471),(472),(473),(474),(475),(476),(477),(478),(479),(480),(481),(482),(483),(484),(485),(486),(487),(488),(489),(490),(491),(492),(493),(494),(495),(496),(497),(498),(499),(500),(501),(502),(503),(504),(505),(506),(507),(508),(509),(510),(511),(512),(513),(514),(515),(516),(517),(518),(519),(520),(521),(522),(523),(524),(525),(526),(527),(528),(529),(530),(531),(532),(533),(534),(535),(536),(537),(538),(539),(540),(541),(542),(543),(544),(545),(546),(547),(548),(549),(550),(551),(552),(553),(554),(555),(556),(557),(558),(559),(560),(561),(562),(563),(564),(565),(566),(567),(568),(569),(570),(571),(572),(573),(574),(575),(576),(577),(578),(579),(580),(581),(582),(583),(584),(585),(586),(587),(588),(589),(590),(591),(592),(593),(594),(595),(596),(597),(598),(599),(600),(601),(602),(603),(604),(605),(606),(607),(608),(609),(610),(611),(612),(613),(614),(615),(616),(617),(618),(619),(620),(621),(622),(623),(624),(625),(626),(627),(628),(629),(630),(631),(632),(633),(634),(635),(636),(637),(638),(639),(640),(641),(642),(643),(644),(645),(646),(647),(648),(649),(650),(651),(652),(653),(654),(655),(656),(657),(658),(659),(660),(661),(662),(663),(664),(665),(666),(667),(668),(669),(670),(671),(672),(673),(674),(675),(676),(677),(678),(679),(680),(681),(682),(683),(684),(685),(686),(687),(688),(689),(690),(691),(692),(693),(694),(695),(696),(697),(698),(699),(700),(701),(702),(703),(704),(705),(706),(707),(708),(709),(710),(711),(712),(713),(714),(715),(716),(717),(718),(719),(720),(721),(722),(723),(724),(725),(726),(727),(728),(729),(730),(731),(732),(733),(734),(735),(736),(737),(738),(739),(740),(741),(742),(743),(744),(745),(746),(747),(748),(749),(750),(751),(752),(753),(754),(755),(756),(757),(758),(759),(760),(761),(762),(763),(764),(765),(766),(767),(768),(769),(770),(771),(772),(773),(774),(775),(776),(777),(778),(779),(780),(781),(782),(783),(784),(785),(786),(787),(788),(789),(790),(791),(792),(793),(794),(795),(796),(797),(798),(799),(800),(801),(802),(803),(804),(805),(806),(807),(808),(809),(810),(811),(812),(813),(814),(815),(816),(817),(818),(819),(820),(821),(822),(823),(824),(825),(826),(827),(828),(829),(830),(831),(832),(833),(834),(835),(836),(837),(838),(839),(840),(841),(842),(843),(844),(845),(846),(847),(848),(849),(850),(851),(852),(853),(854),(855),(856),(857),(858),(859),(860),(861),(862),(863),(864),(865),(866),(867),(868),(869),(870),(871),(872),(873),(874),(875),(876),(877),(878),(879),(880),(881),(882),(883),(884),(885),(886),(887),(888),(889),(890),(891),(892),(893),(894),(895),(896),(897),(898),(899),(900),(901),(902),(903),(904),(905),(906),(907),(908),(909),(910),(911),(912),(913),(914),(915),(916),(917),(918),(919),(920),(921),(922),(923),(924),(925),(926),(927),(928),(929),(930),(931),(932),(933),(934),(935),(936),(937),(938),(939),(940),(941),(942),(943),(944),(945),(946),(947),(948),(949),(950),(951),(952),(953),(954),(955),(956),(957),(958),(959),(960),(961),(962),(963),(964),(965),(966),(967),(968),(969),(970),(971),(972),(973),(974),(975),(976),(977),(978),(979),(980),(981),(982),(983),(984),(985),(986),(987),(988),(989),(990),(991),(992),(993),(994),(995),(996),(997),(998),(999),(1000),(1001),(1002),(1003),(1004),(1005),(1006),(1007),(1008),(1009),(1010),(1011),(1012),(1013),(1014),(1015),(1016),(1017),(1018),(1019),(1020),(1021),(1022),(1023),(1024),(1025),(1026),(1027),(1028),(1029),(1030),(1031),(1032),(1033),(1034),(1035),(1036),(1037),(1038),(1039),(1040),(1041),(1042),(1043),(1044),(1045),(1046),(1047),(1048),(1049),(1050),(1051),(1052),(1053),(1054),(1055),(1056),(1057),(1058),(1059),(1060),(1061),(1062),(1063),(1064),(1065),(1066),(1067),(1068),(1069),(1070),(1071),(1072),(1073),(1074),(1075),(1076),(1077),(1078),(1079),(1080),(1081),(1082),(1083),(1084),(1085),(1086),(1087),(1088),(1089),(1090),(1091),(1092),(1093),(1094),(1095),(1096),(1097),(1098),(1099),(1100),(1101),(1102),(1103),(1104),(1105),(1106),(1107),(1108),(1109),(1110),(1111),(1112),(1113),(1114),(1115),(1116),(1117),(1118),(1119),(1120),(1121),(1122),(1123),(1124),(1125),(1126),(1127),(1128),(1129),(1130),(1131),(1132),(1133),(1134),(1135),(1136),(1137),(1138),(1139),(1140),(1141),(1142),(1143),(1144),(1145),(1146),(1147),(1148),(1149),(1150),(1151),(1152),(1153),(1154),(1155),(1156),(1157),(1158),(1159),(1160),(1161),(1162),(1163),(1164),(1165),(1166),(1167),(1168),(1169),(1170),(1171),(1172),(1173),(1174),(1175),(1176),(1177),(1178),(1179),(1180),(1181),(1182),(1183),(1184),(1185),(1186),(1187),(1188),(1189),(1190),(1191),(1192),(1193),(1194),(1195),(1196),(1197),(1198),(1199),(1200),(1201),(1202),(1203),(1204),(1205),(1206),(1207),(1208),(1209),(1210),(1211),(1212),(1213),(1214),(1215),(1216),(1217),(1218),(1219),(1220),(1221),(1222),(1223),(1224),(1225),(1226),(1227),(1228),(1229),(1230),(1231),(1232),(1233),(1234),(1235),(1236),(1237),(1238),(1239),(1240),(1241),(1242),(1243),(1244),(1245),(1246),(1247),(1248),(1249),(1250),(1251),(1252),(1253),(1254),(1255),(1256),(1257),(1258),(1259),(1260),(1261),(1262),(1263),(1264),(1265),(1266),(1267),(1268),(1269),(1270),(1271),(1272),(1273),(1274),(1275),(1276),(1277),(1278),(1279),(1280),(1281),(1282),(1283),(1284),(1285),(1286),(1287),(1288),(1289),(1290),(1291),(1292),(1293),(1294),(1295),(1296),(1297),(1298),(1299),(1300),(1301),(1302),(1303),(1304),(1305),(1306),(1307),(1308),(1309),(1310),(1311),(1312),(1313),(1314),(1315),(1316),(1317),(1318),(1319),(1320),(1321),(1322),(1323),(1324),(1325),(1326),(1327),(1328),(1329),(1330),(1331),(1332),(1333),(1334),(1335),(1336),(1337),(1338),(1339),(1340),(1341),(1342),(1343),(1344),(1345),(1346),(1347),(1348),(1349),(1350),(1351),(1352),(1353),(1354),(1355),(1356),(1357),(1358),(1359),(1360),(1361),(1362),(1363),(1364),(1365),(1366),(1367),(1368),(1369),(1370),(1371),(1372),(1373),(1374),(1375),(1376),(1377),(1378),(1379),(1380),(1381),(1382),(1383),(1384),(1385),(1386),(1387),(1388),(1389),(1390),(1391),(1392),(1393),(1394),(1395),(1396),(1397),(1398),(1399),(1400),(1401),(1402),(1403),(1404),(1405),(1406),(1407),(1408),(1409),(1410),(1411),(1412),(1413),(1414),(1415),(1416),(1417),(1418),(1419),(1420),(1421),(1422),(1423),(1424),(1425),(1426),(1427),(1428),(1429),(1430),(1431),(1432),(1433),(1434),(1435),(1436),(1437),(1438),(1439),(1440),(1441),(1442),(1443),(1444),(1445),(1446),(1447),(1448),(1449),(1450),(1451),(1452),(1453),(1454),(1455),(1456),(1457),(1458),(1459),(1460),(1461),(1462),(1463),(1464),(1465),(1466),(1467),(1468),(1469),(1470),(1471),(1472),(1473),(1474),(1475),(1476),(1477),(1478),(1479),(1480),(1481),(1482),(1483),(1484),(1485),(1486),(1487),(1488),(1489),(1490),(1491),(1492),(1493),(1494),(1495),(1496),(1497),(1498),(1499),(1500),(1501),(1502),(1503),(1504),(1505),(1506),(1507),(1508),(1509),(1510),(1511),(1512),(1513),(1514),(1515),(1516),(1517),(1518),(1519),(1520),(1521),(1522),(1523),(1524),(1525),(1526),(1527),(1528),(1529),(1530),(1531),(1532),(1533),(1534),(1535),(1536),(1537),(1538),(1539),(1540),(1541),(1542),(1543),(1544),(1545),(1546),(1547),(1548),(1549),(1550),(1551),(1552),(1553),(1554),(1555),(1556),(1557),(1558),(1559),(1560),(1561),(1562),(1563),(1564),(1565),(1566),(1567),(1568),(1569),(1570),(1571),(1572),(1573),(1574),(1575),(1576),(1577),(1578),(1579),(1580),(1581),(1582),(1583),(1584),(1585),(1586),(1587),(1588),(1589),(1590),(1591),(1592),(1593),(1594),(1595),(1596),(1597),(1598),(1599),(1600),(1601),(1602),(1603),(1604),(1605),(1606),(1607),(1608),(1609),(1610),(1611),(1612),(1613),(1614),(1615),(1616),(1617),(1618),(1619),(1620),(1621),(1622),(1623),(1624),(1625),(1626),(1627),(1628),(1629),(1630),(1631),(1632),(1633),(1634),(1635),(1636),(1637),(1638),(1639),(1640),(1641),(1642),(1643),(1644),(1645),(1646),(1647),(1648),(1649),(1650),(1651),(1652),(1653),(1654),(1655),(1656),(1657),(1658),(1659),(1660),(1661),(1662),(1663),(1664),(1665),(1666),(1667),(1668),(1669),(1670),(1671),(1672),(1673),(1674),(1675),(1676),(1677),(1678),(1679),(1680),(1681),(1682),(1683),(1684),(1685),(1686),(1687),(1688),(1689),(1690),(1691),(1692),(1693),(1694),(1695),(1696),(1697),(1698),(1699),(1700),(1701),(1702),(1703),(1704),(1705),(1706),(1707),(1708),(1709),(1710),(1711),(1712),(1713),(1714),(1715),(1716),(1717),(1718),(1719),(1720),(1721),(1722),(1723),(1724),(1725),(1726),(1727),(1728),(1729),(1730),(1731),(1732),(1733),(1734),(1735),(1736),(1737),(1738),(1739),(1740),(1741),(1742),(1743),(1744),(1745),(1746),(1747),(1748),(1749),(1750),(1751),(1752),(1753),(1754),(1755),(1756),(1757),(1758),(1759),(1760),(1761),(1762),(1763),(1764),(1765),(1766),(1767),(1768),(1769),(1770),(1771),(1772),(1773),(1774),(1775),(1776),(1777),(1778),(1779),(1780),(1781),(1782),(1783),(1784),(1785),(1786),(1787),(1788),(1789),(1790),(1791),(1792),(1793),(1794),(1795),(1796),(1797),(1798),(1799),(1800),(1801),(1802),(1803),(1804),(1805),(1806),(1807),(1808),(1809),(1810),(1811),(1812),(1813),(1814),(1815),(1816),(1817),(1818),(1819),(1820),(1821),(1822),(1823),(1824),(1825),(1826),(1827),(1828),(1829),(1830),(1831),(1832),(1833),(1834),(1835),(1836),(1837),(1838),(1839),(1840),(1841),(1842),(1843),(1844),(1845),(1846),(1847),(1848),(1849),(1850),(1851),(1852),(1853),(1854),(1855),(1856),(1857),(1858),(1859),(1860),(1861),(1862),(1863),(1864),(1865),(1866),(1867),(1868),(1869),(1870),(1871),(1872),(1873),(1874),(1875),(1876),(1877),(1878),(1879),(1880),(1881),(1882),(1883),(1884),(1885),(1886),(1887),(1888),(1889),(1890),(1891),(1892),(1893),(1894),(1895),(1896),(1897),(1898),(1899),(1900),(1901),(1902),(1903),(1904),(1905),(1906),(1907),(1908),(1909),(1910),(1911),(1912),(1913),(1914),(1915),(1916),(1917),(1918),(1919),(1920),(1921),(1922),(1923),(1924),(1925),(1926),(1927),(1928),(1929),(1930),(1931),(1932),(1933),(1934),(1935),(1936),(1937),(1938),(1939),(1940),(1941),(1942),(1943),(1944),(1945),(1946),(1947),(1948),(1949),(1950),(1951),(1952),(1953),(1954),(1955),(1956),(1957),(1958),(1959),(1960),(1961),(1962),(1963),(1964),(1965),(1966),(1967),(1968),(1969),(1970),(1971),(1972),(1973),(1974),(1975),(1976),(1977),(1978),(1979),(1980),(1981),(1982),(1983),(1984),(1985),(1986),(1987),(1988),(1989),(1990),(1991),(1992),(1993),(1994),(1995),(1996),(1997),(1998),(1999),(2000),(2001),(2002),(2003),(2004),(2005),(2006),(2007),(2008),(2009),(2010),(2011),(2012),(2013),(2014),(2015),(2016),(2017),(2018),(2019),(2020),(2021),(2022),(2023),(2024),(2025),(2026),(2027),(2028),(2029),(2030),(2031),(2032),(2033),(2034),(2035),(2036),(2037),(2038),(2039),(2040),(2041),(2042),(2043),(2044),(2045),(2046),(2047),(2048),(2049),(2050),(2051),(2052),(2053),(2054),(2055),(2056),(2057),(2058),(2059),(2060),(2061),(2062),(2063),(2064),(2065),(2066),(2067),(2068),(2069),(2070),(2071),(2072),(2073),(2074),(2075),(2076),(2077),(2078),(2079),(2080),(2081),(2082),(2083),(2084),(2085),(2086),(2087),(2088),(2089),(2090),(2091),(2092),(2093),(2094),(2095),(2096),(2097),(2098),(2099),(2100),(2101),(2102),(2103),(2104),(2105),(2106),(2107),(2108),(2109),(2110),(2111),(2112),(2113),(2114),(2115),(2116),(2117),(2118),(2119),(2120),(2121),(2122),(2123),(2124),(2125),(2126),(2127),(2128),(2129),(2130),(2131),(2132),(2133),(2134),(2135),(2136),(2137),(2138),(2139),(2140),(2141),(2142),(2143),(2144),(2145),(2146),(2147),(2148),(2149),(2150),(2151),(2152),(2153),(2154),(2155),(2156),(2157),(2158),(2159),(2160),(2161),(2162),(2163),(2164),(2165),(2166),(2167),(2168),(2169),(2170),(2171),(2172),(2173),(2174),(2175),(2176),(2177),(2178),(2179),(2180),(2181),(2182),(2183),(2184),(2185),(2186),(2187),(2188),(2189),(2190),(2191),(2192),(2193),(2194),(2195),(2196),(2197),(2198),(2199),(2200),(2201),(2202),(2203),(2204),(2205),(2206),(2207),(2208),(2209),(2210),(2211),(2212),(2213),(2214),(2215),(2216),(2217),(2218),(2219),(2220),(2221),(2222),(2223),(2224),(2225),(2226),(2227),(2228),(2229),(2230),(2231),(2232),(2233),(2234),(2235),(2236),(2237),(2238),(2239),(2240),(2241),(2242),(2243),(2244),(2245),(2246),(2247),(2248),(2249),(2250),(2251),(2252),(2253),(2254),(2255),(2256),(2257),(2258),(2259),(2260),(2261),(2262),(2263),(2264),(2265),(2266),(2267),(2268),(2269),(2270),(2271),(2272),(2273),(2274),(2275),(2276),(2277),(2278),(2279),(2280),(2281),(2282),(2283),(2284),(2285),(2286),(2287),(2288),(2289),(2290),(2291),(2292),(2293),(2294),(2295),(2296),(2297),(2298),(2299),(2300),(2301),(2302),(2303),(2304),(2305),(2306),(2307),(2308),(2309),(2310),(2311),(2312),(2313),(2314),(2315),(2316),(2317),(2318),(2319),(2320),(2321),(2322),(2323),(2324),(2325),(2326),(2327),(2328),(2329),(2330),(2331),(2332),(2333),(2334),(2335),(2336),(2337),(2338),(2339),(2340),(2341),(2342),(2343),(2344),(2345),(2346),(2347),(2348),(2349); /*!40000 ALTER TABLE `change_id` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `change_message_id` -- DROP TABLE IF EXISTS `change_message_id`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `change_message_id` ( `s` bigint(20) unsigned NOT NULL AUTO_INCREMENT, UNIQUE KEY `s` (`s`) ) ENGINE=InnoDB AUTO_INCREMENT=253 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `change_message_id` -- LOCK TABLES `change_message_id` WRITE; /*!40000 ALTER TABLE `change_message_id` DISABLE KEYS */; INSERT INTO `change_message_id` VALUES (1),(2),(3),(4),(5),(6),(7),(8),(9),(10),(11),(12),(13),(14),(15),(16),(17),(18),(19),(20),(21),(22),(23),(24),(25),(26),(27),(28),(29),(30),(31),(32),(33),(34),(35),(36),(37),(38),(39),(40),(41),(42),(43),(44),(45),(46),(47),(48),(49),(50),(51),(52),(53),(54),(55),(56),(57),(58),(59),(60),(61),(62),(63),(64),(65),(66),(67),(68),(69),(70),(71),(72),(73),(74),(75),(76),(77),(78),(79),(80),(81),(82),(83),(84),(85),(86),(87),(88),(89),(90),(91),(92),(93),(94),(95),(96),(97),(98),(99),(100),(101),(102),(103),(104),(105),(106),(107),(108),(109),(110),(111),(112),(113),(114),(115),(116),(117),(118),(119),(120),(121),(122),(123),(124),(125),(126),(127),(128),(129),(130),(131),(132),(133),(134),(135),(136),(137),(138),(139),(140),(141),(142),(143),(144),(145),(146),(147),(148),(149),(150),(151),(152),(153),(154),(155),(156),(157),(158),(159),(160),(161),(162),(163),(164),(165),(166),(167),(168),(169),(170),(171),(172),(173),(174),(175),(176),(177),(178),(179),(180),(181),(182),(183),(184),(185),(186),(187),(188),(189),(190),(191),(192),(193),(194),(195),(196),(197),(198),(199),(200),(201),(202),(203),(204),(205),(206),(207),(208),(209),(210),(211),(212),(213),(214),(215),(216),(217),(218),(219),(220),(221),(222),(223),(224),(225),(226),(227),(228),(229),(230),(231),(232),(233),(234),(235),(236),(237),(238),(239),(240),(241),(242),(243),(244),(245),(246),(247),(248),(249),(250),(251),(252); /*!40000 ALTER TABLE `change_message_id` ENABLE KEYS */; UNLOCK TABLES; -- -- Table structure for table `change_messages` -- DROP TABLE IF EXISTS `change_messages`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `change_messages` ( `author_id` int(11) DEFAULT NULL, `written_on` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, `message` text COLLATE utf8_unicode_ci, `patchset_change_id` int(11) DEFAULT NULL, `patchset_patch_set_id` int(11) DEFAULT NULL, `change_id` int(11) NOT NULL DEFAULT '0', `uuid` varchar(40) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '', `tag` varchar(255) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL, PRIMARY KEY (`change_id`,`uuid`), KEY `change_messages_byPatchset` (`patchset_change_id`,`patchset_patch_set_id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- -- Dumping data for table `change_messages` -- LOCK TABLES `change_messages` WRITE; /*!40000 ALTER TABLE `change_messages` DISABLE KEYS */; INSERT INTO `change_messages` VALUES (6,'2015-03-13 14:43:35','Change has been successfully merged into the git repository.',2,1,2,'9af53d3f_9f30f3e9',NULL),(15,'2015-03-13 14:30:25','Patch Set 1: Code-Review+2',2,1,2,'9af53d3f_ff393fd9',NULL),(6,'2015-03-12 15:32:43','Uploaded patch set 1.',2,1,2,'daeb3561_81ff7a01',NULL),(15,'2015-03-12 22:58:10','Patch Set 1: Code-Review+1',2,1,2,'daeb3561_c11c626d',NULL),(6,'2015-03-12 15:53:38','Patch Set 1: Code-Review+2',3,1,3,'daeb3561_01136a5d',NULL),(6,'2015-03-12 15:36:56','Topic changed from sam/python-wsgi to sam/lorry-controller-without-morph',3,1,3,'daeb3561_210e6e35',NULL),(6,'2015-03-12 15:33:50','Uploaded patch set 1.',3,1,3,'daeb3561_61047615',NULL),(6,'2015-03-12 16:46:40','Abandoned\n\nThis is a duplicate of change #2',3,1,3,'daeb3561_e10f662d',NULL),(6,'2015-03-13 14:54:08','Change has been successfully merged into the git repository.',4,2,4,'7afa4931_3e09e92c',NULL),(6,'2015-03-13 14:53:45','Patch Set 2: Code-Review+2',4,2,4,'7afa4931_5e04b514',NULL),(6,'2015-03-13 14:50:46','Uploaded patch set 2.',4,2,4,'7afa4931_7eff7102',NULL),(15,'2015-03-13 14:42:54','Patch Set 1: Code-Review+2',4,1,4,'9af53d3f_bf33b7f5',NULL),(6,'2015-03-12 15:33:50','Uploaded patch set 1.',4,1,4,'daeb3561_4109722b',NULL),(15,'2015-03-12 23:00:00','Patch Set 1: Code-Review+1',4,1,4,'daeb3561_a1195e7b',NULL),(15,'2015-03-12 23:17:03','Abandoned\n\nI will send this as part of the pre_python3 instead',5,1,5,'daeb3561_013a4acd',NULL),(15,'2015-03-12 23:09:27','Uploaded patch set 1.',5,1,5,'daeb3561_81265ab9',NULL),(15,'2015-03-16 12:44:19','Change has been successfully merged into the git repository.',6,2,6,'7afa4931_be33b9f5',NULL),(15,'2015-03-13 14:28:55','Uploaded patch set 2.',6,2,6,'9af53d3f_5f2b8b82',NULL),(6,'2015-03-13 14:35:34','Patch Set 2: Code-Review+2\n\nLooks fine. Changing print to sys.stdout.write would be a different way to solve this.',6,2,6,'9af53d3f_df367be7',NULL),(15,'2015-03-12 23:16:19','Uploaded patch set 1.',6,1,6,'daeb3561_612b5683',NULL),(6,'2015-03-13 16:24:48','Patch Set 2:\n\nI\'ve not tested this but it seems correct to me',7,2,7,'7afa4931_3e20c99a',NULL),(6,'2015-03-13 16:24:38','Patch Set 2: Code-Review+2',7,2,7,'7afa4931_5e2b9582',NULL),(15,'2015-03-16 12:47:10','Change has been successfully merged into the git repository.',7,2,7,'7afa4931_9e30fde9',NULL),(15,'2015-03-13 14:28:55','Uploaded patch set 2.',7,2,7,'9af53d3f_3f20c79a',NULL),(15,'2015-03-12 23:16:19','Uploaded patch set 1.',7,1,7,'daeb3561_4120529b',NULL),(15,'2015-03-16 16:36:28','Topic changed from copyright to pre_python3',8,3,8,'7afa4931_1e73cdb2',NULL),(15,'2015-03-17 11:09:44','Change has been successfully merged into the git repository.',8,3,8,'7afa4931_1eaaadd4',NULL),(15,'2015-03-16 16:35:24','Uploaded patch set 3.',8,3,8,'7afa4931_3e6e89ca',NULL),(6,'2015-03-17 10:22:55','Patch Set 3: Code-Review+2\n\nLooks good to me',8,3,8,'7afa4931_5ea035f4',NULL),(15,'2015-03-13 14:28:55','Uploaded patch set 2.',8,2,8,'9af53d3f_1f2503ab',NULL),(15,'2015-03-12 23:16:19','Uploaded patch set 1.',8,1,8,'daeb3561_21254eab',NULL),(11,'2015-03-13 15:59:32','Topic set to Git Review',9,1,9,'7afa4931_9e191d7c',NULL),(11,'2015-03-13 12:05:20','Patch Set 1: Code-Review+1',9,1,9,'9af53d3f_1f0e2335',NULL),(11,'2015-03-13 12:00:54','Restored',9,1,9,'9af53d3f_3f09e72c',NULL),(11,'2015-03-13 11:59:10','Abandoned',9,1,9,'9af53d3f_5f04ab14',NULL),(11,'2015-03-13 14:15:50','Patch Set 1: Code-Review-1\n\n(1 comment)',9,1,9,'9af53d3f_7f264fbc',NULL),(11,'2015-03-13 11:54:43','Patch Set 1: Code-Review-1',9,1,9,'9af53d3f_7fff6f02',NULL),(11,'2015-03-13 14:06:47','Patch Set 1: Code-Review+1',9,1,9,'9af53d3f_bf1cd76b',NULL),(11,'2015-03-13 12:29:58','Patch Set 1: Code-Review-1',9,1,9,'9af53d3f_df0f9b2d',NULL),(11,'2015-03-13 12:27:10','Patch Set 1: -Code-Review',9,1,9,'9af53d3f_ff125f57',NULL),(11,'2015-03-13 11:23:54','Uploaded patch set 1.',9,1,9,'baf0414d_80ff7601',NULL),(7,'2015-03-20 11:00:23','Abandoned\n\n-1ed by the Author',9,1,9,'da141535_b94abf53',NULL),(11,'2015-03-18 14:40:50','Patch Set 1: Code-Review-1',10,1,10,'1a014df3_1b73dbb2',NULL),(7,'2015-03-18 13:48:08','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI believe that this file is not needed. But I may be wrong',10,1,10,'1a014df3_db3d73bd',NULL),(11,'2015-03-13 15:17:00','Uploaded patch set 1.',10,1,10,'7afa4931_1e0e2d35',NULL),(11,'2015-03-13 15:59:10','Topic changed from Exciting Topic to Git Review',10,1,10,'7afa4931_be1cd96b',NULL),(11,'2015-03-13 15:58:43','Topic changed from master to Exciting Topic',10,1,10,'7afa4931_de0fa52d',NULL),(15,'2015-03-13 15:20:01','Patch Set 1:\n\nWhat is this for?',10,1,10,'7afa4931_fe126157',NULL),(7,'2015-03-20 10:59:56','Abandoned\n\nAlready has a -2',10,1,10,'da141535_d93d73bd',NULL),(6,'2015-03-17 14:56:26','Change has been successfully merged into the git repository.',11,1,11,'7afa4931_1e818d4a',NULL),(15,'2015-03-17 11:09:22','Patch Set 1: Code-Review+2',11,1,11,'7afa4931_3ea56904',NULL),(6,'2015-03-13 16:24:12','Uploaded patch set 1.',11,1,11,'7afa4931_7e2651bc',NULL),(15,'2015-03-13 19:07:59','Uploaded patch set 1.',12,1,12,'7afa4931_1e250dab',NULL),(15,'2015-03-16 13:07:52','Uploaded patch set 2.',12,2,12,'7afa4931_1e5ced24',NULL),(6,'2015-03-16 12:50:41','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThe address in one of the files is messed up somehow. I think it\'s fine other than that.',12,1,12,'7afa4931_3e57a904',NULL),(15,'2015-03-16 16:30:05','Change has been successfully merged into the git repository.',12,2,12,'7afa4931_5e795592',NULL),(6,'2015-03-16 15:07:57','Patch Set 2: Code-Review+2',12,2,12,'7afa4931_9e47dd4b',NULL),(18,'2015-03-18 13:05:53','Patch Set 2: Patch Set 1 was rebased',13,1,13,'1a014df3_3b57b704',NULL),(15,'2015-03-18 14:27:30','Patch Set 2: Code-Review+1',13,2,13,'1a014df3_3b6e97ca',NULL),(6,'2015-03-26 10:44:24','Abandoned\n\nI have set this to \'abandonded\' state because it has been merged outside of Gerrit.',13,2,13,'5a202591_f5715878',NULL),(33,'2015-03-25 19:48:05','Patch Set 2: Code-Review+1\n\nConditions I noted on ml are satisfied, unconditional +1',13,2,13,'7a23299d_7604307e',NULL),(33,'2015-03-25 20:08:53','Patch Set 2: -Code-Review\n\nThis has several +1s, the series on the mailing list associated with this change has been merged.',13,2,13,'7a23299d_d6f42489',NULL),(6,'2015-03-16 12:44:17','Patch Set 1: Code-Review+1\n\nI agree with the premise: we should change the meaning of the \'build-depends\' field in definitions to not implicitly include \'transitive\' dependencies. I\'m ok with this being merged but it introduces inconsistency. The existing meaning of build-depends may be confusing but at least we use it consistently.\n\nIf we are to change the meaning of the field then we will need a migration script, so users of other definitions repos can adapt their strata to use the new format build-depends field.\n\nSuch a script would add build-depends to some chunks that weren\'t actually needed. But it\'s needed to honour our plan for definitions versioning.',13,1,13,'7afa4931_de3685e7',NULL),(15,'2015-03-16 14:08:52','Patch Set 1: Code-Review+1',13,1,13,'7afa4931_de3d65bd',NULL),(18,'2015-03-14 13:12:36','Uploaded patch set 1.',13,1,13,'7afa4931_fe3941d9',NULL),(32,'2015-03-24 16:05:20','Patch Set 2: Code-Review+1\n\nWhile I understand that morph currently doesn\'t need this, I do agree that it makes things clearer for understanding the flow in build-essential.',13,2,13,'9a0e1d27_7704307e',NULL),(6,'2015-03-24 17:11:40','Patch Set 2: Code-Review+1\n\nThinking about it, I\'d be OK with this being merged if the description of build-essential was updated to note that the \'build-depends\' field is used in a way that is inconsistent with all the other definition files, and why this was done.',13,2,13,'9a0e1d27_7712f0b5',NULL),(7,'2015-03-18 13:51:00','Patch Set 2:\n\nThe code looks ok, but I don\'t feel confident enough to merge this change. Did we agree on doing this?',14,2,14,'1a014df3_bb4aa753',NULL),(29,'2015-03-30 20:08:59','Patch Set 2: Code-Review-2\n\n> > My gut feeling is that --verbose is *NOT* the place for all the\n > > build output to suddenly end up on the terminal. I personally\n > > build with --verbose all the time but to have build output from\n > > chunk builds would make that output nearly useless to me.\n > \n > I\'m curious here: for what do you use the output of morph -v rigth\n > no? Im curious because nn my use of morph I normally have to fix\n > issues with packages not being build correctly, not issues in morph\n > itself\n > \n > > Given there\'s already a flag for ensuring compilation output goes\n > > to the terminal this seems redundant and I\'d drop it.\n > \n > yeah, but I think we can agree that \"--build-log-on-stdout\" is\n > pretty unintuitive and not something that uses morph will guess (in\n > opposition with the very standard -v/--verbose)\n\n--build-log-on-stdout was not written to be used by users of morph,\nit is an internal option used by distbuild to transfer logs from distbuild\nworkers over to the initiator.\n\nRegardless of what happens here, --build-log-on-stdout should remain.\n\nWhilst we\'re here, it would be nice if we provided a nicer\ninterface for accessing build logs from the cachedir.\n\nI also use --verbose by default, but have specifically disabled\nbuild-log-on-stdout because it was too much noise.\n\nI\'m not saying we can\'t provide a more intuitive alias for\n--build-log-on-stdout for the user, I am however agreeing with\nDaniel that this should not be added into --verbose.',14,2,14,'3a3291f1_0cecd7c6',NULL),(15,'2015-03-30 19:15:10','Patch Set 2:\n\n> My gut feeling is that --verbose is *NOT* the place for all the\n > build output to suddenly end up on the terminal. I personally\n > build with --verbose all the time but to have build output from\n > chunk builds would make that output nearly useless to me.\n \nI\'m curious here: for what do you use the output of morph -v rigth no? Im curious because nn my use of morph I normally have to fix issues with packages not being build correctly, not issues in morph itself\n\n > Given there\'s already a flag for ensuring compilation output goes\n > to the terminal this seems redundant and I\'d drop it.\n\nyeah, but I think we can agree that \"--build-log-on-stdout\" is pretty unintuitive and not something that uses morph will guess (in opposition with the very standard -v/--verbose)',14,2,14,'3a3291f1_6c8fdb24',NULL),(15,'2015-04-06 18:29:10','Patch Set 4:\n\n(1 comment)\n\nAll the test seems to pass now',14,4,14,'3a4b7175_045dd6e9',NULL),(15,'2015-04-06 18:28:06','Uploaded patch set 5.',14,5,14,'3a4b7175_2458d2f9',NULL),(33,'2015-04-06 17:18:36','Patch Set 4: Code-Review-1\n\n(2 comments)\n\nHey, I much prefer the name of this option,\nlooking at the code there are some changes that would break existing stuff though',14,4,14,'3a4b7175_24ca12a2',NULL),(29,'2015-04-06 19:43:01','Patch Set 5: -Code-Review\n\n(remove veto)',14,5,14,'3a4b7175_64d36a39',NULL),(15,'2015-04-06 13:22:40','Uploaded patch set 3.',14,3,14,'3a4b7175_64ffea02',NULL),(33,'2015-04-06 19:40:45','Patch Set 5: Code-Review+1\n\n(1 comment)',14,5,14,'3a4b7175_a4196224',NULL),(33,'2015-04-06 15:10:12','Patch Set 3: Code-Review-1\n\nHey, thanks for the change. :)\n\nIt\'s hard not to turn this one into a bike shed,\nbut having argued against the naming of an option like\n--build-log-on-stdout it strikes me as odd that you\'re now\nadding a very similar --morph-log-on-stdout, why wouldn\'t\nthis just be --debug ?\n\nI think I\'d be up for this change if --morph-log-on-stdout\nwas --debug with -d as the flag for it.\n\nLet the bike shedding commence!',14,3,14,'3a4b7175_a44a8253',NULL),(15,'2015-04-06 16:52:02','Uploaded patch set 4.',14,4,14,'3a4b7175_a48f2275',NULL),(37,'2015-04-22 10:20:26','Patch Set 8: Patch Set 7 was rebased',14,7,14,'5a7ca5a3_9561e4d5',NULL),(37,'2015-04-22 10:20:26','Change has been successfully rebased as aa6dfcbb70c03dfeb3f9af02283aa1ab83667162',14,7,14,'5a7ca5a3_b55e6011',NULL),(37,'2015-04-22 10:20:22','Patch Set 7: Code-Review+2\n\nI don\'t buy the argument that it\'s a change in semantics, but for the sake of keeping things moving I\'m +2ing and merging.',14,7,14,'5a7ca5a3_f564d8e6',NULL),(15,'2015-04-12 14:31:05','Uploaded patch set 7.',14,7,14,'7a96c907_5e9b75c9',NULL),(15,'2015-04-12 14:33:05','Patch Set 5:\n\n(5 comments)',14,5,14,'7a96c907_7ea0b1f4',NULL),(15,'2015-04-12 14:30:12','Uploaded patch set 6.',14,6,14,'7a96c907_be5e3911',NULL),(8,'2015-03-17 09:32:28','Patch Set 2: Code-Review+1',14,2,14,'7afa4931_7e9bf1c9',NULL),(16,'2015-03-17 15:41:36','Patch Set 2: Code-Review+1',14,2,14,'7afa4931_7ee9b119',NULL),(15,'2015-03-16 18:12:04','Uploaded patch set 2.',14,2,14,'7afa4931_9e5ebd11',NULL),(15,'2015-03-16 13:34:03','Uploaded patch set 1.',14,1,14,'7afa4931_fe402137',NULL),(32,'2015-03-24 16:04:13','Patch Set 2: Code-Review-1\n\nMy gut feeling is that --verbose is *NOT* the place for all the build output to suddenly end up on the terminal. I personally build with --verbose all the time but to have build output from chunk builds would make that output nearly useless to me.\n\nGiven there\'s already a flag for ensuring compilation output goes to the terminal this seems redundant and I\'d drop it.',14,2,14,'9a0e1d27_97d7c4ed',NULL),(6,'2015-04-10 11:25:15','Patch Set 5:\n\n(3 comments)',14,5,14,'ba8cc1f7_006586e0',NULL),(37,'2015-04-10 10:26:22','Patch Set 5:\n\n(1 comment)\n\nFix the option help string and you have a +1 from me.',14,5,14,'ba8cc1f7_604d7272',NULL),(6,'2015-04-10 11:08:08','Patch Set 5:\n\nI agree with the goal: to make --verbose useful to users who want detailed info on potentially slow operations that Morph is doing, without drowning them in debugging information.\n\nBut I think having --debug and a log file shows a bit of a design flaw. Really, --debug, should just echo whatever goes to the log file on stdout, I think. There seems to be no way to tell cliapp \'write log info to the log file and to stdout at the same time\', so the --debug flag may indeed be useful.\n\nI agree with Richard Maw\'s comments too.',14,5,14,'ba8cc1f7_80799695',NULL),(29,'2015-04-10 11:27:54','Patch Set 5:\n\n(1 comment)',14,5,14,'ba8cc1f7_c05ebe12',NULL),(6,'2015-03-18 16:56:15','Change has been successfully merged into the git repository.',15,1,15,'1a014df3_7b9bffc9',NULL),(15,'2015-03-18 16:20:20','Patch Set 1: Code-Review+2',15,1,15,'1a014df3_db6453e7',NULL),(6,'2015-03-16 15:05:57','Uploaded patch set 1.',15,1,15,'7afa4931_be4a9953',NULL),(8,'2015-03-16 17:04:47','Patch Set 1: Code-Review+1',15,1,15,'7afa4931_be6179d5',NULL),(15,'2015-03-17 11:12:29','Patch Set 1: Code-Review+1',15,1,15,'7afa4931_feaee1e6',NULL),(8,'2015-03-18 12:44:52','Change has been successfully merged into the git repository.',16,1,16,'1a014df3_9b300bea',NULL),(15,'2015-03-18 11:57:51','Patch Set 1: Code-Review+2',16,1,16,'1a014df3_bb33c7f5',NULL),(6,'2015-03-16 16:09:02','Uploaded patch set 1.',16,1,16,'7afa4931_7e74119c',NULL),(8,'2015-03-16 17:01:47','Patch Set 1: Code-Review+1',16,1,16,'7afa4931_de6445e7',NULL),(15,'2015-03-17 11:12:54','Patch Set 1: Code-Review+1',16,1,16,'7afa4931_deab25d5',NULL),(16,'2015-03-17 15:03:50','Patch Set 1: Code-Review+1',16,1,16,'7afa4931_fe95c188',NULL),(15,'2015-05-26 14:41:14','Patch Set 1:\n\n> Given the lack of activity on this change, the lack of consensus on\n > whether we want to do it, and the fact that it doesn\'t make the\n > change universally, I\'m -2ing this patch series.\n > Javier can decide whether to drop it, or fix it to handle every\n > `.iter`.\n\nThanks for the review!\nI will try to complete the patch and resubmit as soon as possible',17,1,17,'1acb0d3e_cb4a5527',NULL),(37,'2015-03-26 17:46:56','Patch Set 1:\n\nI think that using .iterkeys() on a dict is nicer, but I\'m not married to the idea. I\'d have thought that iterkeys() would be something that 2to3 could handle automatically though.',17,1,17,'3a1d315d_94e34433',NULL),(37,'2015-04-22 10:43:40','Patch Set 1: Code-Review-2\n\nGiven the lack of activity on this change, the lack of consensus on whether we want to do it, and the fact that it doesn\'t make the change universally, I\'m -2ing this patch series.\nJavier can decide whether to drop it, or fix it to handle every `.iter`.',17,1,17,'5a7ca5a3_b58c2081',NULL),(16,'2015-03-17 15:25:19','Patch Set 1:\n\n(2 comments)\n\nThere are a couple of iterkeys() left in morphloader, and I think its used in morphlib/plugins/deploy_plugin.py a couple of times too. I guess these should be changed too?',17,1,17,'7afa4931_9e8c7d81',NULL),(15,'2015-03-16 16:46:01','Uploaded patch set 1.',17,1,17,'7afa4931_fe6701e9',NULL),(37,'2015-05-27 14:31:44','Patch Set 1: Code-Review-1\n\nI\'m dropping my -2 in favour of a -1, so the next version of this series isn\'t automatically blocked.',17,1,17,'fab9d9a7_4ad09353',NULL),(15,'2015-03-18 17:42:09','Change has been successfully merged into the git repository.',18,1,18,'1a014df3_1baabbd4',NULL),(15,'2015-03-18 17:42:06','Patch Set 1: Code-Review+2\n\nI will review this +2 as it has already a +3 (Adam here and Sam and Richard in the ml)',18,1,18,'1a014df3_3ba57704',NULL),(7,'2015-03-18 14:01:31','Patch Set 1:\n\n(1 comment)\n\nI added some comments in the patch.',18,1,18,'1a014df3_7b741f9c',NULL),(16,'2015-03-17 15:49:26','Patch Set 1: Code-Review+1',18,1,18,'7afa4931_5eeef523',NULL),(15,'2015-03-17 11:25:08','Uploaded patch set 1.',18,1,18,'7afa4931_beb8592b',NULL),(15,'2015-03-18 17:42:38','Change has been successfully merged into the git repository.',19,1,19,'1a014df3_bbb8672b',NULL),(15,'2015-03-18 17:42:31','Patch Set 1:\n\nI will review this +2 as it has already a +3 (Adam here and Sam and Richard in the ml)',19,1,19,'1a014df3_dbab33d5',NULL),(15,'2015-03-18 17:42:22','Patch Set 1: Code-Review+2',19,1,19,'1a014df3_fbaeefe6',NULL),(16,'2015-03-17 15:49:31','Patch Set 1: Code-Review+1',19,1,19,'7afa4931_3ef3290c',NULL),(15,'2015-03-17 11:25:08','Uploaded patch set 1.',19,1,19,'7afa4931_9eb59d33',NULL),(15,'2015-03-17 14:22:27','Change has been successfully merged into the git repository.',20,1,20,'7afa4931_3e7c4972',NULL),(6,'2015-03-17 14:21:17','Patch Set 1: Code-Review+2',20,1,20,'7afa4931_5e871562',NULL),(16,'2015-03-17 14:19:39','Uploaded patch set 1.',20,1,20,'7afa4931_7e82d153',NULL),(7,'2015-03-18 13:45:51','Patch Set 1:\n\nThanks Sam for pointing that out, I\'ll try this new version and see if it works',21,1,21,'1a014df3_1b5cfb24',NULL),(6,'2015-03-18 10:28:56','Patch Set 1: Code-Review+1\n\nThis is used only as part of the GENIVI release process right now, I think. Pedro mostly does GENIVI releases so I\'d like him to check this is OK before merging',21,1,21,'1a014df3_db0fb32d',NULL),(15,'2015-03-17 17:04:21','Uploaded patch set 1.',21,1,21,'5af74547_7dff7702',NULL),(15,'2015-03-23 14:16:38','Change has been successfully merged into the git repository.',21,1,21,'9a0e1d27_5787ec61',NULL),(7,'2015-03-23 13:29:30','Patch Set 1: Code-Review+2\n\nOur licensecheck script still works with this version',21,1,21,'9a0e1d27_7782f053',NULL),(6,'2015-03-18 09:58:24','Patch Set 2: Code-Review+2',22,2,22,'1a014df3_1b0e3b35',NULL),(15,'2015-03-17 21:35:46','Uploaded patch set 2.',22,2,22,'1a014df3_5b04c314',NULL),(9,'2015-03-17 17:59:48','Patch Set 1: Code-Review-1\n\nthis file wasn\'t added in 2011. Use the actual date it was added in the copyright header.',22,1,22,'1a014df3_7bff7f02',NULL),(15,'2015-03-18 11:38:15','Change has been successfully merged into the git repository.',22,2,22,'1a014df3_fb394fd9',NULL),(15,'2015-03-17 17:40:08','Uploaded patch set 1.',22,1,22,'3a045101_7cff7902',NULL),(16,'2015-03-18 09:36:56','Uploaded patch set 1.',23,1,23,'1a014df3_3b09f72c',NULL),(15,'2015-03-18 11:09:26','Change has been successfully merged into the git repository.',23,1,23,'1a014df3_3b20d79a',NULL),(6,'2015-03-18 09:59:01','Patch Set 1: Code-Review+2',23,1,23,'1a014df3_fb126f57',NULL),(6,'2015-03-18 11:34:00','Change has been successfully merged into the git repository.',24,2,24,'1a014df3_1b251bab',NULL),(15,'2015-03-18 11:08:35','Patch Set 2: Code-Review+2',24,2,24,'1a014df3_5b2ba382',NULL),(8,'2015-03-18 11:04:04','Patch Set 2: Code-Review+1',24,2,24,'1a014df3_7b265fbc',NULL),(6,'2015-03-18 10:50:12','Patch Set 2: Commit message was updated',24,2,24,'1a014df3_9b192b7c',NULL),(6,'2015-03-18 10:48:33','Uploaded patch set 1.',24,1,24,'1a014df3_bb1ce76b',NULL),(24,'2015-03-18 14:03:33','Patch Set 1:\n\nThe Qt4 strata depend on the proper Xserver xcb based support that we used to have. I\'m not sure if it can be built with Wayland or XWayland.\n\nPeople are still using Qt4, and it is not unsupported. I don\'t know how many Baserock users still want to use Qt4. I added Qt4 because at the time Qt4 support was wanted (for Genivi?).\n\nI\'m voting 0, because I don\'t have enough information about what Baserock users want.',25,1,25,'1a014df3_5b796392',NULL),(15,'2015-03-18 11:43:06','Uploaded patch set 1.',25,1,25,'1a014df3_db3693e7',NULL),(25,'2015-03-18 16:06:30','Patch Set 1:\n\nVoting 0 as well, would prefer to see this fixed rather than just deleting it.',25,1,25,'1a014df3_fb670fe9',NULL),(15,'2015-04-22 10:20:05','Abandoned\n\nSeems Qt4 systems are still of interest',25,1,25,'5a7ca5a3_d5675ce9',NULL),(42,'2015-04-22 10:12:54','Patch Set 1: Code-Review-1\n\nPerhaps this patch should be dropped then?',25,1,25,'5a7ca5a3_f53db8bc',NULL),(15,'2015-03-18 18:19:28','Patch Set 1: Code-Review+2',26,1,26,'1a014df3_1b819b4a',NULL),(7,'2015-03-18 13:03:42','Patch Set 1: Code-Review+1\n\nI haven\'t tested that it builds without depending on foundation, but I trust you!',26,1,26,'1a014df3_5b528314',NULL),(6,'2015-03-18 12:59:24','Uploaded patch set 1.',26,1,26,'1a014df3_7b4d3f72',NULL),(15,'2015-03-18 18:19:31','Change has been successfully merged into the git repository.',26,1,26,'1a014df3_fb95cf88',NULL),(24,'2015-03-18 17:38:38','Patch Set 1:\n\nI did mention that I had tested this patch when I submitted it to the baserock-dev mailing list, but that comment isn\'t here on gerrit:\n\nThis patch updates the version of cmake in the core stratum from\nv2.8.12.2 to v3.2.1. I have built and run an image based on this\nversion of cmake without problem.',27,1,27,'1a014df3_5ba043f4',NULL),(15,'2015-03-18 17:46:23','Change has been successfully merged into the git repository.',27,1,27,'1a014df3_7b82df53',NULL),(6,'2015-03-18 16:55:58','Patch Set 1: Code-Review+1\n\nLooks fine, i\'ve not tested though',27,1,27,'1a014df3_9b5ecb11',NULL),(15,'2015-03-18 17:46:20','Patch Set 1: Code-Review+2',27,1,27,'1a014df3_9bb5ab33',NULL),(24,'2015-03-18 16:48:24','Uploaded patch set 1.',27,1,27,'1a014df3_bb6187d5',NULL),(15,'2015-03-18 18:11:06','Patch Set 1: Code-Review+1',28,1,28,'1a014df3_3b7c5772',NULL),(6,'2015-03-18 18:03:27','Uploaded patch set 1.',28,1,28,'1a014df3_5b872362',NULL),(8,'2015-03-19 10:12:00','Change has been successfully merged into the git repository.',28,1,28,'1a014df3_9b8c8b81',NULL),(8,'2015-03-19 10:11:38','Patch Set 1: Code-Review+2',28,1,28,'1a014df3_bb8f4775',NULL),(8,'2015-03-19 10:11:25','Patch Set 1: Code-Review+1',28,1,28,'1a014df3_db92139f',NULL),(7,'2015-03-19 12:17:26','Abandoned\n\njust a test',29,1,29,'1a014df3_5bee0324',NULL),(7,'2015-03-19 12:16:49','Uploaded patch set 1.',29,1,29,'1a014df3_7be9bf19',NULL),(6,'2015-03-19 13:04:41','Uploaded patch set 2.',30,2,30,'1a014df3_1bf87be4',NULL),(6,'2015-03-19 12:42:01','Uploaded patch set 1.',30,1,30,'1a014df3_3bf3370c',NULL),(16,'2015-03-19 14:14:27','Patch Set 2: Code-Review+1',30,2,30,'fa0f191f_7aff7902',NULL),(15,'2015-03-19 14:31:17','Change has been successfully merged into the git repository.',30,2,30,'fa0f191f_ba1cf16b',NULL),(15,'2015-03-19 14:31:14','Patch Set 2: Code-Review+2',30,2,30,'fa0f191f_da0fa52d',NULL),(18,'2015-03-19 14:26:09','Change has been successfully merged into the git repository.',31,1,31,'fa0f191f_1a0e3d35',NULL),(6,'2015-03-19 14:25:59','Patch Set 1: Code-Review+2',31,1,31,'fa0f191f_3a09012d',NULL),(7,'2015-03-19 14:24:50','Uploaded patch set 1.',31,1,31,'fa0f191f_5a04b514',NULL),(15,'2015-03-19 14:26:45','Patch Set 1:\n\nCan you explain the reason to use 1.0.1* instead upgrade to 1.0.2*?',31,1,31,'fa0f191f_fa126957',NULL),(15,'2015-03-31 09:48:43','Patch Set 3: Patch Set 2 was rebased',32,2,32,'1a2f8d8d_6b0581c1',NULL),(15,'2015-03-31 09:46:06','Patch Set 1:\n\n> While the commit looks sane, updating git is risky since we have a\n > non-trivial number of things which rely on git\'s interface.\n > \n > Please verify that you can (a) build a demonstrably functional\n > Trove and (b) build a demonstrably functional build system using\n > this version of git.\n\nI do not have idea how to \"build a demonstrably functional Trove\". I sent this patch because is the git version I\'m using in some of the systems I built and everything seems to build correctly',32,1,32,'1a2f8d8d_8b68ad88',NULL),(6,'2015-03-31 10:21:23','Patch Set 3: Code-Review+1\n\nIf Morph\'s test suite passes and a system builds with this version of Git, I\'m happy with upgrading. I\'ve never seen Trove break due to a Git upgrade before. I have seen Morph and the \'core\' stratum both break due to Git updates before.',32,3,32,'1a2f8d8d_cbf595cc',NULL),(15,'2015-04-06 17:01:20','Uploaded patch set 5.',32,5,32,'3a4b7175_04f836e4',NULL),(15,'2015-04-06 17:00:06','Uploaded patch set 4.',32,4,32,'3a4b7175_44ee2e24',NULL),(15,'2015-03-30 11:26:37','Uploaded patch set 2.',32,2,32,'5a2585a7_6d823554',NULL),(32,'2015-03-24 16:02:20','Patch Set 1:\n\nWhile the commit looks sane, updating git is risky since we have a non-trivial number of things which rely on git\'s interface.\n\nPlease verify that you can (a) build a demonstrably functional Trove and (b) build a demonstrably functional build system using this version of git.',32,1,32,'9a0e1d27_b7dac815',NULL),(15,'2015-04-29 10:07:28','Abandoned\n\nA more recent version (2.3.7) submitted in another change',32,5,32,'bada0100_b34502b5',NULL),(8,'2015-04-28 18:56:42','Patch Set 5: Code-Review-2\n\nI\'ve tested git 2.3.7, could you please abandon this patch?',32,5,32,'bada0100_b35e6211',NULL),(6,'2015-03-19 16:22:38','Patch Set 1:\n\nHow have you tested this?',32,1,32,'da141535_5904c314',NULL),(15,'2015-03-19 16:15:05','Uploaded patch set 1.',32,1,32,'da141535_79ff8702',NULL),(15,'2015-03-27 14:37:10','Patch Set 2:\n\nIts lakely that those users upgrade to the kernel version offers when they update they systems. But ok, I will update the patch',33,2,33,'1a1a2d67_337c8872',NULL),(35,'2015-03-26 15:39:31','Patch Set 2: Code-Review-1\n\nApparently that\'s the case, -1, people are using baserock on systems with < 3.16 kernels',33,2,33,'3a1d315d_1425f4aa',NULL),(35,'2015-03-26 15:37:04','Patch Set 2:\n\nSo does this mean you couldn\'t use a baserock system on a 3.10 kernel (for example)?',33,2,33,'3a1d315d_742668bc',NULL),(6,'2015-03-30 17:25:18','Change has been successfully rebased as 82c7f2a156a43b4cfc34b2cac8c2267961a82749',33,4,33,'3a3291f1_0ce29703',NULL),(6,'2015-03-30 17:25:18','Patch Set 5: Patch Set 4 was rebased',33,4,33,'3a3291f1_2cdd5343',NULL),(6,'2015-03-30 17:25:07','Patch Set 4: Code-Review+2',33,4,33,'3a3291f1_4cd89f53',NULL),(15,'2015-03-26 13:41:36','Patch Set 2:\n\nAs I said in a comment before, No idea about the performance gain, I made this change after reading a note in the glibc docs: http://www.gnu.org/software/libc/manual/html_node/Configuring-and-compiling.html',33,2,33,'5a202591_3526b069',NULL),(7,'2015-03-30 10:46:00','Patch Set 4: Code-Review+1',33,4,33,'5a2585a7_6d4d9572',NULL),(7,'2015-03-23 14:52:59','Patch Set 2:\n\nHow faster is with this change?',33,2,33,'9a0e1d27_b78f6875',NULL),(6,'2015-03-19 16:42:50','Patch Set 1: Code-Review-1\n\n3.18 doesn\'t work on Calxeda Highbank and I still need to support Baserock on this system for the time being.\n\nI\'ll be testing a modern system on a Calxeda server very soon, maybe it\'s possible to get 3.18 to run on there, but I don\'t know.\n\nDo you know how much faster this would actually make things?',33,1,33,'da141535_190e4b35',NULL),(15,'2015-03-19 16:37:29','Uploaded patch set 1.',33,1,33,'da141535_39090f2d',NULL),(15,'2015-03-19 17:01:17','Patch Set 1:\n\nAny idea what is the most recent linux version that runs in Highbank?\n\nNo idea about the perfomance gain, I made ths change after reading a note in the glibc docs: http://www.gnu.org/software/libc/manual/html_node/Configuring-and-compiling.html',33,1,33,'da141535_792667bc',NULL),(15,'2015-03-20 11:10:16','Uploaded patch set 2.',33,2,33,'da141535_9947fb4b',NULL),(6,'2015-03-20 10:38:59','Patch Set 1:\n\n3.16 used to work',33,1,33,'da141535_f9403737',NULL),(15,'2015-03-27 15:00:26','Uploaded patch set 4.',33,4,33,'fa3479d7_5204b414',NULL),(15,'2015-03-27 14:53:29','Uploaded patch set 3.',33,3,33,'fa3479d7_72ffb802',NULL),(15,'2015-03-19 18:56:01','Change has been successfully merged into the git repository.',34,2,34,'da141535_195c0b25',NULL),(6,'2015-03-19 17:01:32','Patch Set 1: Code-Review-2\n\n(1 comment)\n\nthis isn\'t valid JSON.\n\nYou can test before you submit with `python -m json.tool foo.lorry` -- it\'ll raise an exception if it can\'t parse the file as JSON.',34,1,34,'da141535_592ba382',NULL),(6,'2015-03-19 17:48:34','Patch Set 2: Code-Review+2\n\nThis looks fine to me',34,2,34,'da141535_794d4772',NULL),(27,'2015-03-19 17:45:28','Uploaded patch set 2.',34,2,34,'da141535_99301bea',NULL),(27,'2015-03-19 16:55:14','Uploaded patch set 1.',34,1,34,'da141535_f9127757',NULL),(6,'2015-03-27 09:22:48','Patch Set 3: Code-Review+2',35,3,35,'1a1a2d67_3309282d',NULL),(15,'2015-03-31 09:49:29','Change has been successfully merged into the git repository.',35,4,35,'1a2f8d8d_0b14bdf3',NULL),(15,'2015-03-31 09:49:27','Patch Set 4: Code-Review+2',35,4,35,'1a2f8d8d_2b0f79e3',NULL),(15,'2015-03-31 09:48:59','Patch Set 4: Patch Set 3 was rebased',35,3,35,'1a2f8d8d_4b0ac5d3',NULL),(37,'2015-03-26 17:50:17','Patch Set 3: Code-Review+1\n\nI guess this looks ok, I normally wouldn\'t bother for anything except major releases, since they are frequent enough for me, but if gerrit makes it easy enough, then it may be worth doing more of these in the future.',35,3,35,'3a1d315d_74d0a853',NULL),(15,'2015-03-19 17:01:56','Uploaded patch set 3.',35,3,35,'da141535_3920ef9a',NULL),(15,'2015-03-19 16:57:44','Uploaded patch set 2.',35,2,35,'da141535_b91cff6b',NULL),(15,'2015-03-19 16:56:50','Uploaded patch set 1.',35,1,35,'da141535_d90fb32d',NULL),(27,'2015-03-19 17:18:16','Uploaded patch set 1.',36,1,36,'da141535_19252bab',NULL),(27,'2015-03-19 17:29:37','Abandoned\n\nincorrect use of gerrit',36,1,36,'da141535_d93693e7',NULL),(8,'2015-03-25 10:25:46','Patch Set 2: Code-Review-2\n\n(1 comment)',37,2,37,'7a23299d_562b7482',NULL),(28,'2015-03-25 10:17:55','Uploaded patch set 2.',37,2,37,'7a23299d_96190c7c',NULL),(8,'2015-03-25 12:54:56','Change has been successfully merged into the git repository.',37,4,37,'7a23299d_968c6c81',NULL),(8,'2015-03-25 12:54:45','Patch Set 4: Code-Review+2',37,4,37,'7a23299d_b68f6875',NULL),(28,'2015-03-25 10:54:45','Uploaded patch set 3.',37,3,37,'7a23299d_d63664e7',NULL),(7,'2015-03-25 12:54:13','Patch Set 4: Code-Review+2\n\nJSON has been fixed, and this patch already had a +2.',37,4,37,'7a23299d_d692e49e',NULL),(7,'2015-03-25 12:47:48','Patch Set 3: Code-Review+2',37,3,37,'7a23299d_d6ab04d5',NULL),(28,'2015-03-25 12:52:57','Uploaded patch set 4.',37,4,37,'7a23299d_f695e088',NULL),(7,'2015-03-20 12:35:17','Restored\n\nThe reason to abandon it wasn\'t true.',37,1,37,'ba092121_78ff8102',NULL),(28,'2015-03-19 18:11:18','Abandoned\n\nIt is part of the standard library.',37,1,37,'da141535_3957cf04',NULL),(6,'2015-03-19 17:49:19','Patch Set 1: Code-Review+2',37,1,37,'da141535_59528314',NULL),(15,'2015-03-19 17:39:26','Patch Set 1: Code-Review+1',37,1,37,'da141535_b933dff5',NULL),(28,'2015-03-19 17:27:27','Uploaded patch set 1.',37,1,37,'da141535_f93957d9',NULL),(15,'2015-03-20 14:52:24','Patch Set 1: Code-Review+1',38,1,38,'9a0e1d27_57048c14',NULL),(7,'2015-03-21 16:30:33','Patch Set 1:\n\n(1 comment)',38,1,38,'9a0e1d27_772670bc',NULL),(26,'2015-03-20 14:47:05','Uploaded patch set 1.',38,1,38,'9a0e1d27_77ff9002',NULL),(6,'2015-03-23 10:22:41','Change has been successfully merged into the git repository.',38,1,38,'9a0e1d27_9747c44b',NULL),(6,'2015-03-23 10:22:19','Patch Set 1: Code-Review+2',38,1,38,'9a0e1d27_b74ac853',NULL),(15,'2015-03-26 18:11:02','Patch Set 2:\n\n/would be ok to call it version-guessed instead git-describe?',39,2,39,'3a1d315d_3441100c',NULL),(37,'2015-03-26 18:02:59','Patch Set 2: Code-Review-1\n\n(2 comments)\n\nI\'m not opposed to adding this metadata, though I\'m perfectly happy with running git-describe from the commit information already included in the metadata.\n\nHowever, running `git describe` at extraction time is far too late, and I\'d like us to move away from including the git repository at all, since it\'s a reproducibility hole.\n\nI also think it\'s far too late in the process to start adding data to the source object. If i had my way it\'d be immutable.',39,2,39,'3a1d315d_543c8c93',NULL),(6,'2015-03-26 18:26:25','Patch Set 2: -Code-Review\n\nversion-guessed is OK for me',39,2,39,'3a1d315d_f44a7826',NULL),(15,'2015-03-20 16:56:56','Uploaded patch set 1.',39,1,39,'9a0e1d27_3709182d',NULL),(6,'2015-03-23 10:26:10','Patch Set 2: Code-Review-1\n\nI think it\'s better to call this field \'git-describe\' rather than \'version\', if it is actually the output of \'git-describe\'. There are ways that upstream projects can make \'git-describe\' give weird output (making tags with funny names, for example) and if these show up in a field created by Morph that is called \'version\', people will assume that Morph is broken when the \'version\' field isn\'t a valid version number.',39,2,39,'9a0e1d27_376eb8ca',NULL),(15,'2015-03-20 17:59:44','Uploaded patch set 2.',39,2,39,'9a0e1d27_b71c086c',NULL),(15,'2015-05-07 16:10:57','Abandoned\n\nthis was for manifest generation, which is now done differently now',39,4,39,'bada0100_8a8d1f34',NULL),(37,'2015-04-01 16:46:11','Patch Set 4:\n\n(2 comments)\n\nThis is a lot better.\nI\'m still not happy about running `git describe` in the build directory, as I want to stop that being a git repository.\nHowever we\'re not doing that in the immediate future, so I\'m not going to block merging on it.',39,4,39,'da6255ed_a94a5d53',NULL),(31,'2015-04-01 16:26:29','Uploaded patch set 4.',39,4,39,'fa5d592f_4ad87353',NULL),(31,'2015-04-01 16:22:34','Uploaded patch set 3.',39,3,39,'fa5d592f_6ad33739',NULL),(37,'2015-04-01 12:05:18','Patch Set 2: Code-Review-1',39,2,39,'fa5d592f_ca47c31c',NULL),(31,'2015-04-01 16:28:11','Patch Set 2:\n\n(2 comments)',39,2,39,'fa5d592f_cae34304',NULL),(37,'2015-04-01 12:05:03','Removed the following approvals:\n\n* Code-Review-1 by Richard Maw \n',39,2,39,'fa5d592f_ea4a8726',NULL),(6,'2015-03-31 08:47:10','Patch Set 5:\n\nmorph build systems/devel-system-x86_64-generic.morph strata/build-essential.morph --local-changes=ignore\nERROR: Components strata/build-essential.morph are not in systems/devel-system-x86_64-generic.morph\n\nIt took me a little while to figure out that I\'d passed it a filename when I was meant to pass it the name of the stratum. Might be good if it either (a) supported either, or (b) the message reminded you to pass the name of the source to build.\n\n\nAlso, if I try to build a stratum without a system, I get this error:\n\nmorph build strata/build-essential.morph --local-changes=ignore \n2015-03-31 08:42:54 Deciding on task order\nERROR: Building a stratum directly is not supported\n\nThis is a little misleading now since, with this patch, building a stratum is supported, you just need to give the name of the system it\'s contained in.',40,5,40,'1a2f8d8d_ab5489ca',NULL),(31,'2015-03-30 16:15:17','Patch Set 5: Code-Review+1\n\nSeems to work, from my testing. Example:\n\n# morph build systems/devel-system-x86_64-generic.morph nano\n2015-03-30 16:13:25 Starting build 7d22d886890f4a8f9b34c91e98cca04f\n2015-03-30 16:13:25 Collecting morphologies involved in building systems/devel-system-x86_64-generic.morph from tlsa\n2015-03-30 16:13:31 Deciding on task order\n2015-03-30 16:13:33 Starting build of nano\n2015-03-30 16:13:33 chunk nano is cached at /src/cache/artifacts/1c509e97eacdfdd82c3a7618e100ae23c7002c5a67138a0a8408dbcbc072838b.chunk.nano-devel\n#',40,5,40,'3a3291f1_ac0263b2',NULL),(16,'2015-03-26 11:31:36','Uploaded patch set 4.',40,4,40,'5a202591_350fd0e3',NULL),(16,'2015-03-30 10:34:10','Uploaded patch set 5.',40,5,40,'5a2585a7_0d25f1aa',NULL),(16,'2015-03-25 11:38:26','Uploaded patch set 3.',40,3,40,'7a23299d_56793492',NULL),(6,'2015-03-25 12:50:53','Patch Set 3:\n\n(3 comments)\n\nI prefer this without the --partial flag, but you need to update the docstrings',40,3,40,'7a23299d_5687f461',NULL),(16,'2015-03-25 13:16:20','Patch Set 3:\n\n> But I\'m confused about the pattern I need to follow, can I do:\n > \n > morph build SYSTEM STRATUM1 CHUNK1 CHUNK2 CHUNK3\n > \n > or\n > \n > morph build SYSTEM STRATUM1 CHUNK1 STRATUM1 CHUNK2 STRATUM2 CHUNK3\n > \n > or\n > \n > morph build SYSTEM STRATUM1 STRATUM2 STRATUM3\n > \n > If any of these don\'t work, and don\'t give a clear error message,\n > there\'s a potential for confusion.\n\nAny of those will work, as long as all the components are in SYSTEM. The command creates the build graph for SYSTEM, then walks the system artifact to find the components that were requested.',40,3,40,'7a23299d_56d5b441',NULL),(6,'2015-03-25 12:59:43','Patch Set 3:\n\nIf I\'m correct, this patch series allows you to specify an arbitrary number of chunks and strata to be built.\n\nI\'d not imagined the command working this way. I figured you\'d be able to pass 1 stratum and maybe 1 chunk within it, and the build would stop after that.\n\nThis assumes the build graph is more or less linear though, and actually it might not be. So I think allowing the user to pass several chunks and strata is fine.\n\nBut I\'m confused about the pattern I need to follow, can I do:\n\nmorph build SYSTEM STRATUM1 CHUNK1 CHUNK2 CHUNK3\n\nor \n\nmorph build SYSTEM STRATUM1 CHUNK1 STRATUM1 CHUNK2 STRATUM2 CHUNK3\n\nor \n\nmorph build SYSTEM STRATUM1 STRATUM2 STRATUM3 \n\nIf any of these don\'t work, and don\'t give a clear error message, there\'s a potential for confusion.',40,3,40,'7a23299d_56eed423',NULL),(16,'2015-03-25 11:35:15','Uploaded patch set 2.',40,2,40,'7a23299d_d63d44bd',NULL),(16,'2015-03-20 17:31:59','Uploaded patch set 1.',40,1,40,'9a0e1d27_170e1435',NULL),(32,'2015-03-24 16:17:18','Patch Set 1:\n\n(2 comments)',40,1,40,'9a0e1d27_97eea4b3',NULL),(32,'2015-03-24 15:57:42','Patch Set 1: Code-Review-1\n\n(5 comments)\n\nI\'m unconvinced of the need or desire for --partial and there\'s an unrelated change in this changeset.',40,1,40,'9a0e1d27_d7cd3c5f',NULL),(16,'2015-03-24 16:11:20','Patch Set 1:\n\n(3 comments)',40,1,40,'9a0e1d27_f7f7208b',NULL),(6,'2015-04-01 16:44:45','Change has been successfully rebased as bd788c7219d8b59be8eb1168f2121d8b280020e6',40,6,40,'da6255ed_2920ad9a',NULL),(6,'2015-04-01 16:44:44','Patch Set 7: Patch Set 6 was rebased',40,6,40,'da6255ed_8919d97b',NULL),(16,'2015-04-01 09:57:25','Uploaded patch set 6.',40,6,40,'fa5d592f_2a209f9a',NULL),(6,'2015-04-01 11:32:14','Patch Set 6: Code-Review+1\n\nThanks for making those changes!',40,6,40,'fa5d592f_2af3ff0b',NULL),(6,'2015-04-01 11:33:52','Patch Set 6: Code-Review+2',40,6,40,'fa5d592f_aae6cf42',NULL),(6,'2015-03-30 17:29:27','Patch Set 5:\n\nI\'d appreciate a docstring for the map_build_graph function containing your explanation of how it works. Other than that, looks fine (not tested though)',41,5,41,'3a3291f1_ece62b16',NULL),(16,'2015-03-26 11:31:36','Uploaded patch set 4.',41,4,41,'5a202591_1514d4f3',NULL),(16,'2015-03-30 10:34:10','Uploaded patch set 5.',41,5,41,'5a2585a7_ed3985d9',NULL),(6,'2015-03-25 14:13:39','Patch Set 3:\n\n(2 comments)\n\nThis looks ok, although a bit confusing.\n\nCould we do this in a simpler way of only saying \'build this component?\' rather than allowing multiple components? We could still allow the user to pass multiple components on the commandline, but then send a build-request message for each component, instead of one message for all of them. Theoretically this shouldn\'t be slower, because of artifact caching. I\'m not sure if the code would actually be simpler though.',41,3,41,'7a23299d_3658f8f9',NULL),(16,'2015-03-25 11:38:26','Uploaded patch set 3.',41,3,41,'7a23299d_366eb8ca',NULL),(16,'2015-03-25 15:16:15','Patch Set 3:\n\n(1 comment)\n\n> Could we do this in a simpler way of only saying \'build this\n > component?\' rather than allowing multiple components? We could\n > still allow the user to pass multiple components on the\n > commandline, but then send a build-request message for each\n > component, instead of one message for all of them. Theoretically\n > this shouldn\'t be slower, because of artifact caching. I\'m not sure\n > if the code would actually be simpler though.\n\nI can look into it, but I\'m also unsure whether the code would be simpler.',41,3,41,'7a23299d_56d81453',NULL),(16,'2015-03-25 11:35:15','Uploaded patch set 2.',41,2,41,'7a23299d_b64ac853',NULL),(16,'2015-03-20 17:32:00','Uploaded patch set 1.',41,1,41,'9a0e1d27_f7128057',NULL),(6,'2015-04-02 08:32:56','Change has been successfully merged into the git repository.',41,7,41,'ba57610f_488d1f31',NULL),(6,'2015-04-02 08:31:49','Patch Set 7: Code-Review+2',41,7,41,'ba57610f_889b1772',NULL),(16,'2015-04-02 08:24:06','Uploaded patch set 7.',41,7,41,'ba57610f_c8910f54',NULL),(NULL,'2015-04-02 04:50:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ica2a270b, however the current patch set is 6.\n* Depends on commit 27c57b6c07f94d10a949534aa1e01d36e0b2a176 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',41,6,41,'ba57610f_e894d345',NULL),(NULL,'2015-04-01 16:46:41','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ica2a270b, however the current patch set is 6.\n* Depends on commit 27c57b6c07f94d10a949534aa1e01d36e0b2a176 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',41,6,41,'da6255ed_a9613dd5',NULL),(16,'2015-04-01 09:57:25','Uploaded patch set 6.',41,6,41,'fa5d592f_0a25dbaa',NULL),(6,'2015-04-01 11:33:56','Patch Set 6: Code-Review+2',41,6,41,'fa5d592f_8ae30b33',NULL),(6,'2015-04-01 11:33:32','Patch Set 6: Code-Review+1',41,6,41,'fa5d592f_eadcc776',NULL),(6,'2015-03-30 17:30:44','Patch Set 5: Code-Review+1\n\nLooks fine, seems like adding a test for distbuild would be simple enough as well. But we can do that separately.',42,5,42,'3a3291f1_acf023ca',NULL),(16,'2015-03-26 11:31:36','Uploaded patch set 4.',42,4,42,'5a202591_f5f838c6',NULL),(16,'2015-03-30 10:34:10','Uploaded patch set 5.',42,5,42,'5a2585a7_cd36c9e7',NULL),(16,'2015-03-25 11:38:26','Uploaded patch set 3.',42,3,42,'7a23299d_1673bcb2',NULL),(16,'2015-03-25 11:35:15','Uploaded patch set 2.',42,2,42,'7a23299d_9647cc4b',NULL),(16,'2015-03-20 17:32:00','Uploaded patch set 1.',42,1,42,'9a0e1d27_d70f7c2d',NULL),(NULL,'2015-04-02 04:45:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ica2a270b, however the current patch set is 6.\n* Depends on commit 27c57b6c07f94d10a949534aa1e01d36e0b2a176 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',42,6,42,'ba57610f_08b047f3',NULL),(6,'2015-04-02 08:32:59','Change has been successfully merged into the git repository.',42,7,42,'ba57610f_2882eb00',NULL),(6,'2015-04-02 08:32:51','Patch Set 7: Code-Review+2',42,7,42,'ba57610f_6888e322',NULL),(16,'2015-04-02 08:24:06','Uploaded patch set 7.',42,7,42,'ba57610f_a89edb61',NULL),(NULL,'2015-04-01 16:44:48','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 6 of I0537f74e.\n* Depends on patch set 5 of Ica2a270b, however the current patch set is 6.\n* Depends on commit 27c57b6c07f94d10a949534aa1e01d36e0b2a176 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',42,6,42,'da6255ed_0925e9aa',NULL),(NULL,'2015-04-01 16:46:41','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ica2a270b, however the current patch set is 6.\n* Depends on commit 27c57b6c07f94d10a949534aa1e01d36e0b2a176 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',42,6,42,'da6255ed_296e6dca',NULL),(6,'2015-04-01 11:33:41','Patch Set 6: Code-Review+2',42,6,42,'fa5d592f_cad90385',NULL),(16,'2015-04-01 09:57:25','Uploaded patch set 6.',42,6,42,'fa5d592f_ea3967d9',NULL),(18,'2015-04-07 19:08:12','Patch Set 1:\n\n> Uploaded patch set 1.\n\nI\'m not going to -1, but I really dislike this idea. Better IMO would be that\n- name: field was *used* by morph\n- filenames did not matter at all (so a files can contain groups of named definitions laid out however a user wants)\n- names were unique.',43,1,43,'1a486d77_e6408037',NULL),(32,'2015-03-25 11:25:31','Patch Set 1: Code-Review-1\n\nthe \'name:\' field is meant to be a doublecheck that noone did something daft by blithely copying a file and not making sure it was what they meant to do.',43,1,43,'7a23299d_f6404037',NULL),(24,'2015-03-24 17:21:28','Patch Set 1: Code-Review-1\n\n> I still don\'t like this idea. Suddenly we\'re making the filename\n > part of the morphology format, which means we can only store\n > morphologies in files. If I paste one a pastebin, for example, or\n > inline it in the wiki, it doesn\'t have a filename any more and,\n > without the \'name\', field, becomes useless.\n\nI agree with the above comment that this change makes it harder to serialize/deserialize definitions into other formats.',43,1,43,'9a0e1d27_370c7894',NULL),(15,'2015-03-21 22:18:48','Uploaded patch set 1.',43,1,43,'9a0e1d27_572b6c82',NULL),(29,'2015-03-23 15:43:26','Patch Set 1:\n\nThis is a test comment from a cli',43,1,43,'9a0e1d27_978c6481',NULL),(6,'2015-03-23 10:20:58','Patch Set 1: Code-Review-1\n\nI still don\'t like this idea. Suddenly we\'re making the filename part of the morphology format, which means we can only store morphologies in files. If I paste one a pastebin, for example, or inline it in the wiki, it doesn\'t have a filename any more and, without the \'name\', field, becomes useless.',43,1,43,'9a0e1d27_d73d3cbd',NULL),(29,'2015-03-23 11:00:11','Patch Set 1:\n\nThis potentially conflicts with the [RFC 0/9] Branch morph submitted to baserock-dev on the same day. Since that RFC also bumps the definitions version number, if we do want to merge this we should try to coordinate the merge of both (if either are to be merged)\n\nThere\'s been discussion around dropping the name field in #baserock before, clearly the name field doesn\'t add any information as far as morph is concerned, but general consensus in #baserock was that the name field should stay,\nif only as a user aid.',43,1,43,'9a0e1d27_f7ae00e7',NULL),(33,'2015-04-08 09:02:10','Patch Set 1:\n\n> > > Uploaded patch set 1.\n > >\n > > I\'m not going to -1, but I really dislike this idea. Better IMO\n > > would be that\n > > - name: field was *used* by morph\n > > - filenames did not matter at all (so a files can contain groups\n > > of named definitions laid out however a user wants)\n > > - names were unique.\n > \n\n(same response, but with more useful formatting)\n\nfilename shouldn\'t matter imo, so long as it\'s checked into the\nrepo you should be able to use it.\n\ni don\'t think there\'s any technical reason for names to be used by\nmorph, and i don\'t get why names have to be unique.\n\ni\'m not against making names in strata optional, i think you should\nbe able to put all the fields in a chunk morph and just reference that from\nthe stratum, so that you\'d write\n\n name: things\n kind: stratum\n ...\n chunks:\n morph: strata/trove/gitano.morph\n morph: strata/cats/xattr.morph\n\nbut maybe,\n\n name: things\n kind: collection\n components:\n component: trove/gitano.morph\n component: cats/xattr.morph\n\nand the user could optionally inline any fields defined in the\nchunk morph, so you could equally write\n\n name: things\n kind: collection\n components:\n name: gitano\n repo: upstream:gitano\n ref: master\n install-commands:\n - make install ...\n name: xattr\n component: cats/xattr.morph\n repo: upstream:xattr\n ref: master\n\nnone of these suggestions are new i\'m just repeating them for the\nsake of discussion.',43,1,43,'fa82b9bf_2209ae2c',NULL),(15,'2015-04-08 16:32:48','Patch Set 1:\n\nSeems this change is not a good idea so I\'m going to abandon it\n\nThanks for all the feedback!',43,1,43,'fa82b9bf_227c4e72',NULL),(15,'2015-04-08 16:32:54','Abandoned\n\nSeems this change is not a good idea so I\'m going to abandon it\n\nThanks for all the feedback!',43,1,43,'fa82b9bf_42815249',NULL),(33,'2015-04-08 08:56:04','Patch Set 1:\n\n> > Uploaded patch set 1.\n > \n > I\'m not going to -1, but I really dislike this idea. Better IMO\n > would be that\n > - name: field was *used* by morph\n > - filenames did not matter at all (so a files can contain groups\n > of named definitions laid out however a user wants)\n > - names were unique.\n\nfilename shouldn\'t matter imo, so long as it\'s checked into the repo you should be able to use it.\n\ni don\'t think there\'s any technical reason for names to be used by morph,\nand i don\'t get why names have to be unique.\n\ni\'m not against making names in strata optional, i think you should be able\nto put all the fields in a chunk morph and just reference that from the stratum, so that you\'d write\n\nname: things\nkind: stratum\n...\nchunks:\nmorph: strata/trove/gitano.morph\nmorph: strata/cats/xattr.morph\n\nor but i\'d rather this were,\n\nname: things\nkind: collection\ncomponents:\ncomponent: trove/gitano.morph\ncomponent: cats/xattr.morph\n\nbut the user could optionally inline any fields defined in the chunk morph,\nso you could equally write\n\nname: things\nkind: collection\ncomponents:\nname: gitano\nrepo: upstream:gitano\nref: master\ninstall-commands:\n - make install ...\nname: xattr\ncomponent: cats/xattr.morph\nrepo: upstream:xattr\nref: master\n\nnone of these suggestions are new i\'m just repeating them for the sake of discussion.',43,1,43,'fa82b9bf_82043a16',NULL),(32,'2015-03-25 11:25:03','Patch Set 1: Code-Review-1\n\nTurns out that I had reviewed this in isolation and actually this is madness :)',44,1,44,'7a23299d_165cdc24',NULL),(15,'2015-03-21 22:18:48','Uploaded patch set 1.',44,1,44,'9a0e1d27_3720f89a',NULL),(32,'2015-03-24 13:07:37','Patch Set 1: Code-Review+1\n\nLooks reasonable to me',44,1,44,'9a0e1d27_37ab588b',NULL),(15,'2015-04-08 16:33:03','Abandoned\n\nSeems this change is not a good idea so I\'m going to abandon it\n\nThanks for all the feedback!',44,1,44,'fa82b9bf_e2950689',NULL),(15,'2015-03-21 22:26:34','Uploaded patch set 1.',45,1,45,'9a0e1d27_1725f4aa',NULL),(7,'2015-03-23 10:25:15','Patch Set 1: Code-Review+1',45,1,45,'9a0e1d27_57792c92',NULL),(15,'2015-03-23 10:28:24','Change has been successfully merged into the git repository.',45,1,45,'9a0e1d27_d7641ce7',NULL),(6,'2015-03-23 10:16:54','Patch Set 1: Code-Review+1',45,1,45,'9a0e1d27_f7404037',NULL),(15,'2015-03-23 10:28:20','Patch Set 1: Code-Review+2',45,1,45,'9a0e1d27_f76720e9',NULL),(6,'2015-03-23 10:15:38','Patch Set 1: Code-Review+1',46,1,46,'9a0e1d27_175cd424',NULL),(7,'2015-03-23 10:27:34','Patch Set 1: Code-Review+2',46,1,46,'9a0e1d27_1773b4b2',NULL),(6,'2015-03-23 16:57:24','Patch Set 1: Reverted\n\nThis patchset was reverted in change: Ic1d32781c27393494f82f44638564c34cf2b296f',46,1,46,'9a0e1d27_57eecc23',NULL),(6,'2015-03-23 17:10:06','Change has been successfully merged into the git repository.',46,2,46,'9a0e1d27_97e34433',NULL),(15,'2015-03-23 10:28:39','Change has been successfully merged into the git repository.',46,1,46,'9a0e1d27_b761a8d5',NULL),(6,'2015-03-23 17:10:02','Patch Set 2: Code-Review+2',46,2,46,'9a0e1d27_b7e64843',NULL),(6,'2015-03-23 17:05:51','Uploaded patch set 2.',46,2,46,'9a0e1d27_d7d9bc84',NULL),(15,'2015-03-22 03:24:43','Uploaded patch set 1.',46,1,46,'9a0e1d27_f73960d9',NULL),(6,'2015-03-23 17:00:14','Patch Set 1:\n\nThis change has not actually been merged. Seems like a bug in Gerrit.',46,1,46,'9a0e1d27_f7dcc076',NULL),(6,'2015-03-23 10:15:23','Patch Set 1: Code-Review+1',47,1,47,'9a0e1d27_3757d804',NULL),(6,'2015-03-23 10:32:56','Change has been successfully merged into the git repository.',47,1,47,'9a0e1d27_57a00cf4',NULL),(7,'2015-03-23 10:31:50','Patch Set 1: Code-Review+2',47,1,47,'9a0e1d27_779b10ca',NULL),(15,'2015-03-23 03:22:25','Uploaded patch set 1.',47,1,47,'9a0e1d27_d7365ce7',NULL),(6,'2015-03-23 10:58:30','Change has been successfully merged into the git repository.',48,1,48,'9a0e1d27_17aa94d4',NULL),(7,'2015-03-23 10:33:46','Patch Set 1: Code-Review+2',48,1,48,'9a0e1d27_37a59804',NULL),(6,'2015-03-23 10:15:09','Patch Set 1: Code-Review+1',48,1,48,'9a0e1d27_57524c14',NULL),(15,'2015-03-23 04:08:08','Uploaded patch set 1.',48,1,48,'9a0e1d27_b733e8f5',NULL),(8,'2015-03-25 12:42:56','Change has been successfully merged into the git repository.',49,4,49,'7a23299d_16aa9cd4',NULL),(8,'2015-03-25 12:42:46','Patch Set 4: Code-Review+2',49,4,49,'7a23299d_36a59804',NULL),(6,'2015-03-25 12:42:26','Patch Set 4: Code-Review+1',49,4,49,'7a23299d_56a014f4',NULL),(15,'2015-03-25 12:27:49','Uploaded patch set 4.',49,4,49,'7a23299d_769b10ca',NULL),(8,'2015-03-25 12:06:03','Patch Set 3: Code-Review-1\n\n(1 comment)',49,3,49,'7a23299d_965eac11',NULL),(15,'2015-03-25 11:46:52','Uploaded patch set 3.',49,3,49,'7a23299d_d66424e7',NULL),(6,'2015-03-24 17:13:19','Patch Set 2:\n\nI think the /usr merge is a good idea, but since I have no idea how long it will take, I don\'t think there\'s any way to avoid working around it in chunk morphs for now. Add a comment to the workaround saying that it should be removed once the /usr merge is done, or something.',49,2,49,'9a0e1d27_5717eca3',NULL),(6,'2015-03-23 10:14:35','Patch Set 1: Code-Review-1\n\ndoes removing --bindir cause the tar binary to be /usr/bin/tar instead of /bin/tar ? I think that means that this chunk will no longer overwrite busybox\'s /bin/tar, which would be a confusing change.',49,1,49,'9a0e1d27_774d5072',NULL),(15,'2015-03-23 10:24:57','Patch Set 1:\n\nI think the propper solution here is to stop using /bin, /lib ... altogether, more than patch every single chunk we want to override. This has been already started by Pedro in http://git.baserock.org/cgi-bin/cgit.cgi/baserock/baserock/definitions.git/log/?h=baserock/pedroalvarez/usr-merge2 (also see storyboard https://storyboard.baserock.org/#!/story/11)\nAnother quicker solution would be to tell busybox to install the sutff in /usr/bin, but Im not sure If its possible\nI can still rework the patch if you think is better to not wait to this to happen',49,1,49,'9a0e1d27_7774309c',NULL),(15,'2015-03-23 04:08:08','Uploaded patch set 1.',49,1,49,'9a0e1d27_9730e4e9',NULL),(8,'2015-03-24 15:27:10','Patch Set 2:\n\n(1 comment)',49,2,49,'9a0e1d27_97c0e42b',NULL),(15,'2015-03-23 17:34:49','Uploaded patch set 2.',49,2,49,'9a0e1d27_d7c09c7e',NULL),(7,'2015-03-23 14:51:20','Change has been successfully merged into the git repository.',50,1,50,'9a0e1d27_1781744a',NULL),(7,'2015-03-23 14:51:17','Patch Set 1: Code-Review+2',50,1,50,'9a0e1d27_377c7872',NULL),(6,'2015-03-23 13:18:59','Patch Set 1: Code-Review+1',50,1,50,'9a0e1d27_97b58433',NULL),(15,'2015-03-23 12:46:10','Uploaded patch set 1.',50,1,50,'9a0e1d27_d7abfcd4',NULL),(15,'2015-03-23 12:51:55','Uploaded patch set 1.',51,1,51,'9a0e1d27_b7b8882b',NULL),(7,'2015-03-23 14:51:24','Change has been successfully merged into the git repository.',51,1,51,'9a0e1d27_d792dc9e',NULL),(7,'2015-03-23 14:51:23','Patch Set 1: Code-Review+2',51,1,51,'9a0e1d27_f795e088',NULL),(32,'2015-03-24 13:44:16','Patch Set 2: Code-Review+1\n\nLooks reasonable to me.',52,2,52,'9a0e1d27_17873411',NULL),(26,'2015-03-24 13:41:14','Uploaded patch set 2.',52,2,52,'9a0e1d27_37823801',NULL),(30,'2015-03-23 16:40:59','Uploaded patch set 1.',52,1,52,'9a0e1d27_77e9d019',NULL),(6,'2015-03-24 14:09:56','Change has been successfully merged into the git repository.',52,2,52,'9a0e1d27_d79f7c4f',NULL),(6,'2015-03-24 14:09:50','Patch Set 2: Code-Review+2\n\nLooks fine to me',52,2,52,'9a0e1d27_f7a28099',NULL),(15,'2015-03-23 17:24:05','Patch Set 1: Code-Review-1\n\n(2 comments)',52,1,52,'9a0e1d27_f7c3a088',NULL),(6,'2015-03-23 16:59:04','Abandoned\n\nthis was a test because change #46 never actually got merged. ignore',53,1,53,'9a0e1d27_17f854e4',NULL),(6,'2015-03-23 16:58:51','Patch Set 1:\n\nthis was a test because change #46 never actually got merged. ignore.',53,1,53,'9a0e1d27_37f3580c',NULL),(6,'2015-03-30 12:48:26','Change has been successfully rebased as 39473587d6b669ccecc6907641aad72942b7fbba',54,3,54,'5a2585a7_adbdbd04',NULL),(6,'2015-03-30 12:48:26','Patch Set 4: Patch Set 3 was rebased',54,3,54,'5a2585a7_cdc0097f',NULL),(6,'2015-03-30 12:47:41','Patch Set 3: Code-Review+2',54,3,54,'5a2585a7_edc3c588',NULL),(6,'2015-03-24 10:26:00','Patch Set 3:\n\npatch set 3 is the same as patch set 2, except for some reason in patch set 2 the baserock_hosts file got deleted, again.',54,3,54,'9a0e1d27_1714d4f3',NULL),(6,'2015-03-24 10:24:46','Uploaded patch set 3.',54,3,54,'9a0e1d27_370fd8e3',NULL),(6,'2015-03-24 10:23:53','Uploaded patch set 2.',54,2,54,'9a0e1d27_570a4cd3',NULL),(6,'2015-03-23 17:17:54','Patch Set 1:\n\nthis backup mechanism is currently running on an internal instance within Codethink\'s OpenStack cloud',54,1,54,'9a0e1d27_57d5ac41',NULL),(6,'2015-03-23 17:13:11','Uploaded patch set 1.',54,1,54,'9a0e1d27_77d0b053',NULL),(16,'2015-03-27 12:08:14','Patch Set 3: Code-Review+1',55,3,55,'1a1a2d67_53526414',NULL),(6,'2015-03-31 11:40:49','Patch Set 4:\n\n(4 comments)\n\nThis is OK, but the code is misleading in places.',55,4,55,'1a2f8d8d_0bb5ddcc',NULL),(31,'2015-03-31 08:27:13','Uploaded patch set 4.',55,4,55,'1a2f8d8d_2b41b90b',NULL),(31,'2015-03-31 14:14:28','Uploaded patch set 5.',55,5,55,'1a2f8d8d_8bee6db3',NULL),(31,'2015-03-31 14:17:55','Patch Set 4:\n\n(4 comments)',55,4,55,'1a2f8d8d_ab4809cd',NULL),(31,'2015-03-24 12:20:36','Uploaded patch set 2.',55,2,55,'9a0e1d27_17b974e9',NULL),(31,'2015-03-24 17:08:29','Uploaded patch set 3.',55,3,55,'9a0e1d27_37359846',NULL),(32,'2015-03-24 11:02:46','Patch Set 1:\n\n(3 comments)\n\nI\'m not entirely comfortable with this. -0',55,1,55,'9a0e1d27_57312ca1',NULL),(31,'2015-03-24 14:16:10','Patch Set 1:\n\n(2 comments)',55,1,55,'9a0e1d27_77b670de',NULL),(31,'2015-03-24 17:10:48','Patch Set 1:\n\n(1 comment)',55,1,55,'9a0e1d27_974584b5',NULL),(31,'2015-03-23 17:49:45','Uploaded patch set 1.',55,1,55,'9a0e1d27_b7bd2805',NULL),(6,'2015-04-01 16:44:51','Change has been successfully rebased as 5ca985edb3d429967cd40d34229db19a1b7c6b0a',55,5,55,'da6255ed_a9337df5',NULL),(6,'2015-04-01 16:44:51','Patch Set 6: Patch Set 5 was rebased',55,5,55,'da6255ed_c936b1e7',NULL),(6,'2015-04-01 11:55:50','Patch Set 5: Code-Review+2',55,5,55,'fa5d592f_8abaeb08',NULL),(16,'2015-03-27 12:47:14','Patch Set 3: Code-Review+1',56,3,56,'1a1a2d67_3357e804',NULL),(31,'2015-03-31 08:27:13','Uploaded patch set 4.',56,4,56,'1a2f8d8d_0b46fd23',NULL),(31,'2015-03-31 14:14:28','Uploaded patch set 5.',56,5,56,'1a2f8d8d_6b2b41ec',NULL),(31,'2015-03-31 14:18:23','Patch Set 4:\n\nFixed in v5.',56,4,56,'1a2f8d8d_8b454db5',NULL),(6,'2015-03-31 11:49:07','Patch Set 4:\n\nLooks great apart from the function names -- should be tags_containing_commit() and branches_containing_commit() I think',56,4,56,'1a2f8d8d_cbc6b549',NULL),(31,'2015-03-24 17:08:29','Uploaded patch set 3.',56,3,56,'9a0e1d27_173a9436',NULL),(31,'2015-03-24 14:17:26','Patch Set 1:\n\n(2 comments)',56,1,56,'9a0e1d27_17b5f4cc',NULL),(31,'2015-03-23 17:49:45','Uploaded patch set 1.',56,1,56,'9a0e1d27_97ba2409',NULL),(32,'2015-03-24 11:05:12','Patch Set 1:\n\n(2 comments)\n\nI\'m not happy yet. -0',56,1,56,'9a0e1d27_f71f2008',NULL),(31,'2015-03-24 12:20:36','Uploaded patch set 2.',56,2,56,'9a0e1d27_f7cde087',NULL),(NULL,'2015-04-01 16:44:53','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ic6e613c2, however the current patch set is 6.\n\nPlease rebase the change and upload a replacement commit.',56,5,56,'da6255ed_095cc924',NULL),(7,'2015-04-01 17:56:35','Change has been successfully merged into the git repository.',56,6,56,'da6255ed_89c43960',NULL),(7,'2015-04-01 17:56:32','Patch Set 6: Code-Review+2',56,6,56,'da6255ed_a9c7fd63',NULL),(7,'2015-04-01 17:56:27','Patch Set 6: Patch Set 5 was rebased',56,5,56,'da6255ed_c9ca316e',NULL),(7,'2015-04-01 17:56:24','Patch Set 5:\n\nThere is a dependency failure because the dependency was merged, and there was sent another version for the remaining patches. I\'ll try to rebase this patches to merge them.',56,5,56,'da6255ed_e9cdf587',NULL),(6,'2015-04-01 11:55:57','Patch Set 5: Code-Review+2',56,5,56,'fa5d592f_6a37b7b1',NULL),(16,'2015-03-27 12:47:28','Patch Set 3: Code-Review+1',57,3,57,'1a1a2d67_135cec24',NULL),(31,'2015-03-31 14:14:28','Uploaded patch set 5.',57,5,57,'1a2f8d8d_4b308556',NULL),(6,'2015-03-31 11:54:15','Patch Set 4: Code-Review+2\n\nLooks fine',57,4,57,'1a2f8d8d_8bc0ad2b',NULL),(31,'2015-03-31 08:27:13','Uploaded patch set 4.',57,4,57,'1a2f8d8d_eb4a9126',NULL),(11,'2015-03-26 14:14:05','Patch Set 3: Code-Review+1',57,3,57,'5a202591_9516a4f0',NULL),(31,'2015-03-23 17:49:45','Uploaded patch set 1.',57,1,57,'9a0e1d27_773790b1',NULL),(31,'2015-03-24 12:20:36','Uploaded patch set 2.',57,2,57,'9a0e1d27_d7cadc6d',NULL),(31,'2015-03-24 17:08:29','Uploaded patch set 3.',57,3,57,'9a0e1d27_f73e0029',NULL),(7,'2015-04-01 17:57:29','Patch Set 6:\n\nThere is a dependency failure because the dependency was merged, and there was sent another version for the remaining patches. I\'ll try to rebase this patches to merge them.',57,6,57,'da6255ed_09872911',NULL),(NULL,'2015-04-01 16:44:53','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ic6e613c2, however the current patch set is 6.\n\nPlease rebase the change and upload a replacement commit.',57,5,57,'da6255ed_29578d04',NULL),(NULL,'2015-04-01 17:56:35','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of I63f0d9da, however the current patch set is 6.\n* Depends on commit b87ccc57e990bf417e32ee0eba735b52cf108317 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',57,5,57,'da6255ed_49a641c3',NULL),(7,'2015-04-01 17:57:23','Change has been successfully merged into the git repository.',57,6,57,'da6255ed_899b1972',NULL),(7,'2015-04-01 17:57:21','Patch Set 6: Code-Review+2',57,6,57,'da6255ed_a99edd61',NULL),(7,'2015-04-01 17:57:19','Patch Set 6: Patch Set 5 was rebased',57,5,57,'da6255ed_c9911154',NULL),(7,'2015-04-01 17:57:18','Patch Set 5:\n\nThere is a dependency failure because the dependency was merged, and there was sent another version for the remaining patches. I\'ll try to rebase this patches to merge them.',57,5,57,'da6255ed_e994d545',NULL),(6,'2015-04-01 11:53:56','Patch Set 5: Code-Review+2',57,5,57,'fa5d592f_aabdaf04',NULL),(16,'2015-03-27 12:49:21','Patch Set 3: Code-Review+1\n\nI\'d also like the PASSED message to be less strong, but I can\'t think of a better way to work it that makes sense and is unambiguous.\n\nIt would also be nice if there was a Yarn for this functionality, but I\'m not going to reject this patch based on that.\n\nLooks fine to me overall other than that.',58,3,58,'1a1a2d67_f3405037',NULL),(31,'2015-03-31 14:14:28','Uploaded patch set 5.',58,5,58,'1a2f8d8d_2b353946',NULL),(31,'2015-03-31 14:20:07','Patch Set 4:\n\n> This command is a bit slow right now\n\nAgreed with all you said. Although if you\'re already `morph build`ing the system, you\'ll have everything anyway.',58,4,58,'1a2f8d8d_6b1221b6',NULL),(6,'2015-03-31 11:53:39','Patch Set 4:\n\nThis command is a bit slow right now because it has to update the local copies of all the repos involved in the build. That could be fixed by extending morph-cache-server to allow running \'git branch --contains\' and \'git tag --contains\' remotely.\n\nI don\'t think this needs doing now, but we should be clear when discussing this command that, right now, it\'s very slow the first time you use it, and extra work would be needed to make it fast.',58,4,58,'1a2f8d8d_abc36937',NULL),(6,'2015-03-31 13:03:20','Patch Set 4: Code-Review+1\n\nThis looks fine at a first cut',58,4,58,'1a2f8d8d_abda4915',NULL),(31,'2015-03-31 08:27:13','Uploaded patch set 4.',58,4,58,'1a2f8d8d_cb47d51c',NULL),(31,'2015-03-24 11:19:25','Patch Set 1:\n\n(1 comment)',58,1,58,'9a0e1d27_17e29403',NULL),(31,'2015-03-24 14:05:43','Patch Set 1:\n\n(2 comments)',58,1,58,'9a0e1d27_3799186f',NULL),(31,'2015-03-23 17:49:45','Uploaded patch set 1.',58,1,58,'9a0e1d27_573c8c93',NULL),(32,'2015-03-24 11:37:13','Patch Set 1:\n\n(1 comment)',58,1,58,'9a0e1d27_57bfecd0',NULL),(32,'2015-03-24 11:12:40','Patch Set 1:\n\n(4 comments)\n\nAgain, unconvinced of the complete correctness. +0',58,1,58,'9a0e1d27_57d80c53',NULL),(31,'2015-03-24 11:34:52','Patch Set 1:\n\n(1 comment)',58,1,58,'9a0e1d27_97ed84f2',NULL),(31,'2015-03-24 12:20:36','Uploaded patch set 2.',58,2,58,'9a0e1d27_b7c76864',NULL),(31,'2015-03-24 17:08:29','Uploaded patch set 3.',58,3,58,'9a0e1d27_d73bfc36',NULL),(31,'2015-03-24 13:53:25','Patch Set 1:\n\n(1 comment)',58,1,58,'9a0e1d27_d7789c2d',NULL),(32,'2015-03-24 11:21:32','Patch Set 1:\n\n(1 comment)',58,1,58,'9a0e1d27_d7e3fc03',NULL),(NULL,'2015-04-01 17:57:23','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ie77357d9, however the current patch set is 6.\n* Depends on commit 5f76b374bfd313d7e5d035cc57f63ca7c94746e8 which has no change associated with it.\n* Depends on commit b87ccc57e990bf417e32ee0eba735b52cf108317 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',58,5,58,'da6255ed_2982ed00',NULL),(NULL,'2015-04-01 16:44:52','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of Ic6e613c2, however the current patch set is 6.\n\nPlease rebase the change and upload a replacement commit.',58,5,58,'da6255ed_694d8572',NULL),(NULL,'2015-04-01 17:56:35','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 5 of I63f0d9da, however the current patch set is 6.\n* Depends on commit b87ccc57e990bf417e32ee0eba735b52cf108317 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',58,5,58,'da6255ed_69a105a9',NULL),(7,'2015-04-01 17:57:57','Change has been successfully merged into the git repository.',58,6,58,'da6255ed_8972f947',NULL),(7,'2015-04-01 17:57:56','Patch Set 6: Code-Review+2',58,6,58,'da6255ed_a975bd33',NULL),(7,'2015-04-01 17:57:53','Patch Set 6: Patch Set 5 was rebased',58,5,58,'da6255ed_c978f12d',NULL),(7,'2015-04-01 17:57:52','Patch Set 5:\n\nThere is a dependency failure because the dependency was merged, and there was sent another version for the remaining patches. I\'ll try to rebase this patches to merge them.',58,5,58,'da6255ed_e97bb527',NULL),(6,'2015-04-01 11:53:50','Patch Set 5: Code-Review+2',58,5,58,'fa5d592f_cac0e37e',NULL),(6,'2015-04-01 11:53:41','Patch Set 5: Code-Review+1',58,5,58,'fa5d592f_eac3a788',NULL),(6,'2015-03-25 14:21:41','Change has been successfully merged into the git repository.',59,1,59,'7a23299d_560a54d3',NULL),(6,'2015-03-25 14:21:33','Patch Set 1: Code-Review+2',59,1,59,'7a23299d_760550c1',NULL),(15,'2015-03-23 18:22:01','Uploaded patch set 1.',59,1,59,'9a0e1d27_3741180c',NULL),(7,'2015-03-24 17:32:04','Patch Set 1: Code-Review+1',59,1,59,'9a0e1d27_d722dc00',NULL),(15,'2015-03-23 18:27:14','Topic changed from glib_2_44_0 to glib_gtk',59,1,59,'9a0e1d27_f74a8026',NULL),(6,'2015-03-25 14:21:54','Change has been successfully merged into the git repository.',60,1,60,'7a23299d_360fd8e3',NULL),(6,'2015-03-25 14:21:16','Patch Set 1: Code-Review+2',60,1,60,'7a23299d_9668ec88',NULL),(7,'2015-03-25 13:36:06','Patch Set 1: Code-Review+1',60,1,60,'7a23299d_b65408cb',NULL),(15,'2015-03-23 18:24:22','Uploaded patch set 1.',60,1,60,'9a0e1d27_17461424',NULL),(7,'2015-03-25 13:19:59','Patch Set 1: Code-Review+1',61,1,61,'7a23299d_36ca38a2',NULL),(7,'2015-03-25 13:34:05','Change has been successfully merged into the git repository.',61,1,61,'7a23299d_763790b1',NULL),(7,'2015-03-25 13:34:04','Patch Set 1: Code-Review+2',61,1,61,'7a23299d_96ba2c09',NULL),(16,'2015-03-24 10:11:58','Patch Set 1: Code-Review+1',61,1,61,'9a0e1d27_770550c1',NULL),(15,'2015-03-24 00:10:34','Uploaded patch set 1.',61,1,61,'9a0e1d27_d7477c1c',NULL),(7,'2015-03-25 13:26:29','Patch Set 1: Code-Review+1',62,1,62,'7a23299d_16cf3cb2',NULL),(7,'2015-03-25 13:34:09','Change has been successfully merged into the git repository.',62,1,62,'7a23299d_3641180c',NULL),(7,'2015-03-25 13:34:07','Patch Set 1: Code-Review+2',62,1,62,'7a23299d_563c9493',NULL),(16,'2015-03-24 10:11:54','Patch Set 1: Code-Review+1',62,1,62,'9a0e1d27_9768e488',NULL),(15,'2015-03-24 00:10:34','Uploaded patch set 1.',62,1,62,'9a0e1d27_b75408cb',NULL),(7,'2015-03-25 13:34:11','Patch Set 1: Code-Review+2',63,1,63,'7a23299d_16461c24',NULL),(7,'2015-03-25 13:34:12','Change has been successfully merged into the git repository.',63,1,63,'7a23299d_f64a8026',NULL),(7,'2015-03-25 13:26:59','Patch Set 1: Code-Review+1',63,1,63,'7a23299d_f6c3a088',NULL),(15,'2015-03-24 00:10:34','Uploaded patch set 1.',63,1,63,'9a0e1d27_975104db',NULL),(16,'2015-03-24 10:11:49','Patch Set 1: Code-Review+1',63,1,63,'9a0e1d27_b76be884',NULL),(7,'2015-03-25 13:33:59','Patch Set 1:\n\nI agree, code looks ok on all of these patches. Merging.',64,1,64,'7a23299d_b6bd2805',NULL),(7,'2015-03-25 13:34:16','Change has been successfully merged into the git repository.',64,1,64,'7a23299d_d647841c',NULL),(7,'2015-03-25 13:33:36','Patch Set 1: Code-Review+2',64,1,64,'7a23299d_d6c0a47e',NULL),(15,'2015-03-24 00:10:34','Uploaded patch set 1.',64,1,64,'9a0e1d27_775e70eb',NULL),(16,'2015-03-24 10:11:43','Patch Set 1: Code-Review+1\n\nThe code looks fine in each of these, and I can confirm that its now possible to deploy a minimal system again!',64,1,64,'9a0e1d27_d76e5c96',NULL),(8,'2015-03-24 09:10:41','Patch Set 1: Code-Review+1',65,1,65,'9a0e1d27_175df4e9',NULL),(15,'2015-03-24 00:53:51','Uploaded patch set 1.',65,1,65,'9a0e1d27_57636cb1',NULL),(6,'2015-03-24 10:26:21','Change has been successfully merged into the git repository.',65,1,65,'9a0e1d27_d7f53ccc',NULL),(6,'2015-03-24 10:26:19','Patch Set 1: Code-Review+2',65,1,65,'9a0e1d27_f7f840c6',NULL),(32,'2015-03-24 13:12:15','Patch Set 1: Code-Review+1\n\nLooks reasonable',66,1,66,'9a0e1d27_17b054f3',NULL),(16,'2015-03-24 12:14:36','Uploaded patch set 1.',66,1,66,'9a0e1d27_37b478f1',NULL),(6,'2015-03-24 13:26:03','Change has been successfully merged into the git repository.',66,1,66,'9a0e1d27_578dac30',NULL),(6,'2015-03-24 13:26:01','Patch Set 1:\n\nthanks for fixing this!',66,1,66,'9a0e1d27_7788b022',NULL),(6,'2015-03-24 13:25:56','Patch Set 1: Code-Review+2',66,1,66,'9a0e1d27_979b4472',NULL),(37,'2015-04-22 10:36:51','Patch Set 1:\n\n(2 comments)',67,1,67,'5a7ca5a3_f592989e',NULL),(33,'2015-03-24 12:38:39','Patch Set 1:\n\nPutting the allow anon read after all the project rules makes it *almost* useless.',67,1,67,'9a0e1d27_77a1d0a8',NULL),(33,'2015-03-24 12:31:03','Uploaded patch set 1.',67,1,67,'9a0e1d27_97c46460',NULL),(32,'2015-03-24 13:16:57','Patch Set 1:\n\n(1 comment)\n\nThe change is not bad per-se but does change the semantic of uncommenting the moved \'allow\' statement. I\'d prefer to see a reworked comment in addition to the movement, but could cope without.\n\n+0',67,1,67,'9a0e1d27_b79e4862',NULL),(6,'2015-06-24 16:21:21','Abandoned\n\nRichard Maw has agreed to adopt this change and will resubmit as a separate patch (as changing the owner of an existing change in Gerrit is hard)',67,1,67,'fafc7978_b2dc4076',NULL),(8,'2015-03-25 10:27:16','Change has been successfully merged into the git repository.',68,1,68,'7a23299d_1625fcaa',NULL),(8,'2015-03-25 09:46:40','Patch Set 1: Code-Review+1\n\nI would like that you followed the name order of the packages in this lorry file, but someone decided not to follow it before you.',68,1,68,'7a23299d_3609182d',NULL),(8,'2015-03-25 10:27:14','Patch Set 1: Code-Review+2',68,1,68,'7a23299d_3620f89a',NULL),(27,'2015-03-24 12:57:25','Uploaded patch set 1.',68,1,68,'9a0e1d27_57a6ccc2',NULL),(32,'2015-03-24 13:13:50','Patch Set 1: Code-Review+1\n\nLooks good',68,1,68,'9a0e1d27_f794c045',NULL),(7,'2015-03-25 13:37:32','Abandoned\n\nThis patch was only for testing purposes.',69,1,69,'7a23299d_96510cdb',NULL),(6,'2015-03-24 14:08:38','Patch Set 1: Code-Review-1\n\nI think I preferred it before',69,1,69,'9a0e1d27_179e1457',NULL),(34,'2015-03-24 14:01:13','Uploaded patch set 1.',69,1,69,'9a0e1d27_97722448',NULL),(22,'2015-03-24 15:18:19','Patch Set 1: Code-Review-1\n\nStyle could be two syllables for those with northern English accents so not sure it\'s appropriate for a haiku',69,1,69,'9a0e1d27_f7c9605b',NULL),(11,'2015-03-26 14:12:21','Abandoned',70,1,70,'5a202591_b519a024',NULL),(6,'2015-03-24 17:05:34','Patch Set 1: Code-Review-1\n\nYou should add these settings in the Firehose plugin, rather than adding them to Morph itself. You can do this in the Plugin.enable() method -- see the file morphlib/plugins/distbuild_plugin.py for existing examples.\n\nI think most Morph users will just be confused by these settings, Morph already has too many options, so it\'s good to limit them to Firehose.',70,1,70,'9a0e1d27_57300c56',NULL),(11,'2015-03-24 17:01:09','Uploaded patch set 1.',70,1,70,'9a0e1d27_772b10ec',NULL),(8,'2015-03-25 09:43:45','Change has been successfully merged into the git repository.',71,1,71,'7a23299d_56049414',NULL),(8,'2015-03-25 09:42:53','Patch Set 1: Code-Review+2',71,1,71,'7a23299d_76ff9002',NULL),(6,'2015-03-24 17:24:44','Uploaded patch set 1.',71,1,71,'9a0e1d27_171174ac',NULL),(7,'2015-03-24 17:28:41','Patch Set 1: Code-Review+1',71,1,71,'9a0e1d27_f725e00a',NULL),(37,'2015-03-30 12:34:34','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nLooks sane to me. I\'d like it if you could include configuration added in the baserock/openstack-v5-kernel series, as we\'re more likely to miss the fact that we\'ve forgotten this architecture when we merge all those OpenStack related kernel changes.\nHowever, I won\'t block merging on it, so +1.',72,2,72,'5a2585a7_eddce576',NULL),(26,'2015-03-25 10:14:50','Uploaded patch set 1.',72,1,72,'7a23299d_160e1c35',NULL),(7,'2015-03-25 12:52:45','Patch Set 1: Code-Review+1\n\nLooks good',72,1,72,'7a23299d_367c7872',NULL),(30,'2015-03-25 10:59:36','Patch Set 1: Code-Review+1\n\ntested by myself.',72,1,72,'7a23299d_b633e8f5',NULL),(26,'2015-03-27 18:18:18','Patch Set 1:\n\nAdded IPv6 to BSP kernel build',72,1,72,'9a437d4f_4fa08df4',NULL),(26,'2015-03-27 18:14:39','Uploaded patch set 2.',72,2,72,'9a437d4f_af6139d5',NULL),(NULL,'2015-04-11 08:22:45','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',72,2,72,'9a91bd0f_1f09632c',NULL),(18,'2015-04-11 08:23:09','Patch Set 3: Patch Set 2 was rebased',72,2,72,'9a91bd0f_3f0ea735',NULL),(18,'2015-04-11 08:22:43','Patch Set 2: Code-Review+2',72,2,72,'9a91bd0f_7f042f15',NULL),(18,'2015-04-11 08:23:20','Patch Set 3: Code-Review+2',72,3,72,'9a91bd0f_df121b58',NULL),(18,'2015-04-11 08:23:23','Change has been successfully merged into the git repository.',72,3,72,'9a91bd0f_ff0fdf2c',NULL),(30,'2015-04-01 11:00:30','Patch Set 2: Code-Review+1',72,2,72,'fa5d592f_2aa53f04',NULL),(26,'2015-03-31 16:42:40','Uploaded patch set 3.',73,3,73,'1a2f8d8d_0bbb9d73',NULL),(26,'2015-03-31 16:41:57','Patch Set 2:\n\nWe used the cross-bootstrap systems to build our rootfs\'s, which seemed to work well. We didn\'t test a build system for this purpose, though it\'s good to know that that\'s possible.',73,2,73,'1a2f8d8d_2bb6598b',NULL),(26,'2015-03-31 16:44:39','Patch Set 3:\n\nNew patch adds \'moonshot-kernel\' configuration extension, which was previously omitted',73,3,73,'1a2f8d8d_ebaf312a',NULL),(NULL,'2015-04-14 11:31:53','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I35d2964f, however the current patch set is 3.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',73,3,73,'3aa0d159_1ccad5a1',NULL),(8,'2015-04-14 11:32:01','Patch Set 4: Patch Set 3 was rebased',73,3,73,'3aa0d159_3ccf91b2',NULL),(8,'2015-04-14 11:31:46','Patch Set 3: Code-Review+2',73,3,73,'3aa0d159_bce3a132',NULL),(8,'2015-04-14 11:32:06','Patch Set 4: Code-Review+2',73,4,73,'3aa0d159_dcc30d89',NULL),(8,'2015-04-14 11:32:16','Change has been successfully merged into the git repository.',73,4,73,'3aa0d159_fcc0497e',NULL),(37,'2015-03-30 12:38:40','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks mostly sensible, I\'m not sure whether we need the cross-bootstrap-system though.',73,2,73,'5a2585a7_ade6dd42',NULL),(30,'2015-03-25 11:07:25','Patch Set 1: Code-Review+1\n\ntested by myself',73,1,73,'7a23299d_9630ece9',NULL),(26,'2015-03-25 10:14:50','Uploaded patch set 1.',73,1,73,'7a23299d_f6128057',NULL),(7,'2015-03-25 13:04:59','Patch Set 1: Code-Review-1\n\n(3 comments)\n\nI spotted some errors on these systems. Looks like your systems were defined before we split some strata',73,1,73,'7a23299d_f6dcc076',NULL),(26,'2015-03-27 18:21:12','Patch Set 2:\n\nAmended. For the devel system I additionally added ansible and node.js (which are in the x86 system)',73,2,73,'9a437d4f_2fa54904',NULL),(26,'2015-03-27 18:14:01','Uploaded patch set 2.',73,2,73,'9a437d4f_cf647de7',NULL),(30,'2015-04-01 11:38:07','Patch Set 3: Code-Review+1',73,3,73,'fa5d592f_0acf1bb2',NULL),(37,'2015-04-01 11:56:55','Patch Set 3: Code-Review+1',73,3,73,'fa5d592f_2a41bf0b',NULL),(7,'2015-04-01 08:09:42','Patch Set 3: Code-Review+1\n\nAssuming the previous problems were amended.',73,3,73,'fa5d592f_6affb702',NULL),(8,'2015-04-14 11:32:34','Change has been successfully merged into the git repository.',74,4,74,'3aa0d159_1c41750b',NULL),(8,'2015-04-14 11:00:32','Patch Set 3: Code-Review+2',74,3,74,'3aa0d159_1ca5f503',NULL),(NULL,'2015-04-14 11:00:36','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of Icdcac240.\n* Depends on patch set 2 of I35d2964f, however the current patch set is 3.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',74,3,74,'3aa0d159_3caa31d5',NULL),(8,'2015-04-14 11:32:27','Patch Set 4: Patch Set 3 was rebased',74,3,74,'3aa0d159_5c37fdb0',NULL),(NULL,'2015-04-14 11:31:53','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I35d2964f, however the current patch set is 3.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',74,3,74,'3aa0d159_5cd05d53',NULL),(8,'2015-04-14 11:32:31','Patch Set 4: Code-Review+2',74,4,74,'3aa0d159_7c3c3994',NULL),(NULL,'2015-04-14 11:32:16','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of Icdcac240, however the current patch set is 4.\n* Depends on commit 4413540f5f34978f489d3710aef2690151849242 which has no change associated with it.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',74,3,74,'3aa0d159_9cbd8505',NULL),(37,'2015-03-30 12:41:30','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks sane to me.',74,2,74,'5a2585a7_6dd0f553',NULL),(7,'2015-03-25 13:11:32','Patch Set 1: Code-Review+1',74,1,74,'7a23299d_96e34c33',NULL),(26,'2015-03-25 10:14:50','Uploaded patch set 1.',74,1,74,'7a23299d_d60f842d',NULL),(26,'2015-03-27 18:23:00','Patch Set 2:\n\nAdded some changes missing from the original series.',74,2,74,'9a437d4f_0faa85d4',NULL),(26,'2015-03-27 18:13:32','Uploaded patch set 2.',74,2,74,'9a437d4f_ef6741e9',NULL),(NULL,'2015-04-03 01:55:52','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Icdcac240, however the current patch set is 3.\n* Depends on commit 4413540f5f34978f489d3710aef2690151849242 which has no change associated with it.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',74,2,74,'9a5c5d37_8747864b',NULL),(37,'2015-04-11 20:42:18','Patch Set 3: Code-Review+1',74,3,74,'9a91bd0f_1f6e43ca',NULL),(26,'2015-04-11 18:02:57','Patch Set 3: Patch Set 2 was rebased',74,2,74,'9a91bd0f_9f3333f6',NULL),(8,'2015-04-02 13:37:35','Patch Set 2: Code-Review+2',74,2,74,'ba57610f_48f3df73',NULL),(NULL,'2015-04-02 13:54:54','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Icdcac240, however the current patch set is 3.\n* Depends on commit 4413540f5f34978f489d3710aef2690151849242 which has no change associated with it.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',74,2,74,'ba57610f_88f8b74a',NULL),(7,'2015-04-01 08:12:08','Patch Set 2: Code-Review+1\n\nLooks OK!',74,2,74,'fa5d592f_4a04f314',NULL),(30,'2015-04-01 11:56:18','Patch Set 2: Code-Review+1\n\ntested',74,2,74,'fa5d592f_4a3cf393',NULL),(28,'2015-04-15 13:46:58','Patch Set 4:\n\nI am a bit confused that this was merged without the corresponding installer work [1] being upstreamed, or morph\'s rawdisk extension being augmented to support partitions.\n\nUnless, Big-endian deployment is different than Little-endian deployment, the cluster definition will not work.\n\n[1]: http://git.baserock.org/cgi-bin/cgit.cgi/baserock/baserock/installer-scripts.git/commit/?h=baserock/tiago-ed/m2-moonshot-deployment&id=42b1f0b0d55cf34055e683b8352e9e9d18874c19',75,4,75,'1a9dcd25_1babbb8a',NULL),(8,'2015-04-14 11:31:03','Patch Set 3: Patch Set 2 was rebased',75,2,75,'3aa0d159_1cf3b50b',NULL),(NULL,'2015-04-14 11:32:34','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I6654879d, however the current patch set is 4.\n* Depends on commit ee2e76b4828f85d28d8a94a2b988e2a5830ebe11 which has no change associated with it.\n* Depends on commit 4413540f5f34978f489d3710aef2690151849242 which has no change associated with it.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',75,3,75,'3aa0d159_3c46b124',NULL),(NULL,'2015-04-14 11:31:53','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I35d2964f, however the current patch set is 3.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',75,3,75,'3aa0d159_7cd51942',NULL),(8,'2015-04-14 11:32:47','Change has been successfully merged into the git repository.',75,4,75,'3aa0d159_9c54a5cb',NULL),(NULL,'2015-04-14 11:31:18','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of Icdcac240.\n* Depends on patch set 2 of I35d2964f, however the current patch set is 3.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',75,3,75,'3aa0d159_9ce6e543',NULL),(NULL,'2015-04-14 11:01:46','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I6654879d, however the current patch set is 3.\n* Depends on commit 582f617779c4a25d22928a5d7bad01ffe502d348 which has no change associated with it.\n* Depends on patch set 2 of I35d2964f, however the current patch set is 3.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',75,2,75,'3aa0d159_bcb5e132',NULL),(NULL,'2015-04-14 11:32:16','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of Icdcac240, however the current patch set is 4.\n* Depends on commit 4413540f5f34978f489d3710aef2690151849242 which has no change associated with it.\n* Depends on commit ced9ee45827549c700e7e370fc913534c89081f3 which has no change associated with it.\n* Depends on commit 060fbdd3228573924c6b8ab96a95c9c00ebf8bd2 which has no change associated with it.\n* Depends on commit f9f0f2a84c0c1a0611cfaca341c0b08742f6ac93 which has no change associated with it.\n* Depends on commit 92ef62a187aacaeee48eff6757b009b3ea781a43 which has no change associated with it.\n* Depends on commit 77ab2a3fe6c2bd7115931201db3fc160f4f9dbc4 which has no change associated with it.\n* Depends on commit 42fe6e3e91f1a64f5af15f2d2941d9148ac9ba46 which has no change associated with it.\n* Depends on commit c1f44560a4ca9828af8360e7932764e2e570b597 which has no change associated with it.\n* Depends on commit a6c29daaac4d50ba96a184d33fb2bfd2f68df251 which has no change associated with it.\n* Depends on commit 88346ac0480b2f662172f21cd6cfe131810b873c which has no change associated with it.\n* Depends on commit c1d5fc34e98a39b6956967dac6712a3b9793fe02 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',75,3,75,'3aa0d159_bcbac108',NULL),(8,'2015-04-14 11:32:42','Patch Set 4: Patch Set 3 was rebased',75,3,75,'3aa0d159_dc4a2d27',NULL),(8,'2015-04-14 11:31:16','Patch Set 3: Code-Review+2',75,3,75,'3aa0d159_dcdc6d77',NULL),(8,'2015-04-14 11:32:45','Patch Set 4: Code-Review+2',75,4,75,'3aa0d159_fc47e91b',NULL),(8,'2015-04-14 11:01:43','Patch Set 2: Code-Review+2',75,2,75,'3aa0d159_fcab69d4',NULL),(37,'2015-03-30 12:47:32','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nLooks like the best thing we can do with the tools currently available in morph.',75,2,75,'5a2585a7_0dcf31b2',NULL),(26,'2015-03-25 10:14:50','Uploaded patch set 1.',75,1,75,'7a23299d_b61c086c',NULL),(7,'2015-03-25 13:10:32','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nMore errors in this system',75,1,75,'7a23299d_b6e64843',NULL),(26,'2015-03-27 18:09:43','Uploaded patch set 2.',75,2,75,'9a437d4f_4f79ad92',NULL),(26,'2015-03-27 18:25:36','Patch Set 2:\n\nAmended. Thanks for the comments.',75,2,75,'9a437d4f_efae21e7',NULL),(7,'2015-04-01 08:16:53','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks OK to me now.',75,2,75,'fa5d592f_0a0efb34',NULL),(26,'2015-04-16 09:22:25','Patch Set 4:\n\nSo am i. I was planning to amend this patch series to exclude the M.2 deployment changes, seems i didn\'t get there on time.',75,4,75,'fa6b99d7_ba5e5111',NULL),(26,'2015-04-16 10:33:30','Patch Set 4:\n\nA revert might be sane for all the merged, but currenly non-functional M.2 deployment changes?',75,4,75,'fa6b99d7_da4a2527',NULL),(6,'2015-03-25 14:30:46','Patch Set 1: Code-Review+2',76,1,76,'7a23299d_1614dcf3',NULL),(30,'2015-03-25 11:20:20','Patch Set 1: Code-Review+1',76,1,76,'7a23299d_3657d804',NULL),(6,'2015-03-25 14:43:18','Change has been successfully merged into the git repository.',76,1,76,'7a23299d_762c304b',NULL),(7,'2015-03-25 13:12:36','Patch Set 1: Code-Review+1',76,1,76,'7a23299d_76d0b053',NULL),(26,'2015-03-25 10:32:09','Uploaded patch set 1.',76,1,76,'7a23299d_f63960d9',NULL),(NULL,'2015-03-31 05:25:55','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Id55b8335fc61e8fdf847f5e383cfedd13d07e6d2\n',77,4,77,'1a2f8d8d_4b3c0594',NULL),(NULL,'2015-03-30 17:39:37','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Id55b8335fc61e8fdf847f5e383cfedd13d07e6d2\n',77,4,77,'3a3291f1_8cc44760',NULL),(NULL,'2015-03-26 06:00:58','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Id55b8335fc61e8fdf847f5e383cfedd13d07e6d2\n',77,2,77,'5a202591_755e68eb',NULL),(16,'2015-03-26 11:31:36','Uploaded patch set 3.',77,3,77,'5a202591_d5f53ccc',NULL),(6,'2015-03-30 11:25:03','Patch Set 4: Code-Review+2',77,4,77,'5a2585a7_8db56133',NULL),(16,'2015-03-30 10:34:10','Uploaded patch set 4.',77,4,77,'5a2585a7_ad337df5',NULL),(7,'2015-03-25 17:59:03','Patch Set 2: Code-Review+2\n\nIt does! Merging',77,2,77,'7a23299d_16873c11',NULL),(16,'2015-03-25 11:35:15','Uploaded patch set 1.',77,1,77,'7a23299d_7674309c',NULL),(16,'2015-03-25 11:38:26','Uploaded patch set 2.',77,2,77,'7a23299d_f66720e9',NULL),(NULL,'2015-03-25 18:14:05','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Id55b8335fc61e8fdf847f5e383cfedd13d07e6d2\n',77,2,77,'7a23299d_f67ba027',NULL),(6,'2015-03-25 12:43:57','Patch Set 2: Code-Review+1\n\nMakes sense',77,2,77,'7a23299d_f6ae00e7',NULL),(6,'2015-04-01 16:44:45','Change has been successfully rebased as 59446059d430673c75561233d37d2a319e6188f3',77,5,77,'da6255ed_492be182',NULL),(6,'2015-04-01 16:44:44','Patch Set 6: Patch Set 5 was rebased',77,5,77,'da6255ed_6926a5bc',NULL),(6,'2015-04-01 11:32:32','Patch Set 5: Code-Review+2',77,5,77,'fa5d592f_0af83be4',NULL),(16,'2015-04-01 09:57:25','Uploaded patch set 5.',77,5,77,'fa5d592f_ca36a3e7',NULL),(11,'2015-03-25 14:08:45','Uploaded patch set 1.',78,1,78,'7a23299d_765e70eb',NULL),(6,'2015-03-25 14:20:22','Patch Set 1: Code-Review-1\n\n(3 comments)\n\nGood catch on this bug, but please do a second version of the patch with my comments addressed.',78,1,78,'7a23299d_b66be884',NULL),(11,'2015-03-25 14:36:45','Abandoned',78,1,78,'7a23299d_f6f840c6',NULL),(6,'2015-03-25 14:41:35','Change has been successfully merged into the git repository.',79,1,79,'7a23299d_96ffccaa',NULL),(6,'2015-03-25 14:41:34','Patch Set 1: Code-Review+2',79,1,79,'7a23299d_b602c8b2',NULL),(31,'2015-03-25 14:38:57','Uploaded patch set 1.',79,1,79,'7a23299d_d6f544cc',NULL),(8,'2015-04-14 08:48:07','Patch Set 1: Code-Review+2',80,1,80,'3aa0d159_1c6e55ca',NULL),(8,'2015-04-14 08:48:11','Patch Set 2: Patch Set 1 was rebased',80,1,80,'3aa0d159_3c7311b3',NULL),(8,'2015-04-14 08:48:11','Change has been successfully rebased as 6fa273953645808be9fc81f52eb9093d8d76f15d',80,1,80,'3aa0d159_dc678de9',NULL),(8,'2015-04-13 09:31:53','Patch Set 1: Code-Review+1',80,1,80,'5a93c517_9d1ca36c',NULL),(11,'2015-03-25 14:58:55','Uploaded patch set 1.',80,1,80,'7a23299d_563134a1',NULL),(6,'2015-03-25 16:30:54','Patch Set 1: Code-Review+1\n\nThis is the second version of http://gerrit.baserock.org/#/c/78/\n\nIn future, when you submit the second version of a change, use the same Change-Id as you did for the first version. That way Gerrit groups them together, and it\'s easier to see what changed between the two versions.\n\nThis patch looks fine and ./check passes.',80,1,80,'7a23299d_56a6d4c2',NULL),(7,'2015-03-27 11:00:55','Patch Set 5: Code-Review+1',81,5,81,'1a1a2d67_732680bc',NULL),(27,'2015-03-27 10:30:07','Uploaded patch set 5.',81,5,81,'1a1a2d67_b31c186c',NULL),(7,'2015-03-26 09:27:30','Patch Set 4: Code-Review-1\n\n(1 comment)',81,4,81,'5a202591_3558f0f9',NULL),(8,'2015-03-30 09:31:32','Change has been successfully rebased as 3242c091577510c9055d329f4bf0973e3829fded',81,5,81,'5a2585a7_ad1c9d6b',NULL),(8,'2015-03-30 09:31:32','Patch Set 6: Patch Set 5 was rebased',81,5,81,'5a2585a7_cd0fe92d',NULL),(8,'2015-03-30 09:31:29','Patch Set 5: Code-Review+2',81,5,81,'5a2585a7_ed12a557',NULL),(8,'2015-03-25 16:36:59','Patch Set 3:\n\nthere is a bazaar repository for testresources tarball.',81,3,81,'7a23299d_16b05cf3',NULL),(27,'2015-03-25 15:01:58','Uploaded patch set 1.',81,1,81,'7a23299d_3626b869',NULL),(27,'2015-03-25 16:36:46','Uploaded patch set 4.',81,4,81,'7a23299d_36ab588b',NULL),(27,'2015-03-25 15:52:44','Uploaded patch set 3.',81,3,81,'7a23299d_56bff4d0',NULL),(7,'2015-03-25 15:31:25','Patch Set 2: Code-Review-1\n\n(1 comment)',81,2,81,'7a23299d_b6f088ca',NULL),(27,'2015-03-25 15:28:02','Uploaded patch set 2.',81,2,81,'7a23299d_f6e60016',NULL),(35,'2015-03-25 15:03:08','Uploaded patch set 1.',82,1,82,'7a23299d_162bbc31',NULL),(7,'2015-03-25 15:15:53','Patch Set 1: Code-Review+1\n\nAssuming that it doesn\'t break for x86',82,1,82,'7a23299d_9616acf0',NULL),(6,'2015-03-25 17:31:01','Change has been successfully merged into the git repository.',82,1,82,'7a23299d_d691c453',NULL),(6,'2015-03-25 17:30:48','Patch Set 1: Code-Review+2',82,1,82,'7a23299d_f694c045',NULL),(24,'2015-03-25 15:27:16','Patch Set 1: Code-Review+1\n\nLooks good to me',83,1,83,'7a23299d_16e29c03',NULL),(7,'2015-03-25 15:17:28','Patch Set 1: Code-Review+1\n\nLooks OK to me',83,1,83,'7a23299d_36dd9843',NULL),(6,'2015-03-25 17:31:13','Change has been successfully merged into the git repository.',83,1,83,'7a23299d_969b4c72',NULL),(6,'2015-03-25 17:31:12','Patch Set 1: Code-Review+2',83,1,83,'7a23299d_b69e4862',NULL),(35,'2015-03-25 15:03:08','Uploaded patch set 1.',83,1,83,'7a23299d_f61f2008',NULL),(7,'2015-03-25 17:58:04','Change has been successfully merged into the git repository.',84,1,84,'7a23299d_36823801',NULL),(7,'2015-03-25 17:58:01','Patch Set 1: Code-Review+2',84,1,84,'7a23299d_568db430',NULL),(8,'2015-03-25 17:52:27','Patch Set 1: Code-Review+1',84,1,84,'7a23299d_7688b022',NULL),(35,'2015-03-25 15:16:03','Patch Set 1: Code-Review+1\n\nYep, sorry about adding this in the first place..',84,1,84,'7a23299d_76d31039',NULL),(7,'2015-03-25 15:13:54','Uploaded patch set 1.',84,1,84,'7a23299d_d61c2416',NULL),(8,'2015-03-25 15:56:16','Change has been successfully merged into the git repository.',85,1,85,'7a23299d_16b97ce9',NULL),(8,'2015-03-25 15:56:14','Patch Set 1: Code-Review+2',85,1,85,'7a23299d_36b478f1',NULL),(7,'2015-03-25 15:52:42','Patch Set 1: Code-Review+1',85,1,85,'7a23299d_76baf0e2',NULL),(36,'2015-03-25 15:49:36','Uploaded patch set 1.',85,1,85,'7a23299d_96ed8cf2',NULL),(6,'2015-03-25 16:23:13','Change has been successfully merged into the git repository.',86,1,86,'7a23299d_76a1d0a8',NULL),(6,'2015-03-25 16:23:10','Patch Set 1: Code-Review+2',86,1,86,'7a23299d_96c46c60',NULL),(24,'2015-03-25 16:10:39','Patch Set 1: Code-Review+1\n\nThis looks fine to me',86,1,86,'7a23299d_b6c76864',NULL),(36,'2015-03-25 16:08:48','Uploaded patch set 1.',86,1,86,'7a23299d_d6cae46d',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',87,1,87,'7a23299d_76b670de',NULL),(33,'2015-04-03 13:48:31','Abandoned\n\nThis topic needs to be reworked',87,1,87,'9a5c5d37_47798e92',NULL),(33,'2015-04-03 15:41:48','Patch Set 1:\n\nThanks for reviewing this, but this series was only pushed here as a gerrit experiment, I\'ve abandoned all changes in this series. 207 and 208 are the new changes that correspond to this series.',87,1,87,'9a5c5d37_e7ae42e7',NULL),(8,'2015-04-02 13:07:01','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nJust a nickpicking comment',87,1,87,'ba57610f_28d1cbcd',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',88,1,88,'7a23299d_56bb74c4',NULL),(33,'2015-04-03 13:50:57','Abandoned\n\nThis topic needs to be reworked',88,1,88,'9a5c5d37_47a06ef4',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',89,1,89,'7a23299d_36b0f8dc',NULL),(33,'2015-03-25 19:34:42','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nDon\'t nest conditions unnecessarily...',89,1,89,'7a23299d_f6d040f9',NULL),(33,'2015-04-03 13:49:53','Abandoned\n\nThis topic needs to be reworked',89,1,89,'9a5c5d37_077396b2',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',90,1,90,'7a23299d_16b5fccc',NULL),(33,'2015-04-03 13:50:44','Abandoned\n\nThis topic needs to be reworked',90,1,90,'9a5c5d37_679b72ca',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',91,1,91,'7a23299d_f6c9605b',NULL),(33,'2015-04-03 13:50:36','Abandoned\n\nThis topic needs to be reworked',91,1,91,'9a5c5d37_875e6611',NULL),(33,'2015-03-26 18:45:15','Patch Set 1:\n\nThis submission was just a test, please keep the review to the ml for now. Not because I\'m antigerrit or whatever you\'re likely to assume, just to keep the review in one place.\n\nAnyway your -1 on one aspect of my code without an overall review is greatly appreciated, thanks...',92,1,92,'3a1d315d_d4477c1c',NULL),(15,'2015-03-26 11:17:55','Patch Set 1: Code-Review-1\n\nI think we should stop supporting previous versions of definitions when we want to make a change in morph that will actually break compatibility, not before',92,1,92,'5a202591_550a4cd3',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',92,1,92,'7a23299d_d6c66449',NULL),(33,'2015-04-03 13:49:39','Abandoned\n\nThis topic needs to be reworked',92,1,92,'9a5c5d37_276e9aca',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',93,1,93,'7a23299d_b6c3e837',NULL),(33,'2015-04-03 13:50:29','Abandoned\n\nThis topic needs to be reworked',93,1,93,'9a5c5d37_a7616ad5',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',94,1,94,'7a23299d_96c0ec2b',NULL),(33,'2015-04-03 13:50:20','Abandoned\n\nThis topic needs to be reworked',94,1,94,'9a5c5d37_c7645ee7',NULL),(33,'2015-03-25 19:24:00','Uploaded patch set 1.',95,1,95,'7a23299d_76dd5014',NULL),(33,'2015-04-03 13:50:07','Abandoned\n\nThis topic needs to be reworked',95,1,95,'9a5c5d37_e76762e9',NULL),(6,'2015-03-26 10:42:51','Uploaded patch set 1.',96,1,96,'5a202591_155df4e9',NULL),(7,'2015-03-26 10:54:12','Change has been successfully merged into the git repository.',96,1,96,'5a202591_750548c1',NULL),(7,'2015-03-26 10:54:09','Patch Set 1: Code-Review+2',96,1,96,'5a202591_9568e488',NULL),(8,'2015-03-26 10:47:51','Patch Set 1: Code-Review+1',96,1,96,'5a202591_b56be084',NULL),(16,'2015-03-26 10:45:22','Patch Set 1: Code-Review+1',96,1,96,'5a202591_d56e5c96',NULL),(27,'2015-03-27 13:27:51','Patch Set 1: Code-Review+1\n\nthis has been discussed in person, and the change seems very sensible to me.',97,1,97,'1a1a2d67_b361b8d5',NULL),(15,'2015-03-26 13:39:51','Patch Set 1: -Code-Review\n\nOh, ok. I will test with morph and come back',97,1,97,'5a202591_55312ca1',NULL),(32,'2015-03-26 13:34:52','Patch Set 1:\n\nI\'d add a note that this needs checking against morph. I\'ve only tested\nit against ybd.',97,1,97,'5a202591_752c284b',NULL),(15,'2015-03-26 13:32:15','Patch Set 1: Code-Review+1',97,1,97,'5a202591_95ffc4aa',NULL),(32,'2015-03-26 13:30:18','Uploaded patch set 1.',97,1,97,'5a202591_b502c0b2',NULL),(18,'2015-03-28 07:14:20','Change has been successfully merged into the git repository.',97,1,97,'7a288981_4e041315',NULL),(18,'2015-03-28 07:14:14','Patch Set 1: Code-Review+2',97,1,97,'7a288981_6effcf02',NULL),(11,'2015-03-26 14:04:16','Uploaded patch set 1.',98,1,98,'5a202591_152bb431',NULL),(11,'2015-03-26 14:06:38','Abandoned',98,1,98,'5a202591_d51c1c16',NULL),(11,'2015-03-31 11:09:40','Abandoned\n\nreplaced by bmottram/firehose',99,1,99,'1a2f8d8d_2b82d900',NULL),(11,'2015-03-26 14:04:16','Uploaded patch set 1.',99,1,99,'5a202591_f51f1808',NULL),(6,'2015-03-30 12:57:20','Patch Set 1: Code-Review+1\n\nSeems to also remove a bunch of whitespace errors, but that\'s fine.',99,1,99,'5a2585a7_6d5eb5eb',NULL),(7,'2015-03-26 16:44:09','Patch Set 3: Code-Review+1\n\nI\'m happy with this changes.',100,3,100,'3a1d315d_1473b4b2',NULL),(8,'2015-03-26 16:50:13','Patch Set 3: Code-Review+1\n\nlooks sane to me',100,3,100,'3a1d315d_14aa94d4',NULL),(7,'2015-03-26 15:16:15','Patch Set 1:\n\nThis seems to be working!',100,1,100,'3a1d315d_3409102d',NULL),(6,'2015-03-26 15:14:24','Patch Set 1:\n\nThis comment is a test to see if I receive an email.',100,1,100,'3a1d315d_54048c14',NULL),(6,'2015-03-26 15:13:41','Uploaded patch set 1.',100,1,100,'3a1d315d_74ff8802',NULL),(6,'2015-03-26 16:33:02','Uploaded patch set 3.',100,3,100,'3a1d315d_b44ac053',NULL),(6,'2015-03-26 16:19:25','Uploaded patch set 2.',100,2,100,'3a1d315d_d43d3cbd',NULL),(7,'2015-03-26 16:52:03','Change has been successfully merged into the git repository.',100,3,100,'3a1d315d_d4abfcd4',NULL),(7,'2015-03-26 15:25:51','Patch Set 1: Code-Review+1\n\nAll these changes look OK to me. Thanks Sam for sorting this out.',100,1,100,'3a1d315d_f4127857',NULL),(7,'2015-03-26 16:51:44','Patch Set 3: Code-Review+2\n\nThese scripts look great! I\'m not a fan of \'lineinfile\' but I think I can live with it in some places :)',100,3,100,'3a1d315d_f4aef8e6',NULL),(6,'2015-03-27 09:22:04','Patch Set 2:\n\nI\'ve seen the `install /proc/self/fd/0` pattern cause problems (try running Morph\'s test suite inside a Docker container), and I think it\'s less clear than using \'cat\'.',101,2,101,'1a1a2d67_5304a414',NULL),(6,'2015-03-27 09:21:15','Patch Set 2: Code-Review+2',101,2,101,'1a1a2d67_73ffa002',NULL),(6,'2015-03-27 09:48:52','Change has been successfully merged into the git repository.',101,2,101,'1a1a2d67_f3129057',NULL),(31,'2015-03-26 15:18:07','Uploaded patch set 1.',101,1,101,'3a1d315d_140e1435',NULL),(7,'2015-03-26 15:59:38','Patch Set 1: Code-Review+1\n\n> I removed the pre-configure commands; they prevented the new\n > version of nano (2.4.0) from building.\n\nLooks like they can be removed now. I\'m still OK with this being merged as it is',101,1,101,'3a1d315d_145cd424',NULL),(31,'2015-03-26 15:38:30','Patch Set 1:\n\n(1 comment)',101,1,101,'3a1d315d_3420f09a',NULL),(31,'2015-03-26 15:55:08','Patch Set 1:\n\n(1 comment)',101,1,101,'3a1d315d_3457d004',NULL),(8,'2015-03-26 18:02:16','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks ok but I have a nickpicking comment, I let in your hands to apply it or not.',101,2,101,'3a1d315d_743788b1',NULL),(28,'2015-03-26 15:53:26','Patch Set 1: Code-Review+1\n\n(1 comment)',101,1,101,'3a1d315d_744d4872',NULL),(7,'2015-03-26 15:35:02','Patch Set 1: -Code-Review\n\nThis bug was introduced in 8f8df38eb9857710afd0b550cb863532b37a1593. The reasons to add the pre-configure commands was to support a new architecture. Can you keep the pre-configure commands (assuming you can\'t check test that this builds in aarch64)',101,1,101,'3a1d315d_9419047c',NULL),(7,'2015-03-26 15:30:13','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nMoving it to devtools I think it is a great idea! I\'ve made some comments although I\'m OK if this is merged as it is.',101,1,101,'3a1d315d_b41c006c',NULL),(31,'2015-03-26 15:41:24','Patch Set 1:\n\n(I can\'t remember exactly what the problem was with the pre-configure, some syntax error in ./configure or something.)',101,1,101,'3a1d315d_d4365ce7',NULL),(31,'2015-03-26 15:40:10','Patch Set 1:\n\n> This bug was introduced in 8f8df38eb9857710afd0b550cb863532b37a1593.\n > The reasons to add the pre-configure commands was to support a new\n > architecture. Can you keep the pre-configure commands (assuming you\n > can\'t check test that this builds in aarch64)\n\nI removed the pre-configure commands; they prevented the new version of nano (2.4.0) from building.',101,1,101,'3a1d315d_f43958d9',NULL),(31,'2015-03-26 17:55:04','Uploaded patch set 2.',101,2,101,'3a1d315d_f4c39888',NULL),(37,'2015-04-07 09:16:47','Patch Set 1:\n\n> But the installer will always need changes to know to how map the partitions on the raw disk, to the devices on the target machine\n\nYes, but if the changes are made in the rawdisk.write extension instead, then it is possible to make disk images with partitions for other uses too, since the installer calls out to rawdisk.write to write the contents to the image.',102,1,102,'1a486d77_43ee2624',NULL),(37,'2015-03-26 17:38:33','Patch Set 1: Code-Review-1\n\nAs I said to Tiago when he first submitted this patch on the mailing list, this change should be in rawdisk.write instead, so that we can make partitioned disk images in other circumstances, such as extracting the root disk from the hardware and imaging that directly from your machine.\n\nIf this code goes into rawdisk.write, then it will work for the installer too, since the installer calls out to rawdisk.write',102,1,102,'3a1d315d_14f854e4',NULL),(7,'2015-03-26 17:33:48','Patch Set 1:\n\n(1 comment)',102,1,102,'3a1d315d_74e9c819',NULL),(28,'2015-03-26 17:55:05','Patch Set 1:\n\n(1 comment)\n\n> As I said to Tiago when he first submitted this patch on the\n > mailing list, this change should be in rawdisk.write instead, so\n > that we can make partitioned disk images in other circumstances,\n > such as extracting the root disk from the hardware and imaging that\n > directly from your machine.\n > \n > If this code goes into rawdisk.write, then it will work for the\n > installer too, since the installer calls out to rawdisk.write\n\nBut the installer will always need changes to know to how map the partitions on the raw disk, to the devices on the target machine',102,1,102,'3a1d315d_d4c09c7e',NULL),(26,'2015-03-26 16:02:15','Uploaded patch set 1.',102,1,102,'3a1d315d_f4403837',NULL),(26,'2015-04-29 15:39:49','Abandoned\n\nWill be reimplemented',102,1,102,'bada0100_f61cd815',NULL),(7,'2015-03-27 14:14:06','Patch Set 1: Code-Review+1\n\nMy only worry is that we are starting to have too many IP\'s hardcoded in many places.',103,1,103,'1a1a2d67_73820054',NULL),(6,'2015-03-26 16:34:03','Uploaded patch set 1.',103,1,103,'3a1d315d_9447c44b',NULL),(8,'2015-03-26 16:52:36','Patch Set 1: Code-Review+1',103,1,103,'3a1d315d_b4b8802b',NULL),(6,'2015-03-27 16:56:48','Change has been successfully rebased as eb82ba3f6ba7214765112ec4d58cc1648628d5ab',103,1,103,'9a437d4f_0f25e5aa',NULL),(6,'2015-03-27 16:56:48','Patch Set 2: Patch Set 1 was rebased',103,1,103,'9a437d4f_2f20a99a',NULL),(6,'2015-03-27 16:56:46','Patch Set 1:\n\nToo many IP addresses indeed. We need some kind of DNS solution in our cloud. Or, I wonder if it\'s possible to use Ansible templating to read the IPs from the hosts file?',103,1,103,'9a437d4f_4f2bed82',NULL),(6,'2015-03-27 16:56:03','Patch Set 1: Code-Review+2',103,1,103,'9a437d4f_6f26b1bc',NULL),(7,'2015-03-31 15:14:22','Patch Set 2: Patch Set 1 was rebased',104,1,104,'1a2f8d8d_0b5f1d74',NULL),(7,'2015-03-31 15:14:19','Patch Set 1: Code-Review+2\n\nThis looks good, and I know that is needed to boot a system with intramfs from a USB stick.\n\nThanks for fixing this!',104,1,104,'1a2f8d8d_2b5ad983',NULL),(7,'2015-03-31 15:14:22','Change has been successfully rebased as 062c5d3aece2e308aa7fc03acab1b3b6dd4270b2',104,1,104,'1a2f8d8d_eb53b16a',NULL),(37,'2015-03-26 16:43:27','Uploaded patch set 1.',104,1,104,'3a1d315d_7474289c',NULL),(6,'2015-03-30 17:39:19','Patch Set 1: Code-Review+1\n\nLooks fine to me, I\'ve tested though',104,1,104,'3a3291f1_acc70364',NULL),(15,'2015-03-26 17:36:06','Change has been successfully merged into the git repository.',105,1,105,'3a1d315d_34f3500c',NULL),(24,'2015-03-26 16:43:32','Uploaded patch set 1.',105,1,105,'3a1d315d_54792c92',NULL),(6,'2015-03-26 17:01:05','Patch Set 1: Code-Review+1\n\nLooks fine, there is a trailing whitespace error but I don\'t think it matters here',105,1,105,'3a1d315d_5487ec61',NULL),(15,'2015-03-26 17:36:04','Patch Set 1: Code-Review+2',105,1,105,'3a1d315d_54eecc23',NULL),(37,'2015-03-26 16:44:05','Uploaded patch set 1.',106,1,106,'3a1d315d_346eb0ca',NULL),(8,'2015-03-26 17:43:16','Patch Set 1: Code-Review+1\n\nLooks sensible to me',106,1,106,'3a1d315d_d4d9bc84',NULL),(6,'2015-03-30 17:37:40','Change has been successfully merged into the git repository.',106,1,106,'3a3291f1_ccca4f6e',NULL),(6,'2015-03-30 17:37:35','Patch Set 1: Code-Review+2\n\nSeems sensible.',106,1,106,'3a3291f1_eccd0b88',NULL),(7,'2015-03-26 16:49:45','Change has been successfully merged into the git repository.',107,1,107,'3a1d315d_34a59004',NULL),(7,'2015-03-26 16:49:44','Patch Set 1: Code-Review+2',107,1,107,'3a1d315d_54a00cf4',NULL),(7,'2015-03-26 16:49:34','Patch Set 1: -Code-Review\n\nMerging, this patch looks ok',107,1,107,'3a1d315d_749b08ca',NULL),(7,'2015-03-26 16:49:04','Patch Set 1: Code-Review+2',107,1,107,'3a1d315d_945ea411',NULL),(8,'2015-03-26 16:46:11','Patch Set 1: Code-Review+1\n\nI like this change',107,1,107,'3a1d315d_d4641ce7',NULL),(6,'2015-03-26 16:44:34','Uploaded patch set 1.',107,1,107,'3a1d315d_f46718e9',NULL),(8,'2015-03-26 17:01:21','Patch Set 1: Code-Review+1\n\nMakes sense to me',108,1,108,'3a1d315d_347c7072',NULL),(8,'2015-03-26 18:59:37','Change has been successfully merged into the git repository.',108,1,108,'3a1d315d_745e68eb',NULL),(37,'2015-03-26 16:46:56','Uploaded patch set 1.',108,1,108,'3a1d315d_b461a0d5',NULL),(7,'2015-03-26 17:25:44','Patch Set 1: Code-Review+2\n\nI wasn\'t aware about this issue when writing this script. This change makes sense to me. Thanks for fixing it!',108,1,108,'3a1d315d_d492dc9e',NULL),(11,'2015-03-31 11:09:20','Abandoned\n\nreplaced by bmottram/firehose',109,1,109,'1a2f8d8d_4b8d2531',NULL),(11,'2015-03-26 16:59:33','Topic changed from remove-context-manager to context-manager',109,1,109,'3a1d315d_7482e853',NULL),(11,'2015-03-26 16:57:33','Uploaded patch set 1.',109,1,109,'3a1d315d_94b58433',NULL),(24,'2015-03-26 17:03:26','Uploaded patch set 1.',110,1,110,'3a1d315d_1481744a',NULL),(7,'2015-03-26 17:22:18','Patch Set 1: Code-Review+1\n\nThis looks ok to me',110,1,110,'3a1d315d_f495d888',NULL),(8,'2015-04-14 08:48:52','Change has been successfully merged into the git repository.',110,1,110,'3aa0d159_9c6105d6',NULL),(8,'2015-04-14 08:48:49','Patch Set 1: Code-Review+2',110,1,110,'3aa0d159_fc64c9e6',NULL),(8,'2015-04-13 09:33:16','Patch Set 1: Code-Review+1',110,1,110,'5a93c517_bd195f7b',NULL),(11,'2015-03-31 11:08:56','Abandoned\n\nreplaced by bmottram/firehose',111,1,111,'1a2f8d8d_6b88e122',NULL),(11,'2015-03-26 17:28:11','Uploaded patch set 1.',111,1,111,'3a1d315d_b48f6075',NULL),(11,'2015-03-31 11:08:36','Abandoned\n\nreplaced by bmottram/firehose',112,1,112,'1a2f8d8d_8b9b0d72',NULL),(11,'2015-03-26 17:46:44','Uploaded patch set 1.',112,1,112,'3a1d315d_b4e64043',NULL),(6,'2015-03-26 18:14:37','Uploaded patch set 1.',113,1,113,'3a1d315d_14461424',NULL),(8,'2015-03-26 19:00:32','Change has been successfully merged into the git repository.',113,1,113,'3a1d315d_3458f0f9',NULL),(8,'2015-03-26 19:00:30','Patch Set 1: Code-Review+2',113,1,113,'3a1d315d_54636cb1',NULL),(8,'2015-03-26 18:48:53','Patch Set 1: Code-Review+1\n\nLooks ok to me',113,1,113,'3a1d315d_945104db',NULL),(7,'2015-03-26 18:46:37','Patch Set 1: Code-Review+1\n\nGreat, I know this change fixed things :)',113,1,113,'3a1d315d_b45400cb',NULL),(26,'2015-03-27 11:19:26','Patch Set 1: Code-Review+1',114,1,114,'1a1a2d67_f33970d9',NULL),(30,'2015-03-26 21:04:46','Uploaded patch set 1.',114,1,114,'3a1d315d_145df4e9',NULL),(6,'2015-03-30 17:33:18','Change has been successfully rebased as e6bbd2b9571baa5524c9b2bf74bdce1c83decba0',114,1,114,'3a3291f1_2cb433f1',NULL),(6,'2015-03-30 17:33:17','Patch Set 2: Patch Set 1 was rebased',114,1,114,'3a3291f1_4cbf7fd1',NULL),(6,'2015-03-30 17:33:07','Patch Set 1: Code-Review+2\n\nThis looks fine, the cross-bootstrap script is fairly fragile and needs to run in a fixed environment only, so in this case I think hardcoding PATH is sensible.',114,1,114,'3a3291f1_6cba3be3',NULL),(26,'2015-03-27 11:03:09','Patch Set 1: Code-Review-1\n\n(2 comments)\n\nWhitespace error, and i think the logic could be simplified',115,1,115,'1a1a2d67_3320089b',NULL),(26,'2015-03-27 14:10:35','Patch Set 2: Code-Review+1\n\nYes, looks good to me',115,2,115,'1a1a2d67_b3b8982b',NULL),(30,'2015-03-27 11:47:16','Uploaded patch set 2.',115,2,115,'1a1a2d67_d33674e7',NULL),(30,'2015-03-31 10:56:54','Patch Set 4: Commit message was updated',115,4,115,'1a2f8d8d_4bd88553',NULL),(7,'2015-03-31 12:12:29','Patch Set 4:\n\nBut OTOH, if the build fails because other reasons (the host has to be rebooted or something) this is useful. Also allowing the user to fiddle with the build at this points, helps the process of cross-bootstrap, starting from the beginning is really annoying',115,4,115,'1a2f8d8d_4be2c5d6',NULL),(37,'2015-03-31 12:01:02','Patch Set 4: Code-Review-1\n\nI don\'t like the idea of allowing you to fiddle with the build in the bootstrap at the point where you\'re running on the target, as:\n\n1. I\'m not sure how useful it is, given you may need to go back to earlier chunks and fix those up before your current chunk will build\n2. It would be all to easy to forget to fix up those changes in the definitions, and every attempt afterwards will have to do the same changes.',115,4,115,'1a2f8d8d_6bdd8114',NULL),(6,'2015-03-31 11:06:23','Patch Set 4: Code-Review-1\n\nI think in the source code would be better than in the commit message. But in the commit message is better than only in Gerrit!\n\nOne final blocker: Morph\'s test suite fails with this patch:\n\n$ ./check\nChecking copyright statements\nChecking source code for silliness\nERROR: morphlib/plugins/cross-bootstrap_plugin.py has lines longer than 79 chars\n130 f.write(\'if [ -d /%s.inst/%s.build ]; then rm -rf /%s.inst; fi\\n\' % (name, name, name))\n137 f.write(\' if [ -e /sbin/ldconfig ]; then /sbin/ldconfig; fi\\n\')\n\nIt\'s just due to lines longer than 79 characters. Fix that and I think this can be merged. Thanks!',115,4,115,'1a2f8d8d_8bc42d60',NULL),(30,'2015-03-31 10:58:44','Patch Set 4:\n\nupdated commit message according to Sam\'s comment.',115,4,115,'1a2f8d8d_8bed4df2',NULL),(30,'2015-03-31 10:54:36','Patch Set 3: Commit message was updated',115,3,115,'1a2f8d8d_ab192924',NULL),(6,'2015-03-31 11:08:33','Patch Set 4:\n\nPosting that output again with spaces before each line so it shows up correctly:\n\n $ ./check\n Checking copyright statements\n Checking source code for silliness\n ERROR: morphlib/plugins/cross-bootstrap_plugin.py has lines longer than 79 chars\n 130 f.write(\'if [ -d /%s.inst/%s.build ]; then rm -rf /%s.inst; fi\\n\' % (name, name, name))\n 137 f.write(\' if [ -e /sbin/ldconfig ]; then /sbin/ldconfig; fi\\n\')',115,4,115,'1a2f8d8d_ab9ec961',NULL),(30,'2015-03-26 21:20:13','Uploaded patch set 1.',115,1,115,'3a1d315d_f4715878',NULL),(6,'2015-03-30 17:35:24','Patch Set 2: Code-Review+1\n\nI think the explanations you gave Pedro would be good as comments in the source code!\n\nThis looks sensible other than that.',115,2,115,'3a3291f1_0cb977e9',NULL),(26,'2015-03-30 16:20:40','Patch Set 2: Code-Review+1',115,2,115,'3a3291f1_6c2c7b4b',NULL),(30,'2015-03-30 15:34:32','Patch Set 2:\n\n(2 comments)',115,2,115,'3a3291f1_6c5ebbeb',NULL),(26,'2015-03-30 16:20:24','Patch Set 2: -Code-Review\n\nIf a build for a package fails, running the native bootstrap script again will skip all successful packages and start where it left off. This allows for ongoing fixes to particular build items, without having to edit the script to skip successful packages.',115,2,115,'3a3291f1_8cffa7aa',NULL),(7,'2015-03-30 10:31:49','Patch Set 2:\n\n(2 comments)',115,2,115,'5a2585a7_2d20ad9a',NULL),(26,'2015-05-07 11:34:01','Patch Set 7: Code-Review+1\n\nComments would be nice in the code for clarity, but i think this is a useful enhancement, for convenience when boot-strapping.',115,7,115,'bada0100_2aa51304',NULL),(18,'2015-05-06 18:41:07','Patch Set 7: Patch Set 6 was rebased',115,6,115,'bada0100_6a26bbbc',NULL),(37,'2015-05-12 10:40:38','Change has been successfully rebased as 1c45305237674b71bfe3c896a9a14238d30ac9aa',115,7,115,'bada0100_77269fbc',NULL),(6,'2015-05-07 14:02:35','Patch Set 7: Code-Review+1',115,7,115,'bada0100_8a875f61',NULL),(37,'2015-05-12 10:40:35','Patch Set 7: Code-Review+2',115,7,115,'bada0100_b71c076c',NULL),(37,'2015-05-12 10:40:38','Patch Set 8: Patch Set 7 was rebased',115,7,115,'bada0100_d7198b7a',NULL),(37,'2015-04-01 11:58:05','Patch Set 6:\n\nI still don\'t like the idea.',115,6,115,'fa5d592f_0a46fb23',NULL),(30,'2015-04-01 09:32:47','Patch Set 4:\n\nThis patch doesn\'t make any difference if you need to make change in system definitions, re-build the tarball and re-deploy it. But if you don\'t need to start from the very beginning, this will save time. So you always have a choice.',115,4,115,'fa5d592f_4a2bd382',NULL),(6,'2015-04-01 11:12:18','Patch Set 6: Code-Review+1',115,6,115,'fa5d592f_6a821754',NULL),(30,'2015-04-01 10:29:34','Uploaded patch set 6.',115,6,115,'fa5d592f_ca3d83bd',NULL),(26,'2015-04-01 09:16:40','Patch Set 4:\n\nI agree, this is how we did it, because it\'s a quicker and more direct way of testing changes rather than rebuilding, and redeploying, the tarball for every change.',115,4,115,'fa5d592f_ea128757',NULL),(30,'2015-04-01 10:24:21','Uploaded patch set 5.',115,5,115,'fa5d592f_ea404737',NULL),(28,'2015-03-27 09:39:45','Uploaded patch set 1.',116,1,116,'1a1a2d67_130e2c35',NULL),(27,'2015-03-27 13:05:59','Patch Set 1: Code-Review+1',116,1,116,'1a1a2d67_53794492',NULL),(35,'2015-03-27 13:05:13','Patch Set 1: Code-Review+1\n\nVery useful tool',116,1,116,'1a1a2d67_7374409c',NULL),(8,'2015-03-30 08:54:58','Change has been successfully rebased as f7daed7d106294deca0220b744c41f2acf648a05',116,1,116,'5a2585a7_2d09cd2c',NULL),(8,'2015-03-30 08:54:57','Patch Set 2: Patch Set 1 was rebased',116,1,116,'5a2585a7_4d041915',NULL),(8,'2015-03-30 08:54:52','Patch Set 1: Code-Review+2',116,1,116,'5a2585a7_6dffd502',NULL),(38,'2015-03-27 11:18:25','Uploaded patch set 1.',117,1,117,'1a1a2d67_13250cab',NULL),(16,'2015-03-27 13:15:51','Patch Set 1: -Code-Review\n\n(1 comment)',117,1,117,'1a1a2d67_1373ccb2',NULL),(27,'2015-03-27 13:43:30','Patch Set 1: -Code-Review',117,1,117,'1a1a2d67_53a024f4',NULL),(27,'2015-03-27 13:43:24','Patch Set 1:\n\n(1 comment)',117,1,117,'1a1a2d67_739b20ca',NULL),(27,'2015-03-27 13:04:30','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nfails to clone with https.\nchanging the url to use http: fixes this.',117,1,117,'1a1a2d67_9347dc4b',NULL),(16,'2015-03-27 12:50:44','Patch Set 1: Code-Review+1',117,1,117,'1a1a2d67_d33d54bd',NULL),(38,'2015-03-27 13:22:40','Patch Set 1:\n\nThis is the same lorry file I use in my downstream trove, I can\'t say I\'ve had any errors there.',117,1,117,'1a1a2d67_d36434e7',NULL),(27,'2015-03-27 13:55:02','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nworked first time for me this time when cloning it. putting the fails down to net weirdness.',117,1,117,'1a1a2d67_d3ab14d5',NULL),(16,'2015-03-27 13:50:25','Patch Set 1: Code-Review+1',117,1,117,'1a1a2d67_f3ae10e7',NULL),(29,'2015-03-27 18:12:42','Change has been successfully merged into the git repository.',117,1,117,'9a437d4f_0f73a5b2',NULL),(29,'2015-03-27 18:12:29','Patch Set 1: Code-Review+2',117,1,117,'9a437d4f_2f6e69ca',NULL),(29,'2015-03-27 16:49:50','Patch Set 1: Code-Review+1',117,1,117,'ba3e81b7_5004ac14',NULL),(32,'2015-03-27 15:38:05','Patch Set 1:\n\n(1 comment)',117,1,117,'fa3479d7_f2128857',NULL),(11,'2015-03-27 12:04:58','Uploaded patch set 1.',118,1,118,'1a1a2d67_9330fce9',NULL),(11,'2015-03-31 11:08:09','Abandoned\n\nreplaced by bmottram/firehose',118,1,118,'1a2f8d8d_cb911554',NULL),(11,'2015-03-27 12:04:58','Uploaded patch set 1.',119,1,119,'1a1a2d67_734d6072',NULL),(11,'2015-03-31 11:07:47','Abandoned\n\nreplaced by bmottram/firehose',119,1,119,'1a2f8d8d_eb94d145',NULL),(38,'2015-03-27 13:17:19','Uploaded patch set 1.',120,1,120,'1a1a2d67_f36730e9',NULL),(27,'2015-04-14 13:50:12','Patch Set 2: Code-Review+1\n\n(1 comment)\n\n+1 from me, though as commented, i thought that empty build depends where no longer required? though it wont do any harm i would like to see it removed on merge.',120,2,120,'3aa0d159_dce6ad16',NULL),(15,'2015-03-30 11:18:24','Patch Set 1: Code-Review-1\n\n(1 comment)',120,1,120,'5a2585a7_4da099f4',NULL),(27,'2015-04-22 14:24:23','Patch Set 5:\n\n(1 comment)\n\nA +1 with the condition that build depends as commented is resolved.',120,5,120,'5a7ca5a3_15ab948a',NULL),(38,'2015-04-22 13:07:50','Uploaded patch set 4.',120,4,120,'5a7ca5a3_351490f4',NULL),(32,'2015-04-22 12:58:33','Patch Set 3: Code-Review-1\n\n(2 comments)\n\nOne blocker, one \"is this right?\"',120,3,120,'5a7ca5a3_55058cc0',NULL),(32,'2015-04-22 13:11:17','Patch Set 4: Code-Review-1\n\n(1 comment)\n\nDid you test-build this? If so then we need to kill morph :/',120,4,120,'5a7ca5a3_950244b3',NULL),(38,'2015-04-22 13:43:10','Uploaded patch set 5.',120,5,120,'5a7ca5a3_95f004cb',NULL),(38,'2015-04-22 12:55:16','Uploaded patch set 3.',120,3,120,'5a7ca5a3_f56e1896',NULL),(29,'2015-03-27 16:53:22','Patch Set 1:\n\n(1 comment)',120,1,120,'9a437d4f_af1c996b',NULL),(38,'2015-04-10 11:43:38','Uploaded patch set 2.',120,2,120,'ba8cc1f7_20a52a04',NULL),(6,'2015-04-10 13:32:59','Patch Set 2:\n\nThis looks fine, except: we discussed in IRC today making entity names unique within definitions. To avoid having a chunk and stratum with the same name, could you rename the stratum to \'ocaml-language\' ? Or rename the chunk, or whatever as long as they aren\'t both called \'ocaml\'.',120,2,120,'ba8cc1f7_60e9f219',NULL),(29,'2015-04-10 12:35:40','Patch Set 2: Code-Review+1',120,2,120,'ba8cc1f7_80875661',NULL),(29,'2015-05-01 11:05:38','Patch Set 6: Code-Review+2',120,6,120,'bada0100_04ce065b',NULL),(29,'2015-05-01 11:04:24','Uploaded patch set 6.',120,6,120,'bada0100_44ec0ec8',NULL),(32,'2015-05-01 10:56:33','Patch Set 5: Code-Review+1\n\nLooks good to me. I will have to assume Dan has tested the resultant OCaml compiler :)',120,5,120,'bada0100_a4c37a37',NULL),(29,'2015-05-01 11:05:43','Patch Set 7: Patch Set 6 was rebased',120,6,120,'bada0100_a4da9a15',NULL),(29,'2015-05-01 11:05:43','Change has been successfully rebased as 6dd0128cd1c943a16c38652ac0a8821844771cf7',120,6,120,'bada0100_c4d79eec',NULL),(32,'2015-03-27 15:57:29','Patch Set 1: Code-Review-1\n\n(3 comments)\n\nAt minimum quote things neatly and use $PREFIX not /usr.',120,1,120,'da3975d1_110e2c35',NULL),(29,'2015-04-27 09:15:40','Patch Set 5: Code-Review+1',120,5,120,'dad5f5cf_514db471',NULL),(29,'2015-04-27 09:11:57','Patch Set 4:\n\n> (1 comment)\n > \n > Did you test-build this? If so then we need to kill morph :/\n\nKnown bug, if there\'s a name mismatch, morph silently fails to\ninclude the stratum in the system artifact, please feel free\nto send a patch to fix this.',120,4,120,'dad5f5cf_b130a0e9',NULL),(7,'2015-03-27 14:22:34','Uploaded patch set 2.',121,2,121,'1a1a2d67_53870462',NULL),(7,'2015-03-27 14:12:21','Uploaded patch set 1.',121,1,121,'1a1a2d67_93b59c33',NULL),(6,'2015-03-27 17:50:07','Change has been successfully rebased as 78aec02baca3b28760b38ccef05005b5fd57806e',121,2,121,'9a437d4f_2f578904',NULL),(6,'2015-03-27 17:50:07','Patch Set 3: Patch Set 2 was rebased',121,2,121,'9a437d4f_4f52cd14',NULL),(6,'2015-03-27 17:50:01','Patch Set 2: Code-Review+2',121,2,121,'9a437d4f_6f4d9172',NULL),(11,'2015-03-31 11:07:23','Abandoned\n\nreplaced by bmottram/firehose',122,1,122,'1a2f8d8d_0bb03df3',NULL),(6,'2015-03-30 17:29:53','Patch Set 1: Code-Review+1\n\nUsing the Python logging module would be better, but this OK for now',122,1,122,'3a3291f1_cce36f04',NULL),(11,'2015-03-27 15:08:30','Uploaded patch set 1.',122,1,122,'fa3479d7_3209302d',NULL),(33,'2015-03-30 16:23:23','Change has been successfully rebased as e280d3e4340298ed3cc7f4244f00c8c806c8197a',123,1,123,'3a3291f1_0c2bb731',NULL),(33,'2015-03-30 16:23:22','Patch Set 2: Patch Set 1 was rebased',123,1,123,'3a3291f1_2c267369',NULL),(33,'2015-03-30 16:23:16','Patch Set 1: Code-Review+2',123,1,123,'3a3291f1_4c31bfa1',NULL),(15,'2015-03-30 16:01:37','Patch Set 1: Code-Review+1',123,1,123,'3a3291f1_ccf5afcc',NULL),(38,'2015-03-27 16:02:47','Uploaded patch set 1.',123,1,123,'da3975d1_f1128857',NULL),(7,'2015-03-31 10:48:55','Change has been successfully rebased as 3388b2e893e9c8f4d4ceec5703eca22a2e0f7643',124,1,124,'1a2f8d8d_4b31a5a1',NULL),(7,'2015-03-31 10:48:55','Patch Set 2: Patch Set 1 was rebased',124,1,124,'1a2f8d8d_6b2c614b',NULL),(7,'2015-03-31 10:48:52','Patch Set 1: Code-Review+2',124,1,124,'1a2f8d8d_8bff8daa',NULL),(26,'2015-03-31 10:36:13','Patch Set 1:\n\nThis is needed in general to make networking function correctly. Causes high CPU load and non-functioning network omitted.',124,1,124,'1a2f8d8d_ab0249b2',NULL),(37,'2015-03-30 12:25:03','Patch Set 1: Code-Review+1\n\nLooks good to me, I\'m rather surprised that it wasn\'t enabled by default before, but it\'s obviously correct, and it\'s just a shame that systemd didn\'t support being built without it.',124,1,124,'5a2585a7_4dee5924',NULL),(26,'2015-03-27 16:45:55','Uploaded patch set 1.',124,1,124,'ba3e81b7_70ffb002',NULL),(6,'2015-03-30 10:51:20','Change has been successfully rebased as 32f6684b640de87293353fd0d6faf25238b043b3',125,1,125,'5a2585a7_ad4a5d53',NULL),(6,'2015-03-30 10:51:20','Patch Set 2: Patch Set 1 was rebased',125,1,125,'5a2585a7_cd3da9bd',NULL),(6,'2015-03-30 10:51:03','Patch Set 1: Code-Review+2',125,1,125,'5a2585a7_ed406537',NULL),(26,'2015-03-27 16:53:17','Uploaded patch set 1.',125,1,125,'9a437d4f_4f040d15',NULL),(7,'2015-03-27 17:28:56','Patch Set 1: Code-Review+1',125,1,125,'9a437d4f_ef3981d9',NULL),(37,'2015-03-30 13:41:13','Patch Set 2:\n\n(1 comment)\n\nAs I understand it, this patch depends on the change to installer-scripts which I have -1\'d.\nThis patch ought to declare that dependency, but I\'d rather we make rawdisk.write handle the partitioning required instead and have the cluster morphologies declare the partition layout they require.',126,2,126,'3a3291f1_ac1ca36b',NULL),(26,'2015-03-30 16:47:12','Patch Set 1:\n\nYes, this is dependent on the changes to installer-scripts.',126,1,126,'3a3291f1_cc1c8f16',NULL),(7,'2015-03-30 10:50:31','Patch Set 1:\n\n(2 comments)',126,1,126,'5a2585a7_0d5cd124',NULL),(26,'2015-03-30 11:37:13','Uploaded patch set 2.',126,2,126,'5a2585a7_2d7c2d72',NULL),(26,'2015-03-27 16:53:17','Uploaded patch set 1.',126,1,126,'9a437d4f_2f09c92c',NULL),(7,'2015-03-27 17:30:34','Patch Set 1:\n\n(1 comment)',126,1,126,'9a437d4f_af3379f5',NULL),(26,'2015-04-29 15:41:57','Abandoned\n\nWill be reimplemented',126,2,126,'bada0100_76d8e853',NULL),(NULL,'2015-04-14 00:06:02','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I6bd2f379.\n* Depends on patch set 1 of Id6ba83ec, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',127,3,127,'3aa0d159_1c09752c',NULL),(6,'2015-03-30 10:53:03','Patch Set 1: Code-Review+1\n\nCode looks fine, not sure what \'Allow an user to specify a reboot command either in the cluster morphology or interactively during the deployment.\' in the commit message refers to though',127,1,127,'5a2585a7_8d47a14b',NULL),(37,'2015-03-30 12:49:35','Patch Set 1: Code-Review+1\n\nI agree with Sam here.',127,1,127,'5a2585a7_8dba0109',NULL),(8,'2015-04-13 11:03:09','Patch Set 3: Code-Review+1',127,3,127,'5a93c517_3dcf8fb2',NULL),(37,'2015-04-13 11:54:54','Patch Set 3: Code-Review+2',127,3,127,'5a93c517_3de22f04',NULL),(26,'2015-04-13 10:57:13','Patch Set 3: Patch Set 2 was rebased',127,2,127,'5a93c517_3df8efe4',NULL),(26,'2015-04-13 11:00:26','Patch Set 3:\n\nCommit message amended to more accurately reflect the changes it implements.',127,3,127,'5a93c517_5dd05b53',NULL),(NULL,'2015-04-13 12:02:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I6bd2f379.\n* Depends on patch set 1 of Id6ba83ec, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',127,3,127,'5a93c517_7da677c3',NULL),(26,'2015-04-13 10:52:27','Patch Set 2: Commit message was updated',127,2,127,'5a93c517_bd8cff80',NULL),(26,'2015-03-27 16:53:17','Uploaded patch set 1.',127,1,127,'9a437d4f_0f0e0535',NULL),(26,'2015-04-29 15:41:47','Abandoned\n\nWill be reimplemented',127,3,127,'bada0100_56d36438',NULL),(37,'2015-03-30 13:37:39','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nAll the bits I understand look sane, though I\'d prefer source for the boot.scr',128,1,128,'3a3291f1_2c09d32c',NULL),(35,'2015-03-30 09:35:22','Patch Set 1:\n\nIs it necessary to have the moonshot/* files in definition? Could these not be but somewhere like:\n\nhttp://git.baserock.org/cgi-bin/cgit.cgi/baserock/baserock/bsp-support.git/\n\nIf they could go there then the boot.scr could be a text file that you run \"mkimage\" on in the chunk (makes it easier to edit/compare)',128,1,128,'5a2585a7_8d19e17b',NULL),(6,'2015-03-30 11:17:23','Patch Set 1:\n\n(3 comments)\n\nJames, good point that hardware-specific stuff should go in bsp-support.git instead of definitions.git.\n\nI have a couple of questions too. Approach looks fine though.',128,1,128,'5a2585a7_8d5e8111',NULL),(26,'2015-03-27 16:53:17','Uploaded patch set 1.',128,1,128,'9a437d4f_ef12a157',NULL),(26,'2015-04-29 15:41:36','Abandoned\n\nWill be reimplemented',128,1,128,'bada0100_b61650f0',NULL),(37,'2015-03-30 12:52:15','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLooks fine to me.',129,1,129,'5a2585a7_0d461124',NULL),(6,'2015-03-30 10:55:35','Patch Set 1: Code-Review+1\n\nLooks fine (I didn\'t mean to +2 this, I don\'t know enough about the project)',129,1,129,'5a2585a7_4d79b992',NULL),(6,'2015-03-30 10:55:19','Patch Set 1: Code-Review+2',129,1,129,'5a2585a7_6d74759c',NULL),(26,'2015-03-27 16:53:17','Uploaded patch set 1.',129,1,129,'9a437d4f_cf0fdd2d',NULL),(6,'2015-04-02 11:13:20','Patch Set 1: Code-Review+2\n\nThis has been sat for 3 days with no objections, I\'ll merge it.',129,1,129,'ba57610f_08ecc7c6',NULL),(NULL,'2015-04-02 11:15:52','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I011d710c.\n* Depends on patch set 1 of Ia7daefb7.\n* Depends on patch set 1 of I6bd2f379, however the current patch set is 2.\n* Depends on commit 140c2676e1209325591413381a2bcd9b465b9a30 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',129,1,129,'ba57610f_88d797ed',NULL),(6,'2015-04-02 11:14:12','Patch Set 1:\n\nSeems it\'ll have to wait til the review comments in the other changes are addressed, first.',129,1,129,'ba57610f_a8da5b15',NULL),(NULL,'2015-04-02 11:13:26','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I011d710c.\n* Depends on patch set 1 of Ia7daefb7.\n* Depends on patch set 1 of I6bd2f379, however the current patch set is 2.\n* Depends on commit 140c2676e1209325591413381a2bcd9b465b9a30 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',129,1,129,'ba57610f_c8cd8f5f',NULL),(NULL,'2015-04-02 23:15:54','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I011d710c.\n* Depends on patch set 1 of Ia7daefb7.\n* Depends on patch set 1 of I6bd2f379, however the current patch set is 2.\n* Depends on commit 140c2676e1209325591413381a2bcd9b465b9a30 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',129,1,129,'ba57610f_cb2109b6',NULL),(26,'2015-04-29 15:40:43','Abandoned\n\nWill be reimplemented',129,1,129,'bada0100_9619cc24',NULL),(31,'2015-03-30 15:46:16','Uploaded patch set 5.',130,5,130,'3a3291f1_0c5df7e9',NULL),(15,'2015-03-30 15:35:30','Patch Set 4: Code-Review-1\n\n(2 comments)',130,4,130,'3a3291f1_2c58b3f9',NULL),(31,'2015-03-30 15:08:08','Patch Set 4:\n\nv4 changed the output from \"In foo:\" to \"In stratum foo:\".',130,4,130,'3a3291f1_4c3c1f94',NULL),(31,'2015-03-30 14:14:14','Patch Set 1:\n\n> Would it be possible to change to `morph info`\n\nPerhaps, although that might increase the scope of the tool\nconsiderably. I think I would expect `morph info` to be\nable to provide info about strata, systems and clusters, as\nwell as chunks.',130,1,130,'3a3291f1_4c52df14',NULL),(16,'2015-03-30 15:07:29','Patch Set 4: Code-Review+1',130,4,130,'3a3291f1_6c37dbb1',NULL),(31,'2015-03-30 14:26:32','Uploaded patch set 3.',130,3,130,'3a3291f1_6c9b5bca',NULL),(6,'2015-03-30 17:23:10','Change has been successfully merged into the git repository.',130,5,130,'3a3291f1_6cd35b39',NULL),(6,'2015-03-30 17:22:47','Patch Set 5:\n\nLooks fine to me, nice work!',130,5,130,'3a3291f1_8c1687f0',NULL),(31,'2015-03-30 14:02:52','Patch Set 1:\n\n(1 comment)\n\nFixed ./check --full in v2.',130,1,130,'3a3291f1_8c30c7e9',NULL),(31,'2015-03-30 15:03:55','Uploaded patch set 4.',130,4,130,'3a3291f1_8cba0709',NULL),(6,'2015-03-30 17:22:20','Patch Set 5: Code-Review+2',130,5,130,'3a3291f1_ac194324',NULL),(31,'2015-03-30 15:47:36','Patch Set 4:\n\n(2 comments)',130,4,130,'3a3291f1_ac6b8384',NULL),(16,'2015-03-30 14:56:15','Patch Set 3: Code-Review+1\n\nLooks good to me!',130,3,130,'3a3291f1_ace6e342',NULL),(16,'2015-03-30 14:18:18','Patch Set 2:\n\n(1 comment)\n\nLooks good now, except for the leftover unused _load_all_sysbranch_morphologies function.',130,2,130,'3a3291f1_cc3dafbd',NULL),(15,'2015-03-30 14:33:34','Patch Set 3:\n\nExactly, info is generic enough so we can add support for other components in the future with the same command\n\nAlso, as a user of other system, I think \"morph info\" is uch more intuitive than \"morph get-chunk-details\"\n\nAnd, as I said before, in the future maybe we use another terminology to refer to chunks',130,3,130,'3a3291f1_ccab6fd5',NULL),(31,'2015-03-30 14:00:35','Uploaded patch set 2.',130,2,130,'3a3291f1_ec398bd9',NULL),(31,'2015-03-30 14:30:12','Patch Set 2:\n\n(1 comment)',130,2,130,'3a3291f1_ecae2be7',NULL),(16,'2015-03-30 15:59:10','Patch Set 5: Code-Review+1',130,5,130,'3a3291f1_ecf86bc6',NULL),(15,'2015-03-30 13:14:16','Patch Set 1:\n\nWould it be possible to change:\n\nmorph get-chunk-details \nfor\nmorph info \n\nI think its easier to remember and maybe in the future we use other therminologu to refer to chunks',130,1,130,'5a2585a7_0d5df1e9',NULL),(16,'2015-03-30 12:57:24','Patch Set 1:\n\n(1 comment)\n\nGreat, thanks!',130,1,130,'5a2585a7_4d63f9b1',NULL),(16,'2015-03-30 12:06:23','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI have a minor comment on the code, and also the test suite doesn\'t pass. You\'ll need to add morphlib/plugins/get_chunk_details_plugin.py to without-test-modules, and then write a Yarn for this plugin if you like (I don\'t mind if you don\'t write a Yarn).',130,1,130,'5a2585a7_cd92499f',NULL),(31,'2015-03-30 12:52:58','Patch Set 1:\n\n(1 comment)\n\nThanks, I\'ll fix up ./check --full',130,1,130,'5a2585a7_ed4aa526',NULL),(31,'2015-03-27 16:55:04','Uploaded patch set 1.',130,1,130,'9a437d4f_8f19d57b',NULL),(6,'2015-03-30 13:41:19','Change has been successfully rebased as c092bb9f60ef8c37d81210f8be3579af7b90ba70',131,4,131,'3a3291f1_4c2bff82',NULL),(6,'2015-03-30 13:41:18','Patch Set 5: Patch Set 4 was rebased',131,4,131,'3a3291f1_6c26bbbc',NULL),(6,'2015-03-30 13:41:16','Patch Set 4:\n\nMerging to master to avoid this becoming stale. Seems to work fine.',131,4,131,'3a3291f1_8c19e77b',NULL),(6,'2015-03-30 13:41:00','Patch Set 4: Code-Review+2',131,4,131,'3a3291f1_cc0fef2d',NULL),(6,'2015-03-30 09:06:37','Patch Set 3:\n\nThe certificate is a (sort of) temporary one generated by Daniel using his personal account with StartSSL. The plan is to replace it with one generated by Codethink, although since the current certificate works fine, I\'m not sure when this will be done now -- Gary will know more. I tried to indicate this situation in the filename so that we don\'t forget :)',131,3,131,'5a2585a7_0d0e1135',NULL),(7,'2015-03-30 12:59:40','Patch Set 4: Code-Review+1',131,4,131,'5a2585a7_2d58adf9',NULL),(6,'2015-03-30 12:51:23','Uploaded patch set 4.',131,4,131,'5a2585a7_4d3c1994',NULL),(18,'2015-03-28 07:19:00','Patch Set 3:\n\nIs \'temporary-dsilverstone\' intentional?',131,3,131,'7a288981_2e09c72c',NULL),(6,'2015-03-27 17:51:47','Uploaded patch set 2.',131,2,131,'9a437d4f_0f5cc524',NULL),(7,'2015-03-27 18:16:07','Patch Set 3: Code-Review+1\n\n(1 comment)\n\nJust one error spotted. Everything else looks great. Feel free to merge once you have fixed it',131,3,131,'9a437d4f_6f9b51ca',NULL),(6,'2015-03-27 17:43:57','Uploaded patch set 1.',131,1,131,'9a437d4f_8f30b5e9',NULL),(6,'2015-03-27 18:06:13','Uploaded patch set 3.',131,3,131,'9a437d4f_8f47954b',NULL),(7,'2015-03-27 18:00:52','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nHad a couple of comments in the README, but everything looks sane.',131,2,131,'9a437d4f_af4a5953',NULL),(11,'2015-03-30 15:54:18','Abandoned',132,1,132,'3a3291f1_4c0adfd3',NULL),(11,'2015-03-30 10:44:07','Uploaded patch set 1.',132,1,132,'5a2585a7_8d30c1e9',NULL),(6,'2015-03-30 11:24:25','Patch Set 1: Code-Review-1\n\nI have some comments, and seems this branch included lots of other changes (there seem to be 19 \'related patches\')',132,1,132,'5a2585a7_adb81d2b',NULL),(6,'2015-03-30 11:24:02','Patch Set 1: Code-Review+2\n\n(2 comments)',132,1,132,'5a2585a7_cdab69d5',NULL),(15,'2015-03-30 11:13:27','Uploaded patch set 1.',133,1,133,'5a2585a7_2d6e6dca',NULL),(15,'2015-03-30 11:20:23','Patch Set 1:\n\nYou are rigth, profile was added in 1.6 and Ubuntu 12.04 only has 1.4 . Should I keep this patch here for the future or should I discard it. Is there any pland to stop supporting 12.04 at any point?',133,1,133,'5a2585a7_2da54d04',NULL),(6,'2015-03-30 11:32:13','Patch Set 1: Code-Review+1\n\nHaving checked, at least some of the users I\'m supporting have updated to 14.04. So I don\'t think we need to worry about that any more.',133,1,133,'5a2585a7_4d877962',NULL),(6,'2015-03-30 11:18:14','Patch Set 1: Code-Review-1\n\nAs far as I know, we still need this to work on Ubuntu 12.04, so still need to use the deprecated feature.\n\nI\'ll double check though.',133,1,133,'5a2585a7_6d9b55ca',NULL),(32,'2015-04-22 12:50:14','Patch Set 1:\n\nI am concerned that this might not migrate users properly. can you give a treatment to migration from one version of the tool to the next?',133,1,133,'5a7ca5a3_d5719c78',NULL),(15,'2015-05-18 12:15:01','Patch Set 1: Code-Review+2',133,1,133,'9adffdf1_cf7b3d28',NULL),(15,'2015-05-18 12:15:04','Change has been successfully merged into the git repository.',133,1,133,'9adffdf1_ef78812d',NULL),(32,'2015-05-13 16:52:02','Patch Set 1: Code-Review+1\n\n[snip]\n > I then installed a new chroot with `manage-baserock add`. This new\n > chroot worked fine, as do my existing chroots, and I no longer see\n > the warning for any of them.\n\n\nThen I withdraw my concerns.',133,1,133,'bada0100_37b6d78b',NULL),(6,'2015-05-13 16:35:16','Patch Set 1:\n\n> I am concerned that this might not migrate users properly. can you\n > give a treatment to migration from one version of the tool to the\n > next?\n\nI applied this patch and ran `make install` in baserock-chroot.git. I already had some chroots and these continued to work and continued to show the following warning:\n\n cd /src/mW: line 79 [baserock-15.17-rc]: Deprecated key ‘script-config’ used\n I: This option will be removed in the future; please update your configuration\n W: line 86 [baserock-15.19]: Deprecated key ‘script-config’ used\n I: This option will be removed in the future; please update your configuration\n\nI then installed a new chroot with `manage-baserock add`. This new chroot worked fine, as do my existing chroots, and I no longer see the warning for any of them.',133,1,133,'bada0100_97c1c3e6',NULL),(6,'2015-03-30 13:17:39','Patch Set 1:\n\n(4 comments)\n\nThis looks mostly fine. I think that it\'d be better to squash the 3 commits you sent into one, it\'d be easier to review them here in Gerrit that way.',134,1,134,'5a2585a7_6d0595c1',NULL),(39,'2015-03-30 12:23:58','Uploaded patch set 1.',134,1,134,'5a2585a7_ad8ffd74',NULL),(16,'2015-03-30 13:24:25','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI set this up on a distbuild network to try it out, and it seems cool and very useful. However I had to make a change to actually get any output due to a TypeError being raised when the InitiatorListJobs tried to show the message.',134,1,134,'5a2585a7_edf865c6',NULL),(39,'2015-04-09 11:28:36','Abandoned\n\nMerged into 136',134,1,134,'da87b5cf_a14a9e53',NULL),(6,'2015-04-01 11:27:56','Patch Set 1:\n\nI think this now obsolete because of https://gerrit.baserock.org/#/c/136/8, could you abandon it?',134,1,134,'fa5d592f_6ae9f719',NULL),(6,'2015-03-30 13:19:29','Patch Set 1: Code-Review+1\n\nI\'m not sure the build_plugin is the right place for this. distbuild_plugin is probably a better place.',135,1,135,'5a2585a7_2d0f8de3',NULL),(39,'2015-03-30 12:23:58','Uploaded patch set 1.',135,1,135,'5a2585a7_8d8c4181',NULL),(16,'2015-03-30 13:25:23','Patch Set 1:\n\nI agree that this should live in distbuild_plugin. Looks fine other than that though.',135,1,135,'5a2585a7_cdf5a9cc',NULL),(39,'2015-04-09 11:28:54','Abandoned\n\nMerged into 136',135,1,135,'da87b5cf_c147a24a',NULL),(6,'2015-04-01 11:27:36','Patch Set 1: -Code-Review\n\nI think this is now obsolete because of https://gerrit.baserock.org/#/c/136/8 , could you abandon this change?',135,1,135,'fa5d592f_8a8c2b81',NULL),(33,'2015-03-31 10:53:45','Patch Set 5: Code-Review-1\n\n(1 comment)\n\nWe should rework this to use something other than randint() for id generation, sorry. :(',136,5,136,'1a2f8d8d_0b2b9d31',NULL),(39,'2015-03-31 16:22:03','Uploaded patch set 7.',136,7,136,'1a2f8d8d_4bc1a5e3',NULL),(29,'2015-03-31 17:29:41','Patch Set 7: Code-Review-1\n\n(4 comments)\n\nHi again, thanks for this.\n\nThis is almost there imo, there is one length check that happens before we enter a loop that shouldn\'t be needed.\n\nI\'d also really like to see either constants defined when you construct the InitiatorConnectionMachine or even better have them defined in self.app.settings. Since there\'s now 2 sites for constructing the InitiatorConnectionMachine we run the risk of updating constants in one section of the code and forgetting to update them in another leading to inconsistent connection behaviour.',136,7,136,'1a2f8d8d_6b4a2185',NULL),(39,'2015-03-31 13:26:00','Uploaded patch set 6.',136,6,136,'1a2f8d8d_8bd78ded',NULL),(33,'2015-03-31 17:59:42','Patch Set 7:\n\n> (4 comments)\n > \n > Hi again, thanks for this.\n > \n > This is almost there imo, there is one length check that happens\n > before we enter a loop that shouldn\'t be needed.\n > \n > I\'d also really like to see either constants defined when you\n > construct the InitiatorConnectionMachine or even better have them\n > defined in self.app.settings. Since there\'s now 2 sites for\n > constructing the InitiatorConnectionMachine we run the risk of\n > updating constants in one section of the code and forgetting to\n > update them in another leading to inconsistent connection\n > behaviour.\n\nThinking about it, making reconnect_interval and max_retries command line arguments should probably be a separate change, so for now defining these in constants would be great.',136,7,136,'1a2f8d8d_cb5a3550',NULL),(39,'2015-03-31 11:14:09','Patch Set 5:\n\n(4 comments)',136,5,136,'1a2f8d8d_eb7bb127',NULL),(33,'2015-04-07 18:46:55','Patch Set 11:\n\n(2 comments)\n\nHey, thanks for the change\n\nI don\'t know how to vote on this just yet, I\'d suggest more nicely formatted output if the command is for use by humans.\n\nMy slight concerns over overloading the term \'jobs\' remain\nfrom the previous set.',136,11,136,'1a486d77_6626d0bc',NULL),(39,'2015-04-07 17:17:22','Uploaded patch set 11.',136,11,136,'1a486d77_a305da15',NULL),(6,'2015-04-15 16:49:28','Patch Set 17: Code-Review+1\n\nNot tested this yet, but older versions worked fine for me.',136,17,136,'1a9dcd25_1b9f3b05',NULL),(39,'2015-04-15 11:56:30','Uploaded patch set 17.',136,17,136,'1a9dcd25_fb6e0f96',NULL),(39,'2015-03-30 15:17:07','Uploaded patch set 5.',136,5,136,'3a3291f1_0c461724',NULL),(39,'2015-03-30 15:14:14','Uploaded patch set 4.',136,4,136,'3a3291f1_2c41d30b',NULL),(39,'2015-03-30 14:22:14','Uploaded patch set 2.',136,2,136,'3a3291f1_2c6e73ca',NULL),(29,'2015-03-30 19:59:53','Patch Set 5:\n\n(6 comments)\n\nGreetings :)\n\nI\'m reviewing this for 2 reasons, firstly because I need to try and get used to gerrit and secondly because I have a soft spot for distbuild and these changes look really cool.\n\nI have a couple of questions, esp regarding the randomly generated id,\nother things are just minor issues.\n\nI do not feel qualified to give a score on this in its current state,\nnonetheless it would be lovely to have my curiosity satisfied.',136,5,136,'3a3291f1_6cdd9b14',NULL),(16,'2015-03-30 15:25:33','Patch Set 5: Code-Review+1\n\nLooks fine to me. I\'ve tested this on a distbuild network and it works nicely. Thanks!',136,5,136,'3a3291f1_ac54a3ca',NULL),(39,'2015-03-30 14:23:28','Uploaded patch set 3.',136,3,136,'3a3291f1_ec674be9',NULL),(39,'2015-04-14 15:51:55','Uploaded patch set 16.',136,16,136,'3aa0d159_1cb415f1',NULL),(6,'2015-03-30 13:23:00','Patch Set 1:\n\nAs I said in the other change, I think these 3 commits would make more sense squashed into one commit.\n\nCould you give an example of the output this command gives?',136,1,136,'5a2585a7_0d14d1f3',NULL),(39,'2015-03-30 12:23:58','Uploaded patch set 1.',136,1,136,'5a2585a7_6de9151a',NULL),(16,'2015-03-30 13:28:15','Patch Set 1:\n\n(1 comment)',136,1,136,'5a2585a7_8dffa1aa',NULL),(39,'2015-04-05 18:09:19','Uploaded patch set 10.',136,10,136,'5a4e6583_e512b657',NULL),(6,'2015-04-13 10:25:02','Patch Set 15: Code-Review+1\n\nFine by me to merge this change, we do still need to make the output neater though',136,15,136,'5a93c517_3d730fb3',NULL),(33,'2015-04-04 09:49:56','Patch Set 9: Code-Review-1\n\n(2 comments)\n\nSorry for +1ing this earlier, I didn\'t spot the initiator_name issue.\nThanks Sam!',136,9,136,'7a51691d_060efa34',NULL),(6,'2015-04-02 11:09:48','Patch Set 9: Code-Review-1\n\n(2 comments)\n\nThanks for doing a new version, I\'m afraid I found a new issue',136,9,136,'ba57610f_48e2bfd6',NULL),(39,'2015-04-02 16:40:02','Patch Set 9:\n\n(1 comment)',136,9,136,'ba57610f_4b3cf993',NULL),(39,'2015-04-02 17:44:51','Patch Set 9:\n\n(1 comment)',136,9,136,'ba57610f_4bbf59d1',NULL),(6,'2015-04-02 17:01:42','Patch Set 9:\n\n(1 comment)',136,9,136,'ba57610f_cbf589cc',NULL),(8,'2015-04-10 08:32:00','Patch Set 14:\n\n> > I tested this with 0, 1 and 2 jobs, and it seems to work. Output\n > > with 2 jobs (using a local test distbuild instance):\n > >\n > > 2015-04-09 13:42:49 Connecting to localhost:59804\n > > 2015-04-09 13:42:49 Requesting currently running distbuilds.\n > > 2015-04-09 13:42:49 2 distbuild requests(s) currently in progress\n > > Initiator connection (address:port): 127.0.0.1:55898\n > > Build request message: {\'partial\': False, \'ref\':\n > \'15708549ae011f20408915086\n > > 4766b734aa62cac\', \'component_names\': [], \'repo\':\n > \'baserock:baserock/definit\n > > ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\',\n > > \'morphol\n > > ogy\': \'systems/build-system-x86_64-chroot.morph\',\n > \'protocol_version\':\n > > 2, \'t\n > > ype\': \'build-request\', \'id\': \'InitiatorConnection-2\'}\n > > Build request ID: InitiatorConnection-2\n > > Initiator connection (address:port): 127.0.0.1:56252\n > > Build request message: {\'partial\': False, \'ref\':\n > \'15708549ae011f20408915086\n > > 4766b734aa62cac\', \'component_names\': [], \'repo\':\n > \'baserock:baserock/definit\n > > ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\',\n > > \'morphol\n > > ogy\': \'systems/devel-system-x86_64-chroot.morph\',\n > \'protocol_version\':\n > > 2, \'t\n > > ype\': \'build-request\', \'id\': \'InitiatorConnection-3\'}\n > > Build request ID: InitiatorConnection-3\n > >\n > > This does seem to work now and I\'m happy with the code, so I\n > think\n > > it\'d be ok to merge it. However, the output is pretty hard to\n > read.\n > > Here\'s a suggestion for a format that I think would be clearer:\n > >\n > > 2015-04-09 13:42:49 Connecting to localhost:59804\n > > 2015-04-09 13:42:49 Requesting currently running distbuilds.\n > > 2015-04-09 13:42:49 2 distbuild requests(s) currently in progress\n > > Build request ID: InitiatorConnection-2\n > > Initiator: 127.0.0.1:55898\n > > Repo: baserock:baserock/definitions\n > > Ref: 15708549ae011f204089150864766b734aa62cac\n > > Component: systems/build-system-x86_64-chroot.morph\n > >\n > > Build request ID: InitiatorConnection-3\n > > Initiator: 127.0.0.1:56252\n > > Repo: baserock:baserock/definitions\n > > Ref: 15708549ae011f204089150864766b734aa62cac\n > > Component: systems/devel-system-x86_64-chroot.morph\n > \n > +-----------------+-------------------------------+---------+\n > | initiator | repo | ref |\n > +-----------------+-------------------------------+---------+\n > | 127.0.0.1:56252 | baserock:baserock/definitions | master |\n > | 127.0.0.1:55898 | baserock:baserock/definitions | devel |\n > +-----------------+-------------------------------+---------+\n > \n > needs to include the component as well...\n > the openstack clients allow you to specify which columns should be\n > included\n > by passing cli args. maybe there\'s even an existing library we\n > could use\n\nFYI, Openstack uses python-prettytable to creates this kind of table.',136,14,136,'ba8cc1f7_2009aa2c',NULL),(39,'2015-04-10 15:01:56','Uploaded patch set 15.',136,15,136,'ba8cc1f7_80ee7621',NULL),(29,'2015-04-10 08:50:45','Patch Set 14:\n\n> > > I tested this with 0, 1 and 2 jobs, and it seems to work.\n > Output\n > > > with 2 jobs (using a local test distbuild instance):\n > > >\n > > > 2015-04-09 13:42:49 Connecting to localhost:59804\n > > > 2015-04-09 13:42:49 Requesting currently running distbuilds.\n > > > 2015-04-09 13:42:49 2 distbuild requests(s) currently in\n > progress\n > > > Initiator connection (address:port): 127.0.0.1:55898\n > > > Build request message: {\'partial\': False, \'ref\':\n > > \'15708549ae011f20408915086\n > > > 4766b734aa62cac\', \'component_names\': [], \'repo\':\n > > \'baserock:baserock/definit\n > > > ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\',\n > > > \'morphol\n > > > ogy\': \'systems/build-system-x86_64-chroot.morph\',\n > > \'protocol_version\':\n > > > 2, \'t\n > > > ype\': \'build-request\', \'id\': \'InitiatorConnection-2\'}\n > > > Build request ID: InitiatorConnection-2\n > > > Initiator connection (address:port): 127.0.0.1:56252\n > > > Build request message: {\'partial\': False, \'ref\':\n > > \'15708549ae011f20408915086\n > > > 4766b734aa62cac\', \'component_names\': [], \'repo\':\n > > \'baserock:baserock/definit\n > > > ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\',\n > > > \'morphol\n > > > ogy\': \'systems/devel-system-x86_64-chroot.morph\',\n > > \'protocol_version\':\n > > > 2, \'t\n > > > ype\': \'build-request\', \'id\': \'InitiatorConnection-3\'}\n > > > Build request ID: InitiatorConnection-3\n > > >\n > > > This does seem to work now and I\'m happy with the code, so I\n > > think\n > > > it\'d be ok to merge it. However, the output is pretty hard to\n > > read.\n > > > Here\'s a suggestion for a format that I think would be clearer:\n > > >\n > > > 2015-04-09 13:42:49 Connecting to localhost:59804\n > > > 2015-04-09 13:42:49 Requesting currently running distbuilds.\n > > > 2015-04-09 13:42:49 2 distbuild requests(s) currently in\n > progress\n > > > Build request ID: InitiatorConnection-2\n > > > Initiator: 127.0.0.1:55898\n > > > Repo: baserock:baserock/definitions\n > > > Ref: 15708549ae011f204089150864766b734aa62cac\n > > > Component: systems/build-system-x86_64-chroot.morph\n > > >\n > > > Build request ID: InitiatorConnection-3\n > > > Initiator: 127.0.0.1:56252\n > > > Repo: baserock:baserock/definitions\n > > > Ref: 15708549ae011f204089150864766b734aa62cac\n > > > Component: systems/devel-system-x86_64-chroot.morph\n > >\n > > +-----------------+-------------------------------+---------+\n > > | initiator | repo | ref |\n > > +-----------------+-------------------------------+---------+\n > > | 127.0.0.1:56252 | baserock:baserock/definitions | master |\n > > | 127.0.0.1:55898 | baserock:baserock/definitions | devel |\n > > +-----------------+-------------------------------+---------+\n > >\n > > needs to include the component as well...\n > > the openstack clients allow you to specify which columns should\n > be\n > > included\n > > by passing cli args. maybe there\'s even an existing library we\n > > could use\n > \n > FYI, Openstack uses python-prettytable to creates this kind of\n > table.\n\nhttps://code.google.com/p/prettytable/\n\nAwesome! I\'d love it if we made this command use this,\nbut as Sam says we should have the controller send back\nthe json to the initiator which would then use prettytable\nto output the list of build requests',136,14,136,'ba8cc1f7_e012e257',NULL),(6,'2015-04-17 08:40:06','Patch Set 17: Code-Review+2',136,17,136,'da7095c5_390ecf35',NULL),(6,'2015-04-17 08:41:58','Patch Set 18: Patch Set 17 was rebased',136,17,136,'da7095c5_d9123358',NULL),(6,'2015-04-17 08:41:59','Change has been successfully rebased as ab92ce0343b838b336313f604ea035a60dfcb960',136,17,136,'da7095c5_f90ff72c',NULL),(6,'2015-04-09 11:26:33','Patch Set 12:\n\nOh! Also I missed the last line off that traceback, sorry. It was:\n\n NameError: global name \'jobs\' is not defined',136,12,136,'da87b5cf_013eeab8',NULL),(39,'2015-04-09 11:32:36','Uploaded patch set 13.',136,13,136,'da87b5cf_216e8eca',NULL),(6,'2015-04-09 13:47:57','Patch Set 14: Code-Review+1\n\nI tested this with 0, 1 and 2 jobs, and it seems to work. Output with 2 jobs (using a local test distbuild instance):\n\n 2015-04-09 13:42:49 Connecting to localhost:59804\n 2015-04-09 13:42:49 Requesting currently running distbuilds.\n 2015-04-09 13:42:49 2 distbuild requests(s) currently in progress\n Initiator connection (address:port): 127.0.0.1:55898\n Build request message: {\'partial\': False, \'ref\': \'15708549ae011f20408915086\n 4766b734aa62cac\', \'component_names\': [], \'repo\': \'baserock:baserock/definit\n ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\', \'morphol\n ogy\': \'systems/build-system-x86_64-chroot.morph\', \'protocol_version\': 2, \'t\n ype\': \'build-request\', \'id\': \'InitiatorConnection-2\'}\n Build request ID: InitiatorConnection-2\n Initiator connection (address:port): 127.0.0.1:56252\n Build request message: {\'partial\': False, \'ref\': \'15708549ae011f20408915086\n 4766b734aa62cac\', \'component_names\': [], \'repo\': \'baserock:baserock/definit\n ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\', \'morphol\n ogy\': \'systems/devel-system-x86_64-chroot.morph\', \'protocol_version\': 2, \'t\n ype\': \'build-request\', \'id\': \'InitiatorConnection-3\'}\n Build request ID: InitiatorConnection-3\n\nThis does seem to work now and I\'m happy with the code, so I think it\'d be ok to merge it. However, the output is pretty hard to read. Here\'s a suggestion for a format that I think would be clearer:\n\n 2015-04-09 13:42:49 Connecting to localhost:59804\n 2015-04-09 13:42:49 Requesting currently running distbuilds.\n 2015-04-09 13:42:49 2 distbuild requests(s) currently in progress\n Build request ID: InitiatorConnection-2\n Initiator: 127.0.0.1:55898\n Repo: baserock:baserock/definitions\n Ref: 15708549ae011f204089150864766b734aa62cac\n Component: systems/build-system-x86_64-chroot.morph\n\n Build request ID: InitiatorConnection-3\n Initiator: 127.0.0.1:56252\n Repo: baserock:baserock/definitions\n Ref: 15708549ae011f204089150864766b734aa62cac\n Component: systems/devel-system-x86_64-chroot.morph',136,14,136,'da87b5cf_21a52e04',NULL),(39,'2015-04-09 11:08:48','Uploaded patch set 12.',136,12,136,'da87b5cf_4125d2a9',NULL),(6,'2015-04-09 11:25:07','Patch Set 12: Code-Review-1\n\nAt a glance, this looks fine. Thanks for persevering Lauren, thanks for the useful commands Richard -- especially that it\'s much better to not reuse the term \'jobs\' to mean \'build-requests\' when it already has a meaning in the distbuild code.\n\nI agree the output could be neater. I think the right approach to this is to not construct the message in the controller: the list-requests message should send back all the information as JSON, and the client/initiator can then format it however it wants (console, GUI, text-to-speech engine...). However, we\'re very much running out of time to work on this patch, so I\'d prefer if we could merge the current version, and do a new protocol-version later on to implement what I described there.\n\nIn the meantime, we can do small tweaks to the existing code to make it useful for console users. I tried this out and discovered an issue. I had no jobs running at the time, I ran \'distbuild-list-jobs\' and the controller crashed:\n\n Traceback (most recent call last):\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 190, in _run\n self.process_args(args)\n File \"/src/morph/morphlib/app.py\", line 280, in process_args\n cliapp.Application.process_args(self, args)\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 539, in process_args\n method(args[1:])\n File \"/src/morph/morphlib/plugins/distbuild_plugin.py\", line 331, in controller_daemon\n loop.run()\n File \"/src/morph/distbuild/mainloop.py\", line 122, in run\n self._run_once()\n File \"/src/morph/distbuild/mainloop.py\", line 107, in _run_once\n for new_event in machine.handle_event(event_source, event):\n File \"/src/morph/distbuild/sm.py\", line 115, in handle_event\n ret = callback(event_source, event)\n File \"/src/morph/distbuild/initiator_connection.py\", line 104, in _handle_msg\n self._handle_list_requests(event)\n File \"/src/morph/distbuild/initiator_connection.py\", line 137, in _handle_list_requests\n % len(jobs))\n\nThe initiator showed this:\n\n 2015-04-09 11:22:03 Connecting to localhost:54597\n 2015-04-09 11:22:03 Requesting currently running distbuilds.\n\nI\'d expect it to say \'No jobs running\'. Still, since the controller crashed, maybe it does say that only it didn\'t because the controller crashed.\n\n\nNote there are still two open changes (#134 and #135) that are marked as related to this one in Gerrit, which I think need to be \'abandoned\' as everything is now done in this one change.',136,12,136,'da87b5cf_415cf225',NULL),(6,'2015-04-09 12:15:32','Patch Set 13: Code-Review-1\n\nNow I get a new crash, when there is a job running:\n\n Traceback (most recent call last):\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 190, in _run\n self.process_args(args)\n File \"/src/morph/morphlib/app.py\", line 280, in process_args\n cliapp.Application.process_args(self, args)\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 539, in process_args\n method(args[1:])\n File \"/src/morph/morphlib/plugins/distbuild_plugin.py\", line 331, in controller_daemon\n loop.run()\n File \"/src/morph/distbuild/mainloop.py\", line 122, in run\n self._run_once()\n File \"/src/morph/distbuild/mainloop.py\", line 107, in _run_once\n for new_event in machine.handle_event(event_source, event):\n File \"/src/morph/distbuild/sm.py\", line 115, in handle_event\n ret = callback(event_source, event)\n File \"/src/morph/distbuild/initiator_connection.py\", line 104, in _handle_msg\n self._handle_list_requests(event)\n File \"/src/morph/distbuild/initiator_connection.py\", line 141, in _handle_list_requests\n % (build.get_init_conn().initiator_name,\n AttributeError: \'BuildController\' object has no attribute \'get_init_conn\'\n\n\nBy the way, I think \'get_init_conn()\' is a bad name for an accessor function that gets an InitiatorConnection object -- call it get_initiator_connection() instead, because even though that\'s quite a long name, you could at least guess the function name based on what it does, or vice versa. Where \'get_init_conn()\' is not really at all guessable.',136,13,136,'da87b5cf_619b36ca',NULL),(39,'2015-04-09 12:51:23','Uploaded patch set 14.',136,14,136,'da87b5cf_81a0baf5',NULL),(29,'2015-04-09 15:36:12','Patch Set 14:\n\n> I tested this with 0, 1 and 2 jobs, and it seems to work. Output\n > with 2 jobs (using a local test distbuild instance):\n > \n > 2015-04-09 13:42:49 Connecting to localhost:59804\n > 2015-04-09 13:42:49 Requesting currently running distbuilds.\n > 2015-04-09 13:42:49 2 distbuild requests(s) currently in progress\n > Initiator connection (address:port): 127.0.0.1:55898\n > Build request message: {\'partial\': False, \'ref\': \'15708549ae011f20408915086\n > 4766b734aa62cac\', \'component_names\': [], \'repo\': \'baserock:baserock/definit\n > ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\',\n > \'morphol\n > ogy\': \'systems/build-system-x86_64-chroot.morph\', \'protocol_version\':\n > 2, \'t\n > ype\': \'build-request\', \'id\': \'InitiatorConnection-2\'}\n > Build request ID: InitiatorConnection-2\n > Initiator connection (address:port): 127.0.0.1:56252\n > Build request message: {\'partial\': False, \'ref\': \'15708549ae011f20408915086\n > 4766b734aa62cac\', \'component_names\': [], \'repo\': \'baserock:baserock/definit\n > ions\', \'original_ref\': \'15708549ae011f204089150864766b734aa62cac\',\n > \'morphol\n > ogy\': \'systems/devel-system-x86_64-chroot.morph\', \'protocol_version\':\n > 2, \'t\n > ype\': \'build-request\', \'id\': \'InitiatorConnection-3\'}\n > Build request ID: InitiatorConnection-3\n > \n > This does seem to work now and I\'m happy with the code, so I think\n > it\'d be ok to merge it. However, the output is pretty hard to read.\n > Here\'s a suggestion for a format that I think would be clearer:\n > \n > 2015-04-09 13:42:49 Connecting to localhost:59804\n > 2015-04-09 13:42:49 Requesting currently running distbuilds.\n > 2015-04-09 13:42:49 2 distbuild requests(s) currently in progress\n > Build request ID: InitiatorConnection-2\n > Initiator: 127.0.0.1:55898\n > Repo: baserock:baserock/definitions\n > Ref: 15708549ae011f204089150864766b734aa62cac\n > Component: systems/build-system-x86_64-chroot.morph\n > \n > Build request ID: InitiatorConnection-3\n > Initiator: 127.0.0.1:56252\n > Repo: baserock:baserock/definitions\n > Ref: 15708549ae011f204089150864766b734aa62cac\n > Component: systems/devel-system-x86_64-chroot.morph\n\n +-----------------+-------------------------------+---------+\n | initiator | repo | ref |\n +-----------------+-------------------------------+---------+\n | 127.0.0.1:56252 | baserock:baserock/definitions | master |\n | 127.0.0.1:55898 | baserock:baserock/definitions | devel |\n +-----------------+-------------------------------+---------+\n\nneeds to include the component as well...\nthe openstack clients allow you to specify which columns should be included\nby passing cli args. maybe there\'s even an existing library we could use',136,14,136,'da87b5cf_a1b85e2b',NULL),(6,'2015-04-09 11:25:52','Patch Set 12:\n\nWhen I say \'the initiator\' above, I mean the output of \'morph distbuild-list-jobs\'',136,12,136,'da87b5cf_e140a637',NULL),(29,'2015-04-01 11:18:59','Patch Set 8: Code-Review+1\n\nAwesome thanks',136,8,136,'fa5d592f_4a875362',NULL),(6,'2015-04-01 11:26:35','Patch Set 8:\n\n(4 comments)\n\nI have a few comments I think should be addressed before this is merged',136,8,136,'fa5d592f_aa8fef74',NULL),(39,'2015-04-01 09:17:50','Uploaded patch set 8.',136,8,136,'fa5d592f_ca0fc32d',NULL),(39,'2015-04-01 15:46:36','Uploaded patch set 9.',136,9,136,'fa5d592f_eaf847c6',NULL),(16,'2015-04-16 10:35:10','Patch Set 17: Code-Review+1\n\nLooks OK to me, and I can confirm it works. It would be cool to have python-prettytable for things like this, but we the current output is fine for now.',136,17,136,'fa6b99d7_fa47e91b',NULL),(7,'2015-03-31 10:54:28','Change has been successfully merged into the git repository.',137,2,137,'1a2f8d8d_cb1c7516',NULL),(7,'2015-03-31 10:54:26','Patch Set 2: Code-Review+2\n\nThanks for resending. It already had a +2, and nothing has changed. So +2ing and merging',137,2,137,'1a2f8d8d_eb1f3108',NULL),(16,'2015-03-30 13:37:43','Patch Set 1: Code-Review+1\n\nLooks good to me, but I don\'t know anything about Gerrit config.',137,1,137,'3a3291f1_0c0e1735',NULL),(7,'2015-03-30 13:37:25','Patch Set 1: Code-Review+1\n\nIn one year I will complain and tell you that it wasn\'t enough :)',137,1,137,'3a3291f1_4c041f15',NULL),(6,'2015-03-30 13:34:55','Uploaded patch set 1.',137,1,137,'3a3291f1_6cffdb02',NULL),(NULL,'2015-03-30 14:44:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of I9140def6, however the current patch set is 5.\n\nPlease rebase the change and upload a replacement commit.',137,1,137,'3a3291f1_8c8c4781',NULL),(8,'2015-03-30 14:44:45','Patch Set 1: Code-Review+2',137,1,137,'3a3291f1_ac8f0375',NULL),(6,'2015-03-30 15:02:59','Uploaded patch set 2.',137,2,137,'3a3291f1_acbdc304',NULL),(11,'2015-03-30 13:54:40','Uploaded patch set 1.',138,1,138,'3a3291f1_0c25f7aa',NULL),(6,'2015-03-30 14:39:02','Patch Set 1: Code-Review-2\n\nThis should not be submitted as a new change, it should be submitted as an update to the existing change https://gerrit.baserock.org/#/c/132/1',138,1,138,'3a3291f1_0c81774a',NULL),(11,'2015-03-30 15:51:58','Abandoned',138,1,138,'3a3291f1_6c059bc1',NULL),(15,'2015-03-30 14:15:35','Uploaded patch set 1.',139,1,139,'3a3291f1_2c579304',NULL),(15,'2015-03-30 14:38:49','Abandoned',139,1,139,'3a3291f1_2c7c3372',NULL),(8,'2015-03-30 14:27:58','Patch Set 1:\n\nI know that you are just moving that file from one place to another, but it would be nice if we fix errors in them at the same time.',139,1,139,'3a3291f1_4ca09ff4',NULL),(8,'2015-03-30 14:25:09','Patch Set 1: Code-Review-1\n\n(3 comments)',139,1,139,'3a3291f1_ac6143d5',NULL),(15,'2015-03-30 14:15:35','Uploaded patch set 1.',140,1,140,'3a3291f1_0c5cd724',NULL),(15,'2015-03-30 14:39:23','Abandoned',140,1,140,'3a3291f1_cc924f9f',NULL),(15,'2015-03-30 14:15:35','Uploaded patch set 1.',141,1,141,'3a3291f1_ec406b37',NULL),(15,'2015-03-30 14:39:03','Abandoned',141,1,141,'3a3291f1_ec950b89',NULL),(15,'2015-03-30 14:37:59','Restored',142,1,142,'3a3291f1_4c877f62',NULL),(15,'2015-03-30 14:48:26','Abandoned',142,1,142,'3a3291f1_4cee5f24',NULL),(15,'2015-03-30 14:37:10','Abandoned',142,1,142,'3a3291f1_6c823b54',NULL),(15,'2015-03-30 14:18:25','Uploaded patch set 1.',142,1,142,'3a3291f1_ac4a6353',NULL),(15,'2015-03-30 14:48:33','Abandoned',143,1,143,'3a3291f1_2cf3130c',NULL),(15,'2015-03-30 14:18:25','Uploaded patch set 1.',143,1,143,'3a3291f1_8c47a74b',NULL),(15,'2015-03-30 14:48:40','Abandoned',144,1,144,'3a3291f1_0cf857e4',NULL),(15,'2015-03-30 14:18:25','Uploaded patch set 1.',144,1,144,'3a3291f1_6c747b9c',NULL),(31,'2015-03-30 14:28:20','Abandoned',145,1,145,'3a3291f1_2ca55304',NULL),(31,'2015-03-30 14:25:41','Uploaded patch set 1.',145,1,145,'3a3291f1_8c5e8711',NULL),(7,'2015-03-31 11:21:05','Change has been successfully merged into the git repository.',146,3,146,'1a2f8d8d_0b9efd56',NULL),(7,'2015-03-31 11:21:03','Patch Set 3: Code-Review+2',146,3,146,'1a2f8d8d_2b99b96e',NULL),(NULL,'2015-03-31 10:56:54','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I5d11a3d6, however the current patch set is 2.\n* Depends on commit 0db1f28c7f492f159376a04dea75670a36af4c29 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',146,2,146,'1a2f8d8d_2bdd3943',NULL),(7,'2015-03-31 11:20:57','Patch Set 3: Patch Set 2 was rebased',146,2,146,'1a2f8d8d_4b940537',NULL),(8,'2015-03-31 09:13:20','Patch Set 2: Code-Review+2',146,2,146,'1a2f8d8d_6b5ea1eb',NULL),(6,'2015-03-30 14:35:28','Uploaded patch set 2.',146,2,146,'3a3291f1_8cb56733',NULL),(15,'2015-03-30 17:32:46','Patch Set 2: Code-Review+1',146,2,146,'3a3291f1_8ced67f2',NULL),(6,'2015-03-30 14:34:44','Uploaded patch set 1.',146,1,146,'3a3291f1_acb8232b',NULL),(8,'2015-03-30 14:55:52','Patch Set 2: Code-Review+1',146,2,146,'3a3291f1_ccd92f85',NULL),(15,'2015-03-31 15:06:36','Uploaded patch set 2.',147,2,147,'1a2f8d8d_8b730d15',NULL),(15,'2015-03-30 14:56:40','Uploaded patch set 1.',147,1,147,'3a3291f1_8ce32733',NULL),(27,'2015-04-21 13:04:14','Patch Set 2: Code-Review+1',147,2,147,'7a7fa997_96c32c38',NULL),(15,'2015-04-27 13:21:29','Patch Set 2: Code-Review+2',147,2,147,'dad5f5cf_3187d011',NULL),(6,'2015-04-27 11:42:34','Patch Set 2: Code-Review+1\n\nLooks ok, but I\'ve not tested and don\'t know a huge amount about X in Baserock.',147,2,147,'dad5f5cf_71d8f853',NULL),(15,'2015-04-27 13:21:35','Change has been successfully rebased as eb2c33af1b56b322524d058dd6f560cb21d98a0d',147,2,147,'dad5f5cf_91755c34',NULL),(15,'2015-04-27 13:21:35','Patch Set 3: Patch Set 2 was rebased',147,2,147,'dad5f5cf_d17be427',NULL),(15,'2015-03-31 15:07:20','Abandoned\n\nsquashed this in one commit to avoid the merge commit',148,1,148,'1a2f8d8d_6b60e135',NULL),(15,'2015-03-30 14:56:40','Uploaded patch set 1.',148,1,148,'3a3291f1_6cd0fb53',NULL),(15,'2015-03-31 15:07:31','Abandoned\n\nsquashed this in one commit to avoid the merge commit',149,1,149,'1a2f8d8d_4b652544',NULL),(15,'2015-03-30 14:56:40','Uploaded patch set 1.',149,1,149,'3a3291f1_4cd53f42',NULL),(11,'2015-03-30 14:58:08','Uploaded patch set 1.',150,1,150,'3a3291f1_2ccaf3a1',NULL),(11,'2015-03-30 15:51:18','Abandoned',150,1,150,'3a3291f1_8c68c788',NULL),(6,'2015-03-30 15:01:50','Patch Set 1: Code-Review-2\n\nThis still duplicates https://gerrit.baserock.org/#/c/132/1 -- you need to use the same Change-Id as the original change in order to submit a new version of it.',150,1,150,'3a3291f1_ecc3cb88',NULL),(29,'2015-03-30 15:18:24','Uploaded patch set 1.',151,1,151,'3a3291f1_ec4aab26',NULL),(37,'2015-04-01 09:30:53','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nThis looks like a sensible change to me. I\'ve only got nit-picks.',151,1,151,'fa5d592f_6a2697bc',NULL),(8,'2015-04-01 10:55:17','Change has been successfully rebased as d28595c19a5b9ee5bcacc6de4319de625024cb87',151,1,151,'fa5d592f_6a9b37ca',NULL),(8,'2015-04-01 10:55:17','Patch Set 2: Patch Set 1 was rebased',151,1,151,'fa5d592f_8a5e6b11',NULL),(8,'2015-04-01 10:55:10','Patch Set 1: Code-Review+2',151,1,151,'fa5d592f_aa612fd5',NULL),(29,'2015-04-01 10:48:34','Patch Set 1:\n\n(2 comments)',151,1,151,'fa5d592f_ca6463e7',NULL),(35,'2015-03-31 10:21:02','Patch Set 1: Code-Review+1\n\n+1 if you built this and it works with the current v5.4.0 API',152,1,152,'1a2f8d8d_ebf851c6',NULL),(15,'2015-03-30 15:24:15','Uploaded patch set 1.',152,1,152,'3a3291f1_cc47ef1c',NULL),(6,'2015-04-01 11:37:11','Change has been successfully rebased as 8519aad9c4b56c9ea90df7e2d9caf1eec1ec97a9',152,1,152,'fa5d592f_2acadfa1',NULL),(6,'2015-04-01 11:37:11','Patch Set 2: Patch Set 1 was rebased',152,1,152,'fa5d592f_4ad51342',NULL),(6,'2015-04-01 11:37:08','Patch Set 1: Code-Review+2',152,1,152,'fa5d592f_6ad0d753',NULL),(11,'2015-03-31 11:06:58','Abandoned\n\nreplaced by bmottram/firehose',153,1,153,'1a2f8d8d_4ba645c3',NULL),(11,'2015-03-30 15:56:06','Uploaded patch set 1.',153,1,153,'3a3291f1_2c0f93e3',NULL),(11,'2015-03-31 11:06:33','Abandoned\n\nreplaced by bmottram/firehose',154,1,154,'1a2f8d8d_6ba101a9',NULL),(11,'2015-03-30 15:56:06','Uploaded patch set 1.',154,1,154,'3a3291f1_0c14d7f3',NULL),(7,'2015-03-31 09:36:59','Patch Set 1: Code-Review+1',155,1,155,'1a2f8d8d_0b5ddde9',NULL),(28,'2015-03-31 09:29:31','Uploaded patch set 1.',155,1,155,'1a2f8d8d_2b5899f9',NULL),(8,'2015-03-31 09:37:18','Change has been successfully merged into the git repository.',155,1,155,'1a2f8d8d_ab6b6984',NULL),(8,'2015-03-31 09:37:15','Patch Set 1: Code-Review+2',155,1,155,'1a2f8d8d_cb6eb596',NULL),(8,'2015-03-31 09:37:04','Patch Set 1: Code-Review+1',155,1,155,'1a2f8d8d_eb717178',NULL),(6,'2015-03-31 10:57:30','Uploaded patch set 1.',156,1,156,'1a2f8d8d_0be27d03',NULL),(8,'2015-03-31 15:27:20','Patch Set 1: Code-Review+2\n\nSounds sensible',156,1,156,'1a2f8d8d_6beea18d',NULL),(15,'2015-03-31 15:33:00','Change has been successfully merged into the git repository.',156,1,156,'1a2f8d8d_cbfeb538',NULL),(7,'2015-03-31 15:23:30','Patch Set 1: Code-Review+1\n\nLooks sensible.',156,1,156,'1a2f8d8d_ebda91e8',NULL),(15,'2015-03-31 15:33:00','Change has been successfully merged into the git repository.',157,1,157,'1a2f8d8d_0beddd8b',NULL),(15,'2015-03-31 15:20:26','Patch Set 1: Code-Review+2',157,1,157,'1a2f8d8d_4bcc0536',NULL),(7,'2015-03-31 15:18:42','Patch Set 1: Code-Review+1',157,1,157,'1a2f8d8d_8b4aedaa',NULL),(6,'2015-03-31 10:57:30','Uploaded patch set 1.',157,1,157,'1a2f8d8d_ebe61116',NULL),(15,'2015-03-31 15:22:48','Patch Set 2: Code-Review+1',158,2,158,'1a2f8d8d_0bd6fdc5',NULL),(7,'2015-03-31 15:22:00','Patch Set 2: Code-Review+1\n\nThanks for including the console output changes :)',158,2,158,'1a2f8d8d_2bd1b9cd',NULL),(6,'2015-03-31 10:58:42','Uploaded patch set 2.',158,2,158,'1a2f8d8d_abf009ca',NULL),(15,'2015-03-31 15:23:41','Patch Set 2: Code-Review+2',158,2,158,'1a2f8d8d_cbd7d5be',NULL),(6,'2015-03-31 10:57:30','Uploaded patch set 1.',158,1,158,'1a2f8d8d_cbe35504',NULL),(15,'2015-03-31 15:33:00','Change has been successfully merged into the git repository.',158,2,158,'1a2f8d8d_eb01713a',NULL),(11,'2015-03-31 11:05:50','Uploaded patch set 1.',159,1,159,'1a2f8d8d_4bbf65d1',NULL),(11,'2015-03-31 11:31:39','Patch Set 2: Commit message was updated',159,2,159,'1a2f8d8d_abac898d',NULL),(8,'2015-04-15 16:55:15','Patch Set 1:\n\n(1 comment)',159,1,159,'1a9dcd25_db88f3c8',NULL),(37,'2015-06-04 10:21:05','Patch Set 4: Code-Review+2',159,4,159,'1aa4ed85_8333def5',NULL),(37,'2015-06-04 10:21:08','Change has been successfully merged into the git repository.',159,4,159,'1aa4ed85_a3305ae9',NULL),(39,'2015-05-18 15:37:05','Patch Set 4: Code-Review+1',159,4,159,'9adffdf1_4f2bcdeb',NULL),(8,'2015-04-16 08:48:21','Patch Set 4: Code-Review+1',159,4,159,'fa6b99d7_3a5c8125',NULL),(11,'2015-04-16 08:34:01','Patch Set 4: Commit message was updated',159,4,159,'fa6b99d7_5a4db571',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 3.',159,3,159,'fa6b99d7_ba3091e9',NULL),(11,'2015-03-31 11:05:50','Uploaded patch set 1.',160,1,160,'1a2f8d8d_2bb419f1',NULL),(NULL,'2015-06-10 10:22:59','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of Idfadb42c, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',160,2,160,'7a42497e_1e526d13',NULL),(8,'2015-06-10 10:22:57','Patch Set 2: Code-Review+2',160,2,160,'7a42497e_3e4da973',NULL),(8,'2015-06-10 10:23:16','Patch Set 3: Code-Review+2',160,3,160,'7a42497e_5e5cf525',NULL),(8,'2015-06-10 10:23:10','Patch Set 3: Patch Set 2 was rebased',160,2,160,'7a42497e_7e573103',NULL),(8,'2015-06-10 10:23:18','Change has been successfully merged into the git repository.',160,3,160,'7a42497e_be409936',NULL),(36,'2015-06-09 10:09:39','Patch Set 2: Code-Review+1',160,2,160,'9a3d3df0_7fa56f03',NULL),(39,'2015-05-18 15:37:31','Patch Set 2: Code-Review+1',160,2,160,'9adffdf1_6f301157',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',160,2,160,'fa6b99d7_1a097d2c',NULL),(11,'2015-03-31 11:05:50','Uploaded patch set 1.',161,1,161,'1a2f8d8d_0bb95de9',NULL),(8,'2015-06-11 15:57:38','Change has been successfully merged into the git repository.',161,6,161,'5a3f45e8_1d0a73d2',NULL),(8,'2015-06-11 15:57:36','Patch Set 6: Code-Review+2',161,6,161,'5a3f45e8_3d05afc2',NULL),(36,'2015-06-11 15:53:17','Patch Set 3: Commit message was updated',161,3,161,'5a3f45e8_5d46bb24',NULL),(8,'2015-06-11 15:56:20','Patch Set 5: Commit message was updated',161,5,161,'5a3f45e8_9d47a31d',NULL),(36,'2015-06-11 15:53:32','Patch Set 4: Commit message was updated',161,4,161,'5a3f45e8_bd4a5f25',NULL),(NULL,'2015-06-11 15:56:32','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ic02c9e6c, however the current patch set is 3.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',161,5,161,'5a3f45e8_dd512bda',NULL),(8,'2015-06-11 15:57:31','Patch Set 6: Patch Set 5 was rebased',161,5,161,'5a3f45e8_dd680b8a',NULL),(8,'2015-06-11 15:56:31','Patch Set 5: Code-Review+2',161,5,161,'5a3f45e8_fd54e7cb',NULL),(36,'2015-06-09 14:10:33','Patch Set 2: -Code-Review\n\nCould the commit message be clarified? I don\'t understand what is meant by \'compile error\'. +1 otherwise',161,2,161,'9a3d3df0_1f0a63d2',NULL),(36,'2015-06-09 14:08:54','Patch Set 2: Code-Review+1',161,2,161,'9a3d3df0_3f05a7c2',NULL),(11,'2015-06-09 14:15:23','Patch Set 2:\n\nI think the compile error was missing parameter or too many parameters.',161,2,161,'9a3d3df0_5f14ebf4',NULL),(36,'2015-06-09 14:37:19','Patch Set 2:\n\nYes, when this function is called it is given only one parameter. I think it would be better if the commit message said that the name parameter is not needed in this function.',161,2,161,'9a3d3df0_bff897c5',NULL),(39,'2015-05-18 15:37:50','Patch Set 2: Code-Review+1',161,2,161,'9adffdf1_0f35c545',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',161,2,161,'fa6b99d7_da122558',NULL),(11,'2015-03-31 11:05:50','Uploaded patch set 1.',162,1,162,'1a2f8d8d_ebcdf187',NULL),(8,'2015-06-11 15:57:06','Patch Set 2: Code-Review+2',162,2,162,'5a3f45e8_3d5e4fea',NULL),(NULL,'2015-06-11 15:57:38','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I19562874, however the current patch set is 6.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',162,2,162,'5a3f45e8_7d0f37e2',NULL),(NULL,'2015-06-11 15:57:09','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I19562874, however the current patch set is 5.\n* Depends on patch set 2 of Ic02c9e6c, however the current patch set is 3.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',162,2,162,'5a3f45e8_7d58d7fa',NULL),(8,'2015-06-11 15:57:52','Patch Set 3: Code-Review+2',162,3,162,'5a3f45e8_9df5e3cd',NULL),(8,'2015-06-11 15:57:50','Patch Set 3: Patch Set 2 was rebased',162,2,162,'5a3f45e8_bdf89fc5',NULL),(8,'2015-06-11 15:57:54','Change has been successfully merged into the git repository.',162,3,162,'5a3f45e8_fd0227b3',NULL),(36,'2015-06-10 10:09:40','Patch Set 2: Code-Review+1',162,2,162,'7a42497e_fe3341f4',NULL),(39,'2015-05-18 15:38:09','Patch Set 2: Code-Review+1',162,2,162,'9adffdf1_2f3a0937',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',162,2,162,'fa6b99d7_fa0fe92c',NULL),(11,'2015-03-31 11:05:50','Uploaded patch set 1.',163,1,163,'1a2f8d8d_cbca356e',NULL),(8,'2015-06-11 15:58:38','Patch Set 3: Code-Review+2',163,3,163,'5a3f45e8_1d31d3a2',NULL),(8,'2015-06-11 15:58:36','Patch Set 3: Patch Set 2 was rebased',163,2,163,'5a3f45e8_3d2c8f4a',NULL),(NULL,'2015-06-11 15:57:38','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I19562874, however the current patch set is 6.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',163,2,163,'5a3f45e8_5d14fbf4',NULL),(8,'2015-06-11 15:57:19','Patch Set 2: Code-Review+2',163,2,163,'5a3f45e8_5d5d1be9',NULL),(8,'2015-06-11 15:58:42','Change has been successfully merged into the git repository.',163,3,163,'5a3f45e8_7d26176a',NULL),(NULL,'2015-06-11 15:57:54','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Iffbbe7bb, however the current patch set is 3.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',163,2,163,'5a3f45e8_ddff6ba9',NULL),(NULL,'2015-06-11 15:57:21','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I19562874, however the current patch set is 5.\n* Depends on patch set 2 of Ic02c9e6c, however the current patch set is 3.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',163,2,163,'5a3f45e8_fd6b4783',NULL),(36,'2015-06-10 16:03:10','Patch Set 2: Code-Review+1',163,2,163,'7a42497e_fef061cb',NULL),(39,'2015-05-18 15:38:23','Patch Set 2: Code-Review+1',163,2,163,'9adffdf1_cf3edd29',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',163,2,163,'fa6b99d7_9a1cad6c',NULL),(11,'2015-03-31 11:22:25','Uploaded patch set 1.',164,1,164,'1a2f8d8d_eba29199',NULL),(8,'2015-06-11 16:01:09','Patch Set 2: Code-Review+2',164,2,164,'5a3f45e8_5d2b5b30',NULL),(36,'2015-06-11 15:42:39','Patch Set 2: Code-Review+1',164,2,164,'5a3f45e8_7d41f70a',NULL),(8,'2015-06-11 16:01:37','Patch Set 3: Patch Set 2 was rebased',164,2,164,'5a3f45e8_9d1cc315',NULL),(NULL,'2015-06-11 16:01:35','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of If312bb54, however the current patch set is 3.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',164,2,164,'5a3f45e8_bd1fff08',NULL),(8,'2015-06-11 16:01:42','Change has been successfully merged into the git repository.',164,3,164,'5a3f45e8_dd164bf1',NULL),(8,'2015-06-11 16:01:40','Patch Set 3: Code-Review+2',164,3,164,'5a3f45e8_fd198723',NULL),(27,'2015-04-21 13:27:51','Patch Set 2: Code-Review+1',164,2,164,'7a7fa997_36ec98c7',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',164,2,164,'fa6b99d7_ba19717b',NULL),(11,'2015-03-31 11:26:58','Uploaded patch set 1.',165,1,165,'1a2f8d8d_cb9fd54f',NULL),(6,'2015-06-12 11:19:40','Patch Set 2: Code-Review+2\n\nNever mind, I guess this only happens if the user explicitly configures git-username and git-email so it\'s not so bad.',165,2,165,'3a4c51b2_1cd8b552',NULL),(6,'2015-06-12 11:19:48','Patch Set 3: Patch Set 2 was rebased',165,2,165,'3a4c51b2_5ce23d04',NULL),(NULL,'2015-06-12 11:19:42','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I9e6830c4, however the current patch set is 3.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',165,2,165,'3a4c51b2_7cdd7942',NULL),(6,'2015-06-12 11:19:52','Change has been successfully merged into the git repository.',165,3,165,'3a4c51b2_9ce32505',NULL),(6,'2015-06-12 11:19:51','Patch Set 3: Code-Review+2',165,3,165,'3a4c51b2_bce6e114',NULL),(6,'2015-06-12 11:17:48','Patch Set 2: Code-Review-1\n\nI think that overriding the global Git config on a system is a bit intrusive, is there a better way of doing this?',165,2,165,'3a4c51b2_dc164df1',NULL),(39,'2015-05-18 15:38:50','Patch Set 2: Code-Review+1',165,2,165,'9adffdf1_ef3ba136',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',165,2,165,'fa6b99d7_5a2615bc',NULL),(15,'2015-03-31 12:17:39','Uploaded patch set 1.',166,1,166,'1a2f8d8d_2be779e6',NULL),(32,'2015-05-26 15:21:36','Patch Set 4:\n\n(1 comment)',166,4,166,'1acb0d3e_eb6e3196',NULL),(15,'2015-04-06 13:27:25','Uploaded patch set 3.',166,3,166,'3a4b7175_4404ee14',NULL),(11,'2015-04-22 10:23:57','Patch Set 4: Commit message was updated',166,4,166,'5a7ca5a3_15a5d403',NULL),(11,'2015-04-22 10:24:40','Patch Set 4: Code-Review+1',166,4,166,'5a7ca5a3_35aa50d5',NULL),(11,'2015-04-22 10:23:18','Patch Set 3: Code-Review+1',166,3,166,'5a7ca5a3_75a0c8f4',NULL),(35,'2015-04-22 11:54:59','Patch Set 4: Code-Review+1\n\nlovely little patch',166,4,166,'5a7ca5a3_955484cb',NULL),(37,'2015-05-13 15:47:57','Patch Set 4:\n\n(1 comment)\n\nAnd some more checks to prevent outputting garbage when it\'s not being output to your terminal directly.',166,4,166,'bada0100_178633ba',NULL),(37,'2015-05-13 15:43:51','Patch Set 4: Code-Review-1\n\n(1 comment)\n\nYou can have a +1 on your next version if you simplify the xterm check to `\'xterm\' in term`, rather than using string.find, but you\'ll need to rebase anyway so I\'m -1ing this version.',166,4,166,'bada0100_57a4bb56',NULL),(16,'2015-05-13 09:15:45','Patch Set 4: Code-Review+1',166,4,166,'bada0100_57b59bcb',NULL),(15,'2015-04-01 13:41:25','Uploaded patch set 2.',166,2,166,'fa5d592f_6a5e97eb',NULL),(15,'2015-03-31 12:17:39','Uploaded patch set 1.',167,1,167,'1a2f8d8d_0becbdc6',NULL),(15,'2015-04-06 13:27:25','Uploaded patch set 3.',167,3,167,'3a4b7175_2409f22c',NULL),(8,'2015-04-23 08:52:34','Patch Set 5: Code-Review+1',167,5,167,'3a79b1b5_f40ff82c',NULL),(11,'2015-04-22 13:29:52','Patch Set 5: Commit message was updated',167,5,167,'5a7ca5a3_55d34c38',NULL),(11,'2015-04-22 13:28:19','Patch Set 4: Commit message was updated',167,4,167,'5a7ca5a3_9519e424',NULL),(37,'2015-05-13 15:49:10','Patch Set 5: Code-Review-1\n\nAdam is right, this code needs to either detect whether its output is a terminal device, or write to /dev/tty directly, which may not work for ssh sessions.',167,5,167,'bada0100_b792c7f4',NULL),(37,'2015-05-13 15:50:21','Patch Set 5:\n\nAlso, in my opinion this should be opt-in, since you may prefer your terminal heading to show the current directory instead, as it is task oriented.',167,5,167,'bada0100_d78f4bcb',NULL),(16,'2015-05-13 09:18:18','Patch Set 5: Code-Review-1\n\nThis is cool, but it appears to break the test suite to me (`./check -full`). I guess because of the sys.stdout.write() in the function which sets the terminal title.',167,5,167,'bada0100_f7c92f5b',NULL),(15,'2015-04-01 13:41:25','Uploaded patch set 2.',167,2,167,'fa5d592f_4a63d3b1',NULL),(7,'2015-03-31 15:31:01','Patch Set 1:\n\nIndeed sounds cool, but also weird :)',168,1,168,'1a2f8d8d_2be8997b',NULL),(6,'2015-03-31 13:37:37','Patch Set 1:\n\nexits, not exists.',168,1,168,'1a2f8d8d_2bfe596c',NULL),(6,'2015-03-31 13:37:24','Patch Set 1:\n\nLooks cool, but is there any way to reset the title to what it was when Morph exists?',168,1,168,'1a2f8d8d_4b09a594',NULL),(15,'2015-03-31 12:17:39','Uploaded patch set 1.',168,1,168,'1a2f8d8d_ebd051f9',NULL),(15,'2015-04-06 13:27:25','Uploaded patch set 3.',168,3,168,'3a4b7175_040ef634',NULL),(8,'2015-04-23 08:52:58','Patch Set 4: Code-Review+1',168,4,168,'3a79b1b5_941c846c',NULL),(11,'2015-04-22 13:27:54','Patch Set 4: Commit message was updated',168,4,168,'5a7ca5a3_d51f5c08',NULL),(16,'2015-05-13 09:26:14','Patch Set 4: Code-Review-1\n\nThis also seems cool, but breaks the tests in the same way as the similar patch for builds.',168,4,168,'bada0100_17c71347',NULL),(37,'2015-05-13 15:51:28','Patch Set 4: Code-Review-1\n\nSee previous reviews about having to be sure that it is outputting to a terminal, and this behaviour being opt-in.\n\nOn a more personal note, I am disappointed that Javier isn\'t running the test suite before submitting changes.',168,4,168,'bada0100_77bc5f6d',NULL),(15,'2015-04-01 18:49:38','Patch Set 2:\n\n> Looks cool, but is there any way to reset the title to what it was\n > when Morph exists?\n\nThats a shell configuration problem: Its fixed in: https://gerrit.baserock.org/#/c/185/',168,2,168,'da6255ed_29fe6d6c',NULL),(15,'2015-04-01 13:41:25','Uploaded patch set 2.',168,2,168,'fa5d592f_2a589ff9',NULL),(11,'2015-03-31 13:50:28','Uploaded patch set 1.',169,1,169,'1a2f8d8d_0b039d74',NULL),(6,'2015-06-12 11:20:19','Patch Set 3: Code-Review+2',169,3,169,'3a4c51b2_1cbf15d2',NULL),(6,'2015-06-12 11:20:16','Patch Set 3: Patch Set 2 was rebased',169,2,169,'3a4c51b2_3cbad1e1',NULL),(6,'2015-06-12 11:18:32','Patch Set 2: Code-Review+2\n\nWould be good for log file to be configurable, but this makes sense for now.\n\nI\'ll cherry-pick this to separate it from the previous change.',169,2,169,'3a4c51b2_3cd3f139',NULL),(6,'2015-06-12 11:20:21','Change has been successfully merged into the git repository.',169,3,169,'3a4c51b2_7cb459f2',NULL),(NULL,'2015-06-12 11:20:14','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ic94f9b51, however the current patch set is 3.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',169,2,169,'3a4c51b2_dcedadf1',NULL),(6,'2015-06-12 11:20:12','Patch Set 2:\n\nCherry pick in gerrit doesn\'t seem to work :)',169,2,169,'3a4c51b2_fcf069cb',NULL),(39,'2015-05-18 15:42:13','Patch Set 2: Code-Review+1\n\nI have no issues so far, my only comment is that a few of the smaller patches to firehose_plugin.py could be condensed for gerrit to make it easier to review.\n\nStill, thank you for these improvements!',169,2,169,'9adffdf1_8f48d5cd',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',169,2,169,'fa6b99d7_7a2bd982',NULL),(6,'2015-03-31 15:01:53','Patch Set 1:\n\n(1 comment)',170,1,170,'1a2f8d8d_0b883de6',NULL),(8,'2015-03-31 16:03:14','Patch Set 2: Code-Review+2\n\nThanks for fixing this and rework it :)',170,2,170,'1a2f8d8d_0ba4bd55',NULL),(8,'2015-03-31 14:38:48','Patch Set 1: -Code-Review',170,1,170,'1a2f8d8d_2b0c1994',NULL),(8,'2015-03-31 14:38:07','Patch Set 1: Code-Review+2',170,1,170,'1a2f8d8d_4b1765a4',NULL),(7,'2015-03-31 15:29:12','Patch Set 1: Code-Review+1\n\nThis change itself is OK to me.',170,1,170,'1a2f8d8d_4bf3e573',NULL),(6,'2015-03-31 16:00:56','Patch Set 1:\n\n(1 comment)',170,1,170,'1a2f8d8d_6b9581e3',NULL),(6,'2015-03-31 16:18:06','Change has been successfully rebased as 4b86588589b909bb6ea4bdfe275b8a34ae7ae74d',170,2,170,'1a2f8d8d_8b8f8dcc',NULL),(8,'2015-03-31 15:05:43','Patch Set 1:\n\n(1 comment)',170,1,170,'1a2f8d8d_ab76c904',NULL),(6,'2015-03-31 16:18:05','Patch Set 3: Patch Set 2 was rebased',170,2,170,'1a2f8d8d_ab9249f4',NULL),(6,'2015-03-31 16:00:17','Uploaded patch set 2.',170,2,170,'1a2f8d8d_abfb6946',NULL),(15,'2015-03-31 14:05:35','Patch Set 1: Code-Review+1',170,1,170,'1a2f8d8d_cbf47589',NULL),(8,'2015-03-31 14:43:28','Patch Set 1:\n\n(1 comment)\n\nJust a comment, Im happy to give you a +1 when you fix it',170,1,170,'1a2f8d8d_eb25f10a',NULL),(6,'2015-03-31 14:00:21','Uploaded patch set 1.',170,1,170,'1a2f8d8d_ebf7318b',NULL),(11,'2015-03-31 14:13:19','Uploaded patch set 1.',171,1,171,'1a2f8d8d_abf12997',NULL),(6,'2015-06-12 11:25:45','Uploaded patch set 3.',171,3,171,'3a4c51b2_9cca056d',NULL),(6,'2015-06-12 11:22:23','Patch Set 2: Code-Review-1\n\n(1 comment)',171,2,171,'3a4c51b2_bccd4189',NULL),(6,'2015-06-12 11:26:57','Change has been successfully merged into the git repository.',171,3,171,'3a4c51b2_dcc48d61',NULL),(6,'2015-06-12 11:26:43','Patch Set 3: Code-Review+2\n\nI\'ve submitted a version that fixes the file descriptor leaks. Sorry, I know that mistake was present from a previous patch, but I still couldn\'t bear to +2 something that was clearly wrong ;)',171,3,171,'3a4c51b2_fcc7c962',NULL),(27,'2015-04-21 14:48:08','Patch Set 2: Code-Review+1',171,2,171,'7a7fa997_96f1ec97',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',171,2,171,'fa6b99d7_1a209d9a',NULL),(7,'2015-03-31 14:57:23','Change has been successfully merged into the git repository.',172,1,172,'1a2f8d8d_4b7e45e6',NULL),(7,'2015-03-31 14:57:21','Patch Set 1: Code-Review+2',172,1,172,'1a2f8d8d_6b7901fc',NULL),(7,'2015-03-31 14:57:17','Patch Set 1: Code-Review+1',172,1,172,'1a2f8d8d_8b1c2dc3',NULL),(8,'2015-03-31 14:45:03','Patch Set 1: Code-Review+1',172,1,172,'1a2f8d8d_ab1fe9b6',NULL),(15,'2015-03-31 14:43:35','Uploaded patch set 1.',172,1,172,'1a2f8d8d_cb223501',NULL),(15,'2015-03-31 17:03:39','Patch Set 2: Code-Review+1\n\nThanks for recheck this',173,2,173,'1a2f8d8d_2b6d3905',NULL),(6,'2015-03-31 16:02:49','Patch Set 1:\n\n(1 comment)',173,1,173,'1a2f8d8d_2b9f7905',NULL),(6,'2015-03-31 16:55:57','Patch Set 1:\n\nTurns out --bindir and --sbindir configure flags don\'t do anything, and the Makefile actually hardcodes /${exec_prefix}/usr/bin in some of the paths. So the best we can do is symlink from /usr/bin -> /bin.',173,1,173,'1a2f8d8d_6b63411b',NULL),(15,'2015-03-31 15:19:09','Patch Set 1:\n\n(1 comment)',173,1,173,'1a2f8d8d_6bc7c113',NULL),(8,'2015-03-31 15:25:39','Patch Set 1:\n\n(1 comment)',173,1,173,'1a2f8d8d_8be1cd9c',NULL),(8,'2015-03-31 17:23:41','Patch Set 3:\n\n(1 comment)',173,3,173,'1a2f8d8d_ab80098c',NULL),(6,'2015-03-31 16:53:34','Uploaded patch set 2.',173,2,173,'1a2f8d8d_aba92926',NULL),(7,'2015-03-31 15:16:27','Patch Set 1: Code-Review+1',173,1,173,'1a2f8d8d_cb50f560',NULL),(6,'2015-03-31 15:03:16','Uploaded patch set 1.',173,1,173,'1a2f8d8d_eb6cd138',NULL),(6,'2015-03-31 17:05:34','Uploaded patch set 3.',173,3,173,'1a2f8d8d_eb7611d8',NULL),(8,'2015-04-01 10:07:39','Patch Set 3: Code-Review+2\n\nhehe, I\'ve checked and w is a propps-ng command....',173,3,173,'fa5d592f_4a52b314',NULL),(15,'2015-04-01 11:01:33','Change has been successfully rebased as aae104b29605f4b19a04869da228313b51d92742',173,3,173,'fa5d592f_caab43d5',NULL),(15,'2015-04-01 11:01:32','Patch Set 4: Patch Set 3 was rebased',173,3,173,'fa5d592f_eaae07e7',NULL),(8,'2015-03-31 17:39:59','Patch Set 1: Code-Review+2',174,1,174,'1a2f8d8d_0b495d8b',NULL),(7,'2015-03-31 17:31:57','Patch Set 1: Code-Review+1',174,1,174,'1a2f8d8d_2b441973',NULL),(7,'2015-03-31 17:31:37','Patch Set 1:\n\nMakes sense to me',174,1,174,'1a2f8d8d_4b4f6593',NULL),(6,'2015-03-31 16:21:23','Uploaded patch set 1.',174,1,174,'1a2f8d8d_6bbc616d',NULL),(8,'2015-03-31 17:29:05','Patch Set 1: Code-Review+1',174,1,174,'1a2f8d8d_8b7d4db4',NULL),(8,'2015-03-31 17:40:21','Change has been successfully merged into the git repository.',174,1,174,'1a2f8d8d_eb5df149',NULL),(8,'2015-04-01 10:13:28','Patch Set 1: Code-Review+1',175,1,175,'fa5d592f_2a577f04',NULL),(37,'2015-04-01 10:07:08','Uploaded patch set 1.',175,1,175,'fa5d592f_8a30abe9',NULL),(7,'2015-04-01 10:33:35','Change has been successfully merged into the git repository.',175,1,175,'fa5d592f_8a478b4b',NULL),(7,'2015-04-01 10:33:30','Patch Set 1: Code-Review+2\n\nLooks great. Merging.',175,1,175,'fa5d592f_aa4a4f53',NULL),(8,'2015-04-01 10:14:18','Patch Set 1: Code-Review+1',176,1,176,'fa5d592f_0a5cbb24',NULL),(7,'2015-04-01 10:34:47','Change has been successfully merged into the git repository.',176,1,176,'fa5d592f_4a799392',NULL),(37,'2015-04-01 10:07:08','Uploaded patch set 1.',176,1,176,'fa5d592f_6a4d7772',NULL),(7,'2015-04-01 10:34:42','Patch Set 1: Code-Review+2\n\nMakes sense to me. Merging',176,1,176,'fa5d592f_6a74579c',NULL),(7,'2015-04-02 11:43:22','Change has been successfully rebased as 134d8198ab4f1496f5986d52bad00b8a4ff1d10c',177,2,177,'ba57610f_081167ac',NULL),(7,'2015-04-02 11:43:22','Patch Set 3: Patch Set 2 was rebased',177,2,177,'ba57610f_280c2b94',NULL),(6,'2015-04-02 09:12:15','Patch Set 2:\n\nsorry, I didn\'t mean that cancelling didn\'t work at all, it did work fine in most cases.',177,2,177,'ba57610f_28b0abdc',NULL),(7,'2015-04-02 11:43:20','Patch Set 2: Code-Review+2\n\nI think this is now ready to be merged. Thanks for fixing the commit message!',177,2,177,'ba57610f_48175fa4',NULL),(6,'2015-04-02 09:11:06','Patch Set 2: Commit message was updated',177,2,177,'ba57610f_48bbdfc4',NULL),(39,'2015-04-02 09:44:58','Patch Set 2: Code-Review+1\n\nTested, works fine, thanks for changing the commit message',177,2,177,'ba57610f_e8c9735b',NULL),(7,'2015-04-01 11:00:28','Patch Set 1:\n\nThese changes make sense to me although I\'d appreciate if someone else with more distbuild knowledge can look at this patch.',177,1,177,'fa5d592f_4aa073f4',NULL),(7,'2015-04-01 13:27:22','Patch Set 1: -Code-Review\n\nI change my vote to 0 until Richard Ipsum is happy with the commit message.\n\nNote to Richard: If a patch has already a two +1s you are on time to give it a -1, to flag some issues.',177,1,177,'fa5d592f_8a51cbda',NULL),(7,'2015-04-01 11:09:22','Patch Set 1: Code-Review+1\n\nThanks Lauren, I\'m more confident now giving a +1',177,1,177,'fa5d592f_8ab54b33',NULL),(29,'2015-04-01 13:07:23','Patch Set 1:\n\n\"It doesn\'t seem like cancelling builds ever actually worked right --\"\n\nThis isn\'t a terribly useful observation, and in any case they clearly worked at some point, so overall it\'s a very confusing statement.\nWhen I first read this I misunderstood it completely as a suggestion that the original cancellation code never worked, which is patently false.\n\nI\'m sorry that I\'m not able to give a more useful review right now but you already have 2 +1s in any case. If you\'re willing to hold off on the merge I could check this out later, up to you.',177,1,177,'fa5d592f_aa548fca',NULL),(39,'2015-04-01 11:04:13','Patch Set 1: Code-Review+1\n\nCan confirm this works with my distbuild-list-jobs patch; previously cancelling a build would disconnect but list-jobs would list the build as still in progress. The addition of this patch removes the distbuild from the list after cancellation',177,1,177,'fa5d592f_aab80f2b',NULL),(6,'2015-04-01 10:48:29','Uploaded patch set 1.',177,1,177,'fa5d592f_ea6727e9',NULL),(NULL,'2015-06-12 11:27:31','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ibe3edab5, however the current patch set is 3.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',178,2,178,'3a4c51b2_1ca6f5c1',NULL),(6,'2015-06-12 11:27:29','Patch Set 2: Code-Review+2\n\nLooks OK at a glance.',178,2,178,'3a4c51b2_3ca131aa',NULL),(6,'2015-06-12 11:28:01','Patch Set 3: Patch Set 2 was rebased',178,2,178,'3a4c51b2_9c916555',NULL),(6,'2015-06-12 11:28:06','Change has been successfully merged into the git repository.',178,3,178,'3a4c51b2_dc9bed70',NULL),(6,'2015-06-12 11:28:04','Patch Set 3: Code-Review+2',178,3,178,'3a4c51b2_fc9ea962',NULL),(27,'2015-04-21 13:07:27','Patch Set 2: Code-Review+1',178,2,178,'7a7fa997_56dd9413',NULL),(39,'2015-05-18 15:42:40','Patch Set 2: Code-Review+1',178,2,178,'9adffdf1_af4599b4',NULL),(11,'2015-04-01 11:01:15','Uploaded patch set 1.',178,1,178,'fa5d592f_0aaa7bd4',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',178,2,178,'fa6b99d7_3a2561ab',NULL),(NULL,'2015-06-12 11:28:06','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I169fc822, however the current patch set is 3.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',179,2,179,'3a4c51b2_3c881122',NULL),(6,'2015-06-12 11:28:15','Patch Set 3: Code-Review+2',179,3,179,'3a4c51b2_5c87dd0f',NULL),(6,'2015-06-12 11:28:12','Patch Set 3: Patch Set 2 was rebased',179,2,179,'3a4c51b2_7c829901',NULL),(6,'2015-06-12 11:27:55','Patch Set 2: Code-Review+2\n\nLooks Ok at a glance.',179,2,179,'3a4c51b2_7cabb989',NULL),(6,'2015-06-12 11:28:16','Change has been successfully merged into the git repository.',179,3,179,'3a4c51b2_bc7b8128',NULL),(NULL,'2015-06-12 11:27:57','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ibe3edab5, however the current patch set is 3.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',179,2,179,'3a4c51b2_bc942145',NULL),(27,'2015-04-20 12:01:59','Patch Set 2: Code-Review+1\n\nthis seems to be a sensible addition of error checking. and seems to be solid code.',179,2,179,'9a6a9dd7_375d78ea',NULL),(39,'2015-05-18 15:43:34','Patch Set 2: Code-Review+1',179,2,179,'9adffdf1_4f12edb5',NULL),(11,'2015-04-01 11:31:42','Uploaded patch set 1.',179,1,179,'fa5d592f_4aee3324',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',179,2,179,'fa6b99d7_da39c5d9',NULL),(11,'2015-04-01 13:43:40','Uploaded patch set 1.',180,1,180,'fa5d592f_0a5ddbe9',NULL),(11,'2015-04-01 14:03:12','Abandoned\n\nLooks like this didn\'t do what I expected.',180,3,180,'fa5d592f_8a68ab88',NULL),(7,'2015-04-01 13:47:59','Patch Set 3: Code-Review-2',180,3,180,'fa5d592f_aa6b6f84',NULL),(11,'2015-04-01 13:44:40','Patch Set 3: Commit message was updated',180,3,180,'fa5d592f_ca6ea396',NULL),(11,'2015-04-01 13:44:29','Patch Set 2: Commit message was updated',180,2,180,'fa5d592f_ea716778',NULL),(11,'2015-04-21 16:19:24','Patch Set 2: Code-Review+1',181,2,181,'7a7fa997_561274b5',NULL),(6,'2015-04-02 09:41:08','Patch Set 1: Code-Review-1\n\nThis means that Morph will now not be able to build any definitions repo that doesn\'t contain scripts/licensecheck.pl! That\'s really a step in the wrong direction.\n\nIt seems that this is also a step to slowing down builds for people who don\'t care about license information.\n\nI\'m not sure the best way to do this right now, but it seems like a massive hack to do it this way.',181,1,181,'ba57610f_08b5e7cc',NULL),(31,'2015-05-01 07:57:48','Abandoned',181,2,181,'bada0100_04f606d8',NULL),(6,'2015-04-09 09:19:56','Patch Set 2:\n\nI guess embedding licensecheck.pl in morph.git is a reasonable option, if we\'re going to have a Morph plugin that depends on it. Of course it also introduces a dependency on Perl, but I think that Git depends on Perl anyway so it\'s no issue in practice.\n\nAbout the effect on build times: I did a quick test myself of running the following in gcc.git (as an example of a big repo):\n\n sudo sh -c \'echo 3 > /proc/sys/vm/drop_caches\'\n time perl ../../baserock/definitions/scripts/licensecheck.pl * > /tmp/licenses\n\nIt reported 13.745s. If that\'s the worst case then yes, the effect on build times isn\'t really too bad.\n\nSo as long as every license reported by licensecheck.pl was included in the metadata (it\'d be misleading to only include one), I\'d be OK with doing that.',181,2,181,'da87b5cf_81043a16',NULL),(31,'2015-04-01 14:34:38','Patch Set 1:\n\n(1 comment)',181,1,181,'fa5d592f_2a0f7fe3',NULL),(7,'2015-04-01 16:03:45','Patch Set 1:\n\n(1 comment)',181,1,181,'fa5d592f_4a3193a1',NULL),(31,'2015-04-01 14:32:27','Uploaded patch set 1.',181,1,181,'fa5d592f_6a0577c1',NULL),(15,'2015-04-01 16:00:57','Patch Set 1: Code-Review-1\n\n(1 comment)',181,1,181,'fa5d592f_aa024fb2',NULL),(31,'2015-04-08 09:04:00','Patch Set 2:\n\n> This means that Morph will now not be able to build any definitions repo that doesn\'t contain scripts/licensecheck.pl! That\'s really a step in the wrong direction.\n\nGood point. Hmm. I could reimplement licencecheck.pl in Python in morph. Or can we just include it with morph? Any other ideas?\n\n> It seems that this is also a step to slowing down builds for people who don\'t care about license information.\n\nFrom the testing I did, just extracting the git build directories was vastly more costly than running licencecheck. I don\'t think the speed impact would be noticeable at all.',181,2,181,'fa82b9bf_420e3236',NULL),(31,'2015-04-08 08:53:27','Patch Set 2: Patch Set 1 was rebased',181,1,181,'fa82b9bf_62ffb602',NULL),(7,'2015-04-01 16:35:22','Patch Set 2: Code-Review+1\n\nLooks good, and I trust Richard Maw :P',182,2,182,'da6255ed_69ffc502',NULL),(8,'2015-04-01 16:44:58','Change has been successfully merged into the git repository.',182,2,182,'da6255ed_c93d91bd',NULL),(8,'2015-04-01 16:44:56','Patch Set 2: Code-Review+2',182,2,182,'da6255ed_e9405537',NULL),(8,'2015-04-01 16:27:30','Uploaded patch set 2.',182,2,182,'fa5d592f_2add3f43',NULL),(37,'2015-04-01 16:12:23','Patch Set 1:\n\n(1 comment)',182,1,182,'fa5d592f_8a166bf0',NULL),(8,'2015-04-01 16:02:36','Uploaded patch set 1.',182,1,182,'fa5d592f_8aff8baa',NULL),(37,'2015-04-01 16:29:27','Patch Set 2: Code-Review+1\n\nLooks good to me',182,2,182,'fa5d592f_aaf00fca',NULL),(37,'2015-04-01 16:11:44','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI think we either need to use the upstream version control, or explain why we\'re not doing so in the commit message.',182,1,182,'fa5d592f_ca1c6316',NULL),(7,'2015-04-01 16:10:30','Patch Set 1:\n\n(1 comment)\n\nLorry file looks good to me, only one nitpick',182,1,182,'fa5d592f_ea1f2708',NULL),(7,'2015-04-01 16:43:02','Patch Set 1: Code-Review+1',183,1,183,'da6255ed_090e0935',NULL),(41,'2015-04-01 16:41:13','Uploaded patch set 1.',183,1,183,'da6255ed_2909cd2c',NULL),(6,'2015-04-01 16:46:29','Change has been successfully rebased as ff184c5dca72f94000cc922e7a5f70a24a2b81b9',183,1,183,'da6255ed_4979a192',NULL),(6,'2015-04-01 16:46:29','Patch Set 2: Patch Set 1 was rebased',183,1,183,'da6255ed_6974659c',NULL),(8,'2015-04-01 16:46:17','Patch Set 1: Code-Review+2',183,1,183,'da6255ed_8947994b',NULL),(6,'2015-04-02 09:05:58','Change has been successfully merged into the git repository.',184,1,184,'ba57610f_089e0757',NULL),(8,'2015-04-02 08:54:15','Patch Set 1:\n\nLooks sensible to me',184,1,184,'ba57610f_2899cb6e',NULL),(8,'2015-04-02 08:53:55','Patch Set 1: Code-Review+2',184,1,184,'ba57610f_4894ff36',NULL),(6,'2015-04-01 16:44:07','Patch Set 1:\n\nTurns out I didn\'t test https://gerrit.baserock.org/#/c/174/ properly. Sorry',184,1,184,'da6255ed_a91c9d6b',NULL),(6,'2015-04-01 16:43:29','Uploaded patch set 1.',184,1,184,'da6255ed_c90fd12d',NULL),(6,'2015-04-02 08:50:44','Patch Set 3: Code-Review-1\n\nSeems that neither /etc/bashrc nor /etc/bash.bashrc get read automatically by the GNU Bash program. Several distros do have those files but they always get included from somewhere else e.g. /etc/profile or ~/.bashrc. So this patch won\'t do anything as-is.\n\nhttps://www.linuxquestions.org/questions/linux-newbie-8/etc-profile-vs-etc-bashrc-315796/\nhttps://www.linuxquestions.org/questions/linux-general-1/etc-profile-v-s-etc-bashrc-273992/',185,3,185,'ba57610f_688fc324',NULL),(6,'2015-04-02 08:47:08','Patch Set 3:\n\n(1 comment)\n\nAccording to \'man bash\', PROMPT_COMMAND is executed \'prior to issuing each primary prompt.\' So it seems what this does is cause \'bash\' to set the terminal title each time it issues a prompt. If I manually run the command then I do see my terminal title change to eg. .`root@laptop:~`. Which is nice.\n\nHowever if I install /etc/bash.bashrc in /etc in my chroot manually, then run \'enter-baserock\', I don\'t see my terminal title change at all. Likewise if I call it /etc/bashrc I don\'t see the terminal title change.\n\nIf I run \'. /etc/bash.bashrc\' in my chroot then I do see the terminal title change.\n\nIf I run \'. /etc/bash.bashrc\' in an SSH session into a Jetson, I get this error:\n\n sh: binfmt.d: unknown operand\n\nAny idea what\'s going on?',185,3,185,'ba57610f_8872f747',NULL),(6,'2015-04-02 09:07:17','Patch Set 3: Code-Review+1\n\nSorry, I missed the second patch to add this to /etc/profile',185,3,185,'ba57610f_a8ac9b8d',NULL),(6,'2015-04-02 09:07:05','Patch Set 3: Code-Review+2',185,3,185,'ba57610f_c89fcf4f',NULL),(15,'2015-04-28 17:23:16','Uploaded patch set 4.',185,4,185,'bada0100_103ba4ec',NULL),(6,'2015-04-29 06:59:41','Patch Set 4: Code-Review+1\n\nWould be good to have comments in the file explaining what the different bits do, because it\'s a bit cryptic otherwise. See how Linux From Scratch does it for example: \n\n80-char line wrapping would also be good.',185,4,185,'bada0100_13e72ee6',NULL),(15,'2015-04-29 13:27:24','Patch Set 6: Code-Review+2',185,6,185,'bada0100_564da471',NULL),(8,'2015-04-29 13:04:15','Patch Set 5: Code-Review+1\n\nok, fair enough',185,5,185,'bada0100_7336ba05',NULL),(8,'2015-04-29 10:45:37','Patch Set 5:\n\n(1 comment)',185,5,185,'bada0100_737ebae6',NULL),(15,'2015-04-29 13:27:25','Change has been successfully merged into the git repository.',185,6,185,'bada0100_76522815',NULL),(15,'2015-04-29 10:36:47','Uploaded patch set 5.',185,5,185,'bada0100_931f9eb7',NULL),(15,'2015-04-29 12:48:33','Patch Set 5:\n\n(1 comment)',185,5,185,'bada0100_93579e26',NULL),(15,'2015-04-29 13:27:20','Patch Set 6: Patch Set 5 was rebased',185,5,185,'bada0100_b63090e9',NULL),(8,'2015-04-28 18:13:50','Patch Set 4:\n\n(1 comment)',185,4,185,'bada0100_d339a6d9',NULL),(15,'2015-04-29 13:27:11','Patch Set 5: Code-Review+2',185,5,185,'bada0100_d63994d9',NULL),(NULL,'2015-04-29 13:27:14','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I4a4b238f, however the current patch set is 4.\n* Depends on commit 1ba8fb72fc0cbb7cb94b86c32a77fe936fd420d3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',185,5,185,'bada0100_f63618e7',NULL),(15,'2015-04-01 17:22:49','Uploaded patch set 1.',185,1,185,'da6255ed_8951d9da',NULL),(15,'2015-04-01 18:44:04','Uploaded patch set 3.',185,3,185,'da6255ed_89d799ed',NULL),(15,'2015-04-01 17:38:05','Uploaded patch set 2.',185,2,185,'da6255ed_89ff99aa',NULL),(8,'2015-04-27 09:21:08','Patch Set 3: Code-Review+1',185,3,185,'dad5f5cf_315cb025',NULL),(6,'2015-04-13 09:22:17','Patch Set 1: Code-Review+2',186,1,186,'5a93c517_1d09732c',NULL),(6,'2015-04-13 09:22:20','Patch Set 2: Patch Set 1 was rebased',186,1,186,'5a93c517_3d0eaf35',NULL),(8,'2015-04-13 09:10:50','Patch Set 1: Code-Review+1',186,1,186,'5a93c517_5dfffb01',NULL),(6,'2015-04-13 09:22:21','Change has been successfully rebased as b949a22d0600c925a7acac195b577731a869d7d9',186,1,186,'5a93c517_dd122b58',NULL),(6,'2015-04-02 09:09:46','Patch Set 1: Code-Review+1',186,1,186,'ba57610f_68b6a3de',NULL),(6,'2015-04-02 09:09:33','Patch Set 1:\n\nNot tested, but +1, thanks for fixing!',186,1,186,'ba57610f_88a9d77d',NULL),(7,'2015-04-02 10:35:25','Patch Set 1:\n\n> It can, but Im not sure it will fit there (this is not a\n > development tool). Indeed, I was to put this in core with bash, I\n > think it matches perfectly what foundation is for: \"Basic userland\n > runtime system\" , ie, not needed to build but as a basic runtime\n > tool)\n\nOK, just saying because it sounds like it is a tool useful for development, but nothing else',186,1,186,'ba57610f_a8c37b37',NULL),(15,'2015-04-02 09:55:07','Patch Set 1:\n\n> Can this go to devtools?\n\nIt can, but Im not sure it will fit there (this is not a development tool). Indeed, I was to put this in core with bash, I think it matches perfectly what foundation is for: \"Basic userland runtime system\" , ie, not needed to build but as a basic runtime tool)',186,1,186,'ba57610f_c8c6af49',NULL),(15,'2015-04-02 11:38:01','Patch Set 1:\n\n> > It can, but Im not sure it will fit there (this is not a\n > > development tool). Indeed, I was to put this in core with bash, I\n > > think it matches perfectly what foundation is for: \"Basic\n > userland\n > > runtime system\" , ie, not needed to build but as a basic runtime\n > > tool)\n > \n > OK, just saying because it sounds like it is a tool useful for\n > development, but nothing else\n\nIts a tool useful to use the system in general (for example systemd-analize b will complete to \'blame\')',186,1,186,'ba57610f_e83e1329',NULL),(15,'2015-04-01 18:26:59','Uploaded patch set 1.',186,1,186,'da6255ed_a9c37d37',NULL),(7,'2015-04-01 20:34:50','Patch Set 1:\n\nCan this go to devtools?',186,1,186,'da6255ed_c9d7d1be',NULL),(6,'2015-04-02 09:07:03','Patch Set 1: Code-Review+1\n\nIt\'s weird that we set up /etc/profile in the busybox chunk, but this OK for now.',187,1,187,'ba57610f_e8a29399',NULL),(15,'2015-04-28 14:50:59','Patch Set 1:\n\n(1 comment)',187,1,187,'bada0100_30034875',NULL),(15,'2015-04-28 17:23:16','Uploaded patch set 2.',187,2,187,'bada0100_30402856',NULL),(15,'2015-04-29 08:11:34','Patch Set 2: Code-Review-1',187,2,187,'bada0100_33035275',NULL),(15,'2015-04-29 12:46:36','Patch Set 3: Code-Review+2',187,3,187,'bada0100_337272e6',NULL),(15,'2015-04-29 12:47:08','Patch Set 4: Code-Review+2',187,4,187,'bada0100_534a9684',NULL),(6,'2015-04-29 06:55:47','Patch Set 2:\n\nYou need to update essential-files/manifest as well for /etc/profile to actually be installed, I think\n\nThanks so much for looking at this anyway!',187,2,187,'bada0100_53ddb613',NULL),(15,'2015-04-29 12:47:09','Change has been successfully merged into the git repository.',187,4,187,'bada0100_734f9a93',NULL),(8,'2015-04-28 18:10:07','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nThen change can be done at merging time',187,2,187,'bada0100_931c7e6c',NULL),(15,'2015-04-29 10:36:47','Uploaded patch set 3.',187,3,187,'bada0100_b31c22c3',NULL),(15,'2015-04-29 12:47:05','Patch Set 4: Patch Set 3 was rebased',187,3,187,'bada0100_b37d02b4',NULL),(8,'2015-04-28 15:49:47','Patch Set 1:\n\n> (1 comment)\n\nI think this should be in the correct place so we avoid waiting for another patch series that we can forget to do it in the future. Despite this, I won\'t ban this to be in as it is.',187,1,187,'bada0100_d06c3c39',NULL),(6,'2015-04-29 11:22:32','Patch Set 3: Code-Review+1',187,3,187,'bada0100_d36c4639',NULL),(NULL,'2015-04-29 12:46:38','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I34446bbd, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',187,3,187,'bada0100_d37686d8',NULL),(15,'2015-04-01 20:57:54','Uploaded patch set 1.',187,1,187,'da6255ed_a9fb7d46',NULL),(8,'2015-04-27 09:20:58','Patch Set 1:\n\n(1 comment)',187,1,187,'dad5f5cf_11572c04',NULL),(11,'2015-04-02 08:43:32','Abandoned',188,1,188,'ba57610f_a875bb33',NULL),(11,'2015-04-02 08:40:45','Uploaded patch set 1.',188,1,188,'ba57610f_e87bb327',NULL),(6,'2015-06-12 11:28:39','Patch Set 3: Code-Review+2',189,3,189,'3a4c51b2_1c943536',NULL),(6,'2015-06-12 11:28:36','Patch Set 3: Patch Set 2 was rebased',189,2,189,'3a4c51b2_3c8f7125',NULL),(6,'2015-06-12 11:28:40','Change has been successfully merged into the git repository.',189,3,189,'3a4c51b2_7c99f96d',NULL),(6,'2015-06-12 11:28:26','Patch Set 2: Code-Review+2',189,2,189,'3a4c51b2_9c78452d',NULL),(NULL,'2015-06-12 11:28:31','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ic8f6f31e, however the current patch set is 3.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',189,2,189,'3a4c51b2_fc750933',NULL),(27,'2015-04-20 11:40:33','Patch Set 2: Code-Review+1\n\nseems good to me',189,2,189,'9a6a9dd7_175874f9',NULL),(39,'2015-05-18 15:43:56','Patch Set 2: Code-Review+1',189,2,189,'9adffdf1_6f17b1a4',NULL),(11,'2015-04-02 08:42:58','Uploaded patch set 1.',189,1,189,'ba57610f_c878ef2d',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',189,2,189,'fa6b99d7_9a334df6',NULL),(11,'2015-04-02 11:12:48','Uploaded patch set 1.',190,1,190,'ba57610f_28e78be6',NULL),(11,'2015-04-02 11:17:30','Abandoned\n\nTest success',190,2,190,'ba57610f_6804637e',NULL),(11,'2015-04-02 11:13:23','Patch Set 2: Commit message was updated',190,2,190,'ba57610f_e8d053f9',NULL),(15,'2015-04-02 11:36:26','Patch Set 1: Code-Review-1\n\n(2 comments)',191,1,191,'ba57610f_28354b46',NULL),(6,'2015-04-02 12:03:17','Change has been successfully merged into the git repository.',191,2,191,'ba57610f_28830bce',NULL),(7,'2015-04-02 11:24:58','Uploaded patch set 1.',191,1,191,'ba57610f_28fe6b6c',NULL),(6,'2015-04-02 12:03:08','Patch Set 2: Code-Review+2',191,2,191,'ba57610f_487e3fe6',NULL),(7,'2015-04-02 11:39:49','Uploaded patch set 2.',191,2,191,'ba57610f_884557b5',NULL),(8,'2015-04-02 11:32:27','Patch Set 1: Code-Review+1\n\nLooks ok to me',191,1,191,'ba57610f_88ee77b3',NULL),(15,'2015-04-02 11:53:33','Patch Set 2: Code-Review+1',191,2,191,'ba57610f_a81ffbb6',NULL),(7,'2015-04-02 11:38:36','Patch Set 1:\n\n(2 comments)\n\nThanks for reviewing. I\'ll fix the comments in the next patch set.',191,1,191,'ba57610f_a8481bcd',NULL),(11,'2015-04-22 17:01:49','Abandoned\n\nThis was definitely an error',192,3,192,'5a7ca5a3_353a5037',NULL),(11,'2015-04-22 16:34:39','Patch Set 3: Commit message was updated',192,3,192,'5a7ca5a3_d5d0bcf9',NULL),(11,'2015-04-02 13:46:56','Uploaded patch set 1.',192,1,192,'ba57610f_e801733a',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',192,2,192,'fa6b99d7_3a0ec135',NULL),(29,'2015-04-02 15:31:04','Abandoned\n\nA better version of this patch already exists in the baserock/openstack-v5-kernel branch',193,1,193,'ba57610f_0b0e0135',NULL),(8,'2015-04-02 14:41:14','Patch Set 1: -Code-Review\n\nI agree with Richard in this, so I change my vote to 0',193,1,193,'ba57610f_28442b73',NULL),(29,'2015-04-02 15:30:17','Patch Set 1: Code-Review-2\n\n> The baserock/openstack-v5-kernel branch contains a version of this\n > patch which adds the config to all the appropriate systems, could\n > we use that instead?\n\nYes the commit for adding xfs support in baserock/openstack-v5-kernel\nlooks better, I\'ll abandon this change.',193,1,193,'ba57610f_6bffbd02',NULL),(29,'2015-04-02 14:05:55','Uploaded patch set 1.',193,1,193,'ba57610f_a8925bf4',NULL),(37,'2015-04-02 14:13:57','Patch Set 1:\n\nThe baserock/openstack-v5-kernel branch contains a version of this patch which adds the config to all the appropriate systems, could we use that instead?',193,1,193,'ba57610f_c8ac6f38',NULL),(8,'2015-04-02 14:12:02','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nJust a nitpick comment',193,1,193,'ba57610f_e8af332a',NULL),(33,'2015-04-07 08:33:18','Patch Set 1:\n\n(1 comment)',194,1,194,'1a486d77_03738eb2',NULL),(8,'2015-04-02 18:09:39','Patch Set 1:\n\n(1 comment)',194,1,194,'ba57610f_2b82e500',NULL),(29,'2015-04-02 17:56:28','Patch Set 1: Code-Review-2\n\n(13 comments)\n\nThanks for the comments, especially on the shell in swift-storage.configure.\n\nI\'ll send a v2 of this soon',194,1,194,'ba57610f_2bab058b',NULL),(29,'2015-04-02 14:10:32','Patch Set 1:\n\nWiki documentation for these changes is on the way',194,1,194,'ba57610f_68bc636d',NULL),(8,'2015-04-02 16:25:16','Patch Set 1: Code-Review-1\n\n(15 comments)\n\nI vote -1 mainly because the systemd unit will never start depending on keystone-setup.service which does not exist in definitions master and I am unsure about using a devel-system as an storage system for swift (although I can live with this last thing).\nBash comments are mostly about style so you can adopt them or ignore them.',194,1,194,'ba57610f_6bd0dd53',NULL),(29,'2015-04-02 14:05:55','Uploaded patch set 1.',194,1,194,'ba57610f_888f97cc',NULL),(8,'2015-04-02 18:05:14','Patch Set 1: -Code-Review\n\n(1 comment)',194,1,194,'ba57610f_ab9ed561',NULL),(29,'2015-04-10 19:09:41','Patch Set 4: Patch Set 3 was rebased',194,3,194,'ba8cc1f7_2041aa0b',NULL),(29,'2015-04-10 19:09:41','Change has been successfully rebased as 4171a9255bc913cff40a177daf7611c06d735754',194,3,194,'ba8cc1f7_40462e25',NULL),(29,'2015-04-10 18:59:13','Patch Set 3: -Code-Review',194,3,194,'ba8cc1f7_6037b2b1',NULL),(29,'2015-04-10 19:09:26','Patch Set 3: Code-Review+2',194,3,194,'ba8cc1f7_803c3695',NULL),(29,'2015-04-10 18:58:45','Uploaded patch set 3.',194,3,194,'ba8cc1f7_c0ba3e0a',NULL),(29,'2015-04-08 17:59:46','Patch Set 2: Code-Review-2\n\nThanks for the reviews, I\'m putting a -2 just so there\'s chance for others to review this before it gets merged',194,2,194,'fa82b9bf_22f3ee0b',NULL),(29,'2015-04-08 10:16:02','Uploaded patch set 2.',194,2,194,'fa82b9bf_6226d6bc',NULL),(8,'2015-04-08 14:54:02','Patch Set 2: Code-Review+1\n\nMy comments to the v1 were addressed.',194,2,194,'fa82b9bf_629b36ca',NULL),(29,'2015-04-08 10:18:41','Patch Set 2: -Code-Review\n\n(remove veto)',194,2,194,'fa82b9bf_822bda81',NULL),(37,'2015-04-08 11:54:59','Patch Set 2: Code-Review+1\n\n(4 comments)',194,2,194,'fa82b9bf_c247a24a',NULL),(29,'2015-04-08 13:33:32','Patch Set 2:\n\n(4 comments)',194,2,194,'fa82b9bf_e26746e9',NULL),(37,'2015-04-07 09:28:42','Patch Set 1: Code-Review+2',195,1,195,'1a486d77_0346ee23',NULL),(6,'2015-04-07 09:16:47','Patch Set 1: Code-Review+1\n\nI don\'t like the fact that this is enabled in some kernels but not others. But there are already other flags that are enabled for some architectures and not others. I trust this has been well tested already.',195,1,195,'1a486d77_63e9221a',NULL),(37,'2015-04-07 09:20:50','Patch Set 1:\n\n> But the installer will always need changes to know to how map the partitions on the raw disk, to the devices on the target machine\n\nYeah, it bugs me too. We ought to have a kernel build-system which does all the kernel configuration we expect for most Baserock systems, and do per-target configuration in the pre-configure commands, and per-role configuration in post-configure commands.\n\nThis change however is to fix the names of options that have changed, so that we *do* still enable these options.',195,1,195,'1a486d77_a3bdda04',NULL),(37,'2015-04-07 09:28:58','Change has been successfully merged into the git repository.',195,1,195,'1a486d77_e34ab226',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',195,1,195,'ba57610f_4b799992',NULL),(6,'2015-04-07 09:17:04','Patch Set 1: Code-Review+1\n\nI don\'t like the fact that this is enabled in some kernels but not others. But there are already other flags that are enabled for some architectures and not others. I trust this has been well tested already.',196,1,196,'1a486d77_23f32a0c',NULL),(37,'2015-04-07 09:22:17','Patch Set 1:\n\n> But the installer will always need changes to know to how map the partitions on the raw disk, to the devices on the target machine\n\nFor this change I attempted to enable it for every architecture we commonly use, as the ones we don\'t commonly use aren\'t often tested, so could be left broken for a long time by this change.',196,1,196,'1a486d77_6337e2b1',NULL),(37,'2015-04-07 09:30:01','Change has been successfully merged into the git repository.',196,1,196,'1a486d77_a354baca',NULL),(37,'2015-04-07 09:29:32','Patch Set 1: Code-Review+2',196,1,196,'1a486d77_c347b61c',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',196,1,196,'ba57610f_2b6e65ca',NULL),(6,'2015-04-07 09:17:12','Patch Set 1: Code-Review+1\n\nI don\'t like the fact that this is enabled in some kernels but not others. But there are already other flags that are enabled for some architectures and not others. I trust this has been well tested already.',197,1,197,'1a486d77_03f82ee4',NULL),(37,'2015-04-07 09:30:54','Change has been successfully merged into the git repository.',197,1,197,'1a486d77_4363c6b1',NULL),(37,'2015-04-07 09:30:50','Patch Set 1: Code-Review+2',197,1,197,'1a486d77_8351beda',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',197,1,197,'ba57610f_0b73a1b2',NULL),(37,'2015-04-07 09:31:43','Change has been successfully merged into the git repository.',198,1,198,'1a486d77_035dcee9',NULL),(37,'2015-04-07 09:31:35','Patch Set 1: Code-Review+2',198,1,198,'1a486d77_2358caf9',NULL),(33,'2015-04-07 09:02:58','Patch Set 1: Code-Review+1',198,1,198,'1a486d77_e3ae32e7',NULL),(6,'2015-04-07 09:19:24','Patch Set 1: Code-Review+1',198,1,198,'1a486d77_e3c3d288',NULL),(37,'2015-04-02 16:16:01','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',198,1,198,'ba57610f_cb92299f',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',198,1,198,'ba57610f_eb672de9',NULL),(37,'2015-04-07 09:59:22','Change has been successfully rebased as a9b03973f1b02740e32deea80a67b87c6c0c3906',199,1,199,'1a486d77_23dd6a43',NULL),(37,'2015-04-07 09:59:22','Patch Set 2: Patch Set 1 was rebased',199,1,199,'1a486d77_43d86653',NULL),(37,'2015-04-07 09:59:18','Patch Set 1: Code-Review+2',199,1,199,'1a486d77_63d36239',NULL),(33,'2015-04-07 09:03:42','Patch Set 1: Code-Review+1',199,1,199,'1a486d77_c3ab36d5',NULL),(6,'2015-04-07 09:19:39','Patch Set 1: Code-Review+1',199,1,199,'1a486d77_c3c0d67e',NULL),(37,'2015-04-02 16:16:06','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',199,1,199,'ba57610f_ab8ff574',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',199,1,199,'ba57610f_cb6469e7',NULL),(37,'2015-04-07 10:01:47','Patch Set 2: Patch Set 1 was rebased',200,1,200,'1a486d77_03b94ee9',NULL),(33,'2015-04-07 09:08:22','Patch Set 1: Code-Review+1',200,1,200,'1a486d77_83b53e33',NULL),(37,'2015-04-07 10:02:03','Change has been successfully merged into the git repository.',200,2,200,'1a486d77_c3ca166e',NULL),(6,'2015-04-07 09:17:42','Patch Set 1: Code-Review+2',200,1,200,'1a486d77_c3d9f684',NULL),(NULL,'2015-04-07 10:00:13','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I939022e8, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',200,1,200,'1a486d77_c3e33604',NULL),(37,'2015-04-07 10:02:00','Patch Set 2: Code-Review+2',200,2,200,'1a486d77_e3cd1288',NULL),(37,'2015-04-02 16:16:11','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',200,1,200,'ba57610f_8b8c3181',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',200,1,200,'ba57610f_ab6135d5',NULL),(37,'2015-04-07 10:03:25','Change has been successfully merged into the git repository.',201,2,201,'1a486d77_03b02ef3',NULL),(37,'2015-04-07 10:03:22','Patch Set 2: Code-Review+2',201,2,201,'1a486d77_23ab2a8b',NULL),(37,'2015-04-07 10:03:08','Patch Set 2: Patch Set 1 was rebased',201,1,201,'1a486d77_43a626c3',NULL),(33,'2015-04-07 09:08:41','Patch Set 1: Code-Review+1',201,1,201,'1a486d77_63824254',NULL),(NULL,'2015-04-07 10:03:05','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I0f426296, however the current patch set is 2.\n* Depends on commit 56498630d65ef1fdca175f1c1f00969e15ea22a2 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',201,1,201,'1a486d77_63a122a9',NULL),(6,'2015-04-07 09:18:08','Patch Set 1: Code-Review+2',201,1,201,'1a486d77_83e3fe32',NULL),(6,'2015-04-07 09:18:02','Patch Set 1: Code-Review+1',201,1,201,'1a486d77_a3e6fa42',NULL),(37,'2015-04-02 16:16:15','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',201,1,201,'ba57610f_4bee3924',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',201,1,201,'ba57610f_8b5e7111',NULL),(33,'2015-04-07 09:08:55','Patch Set 1: Code-Review+1',202,1,202,'1a486d77_43874662',NULL),(37,'2015-04-07 10:04:22','Change has been successfully merged into the git repository.',202,2,202,'1a486d77_438d0631',NULL),(37,'2015-04-07 10:04:20','Patch Set 2: Code-Review+2',202,2,202,'1a486d77_63880223',NULL),(6,'2015-04-07 09:18:13','Patch Set 1: Code-Review+2',202,1,202,'1a486d77_63d00254',NULL),(37,'2015-04-07 10:03:50','Patch Set 2: Patch Set 1 was rebased',202,1,202,'1a486d77_839bfe71',NULL),(NULL,'2015-04-07 10:03:47','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I87f44ebc, however the current patch set is 2.\n* Depends on commit 55bb09a62def206a6ecb48abeae010d56dbcd0bc which has no change associated with it.\n* Depends on commit 56498630d65ef1fdca175f1c1f00969e15ea22a2 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',202,1,202,'1a486d77_a39efa61',NULL),(37,'2015-04-02 16:16:20','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',202,1,202,'ba57610f_2bf3050c',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',202,1,202,'ba57610f_6b9b3dca',NULL),(37,'2015-04-07 10:04:41','Patch Set 1: Code-Review+2',203,1,203,'1a486d77_03870e11',NULL),(33,'2015-04-07 09:09:06','Patch Set 1: Code-Review+1',203,1,203,'1a486d77_237c4a72',NULL),(6,'2015-04-07 09:18:21','Patch Set 1: Code-Review+1',203,1,203,'1a486d77_43d50642',NULL),(37,'2015-04-07 10:05:13','Change has been successfully merged into the git repository.',203,2,203,'1a486d77_638fe224',NULL),(37,'2015-04-07 10:05:10','Patch Set 2: Code-Review+2',203,2,203,'1a486d77_8372de47',NULL),(37,'2015-04-07 10:05:02','Patch Set 2: Patch Set 1 was rebased',203,1,203,'1a486d77_a375da33',NULL),(NULL,'2015-04-07 10:04:44','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I1b65a1b3, however the current patch set is 2.\n* Depends on commit 78f4bfc7e92e619a50d15ba5ed752fbdb98d3ab6 which has no change associated with it.\n* Depends on commit 55bb09a62def206a6ecb48abeae010d56dbcd0bc which has no change associated with it.\n* Depends on commit 56498630d65ef1fdca175f1c1f00969e15ea22a2 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',203,1,203,'1a486d77_c378d62d',NULL),(37,'2015-04-02 16:16:27','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',203,1,203,'ba57610f_0bf841e4',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',203,1,203,'ba57610f_4ba079f4',NULL),(33,'2015-04-07 09:09:32','Patch Set 1: Code-Review+1',204,1,204,'1a486d77_03814e4a',NULL),(6,'2015-04-07 09:19:11','Patch Set 1: Code-Review+1',204,1,204,'1a486d77_23ca0aa2',NULL),(37,'2015-04-07 10:06:17','Change has been successfully merged into the git repository.',204,2,204,'1a486d77_a3acba8d',NULL),(37,'2015-04-07 10:06:15','Patch Set 2: Code-Review+2',204,2,204,'1a486d77_c39fb64f',NULL),(37,'2015-04-07 10:06:08','Patch Set 2: Patch Set 1 was rebased',204,1,204,'1a486d77_e3a2b299',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',204,1,204,'ba57610f_2ba54504',NULL),(37,'2015-04-02 16:16:37','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',204,1,204,'ba57610f_ebdccd76',NULL),(6,'2015-04-07 09:19:16','Patch Set 1: Code-Review+1',205,1,205,'1a486d77_03cf0eb2',NULL),(37,'2015-04-07 10:06:36','Change has been successfully merged into the git repository.',205,2,205,'1a486d77_23b0cadc',NULL),(37,'2015-04-07 10:06:33','Patch Set 2: Code-Review+2',205,2,205,'1a486d77_43bbc6c4',NULL),(37,'2015-04-07 10:06:28','Patch Set 2: Patch Set 1 was rebased',205,1,205,'1a486d77_63b6c2de',NULL),(33,'2015-04-07 09:10:19','Patch Set 1: Code-Review+1',205,1,205,'1a486d77_e3951289',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',205,1,205,'ba57610f_0baa81d4',NULL),(37,'2015-04-02 16:17:02','Patch Set 1:\n\nNote that this merge conflict is because its dependent patch hasn\'t been merged.',205,1,205,'ba57610f_cbd90985',NULL),(37,'2015-04-07 09:26:44','Patch Set 1:\n\n> Maybe this one does only make sense for x86 :)\n\nPretty much. Theoretically this driver is usable on other architectures, since most have PCIe available.\nHowever you don\'t get many non-x86 devices that have free PCIe slots for you to put your own cards in. I\'ve only ever seen it before on a few high-end ARM dev-boards.',206,1,206,'1a486d77_2341ea0b',NULL),(37,'2015-04-07 10:06:53','Change has been successfully merged into the git repository.',206,2,206,'1a486d77_a3c39a37',NULL),(33,'2015-04-07 09:10:31','Patch Set 1: Code-Review+1',206,1,206,'1a486d77_c392169f',NULL),(37,'2015-04-07 10:06:52','Patch Set 2: Code-Review+2',206,2,206,'1a486d77_c3c69649',NULL),(37,'2015-04-07 10:06:45','Patch Set 2: Patch Set 1 was rebased',206,1,206,'1a486d77_e3c9925b',NULL),(6,'2015-04-07 09:17:31','Patch Set 1: Code-Review+1\n\nMaybe this one does only make sense for x86 :)',206,1,206,'1a486d77_e3dcf276',NULL),(37,'2015-04-02 16:01:01','Uploaded patch set 1.',206,1,206,'ba57610f_ebae0de7',NULL),(6,'2015-04-07 13:34:19','Patch Set 1: Code-Review+1\n\nI think returning 0 if the VERSION file is unparseable was agreed in a previous discussion about this feature. Hopefully we\'ll be able to drop support for version 0 soon, and then it won\'t really make a difference whether we assume version 0 or raise an InvalidVersionFile error -- probably the latter would be clearer.',207,1,207,'1a486d77_239faa05',NULL),(33,'2015-04-07 17:15:02','Patch Set 1:\n\n> I think returning 0 if the VERSION file is unparseable was agreed\n > in a previous discussion about this feature. Hopefully we\'ll be\n > able to drop support for version 0 soon, and then it won\'t really\n > make a difference whether we assume version 0 or raise an\n > InvalidVersionFile error -- probably the latter would be clearer.\n\nI was going to rework this to drop the InvalidVersionFile error,\nbut you have a point that when we come to drop support for version 0\nthis error will be clearer, so I\'m happy to leave it as it is.\n\nThis change really is a rollercoaster!',207,1,207,'1a486d77_c308d62f',NULL),(33,'2015-04-03 17:06:17','Patch Set 1:\n\n(1 comment)',207,1,207,'9a5c5d37_277c5a72',NULL),(33,'2015-04-03 13:58:05','Uploaded patch set 1.',207,1,207,'9a5c5d37_27a57a04',NULL),(15,'2015-04-03 16:38:48','Patch Set 1:\n\n(1 comment)',207,1,207,'9a5c5d37_67825254',NULL),(37,'2015-04-11 12:23:34','Patch Set 2: Patch Set 1 was rebased',207,1,207,'9a91bd0f_5f260bbc',NULL),(37,'2015-04-11 12:23:35','Change has been successfully rebased as 2ad079e853fae8b699274b5cecf1b31d6bbd514a',207,1,207,'9a91bd0f_7f2bcf82',NULL),(33,'2015-04-11 10:45:15','Patch Set 1:\n\n> > I think returning 0 if the VERSION file is unparseable was agreed\n > > in a previous discussion about this feature. Hopefully we\'ll be\n > > able to drop support for version 0 soon, and then it won\'t really\n > > make a difference whether we assume version 0 or raise an\n > > InvalidVersionFile error -- probably the latter would be clearer.\n > \n > I was going to rework this to drop the InvalidVersionFile error,\n > but you have a point that when we come to drop support for version\n > 0\n > this error will be clearer, so I\'m happy to leave it as it is.\n > \n > This change really is a rollercoaster!\n\nIt\'s been almost 4 weeks since I submitted the bug fix that depends on\nthis change, I really don\'t mind either way wrt InvalidVersionFile\nvs default to version 0 in the absence of a VERSIONS file,\nbut I\'d like this resolved one way or another so I can merge the fix.',207,1,207,'9a91bd0f_9f1c936c',NULL),(37,'2015-04-11 12:23:27','Patch Set 1: Code-Review+2\n\nWe only agreed formally that if the file is missing it\'s version 0.\nAnd we formally agreed that the first line is always version: X.\n\nIf we need to expand to change the format later, we can always add a version: $VERSION_FILE_HEADER_FINAL, and parse the rest of the file for the rest of the version.\n\nSo, I consider this to be complete.',207,1,207,'9a91bd0f_bf19577b',NULL),(NULL,'2015-04-07 01:35:51','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* I674e6af284b33705ae8235054906f56b8cd8a130\n',208,1,208,'1a486d77_035cae24',NULL),(NULL,'2015-04-07 13:35:53','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* I674e6af284b33705ae8235054906f56b8cd8a130\n',208,1,208,'1a486d77_03a4ae55',NULL),(NULL,'2015-04-06 13:49:18','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* I674e6af284b33705ae8235054906f56b8cd8a130\n',208,1,208,'3a4b7175_c40fbe2d',NULL),(18,'2015-04-06 13:33:23','Patch Set 1: Code-Review+2',208,1,208,'3a4b7175_e412ba57',NULL),(33,'2015-04-05 10:31:47','Patch Set 1:\n\n> Looks reasonable to me.\n > Though every time I see that supported versions list I get tempted\n > to turn it into a set.\n\nThanks :)\nyes a set would make more sense I think',208,1,208,'5a4e6583_050ef234',NULL),(42,'2015-04-05 10:19:08','Patch Set 1: Code-Review+1\n\nLooks reasonable to me.\nThough every time I see that supported versions list I get tempted to turn it into a set.',208,1,208,'5a4e6583_2509ee2c',NULL),(33,'2015-04-03 13:58:05','Uploaded patch set 1.',208,1,208,'9a5c5d37_07aa76d4',NULL),(NULL,'2015-04-11 12:54:16','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I674e6af2, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',208,1,208,'9a91bd0f_1f20839a',NULL),(33,'2015-04-11 12:54:35','Patch Set 2: Patch Set 1 was rebased',208,1,208,'9a91bd0f_3f2547ab',NULL),(18,'2015-04-11 12:57:24','Patch Set 2: Code-Review+2\n\n> Patch Set 2: Patch Set 1 was rebased',208,2,208,'9a91bd0f_df39bbd9',NULL),(37,'2015-04-11 13:04:53','Change has been successfully merged into the git repository.',208,2,208,'9a91bd0f_ff36ffe6',NULL),(8,'2015-04-13 11:46:39','Change has been successfully rebased as f0a31086d816d0a90fdcfaaa4ea58e122a6d99b3',209,1,209,'5a93c517_9d190325',NULL),(7,'2015-04-13 11:24:31','Patch Set 1: Code-Review+1',209,1,209,'5a93c517_9d6b4385',NULL),(8,'2015-04-13 11:46:36','Patch Set 1: Code-Review+2',209,1,209,'5a93c517_dd1f8b08',NULL),(8,'2015-04-13 11:46:39','Patch Set 2: Patch Set 1 was rebased',209,1,209,'5a93c517_fd1cc715',NULL),(15,'2015-04-03 16:12:32','Patch Set 1: Code-Review+1',209,1,209,'9a5c5d37_a7b84a2b',NULL),(33,'2015-04-03 16:07:49','Uploaded patch set 1.',209,1,209,'9a5c5d37_c7ab3ed5',NULL),(6,'2015-04-07 09:41:54','Patch Set 1: Code-Review+2',210,1,210,'1a486d77_83689e88',NULL),(6,'2015-04-07 09:43:00','Change has been successfully rebased as adebf15d27ed0281e9ecab52e984e7f6911df483',210,1,210,'1a486d77_c3f576cc',NULL),(6,'2015-04-07 09:43:00','Patch Set 2: Patch Set 1 was rebased',210,1,210,'1a486d77_e3f872c6',NULL),(33,'2015-04-04 09:19:51','Patch Set 1: Code-Review+1',210,1,210,'7a51691d_66ffee02',NULL),(15,'2015-04-03 17:39:46','Uploaded patch set 1.',210,1,210,'9a5c5d37_0781564a',NULL),(6,'2015-04-07 09:42:15','Patch Set 1: Code-Review+2',211,1,211,'1a486d77_6305a2c1',NULL),(15,'2015-04-07 11:04:48','Change has been successfully merged into the git repository.',211,2,211,'1a486d77_631242b6',NULL),(15,'2015-04-07 11:04:42','Patch Set 2: Code-Review+2',211,2,211,'1a486d77_83453eb5',NULL),(NULL,'2015-04-07 09:43:03','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I55bf8764, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',211,1,211,'1a486d77_a3027ab2',NULL),(15,'2015-04-07 11:04:21','Patch Set 2: Patch Set 1 was rebased',211,1,211,'1a486d77_a3483acd',NULL),(33,'2015-04-04 11:51:53','Patch Set 1: Code-Review+1\n\nI\'ve tested this on x86_64',211,1,211,'7a51691d_a61cc66b',NULL),(15,'2015-04-03 17:41:42','Patch Set 1:\n\nTo test this I built and run a x86-64 base baserock system',211,1,211,'9a5c5d37_c7921e9f',NULL),(15,'2015-04-03 17:39:46','Uploaded patch set 1.',211,1,211,'9a5c5d37_e7952289',NULL),(8,'2015-04-07 15:52:28','Patch Set 2: Patch Set 1 was rebased',212,1,212,'1a486d77_03402e55',NULL),(8,'2015-04-07 15:52:25','Patch Set 1: Code-Review+2',212,1,212,'1a486d77_233b2aed',NULL),(8,'2015-04-07 08:31:59','Patch Set 1: Code-Review+1\n\nThis looks fine and it is a good idea.',212,1,212,'1a486d77_236e8aca',NULL),(27,'2015-04-07 13:02:01','Patch Set 1: Code-Review+1',212,1,212,'1a486d77_83e1be9c',NULL),(8,'2015-04-07 15:52:29','Change has been successfully rebased as 1eb4aded65367880fe9b859d35b1a3c30ed846d6',212,1,212,'1a486d77_e324f2c7',NULL),(33,'2015-04-03 19:46:13','Uploaded patch set 1.',212,1,212,'9a5c5d37_a78f2a75',NULL),(8,'2015-04-07 08:55:13','Change has been successfully merged into the git repository.',213,1,213,'1a486d77_43a066f4',NULL),(8,'2015-04-07 08:55:06','Patch Set 1: Code-Review+2',213,1,213,'1a486d77_639b62ca',NULL),(33,'2015-04-04 13:48:28','Patch Set 1:\n\n> Patch Set 1: Code-Review+2\n\nSorry this was accidental, have changed to +1',213,1,213,'7a51691d_2620d69a',NULL),(33,'2015-04-04 13:47:21','Patch Set 1: Code-Review+1',213,1,213,'7a51691d_462bd282',NULL),(33,'2015-04-04 13:47:11','Patch Set 1: Code-Review+2',213,1,213,'7a51691d_6626cebc',NULL),(15,'2015-04-04 10:12:14','Uploaded patch set 1.',213,1,213,'7a51691d_e612be57',NULL),(8,'2015-04-07 08:24:51','Change has been successfully merged into the git repository.',214,1,214,'1a486d77_c33d76bd',NULL),(8,'2015-04-07 08:24:44','Patch Set 1: Code-Review+2',214,1,214,'1a486d77_e3407237',NULL),(15,'2015-04-04 12:11:17','Patch Set 1: Code-Review+1',214,1,214,'7a51691d_8619ca7b',NULL),(33,'2015-04-04 11:32:20','Uploaded patch set 1.',214,1,214,'7a51691d_c60fc22d',NULL),(6,'2015-04-07 09:42:24','Patch Set 1: Code-Review+2',215,1,215,'1a486d77_430aa6d3',NULL),(6,'2015-04-07 09:43:05','Change has been successfully rebased as 86f19299f71b16aeaadb5cbc569345efc96f3543',215,1,215,'1a486d77_632c824b',NULL),(6,'2015-04-07 09:43:05','Patch Set 2: Patch Set 1 was rebased',215,1,215,'1a486d77_83ff7eaa',NULL),(15,'2015-04-05 23:38:39','Uploaded patch set 1.',215,1,215,'5a4e6583_c50fba2d',NULL),(6,'2015-04-07 09:42:41','Patch Set 1: Code-Review+1',216,1,216,'1a486d77_230faae3',NULL),(15,'2015-04-07 14:02:38','Change has been successfully rebased as 259184abd8315109a71541ea64f613a83ac5ede4',216,1,216,'1a486d77_23b68a8b',NULL),(15,'2015-04-07 14:02:37','Patch Set 2: Patch Set 1 was rebased',216,1,216,'1a486d77_43c186e3',NULL),(15,'2015-04-07 14:02:35','Patch Set 1: Code-Review+2',216,1,216,'1a486d77_63bc826d',NULL),(27,'2015-04-07 13:00:58','Patch Set 1: Code-Review+1',216,1,216,'1a486d77_a3e4baac',NULL),(15,'2015-04-05 23:44:46','Uploaded patch set 1.',216,1,216,'5a4e6583_a51cbe6b',NULL),(6,'2015-04-07 09:42:46','Patch Set 1: Code-Review+1',217,1,217,'1a486d77_0314aef3',NULL),(15,'2015-04-07 14:02:52','Patch Set 1: Code-Review+2',217,1,217,'1a486d77_03bb8e73',NULL),(15,'2015-04-07 14:02:56','Change has been successfully rebased as 3ca9cac4fad26c0ce5c31dbaddca707e8f27fe66',217,1,217,'1a486d77_c3ac5638',NULL),(15,'2015-04-07 14:02:55','Patch Set 2: Patch Set 1 was rebased',217,1,217,'1a486d77_e3af522a',NULL),(27,'2015-04-07 12:59:59','Patch Set 1: Code-Review+1',217,1,217,'1a486d77_e3dab2e8',NULL),(15,'2015-04-05 23:59:18','Uploaded patch set 1.',217,1,217,'5a4e6583_8519c27b',NULL),(18,'2015-04-06 15:15:15','Patch Set 1:\n\n(1 comment)\n\n> (1 comment)\n\nI thought about that, but then noticed that all of the .chunk. things are actual artifacts for installing on systems, so i thought best to not include the word chunk?',218,1,218,'3a4b7175_44798e92',NULL),(15,'2015-04-06 16:55:51','Patch Set 1: Code-Review+1\n\n> (1 comment)\n > \n > > (1 comment)\n > \n > I thought about that, but then noticed that all of the .chunk.\n > things are actual artifacts for installing on systems, so i thought\n > best to not include the word chunk?\n\nAh, ok. Not sure about the details of this, but I still change my vote to +1 because either way this is already an improvement',218,1,218,'3a4b7175_848c2681',NULL),(18,'2015-04-06 14:02:42','Uploaded patch set 1.',218,1,218,'3a4b7175_a41cc26b',NULL),(15,'2015-04-06 15:07:43','Patch Set 1: Code-Review-1\n\n(1 comment)',218,1,218,'3a4b7175_c43d7ebd',NULL),(18,'2015-04-19 15:23:47','Abandoned',218,1,218,'ba65a107_d839cdd9',NULL),(6,'2015-04-09 09:30:14','Patch Set 1: Code-Review-1\n\nI agree with doing this, but there are bits of distbuild and a few tests that make assumptions about the name of the .build-log file, and they will be broken by this change.\n\n`grep build-log` in the the Morph source tree will show them all. The one in distbuild/worker_build_scheduler.py is the only one that would be tricky to fix, the code there to discover what files make up a chunk artifact needs rewriting completely.',218,1,218,'da87b5cf_2109ae2c',NULL),(16,'2015-04-09 10:07:57','Patch Set 1:\n\n(1 comment)\n\nI agree with Sam on this. The list-artifacts plugin will also need to be fixed I think too.',218,1,218,'da87b5cf_e112e657',NULL),(33,'2015-04-07 11:13:06','Patch Set 1:\n\n> Thanks for looking at this, it\'s a pretty comical bug in Morph that\n > circular dependencies cause a stack overflow.\n > \n > I think the right place to solve this is by fixing the\n > \'artifactresolver\' module -- i\'m a bit confused about what the new\n > code you\'ve added to \'sourceresolver\' is for, it seems to overlap\n > with what \'artifactresolver\' is doing already.\n > \n > I\'ve always found the \'artifactresolver\' code pretty hard to\n > understand though, perhaps you can delete it and move the new code\n > from \'sourceresolver\' there instead\n\nThe trouble is resolving artifacts happens *after* we\'ve created the source\npool, so we need to do loop detection either before/during source pool\ncreation, it seemed easier to me to do it before.\n\nThe artifact resolver does have some code for detecting mutually dependent\nstrata, I\'m not sure it\'s functionally equivalent to this, I think it may\njust check whether there\'s a mutual dependency between A and B, not accounting\nfor the possibility of any indirect mutual dependency e.g. A depends on B, B depends on C and C depends on A, I could be wrong about that though.',219,1,219,'1a486d77_03114eac',NULL),(37,'2015-04-07 13:09:05','Patch Set 1:\n\nGiven your comment that it fails when adding sources, I\'ll need to take a closer look at how it works, since it sounds like on its own, my suggestion cannot work.',219,1,219,'1a486d77_23e8ca7b',NULL),(37,'2015-04-07 13:07:36','Patch Set 1:\n\n(3 comments)\n\n> The artifact resolver does have some code for detecting mutually dependent strata, I\'m not sure it\'s functionally equivalent to this, I think it may just check whether there\'s a mutual dependency between A and B, not accounting for the possibility of any indirect mutual dependency e.g. A depends on B, B depends on C and C depends on A, I could be wrong about that though.\n\nIt does not handle indirect mutual dependencies to my knowledge.\n\nI agree that this has too much duplication, the parents and children structure of the node is duplicated in the Artifacts and Sources, with the added complication that the types of nodes in our actual build graph are heterogenous, and the artifact resolver also does the subset of morphology processing that your code does.\n\nGiven we construct a subset of the artifact graph, check it for cycles, then immediately discard it, I\'d prefer if we split up the artifact resolver step to start with something like what you\'re doing, do cycle detection, then fill in the rest of it.',219,1,219,'1a486d77_43f3c673',NULL),(33,'2015-04-07 14:13:38','Patch Set 1:\n\n(3 comments)',219,1,219,'1a486d77_83a65e52',NULL),(37,'2015-04-07 16:00:46','Patch Set 1:\n\n(1 comment)',219,1,219,'1a486d77_a32efaa3',NULL),(6,'2015-04-07 09:39:36','Patch Set 1:\n\nThanks for looking at this, it\'s a pretty comical bug in Morph that circular dependencies cause a stack overflow.\n\nI think the right place to solve this is by fixing the \'artifactresolver\' module -- i\'m a bit confused about what the new code you\'ve added to \'sourceresolver\' is for, it seems to overlap with what \'artifactresolver\' is doing already.\n\nI\'ve always found the \'artifactresolver\' code pretty hard to understand though, perhaps you can delete it and move the new code from \'sourceresolver\' there instead',219,1,219,'1a486d77_c36e9696',NULL),(37,'2015-04-07 13:18:13','Patch Set 1:\n\nOk, it looks to me like we need to add logic to the SourceResolver to keep track of which nodes it\'s already been to.\n\nI could have sworn it used to have such logic before it was factored out into a more appropriate place.',219,1,219,'1a486d77_c3fe9638',NULL),(33,'2015-04-06 18:57:25','Patch Set 1:\n\nHi, this is a draft for a change that introduces new loop detection\nfor stratum dependencies.\n\nI noticed the other day that if I create a cycle in the graph,\ne.g. by making openstack-clients depend on openstack-common and\nopenstack-common depend on openstack-clients\nthen morph gets stuck in a loop adding sources.\n\nThis change builds a representation of the graph up front and checks\nfor cycles. The code for the source resolver is pretty hairy and\nI ended up duplicating more than I\'d like, I\'ve been wondering if\nit might be better for us to move some of the initialisation,\nresolving refs and fetching/extracting definitions, into the source\nresolver\'s constructor perhaps?\n\nWe do already have some code for checking for mutually dependent strata,\nbut it\'s in the artifact resolver and artifact resolving happens \ntoo late in the process to prevent the bug this patch fixes.\n\nAlso, I haven\'t tried to produce a very useful error message, I thought it might be best to stop here and gather comments before continuing.\n\nAny suggestions on how to make this better would be greatly appreciated,\nthanks!',219,1,219,'3a4b7175_0414b6f3',NULL),(33,'2015-04-06 18:44:01','Uploaded patch set 1.',219,1,219,'3a4b7175_8468a688',NULL),(6,'2015-06-24 16:21:14','Abandoned\n\nRichard Maw has agreed to adopt this change and will resubmit as a separate patch (as changing the owner of an existing change in Gerrit is hard)',219,1,219,'fafc7978_52f874e5',NULL),(8,'2015-04-07 14:40:29','Patch Set 1: Code-Review+2',220,1,220,'1a486d77_03726ee5',NULL),(6,'2015-04-07 14:33:10','Patch Set 1: Code-Review+1\n\nSeems OK',220,1,220,'1a486d77_236d6a05',NULL),(7,'2015-04-07 13:47:19','Patch Set 1: Code-Review+1\n\nThis patch looks good to me.',220,1,220,'1a486d77_a3927af4',NULL),(8,'2015-04-07 14:40:32','Change has been successfully rebased as 14e164bbefcb18bb6ffdbfe217bd419e522b323d',220,1,220,'1a486d77_c37336e6',NULL),(8,'2015-04-07 14:40:31','Patch Set 2: Patch Set 1 was rebased',220,1,220,'1a486d77_e37632d8',NULL),(8,'2015-04-07 13:41:12','Uploaded patch set 1.',220,1,220,'1a486d77_e38872c8',NULL),(6,'2015-04-07 14:32:37','Patch Set 1: Code-Review+1\n\nIt\'s a shame to have to mirror these deprecated components! But there we are.',221,1,221,'1a486d77_436866f5',NULL),(7,'2015-04-07 15:08:17','Change has been successfully merged into the git repository.',221,1,221,'1a486d77_634a4285',NULL),(7,'2015-04-07 15:08:11','Patch Set 1: Code-Review+2\n\nLooks ok to me. Merging',221,1,221,'1a486d77_837d3eb4',NULL),(41,'2015-04-07 14:04:22','Uploaded patch set 1.',221,1,221,'1a486d77_a3a95a26',NULL),(33,'2015-04-07 15:21:02','Patch Set 1:\n\nI also don\'t know how to vote on this.\nSome people would rather this were in the README than on the wiki,\nand some vice versa I\'m sure. (+0)',222,1,222,'1a486d77_23444a73',NULL),(18,'2015-04-07 19:00:20','Patch Set 1: Code-Review+2',222,1,222,'1a486d77_2657b804',NULL),(7,'2015-04-07 15:11:41','Patch Set 1:\n\nThis change makes sense to me, but I don\'t feel confident enough to +1 it: +0.5',222,1,222,'1a486d77_434f4693',NULL),(6,'2015-04-07 14:30:13','Uploaded patch set 1.',222,1,222,'1a486d77_6363621b',NULL),(6,'2015-04-07 15:48:42','Patch Set 1:\n\nIt\'s been resoundingly ignored for years as part of Morph\'s README (hence it being totally out of date) so I don\'t think there\'s any reason to keep it there. Unless someone wants to commit to keeping it up to date from now on.\n\nFor the record, I\'d prefer it to be maintained in Git and published somewhere public for each release. But we don\'t have infrastructure for that at this point.',222,1,222,'1a486d77_c35a1650',NULL),(15,'2015-04-07 17:11:38','Patch Set 1: Code-Review-1\n\nId leave the current format of definitions here and make a link from that page to this file:in that way, we will keep everything up to date with minimal effort and also we will have everything in git',222,1,222,'1a486d77_e30bd229',NULL),(6,'2015-04-10 10:59:27','Patch Set 2: Patch Set 1 was rebased',222,1,222,'ba8cc1f7_405cee25',NULL),(6,'2015-04-10 10:59:27','Change has been successfully rebased as c9500e35fd3fcabd8013c6d9d7841508f25e4a16',222,1,222,'ba8cc1f7_e040a237',NULL),(8,'2015-04-07 15:34:21','Uploaded patch set 1.',223,1,223,'1a486d77_03494e8b',NULL),(6,'2015-04-07 15:49:58','Change has been successfully rebased as b909c3d656c8906e34c32b16d9b316f53e3170bd',223,1,223,'1a486d77_43362605',NULL),(6,'2015-04-07 15:49:58','Patch Set 2: Patch Set 1 was rebased',223,1,223,'1a486d77_6331220b',NULL),(6,'2015-04-07 15:49:53','Patch Set 1: Code-Review+2',223,1,223,'1a486d77_83541e22',NULL),(6,'2015-04-07 15:49:48','Patch Set 1: Code-Review+1\n\nWhy not.',223,1,223,'1a486d77_a3571a26',NULL),(34,'2015-04-07 15:39:19','Patch Set 1: Code-Review+1\n\nSeems fine to me. :)',223,1,223,'1a486d77_e35d124a',NULL),(8,'2015-04-07 16:19:48','Change has been successfully merged into the git repository.',224,1,224,'1a486d77_03170e53',NULL),(8,'2015-04-07 16:19:46','Patch Set 1: Code-Review+2',224,1,224,'1a486d77_23120a63',NULL),(7,'2015-04-07 16:19:05','Patch Set 1: Code-Review+1',224,1,224,'1a486d77_431d0673',NULL),(37,'2015-04-07 16:17:29','Patch Set 1: Code-Review+1\n\nLooks sensible to me',224,1,224,'1a486d77_63180285',NULL),(8,'2015-04-07 16:11:22','Uploaded patch set 1.',224,1,224,'1a486d77_832bfe93',NULL),(33,'2015-04-07 18:52:37','Patch Set 1: Code-Review+1',225,1,225,'1a486d77_462bd482',NULL),(33,'2015-04-07 18:55:59','Change has been successfully rebased as df2e5d3ae7c719060c982f20c469e2baa58eeea0',225,1,225,'1a486d77_664db072',NULL),(43,'2015-04-07 17:42:40','Uploaded patch set 1.',225,1,225,'1a486d77_8302de09',NULL),(8,'2015-04-07 18:36:59','Patch Set 1: Code-Review+1',225,1,225,'1a486d77_a61cc86b',NULL),(33,'2015-04-07 18:55:58','Patch Set 2: Patch Set 1 was rebased',225,1,225,'1a486d77_c636a4e7',NULL),(33,'2015-04-07 18:55:56','Patch Set 1: Code-Review+2',225,1,225,'1a486d77_e639a0d9',NULL),(33,'2015-04-07 18:55:30','Patch Set 1: Code-Review+2',226,1,226,'1a486d77_0625dcaa',NULL),(33,'2015-04-07 18:55:22','Patch Set 1: Code-Review+1',226,1,226,'1a486d77_2620d89a',NULL),(43,'2015-04-07 17:42:40','Uploaded patch set 1.',226,1,226,'1a486d77_66fff002',NULL),(33,'2015-04-07 18:55:59','Change has been successfully rebased as 4143e1ed4d264145d5528e119cd01913a3d725b4',226,1,226,'1a486d77_8630ace9',NULL),(33,'2015-04-07 18:55:59','Patch Set 2: Patch Set 1 was rebased',226,1,226,'1a486d77_a633a8f5',NULL),(8,'2015-04-07 18:35:37','Patch Set 1: Code-Review+1',226,1,226,'1a486d77_c60fc42d',NULL),(8,'2015-04-07 18:30:58','Uploaded patch set 1.',227,1,227,'1a486d77_060efc34',NULL),(42,'2015-04-07 19:03:31','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nI had input into the patch\'s writing, so you may choose to ignore my +1 on grounds of bias.',227,1,227,'1a486d77_065cbc24',NULL),(41,'2015-04-08 14:20:16','Patch Set 3: Code-Review+1\n\nThe code looks sensible, I understand the problem, and am happy with the solution proposed.',227,3,227,'fa82b9bf_02658ae0',NULL),(8,'2015-04-08 10:47:26','Patch Set 2: Commit message was updated',227,2,227,'fa82b9bf_2220ce9a',NULL),(37,'2015-04-08 11:38:56','Patch Set 3: Code-Review+1',227,3,227,'fa82b9bf_624d7672',NULL),(8,'2015-04-08 11:32:24','Uploaded patch set 3.',227,3,227,'fa82b9bf_a2337ef5',NULL),(37,'2015-04-08 14:21:33','Patch Set 3: Code-Review+2',227,3,227,'fa82b9bf_a2613ed5',NULL),(8,'2015-04-08 11:33:36','Patch Set 3:\n\nAdd Richard Maw comment as warning in the chunk',227,3,227,'fa82b9bf_c23002eb',NULL),(37,'2015-04-08 14:21:36','Change has been successfully merged into the git repository.',227,3,227,'fa82b9bf_c25ec212',NULL),(29,'2015-04-08 11:05:41','Patch Set 1:\n\n(1 comment)',227,1,227,'fa82b9bf_e23986d9',NULL),(8,'2015-04-08 16:01:11','Uploaded patch set 1.',228,1,228,'fa82b9bf_82a0baf5',NULL),(15,'2015-04-08 16:30:05','Patch Set 1: Code-Review+2',228,1,228,'fa82b9bf_a2b85e2b',NULL),(15,'2015-04-08 16:30:07','Change has been successfully merged into the git repository.',228,1,228,'fa82b9bf_c2b56232',NULL),(29,'2015-04-08 16:19:04','Patch Set 1: Code-Review+1',228,1,228,'fa82b9bf_e2ae66e7',NULL),(29,'2015-04-08 16:20:38','Patch Set 1: Code-Review+1',229,1,229,'fa82b9bf_02acaaec',NULL),(8,'2015-04-08 16:01:11','Uploaded patch set 1.',229,1,229,'fa82b9bf_22a52e04',NULL),(15,'2015-04-08 16:16:47','Patch Set 1: Code-Review+1',229,1,229,'fa82b9bf_42aab2d5',NULL),(15,'2015-04-08 16:30:54','Patch Set 1: Code-Review+2',229,1,229,'fa82b9bf_62825654',NULL),(15,'2015-04-08 16:30:56','Change has been successfully merged into the git repository.',229,1,229,'fa82b9bf_82875a61',NULL),(8,'2015-04-10 08:51:57','Abandoned\n\nIt was agreed, via IRC, to remove cloud-init support from the base-systems.',230,1,230,'ba8cc1f7_0010264d',NULL),(29,'2015-04-10 08:34:07','Patch Set 1:\n\n> > > > > Why do we need deployment of base systems to work out of\n > the\n > > > box\n > > > > > with openstack?\n > > > >\n > > > > Why would we want it to be broken? If it is, we should be\n > clear\n > > > > that they are not for use in OpenStack as-is.\n > > >\n > > > That doesn\'t answer my question though does it? :)\n > > >\n > > > Regardless we can solve this problem without bringing those\n > > > strata into the base system, just create a common stratum\n > > > for configobj and have cloud-init and openstack build-depend\n > > > on that.\n > > Richard, the second option that you described is what we are\n > doing\n > > in this patch. Regarding on the git log of the cloudinit-support.morph\n > > python-requests has been moved to python-core, python-prettytable,\n > > python-json-patch and python-json-pointer have been moved to\n > > python-common, as well as configobj - all of them are required by\n > > cloud-init and Openstack strata.\n > > So the common stratum you are describing in this comment are\n > > python-core and python-common.\n > > Given this I only can see 2 possibilities for unblock this patch:\n > > 1) Remove cloud-init support for all the base-systems, which\n > > regarding of the comments in this thread, despite you, people\n > want\n > > to keep.\n > > 2) Add cloud-init support to the rest of the base-systems.\n > \n > > > > > Why do we need deployment of base systems to work out of\n > the\n > > > box\n > > > > > with openstack?\n > > > >\n > > > > Why would we want it to be broken? If it is, we should be\n > clear\n > > > > that they are not for use in OpenStack as-is.\n > > >\n > > > That doesn\'t answer my question though does it? :)\n > > >\n > > > Regardless we can solve this problem without bringing those\n > > > strata into the base system, just create a common stratum\n > > > for configobj and have cloud-init and openstack build-depend\n > > > on that.\n > \n > Fix previous and unreadable comment\n > \n > Richard, the second option that you described is what we are doing\n > in this patch. Regarding on the git log of the cloudinit-support.morph\n > python-requests has been moved to python-core, python-prettytable,\n > python-json-patch and python-json-pointer have been moved to\n > python-common, as well as configobj - all of them are required by\n > cloud-init and Openstack strata.\n > So the common stratum you are describing in this comment are\n > python-core and python-common.\n > Given this I only can see 2 possibilities for unblock this patch:\n > 1) Remove cloud-init support for all the base-systems, which\n > regarding of the comments in this thread, despite you, people\n > want to keep.\n > 2) Add cloud-init support to the rest of the base-systems.\n\nright, i\'d prefer 1) because i don\'t think being able to deploy to openstack is a compelling reason to add this bloat to the base system.\n\nperhaps try appealing to others for their thoughts?',230,1,230,'ba8cc1f7_400e2e36',NULL),(8,'2015-04-10 07:27:42','Patch Set 1:\n\n> > > Why do we need deployment of base systems to work out of the\n > box\n > > > with openstack?\n > >\n > > Why would we want it to be broken? If it is, we should be clear\n > > that they are not for use in OpenStack as-is.\n > \n > That doesn\'t answer my question though does it? :)\n > \n > Regardless we can solve this problem without bringing those\n > strata into the base system, just create a common stratum\n > for configobj and have cloud-init and openstack build-depend\n > on that.\nRichard, the second option that you described is what we are doing in this patch. Regarding on the git log of the cloudinit-support.morph\npython-requests has been moved to python-core, python-prettytable, python-json-patch and python-json-pointer have been moved to python-common, as well as configobj - all of them are required by cloud-init and Openstack strata.\nSo the common stratum you are describing in this comment are python-core and python-common.\nGiven this I only can see 2 possibilities for unblock this patch:\n1) Remove cloud-init support for all the base-systems, which regarding of the comments in this thread, despite you, people want to keep.\n2) Add cloud-init support to the rest of the base-systems.',230,1,230,'ba8cc1f7_60ffb202',NULL),(8,'2015-04-10 08:10:29','Patch Set 1:\n\n> > > > Why do we need deployment of base systems to work out of the\n > > box\n > > > > with openstack?\n > > >\n > > > Why would we want it to be broken? If it is, we should be clear\n > > > that they are not for use in OpenStack as-is.\n > >\n > > That doesn\'t answer my question though does it? :)\n > >\n > > Regardless we can solve this problem without bringing those\n > > strata into the base system, just create a common stratum\n > > for configobj and have cloud-init and openstack build-depend\n > > on that.\n > Richard, the second option that you described is what we are doing\n > in this patch. Regarding on the git log of the cloudinit-support.morph\n > python-requests has been moved to python-core, python-prettytable,\n > python-json-patch and python-json-pointer have been moved to\n > python-common, as well as configobj - all of them are required by\n > cloud-init and Openstack strata.\n > So the common stratum you are describing in this comment are\n > python-core and python-common.\n > Given this I only can see 2 possibilities for unblock this patch:\n > 1) Remove cloud-init support for all the base-systems, which\n > regarding of the comments in this thread, despite you, people want\n > to keep.\n > 2) Add cloud-init support to the rest of the base-systems.\n\n > > > > Why do we need deployment of base systems to work out of the\n > > box\n > > > > with openstack?\n > > >\n > > > Why would we want it to be broken? If it is, we should be clear\n > > > that they are not for use in OpenStack as-is.\n > >\n > > That doesn\'t answer my question though does it? :)\n > >\n > > Regardless we can solve this problem without bringing those\n > > strata into the base system, just create a common stratum\n > > for configobj and have cloud-init and openstack build-depend\n > > on that.\n \nFix previous and unreadable comment\n\nRichard, the second option that you described is what we are doing\nin this patch. Regarding on the git log of the cloudinit-support.morph\npython-requests has been moved to python-core, python-prettytable,\npython-json-patch and python-json-pointer have been moved to\npython-common, as well as configobj - all of them are required by\ncloud-init and Openstack strata.\nSo the common stratum you are describing in this comment are\npython-core and python-common.\nGiven this I only can see 2 possibilities for unblock this patch:\n 1) Remove cloud-init support for all the base-systems, which\n regarding of the comments in this thread, despite you, people \n want to keep.\n 2) Add cloud-init support to the rest of the base-systems.',230,1,230,'ba8cc1f7_80043616',NULL),(29,'2015-04-09 10:25:47','Patch Set 1:\n\n> I\'m very much in favour of this, but please do add the strata to\n > *all* the base systems.\n > \n > I really hope that one day we can have a *single* base-system.morph\n > that can be built on all architectures.\n\nI wasn\'t expecting others to be in favour of making the base system larger, I don\'t have an opinion on that, but adding python-core and python-common to my mind means this is no longer a \"minimal set of strata\" as the system\'s description describes, so you\'d want to update the description as well.',230,1,230,'da87b5cf_01102a4d',NULL),(6,'2015-04-09 16:46:13','Patch Set 1:\n\n> Why do we need deployment of base systems to work out of the box\n > with openstack?\n\nWhy would we want it to be broken? If it is, we should be clear that they are not for use in OpenStack as-is.',230,1,230,'da87b5cf_2158cef9',NULL),(29,'2015-04-09 16:51:18','Patch Set 1:\n\n> > Why do we need deployment of base systems to work out of the box\n > > with openstack?\n > \n > Why would we want it to be broken? If it is, we should be clear\n > that they are not for use in OpenStack as-is.\n\nThat doesn\'t answer my question though does it? :)\n\nRegardless we can solve this problem without bringing those\nstrata into the base system, just create a common stratum\nfor configobj and have cloud-init and openstack build-depend\non that.',230,1,230,'da87b5cf_415dd2e8',NULL),(29,'2015-04-09 10:44:28','Patch Set 1:\n\n> \n > > Thinking about it, I\'d prefer we just drop cloud-init from our\n > base systems as Javier suggested yesterday.\n > \n > I\'m not sure about removing cloud-init, I think it\'s good to have\n > the base-system \'just work\' in OpenStack. It\'s annoying to\n > instantiate an image only to find that it\'s missing SSH keys, the\n > disk is the wrong size, and your configuration commands didn\'t get\n > run, because of the lack of cloud-init.\n\nWhy do we need deployment of base systems to work out of the box\nwith openstack?',230,1,230,'da87b5cf_6126d6bc',NULL),(6,'2015-04-09 09:10:44','Patch Set 1:\n\nI\'m very much in favour of this, but please do add the strata to *all* the base systems.\n\nI really hope that one day we can have a *single* base-system.morph that can be built on all architectures.',230,1,230,'da87b5cf_61ffb602',NULL),(29,'2015-04-09 10:28:52','Patch Set 1:\n\n> > I\'m very much in favour of this, but please do add the strata to\n > > *all* the base systems.\n > >\n > > I really hope that one day we can have a *single*\n > base-system.morph\n > > that can be built on all architectures.\n > \n > I wasn\'t expecting others to be in favour of making the base system\n > larger, I don\'t have an opinion on that, but adding python-core and\n > python-common to my mind means this is no longer a \"minimal set of\n > strata\" as the system\'s description describes, so you\'d want to\n > update the description as well.\n\nThinking about it, I\'d prefer we just drop cloud-init from our base systems as Javier suggested yesterday.',230,1,230,'da87b5cf_a11cde6b',NULL),(6,'2015-04-09 10:37:06','Patch Set 1:\n\n> I wasn\'t expecting others to be in favour of making the base system\n > larger, I don\'t have an opinion on that, but adding python-core and\n > python-common to my mind means this is no longer a \"minimal set of\n > strata\" as the system\'s description describes, so you\'d want to\n > update the description as well.\n\nSeems a good idea to change the description, to avoid confusion with the \'minimal-system\'.\n\n> Thinking about it, I\'d prefer we just drop cloud-init from our base systems as Javier suggested yesterday.\n\nI\'m not sure about removing cloud-init, I think it\'s good to have the base-system \'just work\' in OpenStack. It\'s annoying to instantiate an image only to find that it\'s missing SSH keys, the disk is the wrong size, and your configuration commands didn\'t get run, because of the lack of cloud-init.',230,1,230,'da87b5cf_c119e27a',NULL),(8,'2015-04-08 17:05:50','Uploaded patch set 1.',230,1,230,'fa82b9bf_02934aa4',NULL),(7,'2015-04-08 17:36:11','Patch Set 1: -Code-Review\n\n> This makes the base system inconsistent.\n >\n > x86 base systems will have python, the rest won\'t\n\nAFAICT python is in core.morph, so all the base systems already have python.',230,1,230,'fa82b9bf_62e9f619',NULL),(29,'2015-04-08 17:38:24','Patch Set 1:\n\n> > This makes the base system inconsistent.\n > >\n > > x86 base systems will have python, the rest won\'t\n > \n > AFAICT python is in core.morph, so all the base systems already\n > have python.\n\nAhh sorry I thought we\'d moved it, regardless it\'s still inconsistent\nto have these 2 strata in x86 systems only.',230,1,230,'fa82b9bf_82ee7a21',NULL),(7,'2015-04-08 17:07:12','Patch Set 1: Code-Review+1\n\nThis makes sense to me, since I think that cloud-init needs them at runtime.',230,1,230,'fa82b9bf_a28ffe74',NULL),(29,'2015-04-08 17:24:01','Patch Set 1: Code-Review-2\n\nThis makes the base system inconsistent.\n\nx86 base systems will have python, the rest won\'t',230,1,230,'fa82b9bf_c28c8282',NULL),(15,'2015-04-09 11:40:37','Patch Set 1: Code-Review+2',231,1,231,'da87b5cf_417392b1',NULL),(6,'2015-04-09 11:02:33','Uploaded patch set 1.',231,1,231,'da87b5cf_812bda81',NULL),(7,'2015-04-09 11:21:50','Patch Set 1: Code-Review+1\n\nThe behaviour change looks good.',231,1,231,'da87b5cf_8152fa11',NULL),(29,'2015-04-09 11:10:13','Patch Set 1: Code-Review+1',231,1,231,'da87b5cf_e13986d9',NULL),(15,'2015-04-09 11:40:39','Change has been successfully merged into the git repository.',231,1,231,'da87b5cf_e16746e9',NULL),(29,'2015-04-09 11:10:58','Patch Set 1: Code-Review+1',232,1,232,'da87b5cf_0137cae4',NULL),(15,'2015-04-09 11:40:49','Patch Set 1: Code-Review+2',232,1,232,'da87b5cf_01658ae0',NULL),(6,'2015-04-09 11:07:09','Uploaded patch set 1.',232,1,232,'da87b5cf_2120ce9a',NULL),(7,'2015-04-09 11:23:00','Patch Set 1: Code-Review+1\n\nMakes sense to me',232,1,232,'da87b5cf_21576e04',NULL),(15,'2015-04-09 11:40:52','Patch Set 2: Patch Set 1 was rebased',232,1,232,'da87b5cf_a1613ed5',NULL),(15,'2015-04-09 11:40:52','Change has been successfully rebased as 9ff939ae35944a4c4a2fa0af972ce22c702a3cab',232,1,232,'da87b5cf_c15ec212',NULL),(7,'2015-04-14 12:29:21','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLooks OK. There is only one thing I don\'t understand.',233,1,233,'3aa0d159_3c1471f4',NULL),(6,'2015-04-14 12:46:47','Patch Set 1:\n\n(1 comment)\n\ni\'ll send a 2nd version',233,1,233,'3aa0d159_3c2b1132',NULL),(6,'2015-04-14 12:53:14','Uploaded patch set 2.',233,2,233,'3aa0d159_5cd37d38',NULL),(6,'2015-04-21 10:47:56','Change has been successfully rebased as f323af122fcfbf31061a04309adc21fbcdae25fa',233,2,233,'7a7fa997_16587cf9',NULL),(8,'2015-04-21 10:35:03','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nI have some nitpicking comments, but you could not care of them if you feel that they are not highly important.',233,2,233,'7a7fa997_3646d824',NULL),(6,'2015-04-21 10:47:46','Patch Set 2: Code-Review+2\n\n(1 comment)\n\nThanks for reviewing, this has 2 +1s now!',233,2,233,'7a7fa997_565ef4ea',NULL),(6,'2015-04-21 10:47:56','Patch Set 3: Patch Set 2 was rebased',233,2,233,'7a7fa997_7663f0b1',NULL),(7,'2015-04-21 10:26:15','Patch Set 2: Code-Review+1\n\nYou are not! My +1 stills applies',233,2,233,'7a7fa997_b6bae808',NULL),(6,'2015-04-09 11:11:33','Uploaded patch set 1.',233,1,233,'da87b5cf_a1337ef5',NULL),(6,'2015-04-14 12:53:14','Uploaded patch set 2.',234,2,234,'3aa0d159_7cd8b953',NULL),(7,'2015-04-14 12:33:29','Patch Set 1: Code-Review+1\n\nNeat. Code looks OK. I haven\'t tested it though, but I trust your distbuild knowledge.',234,1,234,'3aa0d159_dcf8edc6',NULL),(6,'2015-04-21 11:36:31','Patch Set 3: Patch Set 2 was rebased',234,2,234,'7a7fa997_1682bc00',NULL),(6,'2015-04-21 10:48:16','Patch Set 2: Code-Review+2',234,2,234,'7a7fa997_365d78ea',NULL),(6,'2015-04-21 11:36:33','Patch Set 3: Code-Review+2',234,3,234,'7a7fa997_3687b811',NULL),(7,'2015-04-21 10:27:23','Patch Set 2: Code-Review+1',234,2,234,'7a7fa997_5637d4b0',NULL),(8,'2015-04-21 10:38:18','Patch Set 2: Code-Review+1',234,2,234,'7a7fa997_d64a0427',NULL),(6,'2015-04-21 10:48:40','Patch Set 2:\n\nThanks for reviewing these! CPUs worldwide will thank us for cancelling unneeded builds correctly :)',234,2,234,'7a7fa997_d671a478',NULL),(NULL,'2015-04-21 10:48:45','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Iaf785404, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',234,2,234,'7a7fa997_f66e2096',NULL),(6,'2015-04-21 11:38:49','Change has been successfully merged into the git repository.',234,3,234,'7a7fa997_f678602d',NULL),(6,'2015-04-09 11:11:33','Uploaded patch set 1.',234,1,234,'da87b5cf_c13002eb',NULL),(6,'2015-04-14 12:53:14','Uploaded patch set 2.',235,2,235,'3aa0d159_1cddf542',NULL),(7,'2015-04-22 08:22:42','Change has been successfully merged into the git repository.',235,3,235,'5a7ca5a3_1520749a',NULL),(7,'2015-04-22 08:22:39','Patch Set 3: Patch Set 2 was rebased',235,2,235,'5a7ca5a3_5526ecbb',NULL),(7,'2015-04-22 08:22:40','Patch Set 3: Code-Review+2',235,3,235,'5a7ca5a3_752be882',NULL),(7,'2015-04-21 11:14:51','Patch Set 2: Code-Review+1\n\nIndeed, this test doesn\'t work if I revert the fix. I now have an unkilled process around :)',235,2,235,'7a7fa997_16b4fcf0',NULL),(27,'2015-04-21 11:16:02','Patch Set 2: Code-Review+1\n\nLooks sound to me',235,2,235,'7a7fa997_b6c42860',NULL),(6,'2015-04-09 11:11:33','Uploaded patch set 1.',235,1,235,'da87b5cf_614d7672',NULL),(6,'2015-04-09 11:30:41','Patch Set 1:\n\n(1 comment)',235,1,235,'da87b5cf_81799a95',NULL),(37,'2015-04-09 16:28:27','Patch Set 2: Code-Review+2',236,2,236,'da87b5cf_01c10a80',NULL),(37,'2015-04-09 15:31:44','Uploaded patch set 1.',236,1,236,'da87b5cf_41aab2d5',NULL),(37,'2015-04-09 16:24:14','Patch Set 1:\n\n> Seems e1000e never got enabled in x86_64, so you have my +1 if you\n > change the commit message or prove me wrong :)\n\nIt was removed in 8b1bb90701f9a51f10ce8a990bcc1e237cb3b1c7, but that\'s ancient, so I\'m currently perplexed as to how it previously worked, so I\'ll amend the message.',236,1,236,'da87b5cf_41cf12b1',NULL),(15,'2015-04-09 15:54:32','Patch Set 1: Code-Review-1\n\nSeems e1000e never got enabled in x86_64, so you have my +1 if you change the commit message or prove me wrong :)',236,1,236,'da87b5cf_41f872e5',NULL),(37,'2015-04-09 16:28:32','Patch Set 3: Patch Set 2 was rebased',236,2,236,'da87b5cf_a1bdbe04',NULL),(8,'2015-04-09 15:38:30','Patch Set 1: Code-Review+1',236,1,236,'da87b5cf_c1b56232',NULL),(37,'2015-04-09 16:28:32','Change has been successfully rebased as afe4056e2683d55a9ef0bddaec6bad89139be0ee',236,2,236,'da87b5cf_c1ba420a',NULL),(37,'2015-04-09 16:27:59','Patch Set 2: Commit message was updated',236,2,236,'da87b5cf_e1c3c688',NULL),(7,'2015-04-09 15:42:56','Patch Set 1: Code-Review+1\n\n> You don\'t need libpcap.morph nor tcpdump.morph chunk files. Morph\n > detects autotools as a build-system.\n\nBut also some people is looking forward to remove the autodetection of the build system to speed up Morph. The patch is good to me as it is.',237,1,237,'da87b5cf_41815249',NULL),(8,'2015-04-09 15:40:52','Patch Set 1: Code-Review-1\n\nYou don\'t need libpcap.morph nor tcpdump.morph chunk files. Morph detects autotools as a build-system.',237,1,237,'da87b5cf_61825654',NULL),(8,'2015-04-09 15:51:31','Patch Set 1: Code-Review+2\n\nfair enough.',237,1,237,'da87b5cf_61e9f619',NULL),(8,'2015-04-09 15:51:43','Change has been successfully merged into the git repository.',237,1,237,'da87b5cf_81ee7a21',NULL),(28,'2015-04-09 15:46:46','Patch Set 1:\n\nI am aware that I don\'t need to set the build system, but in the Baserock meetup we decided that it would be a good idea to set the build system explicitly, instead of letting morph to guess it',237,1,237,'da87b5cf_c18c8282',NULL),(28,'2015-04-09 15:35:38','Uploaded patch set 1.',237,1,237,'da87b5cf_e1ae66e7',NULL),(28,'2015-04-09 15:35:38','Uploaded patch set 1.',238,1,238,'da87b5cf_01acaaec',NULL),(15,'2015-04-09 15:58:08','Patch Set 1: Code-Review-1\n\n(1 comment)',238,1,238,'da87b5cf_01da6a78',NULL),(7,'2015-04-09 16:32:15','Patch Set 3: Patch Set 2 was rebased',238,2,238,'da87b5cf_2141ae0b',NULL),(8,'2015-04-09 15:42:54','Patch Set 1:\n\n(1 comment)',238,1,238,'da87b5cf_217c4e72',NULL),(28,'2015-04-09 16:21:03','Patch Set 2:\n\n> My previous comments have not been addressed\n\nCan you explain to me exactly which point has not been addressed?',238,2,238,'da87b5cf_21ca0ea2',NULL),(28,'2015-04-09 15:54:01','Patch Set 1:\n\n> (1 comment)\n\n > (1 comment)\n\nThe patch was already submitted upstream by some folk (I found it in the parted mailing list). The owners of the project never provided feedback',238,1,238,'da87b5cf_21f3ee0b',NULL),(7,'2015-04-09 16:32:15','Change has been successfully rebased as df5dcd55aa0e0691dfb9cb8793a13298e6157474',238,2,238,'da87b5cf_41463225',NULL),(15,'2015-04-09 16:30:55','Patch Set 2: Code-Review+1\n\n> > My previous comments have not been addressed\n > \n > Can you explain to me exactly which point has not been addressed?\n\nSorry Tiago! Seems I\'m blind :)',238,2,238,'da87b5cf_6137b6b1',NULL),(15,'2015-04-09 16:13:54','Patch Set 2: Code-Review-1',238,2,238,'da87b5cf_61d01654',NULL),(7,'2015-04-09 16:32:09','Patch Set 2: Code-Review+2\n\nIt also looks good to me',238,2,238,'da87b5cf_813c3a95',NULL),(15,'2015-04-09 16:14:27','Patch Set 2:\n\nMy previous comments have not been addressed',238,2,238,'da87b5cf_81d51a45',NULL),(7,'2015-04-09 15:45:52','Patch Set 1:\n\n(1 comment)',238,1,238,'da87b5cf_a18ffe74',NULL),(28,'2015-04-09 16:07:38','Uploaded patch set 2.',238,2,238,'da87b5cf_a1e61e43',NULL),(7,'2015-04-09 16:42:11','Patch Set 1: Code-Review+1',239,1,239,'da87b5cf_01482a2c',NULL),(6,'2015-04-09 16:45:42','Patch Set 2: Patch Set 1 was rebased',239,1,239,'da87b5cf_615ed6eb',NULL),(6,'2015-04-09 16:45:42','Change has been successfully rebased as c433876ad2f8c85247a4ef6a8c53207980765037',239,1,239,'da87b5cf_8163dab0',NULL),(6,'2015-04-09 16:45:39','Patch Set 1: Code-Review+2',239,1,239,'da87b5cf_c151e2d9',NULL),(8,'2015-04-09 16:13:44','Uploaded patch set 1.',239,1,239,'da87b5cf_c1e32232',NULL),(37,'2015-04-09 16:35:20','Patch Set 1: Code-Review+1\n\nLooks reasonable to me.',239,1,239,'da87b5cf_e14ae626',NULL),(29,'2015-04-09 17:19:16','Change has been successfully merged into the git repository.',240,1,240,'da87b5cf_016fca93',NULL),(6,'2015-04-09 16:44:34','Uploaded patch set 1.',240,1,240,'da87b5cf_a154deca',NULL),(29,'2015-04-09 17:19:14','Patch Set 1: Code-Review+2',240,1,240,'da87b5cf_e1718678',NULL),(8,'2015-04-10 09:24:34','Change has been successfully merged into the git repository.',241,2,241,'ba8cc1f7_0037c6e4',NULL),(29,'2015-04-10 09:15:46','Patch Set 2: Code-Review+1\n\nThe difficulties we\'ve faced here are possibly an indication that\nmorph should support a concept of runtime dependencies.',241,2,241,'ba8cc1f7_2020ca9a',NULL),(37,'2015-04-10 09:16:09','Patch Set 2: Code-Review+1',241,2,241,'ba8cc1f7_4025cea9',NULL),(37,'2015-04-10 09:08:46','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nCommit message could do with a little improvement, but otherwise good.',241,1,241,'ba8cc1f7_6026d2bc',NULL),(8,'2015-04-10 09:09:57','Patch Set 2: Commit message was updated',241,2,241,'ba8cc1f7_802bd681',NULL),(8,'2015-04-10 09:06:23','Uploaded patch set 1.',241,1,241,'ba8cc1f7_a01cda6b',NULL),(8,'2015-04-10 09:24:32','Patch Set 2: Code-Review+2',241,2,241,'ba8cc1f7_e03982d9',NULL),(6,'2015-04-10 11:00:24','Patch Set 1: Code-Review+2\n\n(1 comment)\n\nmorph ./check still passes; I\'m fine with this being merged.',242,1,242,'ba8cc1f7_003ee6b8',NULL),(6,'2015-04-10 11:12:28','Patch Set 2: Patch Set 1 was rebased',242,1,242,'ba8cc1f7_206e8aca',NULL),(6,'2015-04-10 11:12:28','Change has been successfully rebased as f0263ff73fe3c539135683780e48e6153a193ef1',242,1,242,'ba8cc1f7_40738eb1',NULL),(24,'2015-04-10 10:27:36','Patch Set 1:\n\nThis patch had already been reviewed and approved, after Simon had revised twice it in the light of the feedback he received. However, it was never actually merged into the morph master branch.',242,1,242,'ba8cc1f7_8052f611',NULL),(24,'2015-04-10 10:24:55','Uploaded patch set 1.',242,1,242,'ba8cc1f7_c030feea',NULL),(29,'2015-04-10 12:40:03','Patch Set 2: Patch Set 1 was rebased',243,1,243,'ba8cc1f7_009346a4',NULL),(16,'2015-04-10 12:00:19','Patch Set 1: Code-Review+1',243,1,243,'ba8cc1f7_00aca6ec',NULL),(29,'2015-04-10 12:36:59','Patch Set 1: Code-Review+2',243,1,243,'ba8cc1f7_207c4a72',NULL),(NULL,'2015-04-10 12:37:02','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I9344b9b8, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',243,1,243,'ba8cc1f7_40814e49',NULL),(24,'2015-04-10 11:55:48','Uploaded patch set 1.',243,1,243,'ba8cc1f7_40aaaed5',NULL),(29,'2015-04-10 12:41:04','Patch Set 2: Code-Review+2',243,2,243,'ba8cc1f7_a08ffa74',NULL),(29,'2015-04-10 12:41:09','Change has been successfully merged into the git repository.',243,2,243,'ba8cc1f7_c08c7e82',NULL),(40,'2015-04-10 12:00:34','Patch Set 1: Code-Review+1\n\nLooks good. A simple obvious fix.',243,1,243,'ba8cc1f7_c0b55e32',NULL),(33,'2015-04-24 17:39:33','Patch Set 13: Code-Review-2\n\n(1 comment)',244,13,244,'1a76adc5_13264c69',NULL),(39,'2015-04-24 09:34:49','Uploaded patch set 12.',244,12,244,'1a76adc5_73046015',NULL),(39,'2015-04-24 15:31:34','Uploaded patch set 13.',244,13,244,'1a76adc5_f347101c',NULL),(6,'2015-04-15 16:48:34','Patch Set 4:\n\n(4 comments)\n\nThis is better, thanks! Still some comments though. I\'ve also not been able to try this out yet.',244,4,244,'1a9dcd25_7b9aff15',NULL),(33,'2015-04-23 11:15:56','Patch Set 11: Code-Review-1\n\n(1 comment)',244,11,244,'3a79b1b5_b4b50033',NULL),(39,'2015-04-14 15:51:55','Uploaded patch set 4.',244,4,244,'3aa0d159_7cbf59d1',NULL),(39,'2015-04-22 16:38:07','Uploaded patch set 11.',244,11,244,'5a7ca5a3_f5cdb85e',NULL),(39,'2015-04-13 15:10:19','Patch Set 2:\n\n(2 comments)\n\nHi Sam, thanks for the review! Hopefully most of the required changes should be addressed in the patch series I will send shortly.',244,2,244,'5a93c517_0010284d',NULL),(6,'2015-04-13 10:22:57','Patch Set 2:\n\n(10 comments)\n\nHello! Despite all my comments I think this is pretty good overall. I\'ve not had a chance to test it myself yet, will hopefully get to that later this week.',244,2,244,'5a93c517_1d6e53ca',NULL),(39,'2015-04-13 15:11:18','Uploaded patch set 3.',244,3,244,'5a93c517_802bd881',NULL),(39,'2015-04-21 18:27:40','Uploaded patch set 6.',244,6,244,'7a7fa997_169f1c05',NULL),(39,'2015-04-21 20:24:23','Uploaded patch set 10.',244,10,244,'7a7fa997_367258e6',NULL),(39,'2015-04-21 19:43:23','Uploaded patch set 8.',244,8,244,'7a7fa997_36bb3874',NULL),(39,'2015-04-21 19:20:38','Uploaded patch set 7.',244,7,244,'7a7fa997_b68f48cc',NULL),(39,'2015-04-21 20:17:56','Uploaded patch set 9.',244,9,244,'7a7fa997_b6a66852',NULL),(33,'2015-04-20 14:45:10','Patch Set 5: Code-Review-1\n\n(4 comments)\n\nThis needs a little more work before it can be merged.',244,5,244,'9a6a9dd7_17263469',NULL),(33,'2015-04-20 15:30:06','Patch Set 5:\n\n(1 comment)',244,5,244,'9a6a9dd7_57d34c38',NULL),(39,'2015-04-20 15:16:29','Patch Set 5:\n\n(3 comments)',244,5,244,'9a6a9dd7_9719e424',NULL),(39,'2015-04-10 15:17:32','Patch Set 1: Code-Review-1\n\n(2 comments)\n\nNoticed a few minor issues that either break ./check or are not within the code guidelines, will fix and push patch v2',244,1,244,'ba8cc1f7_00da6678',NULL),(39,'2015-04-10 15:01:56','Uploaded patch set 1.',244,1,244,'ba8cc1f7_20f3ea0b',NULL),(39,'2015-04-10 15:17:51','Uploaded patch set 2.',244,2,244,'ba8cc1f7_a0e61a43',NULL),(39,'2015-04-28 08:22:26','Uploaded patch set 14.',244,14,244,'bada0100_1009642c',NULL),(33,'2015-04-28 15:39:30','Patch Set 15: -Code-Review',244,15,244,'bada0100_1083a4cd',NULL),(33,'2015-04-29 16:11:06','Change has been successfully merged into the git repository.',244,16,244,'bada0100_1682bc00',NULL),(33,'2015-04-29 16:10:58','Patch Set 16: Patch Set 15 was rebased',244,15,244,'bada0100_56884422',NULL),(33,'2015-04-29 16:01:56','Patch Set 15: Code-Review+2',244,15,244,'bada0100_56ba84e2',NULL),(29,'2015-04-28 15:24:01','Uploaded patch set 15.',244,15,244,'bada0100_7030f056',NULL),(33,'2015-04-29 16:11:04','Patch Set 16: Code-Review+2',244,16,244,'bada0100_768d4831',NULL),(33,'2015-04-28 17:27:40','Patch Set 15: Code-Review-2\n\nCommand output is sometimes delayed for several seconds,\nsuggest we solve this problem before merging these changes.',244,15,244,'bada0100_902eb4a4',NULL),(33,'2015-04-28 16:17:58','Patch Set 15:\n\n(1 comment)',244,15,244,'bada0100_b08f38cc',NULL),(NULL,'2015-04-29 16:10:43','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 7 of I28e733cb, however the current patch set is 8.\n\nPlease rebase the change and upload a replacement commit.',244,15,244,'bada0100_b69bb071',NULL),(29,'2015-04-28 13:46:42','Patch Set 14:\n\n(1 comment)\n\nThis will be fixed on merge',244,14,244,'bada0100_d0a2fc99',NULL),(29,'2015-04-28 08:53:52','Patch Set 14: Code-Review-1\n\n(1 comment)\n\nThis seems essentially ready now, I will fix this nitpick, and then test and merge this.',244,14,244,'bada0100_f03620e7',NULL),(6,'2015-04-28 16:04:33','Patch Set 15: Code-Review+1\n\n(1 comment)\n\nI\'ve not tested yet, but at a glance it looks fine. Adding build-cancelled message was a good idea for sure.',244,15,244,'bada0100_f0d700be',NULL),(16,'2015-04-16 13:27:31','Patch Set 5: Code-Review-1\n\n(1 comment)\n\nThis seems like a good start, it mostly works and I like it.\n\nHowever, I managed to break it by doing `morph distbuild-start systems/devel-system-x86-64-generic.morph` and waiting for it to begin, then doing the same thing. The second time I didn\'t get disconnected from the controller:\n\n 2015-04-16 13:20:09 Starting distributed build\n 2015-04-16 13:20:09 Connecting to localhost:54819\n 2015-04-16 13:20:09 Requesting build of baserock:baserock/definitions ba804d367743d9bfee7380707c80d00b9dafc303 systems/devel-system-x86_64-generic.morph\n 2015-04-16 13:20:09 Progress: Computing build graph\n 2015-04-16 13:20:34 Progress: Finished computing build graph\n 2015-04-16 13:20:37 Progress: Need to build 1418 artifacts, of 1418 total\n 2015-04-16 13:20:37 stage1-binutils is already building on localhost:44308\n 2015-04-16 13:20:37 Progress: Ready to build stage2-fhs-dirs-misc: waiting for a worker to become available\n 2015-04-16 13:20:37 Progress: Ready to build stage2-fake-bash-misc: waiting for a worker to become available\n\nI then sent ^C to get out of the hang, and did morph distbuild-list-jobs to see what was running. This showed both the builds I started were running:\n\n 2015-04-16 13:23:03 Connecting to localhost:54819\n 2015-04-16 13:23:03 Requesting currently running distbuilds.\n 2015-04-16 13:23:03 2 distbuild requests(s) currently in progress\n\n Build request ID: InitiatorConnection-2\n Initiator: 127.0.0.1:45722\n Repo: baserock:baserock/definitions\n Ref: ba804d367743d9bfee7380707c80d00b9dafc303\n Component: systems/devel-system-x86_64-generic.morph\n\n Build request ID: InitiatorConnection-3\n Initiator: 127.0.0.1:45724\n Repo: baserock:baserock/definitions\n Ref: ba804d367743d9bfee7380707c80d00b9dafc303\n Component: systems/devel-system-x86_64-generic.morph',244,5,244,'fa6b99d7_1addfd42',NULL),(39,'2015-04-16 08:39:29','Uploaded patch set 5.',244,5,244,'fa6b99d7_7a52f914',NULL),(8,'2015-04-13 11:47:07','Change has been successfully merged into the git repository.',245,1,245,'5a93c517_5dd37b38',NULL),(8,'2015-04-13 11:47:06','Patch Set 1: Code-Review+2',245,1,245,'5a93c517_bd163ff0',NULL),(7,'2015-04-13 11:23:40','Patch Set 1: Code-Review+1',245,1,245,'5a93c517_dd71cb78',NULL),(6,'2015-04-10 16:55:47','Uploaded patch set 1.',245,1,245,'ba8cc1f7_c0e31e32',NULL),(7,'2015-04-13 11:23:32','Patch Set 2: Code-Review+1',246,2,246,'5a93c517_1d5893f9',NULL),(8,'2015-04-13 13:25:16','Patch Set 2: Code-Review+2',246,2,246,'5a93c517_3d030f75',NULL),(8,'2015-04-13 13:25:19','Change has been successfully merged into the git repository.',246,2,246,'5a93c517_ddf78b8b',NULL),(6,'2015-04-10 16:58:22','Uploaded patch set 2.',246,2,246,'ba8cc1f7_20ca0aa2',NULL),(6,'2015-04-10 16:56:34','Uploaded patch set 1.',246,1,246,'ba8cc1f7_60d01254',NULL),(6,'2015-04-13 12:04:53','Patch Set 2: Code-Review+2\n\ngood points, but this patch is just moving stuff around :) fran has said in person that it\'s OK to merge this.',247,2,247,'5a93c517_1dabb38a',NULL),(7,'2015-04-13 11:23:36','Patch Set 2: Code-Review+1',247,2,247,'5a93c517_3d5d4fea',NULL),(6,'2015-04-13 12:04:59','Change has been successfully merged into the git repository.',247,2,247,'5a93c517_3db0eff3',NULL),(8,'2015-04-13 12:01:37','Patch Set 2:\n\n(10 comments)\n\nJust some nitpicking comments, if you don\'t want to rework it I can give you the +1 - I vote +0 at the moment',247,2,247,'5a93c517_bdc4ff5f',NULL),(6,'2015-04-10 16:58:22','Uploaded patch set 2.',247,2,247,'ba8cc1f7_40cf0eb1',NULL),(6,'2015-04-10 16:56:57','Uploaded patch set 1.',247,1,247,'ba8cc1f7_80d51645',NULL),(6,'2015-06-12 12:06:56','Patch Set 2:\n\n> What was the result of testing?\n\nI\'m still waiting to do this! every Friday I think \"this week I\'ll test restoring from backups\", but then other work gets in the way...',248,2,248,'3a4c51b2_3cddb115',NULL),(37,'2015-06-12 11:55:31','Patch Set 2:\n\nWhat was the result of testing?',248,2,248,'3a4c51b2_bcc9c15c',NULL),(8,'2015-04-13 13:27:29','Patch Set 2: Code-Review+1',248,2,248,'5a93c517_7d30b756',NULL),(7,'2015-04-13 11:23:28','Patch Set 2: Code-Review+1\n\nThis series looks OK to me',248,2,248,'5a93c517_7d63d7b1',NULL),(6,'2015-04-13 13:31:26','Patch Set 2: Code-Review+2',248,2,248,'5a93c517_9d4823ce',NULL),(6,'2015-04-13 13:31:46','Patch Set 2: -Code-Review\n\nactually, I\'ll wait til it\'s tested!',248,2,248,'5a93c517_bd45dfb4',NULL),(6,'2015-06-19 15:12:35','Uploaded patch set 3.',248,3,248,'7a6b29fe_1687fc62',NULL),(6,'2015-06-19 15:14:07','Patch Set 3:\n\nI\'ve now tested on a private OpenStack instance, by following the instructions in the README.mdwn and copying in data from a backup of the /var/lib/mysql directory from baserock.org instance.\n\nThe \'mysql\' commandline client can see the data and it looks like everything is there that should be.',248,3,248,'7a6b29fe_767c7073',NULL),(6,'2015-04-10 17:00:25','Patch Set 1:\n\nNote I\'ve not managed to actually test this yet, due to hitting a problem in our internal OpenStack cloud...',248,1,248,'ba8cc1f7_00c10680',NULL),(6,'2015-04-10 17:02:05','Uploaded patch set 2.',248,2,248,'ba8cc1f7_a0bdba04',NULL),(6,'2015-04-10 16:58:22','Uploaded patch set 1.',248,1,248,'ba8cc1f7_e0c3c288',NULL),(7,'2015-06-24 11:12:30','Patch Set 3: Code-Review+2',248,3,248,'fafc7978_12526c13',NULL),(6,'2015-07-03 09:08:07','Uploaded patch set 4.',248,4,248,'fafc7978_12a6ecc1',NULL),(6,'2015-07-03 09:08:18','Change has been successfully merged into the git repository.',248,4,248,'fafc7978_52b074f4',NULL),(6,'2015-07-03 09:08:15','Patch Set 4: Code-Review+2',248,4,248,'fafc7978_72abf889',NULL),(29,'2015-04-15 09:14:25','Patch Set 1:\n\n(6 comments)\n\nThank you for this review and sorry for my delayed response.\n\nMany of the concerns in this review surround naming,\nI am not interested in debating the names or changing them\nat this point, it is not worth the effort and provides no\nbenefit.\n\nOther comments surround the configurability of the username\nand the auth_uri. I have no interest in making the usernames\nconfigurable from the cluster, we do not provide this for\nother services in baserock: morph-cache-server, ntpd, lighttpd\netc and doing this here yields no tangible benefit.\n\nAs for the auth_uri and other uris, we made an assumption\nvery early on that the swift proxy-server will be running\non the controller node as per the example architecture[1],\nso I have no interest in supporting configuration of this.\n\nThank you for pointing out the mistake in one of the service\nunits, I will correct this in a following patch set :)\n\n[1]: http://docs.openstack.org/juno/install-guide/install/apt/content/ch_overview.html#example-architecture-with-neutron-networking-hw',249,1,249,'1a9dcd25_3b2557ab',NULL),(29,'2015-04-15 19:23:08','Patch Set 1:\n\n(1 comment)',249,1,249,'1a9dcd25_5efff101',NULL),(29,'2015-04-15 19:22:01','Patch Set 1:\n\n(1 comment)',249,1,249,'1a9dcd25_9b058b16',NULL),(29,'2015-04-15 19:17:44','Patch Set 1:\n\n(1 comment)',249,1,249,'1a9dcd25_db0b132a',NULL),(29,'2015-04-15 21:35:21','Uploaded patch set 2.',249,2,249,'1a9dcd25_fe0fdd2c',NULL),(8,'2015-04-13 11:44:12','Patch Set 1:\n\n(18 comments)\n\nI would like that Pedro or Richard have a look at it too.\nThe patch-series is fine by me, just some comments of consistency names in variables and replacements - just matter of having the same template and variable names as the rest of the components.',249,1,249,'5a93c517_1d265369',NULL),(37,'2015-04-13 13:43:33','Patch Set 1: Code-Review+1\n\n(5 comments)\n\nLooks reasonable to me, I\'d only ask that you use the dict-arguments form when using modules, since I obsess over whitespace.',249,1,249,'5a93c517_1d83b3cd',NULL),(7,'2015-04-13 13:47:29','Patch Set 1:\n\nEverything looks OK. I am missing consistency, but I don\'t think we have to worry about that now.',249,1,249,'5a93c517_ddda2be9',NULL),(7,'2015-04-13 13:37:20','Patch Set 1:\n\n(5 comments)\n\nI\'ve just reviewed the comments, I\'ll review other bits soon.',249,1,249,'5a93c517_fd228700',NULL),(29,'2015-04-10 21:31:10','Patch Set 1:\n\n(1 comment)',249,1,249,'ba8cc1f7_a054daca',NULL),(29,'2015-04-10 21:28:21','Uploaded patch set 1.',249,1,249,'ba8cc1f7_e04ae226',NULL),(29,'2015-04-16 10:19:46','Patch Set 2: Code-Review+2\n\nThis has a +1 from Richard Maw in patch set 1 that applies to this set,\nand Pedro has given this a +1 on IRC',249,2,249,'fa6b99d7_3a46c124',NULL),(29,'2015-04-16 17:04:13','Abandoned\n\nThis change depends on changes that have\nnow been merged to master, this change\nwill be resubmitted targeting master',249,2,249,'fa6b99d7_7a7e79e6',NULL),(29,'2015-04-12 11:42:29','Patch Set 1:\n\n(1 comment)',250,1,250,'7a96c907_1e096d2c',NULL),(29,'2015-04-12 11:44:23','Patch Set 2: Patch Set 1 was rebased',250,1,250,'7a96c907_3e0ea935',NULL),(29,'2015-04-12 11:38:40','Patch Set 1: Code-Review+2',250,1,250,'7a96c907_5efff501',NULL),(29,'2015-04-12 11:44:23','Change has been successfully rebased as 779eb58df6626316c3a448b358b2843ebc4700a2',250,1,250,'7a96c907_de122558',NULL),(18,'2015-04-11 08:19:39','Uploaded patch set 1.',250,1,250,'9a91bd0f_5fffeb01',NULL),(16,'2015-04-11 18:07:40','Patch Set 1: Code-Review+1',250,1,250,'9a91bd0f_df40db37',NULL),(6,'2015-04-13 09:56:14','Patch Set 1:\n\n(1 comment)\n\nthanks for picking up these patches! I\'m in favour of this, i\'m just a bit confused about the stuff moving between x-common.morph and x-wayland.morph, I can\'t tell by looking if it\'s needed or not.',251,1,251,'5a93c517_1d20939a',NULL),(6,'2015-04-20 11:09:45','Patch Set 1:\n\n(1 comment)',251,1,251,'9a6a9dd7_b75188da',NULL),(31,'2015-04-20 11:00:04','Patch Set 1:\n\n(1 comment)',251,1,251,'9a6a9dd7_d74afc26',NULL),(16,'2015-04-11 18:05:37','Uploaded patch set 1.',251,1,251,'9a91bd0f_bf3077e9',NULL),(33,'2015-04-19 15:26:13','Patch Set 1: Code-Review-1\n\n> (1 comment)\n > \n > thanks for picking up these patches! I\'m in favour of this, i\'m\n > just a bit confused about the stuff moving between x-common.morph\n > and x-wayland.morph, I can\'t tell by looking if it\'s needed or not.\n\nRenaming this seems reasonable to me, but as Sam notes there\'s a\nseemingly unrelated change here, can we separate that out?',251,1,251,'ba65a107_f83611e7',NULL),(16,'2015-09-06 18:26:29','Abandoned',251,1,251,'fafc7978_4ce9f319',NULL),(33,'2015-07-01 10:39:42','Removed the following approvals:\n\n* Code-Review-1 by straycat \n',251,1,251,'fafc7978_b24a8025',NULL),(15,'2015-04-12 14:20:04','Patch Set 1: Code-Review-1\n\n(8 comments)',252,1,252,'7a96c907_5e74d59b',NULL),(31,'2015-04-20 11:00:16','Patch Set 1:\n\n(1 comment)',252,1,252,'9a6a9dd7_f747001c',NULL),(16,'2015-04-11 18:05:37','Uploaded patch set 1.',252,1,252,'9a91bd0f_5f4dab71',NULL),(33,'2015-04-19 15:28:45','Patch Set 1:\n\n(1 comment)',252,1,252,'ba65a107_b83099e9',NULL),(16,'2015-09-06 18:26:38','Abandoned',252,1,252,'fafc7978_2cee2f23',NULL),(15,'2015-04-12 14:22:00','Patch Set 1: Code-Review-1\n\n(1 comment)',253,1,253,'7a96c907_3e7309b3',NULL),(16,'2015-04-11 18:05:37','Uploaded patch set 1.',253,1,253,'9a91bd0f_7f52ef14',NULL),(33,'2015-04-19 15:31:23','Patch Set 1:\n\n(1 comment)',253,1,253,'ba65a107_78520115',NULL),(16,'2015-08-10 10:23:47','Patch Set 1:\n\n> Hi, do you plan to further work on this patch? If not, can you\n > abandon it please?\n\nI\'ll try to send a new version of this and the related changes sometime this week/this weekend.',253,1,253,'fafc7978_1b8d6732',NULL),(15,'2015-08-24 11:15:17','Uploaded patch set 2.',253,2,253,'fafc7978_4604327e',NULL),(15,'2015-08-25 08:12:53','Change has been successfully merged into the git repository.',253,2,253,'fafc7978_61b960e9',NULL),(8,'2015-08-25 07:49:16','Patch Set 2: Code-Review+1',253,2,253,'fafc7978_81260467',NULL),(15,'2015-08-25 08:12:51','Patch Set 2: Code-Review+2',253,2,253,'fafc7978_81b444f3',NULL),(6,'2015-08-24 14:01:24','Patch Set 2: Code-Review+1\n\nNice, looks fine at a glance. I\'ve not tried to build or run this yet though.',253,2,253,'fafc7978_e673a613',NULL),(28,'2015-08-10 10:06:02','Patch Set 1:\n\nHi, do you plan to further work on this patch? If not, can you abandon it please?',253,1,253,'fafc7978_fb9ea362',NULL),(NULL,'2015-04-13 09:42:09','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Ib91cd3d22e466bd55cf62cb55e93f67f9079e4b9\n* I3ad56807a4b3e7c45f9c48272d8450ace7b716e7\n* I530cd09eeb95de555916876a8c48377287d2eb48\n',254,1,254,'5a93c517_5d261bbc',NULL),(NULL,'2015-04-13 21:30:56','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Ib91cd3d22e466bd55cf62cb55e93f67f9079e4b9\n* I3ad56807a4b3e7c45f9c48272d8450ace7b716e7\n* I530cd09eeb95de555916876a8c48377287d2eb48\n',254,1,254,'5a93c517_a3e61e43',NULL),(6,'2015-04-13 09:27:07','Patch Set 1: Code-Review+2',254,1,254,'5a93c517_fd0fe72c',NULL),(15,'2015-04-12 13:11:56','Patch Set 1: Code-Review+2',254,1,254,'7a96c907_de39c5d9',NULL),(15,'2015-04-12 13:12:02','Patch Set 1: Code-Review+1',254,1,254,'7a96c907_fe3601e7',NULL),(16,'2015-04-11 18:05:37','Uploaded patch set 1.',254,1,254,'9a91bd0f_1f572304',NULL),(15,'2015-04-28 14:44:59','Patch Set 2: Code-Review+2',254,2,254,'bada0100_5004cc7d',NULL),(15,'2015-04-28 14:45:01','Change has been successfully merged into the git repository.',254,2,254,'bada0100_7009d094',NULL),(15,'2015-04-28 14:44:49','Uploaded patch set 2.',254,2,254,'bada0100_b0d738ed',NULL),(15,'2015-04-12 14:24:16','Patch Set 1: Code-Review-1\n\n(1 comment)',255,1,255,'7a96c907_fe64c1e6',NULL),(16,'2015-04-11 18:05:37','Uploaded patch set 1.',255,1,255,'9a91bd0f_3f5c6725',NULL),(37,'2015-05-13 13:41:11','Patch Set 1: Code-Review+1\n\nIt\'s definitley worth adding simple-network configuration IMO.',255,1,255,'bada0100_f73e0f29',NULL),(15,'2015-08-24 11:15:17','Uploaded patch set 2.',255,2,255,'fafc7978_26092e96',NULL),(6,'2015-08-24 14:03:12','Patch Set 2: Code-Review+1',255,2,255,'fafc7978_4660b235',NULL),(8,'2015-08-25 07:49:49','Patch Set 2: Code-Review+1',255,2,255,'fafc7978_612b2031',NULL),(15,'2015-08-25 08:13:49','Change has been successfully merged into the git repository.',255,2,255,'fafc7978_a1ca286c',NULL),(15,'2015-08-25 08:13:47','Patch Set 2: Code-Review+2',255,2,255,'fafc7978_c1cdac88',NULL),(29,'2015-04-11 18:56:59','Patch Set 1: Code-Review+2',256,1,256,'9a91bd0f_5f74cb9b',NULL),(29,'2015-04-11 18:57:02','Change has been successfully merged into the git repository.',256,1,256,'9a91bd0f_7f798f92',NULL),(37,'2015-04-11 18:52:49','Patch Set 1: Code-Review+1\n\nThis is fully backwards compatible, and may cut down redundant configuration in cases where we do not do first-boot configuration.',256,1,256,'9a91bd0f_9f4a5354',NULL),(16,'2015-04-11 18:54:56','Patch Set 1: Code-Review+1\n\nLooks fine to me.',256,1,256,'9a91bd0f_bf47174b',NULL),(29,'2015-04-11 18:48:42','Uploaded patch set 1.',256,1,256,'9a91bd0f_ff3d9fbc',NULL),(16,'2015-04-15 20:45:39','Patch Set 1:\n\n(1 comment)',260,1,260,'1a9dcd25_1e09692c',NULL),(16,'2015-04-15 20:55:47','Uploaded patch set 2.',260,2,260,'1a9dcd25_3e0ea535',NULL),(29,'2015-04-12 13:09:10','Patch Set 1:\n\n(1 comment)',260,1,260,'7a96c907_3e2549ab',NULL),(29,'2015-04-12 15:05:28','Patch Set 1:\n\n(1 comment)',260,1,260,'7a96c907_3eaa29d5',NULL),(29,'2015-04-12 13:07:45','Patch Set 1:\n\n(2 comments)\n\nJust a couple of thoughts from a brief glance,\nhaven\'t had time to look more at the code yet, sorry :/',260,1,260,'7a96c907_7e2bd182',NULL),(29,'2015-04-12 14:25:58','Patch Set 1: Code-Review-1\n\n(4 comments)\n\nGot a bit more time waiting for deploys,\nand spotted a couple of potential issues.',260,1,260,'7a96c907_9e61fdd5',NULL),(29,'2015-04-12 13:55:17','Patch Set 1:\n\n(1 comment)',260,1,260,'7a96c907_be3079e9',NULL),(16,'2015-04-12 15:21:26','Patch Set 1:\n\n(3 comments)',260,1,260,'7a96c907_beb5d932',NULL),(16,'2015-04-12 11:46:02','Uploaded patch set 1.',260,1,260,'7a96c907_fe0fe12c',NULL),(29,'2015-04-27 15:20:02','Uploaded patch set 3.',260,3,260,'dad5f5cf_115acc83',NULL),(41,'2015-04-27 15:41:14','Patch Set 4: Code-Review+1\n\nThis looks fine to me, now.',260,4,260,'dad5f5cf_31ed908c',NULL),(41,'2015-04-27 15:25:57','Patch Set 3: Code-Review-1\n\n(1 comment)\n\nI\'d intended to make my comment about this a while ago, but I\'m still figuring out gerrit\'s interface.\nAs-is, it doesn\'t handle git-fat properly.',260,3,260,'dad5f5cf_51c7f412',NULL),(29,'2015-04-27 15:40:14','Patch Set 4: Code-Review+1',260,4,260,'dad5f5cf_71f31874',NULL),(29,'2015-04-27 15:42:41','Change has been successfully rebased as cc7be86c788a5337ebce16365b9b51341b7cddc2',260,4,260,'dad5f5cf_91fb1c47',NULL),(6,'2015-04-27 11:39:58','Patch Set 2: Code-Review+1\n\nYes! This works as expected and I like it a lot!\n\nIt can take 5 or more seconds to get through the \'Loading all morphologies\' stage with a cold cache, that\'s not ideal, but I can\'t think of an easy fix.',260,2,260,'dad5f5cf_b11660f0',NULL),(29,'2015-04-27 14:59:44','Patch Set 2: Code-Review-1\n\nThis looks good, but the PATH needs to be absolute and I think you should accept a relative path, I will fix this on merge.',260,2,260,'dad5f5cf_b11c20c3',NULL),(29,'2015-04-27 15:38:23','Uploaded patch set 4.',260,4,260,'dad5f5cf_b1e1809c',NULL),(29,'2015-04-27 15:42:36','Patch Set 4: Code-Review+2',260,4,260,'dad5f5cf_d101a43a',NULL),(16,'2015-04-27 15:30:05','Patch Set 3:\n\n(1 comment)',260,3,260,'dad5f5cf_d1da04e9',NULL),(41,'2015-04-27 15:15:24','Patch Set 2: Code-Review-1\n\n(1 comment)',260,2,260,'dad5f5cf_f1694826',NULL),(29,'2015-04-27 15:30:08','Patch Set 3:\n\n(1 comment)',260,3,260,'dad5f5cf_f1d708be',NULL),(29,'2015-04-27 15:42:40','Patch Set 5: Patch Set 4 was rebased',260,4,260,'dad5f5cf_f1fe2838',NULL),(15,'2015-04-16 16:40:34','Patch Set 1:\n\n(1 comment)\n\nDidn\'t have time to test this yet, sorry; only wanted to add a note about --with-submodules',260,1,260,'fa6b99d7_1a0c1d94',NULL),(16,'2015-04-15 20:55:47','Uploaded patch set 2.',261,2,261,'1a9dcd25_de122158',NULL),(27,'2015-04-21 13:46:21','Patch Set 2: Code-Review+1\n\nlooks good to me',261,2,261,'7a7fa997_5604b47d',NULL),(16,'2015-04-12 11:46:02','Uploaded patch set 1.',261,1,261,'7a96c907_9e1c9d6c',NULL),(16,'2015-04-27 15:44:39','Patch Set 3: Code-Review+2',261,3,261,'dad5f5cf_119f2c05',NULL),(16,'2015-04-27 15:44:42','Change has been successfully merged into the git repository.',261,3,261,'dad5f5cf_31a4b056',NULL),(NULL,'2015-04-27 15:44:08','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I0c175649, however the current patch set is 5.\n\nPlease rebase the change and upload a replacement commit.',261,2,261,'dad5f5cf_5195b4e2',NULL),(16,'2015-04-27 15:44:25','Patch Set 3: Patch Set 2 was rebased',261,2,261,'dad5f5cf_719a3816',NULL),(6,'2015-04-27 11:45:44','Patch Set 2: Code-Review+2',261,2,261,'dad5f5cf_91f0fcca',NULL),(15,'2015-04-13 17:41:50','Uploaded patch set 2.',262,2,262,'5a93c517_20352446',NULL),(8,'2015-04-13 17:57:43','Change has been successfully rebased as fe2761b10c06ac2e213fa339560100a6158c2bc5',262,2,262,'5a93c517_2083e4cd',NULL),(8,'2015-04-13 17:57:36','Patch Set 2: Code-Review+1',262,2,262,'5a93c517_6079ecfb',NULL),(6,'2015-04-13 09:21:34','Patch Set 1: Code-Review+1\n\nThis just adds the patch on top of the 1.8.16 release: http://git.baserock.org/cgi-bin/cgit.cgi/delta/dbus.git/log/?h=baserock/genivi/J-1.0',262,1,262,'5a93c517_7d043715',NULL),(8,'2015-04-13 17:57:43','Patch Set 3: Patch Set 2 was rebased',262,2,262,'5a93c517_807e78e3',NULL),(7,'2015-04-13 11:18:40','Patch Set 1: Code-Review-1\n\n> Change the branch name to something like \"dbus-1.8.16_genivi_J-1.0\"\n > and you have my +1\n\nI agree, with that name we are missing some information when reading then unpetrify-ref (given that the ref is not human readable)',262,1,262,'5a93c517_9d54a3cb',NULL),(18,'2015-04-13 17:48:36','Patch Set 2: Code-Review+1',262,2,262,'5a93c517_a04854cd',NULL),(18,'2015-04-13 17:49:06','Patch Set 2: Code-Review+2\n\n> Patch Set 2: Code-Review+1\n\nThanks, Javier!!',262,2,262,'5a93c517_c04560b4',NULL),(15,'2015-04-13 10:26:31','Patch Set 1: Code-Review-1\n\nChange the branch name to something like \"dbus-1.8.16_genivi_J-1.0\" and you have my +1',262,1,262,'5a93c517_fd64c7e6',NULL),(18,'2015-04-12 20:33:46','Patch Set 1:\n\n> Uploaded patch set 1.\n\ngenivi systems don\'t build without this...',262,1,262,'7a96c907_1e7c0d72',NULL),(18,'2015-04-12 19:31:59','Uploaded patch set 1.',262,1,262,'7a96c907_7e875162',NULL),(16,'2015-04-13 13:45:44','Patch Set 2: Code-Review+1',263,2,263,'5a93c517_3d88efe6',NULL),(15,'2015-04-13 10:39:10','Uploaded patch set 1.',263,1,263,'5a93c517_5d9b7bc9',NULL),(18,'2015-04-13 13:47:24','Patch Set 3: Patch Set 2 was rebased',263,2,263,'5a93c517_5dc7fb12',NULL),(15,'2015-04-13 10:41:42','Patch Set 2:\n\nTested building a running a base-x86-[64|32]-generic system',263,2,263,'5a93c517_7d875762',NULL),(18,'2015-04-13 13:47:24','Change has been successfully rebased as 3eacd36e46d9904e0775c079253c4ed78ef50a96',263,2,263,'5a93c517_7dcc3736',NULL),(18,'2015-04-13 13:47:22','Patch Set 2: Code-Review+2',263,2,263,'5a93c517_bd4abfaa',NULL),(15,'2015-04-13 10:39:30','Uploaded patch set 2.',263,2,263,'5a93c517_ddaeabe7',NULL),(15,'2015-04-13 10:39:10','Uploaded patch set 1.',264,1,264,'5a93c517_7da0b7f4',NULL),(15,'2015-04-13 10:40:31','Abandoned\n\nThis was pushed by mistake',264,1,264,'5a93c517_bdb5df32',NULL),(7,'2015-04-23 14:42:46','Patch Set 4: Code-Review+1\n\n> I\'ll be testing ppc64\n\nppc64 works with this patch.',265,4,265,'3a79b1b5_f4c0587e',NULL),(15,'2015-04-14 12:37:35','Uploaded patch set 3.',265,3,265,'3aa0d159_9c0265b3',NULL),(15,'2015-04-13 10:39:10','Uploaded patch set 1.',265,1,265,'5a93c517_1da5f303',NULL),(18,'2015-04-13 13:49:40','Patch Set 2: Code-Review+1\n\n> Uploaded patch set 1.',265,2,265,'5a93c517_5dee1b8d',NULL),(18,'2015-04-13 13:49:57','Patch Set 2:\n\n> Uploaded patch set 2.',265,2,265,'5a93c517_7df3d773',NULL),(16,'2015-04-13 13:46:05','Patch Set 2:\n\nHave any of these been tested?',265,2,265,'5a93c517_bd739f14',NULL),(15,'2015-04-13 14:05:08','Patch Set 2:\n\n> Have any of these been tested?\n\nNo, none of them (I do not have the hardware to do it)',265,2,265,'5a93c517_dd88ebc8',NULL),(15,'2015-04-13 10:39:30','Uploaded patch set 2.',265,2,265,'5a93c517_fdab67d4',NULL),(15,'2015-05-12 11:23:37','Patch Set 5: Code-Review-1',265,5,265,'bada0100_77745f9c',NULL),(15,'2015-05-12 11:23:21','Uploaded patch set 5.',265,5,265,'bada0100_d7474b4a',NULL),(7,'2015-05-07 16:13:30','Patch Set 4: -Code-Review\n\nI decided to send a version only for ppc64, given that I tested it. https://gerrit.baserock.org/602',265,4,265,'bada0100_ea7b8b27',NULL),(29,'2015-10-31 17:03:31','Patch Set 5:\n\nThere\'s no harm in keeping them around in my opinion, but I wouldn\'t propose changing them without testing the changes, we at least know that these bsps worked when they were merged.',265,5,265,'da01753e_6517a0a4',NULL),(7,'2015-10-24 14:48:21','Patch Set 5:\n\nNobody is using these BSP (that\'s why this has never been tested) I wonder if makes sense to drop support for them.',265,5,265,'da01753e_e46c3739',NULL),(7,'2015-04-17 07:58:51','Patch Set 4:\n\n> As stated before, none of this has been tested in real hardware\n\nI\'ll be testing ppc64',265,4,265,'da7095c5_59ff0302',NULL),(15,'2015-04-16 16:01:39','Patch Set 4: Code-Review-1\n\nAs stated before, none of this has been tested in real hardware',265,4,265,'fa6b99d7_1a82dd00',NULL),(6,'2015-04-16 15:38:09','Patch Set 3: Code-Review-1\n\nI very much doubt that 4.0 works on Calxeda. We need to stick with 3.15.10 on those systems until someone has time to do a \'git bisect\' between 3.15.10 and 3.16.7 and see what broke.',265,3,265,'fa6b99d7_5a885522',NULL),(15,'2015-04-16 16:00:08','Uploaded patch set 4.',265,4,265,'fa6b99d7_7a8d1931',NULL),(15,'2015-09-07 19:13:27','Patch Set 5:\n\n> The latest kernel release is now 4.2. Should this patch be dropped?\n\nI\'d prefer to update the patch to 4.2 instead',265,5,265,'fafc7978_cccde388',NULL),(28,'2015-09-07 13:58:32','Patch Set 5:\n\nThe latest kernel release is now 4.2. Should this patch be dropped?',265,5,265,'fafc7978_ccf843c7',NULL),(15,'2015-04-14 12:37:57','Patch Set 3: Code-Review+2',266,3,266,'3aa0d159_5c2cdd4a',NULL),(NULL,'2015-04-14 01:51:02','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ia8931115.\n* Depends on patch set 2 of I55eff5c8, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',266,2,266,'3aa0d159_5c74dd9b',NULL),(15,'2015-04-14 12:37:59','Change has been successfully merged into the git repository.',266,3,266,'3aa0d159_7c3199a1',NULL),(15,'2015-04-14 12:37:35','Uploaded patch set 3.',266,3,266,'3aa0d159_bcff21aa',NULL),(18,'2015-04-13 13:35:11','Patch Set 2:\n\n> Uploaded patch set 1.',266,2,266,'5a93c517_1d0c1394',NULL),(15,'2015-04-13 10:39:10','Uploaded patch set 1.',266,1,266,'5a93c517_3daa2fd5',NULL),(18,'2015-04-13 13:46:46','Patch Set 2: Code-Review+2',266,2,266,'5a93c517_5d605b35',NULL),(18,'2015-04-13 13:35:00','Patch Set 2: Code-Review+1\n\n> Uploaded patch set 1.',266,2,266,'5a93c517_7d1757a4',NULL),(15,'2015-04-13 10:39:30','Uploaded patch set 2.',266,2,266,'5a93c517_9db8232c',NULL),(NULL,'2015-04-13 13:49:03','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ia8931115.\n* Depends on patch set 2 of I55eff5c8, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',266,2,266,'5a93c517_bde15f9c',NULL),(16,'2015-04-13 13:45:52','Patch Set 2: Code-Review+1',266,2,266,'5a93c517_dd6c6b39',NULL),(8,'2015-04-13 11:02:20','Patch Set 1: Code-Review+1',267,1,267,'5a93c517_1dcad3a1',NULL),(7,'2015-04-13 11:16:28','Patch Set 1: Code-Review+2',267,1,267,'5a93c517_3d46af24',NULL),(7,'2015-04-13 10:53:43','Patch Set 1: Code-Review+1',267,1,267,'5a93c517_5de93b19',NULL),(37,'2015-04-13 10:52:09','Uploaded patch set 1.',267,1,267,'5a93c517_9d8fc375',NULL),(7,'2015-04-13 11:16:30','Change has been successfully merged into the git repository.',267,1,267,'5a93c517_dd4a2b27',NULL),(6,'2015-04-14 08:47:05','Patch Set 3: Code-Review+1\n\nThanks!\n\n > > Also, a .help file for install-essential-files.configure\n > > would be great.\n > \n > I can write a help file, but is this mean to be used by the users?\n > I think we agree this will be mandatory for all the systems?\n\nI don\'t think it should actually be hardcoded, and I think it does need a .help file so users who are exploring available extensions with `morph help-extensions` and `morph help xxx.configure` will know what it does. Just saying \"This installs files from the essential-files/ folder in your definitions.git repo, according to essential-files/manifest. It wraps the install-files.configure extension.\" would be enough.',268,3,268,'3aa0d159_7c799992',NULL),(15,'2015-04-14 12:33:58','Uploaded patch set 4.',268,4,268,'3aa0d159_fcf5a9cb',NULL),(11,'2015-04-22 09:36:51','Patch Set 4: Code-Review+1',268,4,268,'5a7ca5a3_953324f6',NULL),(15,'2015-04-13 17:31:57','Uploaded patch set 3.',268,3,268,'5a93c517_00cee85a',NULL),(6,'2015-04-13 13:56:33','Patch Set 1: Code-Review-1\n\nPlease don\'t copy and paste the existing extension, duplicating code makes maintenance a nightmare. Since both these extensions are installed as part of the \'morphlib\' Python module, one can chain to the other. Probably best to use subprocess.check_call() for that.',268,1,268,'5a93c517_5d95bbe2',NULL),(15,'2015-04-13 12:55:18','Uploaded patch set 1.',268,1,268,'5a93c517_5db61bde',NULL),(15,'2015-04-13 16:16:51','Uploaded patch set 2.',268,2,268,'5a93c517_803198a4',NULL),(6,'2015-04-13 16:41:42','Patch Set 2: Code-Review+1\n\nMuch better than v1, thanks. It might be neater to set INSTALL_FILES in the environment when install-essential-files.configure calls install-files.configure, to avoid the need to modify install-files.configure. Also, a .help file for install-essential-files.configure would be great.\n\nAssuming you\'ve tested it I think this is fine to merge though',268,2,268,'5a93c517_80a678c0',NULL),(15,'2015-04-13 17:33:36','Patch Set 3:\n\n> Much better than v1, thanks. It might be neater to set\n > INSTALL_FILES in the environment when install-essential-files.configure\n > calls install-files.configure, to avoid the need to modify\n > install-files.configure.\n\nDone\n\n> Also, a .help file for install-essential-files.configure\n > would be great.\n\nI can write a help file, but is this mean to be used by the users? I think we agree this will be mandatory for all the systems?',268,3,268,'5a93c517_a0da9415',NULL),(15,'2015-04-28 16:05:16','Change has been successfully rebased as ed423dc974a61f1c033491819c9554716b8f59b3',268,4,268,'bada0100_50ee0c8d',NULL),(15,'2015-04-28 16:05:14','Patch Set 4: Code-Review+2',268,4,268,'bada0100_90e474ad',NULL),(15,'2015-04-28 16:05:16','Patch Set 5: Patch Set 4 was rebased',268,4,268,'bada0100_b0e1789c',NULL),(8,'2015-04-28 15:57:19','Patch Set 4: Code-Review+1',268,4,268,'bada0100_f0506060',NULL),(6,'2015-04-13 14:30:55','Patch Set 1:\n\nGood point, I guess it\'s better to keep the code in Morph, but add a comment noting that it\'s obsolete and just kept for compatibility reasons.',269,1,269,'5a93c517_7d4f5793',NULL),(15,'2015-04-13 12:55:43','Uploaded patch set 1.',269,1,269,'5a93c517_7dbbd7c4',NULL),(15,'2015-04-13 14:16:13','Patch Set 1:\n\n> Looks good, would be nice to remove the code in Morph that\n > currently adds /etc/os-release after this is merged.\n\nYeah, I was thinking about that; the problem is that if you use current morph with a old definitions the result system is not going to have /etc/os-release',269,1,269,'5a93c517_bda63f52',NULL),(6,'2015-04-13 14:05:38','Patch Set 1: Code-Review+1\n\nLooks good, would be nice to remove the code in Morph that currently adds /etc/os-release after this is merged.',269,1,269,'5a93c517_fd85a7ad',NULL),(15,'2015-04-29 16:59:23','Abandoned\n\nThis has already merged in 7b23e26',269,1,269,'bada0100_9676ac05',NULL),(8,'2015-04-27 10:35:40','Patch Set 1: Code-Review+1',269,1,269,'dad5f5cf_f164e8e6',NULL),(7,'2015-04-14 12:24:54','Patch Set 4: Code-Review+1\n\nThe code looks great. Thanks!\n\nThis +1 can be taken as a +2 if the bugs that you mentioned in your comments don\'t exist anymore.',270,4,270,'3aa0d159_7c0af9d3',NULL),(8,'2015-04-14 10:59:11','Patch Set 4: Code-Review+1\n\nThis looks sane to me',270,4,270,'3aa0d159_7ca0b9f4',NULL),(6,'2015-04-14 12:47:32','Patch Set 5: Patch Set 4 was rebased',270,4,270,'3aa0d159_9c190525',NULL),(6,'2015-04-14 12:47:32','Change has been successfully rebased as fd4d6afc778f633b0e4d3df3c478599d7cc1f7fe',270,4,270,'3aa0d159_bc1641f0',NULL),(6,'2015-04-14 12:47:05','Patch Set 4: Code-Review+2',270,4,270,'3aa0d159_dc1f8d08',NULL),(6,'2015-04-14 12:47:29','Patch Set 4:\n\nIt turned out that I had multiple corrupt stratum artifacts, no other bug. So I\'ll merge this. Thanks for the reviews!',270,4,270,'3aa0d159_fc1cc915',NULL),(6,'2015-04-13 14:55:39','Patch Set 4:\n\nSorry about the churn, I really confused myself by putting a full stop after the filename...\n\nOn further investigation, it seems that I\'m hitting a bug where Morph fails to download the stratum artifact from cache.baserock.org correctly. I have verified that the artifact file is not empty on cache.baserock.org, but Morph keeps creating an empty file when it tries to download it, and then triggering this error. I shall send a seperate patch for that once I work out what is going on.',270,4,270,'5a93c517_1d12d362',NULL),(6,'2015-04-13 14:47:31','Uploaded patch set 1.',270,1,270,'5a93c517_3d40ef55',NULL),(6,'2015-04-13 14:54:03','Uploaded patch set 4.',270,4,270,'5a93c517_7d1d1773',NULL),(6,'2015-04-13 15:04:59','Patch Set 4:\n\nFalse alarm about the second bug, I was confusing two different artifacts. Deleting the corrupted files fixed the issue. This patch is useful because it gives you the name of the corrupted file, so you can delete it and have Morph redownload it.',270,4,270,'5a93c517_80043816',NULL),(6,'2015-04-13 14:48:35','Uploaded patch set 2.',270,2,270,'5a93c517_dd246bc8',NULL),(6,'2015-04-13 14:48:51','Uploaded patch set 3.',270,3,270,'5a93c517_fd2127b5',NULL),(8,'2015-04-13 15:15:23','Uploaded patch set 1.',271,1,271,'5a93c517_2020c49a',NULL),(8,'2015-04-13 15:30:32','Change has been successfully merged into the git repository.',271,1,271,'5a93c517_40815049',NULL),(18,'2015-04-13 15:22:14','Patch Set 1: Code-Review+1\n\n> Uploaded patch set 1.',271,1,271,'5a93c517_a04a9453',NULL),(6,'2015-04-13 15:29:27','Patch Set 1: Code-Review+2',271,1,271,'5a93c517_c0b56032',NULL),(18,'2015-04-13 15:23:22','Patch Set 1: Code-Review+1\n\n> Uploaded patch set 1.',272,1,272,'5a93c517_206e84ca',NULL),(18,'2015-04-13 15:30:32','Change has been successfully merged into the git repository.',272,1,272,'5a93c517_207c4472',NULL),(8,'2015-04-13 15:15:23','Uploaded patch set 1.',272,1,272,'5a93c517_4025d0a9',NULL),(18,'2015-04-13 15:29:10','Patch Set 1: Code-Review+2',272,1,272,'5a93c517_40aab0d5',NULL),(35,'2015-04-13 15:26:25','Patch Set 1: Code-Review+1',272,1,272,'5a93c517_a06134d5',NULL),(15,'2015-04-13 15:54:55','Patch Set 1:\n\n> > why is this needed?\n > \n > IIRC, apache-httpd needs to know where suexec is, even when suexec\n > is being installed by the same chunk.\n > \n > We were moving/copying the binary after installation to /lib/httpd.\n > With this change, the hack won\'t be needed.\n\nPlease, put this info in the commit message',273,1,273,'5a93c517_0048282c',NULL),(8,'2015-04-13 16:02:59','Patch Set 3: Commit message was updated',273,3,273,'5a93c517_006fc893',NULL),(6,'2015-04-13 16:13:17','Patch Set 3: Code-Review+2',273,3,273,'5a93c517_00f6e8d7',NULL),(15,'2015-04-13 16:18:55','Patch Set 4: Patch Set 3 was rebased',273,3,273,'5a93c517_20268469',NULL),(15,'2015-04-13 16:18:56','Change has been successfully rebased as 7afae9e4948f9f8dca8e2cabf321c7b11df8a1a8',273,3,273,'5a93c517_402b9030',NULL),(7,'2015-04-13 15:38:01','Patch Set 1:\n\n> why is this needed?\n\nIIRC, apache-httpd needs to know where suexec is, even when suexec is being installed by the same chunk.\n\nWe were moving/copying the binary after installation to /lib/httpd. With this change, the hack won\'t be needed.',273,1,273,'5a93c517_40cf10b1',NULL),(18,'2015-04-13 15:27:46','Patch Set 1: Code-Review+1',273,1,273,'5a93c517_609b2cca',NULL),(18,'2015-04-13 16:04:46','Patch Set 3: Code-Review+1',273,3,273,'5a93c517_a06b7484',NULL),(8,'2015-04-13 15:18:22','Uploaded patch set 1.',273,1,273,'5a93c517_c03000eb',NULL),(6,'2015-04-13 15:30:41','Patch Set 1: Code-Review+1\n\nwhy is this needed?',273,1,273,'5a93c517_c08c8082',NULL),(8,'2015-04-13 16:02:32','Patch Set 2: Commit message was updated',273,2,273,'5a93c517_e0717c78',NULL),(6,'2015-04-13 15:28:36','Patch Set 2:\n\n(1 comment)',274,2,274,'5a93c517_20a52404',NULL),(6,'2015-04-13 15:20:41','Uploaded patch set 1.',274,1,274,'5a93c517_604d6c72',NULL),(6,'2015-04-13 15:23:08','Uploaded patch set 2.',274,2,274,'5a93c517_c047a04a',NULL),(7,'2015-04-21 10:02:31','Patch Set 2: Code-Review+1',274,2,274,'7a7fa997_56d03453',NULL),(6,'2015-04-21 11:03:47','Patch Set 3: Code-Review+2',274,3,274,'7a7fa997_9619ec24',NULL),(8,'2015-04-21 10:23:10','Patch Set 2: Code-Review+1',274,2,274,'7a7fa997_96bd6c05',NULL),(6,'2015-04-21 11:03:50','Change has been successfully merged into the git repository.',274,3,274,'7a7fa997_b61668f0',NULL),(NULL,'2015-04-21 11:03:29','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I953c9477, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',274,2,274,'7a7fa997_d61f6408',NULL),(6,'2015-04-21 11:03:45','Patch Set 3: Patch Set 2 was rebased',274,2,274,'7a7fa997_f61ce015',NULL),(6,'2015-04-21 11:00:09','Patch Set 2: Code-Review+2\n\nThanks for the reviews, merging.',274,2,274,'7a7fa997_f6f5c0cb',NULL),(6,'2015-04-13 15:23:08','Uploaded patch set 2.',275,2,275,'5a93c517_60748c9c',NULL),(6,'2015-04-13 15:20:41','Uploaded patch set 1.',275,1,275,'5a93c517_8052f811',NULL),(NULL,'2015-04-21 11:03:59','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Id2a4e4f2, however the current patch set is 3.\n* Depends on commit 443458c450e63f1e3001e984a26c1fe01b6679c3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',275,2,275,'7a7fa997_16dddc42',NULL),(7,'2015-04-21 10:12:15','Patch Set 2: Code-Review+1',275,2,275,'7a7fa997_36cfb8b2',NULL),(6,'2015-04-21 11:07:32','Patch Set 3: Code-Review+2',275,3,275,'7a7fa997_96f00ccb',NULL),(6,'2015-04-21 11:07:35','Change has been successfully merged into the git repository.',275,3,275,'7a7fa997_b6ed08f2',NULL),(6,'2015-04-21 11:03:05','Patch Set 2: Code-Review+2\n\nThanks for reviewing!',275,2,275,'7a7fa997_b6ff48aa',NULL),(8,'2015-04-21 10:18:18','Patch Set 2: Code-Review+1',275,2,275,'7a7fa997_f6c0607e',NULL),(6,'2015-04-21 11:07:29','Patch Set 3: Patch Set 2 was rebased',275,2,275,'7a7fa997_f6e38003',NULL),(8,'2015-04-13 15:22:07','Uploaded patch set 1.',276,1,276,'5a93c517_003ee8b8',NULL),(7,'2015-04-13 15:32:29','Patch Set 2: Patch Set 1 was rebased',276,1,276,'5a93c517_40f870e5',NULL),(6,'2015-04-13 15:29:59','Patch Set 1: Code-Review+2',276,1,276,'5a93c517_60824c54',NULL),(6,'2015-04-13 15:30:11','Patch Set 1:\n\nI like these!',276,1,276,'5a93c517_80875861',NULL),(18,'2015-04-13 15:26:47','Patch Set 1: Code-Review+1',276,1,276,'5a93c517_c05ec012',NULL),(7,'2015-04-13 15:32:29','Change has been successfully rebased as a163a811531f5ea9db30ee955824b8f0ba319d64',276,1,276,'5a93c517_e0dc1c77',NULL),(6,'2015-04-13 15:23:08','Uploaded patch set 1.',277,1,277,'5a93c517_80799895',NULL),(7,'2015-04-21 10:10:00','Patch Set 1: Code-Review+1\n\nThis is a clear improvement in the code, thanks Sam!',277,1,277,'7a7fa997_16cabca1',NULL),(6,'2015-04-21 10:59:36','Patch Set 1:\n\nThanks for the reviews, merging.',277,1,277,'7a7fa997_361498f4',NULL),(6,'2015-04-21 11:03:13','Patch Set 2: Patch Set 1 was rebased',277,1,277,'7a7fa997_562cb44a',NULL),(6,'2015-04-21 11:03:14','Change has been successfully rebased as 1c01f18a0c6501d7b5206bfef68d9128b7ba1996',277,1,277,'7a7fa997_7631b0a1',NULL),(8,'2015-04-21 10:17:29','Patch Set 1: Code-Review+1',277,1,277,'7a7fa997_d6c3e488',NULL),(6,'2015-04-21 10:59:40','Patch Set 1: Code-Review+2',277,1,277,'7a7fa997_d6f8c4c6',NULL),(8,'2015-04-14 10:57:02','Patch Set 1: Code-Review+1',278,1,278,'3aa0d159_5c9b7dc9',NULL),(6,'2015-04-13 16:42:07','Patch Set 1: Code-Review+1',278,1,278,'5a93c517_20abe48a',NULL),(15,'2015-04-13 16:23:34','Uploaded patch set 1.',278,1,278,'5a93c517_20dd2443',NULL),(15,'2015-04-28 16:05:34','Patch Set 1: Code-Review+2',278,1,278,'bada0100_10e8847b',NULL),(15,'2015-04-28 16:08:20','Patch Set 2: Code-Review+2',278,2,278,'bada0100_5095ace2',NULL),(15,'2015-04-28 16:08:24','Change has been successfully merged into the git repository.',278,2,278,'bada0100_709a3016',NULL),(15,'2015-04-28 16:08:16','Patch Set 2: Patch Set 1 was rebased',278,1,278,'bada0100_b0f8984a',NULL),(NULL,'2015-04-28 16:05:39','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I3d67b3a4, however the current patch set is 5.\n\nPlease rebase the change and upload a replacement commit.',278,1,278,'bada0100_d0019c3a',NULL),(15,'2015-04-13 17:10:51','Uploaded patch set 1.',279,1,279,'5a93c517_2099a46e',NULL),(8,'2015-04-13 17:17:42','Patch Set 2: Code-Review+1',279,2,279,'5a93c517_40b5d0cb',NULL),(15,'2015-04-13 17:33:57','Change has been successfully merged into the git repository.',279,2,279,'5a93c517_60048c7e',NULL),(6,'2015-04-13 17:13:07','Patch Set 1: Code-Review+1',279,1,279,'5a93c517_a0acd48d',NULL),(15,'2015-04-13 17:14:10','Uploaded patch set 2.',279,2,279,'5a93c517_c0a9e07c',NULL),(15,'2015-04-13 17:33:54','Patch Set 2: Code-Review+2',279,2,279,'5a93c517_c0d7a0ec',NULL),(29,'2015-04-13 17:55:06','Uploaded patch set 1.',280,1,280,'5a93c517_401150ab',NULL),(7,'2015-04-13 17:57:46','Patch Set 1: Code-Review+2',280,1,280,'5a93c517_a0761405',NULL),(15,'2015-04-13 17:56:06','Patch Set 1: Code-Review+1',280,1,280,'5a93c517_c01c80c4',NULL),(7,'2015-04-13 17:57:48','Change has been successfully merged into the git repository.',280,1,280,'5a93c517_c0732014',NULL),(NULL,'2015-06-12 12:15:49','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Id345254c, however the current patch set is 3.\n* Depends on commit 316c85524dcd5c13ba8500388d42d733277aaefa which has no change associated with it.\n* Depends on commit 316ac76731913a230e0b52363ed0a0ea40f8ff14 which has no change associated with it.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',281,2,281,'3a4c51b2_1c09d595',NULL),(NULL,'2015-06-12 11:40:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Id345254c, however the current patch set is 3.\n* Depends on commit 316c85524dcd5c13ba8500388d42d733277aaefa which has no change associated with it.\n* Depends on commit 316ac76731913a230e0b52363ed0a0ea40f8ff14 which has no change associated with it.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',281,2,281,'3a4c51b2_3cb651dd',NULL),(6,'2015-06-12 11:34:22','Patch Set 2: Code-Review+2\n\nI\'ve not tested this, but I\'ve taken the liberty of merging all the outstanding firehose patches to master of firehose.git.\n\nFirehose is currently rather unloved, it needs someone to take the time to define goals for it, and ensure that it achieves those goals. I think a big part of the problem is that its design assumes a ready-to-use \'test this branch build and works\' solution, that we don\'t actually have at present.\n\nWith this in mind, I think it makes sense to merge all of the work that\'s been done so far to master of firehose.git, rather than having it sitting round on Gerrit.',281,2,281,'3a4c51b2_5c9ebd57',NULL),(NULL,'2015-06-12 11:34:24','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Id345254c, however the current patch set is 3.\n* Depends on commit 316c85524dcd5c13ba8500388d42d733277aaefa which has no change associated with it.\n* Depends on commit 316ac76731913a230e0b52363ed0a0ea40f8ff14 which has no change associated with it.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',281,2,281,'3a4c51b2_bca26198',NULL),(NULL,'2015-06-12 12:15:41','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Id345254c, however the current patch set is 3.\n* Depends on patch set 2 of Ia2eb431d, however the current patch set is 3.\n* Depends on commit 316ac76731913a230e0b52363ed0a0ea40f8ff14 which has no change associated with it.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',281,2,281,'3a4c51b2_bcd0a1f8',NULL),(6,'2015-06-12 13:39:16','Abandoned\n\nAbandoning this as https://gerrit.baserock.org/#/c/430/1 appears to be a newer version of the same thing',281,2,281,'3a4c51b2_dc73ed13',NULL),(6,'2015-06-12 11:38:53','Patch Set 2: Code-Review-2\n\nA quick once-over in pylint shows a bunch of errors (mostly calling functions using the wrong name), so this patch won\'t actually work. Despite my comment above, I\'ll leave merging this one as it is clearly broken.',281,2,281,'3a4c51b2_dca92d7d',NULL),(NULL,'2015-06-12 12:20:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Id345254c, however the current patch set is 3.\n* Depends on commit 316c85524dcd5c13ba8500388d42d733277aaefa which has no change associated with it.\n* Depends on commit 316ac76731913a230e0b52363ed0a0ea40f8ff14 which has no change associated with it.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',281,2,281,'3a4c51b2_dcee4db4',NULL),(6,'2015-06-12 12:17:42','Patch Set 2:\n\nhttps://gerrit.baserock.org/#/c/430/1 looks like a later version of this...',281,2,281,'3a4c51b2_fcf18996',NULL),(11,'2015-04-14 09:21:52','Uploaded patch set 1.',281,1,281,'3aa0d159_bc5e4111',NULL),(27,'2015-04-17 11:12:20','Patch Set 2: Code-Review+1\n\nlooks good to me',281,2,281,'da7095c5_d9cd5388',NULL),(11,'2015-04-16 08:32:46','Uploaded patch set 2.',281,2,281,'fa6b99d7_fa3609e7',NULL),(8,'2015-04-14 11:43:49','Patch Set 1: Code-Review+1',282,1,282,'3aa0d159_1c5895f9',NULL),(6,'2015-04-14 11:47:23','Patch Set 1: Code-Review+2',282,1,282,'3aa0d159_3c5d51ea',NULL),(6,'2015-04-14 11:47:50','Change has been successfully rebased as 519885d04dffaa5d9bb21271f8c1ffc0a63f5f67',282,1,282,'3aa0d159_9c6b4585',NULL),(15,'2015-04-14 11:37:48','Uploaded patch set 1.',282,1,282,'3aa0d159_bc5161da',NULL),(6,'2015-04-14 11:47:47','Patch Set 1:\n\nThanks for this fix, much appreciated!',282,1,282,'3aa0d159_dc71cd78',NULL),(6,'2015-04-14 11:47:50','Patch Set 2: Patch Set 1 was rebased',282,1,282,'3aa0d159_fc6e0996',NULL),(7,'2015-04-14 12:16:35','Change has been successfully rebased as b48eff60cd046fb0ba00ef8111d82f31bdf74849',283,1,283,'3aa0d159_5c05bdc0',NULL),(6,'2015-04-14 11:38:12','Uploaded patch set 1.',283,1,283,'3aa0d159_5c5e1deb',NULL),(8,'2015-04-14 11:40:30','Patch Set 1: Code-Review+2',283,1,283,'3aa0d159_7c63d9b1',NULL),(7,'2015-04-14 12:16:35','Patch Set 2: Patch Set 1 was rebased',283,1,283,'3aa0d159_bc688188',NULL),(27,'2015-04-23 14:16:06','Patch Set 2: Code-Review+1',284,2,284,'3a79b1b5_34cfb0b2',NULL),(45,'2015-04-14 15:30:06','Patch Set 1: Code-Review+1',284,1,284,'3aa0d159_5cba9de2',NULL),(32,'2015-04-14 15:28:28','Patch Set 1: Code-Review+1\n\nLooks good to me',284,1,284,'3aa0d159_9cf025cb',NULL),(37,'2015-04-14 15:29:52','Patch Set 1:\n\nI haven\'t tested this, someone else will have to due to time constraints, I was just handy to point out what needs to be done.',284,1,284,'3aa0d159_bcede1f1',NULL),(46,'2015-04-14 21:39:07','Patch Set 1: Code-Review-1\n\nThis will silently fail if the commented default of DES is removed or changed upstream.\n\nI think that it would be preferable to separately delete any upstream default (commented or not) and insert the default we want:\n\nsed -i -e \'/^#*ENCRYPT_METHOD/d\' \"$DESTDIR/etc/login.defs\"\necho \'ENCRYPT_METHOD SHA512\' >>\"$DESTDIR/etc/login.defs\"\n\n(You can do both in one sed command, but the required ordering is weird.)',284,1,284,'3aa0d159_fcc60949',NULL),(37,'2015-04-14 15:24:29','Uploaded patch set 1.',284,1,284,'3aa0d159_fce36903',NULL),(32,'2015-04-22 14:46:54','Patch Set 2: Code-Review+1\n\nLooks reasonable. (I have not tested)',284,2,284,'5a7ca5a3_3587b011',NULL),(45,'2015-04-22 14:42:36','Patch Set 2: Code-Review+1',284,2,284,'5a7ca5a3_758d2831',NULL),(46,'2015-04-22 15:17:25','Patch Set 2:\n\nIt still fails if this setting isn\'t mentioned at all in the upstream shipped config file.',284,2,284,'5a7ca5a3_f578582d',NULL),(37,'2015-04-22 14:40:27','Uploaded patch set 2.',284,2,284,'5a7ca5a3_f5913853',NULL),(NULL,'2015-04-30 09:47:56','The change could not be merged due to a path conflict.\n\nPlease rebase the change locally and upload the rebased commit for review.',284,2,284,'bada0100_19098f2c',NULL),(37,'2015-05-05 12:49:26','Patch Set 3: Code-Review+1\n\nI can confirm that with this change, I can set my password to \"verylongpassword\" and can\'t log in with just \"verylong\".',284,3,284,'bada0100_1fabaf8a',NULL),(37,'2015-04-30 09:52:44','Patch Set 2: -Code-Review\n\nActually, it turns out this has been entirely obsoleted by changes that make PAM handle configuring the ENCRYPT_METHOD, according to the new version of login.defs, so I\'m going to have to see what PAM does.',284,2,284,'bada0100_390ed335',NULL),(6,'2015-05-05 13:51:21','Patch Set 3: Code-Review+2',284,3,284,'bada0100_3f879311',NULL),(NULL,'2015-04-30 09:47:27','The change could not be merged due to a path conflict.\n\nPlease rebase the change locally and upload the rebased commit for review.',284,2,284,'bada0100_59ff1702',NULL),(37,'2015-04-30 10:17:58','Patch Set 3:\n\nI\'ve verified that these changes make the right sort of change to the configuration file. I\'m currently doing a build test.',284,3,284,'bada0100_99333ff6',NULL),(37,'2015-04-30 09:47:19','Patch Set 2: Code-Review+2\n\nI\'d rather have this in and it potentially break later than it remain absent for much longer, so I\'m going to merge this and provide a follow-up patch to handle if the option is later removed.',284,2,284,'bada0100_b602d009',NULL),(37,'2015-05-01 11:03:24','Patch Set 3:\n\nIt built successfully, but I didn\'t get as far as running the produced system, due to an unfortunate distraction.',284,3,284,'bada0100_c4c0fe2c',NULL),(32,'2015-04-30 10:23:43','Patch Set 3: Code-Review+1\n\nThe shape looks okay to me, if Richard\'s test-build goes well then I\'m okay with this.',284,3,284,'bada0100_d96787e9',NULL),(6,'2015-05-05 13:51:32','Patch Set 4: Patch Set 3 was rebased',284,3,284,'bada0100_df7be727',NULL),(37,'2015-04-30 10:14:18','Uploaded patch set 3.',284,3,284,'bada0100_f9360be7',NULL),(6,'2015-05-05 13:51:32','Change has been successfully rebased as 93db3685bce720ca523ba5be8699e7d18f33806a',284,3,284,'bada0100_ff782b2d',NULL),(46,'2015-04-17 23:44:05','Patch Set 1: -Code-Review\n\n> If the default changed from DES, I\'d probably be happy enough to\n > use that value instead.\n\nBut the real default is in the code, not in the config file. If this comment in the sample config file is removed or changed, the real default won\'t have changed.',284,1,284,'da7095c5_7c3c3594',NULL),(37,'2015-04-17 14:49:32','Patch Set 1:\n\n> This will silently fail if the commented default of DES is removed\n > or changed upstream.\n\nIf the default changed from DES, I\'d probably be happy enough to use that value instead.',284,1,284,'da7095c5_99fb5b47',NULL),(39,'2015-04-24 15:31:34','Uploaded patch set 12.',285,12,285,'1a76adc5_93549ccb',NULL),(39,'2015-04-24 09:39:13','Uploaded patch set 11.',285,11,285,'1a76adc5_d3121458',NULL),(39,'2015-04-15 08:44:47','Uploaded patch set 2.',285,2,285,'1a9dcd25_1b097b2c',NULL),(39,'2015-04-15 13:26:52','Uploaded patch set 3.',285,3,285,'1a9dcd25_1bddfb42',NULL),(6,'2015-04-15 16:26:55','Patch Set 3:\n\n(1 comment)\n\nit might take up a lot of RAM to store, for each build, the whole BuildController instance and every object it references. Better to just store the information you need: how about a dict mapping ID of build to something that describes the result? No need to keep around all of the state machines.\n\nIt looks like \'distbuild-get-status\' will return a list of every build-request that has ever run on the distbuild network. That will quickly become unwieldy! It needs to be able to take the ID of a build-request (as returned to the user by \'distbuild-start\') and just return the state of *that* build. It shouldn\'t be up to the user to have to dredge through every single build that has happened to find theirs.',285,3,285,'1a9dcd25_fbd7efbd',NULL),(33,'2015-04-23 10:45:57','Patch Set 9: Code-Review-1\n\n(7 comments)',285,9,285,'3a79b1b5_34aa50d5',NULL),(39,'2015-04-14 15:51:55','Uploaded patch set 1.',285,1,285,'3aa0d159_3cb9d1e9',NULL),(33,'2015-04-22 07:55:05','Patch Set 8:\n\nI\'m working on a version of this that will store build requests in an sqlite3 database, but that doesn\'t necessarily block the merge of this change, though I have renamed distbuild-get-status to distbuild-stat, so it might be worth renaming the command before we merge this.',285,8,285,'5a7ca5a3_75044815',NULL),(39,'2015-04-22 16:38:07','Uploaded patch set 9.',285,9,285,'5a7ca5a3_95da4416',NULL),(33,'2015-04-22 08:22:13','Patch Set 8: Code-Review-1\n\n> I\'m working on a version of this that will store build requests in \n > an sqlite3 database, but that doesn\'t necessarily block the merge\n > of this change, though I have renamed distbuild-get-status to\n > distbuild-stat, so it might be worth renaming the command before we\n > merge this.\n\nThat said, if the basis of this implementation remains similar to earlier implementations, then memory consumption will increase linearly with the\nnumber of build requests and I\'d suggest that merging such an implementation\nmay cause more problems than it solves depending on the usage profile of\nthe user and the uptime of the controller.',285,8,285,'5a7ca5a3_b519807b',NULL),(33,'2015-04-22 11:46:03','Patch Set 8:\n\n(1 comment)\n\nSorry, I thought I\'d mentioned this as a simple alternative earlier on',285,8,285,'5a7ca5a3_b5bae008',NULL),(39,'2015-04-21 18:27:40','Uploaded patch set 4.',285,4,285,'7a7fa997_36a49856',NULL),(39,'2015-04-21 20:17:56','Uploaded patch set 7.',285,7,285,'7a7fa997_7668d0f5',NULL),(39,'2015-04-21 19:20:38','Uploaded patch set 5.',285,5,285,'7a7fa997_76c1b0e3',NULL),(39,'2015-04-21 20:24:23','Uploaded patch set 8.',285,8,285,'7a7fa997_d67684d8',NULL),(39,'2015-04-21 19:43:23','Uploaded patch set 6.',285,6,285,'7a7fa997_d6af642a',NULL),(33,'2015-04-20 13:40:37','Patch Set 3:\n\n(1 comment)',285,3,285,'9a6a9dd7_57058cc0',NULL),(33,'2015-04-20 09:05:49','Patch Set 3:\n\n(3 comments)\n\nHey :)\nHad a look through and have a few more suggestions',285,3,285,'9a6a9dd7_5737ccb0',NULL),(33,'2015-04-19 21:37:21','Patch Set 3: Code-Review-1\n\n(2 comments)\n\nsorry, this isn\'t a complete review,\nbut I did notice a couple of style issues you might want to fix',285,3,285,'ba65a107_589b7dc9',NULL),(33,'2015-04-19 21:39:02','Patch Set 3:\n\nAlso, not sure about using raw strings for the build_status,\nit\'d probably be safer if those were defined as constants somewhere.',285,3,285,'ba65a107_78a0c1f4',NULL),(29,'2015-04-28 15:24:01','Uploaded patch set 14.',285,14,285,'bada0100_1035e445',NULL),(29,'2015-04-28 11:58:32','Patch Set 13: Code-Review-2\n\n(1 comment)\n\nI will fix this on merge of this topic.',285,13,285,'bada0100_30cfc8b2',NULL),(NULL,'2015-04-29 16:11:06','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 15 of I458a5767, however the current patch set is 16.\n* Depends on commit 0b0bbdace7bcd04717d76f60d34b44994fb3e368 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',285,14,285,'bada0100_3687c011',NULL),(33,'2015-04-28 16:19:09','Patch Set 14:\n\n> Looks fine at a glance, my only issue is that there\'s too much\n > duplication in initiator.py but that\'s not a big issue at all.\n > Thanks for all the hard work on this!\n\nAgreed, there is too much duplication but I think we need to fix this in another change.',285,14,285,'bada0100_50bccc6c',NULL),(33,'2015-04-28 17:28:10','Patch Set 14: Code-Review-2\n\nCommand output is sometimes delayed for several seconds,\nsuggest we solve this problem before merging these changes.',285,14,285,'bada0100_701d5073',NULL),(29,'2015-04-28 15:37:57','Patch Set 14: -Code-Review',285,14,285,'bada0100_707eb0e6',NULL),(NULL,'2015-04-29 16:05:01','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 15 of I458a5767.\n* Depends on patch set 7 of I28e733cb, however the current patch set is 8.\n\nPlease rebase the change and upload a replacement commit.',285,14,285,'bada0100_76a6a8c3',NULL),(33,'2015-04-28 17:49:23','Patch Set 14:\n\n> Command output is sometimes delayed for several seconds,\n > suggest we solve this problem before merging these changes.\n\nIt occurred to me that this might be due to the number of messages\nsent and lack of prioritising, especially since we send the build\nlog as messages through the controller, so it might be possible that\na flood of build log messages delays our status/control messages.\n\nMaybe we should add a separate queue for handling status/control messages\nin distbuild?',285,14,285,'bada0100_90055416',NULL),(39,'2015-04-29 07:17:19','Patch Set 14:\n\nWould this separate queue be a large scale job or is it something that could be done in a short period of time?',285,14,285,'bada0100_93da3e16',NULL),(33,'2015-04-29 16:11:19','Change has been successfully merged into the git repository.',285,15,285,'bada0100_96754c34',NULL),(NULL,'2015-04-29 16:10:43','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 7 of I28e733cb, however the current patch set is 8.\n\nPlease rebase the change and upload a replacement commit.',285,14,285,'bada0100_969eac62',NULL),(33,'2015-04-29 16:01:15','Patch Set 14: Code-Review+2\n\n> > Command output is sometimes delayed for several seconds,\n > > suggest we solve this problem before merging these changes.\n > \n > It occurred to me that this might be due to the number of messages\n > sent and lack of prioritising, especially since we send the build\n > log as messages through the controller, so it might be possible\n > that\n > a flood of build log messages delays our status/control messages.\n > \n > Maybe we should add a separate queue for handling status/control\n > messages\n > in distbuild?\n\nThis seems to have been caused by doing too much io on my vm host,\nI disabled the lorry controller on my trove, and moved one of the\nworkers onto another vm host, since then I\'ve been unable to reproduce this issue.\n\nSorry for the noise.',285,14,285,'bada0100_96f0ecca',NULL),(39,'2015-04-28 08:22:26','Uploaded patch set 13.',285,13,285,'bada0100_d012fc57',NULL),(6,'2015-04-28 16:12:29','Patch Set 14: Code-Review+1\n\nLooks fine at a glance, my only issue is that there\'s too much duplication in initiator.py but that\'s not a big issue at all. Thanks for all the hard work on this!',285,14,285,'bada0100_d088bcc8',NULL),(33,'2015-04-29 16:11:14','Patch Set 15: Patch Set 14 was rebased',285,14,285,'bada0100_d67bd427',NULL),(33,'2015-04-29 16:11:17','Patch Set 15: Code-Review+2',285,15,285,'bada0100_f678582d',NULL),(6,'2015-04-16 11:10:07','Patch Set 3:\n\n(1 comment)',285,3,285,'fa6b99d7_1a0f3de3',NULL),(39,'2015-04-16 10:17:12','Patch Set 3:\n\n(1 comment)',285,3,285,'fa6b99d7_1a417d0b',NULL),(8,'2015-04-15 08:42:11','Patch Set 1: Code-Review+1',286,1,286,'1a9dcd25_7b043f15',NULL),(6,'2015-04-15 08:56:49','Change has been successfully merged into the git repository.',286,1,286,'1a9dcd25_9b1cab6c',NULL),(6,'2015-04-15 08:56:46','Patch Set 1: Code-Review+2',286,1,286,'1a9dcd25_fb0fef2c',NULL),(15,'2015-04-14 22:46:50','Patch Set 1: Code-Review+1',286,1,286,'3aa0d159_9cda6516',NULL),(6,'2015-04-14 16:30:42','Uploaded patch set 1.',286,1,286,'3aa0d159_dccd4d88',NULL),(16,'2015-04-14 16:35:44','Uploaded patch set 1.',287,1,287,'3aa0d159_fcca896d',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',287,3,287,'5a7ca5a3_35ed708c',NULL),(16,'2015-04-22 22:00:32','Patch Set 3: Code-Review-1\n\nRichard Maw\'s comments are still unaddressed.',287,3,287,'5a7ca5a3_55634c1a',NULL),(16,'2015-04-22 16:29:08','Patch Set 2:\n\n(1 comment)',287,2,287,'5a7ca5a3_75e208d7',NULL),(37,'2015-04-22 16:21:29','Patch Set 2: Code-Review-1\n\n(2 comments)',287,2,287,'5a7ca5a3_d5c99c5b',NULL),(6,'2015-04-21 08:47:42','Patch Set 1:\n\nThis patch series were first sent for review here: and again here: ',287,1,287,'7a7fa997_362578ab',NULL),(11,'2015-04-21 15:03:01','Patch Set 1: Code-Review+1',287,1,287,'7a7fa997_562b54eb',NULL),(27,'2015-04-21 12:03:14','Patch Set 1: Code-Review+1',287,1,287,'7a7fa997_76bbf0c4',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',287,2,287,'7a7fa997_b6e1889c',NULL),(16,'2016-05-24 22:31:10','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',287,3,287,'da36d5c6_e92af52b',NULL),(16,'2015-04-14 16:35:44','Uploaded patch set 1.',288,1,288,'3aa0d159_9cc7c564',NULL),(37,'2015-04-22 16:46:34','Patch Set 2: Code-Review-1\n\n(4 comments)\n\nThe whiteout device nodes created by overlayfs could be handled by instead of checking in the working directory of the system artifact, checking in the whole tree while the overlay is mounted.\n\nAs mentioned in previous reviews, a context manager would improve matters; also since we have no validation on the users configuration of what file paths they have, they may decide to use a tempdir with a comma in, so we have to escape the paths when we pass them as mount options.',288,2,288,'5a7ca5a3_7509a894',NULL),(16,'2015-04-22 22:00:43','Patch Set 3: Code-Review-1\n\nRichard Maw\'s comments are still unaddressed.',288,3,288,'5a7ca5a3_7568c8f5',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',288,3,288,'5a7ca5a3_9576c405',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',288,2,288,'7a7fa997_d66c4439',NULL),(16,'2016-05-24 22:31:18','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',288,3,288,'da36d5c6_09202949',NULL),(6,'2015-04-17 15:21:46','Patch Set 1: Code-Review-1\n\nWe\'ve discovered that this doesn\'t handle the case of a file being removed at integration-time. overlayfs handles this internally by creating a funny character device, but outside overlayfs that doesn\'t make sense.',288,1,288,'da7095c5_d90b132a',NULL),(16,'2015-04-14 16:35:44','Uploaded patch set 1.',289,1,289,'3aa0d159_bcc40160',NULL),(16,'2015-04-22 22:00:47','Patch Set 3: Code-Review-1\n\nRichard Maw\'s comments are still unaddressed.',289,3,289,'5a7ca5a3_156dd404',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',289,3,289,'5a7ca5a3_b573c014',NULL),(37,'2015-04-22 16:56:53','Patch Set 2: Code-Review-1\n\n(3 comments)\n\nEscape the commas and use a context manager for setup_deploy.',289,2,289,'5a7ca5a3_f5f4d888',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',289,2,289,'7a7fa997_f6694026',NULL),(16,'2016-05-24 22:31:24','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',289,3,289,'da36d5c6_291ded0f',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',290,1,290,'3aa0d159_5ca13da8',NULL),(16,'2015-04-22 22:00:53','Patch Set 3: Code-Review-1\n\nRichard Maw\'s comments are still unaddressed.',290,3,290,'5a7ca5a3_357250e6',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',290,3,290,'5a7ca5a3_55602c35',NULL),(37,'2015-04-22 17:12:16','Patch Set 2: Code-Review-1\n\n(4 comments)\n\nFile paths may contain naughty characters, we need to either validate that we don\'t have then, or preferrably use the filesystem\'s escaping mechanism.\n\noverlayfs lets you escape the , character as \\, but unionfs has no way to escape the : or = characters, so we would have to raise an exception if we encountered them.',290,2,290,'5a7ca5a3_f53b7836',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',290,2,290,'7a7fa997_9676cc05',NULL),(16,'2016-05-24 22:31:29','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',290,3,290,'da36d5c6_491a2119',NULL),(37,'2015-04-23 09:48:15','Patch Set 4:\n\n(4 comments)\n\nReally not happy with how this patch has been split up, or the API design.',291,4,291,'3a79b1b5_d440bc37',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',291,1,291,'3aa0d159_7ca679c3',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',291,3,291,'5a7ca5a3_75652844',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',291,4,291,'5a7ca5a3_95fb2447',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',291,2,291,'7a7fa997_b673c814',NULL),(16,'2016-05-24 22:31:35','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',291,4,291,'da36d5c6_6917e5ed',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',292,1,292,'3aa0d159_1cabb58a',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',292,3,292,'5a7ca5a3_155ab483',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',292,4,292,'5a7ca5a3_b5f8a04a',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',292,2,292,'7a7fa997_56603435',NULL),(16,'2016-05-24 22:31:46','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',292,4,292,'da36d5c6_89d25933',NULL),(37,'2015-04-27 10:41:45','Patch Set 4:\n\n(3 comments)\n\nIt looks like there was an error in splitting these patches up.',292,4,292,'dad5f5cf_b15e6011',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',293,1,293,'3aa0d159_3cb0f1f3',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',293,3,293,'5a7ca5a3_355fb074',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',293,4,293,'5a7ca5a3_55958ce2',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',293,2,293,'7a7fa997_76653044',NULL),(16,'2016-05-24 22:31:54','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',293,4,293,'da36d5c6_a9d71d22',NULL),(37,'2015-04-27 10:50:14','Patch Set 4:\n\nI\'d\'ve preferred a way that keeps the tarball artifact cache code working at the same time as adding the OSTree cache, so we could have people opt in to the new behaviour.',293,4,293,'dad5f5cf_519b74c9',NULL),(37,'2015-04-27 10:53:20','Patch Set 4:\n\nAgain, splitting the patches up this way, while on the surface appears to be useful as a way of making it easier to review by reducing the cognitive load, fails to achieve that goal, because the changes are not logically independent of each other.\n\nIn this case I have no idea if the API change has been replicated to all its users.',293,4,293,'dad5f5cf_71a0f8f4',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',294,1,294,'3aa0d159_dc946d46',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',294,4,294,'5a7ca5a3_759a0816',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',294,3,294,'5a7ca5a3_d553dc6a',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',294,2,294,'7a7fa997_165abc83',NULL),(16,'2016-05-24 22:32:00','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',294,4,294,'da36d5c6_c9dc5149',NULL),(37,'2015-04-27 11:03:21','Patch Set 4:\n\n(13 comments)',294,4,294,'dad5f5cf_f1d94884',NULL),(27,'2015-04-23 10:40:51','Patch Set 4: Code-Review+1',295,4,295,'3a79b1b5_549b4cc9',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',295,1,295,'3aa0d159_fc912953',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',295,4,295,'5a7ca5a3_159f1405',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',295,3,295,'5a7ca5a3_f5505860',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',295,2,295,'7a7fa997_365fb874',NULL),(27,'2015-04-20 11:37:23','Patch Set 1: Code-Review+1\n\nwhile I agree with th formatting comments already posted. i dont see how this can be a bad thing, even if it could be improved more. so it gets my +1 for as it is now.',295,1,295,'9a6a9dd7_7763f0b1',NULL),(16,'2016-05-24 22:32:05','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',295,4,295,'da36d5c6_e9e11500',NULL),(6,'2015-04-17 08:38:13','Patch Set 1:\n\n(1 comment)',295,1,295,'da7095c5_19098b2c',NULL),(37,'2015-04-27 15:12:54','Patch Set 4:\n\n(8 comments)',295,4,295,'dad5f5cf_d16c4439',NULL),(16,'2015-04-16 19:26:38','Patch Set 1:\n\n(1 comment)',295,1,295,'fa6b99d7_1ad17dcd',NULL),(6,'2015-04-16 16:37:38','Patch Set 1:\n\n(2 comments)',295,1,295,'fa6b99d7_5a1295b5',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',296,1,296,'3aa0d159_9c9ee562',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',296,4,296,'5a7ca5a3_35a49056',NULL),(16,'2015-04-22 13:47:20','Patch Set 2:\n\n(1 comment)',296,2,296,'5a7ca5a3_75bf68d1',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',296,3,296,'5a7ca5a3_954d64c7',NULL),(6,'2015-04-22 13:42:00','Patch Set 2:\n\n(1 comment)',296,2,296,'5a7ca5a3_f5e37803',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',296,2,296,'7a7fa997_d653e46a',NULL),(16,'2016-05-24 22:32:11','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',296,4,296,'da36d5c6_09e74913',NULL),(37,'2015-04-27 15:24:28','Patch Set 4:\n\n(2 comments)',296,4,296,'dad5f5cf_f1506860',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',297,1,297,'3aa0d159_bc9ba171',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',297,3,297,'5a7ca5a3_b54ae0aa',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',297,4,297,'5a7ca5a3_d588bcc8',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',297,2,297,'7a7fa997_f6506060',NULL),(16,'2016-05-24 22:32:18','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',297,4,297,'da36d5c6_29e40d0c',NULL),(37,'2015-04-27 15:40:23','Patch Set 4:\n\n(1 comment)',297,4,297,'dad5f5cf_11e88c7b',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',298,1,298,'3aa0d159_5c885d22',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',298,3,298,'5a7ca5a3_55c7cc12',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',298,4,298,'5a7ca5a3_f585b8ad',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',298,2,298,'7a7fa997_964d6cc7',NULL),(16,'2016-05-24 22:32:23','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',298,4,298,'da36d5c6_49f141cd',NULL),(37,'2015-04-27 16:32:17','Patch Set 4:\n\n(7 comments)',298,4,298,'dad5f5cf_3149108c',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',299,1,299,'3aa0d159_7c8d1931',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',299,3,299,'5a7ca5a3_75cc4836',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',299,4,299,'5a7ca5a3_959244f5',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',299,2,299,'7a7fa997_b64ae8aa',NULL),(16,'2016-05-24 22:32:29','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',299,4,299,'da36d5c6_69ee05ee',NULL),(37,'2015-04-27 16:42:28','Patch Set 4:\n\n(4 comments)',299,4,299,'dad5f5cf_7136b805',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',300,1,300,'3aa0d159_1c82d500',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',300,3,300,'5a7ca5a3_15d154cd',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',300,4,300,'5a7ca5a3_b58f40cc',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',300,2,300,'7a7fa997_56c7d412',NULL),(16,'2016-05-24 22:32:35','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',300,4,300,'da36d5c6_89b979ef',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',301,1,301,'3aa0d159_3c879111',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',301,3,301,'5a7ca5a3_35d6d0c6',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',301,4,301,'5a7ca5a3_55bcac6c',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',301,2,301,'7a7fa997_76cc5036',NULL),(16,'2016-05-24 22:32:43','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',301,4,301,'da36d5c6_a9be3dd2',NULL),(37,'2015-04-27 17:15:13','Patch Set 4:\n\n(2 comments)',301,4,301,'dad5f5cf_d10be429',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',302,1,302,'3aa0d159_dc7b0d28',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',302,4,302,'5a7ca5a3_75c1a8e3',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',302,3,302,'5a7ca5a3_d5dafce8',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',302,2,302,'7a7fa997_16d15ccd',NULL),(27,'2015-04-29 10:18:07','Patch Set 4: Code-Review+1\n\nthis looks fine to me. even given Richard Maw\'s question.',302,4,302,'bada0100_130c0e94',NULL),(16,'2015-04-28 13:56:31','Patch Set 4:\n\n(1 comment)',302,4,302,'bada0100_b0a9787d',NULL),(16,'2016-05-24 22:33:09','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',302,4,302,'da36d5c6_c9b37109',NULL),(37,'2015-04-27 17:20:57','Patch Set 4:\n\n(4 comments)',302,4,302,'dad5f5cf_74046615',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',303,1,303,'3aa0d159_fc78492d',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',303,4,303,'5a7ca5a3_15b6348b',NULL),(11,'2015-04-22 10:46:39','Patch Set 2: Code-Review+1',303,2,303,'5a7ca5a3_15f3940b',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',303,3,303,'5a7ca5a3_f5d7f8bd',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',303,2,303,'7a7fa997_36d6d8c6',NULL),(27,'2015-04-28 15:00:56','Patch Set 4: Code-Review+1',303,4,303,'bada0100_d0f75c8b',NULL),(16,'2016-05-24 22:33:30','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',303,4,303,'da36d5c6_e9b835e8',NULL),(37,'2015-04-27 17:21:32','Patch Set 4: Code-Review-2\n\nUnacceptable. It may be \"full of hacks\", but they\'re hacks we need.',303,4,303,'dad5f5cf_14095a2c',NULL),(37,'2015-04-27 17:23:03','Patch Set 4:\n\nI don\'t blame you for attempting this way given a lack of time, but it cannot be merged in this state, and this prevents the whole series being viable.',303,4,303,'dad5f5cf_340ede35',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',304,1,304,'3aa0d159_9c758534',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',304,4,304,'5a7ca5a3_35bb3074',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',304,3,304,'5a7ca5a3_95e484ad',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',304,2,304,'7a7fa997_d6da04e9',NULL),(37,'2015-04-28 09:46:46','Patch Set 4:\n\n(9 comments)',304,4,304,'bada0100_b047384b',NULL),(16,'2016-05-24 22:33:40','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',304,4,304,'da36d5c6_09ce6983',NULL),(6,'2015-04-17 14:32:48','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nI\'ve used \'morph convert-local-cache\' and it seems to work.',304,1,304,'da7095c5_19d18bcd',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',305,1,305,'3aa0d159_bc72c147',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',305,3,305,'5a7ca5a3_b5e1809c',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',305,4,305,'5a7ca5a3_d5af5c2a',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',305,2,305,'7a7fa997_f6d700be',NULL),(37,'2015-04-28 09:47:15','Patch Set 4:\n\nUgh, I\'d rather we converted these to yarns',305,4,305,'bada0100_5074cc9b',NULL),(27,'2015-04-29 11:27:32','Patch Set 4: Code-Review+1',305,4,305,'bada0100_53605635',NULL),(16,'2015-04-28 10:31:46','Patch Set 4:\n\n> Ugh, I\'d rather we converted these to yarns\n\nI tried converting the build-system-* tests to yarns when I was first looking at this, but found they failed because they needed (for example) `make` and other such tools. I didn\'t have time then to try and provide fake versions of all of these tools such that the tests passed.',305,4,305,'bada0100_f0ab80d4',NULL),(16,'2016-05-24 22:33:45','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',305,4,305,'da36d5c6_29cb2d74',NULL),(6,'2015-04-15 15:01:58','Patch Set 1:\n\nWe need to make it clear that performance will be dreadful now if \'cachedir\' is not on the same physical filesystem as \'tmpdir\'. Might be worth trying to create a hardlink from cachedir to tmpdir as a test, and assuming that if that doesn\'t work, OSTree will not be able to do hardlink clones, and warn the user their builds will be slower than they need to be. If there\'s no time for that, just make it clear in documentation (quick-start on the wiki, arm-howtos on the wiki, and maybe the builtin documentation of the tmpdir and cachedir settings).',306,1,306,'1a9dcd25_5b04e37d',NULL),(16,'2015-04-14 16:35:45','Uploaded patch set 1.',306,1,306,'3aa0d159_5c8ffd23',NULL),(11,'2015-04-22 10:44:54','Patch Set 2: Code-Review+1',306,2,306,'5a7ca5a3_55e90c19',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 3.',306,3,306,'5a7ca5a3_55eeec8c',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 4.',306,4,306,'5a7ca5a3_f5acd837',NULL),(11,'2015-04-21 16:56:38','Patch Set 1: Code-Review+1',306,1,306,'7a7fa997_368818e7',NULL),(16,'2015-04-21 16:53:25','Patch Set 1:\n\n(1 comment)',306,1,306,'7a7fa997_767e90e6',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 2.',306,2,306,'7a7fa997_96e48cad',NULL),(11,'2015-04-21 16:43:50','Patch Set 1:\n\n(1 comment)',306,1,306,'7a7fa997_d625240b',NULL),(6,'2015-04-28 10:52:54','Patch Set 4:\n\n> This is a significant regression in performance compared to\n > non-OSTree when we have separate cachedir and tempdir.\n > \n > The problem with the hardlink cache was that it lacked any\n > verification mechanism. Is it possible for us to clone the OSTree\n > repository on the tempdir if we detect that it is on a different\n > filesystem?\n\nIs there any reason to support separate cachedir and tempdir? I used to do this, so that I could have my cachedir in a /src mount that was backed by a slow (but useful) FUSE filesystem, and tempdir in a different, fast mount. Then I realised there was no benefit to having cachedir on the FUSE filesystem, so I made a separate, fast mount that could contain both tempdir and cachedir.\n\nWe do definitely need to help users configure their systems to avoid a big slowdown, though, at least by adding a warning to Morph if hardlinks between cachedir and tempdir aren\'t possible.\n\nI think duplicating the OStree repo would be a waste of disk space.\n\nThere are problems with the hardlink cache other than the corruption problems it introduced. It is a waste of diskspace to have duplicate copies unpacked chunk artifacts, and some are big (each gcc-devel is > 400MB). It makes \'morph gc\' less effective: often when I\'m low on diskspace, I find that \'morph gc\' deletes the chunk cache, then I run a build and the chunks get unpacked again, and almost the same amount of disk space disappears again. It is also just reimplementing what OSTree does.',306,4,306,'bada0100_3081084b',NULL),(27,'2015-04-29 16:30:34','Patch Set 4: Code-Review+1',306,4,306,'bada0100_363a6037',NULL),(37,'2015-04-28 10:02:06','Patch Set 4:\n\nThis is a significant regression in performance compared to non-OSTree when we have separate cachedir and tempdir.\n\nThe problem with the hardlink cache was that it lacked any verification mechanism. Is it possible for us to clone the OSTree repository on the tempdir if we detect that it is on a different filesystem?',306,4,306,'bada0100_7079d092',NULL),(16,'2016-05-24 22:33:50','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',306,4,306,'da36d5c6_49c86175',NULL),(27,'2015-04-15 09:33:16','Patch Set 1: Code-Review+1\n\nThis all looks good and sensible to me, cant spot anything off. +1',307,1,307,'1a9dcd25_1b573b04',NULL),(15,'2015-04-15 14:49:08','Patch Set 2:\n\nIf we plan to maintain this, can we add this system to our ci, please?',307,2,307,'1a9dcd25_1be73be6',NULL),(6,'2015-04-15 14:00:12','Patch Set 2:\n\n(1 comment)',307,2,307,'1a9dcd25_3b879711',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 2.',307,2,307,'1a9dcd25_3be23704',NULL),(7,'2015-04-15 17:21:28','Patch Set 3:\n\n> Uploaded patch set 3.\n\nAdded some comments in tempest.morph.',307,3,307,'1a9dcd25_7b68bff5',NULL),(7,'2015-04-15 15:22:20','Patch Set 2:\n\n> If we plan to maintain this, can we add this system to our ci,\n > please?\n\nIf we want to maintain this, that would be desirable, yes. :)',307,2,307,'1a9dcd25_7b7e7fe6',NULL),(34,'2015-04-15 13:57:47','Patch Set 2: Code-Review+1\n\n(1 comment)\n\ntl;dr: yeah, tempest chunk is bloated due to deadline',307,2,307,'1a9dcd25_7b8d1f31',NULL),(7,'2015-04-15 13:25:11','Patch Set 1:\n\n(4 comments)',307,1,307,'1a9dcd25_7bd8bf53',NULL),(15,'2015-04-15 11:24:55','Patch Set 1: Code-Review-1\n\n(2 comments)\n\nSome little comments before merging',307,1,307,'1a9dcd25_9be6eb43',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 3.',307,3,307,'1a9dcd25_bb8f27cc',NULL),(6,'2015-04-15 11:24:05','Patch Set 1: Code-Review+1\n\n(3 comments)\n\nI have a couple of comments about this one, although they can be fixed up later if need be',307,1,307,'1a9dcd25_fbd92f84',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',307,1,307,'3aa0d159_7c943937',NULL),(7,'2015-04-16 16:22:11','Patch Set 3: Code-Review+2\n\nMerging, all comments addressed.',307,3,307,'fa6b99d7_3a87a111',NULL),(7,'2015-04-16 16:23:14','Change has been successfully merged into the git repository.',307,4,307,'fa6b99d7_9a758d34',NULL),(6,'2015-04-16 09:29:49','Patch Set 3: Code-Review+1',307,3,307,'fa6b99d7_bae3b132',NULL),(7,'2015-04-16 16:23:04','Patch Set 4: Patch Set 3 was rebased',307,3,307,'fa6b99d7_da7b0528',NULL),(7,'2015-04-16 16:23:12','Patch Set 4: Code-Review+2',307,4,307,'fa6b99d7_fa78492d',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 5.',308,5,308,'1a9dcd25_1b6dfb04',NULL),(8,'2015-04-15 14:51:24','Patch Set 2:\n\n> (1 comment)\n > \n > It would be useful for reviewers to have a git repository and ref\n > that these default configuration files came from, so we can check\n > for any changes.\n\nTrue, the repositories are multiple, all of them from g.b.o (cinder, neutron, glance, nova...) except nova.conf which comes from http://pkgs.fedoraproject.org/cgit/openstack-nova.git/tree/nova.conf.sample\nThe tag of these repos are 2014.2.1.\nSorry to not provide this information - maybe is worth to add it to the commit message',308,2,308,'1a9dcd25_3bec77c7',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 3.',308,3,308,'1a9dcd25_5b2b83eb',NULL),(7,'2015-04-15 15:21:07','Patch Set 2:\n\n> (2 comments)\n\nFiles removed in the new version',308,2,308,'1a9dcd25_5b7943fb',NULL),(8,'2015-04-15 14:45:38','Patch Set 2:\n\n(1 comment)',308,2,308,'1a9dcd25_5bddc313',NULL),(19,'2015-04-15 14:23:09','Patch Set 2:\n\n(1 comment)\n\nIt would be useful for reviewers to have a git repository and ref that these default configuration files came from, so we can check for any changes.',308,2,308,'1a9dcd25_7bbbdfc4',NULL),(8,'2015-04-15 14:52:50','Patch Set 2: Code-Review-1\n\n(2 comments)',308,2,308,'1a9dcd25_9bda6b16',NULL),(8,'2015-04-15 16:41:23','Patch Set 4: Commit message was updated',308,4,308,'1a9dcd25_9bfb4b47',NULL),(15,'2015-04-15 11:16:54','Patch Set 1: Code-Review+1',308,1,308,'1a9dcd25_bb8c0781',NULL),(6,'2015-04-15 11:04:12','Patch Set 1:\n\nI wonder if these might be better in a separate openstack-specific Git repo, actually. But it\'s not a huge amount of stuff, definitions.git is still smaller than linux.git :)',308,1,308,'1a9dcd25_bbb5e732',NULL),(19,'2015-04-15 14:45:23','Patch Set 2: Code-Review+1\n\nAssuming these are all defaults copied from OpenStack directly, so no objections.',308,2,308,'1a9dcd25_bbc0872b',NULL),(15,'2015-04-15 14:15:45','Patch Set 2: Code-Review+1',308,2,308,'1a9dcd25_dba2339a',NULL),(6,'2015-04-15 11:01:41','Patch Set 1: Code-Review+2\n\nI\'m happy for this to be merged as-is, it can\'t interfere with anything already in the Baserock reference system definitions.',308,1,308,'1a9dcd25_dbaeb3e7',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 2.',308,2,308,'1a9dcd25_dbe6b316',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',308,1,308,'3aa0d159_1c99756e',NULL),(7,'2015-04-16 16:23:48','Patch Set 6: Code-Review+2',308,6,308,'fa6b99d7_1a997d6e',NULL),(7,'2015-04-16 16:23:50','Change has been successfully merged into the git repository.',308,6,308,'fa6b99d7_3a9ec157',NULL),(7,'2015-04-16 16:23:41','Patch Set 5:\n\nMerging, all comments addressed.',308,5,308,'fa6b99d7_5a8ff523',NULL),(7,'2015-04-16 16:23:46','Patch Set 6: Patch Set 5 was rebased',308,5,308,'fa6b99d7_7a943937',NULL),(6,'2015-04-16 09:30:57','Patch Set 5: Code-Review+1',308,5,308,'fa6b99d7_7ad51942',NULL),(7,'2015-04-16 16:23:33','Patch Set 5: Code-Review+2',308,5,308,'fa6b99d7_ba72d147',NULL),(27,'2015-04-16 09:52:49','Patch Set 5: Code-Review+1\n\nsounds good to me!',308,5,308,'fa6b99d7_dac30589',NULL),(6,'2015-04-15 11:10:47','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThis looks fine at a glance, and won\'t interfere with any existing stuff in the Baserock reference systems.',309,1,309,'1a9dcd25_1b7c1b72',NULL),(19,'2015-04-15 15:09:13','Patch Set 2: Code-Review+1',309,2,309,'1a9dcd25_1bfe5b6c',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 5.',309,5,309,'1a9dcd25_3b7237e6',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 4.',309,4,309,'1a9dcd25_5bbce36c',NULL),(15,'2015-04-15 12:08:51','Patch Set 1:\n\nthe same comment than previous commits: IS openstack/usr/share/openstack/keystone/keystone.conf autogenerated in some way?',309,1,309,'1a9dcd25_7b0affd3',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 3.',309,3,309,'1a9dcd25_7b30bf56',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 2.',309,2,309,'1a9dcd25_fbe36f03',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',309,1,309,'3aa0d159_3c9eb157',NULL),(6,'2015-04-16 09:31:10','Patch Set 5: Code-Review+1',309,5,309,'fa6b99d7_1acadda1',NULL),(15,'2015-04-16 11:17:40','Patch Set 6: Code-Review-1\n\n(Note, this is only to note a concern, it can be fixed later so don\'t block on this for your openstack work)\n\nI think in general .service files should be in the morphology file (stratum/databases/postgress.morph for example) as they are useful for any user, not only the ones that build openstack',309,6,309,'fa6b99d7_3a1481f4',NULL),(7,'2015-04-16 12:06:03','Patch Set 6:\n\n> (Note, this is only to note a concern, it can be fixed later so\n > don\'t block on this for your openstack work)\n > \n > I think in general .service files should be in the morphology file\n > (stratum/databases/postgress.morph for example) as they are useful\n > for any user, not only the ones that build openstack\n\nI\'m aware of that, and I actually have the same opinion. I will do that for postgresql and other services, but in a separate patch series. :)',309,6,309,'fa6b99d7_3a2b2132',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 6.',309,6,309,'fa6b99d7_9a54adcb',NULL),(7,'2015-04-16 16:24:32','Change has been successfully merged into the git repository.',309,7,309,'fa6b99d7_9aacad8e',NULL),(7,'2015-04-16 16:24:21','Patch Set 7: Patch Set 6 was rebased',309,6,309,'fa6b99d7_daa2259a',NULL),(7,'2015-04-16 16:24:29','Patch Set 7: Code-Review+2\n\nMerging, all comments addressed.',309,7,309,'fa6b99d7_fa9fe94e',NULL),(7,'2015-04-15 13:00:25','Patch Set 1:\n\n> Are the openstack/usr/share/openstack/glance/*.conf autogenerated?\n \nNope, they are being copied from the upstream repo.\n\n > (they look very diferent from http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/oslo-config-generator/glance-scrubber.conf)\n \nYou should be looking at this one: http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/glance-scrubber.conf\n\n > If yes, wouldnt be better to autogenerate them in some way?\n\nIn some components, openstack is starting to stop providing default configuration files, and just provide scripts to autogenerate a default one. But given that we need to modify them to add some placeholders that will be modified by the setup scripts, we can\'t use the autogenerated defaults.',310,1,310,'1a9dcd25_1b265b69',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 3.',310,3,310,'1a9dcd25_1b35fb45',NULL),(6,'2015-04-15 11:12:27','Patch Set 1: Code-Review+1\n\nThis looks fine at a glance, and won\'t interfere with any existing stuff in the Baserock reference systems.',310,1,310,'1a9dcd25_3b81d74a',NULL),(15,'2015-04-15 12:07:51','Patch Set 1: Code-Review-1\n\nAre the openstack/usr/share/openstack/glance/*.conf autogenerated? \n\n(they look very diferent from http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/oslo-config-generator/glance-scrubber.conf)\n\nIf yes, wouldnt be better to autogenerate them in some way?',310,1,310,'1a9dcd25_5b05c3c0',NULL),(15,'2015-04-15 13:41:32','Patch Set 1:\n\n> > Are the openstack/usr/share/openstack/glance/*.conf\n > autogenerated?\n > \n > Nope, they are being copied from the upstream repo.\n > \n > > (they look very diferent from http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/oslo-config-generator/glance-scrubber.conf)\n > \n > You should be looking at this one: http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/glance-scrubber.conf\n > \n > > If yes, wouldnt be better to autogenerate them in some way?\n > \n > In some components, openstack is starting to stop providing default\n > configuration files, and just provide scripts to autogenerate a\n > default one. But given that we need to modify them to add some\n > placeholders that will be modified by the setup scripts, we can\'t\n > use the autogenerated defaults.\n\nIf you need to do that Id say you should patch those scripts then, and use the script to generate the configuration we need.\nIMHO, If not is going to be very difficult to keep all those configuration files up-to-date with new version of the components',310,1,310,'1a9dcd25_7ba67fc3',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 4.',310,4,310,'1a9dcd25_7bc19fe3',NULL),(7,'2015-04-15 13:39:49','Patch Set 2:\n\n(1 comment)',310,2,310,'1a9dcd25_9bc7cb64',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 2.',310,2,310,'1a9dcd25_9bf02bcb',NULL),(15,'2015-04-15 14:20:24','Patch Set 2: Code-Review-1\n\n> > > Are the openstack/usr/share/openstack/glance/*.conf\n > > autogenerated?\n > >\n > > Nope, they are being copied from the upstream repo.\n > >\n > > > (they look very diferent from http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/oslo-config-generator/glance-scrubber.conf)\n > >\n > > You should be looking at this one: http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/glance.git/tree/etc/glance-scrubber.conf\n > >\n > > > If yes, wouldnt be better to autogenerate them in some way?\n > >\n > > In some components, openstack is starting to stop providing\n > default\n > > configuration files, and just provide scripts to autogenerate a\n > > default one. But given that we need to modify them to add some\n > > placeholders that will be modified by the setup scripts, we can\'t\n > > use the autogenerated defaults.\n > \n > If you need to do that Id say you should patch those scripts then,\n > and use the script to generate the configuration we need.\n > IMHO, If not is going to be very difficult to keep all those\n > configuration files up-to-date with new version of the components\n\nI guess one idea is to check how other openstack instances personalize the configuration files',310,2,310,'1a9dcd25_bba9677d',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 5.',310,5,310,'1a9dcd25_db76b3d8',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',310,1,310,'3aa0d159_dca22d9a',NULL),(27,'2015-04-16 14:15:06','Patch Set 6: Code-Review+1\n\nCant see anything wrong with it.',310,6,310,'fa6b99d7_3ab9e1e9',NULL),(6,'2015-04-16 09:31:33','Patch Set 5: Code-Review+1',310,5,310,'fa6b99d7_3acfa1b2',NULL),(7,'2015-04-16 16:25:24','Patch Set 7: Code-Review+2\n\nMerging, all comments addressed.',310,7,310,'fa6b99d7_5ab615de',NULL),(7,'2015-04-16 16:25:25','Change has been successfully merged into the git repository.',310,7,310,'fa6b99d7_7abbd9c4',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 6.',310,6,310,'fa6b99d7_ba5171da',NULL),(7,'2015-04-16 16:25:12','Patch Set 7: Patch Set 6 was rebased',310,6,310,'fa6b99d7_baa9717d',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 5.',311,5,311,'1a9dcd25_1bb65b8b',NULL),(6,'2015-04-15 11:28:45','Patch Set 2: Code-Review+1\n\nLooks fine at a glance, and won\'t interfere with any existing Baserock reference systems.',311,2,311,'1a9dcd25_1bcadba1',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 4.',311,4,311,'1a9dcd25_3b3a3737',NULL),(15,'2015-04-15 11:30:21','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks ok (only a little comment inline), agree with Sam that it will not affect other baserock systems',311,2,311,'1a9dcd25_3bcf97b2',NULL),(15,'2015-04-15 14:47:35','Patch Set 3: Code-Review+1\n\nI will change to +1, the copyright year is not that important and can be fixed at merge time',311,3,311,'1a9dcd25_7be2ffd6',NULL),(15,'2015-04-15 14:18:01','Patch Set 3: Code-Review-1\n\n(1 comment)',311,3,311,'1a9dcd25_9bacab8e',NULL),(7,'2015-04-15 09:52:29','Patch Set 2:\n\n> Uploaded patch set 2.\n\nFixed error in openstack-cinder.configure',311,2,311,'1a9dcd25_bb47274b',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 3.',311,3,311,'1a9dcd25_bbede7f1',NULL),(7,'2015-04-15 09:17:33','Uploaded patch set 2.',311,2,311,'1a9dcd25_db39d3d9',NULL),(8,'2015-04-15 14:33:53','Patch Set 3:\n\n(1 comment)',311,3,311,'1a9dcd25_dbc9d35b',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 6.',311,6,311,'1a9dcd25_fb736fe5',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',311,1,311,'3aa0d159_fc9fe94e',NULL),(7,'2015-04-16 16:25:42','Patch Set 8: Patch Set 7 was rebased',311,7,311,'fa6b99d7_1ab09ddc',NULL),(7,'2015-04-16 16:25:49','Patch Set 8: Code-Review+2\n\nMerging, all comments addressed.',311,8,311,'fa6b99d7_3ab561cd',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 7.',311,7,311,'fa6b99d7_5a5e15eb',NULL),(7,'2015-04-16 16:25:53','Change has been successfully merged into the git repository.',311,8,311,'fa6b99d7_dac9c55b',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 5.',312,5,312,'1a9dcd25_3bbb1774',NULL),(7,'2015-04-15 13:40:36','Patch Set 3:\n\n(1 comment)',312,3,312,'1a9dcd25_5ba143a8',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 3.',312,3,312,'1a9dcd25_5bbaa3e2',NULL),(15,'2015-04-15 12:00:57','Patch Set 2: Code-Review-1\n\nReading http://git.baserock.org/cgi-bin/cgit.cgi/delta/openstack/nova.git/tree/etc/nova/README-nova.conf.txt , seems nova.conf is a generated file.\n\nShouldnt be a way to regenerate it instead hardcode it in the openstack/usr/share/openstack/nova/nova.conf ?',312,2,312,'1a9dcd25_9b6b4b85',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 6.',312,6,312,'1a9dcd25_9b802b8d',NULL),(6,'2015-04-15 11:15:20','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nThis looks fine at a glance, and won\'t interfere with any existing stuff in the Baserock reference systems. I\'m very impressed with how clean these patches are so far!',312,2,312,'1a9dcd25_9b8fcb75',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 4.',312,4,312,'1a9dcd25_db3eb329',NULL),(7,'2015-04-15 09:17:33','Uploaded patch set 2.',312,2,312,'1a9dcd25_fb360fe7',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',312,1,312,'3aa0d159_9caca58e',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 7.',312,7,312,'fa6b99d7_7a63d9b1',NULL),(27,'2015-04-16 13:23:08','Patch Set 7: Code-Review+1',312,7,312,'fa6b99d7_7ad8b953',NULL),(7,'2015-04-16 16:26:19','Patch Set 8: Code-Review+2\n\nMerging, all comments addressed.',312,8,312,'fa6b99d7_9ac34d38',NULL),(7,'2015-04-16 16:26:21','Change has been successfully merged into the git repository.',312,8,312,'fa6b99d7_bac0912b',NULL),(7,'2015-04-16 16:26:06','Patch Set 8: Patch Set 7 was rebased',312,7,312,'fa6b99d7_fac60949',NULL),(15,'2015-04-15 12:14:32','Patch Set 3: Code-Review+1',313,3,313,'1a9dcd25_1b0f3be3',NULL),(7,'2015-04-15 09:50:04','Uploaded patch set 3.',313,3,313,'1a9dcd25_3b5c7725',NULL),(7,'2015-04-15 09:54:49','Patch Set 3:\n\n> Uploaded patch set 3.\n\nSimplified network setup to avoid network loops',313,3,313,'1a9dcd25_5b74e39b',NULL),(7,'2015-04-15 14:03:00','Patch Set 5:\n\n> Uploaded patch set 5.\n\nI merged in this change some changes from Richard Ipsum: https://gerrit.baserock.org/#/c/328/',313,5,313,'1a9dcd25_5b8f0324',NULL),(27,'2015-04-15 14:11:49','Patch Set 5: Code-Review+1\n\ndoes not break anything it seems.',313,5,313,'1a9dcd25_7b943f37',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 4.',313,4,313,'1a9dcd25_7bbf5fd1',NULL),(7,'2015-04-15 09:17:33','Uploaded patch set 2.',313,2,313,'1a9dcd25_9b334bf6',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 8.',313,8,313,'1a9dcd25_bb7de7b3',NULL),(19,'2015-04-15 16:02:46','Patch Set 6: Code-Review+1',313,6,313,'1a9dcd25_db53136b',NULL),(7,'2015-04-15 14:00:47','Uploaded patch set 5.',313,5,313,'1a9dcd25_db7b1328',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 7.',313,7,313,'1a9dcd25_dbaf932a',NULL),(6,'2015-04-15 11:30:45','Patch Set 3: Code-Review+1\n\nLooks fine at a glance, and won\'t interfere with any existing Baserock reference systems.',313,3,313,'1a9dcd25_dbc31389',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 6.',313,6,313,'1a9dcd25_fb3b6f36',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',313,1,313,'3aa0d159_bca9617d',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 9.',313,9,313,'fa6b99d7_1a589df9',NULL),(7,'2015-04-16 16:26:54','Change has been successfully merged into the git repository.',313,11,313,'fa6b99d7_1ae73de6',NULL),(7,'2015-04-16 16:26:38','Patch Set 11: Patch Set 10 was rebased',313,10,313,'fa6b99d7_5addb513',NULL),(7,'2015-04-16 16:26:52','Patch Set 11: Code-Review+2\n\nMerging, all comments addressed.',313,11,313,'fa6b99d7_7ae2f9d6',NULL),(29,'2015-04-16 11:42:07','Patch Set 9:\n\n(1 comment)',313,9,313,'fa6b99d7_9a026db3',NULL),(29,'2015-04-16 15:32:14','Patch Set 10: Code-Review+1',313,10,313,'fa6b99d7_9a9eed62',NULL),(7,'2015-04-16 14:11:31','Uploaded patch set 10.',313,10,313,'fa6b99d7_9af02dcb',NULL),(7,'2015-04-16 14:18:22','Topic changed from baserock/openstack-in-baserock2 to baserock/openstack-in-baserock',313,10,313,'fa6b99d7_bac41160',NULL),(29,'2015-04-16 11:42:19','Patch Set 9: Code-Review-1',313,9,313,'fa6b99d7_baff31aa',NULL),(27,'2015-04-16 11:21:12','Patch Set 9: Code-Review+1',313,9,313,'fa6b99d7_daf8e5c6',NULL),(7,'2015-04-16 14:05:50','Patch Set 9:\n\n(1 comment)',313,9,313,'fa6b99d7_fae36903',NULL),(15,'2015-04-15 11:53:32','Patch Set 3: Code-Review-1\n\n(1 comment)\n\nShould we overwrite the /etc/sysctl.conf file?',314,3,314,'1a9dcd25_1b589bf9',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 4.',314,4,314,'1a9dcd25_1bb41bf1',NULL),(8,'2015-04-15 16:12:26','Patch Set 6:\n\n(1 comment)',314,6,314,'1a9dcd25_3bd6b7c6',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 8.',314,8,314,'1a9dcd25_5b4aa384',NULL),(15,'2015-04-15 14:22:15','Patch Set 5: Code-Review-1\n\nseems the change to overwrite etc/sysctl.conf was not made',314,5,314,'1a9dcd25_5bb623de',NULL),(7,'2015-04-15 15:06:25','Patch Set 5:\n\n> seems the change to overwrite etc/sysctl.conf was not made\n\nThanks for pointing that out, too many patches :)',314,5,314,'1a9dcd25_7b099f94',NULL),(7,'2015-04-15 09:55:54','Patch Set 3:\n\n> Uploaded patch set 3.\n\nChanged ml2_conf.ini to match changes in the networking setup.',314,3,314,'1a9dcd25_7b799f92',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 6.',314,6,314,'1a9dcd25_9b482bce',NULL),(6,'2015-04-15 11:32:43','Patch Set 3: Code-Review+1\n\nLooks fine at a glance, and won\'t interfere with any existing Baserock reference systems.',314,3,314,'1a9dcd25_9bbd8b05',NULL),(7,'2015-04-15 09:17:33','Uploaded patch set 2.',314,2,314,'1a9dcd25_bb3087e9',NULL),(19,'2015-04-15 16:06:53','Patch Set 6:\n\n(1 comment)\n\nOne suspicious commented-out line in ml2_conf.ini, otherwise looks good',314,6,314,'1a9dcd25_bb4ac7aa',NULL),(7,'2015-04-15 13:01:19','Patch Set 3:\n\n(1 comment)',314,3,314,'1a9dcd25_db1f9308',NULL),(7,'2015-04-15 09:50:04','Uploaded patch set 3.',314,3,314,'1a9dcd25_db40f337',NULL),(7,'2015-04-15 15:19:16','Patch Set 6:\n\n> Uploaded patch set 6.\n\nApplied suggestions from Javier regarding sysctl.conf',314,6,314,'1a9dcd25_fb228f00',NULL),(7,'2015-04-15 14:00:47','Uploaded patch set 5.',314,5,314,'1a9dcd25_fb784f2d',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 7.',314,7,314,'1a9dcd25_fbaccf37',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',314,1,314,'3aa0d159_5cb61dde',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 9.',314,9,314,'fa6b99d7_3a5d61ea',NULL),(7,'2015-04-16 16:28:13','Patch Set 11: Patch Set 10 was rebased',314,10,314,'fa6b99d7_3aec81c7',NULL),(27,'2015-04-16 11:01:09','Patch Set 9: Code-Review+1',314,9,314,'fa6b99d7_9a6b4d85',NULL),(7,'2015-04-16 14:18:13','Topic changed from baserock/openstack-in-baserock2 to baserock/openstack-in-baserock',314,10,314,'fa6b99d7_9ac7cd64',NULL),(7,'2015-04-16 14:11:31','Uploaded patch set 10.',314,10,314,'fa6b99d7_baedf1f1',NULL),(7,'2015-04-16 16:28:21','Patch Set 11: Code-Review+2\n\nMerging, all comments addressed.',314,11,314,'fa6b99d7_dad0e5f9',NULL),(7,'2015-04-16 16:28:23','Change has been successfully merged into the git repository.',314,11,314,'fa6b99d7_facda95e',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 4.',315,4,315,'1a9dcd25_3bb9d7e9',NULL),(7,'2015-04-15 09:17:33','Uploaded patch set 2.',315,2,315,'1a9dcd25_5b4dc371',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 8.',315,8,315,'1a9dcd25_7b4f5f93',NULL),(8,'2015-04-15 12:32:14','Patch Set 3:\n\n(1 comment)',315,3,315,'1a9dcd25_9b026bb3',NULL),(7,'2015-04-15 14:00:47','Uploaded patch set 5.',315,5,315,'1a9dcd25_9b758b34',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 7.',315,7,315,'1a9dcd25_9ba90b27',NULL),(19,'2015-04-15 16:30:27','Patch Set 6: Code-Review+1',315,6,315,'1a9dcd25_9be4abad',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 6.',315,6,315,'1a9dcd25_bb45e7b4',NULL),(6,'2015-04-15 11:26:15','Patch Set 3: Code-Review+1\n\nLooks fine at a glance, and won\'t interfere with any existing Baserock reference systems. I\'m surprised how few files there are needed for Horizon to be honest !',315,3,315,'1a9dcd25_bbe3a732',NULL),(15,'2015-04-15 12:19:17','Patch Set 3: Code-Review-1\n\n(1 comment)\n\nA little comment about a license issue',315,3,315,'1a9dcd25_dbf8f3c6',NULL),(7,'2015-04-15 09:50:04','Uploaded patch set 3.',315,3,315,'1a9dcd25_fb3dafbc',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',315,1,315,'3aa0d159_7cbbd9c4',NULL),(29,'2015-04-16 11:56:05','Patch Set 9: Code-Review-1\n\n(2 comments)\n\nI have a note about the use of network-online.target\nbut feel free to leave it as it is.',315,9,315,'fa6b99d7_1a265d69',NULL),(7,'2015-04-16 16:28:44','Change has been successfully merged into the git repository.',315,11,315,'fa6b99d7_5a04d57d',NULL),(27,'2015-04-16 11:07:56','Patch Set 9: Code-Review+1',315,9,315,'fa6b99d7_5a05b5c0',NULL),(27,'2015-04-16 10:16:55','Patch Set 8: Code-Review+1\n\nlooks good to me.',315,8,315,'fa6b99d7_5a37f5b0',NULL),(7,'2015-04-16 14:11:31','Uploaded patch set 10.',315,10,315,'fa6b99d7_5aba95e2',NULL),(7,'2015-04-16 16:28:31','Patch Set 11: Patch Set 10 was rebased',315,10,315,'fa6b99d7_9ada6d16',NULL),(29,'2015-04-16 15:37:36','Patch Set 10: Code-Review+1',315,10,315,'fa6b99d7_ba9bb171',NULL),(7,'2015-04-16 16:28:41','Patch Set 11: Code-Review+2\n\nMerging, all comments addressed.',315,11,315,'fa6b99d7_bad731ed',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 9.',315,9,315,'fa6b99d7_da71c578',NULL),(7,'2015-04-16 14:18:06','Topic changed from baserock/openstack-in-baserock2 to baserock/openstack-in-baserock',315,10,315,'fa6b99d7_faca896d',NULL),(7,'2015-04-15 17:23:41','Uploaded patch set 8.',316,8,316,'1a9dcd25_1b441b73',NULL),(15,'2015-04-15 14:12:18','Patch Set 5: Code-Review+1',316,5,316,'1a9dcd25_1b997b6e',NULL),(27,'2015-04-15 14:27:24','Patch Set 5: Code-Review+1\n\nTested working.',316,5,316,'1a9dcd25_1bb09bdc',NULL),(7,'2015-04-15 15:17:03','Uploaded patch set 6.',316,6,316,'1a9dcd25_5b12a3b5',NULL),(7,'2015-04-15 09:17:33','Uploaded patch set 2.',316,2,316,'1a9dcd25_7b52ff14',NULL),(6,'2015-04-15 11:27:31','Patch Set 3: Code-Review+1\n\nLooks pretty readable given how many services are involved, nice work on not requiring the user to specify loads of unnecessary default values.',316,3,316,'1a9dcd25_7bd51f42',NULL),(19,'2015-04-15 16:36:18','Patch Set 6: Code-Review+1',316,6,316,'1a9dcd25_7bf3df73',NULL),(7,'2015-04-15 09:50:04','Uploaded patch set 3.',316,3,316,'1a9dcd25_9b4a6b54',NULL),(7,'2015-04-15 14:00:47','Uploaded patch set 5.',316,5,316,'1a9dcd25_bb72c747',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 7.',316,7,316,'1a9dcd25_bba64752',NULL),(7,'2015-04-15 13:47:15','Patch Set 4:\n\n(1 comment)',316,4,316,'1a9dcd25_db947346',NULL),(7,'2015-04-15 13:36:02','Uploaded patch set 4.',316,4,316,'1a9dcd25_dbcd5388',NULL),(15,'2015-04-15 11:31:52','Patch Set 3: Code-Review+1\n\nLooks good, very nice documented as well, good work!',316,3,316,'1a9dcd25_fbc04f7e',NULL),(7,'2015-04-14 16:54:48','Uploaded patch set 1.',316,1,316,'3aa0d159_1cb095dc',NULL),(7,'2015-04-16 16:29:26','Patch Set 11: Code-Review+2\n\nMerging, all comments addressed.',316,11,316,'fa6b99d7_1afe5d6c',NULL),(7,'2015-04-16 16:29:28','Change has been successfully merged into the git repository.',316,11,316,'fa6b99d7_3a032175',NULL),(7,'2015-04-16 16:28:56','Patch Set 11: Patch Set 10 was rebased',316,10,316,'fa6b99d7_7a099994',NULL),(7,'2015-04-16 14:11:31','Uploaded patch set 10.',316,10,316,'fa6b99d7_7abf59d1',NULL),(27,'2015-04-16 11:03:11','Patch Set 9: Code-Review+1',316,9,316,'fa6b99d7_ba689188',NULL),(7,'2015-04-16 14:18:00','Topic changed from baserock/openstack-in-baserock2 to baserock/openstack-in-baserock',316,10,316,'fa6b99d7_dacd4588',NULL),(7,'2015-04-16 10:39:36','Uploaded patch set 9.',316,9,316,'fa6b99d7_fa6e0996',NULL),(27,'2015-04-16 09:56:00','Patch Set 8: Code-Review+1',316,8,316,'fa6b99d7_fac0497e',NULL),(8,'2015-04-15 08:37:48','Patch Set 1: Code-Review+1',317,1,317,'1a9dcd25_5bff0302',NULL),(6,'2015-04-14 17:08:38','Uploaded patch set 1.',317,1,317,'3aa0d159_3cb551cd',NULL),(7,'2015-04-21 09:27:18','Change has been successfully rebased as 40c9378496c4b195fc1260ed355b801fe5e380ed',317,1,317,'7a7fa997_56e91419',NULL),(7,'2015-04-21 09:27:16','Patch Set 1: Code-Review+2',317,1,317,'7a7fa997_968fac75',NULL),(7,'2015-04-21 09:27:18','Patch Set 2: Patch Set 1 was rebased',317,1,317,'7a7fa997_b68c2881',NULL),(16,'2015-04-21 09:26:26','Patch Set 1: Code-Review+1',317,1,317,'7a7fa997_f692a09e',NULL),(26,'2015-04-14 17:31:24','Uploaded patch set 1.',318,1,318,'3aa0d159_dcc9cd5b',NULL),(26,'2015-04-19 09:16:02','Abandoned\n\nReplaced with a new series which maintains commit history',318,1,318,'ba65a107_78044115',NULL),(8,'2015-04-16 09:30:56','Patch Set 1: Code-Review+1',318,1,318,'fa6b99d7_5ad05553',NULL),(26,'2015-04-16 09:59:24','Patch Set 1: Code-Review-1\n\nI\'ll rework this to maintain an equivalent commit history to the other BSPs',318,1,318,'fa6b99d7_9abd8d05',NULL),(8,'2015-04-16 10:01:19','Patch Set 1: -Code-Review\n\nChange my vote then, I will wait for the next series',318,1,318,'fa6b99d7_babad108',NULL),(7,'2015-04-15 10:12:44','Patch Set 1: Code-Review+1',319,1,319,'1a9dcd25_1b6e5bca',NULL),(8,'2015-04-15 10:22:11','Patch Set 1: Code-Review+2',319,1,319,'1a9dcd25_3b7317b3',NULL),(8,'2015-04-15 10:22:15','Patch Set 2: Patch Set 1 was rebased',319,1,319,'1a9dcd25_db6793e9',NULL),(8,'2015-04-15 10:22:16','Change has been successfully rebased as ba804d367743d9bfee7380707c80d00b9dafc303',319,1,319,'1a9dcd25_fb64cfe6',NULL),(29,'2015-04-14 21:48:24','Uploaded patch set 1.',319,1,319,'3aa0d159_9cc34538',NULL),(15,'2015-04-14 22:40:08','Patch Set 1: Code-Review+1',319,1,319,'3aa0d159_fccda95e',NULL),(7,'2015-04-15 18:53:20','Patch Set 3: Code-Review+1',320,3,320,'1a9dcd25_1b12db62',NULL),(29,'2015-04-15 17:54:45','Uploaded patch set 2.',320,2,320,'1a9dcd25_9b57cb26',NULL),(15,'2015-04-15 21:58:32','Patch Set 3: Code-Review+1',320,3,320,'1a9dcd25_9e1c996c',NULL),(29,'2015-04-15 10:42:10','Patch Set 1: Code-Review-1\n\n(1 comment)',320,1,320,'1a9dcd25_bb5e4711',NULL),(29,'2015-04-15 17:57:08','Patch Set 3: Commit message was updated',320,3,320,'1a9dcd25_db2473c8',NULL),(29,'2015-04-14 21:48:24','Uploaded patch set 1.',320,1,320,'3aa0d159_bcc0812b',NULL),(29,'2015-04-16 09:23:02','Patch Set 4: Patch Set 3 was rebased',320,3,320,'fa6b99d7_1aa5fd03',NULL),(29,'2015-04-16 09:24:05','Patch Set 4: Code-Review+2',320,4,320,'fa6b99d7_3aaa41d5',NULL),(29,'2015-04-16 09:22:32','Patch Set 3: Code-Review+2',320,3,320,'fa6b99d7_5a9b75c9',NULL),(NULL,'2015-04-16 09:22:36','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I9840f6b4, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',320,3,320,'fa6b99d7_7aa0b9f4',NULL),(29,'2015-04-16 09:24:10','Change has been successfully merged into the git repository.',320,4,320,'fa6b99d7_daaea5e7',NULL),(29,'2015-04-15 17:56:03','Patch Set 2: -Code-Review\n\nsubmitted v2 (removing veto)',321,2,321,'1a9dcd25_3b40f755',NULL),(15,'2015-04-15 22:14:11','Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI think this can still be improved\n\nAnd also, taking in account my comment, would it be a terrible idea to avoid the configure extension and simply put the unit file in the chunk morph file?',321,2,321,'1a9dcd25_5e2611bc',NULL),(29,'2015-04-15 17:18:56','Patch Set 1: Code-Review-2',321,1,321,'1a9dcd25_9b926bf5',NULL),(29,'2015-04-15 17:54:45','Uploaded patch set 2.',321,2,321,'1a9dcd25_bb540722',NULL),(29,'2015-04-15 12:02:40','Patch Set 1:\n\n> > (3 comments)\n > >\n > > I wonder if the ntpd systemd service files should go in the ntpd\n > > chunk instead create a ntpd.configure extension\n > \n > That would make it harder to update NTP in future, as we wouldn\'t\n > be able to consume the upstream commits directly. Ideally the\n > systemd files would be shipped in the upstream ntpd repo. For now I\n > think it\'s fine for us to create them at deploy-time.\n > \n > I\'m happy for this to be merged once the comments of others are\n > resolved.\n\nI agree with your comment, could go in the chunk, but\nputting this in the conf ext means we have no delta on upstream',321,1,321,'1a9dcd25_bb688788',NULL),(19,'2015-04-15 13:52:58','Patch Set 1: Code-Review+1\n\n(2 comments)',321,1,321,'1a9dcd25_bb9ba771',NULL),(15,'2015-04-15 14:55:28','Patch Set 1:\n\n> > > (3 comments)\n > > >\n > > > I wonder if the ntpd systemd service files should go in the\n > ntpd\n > > > chunk instead create a ntpd.configure extension\n > >\n > > That would make it harder to update NTP in future, as we wouldn\'t\n > > be able to consume the upstream commits directly. Ideally the\n > > systemd files would be shipped in the upstream ntpd repo. For now\n > I\n > > think it\'s fine for us to create them at deploy-time.\n > >\n > > I\'m happy for this to be merged once the comments of others are\n > > resolved.\n > \n > I agree with your comment, could go in the chunk, but\n > putting this in the conf ext means we have no delta on upstream\n\nsorry, I meant in the morphology file, not in the chunk itself.',321,1,321,'1a9dcd25_bbd727ed',NULL),(6,'2015-04-15 11:42:41','Patch Set 1: Code-Review+1\n\n> (3 comments)\n > \n > I wonder if the ntpd systemd service files should go in the ntpd\n > chunk instead create a ntpd.configure extension\n\nThat would make it harder to update NTP in future, as we wouldn\'t be able to consume the upstream commits directly. Ideally the systemd files would be shipped in the upstream ntpd repo. For now I think it\'s fine for us to create them at deploy-time.\n\nI\'m happy for this to be merged once the comments of others are resolved.',321,1,321,'1a9dcd25_db4a3327',NULL),(29,'2015-04-15 11:55:26','Patch Set 1:\n\n(4 comments)',321,1,321,'1a9dcd25_db71d378',NULL),(15,'2015-04-15 11:12:39','Patch Set 1: Code-Review-1\n\n(3 comments)\n\nI wonder if the ntpd systemd service files should go in the ntpd chunk instead create a ntpd.configure extension\n\nI think you should be able to enable the ntpd service (so timesyncd will not be used) with a system-integration script',321,1,321,'1a9dcd25_db955389',NULL),(19,'2015-04-15 11:02:41','Patch Set 1:\n\n(1 comment)\n\nJust one issue with a comment in ntpd.configure',321,1,321,'1a9dcd25_fbab6fd4',NULL),(29,'2015-04-14 21:48:24','Uploaded patch set 1.',321,1,321,'3aa0d159_5cddbd13',NULL),(29,'2015-04-16 09:19:17','Uploaded patch set 3.',321,3,321,'fa6b99d7_5a74d59b',NULL),(29,'2015-04-16 09:25:33','Patch Set 4: Code-Review+2',321,4,321,'fa6b99d7_5a829553',NULL),(29,'2015-04-16 08:20:33','Patch Set 2:\n\n(1 comment)\n\n> (1 comment)\n > \n > I think this can still be improved\n > \n > And also, taking in account my comment, would it be a terrible idea\n > to avoid the configure extension and simply put the unit file in\n > the chunk morph file?\n\nIf we don\'t need this extension we need to put the unit file in the\nchunk morph *and* we need to patch ntpd to set a higher rlimit,\nif you really think we need to do this then I\'m happy to make the\nchange at a later date but right now we really need this change merged.',321,2,321,'fa6b99d7_7a043915',NULL),(29,'2015-04-16 09:25:35','Change has been successfully merged into the git repository.',321,4,321,'fa6b99d7_7a875962',NULL),(NULL,'2015-04-16 09:25:09','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Idd8a7916, however the current patch set is 4.\n* Depends on commit 7c24e92941c511f2f1090c96b0472cbee11e613d which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',321,3,321,'fa6b99d7_9ab82d2c',NULL),(16,'2015-04-16 08:54:23','Patch Set 2: Code-Review+1',321,2,321,'fa6b99d7_ba47314b',NULL),(29,'2015-04-16 09:25:15','Patch Set 4: Patch Set 3 was rebased',321,3,321,'fa6b99d7_bab5f132',NULL),(29,'2015-04-16 09:25:06','Patch Set 3: Code-Review+2',321,3,321,'fa6b99d7_faab69d4',NULL),(15,'2015-04-15 22:16:05','Patch Set 2: Code-Review+1\n\nWith the same comment about the ntp extension',322,2,322,'1a9dcd25_1e20899a',NULL),(6,'2015-04-15 11:40:07','Patch Set 1: Code-Review+1\n\nLooks fine',322,1,322,'1a9dcd25_3b46b724',NULL),(29,'2015-04-15 17:54:45','Uploaded patch set 2.',322,2,322,'1a9dcd25_5b31430a',NULL),(15,'2015-04-15 11:33:57','Patch Set 1: Code-Review+1\n\nLooks good (assuming we are sure we really need the ntp extension)',322,1,322,'1a9dcd25_bbbac708',NULL),(29,'2015-04-14 21:48:24','Uploaded patch set 1.',322,1,322,'3aa0d159_7ce2f9d6',NULL),(29,'2015-04-16 09:26:00','Patch Set 3: Code-Review+2',322,3,322,'fa6b99d7_1a7c1d72',NULL),(NULL,'2015-04-16 09:26:02','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of If7926bc7, however the current patch set is 4.\n* Depends on commit 9ba3c6e808a5a9cacc7c6c36cbc49b19e35b9596 which has no change associated with it.\n* Depends on commit 7c24e92941c511f2f1090c96b0472cbee11e613d which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',322,3,322,'fa6b99d7_3a81e14a',NULL),(29,'2015-04-16 09:19:17','Uploaded patch set 3.',322,3,322,'fa6b99d7_7a799992',NULL),(16,'2015-04-16 08:52:42','Patch Set 2: Code-Review+1',322,2,322,'fa6b99d7_9a4a6d54',NULL),(29,'2015-04-16 09:26:32','Change has been successfully merged into the git repository.',322,4,322,'fa6b99d7_9a8fcd75',NULL),(29,'2015-04-16 09:26:21','Patch Set 4: Patch Set 3 was rebased',322,3,322,'fa6b99d7_da954589',NULL),(29,'2015-04-16 09:26:30','Patch Set 4: Code-Review+2',322,4,322,'fa6b99d7_fa92899e',NULL),(29,'2015-04-15 17:54:45','Uploaded patch set 2.',323,2,323,'1a9dcd25_7b367f05',NULL),(15,'2015-04-15 11:43:34','Patch Set 1:\n\n(1 comment)\n\nNot sure how the /etc/ntp.conf set here will interact with the one set in the ntp configure extension, so +0 until I get a reply',323,1,323,'1a9dcd25_9b54abcb',NULL),(29,'2015-04-15 17:28:01','Patch Set 1:\n\n(1 comment)',323,1,323,'1a9dcd25_fb5a8f4f',NULL),(29,'2015-04-14 21:48:24','Uploaded patch set 1.',323,1,323,'3aa0d159_1ce735e6',NULL),(29,'2015-04-16 09:19:17','Uploaded patch set 3.',323,3,323,'fa6b99d7_1a6e5dca',NULL),(29,'2015-04-16 09:27:08','Patch Set 4: Code-Review+2',323,4,323,'fa6b99d7_1af3bd0b',NULL),(29,'2015-04-16 09:27:12','Change has been successfully merged into the git repository.',323,4,323,'fa6b99d7_3af801e5',NULL),(NULL,'2015-04-16 09:26:56','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I41fe7968, however the current patch set is 4.\n* Depends on commit ba441ce8be9be0fdfc32c92b1985914cdc2c3a72 which has no change associated with it.\n* Depends on commit 9ba3c6e808a5a9cacc7c6c36cbc49b19e35b9596 which has no change associated with it.\n* Depends on commit 7c24e92941c511f2f1090c96b0472cbee11e613d which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',323,3,323,'fa6b99d7_5ae93519',NULL),(29,'2015-04-16 09:27:05','Patch Set 4: Patch Set 3 was rebased',323,3,323,'fa6b99d7_7aee7924',NULL),(29,'2015-04-16 09:26:54','Patch Set 3: Code-Review+2',323,3,323,'fa6b99d7_ba8c1181',NULL),(16,'2015-04-16 08:52:06','Patch Set 2: Code-Review+1',323,2,323,'fa6b99d7_fa3da9bc',NULL),(29,'2015-04-15 17:54:45','Uploaded patch set 2.',324,2,324,'1a9dcd25_1b3bbbec',NULL),(15,'2015-04-15 11:36:12','Patch Set 1: Code-Review+1\n\nLooks good',324,1,324,'1a9dcd25_5b3703b1',NULL),(15,'2015-04-15 22:15:21','Patch Set 2: Code-Review+1',324,2,324,'1a9dcd25_7e2bcd82',NULL),(6,'2015-04-15 11:43:23','Patch Set 1: Code-Review+2',324,1,324,'1a9dcd25_fb47ef1b',NULL),(29,'2015-04-14 21:48:24','Uploaded patch set 1.',324,1,324,'3aa0d159_3cec71c7',NULL),(29,'2015-04-16 09:19:17','Uploaded patch set 3.',324,3,324,'fa6b99d7_3a7321b3',NULL),(29,'2015-04-16 09:27:50','Change has been successfully merged into the git repository.',324,4,324,'fa6b99d7_9ae6ed43',NULL),(16,'2015-04-16 08:49:36','Patch Set 2: Code-Review+1',324,2,324,'fa6b99d7_da40e537',NULL),(29,'2015-04-16 09:27:44','Patch Set 4: Patch Set 3 was rebased',324,3,324,'fa6b99d7_dadc6577',NULL),(29,'2015-04-16 09:27:48','Patch Set 4: Code-Review+2',324,4,324,'fa6b99d7_fad92984',NULL),(7,'2015-05-26 15:10:50','Patch Set 7: Code-Review+1\n\nThis change looks OK to me, unless someone says there are reasons to have these BSPs \"duplicated\"',325,7,325,'1acb0d3e_4b5e65eb',NULL),(15,'2015-04-14 22:18:40','Uploaded patch set 1.',325,1,325,'3aa0d159_dcd0edf9',NULL),(15,'2015-06-03 17:12:12','Uploaded patch set 10.',325,10,325,'3aa7f18b_040ff6e2',NULL),(15,'2015-06-03 17:11:50','Uploaded patch set 9.',325,9,325,'3aa7f18b_640a6ad4',NULL),(15,'2015-06-03 17:26:53','Uploaded patch set 11.',325,11,325,'3aa7f18b_840206b3',NULL),(29,'2015-06-03 15:27:23','Patch Set 8: Code-Review-1\n\n(1 comment)',325,8,325,'3aa7f18b_c471de78',NULL),(15,'2015-06-03 17:12:57','Patch Set 8:\n\n(1 comment)',325,8,325,'3aa7f18b_c4f8fec6',NULL),(15,'2015-06-02 14:54:32','Uploaded patch set 8.',325,8,325,'5aaae553_45740a9c',NULL),(15,'2015-04-21 15:42:27','Uploaded patch set 3.',325,3,325,'7a7fa997_363a5837',NULL),(7,'2015-04-21 08:04:16','Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI\'m mostly concerned about the \'strata/bsp-x86_both-tools.morph\' removal. As radiofree pointed out in #baserock: \"I believe the rawdisk images install the bootloader by running extlinux on the *host*, so you\'ll need to build an image with the image you\'ve built\"',325,2,325,'7a7fa997_76045015',NULL),(15,'2015-04-21 15:46:36','Patch Set 2:\n\n(1 comment)\n\nUpdated patch where I did not tough the strata/bsp-x86_both-tools stratum (added for the chroot systems).\nI will make another patch to add that stratum to the x86 systems (so we can remove syslinux and nasm from the bsp-x86-generic stratum to not duplicate them) in a posterior commit',325,2,325,'7a7fa997_f63b8036',NULL),(15,'2015-04-20 16:21:34','Uploaded patch set 2.',325,2,325,'9a6a9dd7_f7e38003',NULL),(15,'2015-06-08 08:42:54','Patch Set 11:\n\n> > > I\'m still a little concerned about this, is it not possible\n > that\n > > > the config we use for 32bit and 64bit could diverge in the\n > > future?\n > > > (e.g. you probably don\'t need large file support in a 64 bit\n > > > kernel)\n > >\n > > Yes, in that case we can always revert this patch\n > \n > I don\'t think that\'s a sane strategy: as soon as we add other\n > systems\n > that use this bsp, a revert of this change will not fix the issue.\n\nOf course I meant a revert _and_ fix other changes so we are in the original state.\nI think is better than have all this code duplicated in definitions, but I understand others can think different\n\n > > > I\'m still a little concerned about this, is it not possible\n > that\n > > > the config we use for 32bit and 64bit could diverge in the\n > > future?\n > > > (e.g. you probably don\'t need large file support in a 64 bit\n > > > kernel)\n > >\n > > Yes, in that case we can always revert this patch\n > \n > I don\'t think that\'s a sane strategy: as soon as we add other\n > systems\n > that use this bsp, a revert of this change will not fix the issue.\n\nSorry, by revert I meant revert this commit and make the necessary fixes to come back to the previous state, if needed.\nI think is better than duplicate all this code in definitions, but I understand others can think different.',325,11,325,'ba3841fe_20046a14',NULL),(29,'2015-06-08 07:19:56','Patch Set 11: Code-Review-2\n\n> > I\'m still a little concerned about this, is it not possible that\n > > the config we use for 32bit and 64bit could diverge in the\n > future?\n > > (e.g. you probably don\'t need large file support in a 64 bit\n > > kernel)\n > \n > Yes, in that case we can always revert this patch\n\nI don\'t think that\'s a sane strategy: as soon as we add other systems\nthat use this bsp, a revert of this change will not fix the issue.',325,11,325,'ba3841fe_40ffee01',NULL),(15,'2015-04-30 14:40:28','Uploaded patch set 7.',325,7,325,'bada0100_5904f77d',NULL),(15,'2015-04-30 14:18:45','Uploaded patch set 5.',325,5,325,'bada0100_f99feb4e',NULL),(15,'2015-04-30 14:24:02','Uploaded patch set 6.',325,6,325,'bada0100_f9c60b49',NULL),(15,'2015-06-07 23:34:50','Patch Set 11:\n\n> I\'m still a little concerned about this, is it not possible that\n > the config we use for 32bit and 64bit could diverge in the future?\n > (e.g. you probably don\'t need large file support in a 64 bit\n > kernel)\n\nYes, in that case we can always revert this patch',325,11,325,'da33351e_81573a02',NULL),(15,'2015-04-27 16:17:33','Uploaded patch set 4.',325,4,325,'dad5f5cf_b17d00b4',NULL),(29,'2015-06-05 07:21:40','Patch Set 11: Code-Review-1\n\nI\'m still a little concerned about this, is it not possible that the config we use for 32bit and 64bit could diverge in the future? (e.g. you probably don\'t need large file support in a 64 bit kernel)',325,11,325,'fa2e39b8_42fff201',NULL),(16,'2015-04-15 10:47:01','Uploaded patch set 1.',326,1,326,'1a9dcd25_5b9b83c9',NULL),(27,'2015-04-22 10:22:32','Patch Set 3: Code-Review+1',326,3,326,'5a7ca5a3_559b4cc9',NULL),(16,'2015-04-21 18:16:31','Uploaded patch set 2.',326,2,326,'7a7fa997_36ed788c',NULL),(16,'2015-04-21 18:17:50','Uploaded patch set 3.',326,3,326,'7a7fa997_f6fe2038',NULL),(16,'2015-04-30 13:42:16','Abandoned\n\nThis is obsolete now. See https://gerrit.baserock.org/#/c/539/',326,3,326,'bada0100_59a157a8',NULL),(16,'2015-04-15 10:47:01','Uploaded patch set 1.',327,1,327,'1a9dcd25_7ba0bff4',NULL),(11,'2015-04-22 10:17:06','Patch Set 3: Code-Review+1',327,3,327,'5a7ca5a3_156e34ca',NULL),(16,'2015-04-21 18:17:50','Uploaded patch set 3.',327,3,327,'7a7fa997_96fb2c47',NULL),(16,'2015-04-21 18:16:31','Uploaded patch set 2.',327,2,327,'7a7fa997_d601a43a',NULL),(16,'2015-04-30 13:42:36','Abandoned\n\nThis is obsolete now. See https://gerrit.baserock.org/#/c/540/',327,3,327,'bada0100_79a69bc3',NULL),(7,'2015-04-15 12:35:48','Patch Set 1: Code-Review+2',328,1,328,'1a9dcd25_5b2ce34a',NULL),(7,'2015-04-15 12:35:50','Change has been successfully merged into the git repository.',328,1,328,'1a9dcd25_7b319fa1',NULL),(29,'2015-04-15 12:33:14','Uploaded patch set 1.',328,1,328,'1a9dcd25_bbff27aa',NULL),(34,'2015-04-15 15:11:59','Uploaded patch set 1.',329,1,329,'1a9dcd25_3b031775',NULL),(6,'2015-04-15 15:19:35','Patch Set 1: Code-Review+1\n\nBrilliant. Maybe it could go in an openembedded/ prefix though?',329,1,329,'1a9dcd25_9b1fcbb7',NULL),(34,'2015-04-15 15:35:29','Uploaded patch set 2.',329,2,329,'1a9dcd25_bb73a714',NULL),(6,'2015-04-15 16:34:01','Patch Set 2: Code-Review+1\n\nThanks',329,2,329,'1a9dcd25_bbe1679c',NULL),(15,'2015-05-01 11:13:48','Patch Set 2: Code-Review-2\n\nDo not think we need this for the OpenBMC work',329,2,329,'bada0100_24feaa6c',NULL),(34,'2015-05-12 15:09:44','Abandoned\n\nAbandoned, because although the irony would be fun, we don\'t seem to need it after all :D',329,2,329,'bada0100_b7196724',NULL),(34,'2015-04-15 15:35:29','Uploaded patch set 2.',330,2,330,'1a9dcd25_5b606335',NULL),(6,'2015-04-15 16:34:09','Patch Set 2: Code-Review+1',330,2,330,'1a9dcd25_5bee238d',NULL),(6,'2015-04-15 15:19:42','Patch Set 1: Code-Review+1\n\nBrilliant. Maybe it could go in an openembedded/ prefix though?',330,1,330,'1a9dcd25_bb1c07c3',NULL),(34,'2015-04-15 15:11:59','Uploaded patch set 1.',330,1,330,'1a9dcd25_dbf7938b',NULL),(15,'2015-05-01 11:13:15','Patch Set 2: Code-Review-2\n\nDo not think we need this for OpenBMC',330,2,330,'bada0100_84099697',NULL),(34,'2015-05-12 15:10:02','Abandoned\n\nGone for now; we don\'t seem to need it.',330,2,330,'bada0100_d7166bf1',NULL),(34,'2015-04-15 15:38:36','Patch Set 2: Code-Review-1\n\n(1 comment)',331,2,331,'1a9dcd25_3b5f9774',NULL),(34,'2015-04-15 15:35:29','Uploaded patch set 2.',331,2,331,'1a9dcd25_7b651f44',NULL),(34,'2015-04-15 15:13:36','Patch Set 1: Code-Review-1\n\nYeah, please don\'t use this until fb clarify their licensing! We could get in trouble.',331,1,331,'1a9dcd25_9bf10b98',NULL),(34,'2015-04-15 15:11:59','Uploaded patch set 1.',331,1,331,'1a9dcd25_fbf4cf88',NULL),(34,'2015-08-10 10:20:38','Abandoned\n\nOh OpenBMC, it was not to be.',331,2,331,'fafc7978_3b882b22',NULL),(28,'2015-08-10 10:05:15','Patch Set 2:\n\nHi, do you plan to further work on this patch? If not, can you abandon it please?',331,2,331,'fafc7978_9b915755',NULL),(34,'2015-08-10 10:19:48','Patch Set 2:\n\n> Hi, do you plan to further work on this patch? If not, can you\n > abandon it please?\n\nI doubt I\'ll be working on it in the near future, so I\'ll abandon it. :)\n\n(Heartbreaking backstory: On the 30th of April, fb responded saying they would update soon. We then heard nothing until the 4th of August, when a fb bot contacted us to say we should get a response within 30 days.)',331,2,331,'fafc7978_db9bdf70',NULL),(16,'2015-04-15 15:18:32','Patch Set 1: Code-Review+1\n\nLooks OK to me',332,1,332,'1a9dcd25_1b0c1b94',NULL),(29,'2015-04-15 15:18:56','Patch Set 1: Code-Review+2',332,1,332,'1a9dcd25_3b11d7ac',NULL),(6,'2015-04-15 15:18:17','Patch Set 1: Code-Review+1\n\nseems ok at a glance',332,1,332,'1a9dcd25_7b175fa4',NULL),(29,'2015-04-15 15:16:28','Uploaded patch set 1.',332,1,332,'1a9dcd25_bbee47b3',NULL),(29,'2015-04-15 15:19:00','Change has been successfully merged into the git repository.',332,1,332,'1a9dcd25_db25530b',NULL),(28,'2015-04-15 15:30:42','Uploaded patch set 1.',333,1,333,'1a9dcd25_1b83bbcd',NULL),(7,'2015-04-15 18:43:54','Patch Set 1: Code-Review+1',333,1,333,'1a9dcd25_fb212fb5',NULL),(28,'2015-04-17 09:28:04','Restored',333,2,333,'da7095c5_39aa4fd5',NULL),(28,'2015-04-17 09:30:46','Restored',333,2,333,'da7095c5_5982a353',NULL),(28,'2015-04-17 09:52:18','Abandoned',333,2,333,'da7095c5_79ee8724',NULL),(28,'2015-04-17 09:26:39','Abandoned',333,2,333,'da7095c5_99611bd6',NULL),(28,'2015-04-17 09:30:13','Abandoned',333,2,333,'da7095c5_b9b5ff32',NULL),(28,'2015-04-17 09:23:55','Patch Set 2: Patch Set 1 was rebased',333,1,333,'da7095c5_f93db7bc',NULL),(15,'2015-04-16 16:43:26','Patch Set 1: Code-Review+1',333,1,333,'fa6b99d7_3a11e1ac',NULL),(28,'2015-04-15 15:30:42','Uploaded patch set 1.',334,1,334,'1a9dcd25_3b88f7e6',NULL),(7,'2015-04-15 18:44:51','Patch Set 1: Code-Review+1',334,1,334,'1a9dcd25_9b2eeba4',NULL),(28,'2015-04-17 09:27:01','Abandoned',334,1,334,'da7095c5_b95e5f11',NULL),(15,'2015-04-16 16:53:09','Patch Set 1: Code-Review+1\n\nNice work splitting this patch series, thanks',334,1,334,'fa6b99d7_5a7935fb',NULL),(7,'2015-04-15 18:45:13','Patch Set 1: Code-Review+1',335,1,335,'1a9dcd25_bb2ba793',NULL),(28,'2015-04-15 15:30:42','Uploaded patch set 1.',335,1,335,'1a9dcd25_db6c7339',NULL),(28,'2015-04-17 09:27:17','Abandoned',335,1,335,'da7095c5_599b83c9',NULL),(15,'2015-04-16 16:51:14','Patch Set 1: Code-Review+1',335,1,335,'fa6b99d7_ba1c11c3',NULL),(7,'2015-04-15 18:47:48','Patch Set 1: Code-Review+1',336,1,336,'1a9dcd25_5b186384',NULL),(28,'2015-04-15 15:30:42','Uploaded patch set 1.',336,1,336,'1a9dcd25_fb692f26',NULL),(28,'2015-04-17 09:27:25','Abandoned',336,1,336,'da7095c5_79a0c7f4',NULL),(15,'2015-04-16 16:50:40','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nI made a comment about how we manage the .service but that can be fixed when merged',336,1,336,'fa6b99d7_9a1fcdb7',NULL),(7,'2015-04-15 18:50:16','Patch Set 1: Code-Review+1',337,1,337,'1a9dcd25_7b1d1f73',NULL),(28,'2015-04-15 15:30:42','Uploaded patch set 1.',337,1,337,'1a9dcd25_9b76eb05',NULL),(28,'2015-04-17 09:27:28','Abandoned',337,1,337,'da7095c5_19a50b04',NULL),(15,'2015-04-16 16:45:38','Patch Set 1: Code-Review+1\n\nLooks good at a glace and it doesnt affect other Baserock systems',337,1,337,'fa6b99d7_da25450b',NULL),(16,'2015-04-15 16:10:32','Patch Set 1: Code-Review+1\n\nI was just testing this exact thing whilst rebasing my OSTree branch! It built fine there, so this is fine by me.',338,1,338,'1a9dcd25_5bc70313',NULL),(16,'2015-04-15 16:11:45','Patch Set 1:\n\nActually, I hadn\'t updated to 3.14 there. But +1 from me still.',338,1,338,'1a9dcd25_7bcc3f36',NULL),(15,'2015-04-15 16:06:10','Uploaded patch set 1.',338,1,338,'1a9dcd25_9b4d8bc7',NULL),(29,'2015-04-17 10:21:52','Patch Set 2:\n\n> We need to get OpenStack into the clusters/ci.morph so that it gets\n > built by Mason, and we aren\'t in danger of breaking it with\n > component updates in future. I believe Fran and Pedro are going to\n > look at doing that as soon as possible. In the meantime, if there\n > are any problems with this patch we can easily revert it.\n\nFair enough',338,2,338,'da7095c5_3946cf24',NULL),(6,'2015-04-17 10:12:01','Change has been successfully rebased as e495bf993d2a34b25208e8694eb437bc545f0d55',338,1,338,'da7095c5_593703b1',NULL),(6,'2015-04-17 10:11:44','Patch Set 1: Code-Review+2\n\nWe need to get OpenStack into the clusters/ci.morph so that it gets built by Mason, and we aren\'t in danger of breaking it with component updates in future. I believe Fran and Pedro are going to look at doing that as soon as possible. In the meantime, if there are any problems with this patch we can easily revert it.',338,1,338,'da7095c5_99bd9b05',NULL),(6,'2015-04-17 10:12:01','Patch Set 2: Patch Set 1 was rebased',338,1,338,'da7095c5_b9badf08',NULL),(29,'2015-04-16 08:39:54','Patch Set 1:\n\nThis is changing a dependency of the virtualization stratum\nand therefore a dependency of openstack, have we verified\nthat we can still build with 3.1.4?',338,1,338,'fa6b99d7_1a573d04',NULL),(6,'2015-04-15 17:14:51','Uploaded patch set 1.',339,1,339,'1a9dcd25_fb85afad',NULL),(6,'2015-04-21 11:51:14','Patch Set 2: Patch Set 1 was rebased',339,1,339,'7a7fa997_369ed857',NULL),(8,'2015-04-21 11:31:07','Patch Set 1: Code-Review+1',339,1,339,'7a7fa997_56883422',NULL),(16,'2015-04-21 09:30:25','Patch Set 1: Code-Review+1',339,1,339,'7a7fa997_76ee9024',NULL),(6,'2015-04-21 11:40:08','Patch Set 1: Code-Review+2\n\nthanks',339,1,339,'7a7fa997_96756c34',NULL),(6,'2015-04-21 11:51:18','Patch Set 2: Code-Review+2',339,2,339,'7a7fa997_d6a2049a',NULL),(6,'2015-04-21 11:51:20','Change has been successfully merged into the git repository.',339,2,339,'7a7fa997_f69f004f',NULL),(27,'2015-04-17 14:53:10','Patch Set 1: Code-Review+1\n\nlooks good to me and removes annoyances. so yes.',339,1,339,'da7095c5_199f4b05',NULL),(7,'2015-04-15 17:24:25','Abandoned',340,1,340,'1a9dcd25_3b49d78b',NULL),(7,'2015-04-15 17:20:18','Uploaded patch set 1.',340,1,340,'1a9dcd25_5b63831a',NULL),(6,'2015-04-24 10:22:58','Change has been successfully rebased as 5239f5190ce326b891f4b69555f91a69b1a1a2ba',341,3,341,'1a76adc5_13208c9a',NULL),(6,'2015-04-24 10:22:55','Patch Set 3: Code-Review+2\n\nI shall submit this now so we can benefit from the speed improvements. I agree that it needs more work, because it is no longer serialising artifacts but still says it is, and for other reasons.',341,3,341,'1a76adc5_532604bc',NULL),(6,'2015-04-24 10:22:57','Patch Set 4: Patch Set 3 was rebased',341,3,341,'1a76adc5_732b0083',NULL),(33,'2015-04-23 14:23:59','Patch Set 3: -Code-Review',341,3,341,'3a79b1b5_d4c3dc88',NULL),(33,'2015-04-22 08:03:04','Patch Set 3: Code-Review-1\n\nMy reservations from the previous patchset still hold,\nadding Richard Maw to the review.',341,3,341,'5a7ca5a3_1509542c',NULL),(37,'2015-04-22 13:05:57','Patch Set 3: Code-Review+2\n\n(3 comments)\n\n> What we\'re doing here is contructing a partial build graph for\n > distbuild, so adding this functionality elsewhere may make more\n > sense then essentially removing serialisation and replacing it\n > with this.\n\nIf we\'re not using this anywhere else and we\'re not guaranteeing API stability, then I\'m ok with this.\n\nGenerally though I\'d like to have the core logic rewritten to have distinct morphology load, dependency graph and build instruction objects, only the last one needing to be sent to the worker nodes.',341,3,341,'5a7ca5a3_150f14e3',NULL),(6,'2015-04-22 10:00:10','Patch Set 1:\n\n> My reservations from the previous patchset still hold,\n > adding Richard Maw to the review.\n\nCould you clarify what reservations you still have? If the function names and docstrings were changed to reflect that this isn\'t actually doing serialisation any more, could we merge this?\n\nStill I am very keen to merge it because, for distbuild to be useful, we need to get the time from running \'morph distbuild\' to builds actually starting to be pretty much unnoticable. This series gets us about 30 seconds closer, and takes stratum generation to about 5 seconds down from 35-45 seconds as well.',341,1,341,'5a7ca5a3_15571404',NULL),(37,'2015-04-22 14:25:34','Patch Set 3:\n\n> > > The workers need more than just build instructions, since they\n > > need\n > > > to know the artifact\'s dependencies too.\n > >\n > > I intend that \"make a staging area comprised of these things\"\n > will\n > > be part of those build instructions to handle this.\n > >\n > > > Rather than send them a\n > > > full build graph, they calculate the build graph themselves as\n > of\n > > > the third patch in this topic. That means they need other\n > > > information such as the source repo + ref.\n > >\n > > \"Extract these sources into the staging area\" would be another\n > > build instruction.\n > \n > Makes sense. Do you mind if this improvement is done in a separate\n > patch series to this, we\'re a little short on time now?\n\nThis improvement was general rambling about how I\'d like it to be done eventually, there\'s no call to make these changes now, particularly since it\'ll be a big job to convert non-distributed builds too.',341,3,341,'5a7ca5a3_35b010f4',NULL),(37,'2015-04-22 13:50:52','Patch Set 3:\n\n> The workers need more than just build instructions, since they need\n > to know the artifact\'s dependencies too.\n\nI intend that \"make a staging area comprised of these things\" will be part of those build instructions to handle this.\n\n > Rather than send them a\n > full build graph, they calculate the build graph themselves as of\n > the third patch in this topic. That means they need other\n > information such as the source repo + ref.\n\n\"Extract these sources into the staging area\" would be another build instruction.',341,3,341,'5a7ca5a3_35b9f0e9',NULL),(16,'2015-04-22 13:34:00','Patch Set 3:\n\n> (3 comments)\n > \n > > What we\'re doing here is contructing a partial build graph for\n > > distbuild, so adding this functionality elsewhere may make more\n > > sense then essentially removing serialisation and replacing it\n > > with this.\n > \n > If we\'re not using this anywhere else and we\'re not guaranteeing\n > API stability, then I\'m ok with this.\n > \n > Generally though I\'d like to have the core logic rewritten to have\n > distinct morphology load, dependency graph and build instruction\n > objects, only the last one needing to be sent to the worker nodes.\n\nThe workers need more than just build instructions, since they need to know the artifact\'s dependencies too. Rather than send them a full build graph, they calculate the build graph themselves as of the third patch in this topic. That means they need other information such as the source repo + ref.',341,3,341,'5a7ca5a3_75d8c853',NULL),(33,'2015-04-22 10:45:52','Patch Set 3:\n\n> > My reservations from the previous patchset still hold,\n > > adding Richard Maw to the review.\n > \n > Could you clarify what reservations you still have? If the function\n > names and docstrings were changed to reflect that this isn\'t\n > actually doing serialisation any more, could we merge this?\n > \n > Still I am very keen to merge it because, for distbuild to be\n > useful, we need to get the time from running \'morph distbuild\' to\n > builds actually starting to be pretty much unnoticable. This series\n > gets us about 30 seconds closer, and takes stratum generation to\n > about 5 seconds down from 35-45 seconds as well.\n\nAgreed it would be useful to merge,\nI\'m partly concerned with no longer having the ability to serialise\nartifacts,\n\n > > My reservations from the previous patchset still hold,\n > > adding Richard Maw to the review.\n > \n > Could you clarify what reservations you still have? If the function\n > names and docstrings were changed to reflect that this isn\'t\n > actually doing serialisation any more, could we merge this?\n > \n > Still I am very keen to merge it because, for distbuild to be\n > useful, we need to get the time from running \'morph distbuild\' to\n > builds actually starting to be pretty much unnoticable. This series\n > gets us about 30 seconds closer, and takes stratum generation to\n > about 5 seconds down from 35-45 seconds as well.\n\nAgreed, just concerned we\'re removing functionality we\'d previously\nconsidered moving to morphlib for general use. And yes we\'re not\nserialising, so we\'re ending up with a command serialise-artifact which\ndoesn\'t serialise an artifact.\n\nWhat we\'re doing here is contructing a partial build graph for\ndistbuild, so adding this functionality elsewhere may make more\nsense then essentially removing serialisation and replacing it\nwith this.',341,3,341,'5a7ca5a3_75ee8824',NULL),(16,'2015-04-22 13:56:15','Patch Set 3:\n\n> > The workers need more than just build instructions, since they\n > need\n > > to know the artifact\'s dependencies too.\n > \n > I intend that \"make a staging area comprised of these things\" will\n > be part of those build instructions to handle this.\n > \n > > Rather than send them a\n > > full build graph, they calculate the build graph themselves as of\n > > the third patch in this topic. That means they need other\n > > information such as the source repo + ref.\n > \n > \"Extract these sources into the staging area\" would be another\n > build instruction.\n\nMakes sense. Do you mind if this improvement is done in a separate patch series to this, we\'re a little short on time now?',341,3,341,'5a7ca5a3_95c7a464',NULL),(37,'2015-04-22 13:11:13','Patch Set 3:\n\nI am however, unhappy that this patch cannot be applied independently without breaking distbuild >:¬|',341,3,341,'5a7ca5a3_f5f5b8cb',NULL),(32,'2015-04-21 09:15:51','Patch Set 2:\n\n(1 comment)\n\nOver all, I\'m not quite sure why this is necessary. Surely serialising and transferring a graph isn\'t expensive, and won\'t this require the worker to have access to the definitions content and also mandate identical copies of morph on every worker?',341,2,341,'7a7fa997_3681f84a',NULL),(33,'2015-04-21 09:07:22','Patch Set 2:\n\n> (4 comments)\n > \n > > I would suggest splitting out your creation of ArtifactReference,\n > > it seems perfectly sensible to do partial serialisation for\n > distbuild\n > > however there\'s no reason to break the existing serialisation in\n > > the process.\n > >\n > > Perhaps we ought to move the existing serialisation into morphlib\n > > proper (we\'ve discussed this before but never got around to it)\n > > and keep your ArtifactReferences for distbuild.\n > \n > I guess we could, although I don\'t know how useful adding a bunch\n > of unused code to morphlib would be. If we have a use-case for\n > serialising complete artifacts again we can just grab the code from\n > the history and do anything needed to get it working from there, it\n > would probably end up being forgotten when it needed updating if it\n > was unused in morphlib anyway.\n\n > (4 comments)\n > \n > > I would suggest splitting out your creation of ArtifactReference,\n > > it seems perfectly sensible to do partial serialisation for\n > distbuild\n > > however there\'s no reason to break the existing serialisation in\n > > the process.\n > >\n > > Perhaps we ought to move the existing serialisation into morphlib\n > > proper (we\'ve discussed this before but never got around to it)\n > > and keep your ArtifactReferences for distbuild.\n > \n > I guess we could, although I don\'t know how useful adding a bunch\n > of unused code to morphlib would be. If we have a use-case for\n > serialising complete artifacts again we can just grab the code from\n > the history and do anything needed to get it working from there, it\n > would probably end up being forgotten when it needed updating if it\n > was unused in morphlib anyway.\n\nI\'m in two minds about whether we want to keep this, we have unit tests\nthat should flag when the serialisation code no longer works so we could,\nbut perhaps it\'s not worth it.\n\nI do not feel confident merging these changes, since you\'re not serialising/deserialising artifacts anymore, you\'re creating a new object that encodes the subset of an artifact you need for distbuild and serialising that, I think at the very least the function names and doc\nstrings should be updated to reflect this.\n\nWill add Daniel Silverstone to this review to see what he suggests.',341,2,341,'7a7fa997_56827453',NULL),(32,'2015-04-21 09:59:33','Patch Set 2:\n\n> It will require both those things, but I don\'t think they are a\n > problem?\n\nThe identical morph versions I\'m not so bothered about, but having every worker have to fetch yet another repo makes me a little sad. Especially since I was hoping eventually to get to the point of sending the graph from the initiator to the controller rather than computing it on the controller even.\n\nBut if you prefer this approach I won\'t -1 it.',341,2,341,'7a7fa997_96e6cc43',NULL),(16,'2015-04-21 18:30:00','Uploaded patch set 3.',341,3,341,'7a7fa997_d688c4c8',NULL),(16,'2015-04-21 09:53:26','Patch Set 2:\n\n(2 comments)\n\n> (1 comment)\n > \n > Over all, I\'m not quite sure why this is necessary. Surely\n > serialising and transferring a graph isn\'t expensive, and won\'t\n > this require the worker to have access to the definitions content\n > and also mandate identical copies of morph on every worker?\n\nSerialising it is fast, transferring it is really slow thanks to doing both a yaml and a json dump of a huge data structure (see the third patch in this series for some speed measurments from Sam).\n\nIt will require both those things, but I don\'t think they are a problem?',341,2,341,'7a7fa997_d6dc4477',NULL),(6,'2015-04-21 10:41:12','Patch Set 2:\n\n> > It will require both those things, but I don\'t think they are a\n > > problem?\n > \n > The identical morph versions I\'m not so bothered about, but having\n > every worker have to fetch yet another repo makes me a little sad. \n > Especially since I was hoping eventually to get to the point of\n > sending the graph from the initiator to the controller rather than\n > computing it on the controller even.\n > \n > But if you prefer this approach I won\'t -1 it.\n\nI don\'t see how an approach that involves serialising the build graph can ever be fast enough: it seems to result in tens of megabytes of data, which then takes an age to transfer. I could well be missing something, but I couldn\'t find any simple way to reduce the amount of data that needed to be transferred, other than this.\n\nIn the past, constructing the build graph wasn\'t fast either, but Morph does enough caching now that in the normal case, build-graph calculation takes a few seconds. So right now it\'s much faster to calculate the build-graph in each process than to serialise and transfer it.\n\nWith regards to requiring the same version of distbuild: all distbuild breakages I\'ve seen have been due to version mismatches between initiator and controller, not between controller and its workers. In my experience the controller and workers are always deployed together.',341,2,341,'7a7fa997_f647001c',NULL),(33,'2015-04-20 17:23:21','Patch Set 2:\n\nI would suggest splitting out your creation of ArtifactReference,\nit seems perfectly sensible to do partial serialisation for distbuild\nhowever there\'s no reason to break the existing serialisation in the\nprocess.\n\nPerhaps we ought to move the existing serialisation into morphlib\nproper (we\'ve discussed this before but never got around to it)\nand keep your ArtifactReferences for distbuild.',341,2,341,'9a6a9dd7_57a10ca8',NULL),(33,'2015-04-20 17:04:48','Patch Set 2: Code-Review-1\n\n(2 comments)\n\nI\'m still partway through reviewing this, please don\'t merge yet.',341,2,341,'9a6a9dd7_77bf70d1',NULL),(33,'2015-04-20 15:34:48','Patch Set 2: Commit message was updated',341,2,341,'9a6a9dd7_77d8d053',NULL),(16,'2015-04-20 21:37:41','Patch Set 1:\n\n(4 comments)\n\n> I would suggest splitting out your creation of ArtifactReference,\n > it seems perfectly sensible to do partial serialisation for distbuild\n > however there\'s no reason to break the existing serialisation in\n > the process.\n >\n > Perhaps we ought to move the existing serialisation into morphlib\n > proper (we\'ve discussed this before but never got around to it)\n > and keep your ArtifactReferences for distbuild.\n\nI guess we could, although I don\'t know how useful adding a bunch of unused code to morphlib would be. If we have a use-case for serialising complete artifacts again we can just grab the code from the history and do anything needed to get it working from there, it would probably end up being forgotten when it needed updating if it was unused in morphlib anyway.',341,1,341,'9a6a9dd7_97756434',NULL),(33,'2015-04-20 17:13:58','Patch Set 1:\n\n(4 comments)',341,1,341,'9a6a9dd7_b7c42860',NULL),(6,'2015-04-16 12:34:04','Patch Set 1: Code-Review+1',341,1,341,'fa6b99d7_da1f8508',NULL),(16,'2015-04-16 09:19:46','Uploaded patch set 1.',341,1,341,'fa6b99d7_da6785e9',NULL),(6,'2015-04-24 10:24:03','Change has been successfully merged into the git repository.',342,3,342,'1a76adc5_13572c04',NULL),(6,'2015-04-24 10:23:12','Patch Set 2: Code-Review+2\n\nI shall submit this now so we can benefit from the speed improvements. I agree that it needs more work, because it is no longer serialising artifacts but still says it is, and for other reasons.',342,2,342,'1a76adc5_332588ab',NULL),(6,'2015-04-24 10:23:46','Patch Set 3: Patch Set 2 was rebased',342,2,342,'1a76adc5_534da471',NULL),(6,'2015-04-24 10:24:01','Patch Set 3: Code-Review+2',342,3,342,'1a76adc5_73522015',NULL),(NULL,'2015-04-24 10:23:14','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I6bd0bed1, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',342,2,342,'1a76adc5_d339b4d9',NULL),(37,'2015-04-22 13:34:56','Patch Set 2: Code-Review-1\n\nI\'m not happy with this patch series. At a minimum, I want this to be more explicit in the distbuild code you have changed that it takes an *ArtifactReference*, not an Artifact.',342,2,342,'5a7ca5a3_15ddd442',NULL),(37,'2015-04-22 13:28:46','Patch Set 2:\n\nThis change does not fill me with happiness. It effectively reverts one I wrote months ago to de-conflate Artifacts and Sources.\n\nI\'d be marginally more well-disposed towards it if you replaced every instance of \"Artifact\" with \"ArtifactReference\".',342,2,342,'5a7ca5a3_b51660f0',NULL),(37,'2015-04-22 13:15:45','Patch Set 2:\n\n>:¬( I *really* don\'t like that distbuild is broken between this patch and the previous one.',342,2,342,'5a7ca5a3_b5ff40aa',NULL),(16,'2015-04-21 18:30:00','Uploaded patch set 2.',342,2,342,'7a7fa997_f685c0ad',NULL),(6,'2015-04-16 12:34:08','Patch Set 1: Code-Review+1',342,1,342,'fa6b99d7_fa1cc915',NULL),(16,'2015-04-16 09:19:46','Uploaded patch set 1.',342,1,342,'fa6b99d7_fa64c9e6',NULL),(NULL,'2015-04-24 10:24:03','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I79b40d04, however the current patch set is 3.\n* Depends on commit 343b54145f59786beb773f140350aaf05d2f8c6e which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',343,2,343,'1a76adc5_335ca825',NULL),(6,'2015-04-24 10:24:19','Change has been successfully merged into the git repository.',343,3,343,'1a76adc5_934a5c54',NULL),(NULL,'2015-04-24 10:23:24','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I6bd0bed1, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',343,2,343,'1a76adc5_b330b8e9',NULL),(6,'2015-04-24 10:24:08','Patch Set 3: Patch Set 2 was rebased',343,2,343,'1a76adc5_d340d437',NULL),(6,'2015-04-24 10:23:22','Patch Set 2: Code-Review+2\n\nI shall submit this now so we can benefit from the speed improvements. I agree that it needs more work, because it is no longer serialising artifacts but still says it is, and for other reasons.',343,2,343,'1a76adc5_f33630e7',NULL),(6,'2015-04-24 10:24:17','Patch Set 3: Code-Review+2',343,3,343,'1a76adc5_f33dd0bc',NULL),(37,'2015-04-22 13:47:34','Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI\'m still unhappy that these patches aren\'t atomically applicable.\nRemove the duplicate code and sort out the dependencies and I\'ll +1/+2 and merge depending on other reviews.',343,2,343,'5a7ca5a3_15b4f4f0',NULL),(37,'2015-04-22 14:09:15','Patch Set 2:\n\n(1 comment)',343,2,343,'5a7ca5a3_55a10ca8',NULL),(27,'2015-04-22 09:27:28','Patch Set 2: Code-Review+1',343,2,343,'5a7ca5a3_f53618e7',NULL),(16,'2015-04-22 13:52:02','Patch Set 2:\n\n(1 comment)',343,2,343,'5a7ca5a3_f5ca986d',NULL),(6,'2015-04-21 08:45:16','Patch Set 1:\n\nso we don\'t lose track: here are the original mailing list submissions of this patch series: .\n\nAt the time, I thought it had introduced a bug causing builds to get stuck so didn\'t want to merge it, but the bug turned out to be in \'master\' anyway.',343,1,343,'7a7fa997_16207c9a',NULL),(16,'2015-04-21 18:30:00','Uploaded patch set 2.',343,2,343,'7a7fa997_96924cf5',NULL),(6,'2015-04-16 12:35:13','Patch Set 1: Code-Review+1\n\nHere\'s a fairly unscientific before-and-after comparison for this branch. Test is:\ntime to rebuild a system image, when the kernel version was changed. Test hardware\nwas an NVIDIA Jetson.\n\nBefore serialise-speedups:\n\n 2015-04-16 11:43:18 Starting distributed build\n 2015-04-16 11:43:18 Connecting to sam-jetson-mason:7878\n 2015-04-16 11:43:18 Requesting build of ssh://... 8111b529c4b92551aa5ddc58e02c8fa72123a784 systems/build-system-armv7lhf-highbank.morph\n 2015-04-16 11:43:18 Progress: Computing build graph\n 2015-04-16 11:44:12 Progress: Finished computing build graph\n 2015-04-16 11:44:35 Progress: Need to build 9 artifacts, of 1160 total\n 2015-04-16 11:44:35 Started building linux-armv7-highbank on sam-jetson-mason:3434\n 2015-04-16 11:51:17 Progress: Transferring linux-armv7-highbank-misc to shared artifact cache\n 2015-04-16 11:51:31 Finished building linux-armv7-highbank\n 2015-04-16 11:51:31 Progress: Ready to build bsp-armv7-highbank-runtime: waiting for a worker to become available\n 2015-04-16 11:51:31 Progress: Ready to build bsp-armv7-highbank-devel: waiting for a worker to become available\n 2015-04-16 11:51:31 Started building bsp-armv7-highbank-devel on sam-jetson-mason:3434\n 2015-04-16 11:51:57 Progress: Transferring bsp-armv7-highbank-devel to shared artifact cache\n 2015-04-16 11:52:08 Finished building bsp-armv7-highbank-devel\n 2015-04-16 11:52:08 Started building bsp-armv7-highbank-runtime on sam-jetson-mason:3434\n 2015-04-16 11:52:35 Progress: Transferring bsp-armv7-highbank-runtime to shared artifact cache\n 2015-04-16 11:52:55 Finished building bsp-armv7-highbank-runtime\n 2015-04-16 11:52:55 Progress: Ready to build build-system-armv7lhf-highbank-rootfs: waiting for a worker to become available\n 2015-04-16 11:52:55 Started building build-system-armv7lhf-highbank on sam-jetson-mason:3434\n 2015-04-16 11:55:28 Progress: Transferring build-system-armv7lhf-highbank-rootfs to shared artifact cache\n 2015-04-16 11:55:56 Finished building build-system-armv7lhf-highbank\n 2015-04-16 11:55:56 Artifact: http://...\n\nAfter:\n\n 2015-04-16 12:11:27 Starting distributed build\n 2015-04-16 12:11:27 Connecting to sam-jetson-mason:7878\n 2015-04-16 12:11:27 Requesting build of ssh://... 03440d99d5bddb0c6594c870f1da19ead5605ddf systems/build-system-armv7lhf-highbank.morph\n 2015-04-16 12:11:27 Progress: Computing build graph\n 2015-04-16 12:11:53 Progress: Finished computing build graph\n 2015-04-16 12:11:55 Progress: Need to build 9 artifacts, of 1160 total\n 2015-04-16 12:11:55 Started building linux-armv7-highbank on sam-jetson-mason:3434\n 2015-04-16 12:21:07 Progress: Transferring linux-armv7-highbank-misc to shared artifact cache\n 2015-04-16 12:21:07 Finished building linux-armv7-highbank\n 2015-04-16 12:21:07 Progress: Ready to build bsp-armv7-highbank-runtime: waiting for a worker to become available\n 2015-04-16 12:21:07 Progress: Ready to build bsp-armv7-highbank-devel: waiting for a worker to become available\n 2015-04-16 12:21:07 Started building bsp-armv7-highbank-devel on sam-jetson-mason:3434\n 2015-04-16 12:21:12 Progress: Transferring bsp-armv7-highbank-devel to shared artifact cache\n 2015-04-16 12:21:12 Finished building bsp-armv7-highbank-devel\n 2015-04-16 12:21:12 Started building bsp-armv7-highbank-runtime on sam-jetson-mason:3434\n 2015-04-16 12:21:17 Progress: Transferring bsp-armv7-highbank-runtime to shared artifact cache\n 2015-04-16 12:21:17 Finished building bsp-armv7-highbank-runtime\n 2015-04-16 12:21:17 Progress: Ready to build build-system-armv7lhf-highbank-rootfs: waiting for a worker to become available\n 2015-04-16 12:21:17 Started building build-system-armv7lhf-highbank on sam-jetson-mason:3434\n 2015-04-16 12:23:19 Progress: Transferring build-system-armv7lhf-highbank-rootfs to shared artifact cache\n 2015-04-16 12:23:46 Finished building build-system-armv7lhf-highbank\n 2015-04-16 12:23:46 Artifact: http://...\n\nThe key results are these two.\n\nTime to compute build graph: 54 seconds before, 26 seconds after\nTime to build a stratum: 37-47 seconds before, 4-5 seconds after\n\nI would really like to shave 21 more seconds off the \'computing build graph\'\nstep. I don\'t see a reason for it to take longer than that. But this branch\ngives a big improvement (more than half) and also massively reduces time wasted\nwhen creating a stratum. Great work!\n\nWe held off on merging this patch before because a bug showed up while someone\nwas testing it. We\'ve now established that the bug is present in \'master\' as\nwell. I\'ll be sending a patch to fix that hopefully tomorrow.\n\nI\'ve not tested that ./check still passes, I assume it does :)',343,1,343,'fa6b99d7_9a190d25',NULL),(16,'2015-04-16 09:19:46','Uploaded patch set 1.',343,1,343,'fa6b99d7_9a610dd6',NULL),(6,'2015-04-16 12:35:37','Patch Set 1:\n\nWith better formatting:\n\n- Time to compute build graph: 54 seconds before, 26 seconds after\n- Time to build a stratum: 37-47 seconds before, 4-5 seconds after',343,1,343,'fa6b99d7_ba1651f0',NULL),(7,'2015-04-16 15:23:50','Patch Set 1: Code-Review+2',344,1,344,'fa6b99d7_1aabbd8a',NULL),(6,'2015-04-16 14:15:05','Uploaded patch set 1.',344,1,344,'fa6b99d7_1ab41df1',NULL),(7,'2015-04-16 15:23:57','Patch Set 2: Patch Set 1 was rebased',344,1,344,'fa6b99d7_3ab001f4',NULL),(35,'2015-04-16 15:15:05','Patch Set 1: Code-Review+1\n\nNo objections from me',344,1,344,'fa6b99d7_5aa135a8',NULL),(7,'2015-04-16 15:23:58','Change has been successfully rebased as 1ec9fced3606cf71c80414093289672ef56c4b92',344,1,344,'fa6b99d7_da946546',NULL),(15,'2015-04-17 10:37:10','Patch Set 2: Patch Set 1 was rebased',345,1,345,'da7095c5_392b2f32',NULL),(6,'2015-04-17 10:12:27','Patch Set 1: Code-Review+2',345,1,345,'da7095c5_793c4794',NULL),(15,'2015-04-17 10:37:11','Change has been successfully rebased as 7a305c418ca7766eb872d18f186eb1f0ba0c86bf',345,1,345,'da7095c5_d91f9308',NULL),(15,'2015-04-16 15:21:16','Uploaded patch set 1.',345,1,345,'fa6b99d7_7aa679c3',NULL),(8,'2015-04-16 15:26:03','Patch Set 1: Code-Review+1',345,1,345,'fa6b99d7_fa912953',NULL),(8,'2015-04-16 16:33:41','Patch Set 1: Code-Review+2',346,1,346,'fa6b99d7_3a3a4137',NULL),(8,'2015-04-16 16:33:51','Change has been successfully merged into the git repository.',346,1,346,'fa6b99d7_da3ea529',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',346,1,346,'fa6b99d7_daf7858b',NULL),(7,'2015-04-17 15:21:42','Patch Set 3: Patch Set 2 was rebased',347,2,347,'da7095c5_1912eb62',NULL),(7,'2015-04-17 15:21:43','Change has been successfully rebased as 0b3d2ffad59e0660add775765696bb0b43b9d5cc',347,2,347,'da7095c5_3917af53',NULL),(7,'2015-04-17 14:27:27','Uploaded patch set 2.',347,2,347,'da7095c5_395faf74',NULL),(7,'2015-04-17 14:35:08','Patch Set 2: Code-Review+1',347,2,347,'da7095c5_39d6cfc6',NULL),(8,'2015-04-17 08:49:28','Patch Set 1:\n\n> Patch Set 1: -Code-Review\n\nit looks fine by me, but Im the commiter so I think I shouldn\'t vote this.',347,1,347,'da7095c5_592623bc',NULL),(7,'2015-04-17 15:21:40','Patch Set 2: Code-Review+2',347,2,347,'da7095c5_791d2773',NULL),(15,'2015-04-17 15:03:33','Patch Set 2: Code-Review+1',347,2,347,'da7095c5_794f6793',NULL),(8,'2015-04-17 08:48:26','Patch Set 1: -Code-Review',347,1,347,'da7095c5_991cbb6c',NULL),(29,'2015-04-17 08:48:58','Patch Set 1: Code-Review+1',347,1,347,'da7095c5_b9197f7b',NULL),(8,'2015-04-16 19:36:52','Patch Set 1: Code-Review+1',347,1,347,'fa6b99d7_dada25e9',NULL),(7,'2015-04-16 16:35:13','Patch Set 1: Code-Review+1',347,1,347,'fa6b99d7_fa3b6936',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',347,1,347,'fa6b99d7_faf4c988',NULL),(29,'2015-04-17 08:54:34','Patch Set 1: Code-Review-1\n\n(1 comment)',348,1,348,'da7095c5_39256fab',NULL),(29,'2015-04-17 15:02:24','Patch Set 2: Code-Review+1',348,2,348,'da7095c5_594aa384',NULL),(37,'2015-04-17 14:51:30','Patch Set 1:\n\n(1 comment)',348,1,348,'da7095c5_5995c3e2',NULL),(27,'2015-04-17 14:42:34','Patch Set 2: Code-Review+1',348,2,348,'da7095c5_59ee238d',NULL),(7,'2015-04-17 15:22:05','Change has been successfully merged into the git repository.',348,3,348,'da7095c5_5cfff101',NULL),(8,'2015-04-17 08:49:42','Patch Set 1: -Code-Review\n\nit looks fine by me, but Im the commiter so I think I shouldn\'t vote this.',348,1,348,'da7095c5_792be782',NULL),(7,'2015-04-17 15:22:01','Patch Set 3: Patch Set 2 was rebased',348,2,348,'da7095c5_99059b16',NULL),(7,'2015-04-17 15:22:03','Patch Set 3: Code-Review+2',348,3,348,'da7095c5_b902df09',NULL),(7,'2015-04-17 14:27:27','Uploaded patch set 2.',348,2,348,'da7095c5_d953136b',NULL),(7,'2015-04-17 15:21:57','Patch Set 2: Code-Review+2',348,2,348,'da7095c5_f908572f',NULL),(15,'2015-04-17 15:06:01','Patch Set 2: Code-Review+1',348,2,348,'da7095c5_f95a974f',NULL),(8,'2015-04-16 19:36:09','Patch Set 1: Code-Review+1',348,1,348,'fa6b99d7_3ad6c1c6',NULL),(7,'2015-04-16 16:35:34','Patch Set 1: Code-Review+1',348,1,348,'fa6b99d7_9a482dce',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',348,1,348,'fa6b99d7_9af10d98',NULL),(27,'2015-04-17 10:12:38','Patch Set 1: Code-Review+1\n\nlooks good to m and cant break any current baserock functionality',349,1,349,'da7095c5_19418b0b',NULL),(7,'2015-04-17 15:46:14','Change has been successfully merged into the git repository.',349,3,349,'da7095c5_3c5c7d25',NULL),(7,'2015-04-17 15:35:42','Uploaded patch set 3.',349,3,349,'da7095c5_bc196d7b',NULL),(7,'2015-04-17 15:46:01','Patch Set 3: Code-Review+2',349,3,349,'da7095c5_bc308de9',NULL),(8,'2015-04-17 15:43:27','Patch Set 3: Code-Review+1',349,3,349,'da7095c5_dc39c1d9',NULL),(7,'2015-04-17 14:27:27','Uploaded patch set 2.',349,2,349,'da7095c5_f9505760',NULL),(27,'2015-04-17 14:36:09','Patch Set 2: Code-Review+1',349,2,349,'da7095c5_f9d7f7bd',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',349,1,349,'fa6b99d7_baee51b3',NULL),(8,'2015-04-17 15:43:19','Patch Set 3: Code-Review+1',350,3,350,'da7095c5_3c255dab',NULL),(7,'2015-04-17 15:35:42','Uploaded patch set 3.',350,3,350,'da7095c5_5c2611bc',NULL),(7,'2015-04-17 15:46:05','Patch Set 3: Code-Review+2',350,3,350,'da7095c5_5c4db171',NULL),(7,'2015-04-17 14:27:27','Uploaded patch set 2.',350,2,350,'da7095c5_994d9bc7',NULL),(37,'2015-04-17 14:57:12','Patch Set 1:\n\n(1 comment)',350,1,350,'da7095c5_b98f3fcc',NULL),(28,'2015-04-17 13:43:33','Patch Set 1:\n\n(1 comment)',350,1,350,'da7095c5_b9a97f7d',NULL),(27,'2015-04-17 14:42:03','Patch Set 2: Code-Review+1',350,2,350,'da7095c5_b9e17f9c',NULL),(7,'2015-04-17 15:46:17','Change has been successfully merged into the git repository.',350,3,350,'da7095c5_dc40e137',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',350,1,350,'fa6b99d7_5a2b75eb',NULL),(8,'2015-04-17 15:43:01','Patch Set 3: Code-Review+1',351,3,351,'da7095c5_1c20999a',NULL),(8,'2015-04-17 11:54:32','Patch Set 1: Code-Review-1\n\nThis breaks onenode, patches for fixing this are in their way',351,1,351,'da7095c5_39b00ff4',NULL),(8,'2015-04-17 15:22:38','Patch Set 2: Code-Review+1',351,2,351,'da7095c5_7c043515',NULL),(7,'2015-04-17 15:35:42','Uploaded patch set 3.',351,3,351,'da7095c5_7c2bd582',NULL),(7,'2015-04-17 15:46:07','Patch Set 3: Code-Review+2',351,3,351,'da7095c5_7c52f514',NULL),(7,'2015-04-17 14:27:27','Uploaded patch set 2.',351,2,351,'da7095c5_b94adfaa',NULL),(27,'2015-04-17 14:35:49','Patch Set 2: Code-Review+1',351,2,351,'da7095c5_d9da33e9',NULL),(27,'2015-04-17 10:23:36','Patch Set 1: Code-Review+1',351,1,351,'da7095c5_f947f71b',NULL),(7,'2015-04-17 15:46:20','Change has been successfully merged into the git repository.',351,3,351,'da7095c5_fc3da5bc',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',351,1,351,'fa6b99d7_7a30b956',NULL),(7,'2015-04-17 14:27:27','Uploaded patch set 2.',352,2,352,'da7095c5_195aeb83',NULL),(8,'2015-04-17 11:53:36','Patch Set 1: Code-Review-1\n\nThis configuration breaks one node. Patches are on going',352,1,352,'da7095c5_19abcb8a',NULL),(7,'2015-04-17 15:46:09','Patch Set 3: Code-Review+2',352,3,352,'da7095c5_1c573904',NULL),(37,'2015-04-17 14:59:18','Patch Set 1:\n\n(1 comment)',352,1,352,'da7095c5_79c1a7e3',NULL),(27,'2015-04-17 14:37:03','Patch Set 2: Code-Review+1',352,2,352,'da7095c5_99e4bbad',NULL),(7,'2015-04-17 15:35:42','Uploaded patch set 3.',352,3,352,'da7095c5_9c1ca96c',NULL),(27,'2015-04-17 15:45:45','Patch Set 3: Code-Review+1',352,3,352,'da7095c5_9c3349f6',NULL),(7,'2015-04-17 15:46:23','Change has been successfully merged into the git repository.',352,3,352,'da7095c5_9c4a6954',NULL),(27,'2015-04-17 10:44:21','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nlooks good to me, bar the confirmation of the commented possible typeo.',352,1,352,'da7095c5_d9e6b316',NULL),(8,'2015-04-17 08:57:46','Patch Set 1:\n\n(1 comment)\n\nLooks fine by me, just the typo.',352,1,352,'da7095c5_f93617e7',NULL),(8,'2015-04-17 15:43:38','Patch Set 3: Code-Review+1',352,3,352,'da7095c5_fc3605e7',NULL),(7,'2015-04-16 16:31:16','Uploaded patch set 1.',352,1,352,'fa6b99d7_1a35fd45',NULL),(8,'2015-04-17 10:35:02','Change has been successfully merged into the git repository.',353,10,353,'da7095c5_190f4be3',NULL),(27,'2015-04-17 10:03:24','Patch Set 9: Code-Review+1\n\nMakes sense to me.',353,9,353,'da7095c5_19caeba1',NULL),(28,'2015-04-17 09:52:57','Restored',353,2,353,'da7095c5_19f3cb0b',NULL),(8,'2015-04-17 10:34:59','Patch Set 10: Code-Review+2',353,10,353,'da7095c5_5905c3c0',NULL),(28,'2015-04-17 09:25:52','Abandoned',353,2,353,'da7095c5_5974e39b',NULL),(28,'2015-04-17 09:24:16','Restored',353,1,353,'da7095c5_994a7b54',NULL),(28,'2015-04-17 09:24:48','Uploaded patch set 2.',353,2,353,'da7095c5_b9473f4b',NULL),(8,'2015-04-17 10:34:57','Patch Set 10: Patch Set 9 was rebased',353,9,353,'da7095c5_b9689f88',NULL),(28,'2015-04-17 09:53:25','Patch Set 9: Patch Set 2 was rebased',353,2,353,'da7095c5_b9e3bf32',NULL),(28,'2015-04-17 09:23:38','Abandoned',353,1,353,'da7095c5_d940f337',NULL),(15,'2015-04-17 10:32:11','Patch Set 9: Code-Review+1',353,9,353,'da7095c5_d971d378',NULL),(28,'2015-04-16 17:11:20','Uploaded patch set 1.',353,1,353,'fa6b99d7_1a83bdcd',NULL),(15,'2015-04-17 10:31:30','Patch Set 1: Code-Review+1',354,1,354,'da7095c5_395d6fea',NULL),(27,'2015-04-17 10:09:06','Patch Set 1: Code-Review+1',354,1,354,'da7095c5_39cfafb2',NULL),(8,'2015-04-17 10:35:28','Change has been successfully merged into the git repository.',354,2,354,'da7095c5_99027bb3',NULL),(28,'2015-04-17 09:53:10','Restored',354,1,354,'da7095c5_99e6fb43',NULL),(8,'2015-04-17 10:35:23','Patch Set 2: Patch Set 1 was rebased',354,1,354,'da7095c5_d9f8f3c6',NULL),(28,'2015-04-17 09:26:15','Abandoned',354,1,354,'da7095c5_f964d7e6',NULL),(8,'2015-04-17 10:35:25','Patch Set 2: Code-Review+2',354,2,354,'da7095c5_f9f5b7cb',NULL),(28,'2015-04-16 17:11:20','Uploaded patch set 1.',354,1,354,'fa6b99d7_3a8801e7',NULL),(15,'2015-04-17 10:31:12','Patch Set 1: Code-Review+1',355,1,355,'da7095c5_1958abf9',NULL),(8,'2015-04-17 10:35:59','Patch Set 2: Code-Review+2',355,2,355,'da7095c5_592ce34a',NULL),(8,'2015-04-17 10:36:02','Change has been successfully merged into the git repository.',355,2,355,'da7095c5_7931a7a1',NULL),(8,'2015-04-17 10:35:57','Patch Set 2: Patch Set 1 was rebased',355,1,355,'da7095c5_b9ff3faa',NULL),(28,'2015-04-17 09:26:08','Abandoned',355,1,355,'da7095c5_d96793e9',NULL),(27,'2015-04-17 10:10:22','Patch Set 1: Code-Review+1\n\ninclusion of default config is helpful for those wanting to edit and create their own configs later.',355,1,355,'da7095c5_d9c31389',NULL),(28,'2015-04-17 09:53:07','Restored',355,1,355,'da7095c5_f9d93784',NULL),(28,'2015-04-16 17:11:20','Uploaded patch set 1.',355,1,355,'fa6b99d7_da6c6539',NULL),(28,'2015-04-17 09:26:03','Abandoned',356,1,356,'da7095c5_196e6bca',NULL),(15,'2015-04-17 10:35:16','Patch Set 1:\n\n(1 comment)',356,1,356,'da7095c5_39148ff4',NULL),(8,'2015-04-17 10:58:06','Patch Set 2:\n\n2 +1 in the version previous to the manual rebase.',356,2,356,'da7095c5_59baa3e2',NULL),(15,'2015-04-17 10:31:03','Patch Set 1: Code-Review+1',356,1,356,'da7095c5_7963e7b1',NULL),(8,'2015-04-17 10:58:13','Change has been successfully merged into the git repository.',356,2,356,'da7095c5_79bf67d1',NULL),(27,'2015-04-17 10:33:57','Patch Set 1: Code-Review+1',356,1,356,'da7095c5_996b5b85',NULL),(8,'2015-04-17 10:57:32','Patch Set 2: Code-Review+2',356,2,356,'da7095c5_b9edfff1',NULL),(28,'2015-04-17 09:53:04','Restored',356,1,356,'da7095c5_d9dc7377',NULL),(8,'2015-04-17 10:37:31','Patch Set 1: Code-Review+2',356,1,356,'da7095c5_f91cd715',NULL),(28,'2015-04-17 10:51:59','Uploaded patch set 2.',356,2,356,'da7095c5_f9e37703',NULL),(28,'2015-04-16 17:11:20','Uploaded patch set 1.',356,1,356,'fa6b99d7_fa692926',NULL),(8,'2015-04-17 10:36:51','Patch Set 1: Code-Review+2',357,1,357,'da7095c5_19266b69',NULL),(8,'2015-04-17 10:58:42','Patch Set 2: Code-Review+2',357,2,357,'da7095c5_19b42bf1',NULL),(8,'2015-04-17 10:58:45','Change has been successfully merged into the git repository.',357,2,357,'da7095c5_39b9efe9',NULL),(28,'2015-04-17 09:53:02','Restored',357,1,357,'da7095c5_39f80fe5',NULL),(15,'2015-04-17 10:30:34','Patch Set 1: Code-Review+1',357,1,357,'da7095c5_595e23eb',NULL),(28,'2015-04-17 09:25:57','Abandoned',357,1,357,'da7095c5_7979a792',NULL),(28,'2015-04-17 10:54:08','Patch Set 2: Patch Set 1 was rebased',357,1,357,'da7095c5_99f03bcb',NULL),(28,'2015-04-16 17:11:20','Uploaded patch set 1.',357,1,357,'fa6b99d7_9a76ed05',NULL),(29,'2015-04-16 19:05:46','Uploaded patch set 2.',358,2,358,'fa6b99d7_3a5fa174',NULL),(29,'2015-04-16 18:22:38','Patch Set 1: Code-Review+2\n\nThese changes were reviewed in previous patch sets that targeted\nbaserock/openstack-v7 rather than master, since the changes this\nchange depend on are now merged into master, this change now\ntargets master.',358,1,358,'fa6b99d7_7a651944',NULL),(29,'2015-04-16 18:19:33','Uploaded patch set 1.',358,1,358,'fa6b99d7_ba73b114',NULL),(29,'2015-04-16 19:05:59','Patch Set 2: Code-Review+2',358,2,358,'fa6b99d7_da53056b',NULL),(29,'2015-04-16 19:06:01','Change has been successfully merged into the git repository.',358,2,358,'fa6b99d7_fa504960',NULL),(29,'2015-04-16 18:23:33','Patch Set 1: Code-Review+2\n\nThese changes were reviewed in previous patch sets that targeted\nbaserock/openstack-v7 rather than master, since the changes this\nchange depend on are now merged into master, this change now\ntargets master.',359,1,359,'fa6b99d7_1a5add83',NULL),(29,'2015-04-16 18:19:33','Uploaded patch set 1.',359,1,359,'fa6b99d7_5a605535',NULL),(29,'2015-04-16 19:08:02','Change has been successfully merged into the git repository.',359,2,359,'fa6b99d7_5ac7f512',NULL),(29,'2015-04-16 19:07:23','Patch Set 2: Patch Set 1 was rebased',359,1,359,'fa6b99d7_9a4d8dc7',NULL),(29,'2015-04-16 19:07:31','Patch Set 2: Code-Review+2',359,2,359,'fa6b99d7_ba4ad1aa',NULL),(29,'2015-04-17 10:42:39','Patch Set 3: Patch Set 2 was rebased',360,2,360,'da7095c5_19dd0b43',NULL),(37,'2015-04-17 09:21:40','Patch Set 1: Code-Review+1\n\nInteresting use of templating. If we hadn\'t got the install-files templating in this would have had to have been provided by a separate write extension.\n\nI worry that we\'ll end up with really complicated templates, but this is sufficiently simple, so +1.',360,1,360,'da7095c5_395c8f25',NULL),(29,'2015-04-17 10:42:40','Change has been successfully rebased as 87dfef316f63446cc1ebe91a1402eaa00eb33ead',360,2,360,'da7095c5_39e24f04',NULL),(15,'2015-04-17 09:57:11','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nVery little detail before commit this: see the inline comment\n\nAnother question: I think this conf file should be in the morphology file: Any idea how we plan to do this? Does put the conf file in the morphology and then overwrite it for swift systems sounds like a good idea?',360,1,360,'da7095c5_59d06353',NULL),(15,'2015-04-17 10:42:25','Patch Set 2:\n\n> (1 comment)\n > \n > > (1 comment)\n > >\n > > Very little detail before commit this: see the inline comment\n > >\n > > Another question: I think this conf file should be in the\n > > morphology file: Any idea how we plan to do this? Does put the\n > conf\n > > file in the morphology and then overwrite it for swift systems\n > > sounds like a good idea?\n > \n > I don\'t know whether it makes sense to have a default conf file\n > in the chunk, given ntpd is only used in special circumstances\n > (we use systemd-timesyncd by default) the chances are a default\n > config would not be appropriate for most special circumstances.\n\nWell, distros ship with a default /etc/ntp.conf file and seems to be ok. The idea here is that if someone put ntp in its system, I think we should assume that it wants to use it instead timesyncd, and I think we can make it work out-of-the-box\n\nI will try to write a patch about this so we can discuss about it when all this got merged',360,2,360,'da7095c5_59d38338',NULL),(29,'2015-04-17 10:42:26','Patch Set 2: Code-Review+2',360,2,360,'da7095c5_79d8c753',NULL),(15,'2015-04-17 10:38:45','Patch Set 2: Code-Review+1',360,2,360,'da7095c5_99191b25',NULL),(29,'2015-04-17 10:29:04','Patch Set 1:\n\n(1 comment)\n\n> (1 comment)\n > \n > Very little detail before commit this: see the inline comment\n > \n > Another question: I think this conf file should be in the\n > morphology file: Any idea how we plan to do this? Does put the conf\n > file in the morphology and then overwrite it for swift systems\n > sounds like a good idea?\n\nI don\'t know whether it makes sense to have a default conf file\nin the chunk, given ntpd is only used in special circumstances\n(we use systemd-timesyncd by default) the chances are a default\nconfig would not be appropriate for most special circumstances.',360,1,360,'da7095c5_b9517fda',NULL),(29,'2015-04-17 10:32:54','Uploaded patch set 2.',360,2,360,'da7095c5_f96e1796',NULL),(29,'2015-04-16 22:21:33','Uploaded patch set 1.',360,1,360,'fa6b99d7_fad7e9bd',NULL),(8,'2015-04-17 13:29:26','Patch Set 2: Code-Review+1',361,2,361,'da7095c5_1982eb00',NULL),(7,'2015-04-17 15:00:00','Patch Set 2: Code-Review+2',361,2,361,'da7095c5_39bb2f74',NULL),(7,'2015-04-17 09:09:03','Uploaded patch set 2.',361,2,361,'da7095c5_79520715',NULL),(7,'2015-04-17 09:08:17','Uploaded patch set 1.',361,1,361,'da7095c5_b9309fe9',NULL),(7,'2015-04-17 15:00:01','Patch Set 3: Patch Set 2 was rebased',361,2,361,'da7095c5_d9af932a',NULL),(7,'2015-04-17 15:00:02','Change has been successfully rebased as 660fc606147a0d0d86d47039e8efff13c41bf482',361,2,361,'da7095c5_f9acd737',NULL),(27,'2015-04-17 10:11:08','Patch Set 2: Code-Review+1\n\ninclusion of default config is helpful for people wishing to make their own configs later down the line.',361,2,361,'da7095c5_f9c0577e',NULL),(7,'2015-04-17 09:09:03','Uploaded patch set 2.',362,2,362,'da7095c5_19574b04',NULL),(7,'2015-04-17 15:00:21','Change has been successfully merged into the git repository.',362,3,362,'da7095c5_196d0b05',NULL),(7,'2015-04-17 09:08:17','Uploaded patch set 1.',362,1,362,'da7095c5_594dc371',NULL),(7,'2015-04-17 15:00:15','Patch Set 3: Patch Set 2 was rebased',362,2,362,'da7095c5_5963831a',NULL),(7,'2015-04-17 15:00:18','Patch Set 3: Code-Review+2',362,3,362,'da7095c5_7968c7f5',NULL),(8,'2015-04-17 13:28:12','Patch Set 2:\n\n(1 comment)',362,2,362,'da7095c5_798d2731',NULL),(27,'2015-04-17 10:01:30','Patch Set 2: Code-Review+1\n\nThis looks much as i expected. good job!',362,2,362,'da7095c5_79d52742',NULL),(29,'2015-04-17 14:02:41','Patch Set 2: Code-Review+1\n\n(1 comment)',362,2,362,'da7095c5_99483bce',NULL),(29,'2015-04-17 13:01:07','Patch Set 2:\n\n(1 comment)',362,2,362,'da7095c5_999efb62',NULL),(7,'2015-04-17 15:00:09','Patch Set 2: Code-Review+2',362,2,362,'da7095c5_99a91b27',NULL),(NULL,'2015-04-17 15:00:11','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ic3550f26, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',362,2,362,'da7095c5_b9a65f52',NULL),(28,'2015-04-17 12:31:08','Patch Set 2:\n\n(1 comment)',362,2,362,'da7095c5_d9947346',NULL),(15,'2015-04-17 09:36:00','Patch Set 1: Code-Review+1',363,1,363,'da7095c5_197c2b72',NULL),(7,'2015-04-17 09:26:04','Uploaded patch set 1.',363,1,363,'da7095c5_39732fb3',NULL),(8,'2015-04-17 09:50:08','Patch Set 1: Code-Review+2',363,1,363,'da7095c5_998fdb75',NULL),(8,'2015-04-17 09:50:10','Change has been successfully merged into the git repository.',363,1,363,'da7095c5_b98c1f81',NULL),(8,'2015-04-17 09:49:55','Patch Set 1: Code-Review+1',363,1,363,'da7095c5_f992979e',NULL),(8,'2015-04-23 07:40:48','Patch Set 3: Code-Review+1',364,3,364,'3a79b1b5_74044815',NULL),(6,'2015-04-23 11:38:27','Patch Set 3: Code-Review+2',364,3,364,'3a79b1b5_948fa475',NULL),(6,'2015-04-23 11:38:31','Change has been successfully merged into the git repository.',364,3,364,'3a79b1b5_b48c2081',NULL),(6,'2015-04-22 17:27:02','Uploaded patch set 2.',364,2,364,'5a7ca5a3_b54500b5',NULL),(15,'2015-04-22 22:54:33','Uploaded patch set 3.',364,3,364,'5a7ca5a3_d5767cd8',NULL),(16,'2015-04-17 13:50:35','Patch Set 1:\n\n(1 comment)\n\nThat is correct. I\'ll add a comment.',364,1,364,'da7095c5_19e74be6',NULL),(15,'2015-04-17 13:48:48','Patch Set 1: Code-Review+1\n\nLooks good, it would be great if you can add a comment to the highbank BSPs to know why they are different from the rest',364,1,364,'da7095c5_59ddc313',NULL),(15,'2015-04-17 13:48:05','Patch Set 1: Code-Review+2\n\n(2 comments)',364,1,364,'da7095c5_b9c09f2b',NULL),(16,'2015-04-17 11:20:24','Uploaded patch set 1.',364,1,364,'da7095c5_f9ca976d',NULL),(15,'2015-04-23 11:30:56','Patch Set 3:\n\n(1 comment)',365,3,365,'3a79b1b5_147cf471',NULL),(6,'2015-04-23 11:38:39','Patch Set 3: Code-Review+2',365,3,365,'3a79b1b5_54e90c19',NULL),(8,'2015-04-23 07:39:32','Patch Set 3: Code-Review+1',365,3,365,'3a79b1b5_54ffcc01',NULL),(6,'2015-04-23 11:38:41','Change has been successfully merged into the git repository.',365,3,365,'3a79b1b5_74ee8824',NULL),(8,'2015-04-22 17:29:34','Patch Set 2: Code-Review-1\n\nThis still not add pygoject to the openstack system',365,2,365,'5a7ca5a3_3511f0ac',NULL),(15,'2015-04-22 10:18:38','Patch Set 1: -Code-Review\n\n> Sorry yes, will do. I went for python-pygobject based on the\n > presence of python-cliapp, but I\'ll change it if you like.\n\nI will give you my +1 if you add python-pygobject to the systems/openstack-system-x86_64.morph\n\nThe name was only a suggestion: it can be changed after merged if needed',365,1,365,'5a7ca5a3_357330b3',NULL),(6,'2015-04-22 17:27:02','Uploaded patch set 2.',365,2,365,'5a7ca5a3_55126cb5',NULL),(15,'2015-04-22 22:54:33','Uploaded patch set 3.',365,3,365,'5a7ca5a3_f57378e5',NULL),(8,'2015-04-17 13:41:13','Patch Set 1: Code-Review-1\n\nyou need to add this to system/openstack-system-x86_64.morph too, please',365,1,365,'da7095c5_19998b6e',NULL),(15,'2015-04-17 13:43:23','Patch Set 1: Code-Review-1\n\nI think you have to add python-pygobject to the systems/openstack-system-x86_64.morph system?\n\nAlso, not that important but I\'d call the stratum pygobject-common or python-gobject-common, not python-pygobject',365,1,365,'da7095c5_99acbb8e',NULL),(16,'2015-04-17 11:20:24','Uploaded patch set 1.',365,1,365,'da7095c5_99c7db64',NULL),(16,'2015-04-17 14:00:26','Patch Set 1:\n\nSorry yes, will do. I went for python-pygobject based on the presence of python-cliapp, but I\'ll change it if you like.',365,1,365,'da7095c5_d93eb329',NULL),(8,'2015-04-23 07:41:23','Patch Set 3: Code-Review+1',366,3,366,'3a79b1b5_1409542c',NULL),(6,'2015-04-23 11:38:45','Patch Set 3: Code-Review+2',366,3,366,'3a79b1b5_14f3940b',NULL),(6,'2015-04-23 11:38:47','Change has been successfully merged into the git repository.',366,3,366,'3a79b1b5_34f810e5',NULL),(6,'2015-04-22 17:27:02','Uploaded patch set 2.',366,2,366,'5a7ca5a3_751768a4',NULL),(15,'2015-04-22 22:54:33','Uploaded patch set 3.',366,3,366,'5a7ca5a3_9580048d',NULL),(8,'2015-04-22 17:30:24','Patch Set 2: Code-Review-1\n\nThis should be added to the openstack system',366,2,366,'5a7ca5a3_d5251c0b',NULL),(8,'2015-04-17 13:42:03','Patch Set 1: Code-Review-1\n\n> I think you have to add libsoup-common to the systems/openstack-system-x86_64.morph\n > system?\n\nYes, this is required for systems/openstack-system-x86_64.morph',366,1,366,'da7095c5_399ecf57',NULL),(8,'2015-04-17 13:46:01','Patch Set 1:\n\n> Apologies, that system wasn\'t there when I wrote the patch and I\n > didn\'t check after I rebased onto master.\n\nhehe, no probs, just we don\'t want that the first change breaks Openstack systems :/',366,1,366,'da7095c5_39b56fcd',NULL),(15,'2015-04-17 13:36:04','Patch Set 1: Code-Review-1\n\nI think you have to add libsoup-common to the systems/openstack-system-x86_64.morph system?',366,1,366,'da7095c5_598f0324',NULL),(16,'2015-04-17 13:43:33','Patch Set 1:\n\nApologies, that system wasn\'t there when I wrote the patch and I didn\'t check after I rebased onto master.',366,1,366,'da7095c5_59b623de',NULL),(16,'2015-04-17 11:20:24','Uploaded patch set 1.',366,1,366,'da7095c5_b9c41f60',NULL),(8,'2015-04-23 07:52:50','Patch Set 3: Code-Review+1\n\nJust a comment, I assume that python-pygobject is a runtime dependency of the ostree-core stratum because it is not on it, is this right?',367,3,367,'3a79b1b5_340ed035',NULL),(6,'2015-04-23 11:31:38','Uploaded patch set 5.',367,5,367,'3a79b1b5_3481f04a',NULL),(6,'2015-04-23 09:34:37','Patch Set 3:\n\n> Just a comment, I assume that python-pygobject is a runtime\n > dependency of the ostree-core stratum because it is not on it, is\n > this right?\n\nyes, pygobject is only used by Morph to call the ostree library.',367,3,367,'3a79b1b5_544d8c71',NULL),(6,'2015-04-23 11:19:54','Uploaded patch set 4.',367,4,367,'3a79b1b5_54826c53',NULL),(6,'2015-04-23 11:35:06','Uploaded patch set 6.',367,6,367,'3a79b1b5_d4951c89',NULL),(6,'2015-04-23 11:38:52','Patch Set 6: Code-Review+2',367,6,367,'3a79b1b5_d4dc3c77',NULL),(15,'2015-04-23 11:37:27','Patch Set 6: Code-Review+1',367,6,367,'3a79b1b5_f492989e',NULL),(6,'2015-04-23 11:38:54','Change has been successfully merged into the git repository.',367,6,367,'3a79b1b5_f4d93884',NULL),(6,'2015-04-22 17:27:02','Uploaded patch set 2.',367,2,367,'5a7ca5a3_150cf493',NULL),(15,'2015-04-22 11:21:35','Patch Set 1: -Code-Review\n\n> Indeed, but I can\'t remember how much of tools is depended on by\n > ostree-core and so would like to send a further patch for those\n > systems later (e.g. when morph actually needs it present) when I\'ve\n > had time to test properly and decide what to do.\n\nFYI: I can build ostree-core stratum without the tools stratum at all (you just have to replace - morph: strata/tools.morph for - morph: strata/foundation.morph)',367,1,367,'5a7ca5a3_35cfb0b2',NULL),(27,'2015-04-22 12:05:30','Patch Set 1: Code-Review+1\n\nseems a sensible upgrade',367,1,367,'5a7ca5a3_7563e8b1',NULL),(15,'2015-04-22 22:54:33','Uploaded patch set 3.',367,3,367,'5a7ca5a3_b57d00b4',NULL),(15,'2015-04-22 13:46:44','Patch Set 1: Code-Review-1\n\ncross-bootstrap-system-* systems are missing',367,1,367,'5a7ca5a3_b5ed00f2',NULL),(15,'2015-04-17 13:51:41','Patch Set 1: Code-Review-1\n\nI think the cross-bootstrap-system-* systems are missing?',367,1,367,'da7095c5_39ec8fc7',NULL),(16,'2015-04-17 11:20:24','Uploaded patch set 1.',367,1,367,'da7095c5_59a143a8',NULL),(16,'2015-04-17 13:57:56','Patch Set 1:\n\nIndeed, but I can\'t remember how much of tools is depended on by ostree-core and so would like to send a further patch for those systems later (e.g. when morph actually needs it present) when I\'ve had time to test properly and decide what to do.',367,1,367,'da7095c5_b9d73fed',NULL),(37,'2015-04-17 14:03:09','Patch Set 1:\n\n(1 comment)',368,1,368,'da7095c5_5912a3b5',NULL),(29,'2015-04-17 14:23:47','Patch Set 1: Code-Review+2',368,1,368,'da7095c5_59606335',NULL),(29,'2015-04-17 14:23:52','Change has been successfully merged into the git repository.',368,1,368,'da7095c5_79652744',NULL),(29,'2015-04-17 11:21:59','Uploaded patch set 1.',368,1,368,'da7095c5_79a687c3',NULL),(29,'2015-04-17 14:10:27','Patch Set 1:\n\n(1 comment)',368,1,368,'da7095c5_9976fb05',NULL),(29,'2015-04-17 13:53:47','Patch Set 1:\n\n(2 comments)',368,1,368,'da7095c5_99da7b16',NULL),(37,'2015-04-17 13:34:49','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nI\'m just confused and grumbling.',368,1,368,'da7095c5_b972df47',NULL),(7,'2015-04-17 14:22:02','Patch Set 1: Code-Review+1',368,1,368,'da7095c5_b973bf14',NULL),(29,'2015-04-17 14:46:24','Patch Set 2: Code-Review+1',369,2,369,'da7095c5_19e8ab7b',NULL),(7,'2015-04-17 15:51:47','Patch Set 2: Code-Review+2',369,2,369,'da7095c5_1c6e59ca',NULL),(7,'2015-04-17 15:51:50','Patch Set 3: Patch Set 2 was rebased',369,2,369,'da7095c5_3c731db3',NULL),(29,'2015-04-17 13:43:55','Patch Set 1:\n\n(2 comments)',369,1,369,'da7095c5_79bbe7c4',NULL),(37,'2015-04-17 14:43:31','Uploaded patch set 2.',369,2,369,'da7095c5_79f3e773',NULL),(29,'2015-04-17 13:33:50','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nstill reviewing...',369,1,369,'da7095c5_99759b34',NULL),(29,'2015-04-17 13:47:49','Patch Set 1:\n\n(1 comment)',369,1,369,'da7095c5_99c35b38',NULL),(37,'2015-04-17 13:27:50','Uploaded patch set 1.',369,1,369,'da7095c5_b99bbf71',NULL),(7,'2015-04-17 15:51:50','Change has been successfully rebased as 1dfb2680c0025bf9b248adb3cb0a878b1119573b',369,2,369,'da7095c5_dc6781e9',NULL),(7,'2015-04-20 08:12:14','Patch Set 1: Code-Review+2',370,1,370,'9a6a9dd7_57ffcc01',NULL),(7,'2015-04-20 08:13:33','Patch Set 2: Patch Set 1 was rebased',370,1,370,'9a6a9dd7_d7399cd9',NULL),(7,'2015-04-20 08:13:34','Change has been successfully rebased as 3c433d81ef86c3a0195843ab8423ac3ae11e887b',370,1,370,'9a6a9dd7_f73620e7',NULL),(26,'2015-04-17 13:59:22','Uploaded patch set 1.',370,1,370,'da7095c5_5904e37d',NULL),(8,'2015-04-17 14:07:03','Patch Set 1: Code-Review+1',370,1,370,'da7095c5_d96c7339',NULL),(7,'2015-04-20 08:13:50','Change has been successfully merged into the git repository.',371,2,371,'9a6a9dd7_17571404',NULL),(7,'2015-04-20 08:13:45','Patch Set 2: Patch Set 1 was rebased',371,1,371,'9a6a9dd7_574d8c71',NULL),(7,'2015-04-20 08:12:22','Patch Set 1: Code-Review+2',371,1,371,'9a6a9dd7_77045015',NULL),(7,'2015-04-20 08:13:48','Patch Set 2: Code-Review+2',371,2,371,'9a6a9dd7_77521015',NULL),(NULL,'2015-04-20 08:13:38','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I369d9ddb, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',371,1,371,'9a6a9dd7_b730a8e9',NULL),(8,'2015-04-17 14:06:58','Patch Set 1: Code-Review+1',371,1,371,'da7095c5_39880fe7',NULL),(26,'2015-04-17 13:59:22','Uploaded patch set 1.',371,1,371,'da7095c5_7909a794',NULL),(7,'2015-04-20 08:12:24','Patch Set 1: Code-Review+2',372,1,372,'9a6a9dd7_1709542c',NULL),(7,'2015-04-20 08:13:58','Change has been successfully merged into the git repository.',372,2,372,'9a6a9dd7_974a4454',NULL),(7,'2015-04-20 08:13:55','Patch Set 2: Patch Set 1 was rebased',372,1,372,'9a6a9dd7_d740bc37',NULL),(7,'2015-04-20 08:13:57','Patch Set 2: Code-Review+2',372,2,372,'9a6a9dd7_f73dc0bc',NULL),(8,'2015-04-17 14:06:54','Patch Set 1: Code-Review+1',372,1,372,'da7095c5_1983cbcd',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',372,1,372,'da7095c5_19fe6b6c',NULL),(7,'2015-04-20 08:14:05','Change has been successfully merged into the git repository.',373,2,373,'9a6a9dd7_176e34ca',NULL),(7,'2015-04-20 08:12:26','Patch Set 1: Code-Review+2',373,1,373,'9a6a9dd7_370ed835',NULL),(7,'2015-04-20 08:14:02','Patch Set 2: Patch Set 1 was rebased',373,1,373,'9a6a9dd7_5774ac9b',NULL),(7,'2015-04-20 08:14:04','Patch Set 2: Code-Review+2',373,2,373,'9a6a9dd7_7779b092',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',373,1,373,'da7095c5_39032f75',NULL),(8,'2015-04-17 14:06:50','Patch Set 1: Code-Review+1',373,1,373,'da7095c5_797e87e6',NULL),(7,'2015-04-20 08:14:12','Change has been successfully merged into the git repository.',374,2,374,'9a6a9dd7_9761e4d5',NULL),(7,'2015-04-20 08:12:29','Patch Set 1: Code-Review+2',374,1,374,'9a6a9dd7_d712fc57',NULL),(7,'2015-04-20 08:14:08','Patch Set 2: Patch Set 1 was rebased',374,1,374,'9a6a9dd7_d7675ce9',NULL),(7,'2015-04-20 08:14:10','Patch Set 2: Code-Review+2',374,2,374,'9a6a9dd7_f764e0e6',NULL),(8,'2015-04-17 14:06:46','Patch Set 1: Code-Review+1',374,1,374,'da7095c5_597943fb',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',374,1,374,'da7095c5_d9f7938b',NULL),(7,'2015-04-20 08:14:19','Change has been successfully merged into the git repository.',375,2,375,'9a6a9dd7_17a5d403',NULL),(7,'2015-04-20 08:14:16','Patch Set 2: Patch Set 1 was rebased',375,1,375,'9a6a9dd7_579b4cc9',NULL),(7,'2015-04-20 08:14:18','Patch Set 2: Code-Review+2',375,2,375,'9a6a9dd7_77a0d0f4',NULL),(7,'2015-04-20 08:12:32','Patch Set 1: Code-Review+2',375,1,375,'9a6a9dd7_f70f002d',NULL),(8,'2015-04-17 14:06:41','Patch Set 1: Code-Review+1',375,1,375,'da7095c5_b91c1fc3',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',375,1,375,'da7095c5_f9f4d788',NULL),(7,'2015-04-20 08:12:34','Patch Set 1: Code-Review+2',376,1,376,'9a6a9dd7_971c846c',NULL),(7,'2015-04-20 08:14:25','Change has been successfully merged into the git repository.',376,2,376,'9a6a9dd7_97b8042c',NULL),(7,'2015-04-20 08:14:22','Patch Set 2: Patch Set 1 was rebased',376,1,376,'9a6a9dd7_d7ae7ce7',NULL),(7,'2015-04-20 08:14:24','Patch Set 2: Code-Review+2',376,2,376,'9a6a9dd7_f7ab80d4',NULL),(8,'2015-04-17 14:06:38','Patch Set 1: Code-Review+1',376,1,376,'da7095c5_991fdbb7',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',376,1,376,'da7095c5_99f11b98',NULL),(7,'2015-04-20 08:14:31','Change has been successfully merged into the git repository.',377,2,377,'9a6a9dd7_177cf471',NULL),(7,'2015-04-20 08:14:28','Patch Set 2: Patch Set 1 was rebased',377,1,377,'9a6a9dd7_57826c53',NULL),(7,'2015-04-20 08:14:29','Patch Set 2: Code-Review+2',377,2,377,'9a6a9dd7_77877062',NULL),(7,'2015-04-20 08:12:38','Patch Set 1: Code-Review+2',377,1,377,'9a6a9dd7_b719887b',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',377,1,377,'da7095c5_b9ee5fb3',NULL),(8,'2015-04-17 14:06:32','Patch Set 1: Code-Review+1',377,1,377,'da7095c5_f9229700',NULL),(7,'2015-04-20 08:13:14','Patch Set 1: Code-Review+2',378,1,378,'9a6a9dd7_5726ecbb',NULL),(7,'2015-04-20 08:14:37','Change has been successfully merged into the git repository.',378,2,378,'9a6a9dd7_978fa475',NULL),(7,'2015-04-20 08:14:34','Patch Set 2: Patch Set 1 was rebased',378,1,378,'9a6a9dd7_d7951c89',NULL),(7,'2015-04-20 08:14:35','Patch Set 2: Code-Review+2',378,2,378,'9a6a9dd7_f792a09e',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',378,1,378,'da7095c5_592b83eb',NULL),(8,'2015-04-17 14:06:28','Patch Set 1: Code-Review+1',378,1,378,'da7095c5_d925530b',NULL),(7,'2015-04-20 08:14:42','Change has been successfully merged into the git repository.',379,2,379,'9a6a9dd7_17f3940b',NULL),(7,'2015-04-20 08:14:39','Patch Set 2: Patch Set 1 was rebased',379,1,379,'9a6a9dd7_57e90c19',NULL),(7,'2015-04-20 08:13:17','Patch Set 1: Code-Review+2',379,1,379,'9a6a9dd7_772bf082',NULL),(7,'2015-04-20 08:14:41','Patch Set 2: Code-Review+2',379,2,379,'9a6a9dd7_77ee9024',NULL),(8,'2015-04-17 14:06:24','Patch Set 1: Code-Review+1',379,1,379,'da7095c5_3911efac',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',379,1,379,'da7095c5_7930c756',NULL),(7,'2015-04-20 08:13:20','Patch Set 1: Code-Review+2',380,1,380,'9a6a9dd7_1720749a',NULL),(7,'2015-04-20 08:14:51','Change has been successfully merged into the git repository.',380,2,380,'9a6a9dd7_97e6c443',NULL),(7,'2015-04-20 08:14:46','Patch Set 2: Patch Set 1 was rebased',380,1,380,'9a6a9dd7_d7dc3c77',NULL),(7,'2015-04-20 08:14:48','Patch Set 2: Code-Review+2',380,2,380,'9a6a9dd7_f7d94084',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',380,1,380,'da7095c5_19350b46',NULL),(8,'2015-04-17 14:04:40','Patch Set 1: Code-Review+1\n\nThanks for rework this',380,1,380,'da7095c5_791767a4',NULL),(7,'2015-04-20 08:14:57','Change has been successfully merged into the git repository.',381,2,381,'9a6a9dd7_17cab4a1',NULL),(7,'2015-04-20 08:13:23','Patch Set 1: Code-Review+2',381,1,381,'9a6a9dd7_372578ab',NULL),(NULL,'2015-04-20 08:13:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba.\n* Depends on patch set 1 of I2a815688.\n* Depends on patch set 1 of I9dced77c.\n* Depends on patch set 1 of I54b56741.\n* Depends on patch set 1 of Ifb37ebb7.\n* Depends on patch set 1 of Ie1c0ed80, however the current patch set is 2.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_375c9825',NULL),(NULL,'2015-04-20 08:14:05','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba.\n* Depends on patch set 1 of I2a815688.\n* Depends on patch set 1 of I9dced77c.\n* Depends on patch set 1 of I54b56741, however the current patch set is 2.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_377338b3',NULL),(NULL,'2015-04-20 08:14:31','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8, however the current patch set is 2.\n* Depends on commit 649054722aae711108b4a5163da9ecdf97296bef which has no change associated with it.\n* Depends on commit d287f9072e4f3876f7f8d61c5f9b9d3c12b2779c which has no change associated with it.\n* Depends on commit 04010242449ea3b749b5d96b9079e2414dd1f16b which has no change associated with it.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_3781f84a',NULL),(NULL,'2015-04-20 08:14:19','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba.\n* Depends on patch set 1 of I2a815688, however the current patch set is 2.\n* Depends on commit 04010242449ea3b749b5d96b9079e2414dd1f16b which has no change associated with it.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_37aa58d5',NULL),(NULL,'2015-04-20 08:14:43','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9, however the current patch set is 2.\n* Depends on commit ee0ce28983ba15b504fa0d1adedb44c24b83b08a which has no change associated with it.\n* Depends on commit 3b5e027a2d376b204c106e6456b178d306d1a8b3 which has no change associated with it.\n* Depends on commit 649054722aae711108b4a5163da9ecdf97296bef which has no change associated with it.\n* Depends on commit d287f9072e4f3876f7f8d61c5f9b9d3c12b2779c which has no change associated with it.\n* Depends on commit 04010242449ea3b749b5d96b9079e2414dd1f16b which has no change associated with it.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_37f818e5',NULL),(7,'2015-04-20 08:14:53','Patch Set 2: Patch Set 1 was rebased',381,1,381,'9a6a9dd7_57d02c53',NULL),(7,'2015-04-20 08:14:55','Patch Set 2: Code-Review+2',381,2,381,'9a6a9dd7_77d53042',NULL),(NULL,'2015-04-20 08:13:38','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba.\n* Depends on patch set 1 of I2a815688.\n* Depends on patch set 1 of I9dced77c.\n* Depends on patch set 1 of I54b56741.\n* Depends on patch set 1 of Ifb37ebb7.\n* Depends on patch set 1 of I369d9ddb, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_973324f6',NULL),(NULL,'2015-04-20 08:13:58','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba.\n* Depends on patch set 1 of I2a815688.\n* Depends on patch set 1 of I9dced77c.\n* Depends on patch set 1 of I54b56741.\n* Depends on patch set 1 of Ifb37ebb7, however the current patch set is 2.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_b747484b',NULL),(NULL,'2015-04-20 08:14:12','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba.\n* Depends on patch set 1 of I2a815688.\n* Depends on patch set 1 of I9dced77c, however the current patch set is 2.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_b75e6811',NULL),(NULL,'2015-04-20 08:14:37','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa, however the current patch set is 2.\n* Depends on commit 3b5e027a2d376b204c106e6456b178d306d1a8b3 which has no change associated with it.\n* Depends on commit 649054722aae711108b4a5163da9ecdf97296bef which has no change associated with it.\n* Depends on commit d287f9072e4f3876f7f8d61c5f9b9d3c12b2779c which has no change associated with it.\n* Depends on commit 04010242449ea3b749b5d96b9079e2414dd1f16b which has no change associated with it.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_b78c2881',NULL),(NULL,'2015-04-20 08:14:25','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476.\n* Depends on patch set 1 of I6cfd9cb9.\n* Depends on patch set 1 of I20e625fa.\n* Depends on patch set 1 of I80d86ce8.\n* Depends on patch set 1 of Ie5a1a4ba, however the current patch set is 2.\n* Depends on commit d287f9072e4f3876f7f8d61c5f9b9d3c12b2779c which has no change associated with it.\n* Depends on commit 04010242449ea3b749b5d96b9079e2414dd1f16b which has no change associated with it.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_b7b50833',NULL),(NULL,'2015-04-20 08:14:51','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ic5773476, however the current patch set is 2.\n* Depends on commit 0878c8d34c9aceaa7f6f09a948cb5f395751620f which has no change associated with it.\n* Depends on commit ee0ce28983ba15b504fa0d1adedb44c24b83b08a which has no change associated with it.\n* Depends on commit 3b5e027a2d376b204c106e6456b178d306d1a8b3 which has no change associated with it.\n* Depends on commit 649054722aae711108b4a5163da9ecdf97296bef which has no change associated with it.\n* Depends on commit d287f9072e4f3876f7f8d61c5f9b9d3c12b2779c which has no change associated with it.\n* Depends on commit 04010242449ea3b749b5d96b9079e2414dd1f16b which has no change associated with it.\n* Depends on commit df9e7e445bded4a5d5017ba977305ccadd29c331 which has no change associated with it.\n* Depends on commit c383a744c5b6099f4c50e5db2716c9800d23e1f2 which has no change associated with it.\n* Depends on commit fe4abd3952978d36644f2fbc6344194c3e6d6482 which has no change associated with it.\n* Depends on commit 668d76e0e8bab6441ba3dbe148a5204dc52e07f3 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',381,1,381,'9a6a9dd7_b7e3c832',NULL),(8,'2015-04-17 14:06:18','Patch Set 1: Code-Review+1',381,1,381,'da7095c5_190c2b94',NULL),(26,'2015-04-17 13:59:23','Uploaded patch set 1.',381,1,381,'da7095c5_393a4f37',NULL),(27,'2015-04-17 14:53:58','Patch Set 1: Code-Review+1\n\nlooks good to me!',382,1,382,'da7095c5_39a48f56',NULL),(43,'2015-04-17 14:49:21','Uploaded patch set 1.',382,1,382,'da7095c5_39ed6f8c',NULL),(15,'2015-04-17 17:15:23','Patch Set 2: Patch Set 1 was rebased',382,1,382,'da7095c5_9c8fc975',NULL),(8,'2015-04-17 15:02:07','Patch Set 1: Code-Review+1',382,1,382,'da7095c5_b97dffb3',NULL),(15,'2015-04-17 17:15:24','Change has been successfully rebased as cd8260cc5d7537571f68ee5b47c5b0308268e853',382,1,382,'da7095c5_bc8c0d81',NULL),(37,'2015-04-17 15:00:47','Patch Set 1: Code-Review+1',382,1,382,'da7095c5_d976b3d8',NULL),(15,'2015-04-17 17:15:20','Patch Set 1: Code-Review+2',382,1,382,'da7095c5_fc92859e',NULL),(7,'2015-04-17 17:16:49','Patch Set 2: Patch Set 1 was rebased',383,1,383,'da7095c5_3cf8fde4',NULL),(15,'2015-04-17 17:15:46','Patch Set 1: Code-Review+2',383,1,383,'da7095c5_5ce93119',NULL),(NULL,'2015-04-17 17:15:49','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ia5c5afda, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',383,1,383,'da7095c5_7cee7524',NULL),(43,'2015-04-17 14:49:21','Uploaded patch set 1.',383,1,383,'da7095c5_d901d33a',NULL),(7,'2015-04-17 17:16:51','Patch Set 2: Code-Review+2',383,2,383,'da7095c5_dcdc6177',NULL),(37,'2015-04-17 15:01:31','Patch Set 1: Code-Review+1',383,1,383,'da7095c5_f97377e5',NULL),(27,'2015-04-17 14:55:56','Patch Set 1: Code-Review+1\n\nkeeping the default config files in is good incase anyone needs to make their config files from the ground up, and it allows people to see what has been changed in our modified config files.',383,1,383,'da7095c5_f985b7ad',NULL),(7,'2015-04-17 17:16:53','Change has been successfully merged into the git repository.',383,2,383,'da7095c5_fcd92584',NULL),(37,'2015-04-17 15:10:21','Patch Set 1:\n\n(3 comments)\n\nThis follows the pre-multi-node split design, where we had all the services started and enabled by the ansible script that sorted out the config, but if this runs entirely on the controller node it should be fine.\n\nThe difficulty is that there\'s no way to specify this currently, except for removing it from the system definition.',384,1,384,'da7095c5_193bcbec',NULL),(43,'2015-04-17 16:28:41','Patch Set 1:\n\n(1 comment)\n\n> (1 comment)\n > \n > Services of ceilometer need to be `After=openstack-ceilometer-setup.service`\n\nThis can be done, I just conformed to the style of the other units present in master at the time of writing\n \n > Also if it is possible, have a look at the openstack-in-3-nodes\n > branch to split the db from the setup script so you will have a\n > config-setup service and a db-setup service which will make easier\n > to split for 3 nodes.\n\nYep',384,1,384,'da7095c5_1ca5f903',NULL),(7,'2015-04-17 17:30:26','Change has been successfully merged into the git repository.',384,5,384,'da7095c5_1ccad9a1',NULL),(8,'2015-04-17 15:07:29','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nServices of ceilometer need to be `After=openstack-ceilometer-setup.service`\n\nAlso if it is possible, have a look at the openstack-in-3-nodes branch to split the db from the setup script so you will have a config-setup service and a db-setup service which will make easier to split for 3 nodes.',384,1,384,'da7095c5_5931430a',NULL),(7,'2015-04-17 17:30:20','Patch Set 5: Patch Set 4 was rebased',384,4,384,'da7095c5_5cd05153',NULL),(43,'2015-04-17 16:47:37','Uploaded patch set 2.',384,2,384,'da7095c5_7c875562',NULL),(7,'2015-04-17 17:30:25','Patch Set 5: Code-Review+2',384,5,384,'da7095c5_7cd51542',NULL),(27,'2015-04-17 15:02:06','Patch Set 1: Code-Review+1\n\nlooks good to me!',384,1,384,'da7095c5_99803b8d',NULL),(43,'2015-04-17 16:00:00','Patch Set 1:\n\n(3 comments)',384,1,384,'da7095c5_9c6109d6',NULL),(43,'2015-04-17 17:27:56','Uploaded patch set 4.',384,4,384,'da7095c5_9ce6e943',NULL),(8,'2015-04-17 17:29:43','Patch Set 4: Code-Review+1',384,4,384,'da7095c5_bce3ad32',NULL),(43,'2015-04-17 17:08:08','Uploaded patch set 3.',384,3,384,'da7095c5_dc954189',NULL),(43,'2015-04-17 14:49:21','Uploaded patch set 1.',384,1,384,'da7095c5_f9fe1738',NULL),(33,'2015-04-22 08:05:28','Patch Set 2: Code-Review+1',385,2,385,'5a7ca5a3_350ed035',NULL),(15,'2015-04-22 10:12:57','Change has been successfully rebased as 30f14e212cb62026b17b43cdda24587c570aff72',385,2,385,'5a7ca5a3_5574ac9b',NULL),(15,'2015-04-22 10:12:54','Patch Set 2: Code-Review+2',385,2,385,'5a7ca5a3_954a4454',NULL),(15,'2015-04-22 10:12:56','Patch Set 3: Patch Set 2 was rebased',385,2,385,'5a7ca5a3_b547404b',NULL),(27,'2015-04-21 13:13:05','Patch Set 2: Code-Review+1',385,2,385,'7a7fa997_76e210d7',NULL),(7,'2015-04-20 08:23:57','Patch Set 1: Code-Review-1\n\nShouldn\'t the swift manifest [1] have the \'overwrite\' flag in the /etc/ntp.conf file?\n\n[1]: http://git.baserock.org/cgi-bin/cgit.cgi/baserock/baserock/definitions.git/tree/swift/manifest',385,1,385,'9a6a9dd7_37cfb8b2',NULL),(33,'2015-04-20 08:46:58','Patch Set 1: Code-Review-1\n\n> Shouldn\'t the swift manifest [1] have the \'overwrite\' flag in the\n > /etc/ntp.conf file?\n > \n > [1]: http://git.baserock.org/cgi-bin/cgit.cgi/baserock/baserock/definitions.git/tree/swift/manifest\n\nYes, good catch :)',385,1,385,'9a6a9dd7_d7c3dc88',NULL),(15,'2015-04-20 13:54:17','Uploaded patch set 2.',385,2,385,'9a6a9dd7_d7f8bcc6',NULL),(33,'2015-04-19 20:35:36','Patch Set 1:\n\n(1 comment)\n\nI just noticed something I didn\'t notice the other day.\n\nAside from that, yes I think we could merge this,\nas long as we make sure we patch ntpd.',385,1,385,'ba65a107_186e65ca',NULL),(29,'2015-04-19 13:11:44','Patch Set 1: -Code-Review',385,1,385,'ba65a107_58261dbc',NULL),(15,'2015-04-19 20:14:45','Patch Set 1:\n\n> >\n > > Not sure I understand why: the rlimit change has been added in\n > > swift/etc/ntp.conf , so the resulting system is the same here as\n > in\n > > the ntpd extension. Maybe I\'m missing something?\n > \n > ntpd wants to have its memory locked\n > (to make sure it can respond to queries with minimal latency)\n > but it doesn\'t lock enough by default at least not for linux\n > running on x86-64, so it will typically crash with some vague\n > \"out of memory\" error. the rlimit can be increased in the config\n > file, but given that it doesn\'t make sense to run with the default\n > rlimit I think we would probably be better off patching ntpd\n > itself.\n\nI could agree with that but I think thats a change that should be done in another commit; as the result system will be different from what we already have with the extension.\nSo, if you dont have any other concerns, can we merge this and decide to change to patch the chunk directly in a poterior commit?',385,1,385,'ba65a107_5874dd9b',NULL),(33,'2015-04-19 21:16:45','Patch Set 1: Code-Review+1\n\n(1 comment)',385,1,385,'ba65a107_986115d6',NULL),(33,'2015-04-19 13:10:40','Patch Set 1: Code-Review-1\n\nThe config installed at post-install seems reasonable\n\nIf we want to remove the ntp.configure extension then we need to patch\nntpd to set a higher rlimit by default.\n\nAs it stands I am quite sure that merging this change would cause\nntp servers to fail to start on at least x86-64.\n\nI\'d suggest patching ntpd and then dropping the change to the\nswift install-files.',385,1,385,'ba65a107_b819797b',NULL),(33,'2015-04-19 19:59:26','Patch Set 1:\n\n> \n > Not sure I understand why: the rlimit change has been added in\n > swift/etc/ntp.conf , so the resulting system is the same here as in\n > the ntpd extension. Maybe I\'m missing something?\n\nntpd wants to have its memory locked\n(to make sure it can respond to queries with minimal latency)\nbut it doesn\'t lock enough by default at least not for linux\nrunning on x86-64, so it will typically crash with some vague\n\"out of memory\" error. the rlimit can be increased in the config\nfile, but given that it doesn\'t make sense to run with the default\nrlimit I think we would probably be better off patching ntpd itself.',385,1,385,'ba65a107_b847394b',NULL),(15,'2015-04-19 19:43:43','Patch Set 1:\n\n> The config installed at post-install seems reasonable\n > \n > If we want to remove the ntp.configure extension then we need to\n > patch\n > ntpd to set a higher rlimit by default.\n > \n > As it stands I am quite sure that merging this change would cause\n > ntp servers to fail to start on at least x86-64.\n > \n > I\'d suggest patching ntpd and then dropping the change to the\n > swift install-files.\n\nCan we change the default ntp.conf (the one denied in the morphology file) so we can avoid a delta with upstream?',385,1,385,'ba65a107_d840ed37',NULL),(15,'2015-04-19 20:59:02','Patch Set 1:\n\n(1 comment)',385,1,385,'ba65a107_d8678de9',NULL),(15,'2015-04-19 19:46:30','Patch Set 1:\n\n> The config installed at post-install seems reasonable\n > \n > If we want to remove the ntp.configure extension then we need to\n > patch\n > ntpd to set a higher rlimit by default.\n\nNot sure I understand why: the rlimit change has been added in swift/etc/ntp.conf , so the resulting system is the same here as in the ntpd extension. Maybe I\'m missing something?',385,1,385,'ba65a107_f83db1bc',NULL),(29,'2015-04-17 15:04:24','Patch Set 1: Code-Review-2\n\nThis will break swift',385,1,385,'da7095c5_3949ef8b',NULL),(15,'2015-04-17 14:53:04','Uploaded patch set 1.',385,1,385,'da7095c5_799a0716',NULL),(29,'2015-04-17 15:12:09','Patch Set 1:\n\n> This will break swift\n\nFor the record, I also encourage us to move away from ntpd.configure,\nbut I\'d suggest we perhaps patch ntpd\'s hardcoded rlimit in its source,\nwe definitely want to let the openstack stuff settle before changing\nntpd configuration, so I\'m temporarily blocking this change.',385,1,385,'da7095c5_d92473c8',NULL),(7,'2015-04-17 15:04:22','Patch Set 1: Code-Review+1',386,1,386,'da7095c5_19442b73',NULL),(27,'2015-04-17 15:10:43','Patch Set 1: Code-Review+1',386,1,386,'da7095c5_39400f56',NULL),(7,'2015-04-17 15:14:13','Patch Set 2: Patch Set 1 was rebased',386,1,386,'da7095c5_992efba4',NULL),(29,'2015-04-17 14:56:39','Uploaded patch set 1.',386,1,386,'da7095c5_99927bf5',NULL),(7,'2015-04-17 15:14:13','Change has been successfully rebased as 2514cc238778ec5679db481cce7517f453351869',386,1,386,'da7095c5_b92bbf93',NULL),(43,'2015-04-17 15:07:28','Patch Set 1: Code-Review+1',386,1,386,'da7095c5_b9541f22',NULL),(7,'2015-04-17 15:14:11','Patch Set 1: Code-Review+2',386,1,386,'da7095c5_f92137b5',NULL),(15,'2015-04-17 15:20:10','Uploaded patch set 1.',387,1,387,'da7095c5_59186384',NULL),(7,'2015-04-17 15:47:29','Patch Set 2: Patch Set 1 was rebased',387,1,387,'da7095c5_5c74d19b',NULL),(7,'2015-04-17 15:47:29','Change has been successfully rebased as b658fbb518d64d3ff66e1b0f5d6d28d1210dd348',387,1,387,'da7095c5_7c799592',NULL),(7,'2015-04-17 15:47:25','Patch Set 1: Code-Review+2',387,1,387,'da7095c5_bc472d4b',NULL),(8,'2015-04-17 15:33:21','Patch Set 1: Code-Review+1',387,1,387,'da7095c5_fc0fe52c',NULL),(7,'2015-04-17 16:39:13','Uploaded patch set 1.',388,1,388,'da7095c5_3caa3dd5',NULL),(8,'2015-04-17 16:46:56','Patch Set 1: Code-Review+1\n\nFair enough :)',388,1,388,'da7095c5_5c829153',NULL),(7,'2015-04-17 17:34:23','Patch Set 2: Patch Set 1 was rebased',388,1,388,'da7095c5_9cbd8905',NULL),(7,'2015-04-17 16:44:54','Patch Set 1:\n\n(1 comment)',388,1,388,'da7095c5_bcb5ed32',NULL),(7,'2015-04-17 17:34:24','Change has been successfully rebased as 1dc8ee2a80e041968b20053fc629f9803afc2924',388,1,388,'da7095c5_bcbacd08',NULL),(43,'2015-04-17 17:33:58','Patch Set 1: Code-Review+1\n\nLooks sensible',388,1,388,'da7095c5_dcc30189',NULL),(8,'2015-04-17 16:41:59','Patch Set 1:\n\n(1 comment)',388,1,388,'da7095c5_fcab65d4',NULL),(7,'2015-04-17 17:34:22','Patch Set 1: Code-Review+2',388,1,388,'da7095c5_fcc0457e',NULL),(37,'2015-04-22 14:41:20','Change has been successfully rebased as 71797241802b692f6be53b0aa4e5d61658c6792b',389,1,389,'5a7ca5a3_55882c22',NULL),(37,'2015-04-22 14:41:13','Patch Set 1: Code-Review+2',389,1,389,'5a7ca5a3_959ec462',NULL),(37,'2015-04-22 14:41:20','Patch Set 2: Patch Set 1 was rebased',389,1,389,'5a7ca5a3_b59bc071',NULL),(37,'2015-04-17 17:05:47','Uploaded patch set 1.',389,1,389,'da7095c5_1c7c1972',NULL),(8,'2015-04-17 17:31:10','Patch Set 1: Code-Review+1',389,1,389,'da7095c5_3ccf9db2',NULL),(8,'2015-04-22 15:46:26','Patch Set 2: Patch Set 1 was rebased',390,1,390,'5a7ca5a3_1599546e',NULL),(8,'2015-04-22 15:46:28','Patch Set 2: Code-Review+2',390,2,390,'5a7ca5a3_359ed057',NULL),(8,'2015-04-22 15:46:11','Patch Set 1: Code-Review+2',390,1,390,'5a7ca5a3_558fcc23',NULL),(NULL,'2015-04-22 15:46:15','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I645d11af, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',390,1,390,'5a7ca5a3_75944837',NULL),(42,'2015-04-22 10:11:54','Patch Set 1:\n\n(1 comment)',390,1,390,'5a7ca5a3_d540bc37',NULL),(8,'2015-04-22 15:46:32','Change has been successfully merged into the git repository.',390,2,390,'5a7ca5a3_d5a2fc99',NULL),(43,'2015-04-21 10:57:10','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nSee comments.',390,1,390,'7a7fa997_160f1ce3',NULL),(37,'2015-04-17 17:05:47','Uploaded patch set 1.',390,1,390,'da7095c5_3c81dd4a',NULL),(8,'2015-04-17 17:34:31','Patch Set 1: Code-Review+1',390,1,390,'da7095c5_5c37f1b0',NULL),(15,'2015-04-20 11:36:17','Patch Set 1:\n\n> Even if I could be persuaded unique naming across definitions\n > is necessary I wouldn\'t arbitrarily append \'group\' to every\n > stratum, instead I\'d rename strata to match the functions\n > they perform as Emmet suggested, so for example the \'swift\'\n > stratum would become the \'distributed-object-storage\' stratum,\n > the \'ntpd\' stratum would become the \'time-server\' stratum etc.\n\nNot sure that would work in all the cases neither. How would you rename the stratum containning the xfce components?',391,1,391,'9a6a9dd7_575eecea',NULL),(33,'2015-04-19 11:18:46','Patch Set 1:\n\nI\'m still not convinced this change is really necessary,\nthese objects are clearly distinguished by their type.\n\nEven if I could be persuaded unique naming across definitions\nis necessary I wouldn\'t arbitrarily append \'group\' to every\nstratum, instead I\'d rename strata to match the functions\nthey perform as Emmet suggested, so for example the \'swift\'\nstratum would become the \'distributed-object-storage\' stratum,\nthe \'ntpd\' stratum would become the \'time-server\' stratum etc.',391,1,391,'ba65a107_1809852c',NULL),(18,'2015-04-19 06:47:36','Uploaded patch set 1.',391,1,391,'ba65a107_58fffd01',NULL),(33,'2015-04-19 11:26:51','Patch Set 1: Code-Review-1\n\n(1 comment)',391,1,391,'ba65a107_d8122d58',NULL),(18,'2015-04-28 13:37:14','Abandoned',391,1,391,'bada0100_b09bb871',NULL),(6,'2015-04-24 11:02:45','Patch Set 2:\n\n> The last released version of definitions (baserock-15.10) contains\n > Morph 9e105fccb12de23551c93aac6cb2b1056b858700. That version of\n > Morph has \'not_supported_versions = []\', so the last release of\n > definitions will still build current \'master\' of definitions, and\n > will not hit anything it doesn\'t understand.\n\nTurns out the 15.10 release actually can\'t build master of definitions right now due to requiring that \'build-deps: []\' be present. :( That doesn\'t affect this patch at all, I just wanted to correct my comment.',392,2,392,'1a76adc5_73878062',NULL),(6,'2015-04-21 16:54:58','Patch Set 2:\n\nAlso, thanks again for fixing that morph paths issue, i have lost days to that in the past...',392,2,392,'7a7fa997_16839ccd',NULL),(6,'2015-04-21 16:52:47','Patch Set 2: Code-Review+1\n\nThe last released version of definitions (baserock-15.10) contains Morph 9e105fccb12de23551c93aac6cb2b1056b858700. That version of Morph has \'not_supported_versions = []\', so the last release of definitions will still build current \'master\' of definitions, and will not hit anything it doesn\'t understand.\n\nNewer versions of Morph list \'supported versions\' rather than \'not supported versions\', so we\'ll need to be more careful about this in future. I proposed a process for that here, which I don\'t really like but I\'m yet to hear a better suggestion: ',392,2,392,'7a7fa997_b61c28c3',NULL),(27,'2015-04-20 09:41:41','Patch Set 2: Code-Review+1',392,2,392,'9a6a9dd7_773c5094',NULL),(15,'2015-04-19 19:55:23','Patch Set 1: Code-Review-1\n\nCan you explain in the commit message what have been change in definitions to us to bump the version?',392,1,392,'ba65a107_984a7554',NULL),(33,'2015-04-19 21:23:18','Patch Set 2: Commit message was updated',392,2,392,'ba65a107_b85e5911',NULL),(33,'2015-04-19 12:23:25','Uploaded patch set 1.',392,1,392,'ba65a107_f80ff12c',NULL),(15,'2015-04-29 13:11:41','Change has been successfully rebased as db1fe6e41bebf7da71d11fe9bc492ede1821f57b',392,2,392,'bada0100_53185684',NULL),(15,'2015-04-29 13:11:38','Patch Set 2: Code-Review+2',392,2,392,'bada0100_932ebea4',NULL),(15,'2015-04-29 13:11:41','Patch Set 3: Patch Set 2 was rebased',392,2,392,'bada0100_b32bc293',NULL),(18,'2015-04-19 14:46:57','Change has been successfully merged into the git repository.',393,1,393,'ba65a107_1820a59a',NULL),(18,'2015-04-19 14:46:55','Patch Set 1: Code-Review+2',393,1,393,'ba65a107_782be182',NULL),(33,'2015-04-19 12:50:30','Uploaded patch set 1.',393,1,393,'ba65a107_981cb56c',NULL),(15,'2015-04-20 13:42:53','Patch Set 2:\n\nyes please!',394,2,394,'9a6a9dd7_170f14e3',NULL),(15,'2015-04-20 13:43:10','Change has been successfully merged into the git repository.',394,2,394,'9a6a9dd7_371498f4',NULL),(15,'2015-04-20 13:42:40','Patch Set 2: Code-Review+2',394,2,394,'9a6a9dd7_770a10d4',NULL),(8,'2015-04-20 13:40:37','Patch Set 2: Code-Review+1',394,2,394,'9a6a9dd7_b768a888',NULL),(7,'2015-04-20 13:13:10','Uploaded patch set 1.',394,1,394,'9a6a9dd7_d7719c78',NULL),(7,'2015-04-20 13:14:58','Uploaded patch set 2.',394,2,394,'9a6a9dd7_f76e2096',NULL),(27,'2015-04-21 13:04:50','Patch Set 1: Code-Review+1',395,1,395,'7a7fa997_b6c0a82b',NULL),(15,'2015-04-20 16:26:39','Uploaded patch set 1.',395,1,395,'9a6a9dd7_97f004cb',NULL),(6,'2015-04-27 11:43:40','Patch Set 1: Code-Review+2',395,1,395,'dad5f5cf_31e27004',NULL),(6,'2015-04-27 11:43:56','Patch Set 2: Patch Set 1 was rebased',395,1,395,'dad5f5cf_d1e68416',NULL),(6,'2015-04-27 11:43:56','Change has been successfully rebased as 3bb8687e8fb755e7e18d5a3f26b64dc71fedcea2',395,1,395,'dad5f5cf_f1e38803',NULL),(27,'2015-04-21 12:56:40','Patch Set 1: Code-Review+1',396,1,396,'7a7fa997_d6c9a45b',NULL),(15,'2015-04-20 17:09:59','Uploaded patch set 1.',396,1,396,'9a6a9dd7_17b4f4f0',NULL),(6,'2015-04-27 11:43:26','Patch Set 1: Code-Review+2\n\nUntested but this is unlikely to break anything.',396,1,396,'dad5f5cf_11ddec42',NULL),(15,'2015-04-27 15:18:27','Change has been successfully rebased as 5b6c916b5431878b4f309bfd304ab7478c01bc93',396,1,396,'dad5f5cf_51605435',NULL),(15,'2015-04-27 15:18:26','Patch Set 2: Patch Set 1 was rebased',396,1,396,'dad5f5cf_b173c014',NULL),(15,'2015-04-21 11:15:36','Patch Set 1: Code-Review+2',397,1,397,'7a7fa997_36b9f8e9',NULL),(8,'2015-04-21 09:10:53','Patch Set 1: Code-Review+1',397,1,397,'7a7fa997_76877062',NULL),(43,'2015-04-21 09:16:10','Patch Set 1: Code-Review+1',397,1,397,'7a7fa997_d6952489',NULL),(15,'2015-04-21 11:15:39','Patch Set 2: Patch Set 1 was rebased',397,1,397,'7a7fa997_d6cd2488',NULL),(15,'2015-04-21 11:15:40','Change has been successfully rebased as 02101b041b4e261a4b6e42ead1a565ae8a17b313',397,1,397,'7a7fa997_f6caa06d',NULL),(15,'2015-04-20 17:42:16','Uploaded patch set 1.',397,1,397,'9a6a9dd7_77a690c3',NULL),(7,'2015-04-21 08:29:06','Patch Set 2: Commit message was updated',398,2,398,'7a7fa997_16095c2c',NULL),(6,'2015-04-21 08:58:02','Patch Set 2: Code-Review+2',398,2,398,'7a7fa997_b630a8e9',NULL),(7,'2015-04-21 08:32:31','Patch Set 2: Code-Review+1',398,2,398,'7a7fa997_d6120458',NULL),(8,'2015-04-21 09:00:15','Change has been successfully merged into the git repository.',398,2,398,'7a7fa997_d640c437',NULL),(8,'2015-04-20 17:51:51','Uploaded patch set 1.',398,1,398,'9a6a9dd7_37b018f4',NULL),(6,'2015-04-21 08:58:13','Patch Set 1: Code-Review+2',399,1,399,'7a7fa997_564d9471',NULL),(8,'2015-04-21 09:00:49','Patch Set 2: Code-Review+2',399,2,399,'7a7fa997_5674b49b',NULL),(8,'2015-04-21 09:00:51','Change has been successfully merged into the git repository.',399,2,399,'7a7fa997_7679b092',NULL),(NULL,'2015-04-21 09:00:39','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I8aa7c9ff, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',399,1,399,'7a7fa997_964a4c54',NULL),(8,'2015-04-21 09:00:45','Patch Set 2: Patch Set 1 was rebased',399,1,399,'7a7fa997_b647484b',NULL),(7,'2015-04-21 08:32:58','Patch Set 1: Code-Review+1',399,1,399,'7a7fa997_f60f002d',NULL),(8,'2015-04-20 17:51:51','Uploaded patch set 1.',399,1,399,'9a6a9dd7_d7943c46',NULL),(8,'2015-04-21 09:01:09','Patch Set 2: Patch Set 1 was rebased',400,1,400,'7a7fa997_166e3cca',NULL),(8,'2015-04-21 09:01:12','Patch Set 2: Code-Review+2',400,2,400,'7a7fa997_367338b3',NULL),(6,'2015-04-21 08:58:28','Patch Set 1: Code-Review+2',400,1,400,'7a7fa997_76521015',NULL),(7,'2015-04-21 08:33:59','Patch Set 1: Code-Review+1',400,1,400,'7a7fa997_961c8c6c',NULL),(8,'2015-04-21 09:01:14','Change has been successfully merged into the git repository.',400,2,400,'7a7fa997_d66764e9',NULL),(8,'2015-04-20 17:51:51','Uploaded patch set 1.',400,1,400,'9a6a9dd7_f7914053',NULL),(7,'2015-04-21 08:30:02','Patch Set 2: Commit message was updated',401,2,401,'7a7fa997_360ed835',NULL),(6,'2015-04-21 08:58:54','Patch Set 2: Code-Review+2',401,2,401,'7a7fa997_365c9825',NULL),(8,'2015-04-21 09:01:42','Change has been successfully merged into the git repository.',401,3,401,'7a7fa997_569b54c9',NULL),(8,'2015-04-21 09:01:36','Patch Set 3: Patch Set 2 was rebased',401,2,401,'7a7fa997_9661ecd5',NULL),(7,'2015-04-21 08:34:09','Patch Set 2: Code-Review+1',401,2,401,'7a7fa997_b619887b',NULL),(8,'2015-04-21 09:01:39','Patch Set 3: Code-Review+2',401,3,401,'7a7fa997_b65e6811',NULL),(43,'2015-04-21 08:52:36','Patch Set 2: Code-Review+1',401,2,401,'7a7fa997_f63620e7',NULL),(NULL,'2015-04-21 09:01:26','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I4152b8dc, however the current patch set is 2.\n* Depends on commit 599adf1e12f3a206e78e90f4a5725a7c27a3e8e5 which has no change associated with it.\n* Depends on commit f4b63315b2b7a7245d178f82c72ae51dc242d65f which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',401,2,401,'7a7fa997_f664e0e6',NULL),(8,'2015-04-20 17:51:51','Uploaded patch set 1.',401,1,401,'9a6a9dd7_979ec462',NULL),(6,'2015-04-21 08:58:35','Patch Set 1: Code-Review+2',402,1,402,'7a7fa997_16571c04',NULL),(8,'2015-04-21 09:01:57','Patch Set 2: Patch Set 1 was rebased',402,1,402,'7a7fa997_16a5dc03',NULL),(8,'2015-04-21 09:02:00','Patch Set 2: Code-Review+2',402,2,402,'7a7fa997_36aa58d5',NULL),(7,'2015-04-21 08:34:22','Patch Set 1: Code-Review+1',402,1,402,'7a7fa997_5626f4bb',NULL),(NULL,'2015-04-21 09:01:54','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I8802fa01, however the current patch set is 3.\n* Depends on commit b2f7e31f1260572f2be4aecceba8adce9de84a05 which has no change associated with it.\n* Depends on commit 599adf1e12f3a206e78e90f4a5725a7c27a3e8e5 which has no change associated with it.\n* Depends on commit f4b63315b2b7a7245d178f82c72ae51dc242d65f which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',402,1,402,'7a7fa997_76a0d0f4',NULL),(8,'2015-04-21 09:02:02','Change has been successfully merged into the git repository.',402,2,402,'7a7fa997_d6ae84e7',NULL),(8,'2015-04-20 17:51:51','Uploaded patch set 1.',402,1,402,'9a6a9dd7_b79bc871',NULL),(7,'2015-04-21 08:34:45','Patch Set 1: Code-Review+1',403,1,403,'7a7fa997_762bf082',NULL),(8,'2015-04-21 08:56:21','Patch Set 1:\n\n> I was just wondering why you are reverting a change you requested\n > in your comments on this patch?\n > \n > https://gerrit.baserock.org/#/c/384/\n\nBecause when I test it, I\'ve realized that I was wrong. Depending on openstack-ceilometer-setup.morph create a systemd loop for these services, stopping them to run. This is because they are enabled and started in the openstack-ceilometer-setup.morph, my fault for suggesting things without testing them.',403,1,403,'7a7fa997_96332cf6',NULL),(8,'2015-04-21 09:02:26','Patch Set 2: Code-Review+2',403,2,403,'7a7fa997_96b80c2c',NULL),(8,'2015-04-21 09:02:28','Change has been successfully merged into the git repository.',403,2,403,'7a7fa997_b6b50833',NULL),(43,'2015-04-21 08:51:09','Patch Set 1:\n\nI was just wondering why you are reverting a change you requested in your comments on this patch?\n\nhttps://gerrit.baserock.org/#/c/384/',403,1,403,'7a7fa997_d639a4d9',NULL),(43,'2015-04-21 09:00:27','Patch Set 1: Code-Review+1',403,1,403,'7a7fa997_f63dc0bc',NULL),(8,'2015-04-21 09:02:23','Patch Set 2: Patch Set 1 was rebased',403,1,403,'7a7fa997_f6ab80d4',NULL),(8,'2015-04-20 17:51:51','Uploaded patch set 1.',403,1,403,'9a6a9dd7_57882c22',NULL),(27,'2015-04-21 12:28:14','Patch Set 1: Code-Review+1\n\nlooks sane from here',404,1,404,'7a7fa997_16b07cdc',NULL),(7,'2015-04-21 13:52:30','Patch Set 1: Code-Review-2\n\nPlease, don\'t do this. I don\'t see any point on releasing weston systems (that is, including them on the release process, building, testing them, and publishing them on download.baserock.org), and we still need to do releases of genivi systems.',404,1,404,'7a7fa997_36033875',NULL),(16,'2015-04-21 12:34:35','Patch Set 1:\n\nDoes this mean we don\'t want to release GENIVI stuff anymore? If we still do, I think it makes more sense to add the GENIVI baselines to ci.morph rather than remove them from release.morph.',404,1,404,'7a7fa997_36b578cd',NULL),(15,'2015-04-21 13:43:10','Patch Set 1:\n\n> Does this mean we don\'t want to release GENIVI stuff anymore? If we\n > still do, I think it makes more sense to add the GENIVI baselines\n > to ci.morph rather than remove them from release.morph.\n\nSure; but if we want to do that, I\'d suggest to fix the genivi systems (AFAIK are currently broken), add them to the ci, and then, add it back to the release cluster',404,1,404,'7a7fa997_96da4c16',NULL),(15,'2015-04-21 13:56:45','Patch Set 1:\n\n> Please, don\'t do this. I don\'t see any point on releasing weston\n > systems (that is, including them on the release process, building,\n > testing them, and publishing them on download.baserock.org), and we\n > still need to do releases of genivi systems.\n\nThis patch series is about to sync what we test (ci) whith what we release (release), as I do not see the point on release systems we are not actively testing and can be broken.\nI think removing genivi systems from the release is the correct thing to do as I though they where currently borken, but I will rework the patch to include the genivi systems in the ci instead',404,1,404,'7a7fa997_d6f7648b',NULL),(15,'2015-04-21 14:04:48','Uploaded patch set 2.',404,2,404,'7a7fa997_f6f4e088',NULL),(15,'2015-04-20 18:09:04','Uploaded patch set 1.',404,1,404,'9a6a9dd7_d77bdc27',NULL),(15,'2015-05-01 14:39:09','Patch Set 4: Patch Set 3 was rebased',404,3,404,'bada0100_04092631',NULL),(8,'2015-04-28 13:07:23','Patch Set 3: Code-Review+1',404,3,404,'bada0100_3014a8f4',NULL),(15,'2015-05-01 14:39:10','Change has been successfully rebased as 5afd260b75077ef440accf7baf2354dbb47f929c',404,3,404,'bada0100_a405ba15',NULL),(15,'2015-05-01 14:39:06','Patch Set 3: Code-Review+2',404,3,404,'bada0100_e40bc229',NULL),(15,'2015-04-27 15:40:12','Uploaded patch set 3.',404,3,404,'dad5f5cf_51ee148d',NULL),(35,'2015-04-27 15:36:16','Patch Set 2: Code-Review-1\n\nYou need to add BOOT_DEVICE and change ROOT_DEVICE for the jetson',404,2,404,'dad5f5cf_91e47cad',NULL),(7,'2015-04-27 15:25:56','Patch Set 2: Code-Review+1\n\nI always wanted to do this. I thing we are putting a lot of systems in the CI, but I think that is a separate discussion.',404,2,404,'dad5f5cf_b14ae0aa',NULL),(35,'2015-04-27 15:42:43','Patch Set 3: Code-Review+1\n\nLooks good now',404,3,404,'dad5f5cf_b1f8a04a',NULL),(7,'2015-04-27 15:23:45','Patch Set 2: -Code-Review\n\nRemove veto - The patch has changed',404,2,404,'dad5f5cf_d153e46a',NULL),(37,'2015-04-22 09:41:33','Patch Set 2: Code-Review-2\n\nSorry, that needs to be a -2, we\'re rather committed to the PXEBoot deployment extension at the moment.\n\nThe Ironic work also needs to be aware of this change.',405,2,405,'5a7ca5a3_554d8c71',NULL),(28,'2015-04-22 09:52:11','Patch Set 2:\n\nRichard is correct: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#pxe-setup',405,2,405,'5a7ca5a3_75520815',NULL),(37,'2015-04-22 09:38:36','Patch Set 2: Code-Review-1\n\nSorry Javier, the reason why we haven\'t updated to a newer version of syslinux is that it would in the very least break PXE booting, since a lot of its code has been split out into support binaries (basically libraries) and we are not yet in a position to work out which extra binaries need to be put in their place.\n\nI\'d like us to update our bootloader, since I know of a few bugs which would be fixed in doing so, but I\'m unsure if we\'re able to do so yet.\n\nSee http://www.syslinux.org/wiki/index.php/PXELINUX#Configuration\n\n [5.00+] Also copy \"ldlinux.c32\" from the Syslinux distribution to the \"/tftpboot\" directory on the TFTP server.',405,2,405,'5a7ca5a3_b530a0e9',NULL),(27,'2015-04-21 13:14:15','Patch Set 2: Code-Review+1\n\nsems a good solid update to me...',405,2,405,'7a7fa997_16e71ce6',NULL),(15,'2015-04-21 12:01:56','Patch Set 2:\n\nUpdated a new version of the patch so It doesn\'t depend on the \"bsp-x86-generic\" patch series',405,2,405,'7a7fa997_56b6f4dd',NULL),(15,'2015-04-21 12:00:06','Uploaded patch set 2.',405,2,405,'7a7fa997_b6a9887d',NULL),(35,'2015-04-21 10:02:15','Patch Set 1: Code-Review+1\n\nNo problem with this if it works and you still get a boot menu etc..',405,1,405,'7a7fa997_b6e3c832',NULL),(7,'2015-04-21 11:25:44','Patch Set 1:\n\nI\'d like to get Richard Maw\'s input on this change before we decide to merge it. IIRC he said that upgrading syslinux wasn\'t going to be easy, and looks like it was. That is why I\'m worried :)',405,1,405,'7a7fa997_f6914053',NULL),(15,'2015-04-20 22:41:18','Patch Set 1:\n\nI\'ve built and run a base-system-x86_64-generic and a build-system-x86_64 to test this. I also build (and then boot) a build-system-x86_64 inside the built build-system-x86_64',405,1,405,'9a6a9dd7_578fcc23',NULL),(15,'2015-04-20 22:37:45','Uploaded patch set 1.',405,1,405,'9a6a9dd7_b772e847',NULL),(15,'2015-04-30 14:37:32','Uploaded patch set 4.',405,4,405,'bada0100_99da5f16',NULL),(28,'2015-05-07 10:37:00','Patch Set 4: Code-Review-1\n\nYou also need to update morph, the openstack-ironic configuration extension, the nfsboot-server configuration extension, and the pxeboot write extension and to copy the module libraries [1].\n\nI would also like to see some post-install clean up as Arch Linux and Debian do for their packages, something like [2].\n\n[1] http://www.syslinux.org/wiki/index.php/Library_modules\n[2] http://git.baserock.org/cgi-bin/cgit.cgi/baserock/baserock/definitions.git/log/?h=baserock/tiagogomes/syslinux-6.03',405,4,405,'bada0100_aa6103d5',NULL),(15,'2015-04-30 14:26:38','Uploaded patch set 3.',405,3,405,'bada0100_b9c0832b',NULL),(16,'2015-04-21 18:11:57','Patch Set 1: Code-Review+1\n\nLooks fine, and I know its been tested.',406,1,406,'7a7fa997_16e87c7b',NULL),(16,'2015-04-21 18:25:12','Patch Set 2: Patch Set 1 was rebased',406,1,406,'7a7fa997_569594e2',NULL),(16,'2015-04-21 18:25:12','Change has been successfully rebased as 9d2700755d616d66d49713cce77c48e1eb566cef',406,1,406,'7a7fa997_769a1016',NULL),(6,'2015-04-21 10:09:11','Uploaded patch set 1.',406,1,406,'7a7fa997_76d53042',NULL),(27,'2015-04-21 11:58:39','Patch Set 1: Code-Review+1\n\nlooks sane and logical to me.',406,1,406,'7a7fa997_96ac8c8e',NULL),(16,'2015-04-21 18:25:10','Patch Set 1: Code-Review+2',406,1,406,'7a7fa997_b6f8a84a',NULL),(8,'2015-04-24 13:50:34','Patch Set 3: Patch Set 2 was rebased',407,2,407,'1a76adc5_53d04453',NULL),(8,'2015-04-24 13:50:35','Change has been successfully rebased as dcb95e689f2f61a61ef50822f8cb0e9543c8005d',407,2,407,'1a76adc5_73d54042',NULL),(8,'2015-04-24 13:50:33','Patch Set 2: Code-Review+2',407,2,407,'1a76adc5_b3e3d832',NULL),(43,'2015-04-24 10:41:50','Patch Set 2: Code-Review+1',407,2,407,'1a76adc5_d36774e9',NULL),(8,'2015-04-23 10:01:39','Patch Set 2: Code-Review+1',407,2,407,'3a79b1b5_7479a892',NULL),(28,'2015-04-23 08:53:34','Uploaded patch set 2.',407,2,407,'3a79b1b5_b419807b',NULL),(27,'2015-04-21 11:22:37','Patch Set 1: Code-Review+1\n\nLooks sane to me',407,1,407,'7a7fa997_16ab9c8a',NULL),(28,'2015-04-21 10:49:00','Uploaded patch set 1.',407,1,407,'7a7fa997_966b2c85',NULL),(39,'2015-04-24 09:34:49','Uploaded patch set 6.',408,6,408,'1a76adc5_13096c2c',NULL),(27,'2015-04-24 11:09:38','Patch Set 6: Code-Review+1',408,6,408,'1a76adc5_137c0c72',NULL),(33,'2015-04-23 13:26:15','Patch Set 5: Code-Review+1\n\nThis looks fine, I will test it and merge.',408,5,408,'3a79b1b5_94e6c443',NULL),(27,'2015-04-22 09:12:56','Patch Set 5: Code-Review+1',408,5,408,'5a7ca5a3_352570ab',NULL),(6,'2015-04-21 11:44:32','Patch Set 2:\n\n(3 comments)',408,2,408,'7a7fa997_16995c6e',NULL),(39,'2015-04-21 13:47:21','Uploaded patch set 3.',408,3,408,'7a7fa997_16fe3c6c',NULL),(39,'2015-04-21 20:17:56','Uploaded patch set 5.',408,5,408,'7a7fa997_5663541a',NULL),(39,'2015-04-21 11:18:25','Uploaded patch set 1.',408,1,408,'7a7fa997_56a114a8',NULL),(39,'2015-04-21 19:20:38','Uploaded patch set 4.',408,4,408,'7a7fa997_56bcb46c',NULL),(39,'2015-04-21 13:46:39','Patch Set 2:\n\n(1 comment)',408,2,408,'7a7fa997_7609b094',NULL),(11,'2015-04-21 14:58:28','Patch Set 3: Code-Review+1',408,3,408,'7a7fa997_b6ee68b3',NULL),(39,'2015-04-21 11:37:38','Uploaded patch set 2.',408,2,408,'7a7fa997_d67be427',NULL),(6,'2015-04-21 11:24:27','Patch Set 1:\n\n(1 comment)\n\nI\'ve not tested this yet but it looks great, apart from the confusing use of the \'build-failed\' message. Will deploy this to a distbuild network later and test.',408,1,408,'7a7fa997_d6944446',NULL),(11,'2015-04-21 13:37:53','Patch Set 2: Code-Review+1\n\n(1 comment)',408,2,408,'7a7fa997_f6cdc05e',NULL),(6,'2015-04-28 16:00:59','Patch Set 7: Code-Review+1',408,7,408,'bada0100_10d164cd',NULL),(39,'2015-04-28 08:22:26','Uploaded patch set 7.',408,7,408,'bada0100_300ee835',NULL),(33,'2015-04-29 16:03:05','Patch Set 8: Patch Set 7 was rebased',408,7,408,'bada0100_36b900ea',NULL),(33,'2015-04-29 16:01:40','Patch Set 7: Code-Review+2',408,7,408,'bada0100_b6edf0f1',NULL),(33,'2015-04-29 16:03:05','Change has been successfully rebased as 4a1c2d118511da067fcadf2253fdc2a49d04e4fa',408,7,408,'bada0100_d6cd1488',NULL),(33,'2015-04-28 17:27:17','Patch Set 7: Code-Review-2\n\nCommand output is sometimes delayed for several seconds,\nsuggest we solve this problem before merging these changes.',408,7,408,'bada0100_f02140b5',NULL),(7,'2015-04-21 16:41:20','Change has been successfully merged into the git repository.',409,1,409,'7a7fa997_160cfc93',NULL),(15,'2015-04-21 15:41:33','Patch Set 1: Code-Review+1',409,1,409,'7a7fa997_1635dc45',NULL),(7,'2015-04-21 16:41:18','Patch Set 1: Code-Review+2',409,1,409,'7a7fa997_761770a4',NULL),(8,'2015-04-21 15:29:25','Uploaded patch set 1.',409,1,409,'7a7fa997_7630d056',NULL),(8,'2015-04-22 15:22:48','Patch Set 1: Code-Review+2\n\n> > (1 comment)\n > \n > Possible, but since I only want to lorry 1 of the repos probably\n > not necessary. Also looking at the GoogleCloudPlatform repositories\n > the only thing they really have in common is the author. kubernetes\n > is a cluster management system. gcloud-java is client side java\n > code for accessing google cloud APIs.\n\nFair enough',410,1,410,'5a7ca5a3_95756434',NULL),(8,'2015-04-22 15:22:58','Change has been successfully merged into the git repository.',410,1,410,'5a7ca5a3_b572e047',NULL),(47,'2015-04-22 15:17:14','Patch Set 1:\n\n> (1 comment)\n\nPossible, but since I only want to lorry 1 of the repos probably not necessary. Also looking at the GoogleCloudPlatform repositories the only thing they really have in common is the author. kubernetes is a cluster management system. gcloud-java is client side java code for accessing google cloud APIs.',410,1,410,'5a7ca5a3_d57bdc27',NULL),(8,'2015-04-21 16:48:24','Patch Set 1:\n\n(1 comment)',410,1,410,'7a7fa997_961facb7',NULL),(47,'2015-04-21 15:55:58','Uploaded patch set 1.',410,1,410,'7a7fa997_96480cce',NULL),(15,'2015-04-21 16:00:11','Patch Set 1: Code-Review+1',410,1,410,'7a7fa997_b64508b5',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 2.',411,2,411,'5a7ca5a3_75f3e873',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 3.',411,3,411,'5a7ca5a3_95a9e426',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 1.',411,1,411,'7a7fa997_56eef48c',NULL),(37,'2015-04-28 10:03:50','Patch Set 3:\n\n(1 comment)',411,3,411,'bada0100_307348b3',NULL),(27,'2015-04-28 14:38:13','Patch Set 3: Code-Review+1',411,3,411,'bada0100_30eca8c7',NULL),(16,'2016-05-24 22:33:55','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',411,3,411,'da36d5c6_69c5255a',NULL),(27,'2015-04-24 13:59:42','Patch Set 3: Code-Review+1\n\nseems sane to me, but not currently able to test.',412,3,412,'1a76adc5_93bd7c05',NULL),(16,'2015-04-22 21:58:25','Uploaded patch set 2.',412,2,412,'5a7ca5a3_15e8747b',NULL),(16,'2015-04-22 21:59:43','Uploaded patch set 3.',412,3,412,'5a7ca5a3_b5a66052',NULL),(16,'2015-04-21 17:46:21','Uploaded patch set 1.',412,1,412,'7a7fa997_76f3f073',NULL),(16,'2016-05-24 22:34:02','Abandoned\n\nI don\'t have the time to finish this, if anyone ever does, feel free to resurrect.',412,3,412,'da36d5c6_89a099a7',NULL),(39,'2015-04-21 19:20:38','Uploaded patch set 1.',413,1,413,'7a7fa997_16b63c8b',NULL),(39,'2015-04-21 19:43:45','Abandoned',413,1,413,'7a7fa997_f6ace037',NULL),(16,'2015-04-21 20:18:05','Patch Set 1: Code-Review+1\n\nLooks fine to me.',414,1,414,'7a7fa997_166ddc04',NULL),(39,'2015-04-21 19:47:41','Uploaded patch set 1.',414,1,414,'7a7fa997_96a9ec26',NULL),(6,'2015-04-27 11:30:30','Change has been successfully rebased as 1fd7d6412418034002e816b0c01d06c358b5a0a6',414,1,414,'dad5f5cf_9119dc24',NULL),(6,'2015-04-27 11:30:28','Patch Set 1: Code-Review+2\n\nThanks!',414,1,414,'dad5f5cf_d11f6408',NULL),(6,'2015-04-27 11:30:30','Patch Set 2: Patch Set 1 was rebased',414,1,414,'dad5f5cf_f11ce815',NULL),(39,'2015-04-22 07:34:32','Patch Set 2: Code-Review+1\n\nLooks fine',415,2,415,'5a7ca5a3_55ffcc01',NULL),(7,'2015-04-22 08:22:07','Change has been successfully rebased as 8103617c23fed8f07f23431d0b66ca6bcb6cba2d',415,2,415,'5a7ca5a3_951c846c',NULL),(7,'2015-04-22 08:22:04','Patch Set 2: Code-Review+2',415,2,415,'5a7ca5a3_d512fc57',NULL),(7,'2015-04-22 08:22:06','Patch Set 3: Patch Set 2 was rebased',415,2,415,'5a7ca5a3_f50ff82c',NULL),(6,'2015-04-21 20:34:08','Uploaded patch set 2.',415,2,415,'7a7fa997_96800c8d',NULL),(16,'2015-04-21 20:35:16','Patch Set 2: Code-Review+1\n\nSeems pretty sensible to me.',415,2,415,'7a7fa997_b67d08b4',NULL),(6,'2015-04-21 20:25:23','Uploaded patch set 1.',415,1,415,'7a7fa997_f67380e5',NULL),(15,'2015-05-25 15:26:36','Abandoned\n\nSeems I misunderstood the meaning of the extension here',416,1,416,'3ace114c_cc126f58',NULL),(15,'2015-04-22 10:16:44','Uploaded patch set 1.',416,1,416,'5a7ca5a3_7579a892',NULL),(6,'2015-04-27 11:29:39','Patch Set 1: Code-Review-1\n\nYou\'ve confused nfsboot.configure with nfsboot.write ... easily done since they have the same name. But they do different things. nfsboot.configure disables ifup@eth0.service to avoid userland re-DHCPing when NFSbooted. systemd-networkd is smart enough not to need this, but we can\'t predict that everyone who wants to nfsboot will use systemd-networkd.',416,1,416,'dad5f5cf_312b5032',NULL),(15,'2015-04-22 10:33:50','Patch Set 1:\n\n(1 comment)',417,1,417,'5a7ca5a3_157cf471',NULL),(15,'2015-04-22 10:33:27','Uploaded patch set 2.',417,2,417,'5a7ca5a3_55826c53',NULL),(8,'2015-04-22 10:39:15','Patch Set 2: Code-Review+1',417,2,417,'5a7ca5a3_958fa475',NULL),(8,'2015-04-22 10:32:27','Patch Set 1: Code-Review-1\n\n(1 comment)',417,1,417,'5a7ca5a3_b5b50033',NULL),(15,'2015-04-22 10:28:28','Uploaded patch set 1.',417,1,417,'5a7ca5a3_d5ae7ce7',NULL),(15,'2015-04-22 10:29:21','Patch Set 1:\n\nThis is a optional dependency of new versions os syslinux and systemd',417,1,417,'5a7ca5a3_f5ab78d4',NULL),(6,'2015-04-27 11:27:19','Change has been successfully rebased as eafad32db3d1e4b69c430f4403b96288313f3105',417,2,417,'dad5f5cf_11264c69',NULL),(6,'2015-04-27 11:27:15','Patch Set 2: Code-Review+2',417,2,417,'dad5f5cf_512cd44a',NULL),(6,'2015-04-27 11:27:18','Patch Set 3: Patch Set 2 was rebased',417,2,417,'dad5f5cf_7131d8a1',NULL),(6,'2015-04-22 11:02:53','Uploaded patch set 1.',418,1,418,'5a7ca5a3_35f810e5',NULL),(8,'2015-04-22 16:11:19','Patch Set 1: Code-Review+1',418,1,418,'5a7ca5a3_55b6ecdd',NULL),(7,'2015-04-22 11:12:13','Patch Set 1: Code-Review+1',418,1,418,'5a7ca5a3_75d52842',NULL),(6,'2015-04-28 15:59:03','Change has been successfully rebased as 93dd98f8cb5e70a1e230e96678bf69c648cf32bd',418,1,418,'bada0100_50c7ec12',NULL),(6,'2015-04-28 15:59:00','Patch Set 1: Code-Review+2',418,1,418,'bada0100_904d54c7',NULL),(6,'2015-04-28 15:59:03','Patch Set 2: Patch Set 1 was rebased',418,1,418,'bada0100_b04ad8aa',NULL),(6,'2015-04-22 11:02:53','Uploaded patch set 1.',419,1,419,'5a7ca5a3_d5dc3c77',NULL),(8,'2015-04-22 16:22:32','Patch Set 1: Code-Review+1',419,1,419,'5a7ca5a3_f5c61849',NULL),(6,'2015-05-07 14:35:40','Patch Set 2: Patch Set 1 was rebased',419,1,419,'bada0100_0af60fd8',NULL),(29,'2015-05-06 10:43:42','Patch Set 1: Code-Review+1',419,1,419,'bada0100_1fe88f7b',NULL),(6,'2015-05-07 14:23:00','Patch Set 1: Code-Review+2',419,1,419,'bada0100_6a379bb1',NULL),(NULL,'2015-05-07 14:23:03','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ifdaa92c2, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',419,1,419,'bada0100_8a3c3f95',NULL),(6,'2015-05-07 14:35:43','Patch Set 2: Code-Review+2',419,2,419,'bada0100_aa0263b2',NULL),(6,'2015-05-07 14:35:45','Change has been successfully merged into the git repository.',419,2,419,'bada0100_caffa7a9',NULL),(27,'2015-05-06 11:00:22','Patch Set 1: Code-Review+1',419,1,419,'bada0100_df01a73a',NULL),(27,'2015-04-22 11:04:30','Patch Set 1: Code-Review+1\n\nseems a sensible alteration and the code seems sound to me.',420,1,420,'5a7ca5a3_55d02c53',NULL),(8,'2015-04-22 16:26:14','Patch Set 1: Code-Review+1',420,1,420,'5a7ca5a3_b5c0a02b',NULL),(6,'2015-04-22 11:02:53','Uploaded patch set 1.',420,1,420,'5a7ca5a3_f5d93884',NULL),(NULL,'2015-05-07 14:24:20','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ifdaa92c2, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',420,1,420,'bada0100_0a484f2c',NULL),(6,'2015-05-07 14:35:55','Patch Set 2: Patch Set 1 was rebased',420,1,420,'bada0100_2a267369',NULL),(6,'2015-05-07 14:23:25','Patch Set 1: Code-Review+2',420,1,420,'bada0100_2a41930b',NULL),(29,'2015-05-06 10:46:30','Patch Set 1: Code-Review+1',420,1,420,'bada0100_3fed538c',NULL),(6,'2015-05-07 14:35:58','Patch Set 2: Code-Review+2',420,2,420,'bada0100_4a2bb730',NULL),(6,'2015-05-07 14:24:18','Patch Set 1:\n\nThanks for reviewing. I kind of agree on is_running() but it seems common in Python to have method names that don\'t have a verb in them, as well.',420,1,420,'bada0100_4a465725',NULL),(NULL,'2015-05-07 14:35:45','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I35586108, however the current patch set is 2.\n* Depends on commit a7883b95acc09f22786d000f05c0ec4272911c32 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',420,1,420,'bada0100_6a2c7b4b',NULL),(32,'2015-05-06 08:55:20','Patch Set 1: Code-Review+1\n\n(3 comments)\n\nMy comments are nitpicks, but otherwise this looks sane.',420,1,420,'bada0100_7f651b44',NULL),(6,'2015-05-07 14:36:00','Change has been successfully merged into the git repository.',420,2,420,'bada0100_ea1f0b08',NULL),(7,'2015-04-22 11:17:59','Patch Set 1: Code-Review+1\n\nhm.. yes, I don\'t see the point of having a JobID, why did we create it? it was needed I guess?',421,1,421,'5a7ca5a3_15cab4a1',NULL),(8,'2015-04-22 16:30:13','Patch Set 1: Code-Review+1',421,1,421,'5a7ca5a3_15e714e6',NULL),(6,'2015-04-22 11:02:53','Uploaded patch set 1.',421,1,421,'5a7ca5a3_95e6c443',NULL),(NULL,'2015-05-07 14:36:00','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I2942ecf5, however the current patch set is 2.\n* Depends on commit 6ab7576ca6eae48d967072e8272d70f9f467e9da which has no change associated with it.\n* Depends on commit a7883b95acc09f22786d000f05c0ec4272911c32 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',421,1,421,'bada0100_0a1daf0f',NULL),(32,'2015-05-06 08:57:23','Patch Set 1: Code-Review+1\n\nNothing here seems contentious',421,1,421,'bada0100_3f5f9374',NULL),(29,'2015-05-06 10:37:51','Patch Set 1:\n\n> hm.. yes, I don\'t see the point of having a JobID, why did we\n > create it? it was needed I guess?\n\nI did it this way to reduce coupling between the Job class and the Artifact class.',421,1,421,'bada0100_5fee178d',NULL),(6,'2015-05-07 14:36:16','Change has been successfully merged into the git repository.',421,2,421,'bada0100_6ad31b39',NULL),(29,'2015-05-06 10:40:33','Patch Set 1: Code-Review-1\n\nThis change makes me uncomfortable because it reverts a decision I made to try and reduce coupling between the Job class and the Initiator class. Since no one else seems to mind you can interpret this -1 as a -0',421,1,421,'bada0100_7ff3db73',NULL),(6,'2015-05-07 14:35:12','Patch Set 1: Code-Review+2\n\n> This change makes me uncomfortable because it reverts a decision I\n > made to try and reduce coupling between the Job class and the\n > Initiator class. Since no one else seems to mind you can interpret\n > this -1 as a -0\n\nSo this is going against a deliberate decision made in commits and ? In that case, I apologise, although I don\'t think that artifact cache IDs tie things that closely to the Initiator class anyway. Those commits (if they are the right ones) do look sensible, in general I dislike how actors in distbuild will store a whole message instead of just keeping the parts they care about.\n\nI\'ve not got time to rework and retest this series now so I\'m going to merge it, but will try to look through the git logs of distbuild more carefully in future',421,1,421,'bada0100_8a0affd0',NULL),(NULL,'2015-05-07 14:35:46','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I35586108, however the current patch set is 2.\n* Depends on commit a7883b95acc09f22786d000f05c0ec4272911c32 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',421,1,421,'bada0100_8a319fa4',NULL),(6,'2015-05-07 14:37:58','Patch Set 2:\n\n> ... In that case, I apologise, although I don\'t think that artifact\n > cache IDs tie things that closely to the Initiator class anyway.\n\nI guess I mean the Artifact class here. So using cache IDs does tie jobs to Artifacts, but I think that if we change how cache identity works in Morph it\'ll be a huge massive job in any case, so hopefully I haven\'t ruined the lives of any future developers by doing this',421,2,421,'bada0100_8ad8bf54',NULL),(6,'2015-05-07 14:36:11','Patch Set 2: Patch Set 1 was rebased',421,1,421,'bada0100_aa190324',NULL),(6,'2015-05-07 14:36:14','Patch Set 2: Code-Review+2',421,2,421,'bada0100_ca16c7f1',NULL),(NULL,'2015-05-07 14:35:25','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ifdaa92c2, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',421,1,421,'bada0100_eaf86bc6',NULL),(8,'2015-04-22 17:26:40','Patch Set 1: Code-Review+1',422,1,422,'5a7ca5a3_954804ce',NULL),(6,'2015-04-22 11:02:53','Uploaded patch set 1.',422,1,422,'5a7ca5a3_b5e3c032',NULL),(27,'2015-04-22 11:34:01','Patch Set 1:\n\ni cant see anything wrong with any of this, but am not in a possition to properly test it. so a +0 from me.',422,1,422,'5a7ca5a3_d5c3dc88',NULL),(6,'2015-05-07 14:47:20','Patch Set 3: Code-Review+2',422,3,422,'bada0100_0ae4cf0b',NULL),(29,'2015-05-06 13:00:32','Patch Set 1: Code-Review+1\n\nIf we do want workers to be able to reject jobs this should be made in a separate change.',422,1,422,'bada0100_1fb64f8b',NULL),(6,'2015-05-07 14:41:32','Uploaded patch set 2.',422,2,422,'bada0100_2add1343',NULL),(6,'2015-05-07 14:47:05','Uploaded patch set 3.',422,3,422,'bada0100_4ae2d704',NULL),(29,'2015-05-06 12:48:09','Patch Set 1:\n\n(2 comments)',422,1,422,'bada0100_7fc19be3',NULL),(6,'2015-05-07 14:47:37','Change has been successfully merged into the git repository.',422,3,422,'bada0100_aaf023ca',NULL),(32,'2015-05-06 09:01:33','Patch Set 1: Code-Review+1\n\nAgain this looks reasonable. I am not in a position to test this so I\'d ask that before this topic goes in, Sam provide evidence of the extent of the testing already done. Testing distbuild networks, especially changes meant to cope with unusually timed coincidences is very hard.',422,1,422,'bada0100_df53e76a',NULL),(6,'2015-05-07 14:47:15','Patch Set 1:\n\nIn rebasing this I got conflicts due to the change from Artifact to ArtifactReference objects, so I guess that\'s why decoupling Jobs from Artifacts was useful ;) Hopefully now that we use ArtifactReference it won\'t be an issue.',422,1,422,'bada0100_eae62b16',NULL),(35,'2015-04-22 11:51:29','Patch Set 1: Code-Review+1\n\nTested this last night, can confirm it fixes the boot problem',423,1,423,'5a7ca5a3_1541540b',NULL),(15,'2015-04-22 11:54:22','Patch Set 1: Code-Review+2',423,1,423,'5a7ca5a3_3546d024',NULL),(15,'2015-04-22 11:54:25','Patch Set 2: Patch Set 1 was rebased',423,1,423,'5a7ca5a3_d54afc26',NULL),(15,'2015-04-22 11:54:25','Change has been successfully rebased as d23510244330f02de2bc02f6a561444b19900d73',423,1,423,'5a7ca5a3_f547f81b',NULL),(7,'2015-04-22 11:37:15','Uploaded patch set 1.',423,1,423,'5a7ca5a3_f5c0587e',NULL),(15,'2015-04-22 11:46:33','Uploaded patch set 1.',424,1,424,'5a7ca5a3_5537ccb0',NULL),(16,'2015-04-22 12:03:16','Patch Set 1: Code-Review+1',424,1,424,'5a7ca5a3_b55180da',NULL),(6,'2015-04-27 11:26:57','Patch Set 2: Patch Set 1 was rebased',424,1,424,'dad5f5cf_91023cb3',NULL),(6,'2015-04-27 11:26:58','Change has been successfully rebased as a36ef662f4276f8eef30de367e64ff2ff3f9ad1c',424,1,424,'dad5f5cf_b1ff40aa',NULL),(6,'2015-04-27 11:26:55','Patch Set 1: Code-Review+2',424,1,424,'dad5f5cf_f1f5c8cb',NULL),(16,'2015-04-22 12:03:43','Patch Set 1: Code-Review+1',425,1,425,'5a7ca5a3_555eecea',NULL),(15,'2015-04-22 11:48:48','Uploaded patch set 1.',425,1,425,'5a7ca5a3_753c4894',NULL),(6,'2015-04-27 11:26:51','Patch Set 2: Patch Set 1 was rebased',425,1,425,'dad5f5cf_3114b0f4',NULL),(6,'2015-04-27 11:26:34','Patch Set 1: Code-Review+2',425,1,425,'dad5f5cf_710a38d4',NULL),(6,'2015-04-27 11:26:51','Change has been successfully rebased as 9a5bdf1e906c2c690f34108e6e5587bf37a80d7f',425,1,425,'dad5f5cf_d1f8c4c6',NULL),(8,'2015-04-24 13:50:48','Patch Set 2: Code-Review+2',426,2,426,'1a76adc5_13cacca1',NULL),(8,'2015-04-24 13:50:50','Patch Set 3: Patch Set 2 was rebased',426,2,426,'1a76adc5_33cfc8b2',NULL),(8,'2015-04-24 13:50:51','Change has been successfully rebased as 9e7b9c4d0cc17e31f3c84c2d6ae9a95a5f97527c',426,2,426,'1a76adc5_d3c3f488',NULL),(43,'2015-04-24 10:49:20','Patch Set 2: Code-Review+1',426,2,426,'1a76adc5_f364f0e6',NULL),(8,'2015-04-23 09:58:37','Patch Set 2: Code-Review+1',426,2,426,'3a79b1b5_5474ac9b',NULL),(28,'2015-04-23 09:57:53','Patch Set 2: Commit message was updated',426,2,426,'3a79b1b5_b447404b',NULL),(27,'2015-04-22 15:56:43','Patch Set 1: Code-Review+1',426,1,426,'5a7ca5a3_95ac848e',NULL),(28,'2015-04-22 14:27:33','Uploaded patch set 1.',426,1,426,'5a7ca5a3_d5943c46',NULL),(7,'2015-04-24 11:59:44','Change has been successfully merged into the git repository.',427,4,427,'1a76adc5_13f3ac0b',NULL),(8,'2015-04-24 11:11:09','Patch Set 1: Code-Review+1\n\nI haven\'t tested it',427,1,427,'1a76adc5_3381084b',NULL),(6,'2015-04-24 11:59:19','Patch Set 4: Code-Review+1\n\nI\'ve fixed an error which Pedro spotted (eventually). Have tested this on a Trove and it fixes a failure case of trove-setup that I hit.',427,4,427,'1a76adc5_53e92419',NULL),(7,'2015-04-24 11:59:41','Patch Set 4: Code-Review+2',427,4,427,'1a76adc5_73eea024',NULL),(6,'2015-04-24 11:58:21','Uploaded patch set 4.',427,4,427,'1a76adc5_938fbc75',NULL),(8,'2015-04-24 11:59:10','Patch Set 4: Code-Review+1',427,4,427,'1a76adc5_b38c3881',NULL),(6,'2015-04-24 11:57:30','Uploaded patch set 2.',427,2,427,'1a76adc5_d3953489',NULL),(6,'2015-04-24 11:58:03','Uploaded patch set 3.',427,3,427,'1a76adc5_f392b09e',NULL),(7,'2015-04-22 14:45:34','Uploaded patch set 1.',427,1,427,'5a7ca5a3_1582b400',NULL),(27,'2015-04-22 15:50:53','Patch Set 1: Code-Review+1\n\ni think this makes sence to me.... and i cant see it breaking anyhing... +1',427,1,427,'5a7ca5a3_f59ff84e',NULL),(37,'2015-04-23 13:58:49','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThis looks reasonable to me. I\'m putting together a squashed patch to include all of these OSTree changes so we have something we can merge for now for people to use while we work on making the history usable, and I\'ll include this patch in it.',428,1,428,'3a79b1b5_74d52842',NULL),(27,'2015-04-22 16:13:07','Patch Set 1: Code-Review+1',428,1,428,'5a7ca5a3_75bbe8c4',NULL),(6,'2015-04-22 16:00:54','Uploaded patch set 1.',428,1,428,'5a7ca5a3_b5a9807d',NULL),(6,'2015-05-07 13:58:30','Topic changed from baserock/adamcoldrick/ostree to sam/fix-artifact-cache-error',428,2,428,'bada0100_0aaccfec',NULL),(6,'2015-05-07 13:59:01','Patch Set 2: Code-Review+2\n\nDisentangled from the OSTree branch, otherwise the same patch. Since this had two +1s already I shall go ahead and merge.',428,2,428,'bada0100_aab8232b',NULL),(6,'2015-05-07 14:00:06','Change has been successfully merged into the git repository.',428,2,428,'bada0100_cab56732',NULL),(6,'2015-05-07 13:58:10','Uploaded patch set 2.',428,2,428,'bada0100_eaae2be7',NULL),(6,'2015-06-12 12:15:49','Change has been successfully merged into the git repository.',429,2,429,'3a4c51b2_3c04917d',NULL),(6,'2015-06-12 12:15:39','Patch Set 1: Code-Review+2\n\nLooks ok',429,1,429,'3a4c51b2_5cecfdc7',NULL),(NULL,'2015-06-12 12:15:41','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ia2eb431d, however the current patch set is 3.\n* Depends on commit 316ac76731913a230e0b52363ed0a0ea40f8ff14 which has no change associated with it.\n* Depends on commit bca28ec1198e1bbbddc723f550e38bb33437cd18 which has no change associated with it.\n* Depends on commit 01e5adfcb80518dea53560b8f3a5a6570dbaaf0e which has no change associated with it.\n* Depends on commit 06ebfe6cf4eb7d85371db905847f7c21f22f3c3e which has no change associated with it.\n* Depends on commit 332f1e6e7f384a42e0dec2d1a6d4cd34f6430d3f which has no change associated with it.\n* Depends on commit 8c58fefcd60b23c46e6de4150216d00fd2b13c5b which has no change associated with it.\n* Depends on commit 1d154520449a0eb98a27cb77eea51b665ce04da0 which has no change associated with it.\n* Depends on commit 19ca2887127e4d6e83c39208d56f862ae1c5e53c which has no change associated with it.\n* Depends on commit 90e9d96ea5f184ea6e4cd22192489c3e4cd066cb which has no change associated with it.\n* Depends on commit 719910efb0f0f550bf8acc792cb3cae1d0bc0785 which has no change associated with it.\n* Depends on commit 89df6b5936cad386aa5aec556a37325c5ba56f76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',429,1,429,'3a4c51b2_9ccde560',NULL),(6,'2015-06-12 12:15:47','Patch Set 2: Code-Review+2',429,2,429,'3a4c51b2_dcd76dec',NULL),(6,'2015-06-12 12:15:45','Patch Set 2: Patch Set 1 was rebased',429,1,429,'3a4c51b2_fcda2916',NULL),(11,'2015-04-22 17:01:10','Uploaded patch set 1.',429,1,429,'5a7ca5a3_7530c856',NULL),(7,'2015-11-05 22:13:49','Abandoned\n\nNothing has been said for months. Abandoning.',430,1,430,'1af78d9a_6b578103',NULL),(6,'2015-06-12 13:39:28','Patch Set 1: Code-Review-1',430,1,430,'3a4c51b2_3c601135',NULL),(6,'2015-06-12 14:47:42','Patch Set 1:\n\nSo it\'s meant to call reduce() rather than _reduce() ?',430,1,430,'3a4c51b2_3cc77114',NULL),(11,'2015-06-12 14:04:07','Patch Set 1:\n\nSee https://docs.python.org/2/library/functions.html#reduce',430,1,430,'3a4c51b2_9c504560',NULL),(6,'2015-06-12 12:17:21','Patch Set 1:\n\nIs this a later version of https://gerrit.baserock.org/#/c/281/ ?',430,1,430,'3a4c51b2_9cf4c588',NULL),(11,'2015-06-12 14:12:02','Patch Set 1:\n\nIn python 3 reduce is here https://docs.python.org/3.2/library/functools.html',430,1,430,'3a4c51b2_dc4acdab',NULL),(6,'2015-06-12 13:38:52','Patch Set 1:\n\nThis does seem like a newer version of #281, but still with a reference to a function named _reduce() that doesn\'t exist.',430,1,430,'3a4c51b2_fc76a905',NULL),(11,'2015-04-22 17:01:10','Uploaded patch set 1.',430,1,430,'5a7ca5a3_1535d445',NULL),(36,'2015-06-18 10:06:19','Patch Set 1:\n\n(1 comment)',430,1,430,'9a561d44_372678bb',NULL),(11,'2015-06-15 08:26:29','Patch Set 1:\n\nFor python 3 you might need to include functools. Probably the preceding underscore isn\'t strictly needed',430,1,430,'fa57193c_1a2b9d83',NULL),(37,'2015-09-23 10:19:59','Patch Set 1:\n\n> For python 3 you might need to include functools.\n\nWe don\'t currently support python3. I don\'t object to idioms that are compatible with both, provided it actually works.\n\n> Probably the preceding underscore isn\'t strictly needed.\n\nWith the preceding underscore the function is completely undefined, so this can\'t work. It\'s nothing about whether it\'s strictly needed or not, it\'s just broken.',430,1,430,'fafc7978_27a648c2',NULL),(6,'2015-09-23 11:09:42','Patch Set 1:\n\nThis seems abandoned -- shall I officially abandon it? I will do so next week if there is no comment before then.',430,1,430,'fafc7978_4788ac22',NULL),(37,'2015-09-23 12:53:19','Patch Set 1: Code-Review-2\n\n> This seems abandoned -- shall I officially abandon it? I will do so next week if there is no comment before then.\n\nIt certainly needs a lot of work.\n\nI think it would be better to abandon and re-submit the new version than send a follow up.',430,1,430,'fafc7978_a7cd1860',NULL),(37,'2015-09-23 12:45:21','Patch Set 1:\n\n(28 comments)',430,1,430,'fafc7978_c7d01cfa',NULL),(18,'2015-04-23 18:08:11','Patch Set 2: Code-Review+2',431,2,431,'3a79b1b5_1441540b',NULL),(18,'2015-04-23 18:08:18','Change has been successfully merged into the git repository.',431,2,431,'3a79b1b5_3446d024',NULL),(6,'2015-04-23 17:55:59','Uploaded patch set 2.',431,2,431,'3a79b1b5_743c4894',NULL),(6,'2015-04-22 17:30:38','Uploaded patch set 1.',431,1,431,'5a7ca5a3_f5229800',NULL),(27,'2015-04-24 13:51:11','Patch Set 1: Code-Review+1\n\nLooks sane to me. not in a position to test however.',432,1,432,'1a76adc5_f3c0707e',NULL),(11,'2015-04-23 08:54:59','Patch Set 1: Code-Review+1',432,1,432,'3a79b1b5_5426ecbb',NULL),(11,'2015-04-23 08:55:41','Patch Set 1: -Code-Review',432,1,432,'3a79b1b5_742be882',NULL),(29,'2015-04-22 17:52:33','Uploaded patch set 1.',432,1,432,'5a7ca5a3_951fa4b7',NULL),(28,'2015-04-30 14:32:29','Patch Set 2:\n\n(1 comment)',432,2,432,'bada0100_19e74fe6',NULL),(37,'2015-04-30 13:49:36','Change has been successfully rebased as 9867774b70545831d5b3baca4dc47c17ef890601',432,1,432,'bada0100_999edf62',NULL),(29,'2015-05-01 06:49:40','Patch Set 2:\n\n(1 comment)',432,2,432,'bada0100_a454daca',NULL),(37,'2015-04-30 13:49:35','Patch Set 2: Patch Set 1 was rebased',432,1,432,'bada0100_f9912b53',NULL),(6,'2015-04-27 11:16:42','Patch Set 1:\n\nI still think it\'s better to make a generic solution that doesn\'t suck, but we still haven\'t done that, so I see no harm in merging this.',432,1,432,'dad5f5cf_11416c0b',NULL),(6,'2015-04-27 11:15:52','Patch Set 1: Code-Review+2\n\nI still think it\'s better to make a generic solution that doesn\'t suck, but we still haven\'t done that, so I see no harm in merging this.',432,1,432,'dad5f5cf_5137f4b0',NULL),(15,'2015-04-22 18:26:38','Uploaded patch set 1.',433,1,433,'5a7ca5a3_b51c20c3',NULL),(15,'2015-04-28 13:15:31','Uploaded patch set 2.',433,2,433,'bada0100_10264469',NULL),(15,'2015-05-12 15:25:02','Patch Set 7: Code-Review+2',433,7,433,'bada0100_17e4f30b',NULL),(6,'2015-04-29 09:05:48','Patch Set 4:\n\nMy concern still stands. To avoid blocking work on ARMv5, maybe it\'d be useful to merge this to a temporary branch of definitions and update VERSION in that branch, for now ? That way Morph from Baserock 15.17-rc could still build master for the time being (and we wouldn\'t get in a situation where 15.17-rc couldn\'t build whatever the next release is).',433,4,433,'bada0100_333a7237',NULL),(15,'2015-04-28 13:21:08','Patch Set 2:\n\n> Actually, there\'s a problem with merging this system to\n > definitions. The problem is that it makes older versions of Morph\n > that think \'armv5\' is an invalid architecture unable to build\n > anything from definitions. Which means it needs to be treated as a\n > new VERSION of the definition format.\n > \n > Currently you get an error trying to build Baserock 15.10 with\n > Morph from Baserock 14.46 (because of the new armv8l64 systems),\n > but you also get an error trying to run Morph from Baseock 15.10 in\n > Baserock 14.46 to get around that (because it added a dependency on\n > PyLRU), and this sort of breakage on upgrades seems to discourages\n > users from trying to upgrade at all.\n\nRigth, I will abandon this and submit as a different patch series to be able to commit the rest of the patches',433,2,433,'bada0100_50ba8ce2',NULL),(15,'2015-04-29 10:10:23','Patch Set 4:\n\n> My concern still stands. To avoid blocking work on ARMv5, maybe\n > it\'d be useful to merge this to a temporary branch of definitions\n > and update VERSION in that branch, for now ? That way Morph from\n > Baserock 15.17-rc could still build master for the time being (and\n > we wouldn\'t get in a situation where 15.17-rc couldn\'t build\n > whatever the next release is).\n\nYeah, I will hold on this until we bump the version in morph and make a new release',433,4,433,'bada0100_531296b5',NULL),(15,'2015-04-28 13:21:11','Abandoned',433,2,433,'bada0100_70bf90d1',NULL),(22,'2015-04-29 08:47:27','Patch Set 4:\n\nI\'ve been able to successfully cross-compile this on a VM so I\'m happy it works. I\'ll +1 if Sam is happy you\'ve satisfied his concern.',433,4,433,'bada0100_7330fa56',NULL),(15,'2015-04-28 13:23:26','Restored',433,2,433,'bada0100_90c79464',NULL),(15,'2015-04-28 13:24:37','Uploaded patch set 3.',433,3,433,'bada0100_b0c41860',NULL),(6,'2015-05-12 11:22:45','Patch Set 6: -Code-Review\n\n15.19 release will be able to build this system.',433,6,433,'bada0100_b74ac753',NULL),(15,'2015-05-12 15:25:06','Patch Set 8: Patch Set 7 was rebased',433,7,433,'bada0100_b7f087ca',NULL),(15,'2015-04-29 13:09:53','Uploaded patch set 5.',433,5,433,'bada0100_d32446c8',NULL),(15,'2015-04-29 13:29:48','Uploaded patch set 6.',433,6,433,'bada0100_d640b437',NULL),(15,'2015-05-12 15:25:06','Change has been successfully rebased as 8b66c3a67b38c6fa87ac6f9ac34ff0681cff8927',433,7,433,'bada0100_d7ed0bf1',NULL),(15,'2015-04-28 13:47:42','Uploaded patch set 4.',433,4,433,'bada0100_f09f004f',NULL),(15,'2015-05-12 15:24:40','Uploaded patch set 7.',433,7,433,'bada0100_f7e60f16',NULL),(6,'2015-04-27 12:32:05','Patch Set 1: Code-Review-2\n\nActually, there\'s a problem with merging this system to definitions. The problem is that it makes older versions of Morph that think \'armv5\' is an invalid architecture unable to build anything from definitions. Which means it needs to be treated as a new VERSION of the definition format.\n\nCurrently you get an error trying to build Baserock 15.10 with Morph from Baserock 14.46 (because of the new armv8l64 systems), but you also get an error trying to run Morph from Baseock 15.10 in Baserock 14.46 to get around that (because it added a dependency on PyLRU), and this sort of breakage on upgrades seems to discourages users from trying to upgrade at all.',433,1,433,'dad5f5cf_31b910ea',NULL),(15,'2015-04-27 11:40:26','Patch Set 1: Code-Review-1\n\nThis needs to be updated after the recent changes in the cross-* systems',433,1,433,'dad5f5cf_51d37438',NULL),(8,'2015-04-27 11:25:47','Patch Set 1: Code-Review+1',433,1,433,'dad5f5cf_916b1c85',NULL),(6,'2015-04-27 11:25:27','Patch Set 1: Code-Review+1',433,1,433,'dad5f5cf_f16e2896',NULL),(15,'2015-04-22 18:26:38','Uploaded patch set 1.',434,1,434,'5a7ca5a3_55790cfb',NULL),(15,'2015-04-28 13:15:31','Uploaded patch set 2.',434,2,434,'bada0100_302b4832',NULL),(15,'2015-04-28 13:18:07','Change has been successfully rebased as 68009f226fa25c6f158005680f4abcd19481dab4',434,2,434,'bada0100_50d36c38',NULL),(15,'2015-04-28 13:12:05','Patch Set 1: Code-Review+2',434,1,434,'bada0100_7031d0a1',NULL),(15,'2015-04-28 13:18:03','Patch Set 2: Code-Review+2',434,2,434,'bada0100_9019d424',NULL),(15,'2015-04-28 13:18:06','Patch Set 3: Patch Set 2 was rebased',434,2,434,'bada0100_b01658f0',NULL),(8,'2015-04-27 11:26:12','Patch Set 1: Code-Review+1',434,1,434,'dad5f5cf_b168a088',NULL),(6,'2015-04-27 11:25:05','Patch Set 1: Code-Review+1',434,1,434,'dad5f5cf_d171a478',NULL),(22,'2015-04-27 14:00:54','Patch Set 1: Code-Review+1\n\nThis seems sensible. One question though, I understand we\'re looking to move away from morph as the only tool for making builds. Hence, perhaps we should be renaming $MORPH_ARCH to something more generic.',434,1,434,'dad5f5cf_d1c9a45b',NULL),(15,'2015-04-22 18:26:38','Uploaded patch set 1.',435,1,435,'5a7ca5a3_757e88e6',NULL),(15,'2015-04-28 13:24:59','Patch Set 3: Code-Review+2',435,3,435,'bada0100_10aba48a',NULL),(NULL,'2015-04-28 13:18:32','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ie917edd7, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',435,2,435,'bada0100_10dde442',NULL),(15,'2015-04-28 13:25:01','Change has been successfully merged into the git repository.',435,3,435,'bada0100_30b028f4',NULL),(15,'2015-04-28 13:24:37','Uploaded patch set 3.',435,3,435,'bada0100_50a12ca8',NULL),(15,'2015-04-28 13:18:29','Patch Set 2: Code-Review+2',435,2,435,'bada0100_70d8f053',NULL),(15,'2015-04-28 13:15:31','Uploaded patch set 2.',435,2,435,'bada0100_d01f5c08',NULL),(6,'2015-04-27 11:24:47','Patch Set 1: Code-Review+2',435,1,435,'dad5f5cf_315d90ea',NULL),(8,'2015-04-27 11:26:29','Patch Set 1: Code-Review+1',435,1,435,'dad5f5cf_5105b4c0',NULL),(22,'2015-04-27 14:50:32','Patch Set 1: Code-Review+1',435,1,435,'dad5f5cf_f122a800',NULL),(15,'2015-04-22 18:26:38','Uploaded patch set 1.',436,1,436,'5a7ca5a3_158394cd',NULL),(15,'2015-04-22 19:24:45','Patch Set 1:\n\nI\'ve native built an armv5 rootfs on a armv7 board with these changes',436,1,436,'5a7ca5a3_d56c3c39',NULL),(15,'2015-04-28 13:24:37','Uploaded patch set 3.',436,3,436,'bada0100_70a6b0c3',NULL),(NULL,'2015-04-28 13:18:56','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ie917edd7, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',436,2,436,'bada0100_90f0f4ca',NULL),(15,'2015-04-28 13:25:07','Patch Set 3: Code-Review+2',436,3,436,'bada0100_d0943c46',NULL),(15,'2015-04-28 13:18:55','Patch Set 2: Code-Review+2',436,2,436,'bada0100_d0e67c16',NULL),(15,'2015-04-28 13:15:31','Uploaded patch set 2.',436,2,436,'bada0100_f01ce015',NULL),(15,'2015-04-28 13:25:09','Change has been successfully merged into the git repository.',436,3,436,'bada0100_f0914053',NULL),(8,'2015-04-27 11:26:45','Patch Set 1: Code-Review+1',436,1,436,'dad5f5cf_110f2ce3',NULL),(6,'2015-04-27 11:24:38','Patch Set 1: Code-Review+2',436,1,436,'dad5f5cf_11588cf9',NULL),(22,'2015-04-27 14:10:30','Patch Set 1: Code-Review+1',436,1,436,'dad5f5cf_11e72ce6',NULL),(11,'2015-04-23 08:26:59','Patch Set 1: Code-Review+1',437,1,437,'3a79b1b5_d412fc57',NULL),(15,'2015-04-22 18:30:49','Uploaded patch set 1.',437,1,437,'5a7ca5a3_358810e7',NULL),(15,'2015-04-22 19:24:57','Patch Set 1:\n\nI\'ve native built an armv5 rootfs on a armv7 board with these changes',437,1,437,'5a7ca5a3_f5693826',NULL),(15,'2015-04-28 13:09:41','Patch Set 2: Code-Review+2',437,2,437,'bada0100_900234b3',NULL),(15,'2015-04-28 13:09:43','Change has been successfully merged into the git repository.',437,2,437,'bada0100_b0ff38aa',NULL),(15,'2015-04-28 13:09:22','Uploaded patch set 2.',437,2,437,'bada0100_f0f5c0cb',NULL),(6,'2015-04-27 11:24:02','Patch Set 1: Code-Review+2\n\n> I\'ve native built an armv5 rootfs on a armv7 board with these\n > changes\n\nGood enough for me. Code looks fine. Thanks!',437,1,437,'dad5f5cf_716318b2',NULL),(22,'2015-04-27 14:08:52','Patch Set 1: Code-Review+1',437,1,437,'dad5f5cf_b1c0a02b',NULL),(16,'2015-04-22 21:58:24','Uploaded patch set 1.',438,1,438,'5a7ca5a3_d5019c3a',NULL),(16,'2015-04-22 21:59:04','Abandoned\n\nOops, I thought I\'d finished rebasing.',438,1,438,'5a7ca5a3_f5fe1838',NULL),(8,'2015-04-24 13:50:19','Change has been successfully rebased as 81b6779dddcf977daf26db193c8bcd016066e044',439,1,439,'1a76adc5_93e6dc43',NULL),(8,'2015-04-24 13:50:16','Patch Set 1: Code-Review+2',439,1,439,'1a76adc5_d3dc5477',NULL),(8,'2015-04-24 13:50:19','Patch Set 2: Patch Set 1 was rebased',439,1,439,'1a76adc5_f3d95084',NULL),(8,'2015-04-23 10:01:56','Patch Set 1: Code-Review+1',439,1,439,'3a79b1b5_146e34ca',NULL),(28,'2015-04-23 09:00:41','Uploaded patch set 1.',439,1,439,'3a79b1b5_342570ab',NULL),(27,'2015-04-23 10:43:45','Patch Set 1: Code-Review+1',439,1,439,'3a79b1b5_74a0c8f4',NULL),(24,'2015-04-23 10:54:09','Uploaded patch set 1.',440,1,440,'3a79b1b5_d4ae7ce7',NULL),(24,'2015-04-23 11:00:27','Patch Set 1:\n\nThis patch was tested by building a web-system-x86_64-generic system with the change, and verifying that the nginx in it had SSL support configured.',440,1,440,'3a79b1b5_f4ab78d4',NULL),(6,'2015-04-27 11:10:12','Patch Set 2: Patch Set 1 was rebased',440,1,440,'dad5f5cf_51d05453',NULL),(6,'2015-04-27 11:10:13','Change has been successfully rebased as f2d78e9b7221bca65cba53af3f3b50d50d90628f',440,1,440,'dad5f5cf_71d55842',NULL),(7,'2015-04-27 11:04:32','Patch Set 1: Code-Review+2',440,1,440,'dad5f5cf_91e6bc43',NULL),(8,'2015-04-27 08:56:51','Patch Set 1: Code-Review+1\n\nThis builds fine.',440,1,440,'dad5f5cf_d139a4d9',NULL),(6,'2015-04-24 10:58:56','Change has been successfully rebased as e62366ed8a32a44dbe034e8d43450338b1b66e12',441,1,441,'1a76adc5_53828453',NULL),(6,'2015-04-24 10:58:53','Patch Set 1:\n\nthanks for this!',441,1,441,'1a76adc5_93b81c2c',NULL),(6,'2015-04-24 10:58:56','Patch Set 2: Patch Set 1 was rebased',441,1,441,'1a76adc5_b3b51833',NULL),(6,'2015-04-24 10:58:47','Patch Set 1: Code-Review+2',441,1,441,'1a76adc5_f3ab90d4',NULL),(7,'2015-04-23 13:55:06','Uploaded patch set 1.',441,1,441,'3a79b1b5_54d02c53',NULL),(37,'2015-04-24 15:01:26','Patch Set 1: Code-Review-2\n\nFurther investigation of what is required to break the symlinks points to more evidence that it will be a huge undertaking, so merging this would break more things for longer than I had previously thought when I proposed this change.',442,1,442,'1a76adc5_13416c0b',NULL),(37,'2015-04-23 14:04:28','Uploaded patch set 1.',442,1,442,'3a79b1b5_14cab4a1',NULL),(42,'2015-04-23 19:49:05','Patch Set 1:\n\nAnother *really* important note to take into account is that unless and until we make the rootfs read-only (either / read-only with everything mutable mounted on top, or /usr read-only and everything moved into there) we *need* to make all the write extensions break hard-links when copying from the staging area into the target image.\n\nThis is because there is no way to tell whether a file is a hard link because it was a hard link in the chunk\'s DESTDIR, or whether it is a hard-link because it has been deduplicated by OSTree.\n\nIn the latter case, if the hard-link is not broken, this results in unwanted sharing of files, such that if one deduplicated file is written to, they all are.\nAn example where this can cause problems, such as when /etc/machine-id is written to. This results in all empty files suddenly containing the machine id.\nSince there are some important files that *must* remain empty, I believe one example was a C library header file, where it being empty was significant, this results in a system that is broken in some fashion.',442,1,442,'3a79b1b5_d44afc26',NULL),(37,'2015-04-30 16:22:51','Abandoned\n\nI don\'t have a solution for the write extensions making invalid systems',442,1,442,'bada0100_2420ea9a',NULL),(37,'2015-04-24 10:35:09','Patch Set 1: Code-Review+2',443,1,443,'1a76adc5_337348b3',NULL),(8,'2015-04-24 08:32:03','Patch Set 1: Code-Review+1',443,1,443,'1a76adc5_53ffe401',NULL),(42,'2015-04-23 20:43:44','Patch Set 1: Code-Review+1\n\nFair enough. I had assumed that 32 bit would be an option, but if it is not then I retract that concern.\nThere\'s something to be said for keeping 32-bit as capable as 64-bit, but that\'s not sufficient cause to delay this change.',443,1,443,'3a79b1b5_140f14e3',NULL),(47,'2015-04-23 20:10:04','Patch Set 1:\n\n> I\'d like to see 32-bit x86 too, since this is roughly what\'s needed\n > for AWS too.\n\nI\'m happy to add this to 32-bit, but if its for AWS specifically I don\'t see the purpose. Amazon has had 64bit available for all instances since 2012, they recommend their 64bit AMI for all instance types.\n\nI checked the AWS console. 32bit windows AMI is the only standard 32 bit available. Choosing that limits you to the T2 burstable instances. Looks like 32 bit isn\'t even available for most of their instance types any more.',443,1,443,'3a79b1b5_145874f9',NULL),(47,'2015-04-23 15:11:49','Uploaded patch set 1.',443,1,443,'3a79b1b5_94bd6405',NULL),(42,'2015-04-23 19:55:05','Patch Set 1:\n\nI\'d like to see 32-bit x86 too, since this is roughly what\'s needed for AWS too.',443,1,443,'3a79b1b5_f447f81b',NULL),(37,'2015-04-30 09:38:43','Change has been successfully merged into the git repository.',443,2,443,'bada0100_163b9cec',NULL),(37,'2015-04-30 09:38:16','Patch Set 2: Patch Set 1 was rebased',443,1,443,'bada0100_5631240a',NULL),(37,'2015-04-30 09:38:37','Patch Set 2: Code-Review+2\n\nThis patch appeared to have become stuck, so I\'ve rebased and re-submitted.',443,2,443,'bada0100_7636a805',NULL),(47,'2015-04-24 17:27:04','Patch Set 1:\n\n(3 comments)\n\n> (10 comments)\n > \n > Interesting work. I\'d be happy to see a version of this merged, but\n > I think there\'s a few fix-ups that would improve it first.',444,1,444,'1a76adc5_532cc44a',NULL),(42,'2015-04-23 20:22:35','Patch Set 1:\n\n(10 comments)\n\nInteresting work. I\'d be happy to see a version of this merged, but I think there\'s a few fix-ups that would improve it first.',444,1,444,'3a79b1b5_740a08d4',NULL),(47,'2015-04-23 15:11:49','Uploaded patch set 1.',444,1,444,'3a79b1b5_b4bae008',NULL),(47,'2015-06-18 21:53:47','Uploaded patch set 2.',444,2,444,'9a561d44_9747841d',NULL),(37,'2015-04-30 09:40:40','Patch Set 1:\n\nLooking forward to the next version.',444,1,444,'bada0100_36402056',NULL),(8,'2015-09-29 11:16:21','Patch Set 2:\n\nAre we still interested on getting this into master? Adam or Richard could you modify this patch adding your comments so we could review and merge this change?',444,2,444,'da01753e_d17d84b3',NULL),(16,'2015-06-24 14:52:12','Patch Set 2: Code-Review-1\n\n(4 comments)\n\nThe day after this patch was sent, a patch was merged which stopped the existing write extensions from depending on morphlib and cliapp. I\'d like to keep it that way if at all possible.\n\nFor this reason, I\'m voting -1 to this patch. It should be trivial to make it not use cliapp and morphlib anymore, I tried to ensure that change would cause minimal code churn in the existing extensions.\n\nIf you don\'t have time to make these changes then I\'m happy to send a follow-up patch to make them if someone else +1s this and it is merged, given the remove-dependencies patch somewhat quietly changed things under your feet :) .',444,2,444,'fafc7978_12870c63',NULL),(37,'2015-06-24 14:30:58','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nLooks good to me, but I\'d like someone else to have another pair of eyes on this before merging.',444,2,444,'fafc7978_b2ae00e6',NULL),(27,'2015-04-24 13:47:26','Patch Set 1: Code-Review+1',445,1,445,'1a76adc5_33f828e5',NULL),(15,'2015-04-23 15:32:15','Uploaded patch set 1.',445,1,445,'3a79b1b5_5437ccb0',NULL),(15,'2015-04-28 14:41:30','Abandoned\n\nThis has been already merged as part of the GLib move to the core stratum',445,1,445,'bada0100_f0cdc05e',NULL),(39,'2015-04-24 09:34:49','Uploaded patch set 1.',446,1,446,'1a76adc5_330ee835',NULL),(39,'2015-04-24 15:31:34','Uploaded patch set 3.',446,3,446,'1a76adc5_b35198da',NULL),(39,'2015-04-24 09:39:13','Uploaded patch set 2.',446,2,446,'1a76adc5_f30f102d',NULL),(27,'2015-04-28 13:01:22','Patch Set 4: Code-Review+1',446,4,446,'bada0100_105884f9',NULL),(27,'2015-04-28 16:19:37','Patch Set 5: Code-Review+1',446,5,446,'bada0100_10b6448b',NULL),(29,'2015-04-28 15:24:01','Uploaded patch set 5.',446,5,446,'bada0100_303a6837',NULL),(33,'2015-04-28 17:27:58','Patch Set 5: Code-Review-2\n\nCommand output is sometimes delayed for several seconds,\nsuggest we solve this problem before merging these changes.',446,5,446,'bada0100_50184c84',NULL),(33,'2015-04-29 16:11:29','Patch Set 6: Code-Review+2',446,6,446,'bada0100_568fe423',NULL),(33,'2015-04-29 16:11:30','Change has been successfully merged into the git repository.',446,6,446,'bada0100_76946837',NULL),(33,'2015-04-29 16:02:04','Patch Set 5: Code-Review+2',446,5,446,'bada0100_76bf88d1',NULL),(33,'2015-04-29 16:11:26','Patch Set 6: Patch Set 5 was rebased',446,5,446,'bada0100_b672d047',NULL),(39,'2015-04-28 08:22:26','Uploaded patch set 4.',446,4,446,'bada0100_f00f002d',NULL),(6,'2015-04-27 11:19:34','Patch Set 3:\n\nI\'m not sure this is needed, although there\'s no harm it. +0 from me.',446,3,446,'dad5f5cf_515e14eb',NULL),(6,'2015-04-24 10:56:17','Patch Set 1: Code-Review+1\n\nlooks good, not tested',447,1,447,'1a76adc5_73a0e0f4',NULL),(15,'2015-04-24 10:17:58','Uploaded patch set 1.',447,1,447,'1a76adc5_931c9c6c',NULL),(15,'2015-04-28 13:41:25','Patch Set 2: Code-Review+2',447,2,447,'bada0100_1082c400',NULL),(15,'2015-04-28 13:41:29','Patch Set 3: Patch Set 2 was rebased',447,2,447,'bada0100_3087c811',NULL),(22,'2015-04-28 13:10:13','Patch Set 1: Code-Review+1\n\nThis looks good though I haven\'t tested it. I won\'t veto for this, but I would prefer you added a quick explanation as to why you\'ve done this change to the commit message.',447,1,447,'bada0100_502ccc4a',NULL),(8,'2015-04-28 13:06:51','Patch Set 1: Code-Review+1',447,1,447,'bada0100_700a30d4',NULL),(15,'2015-04-28 13:39:47','Uploaded patch set 2.',447,2,447,'bada0100_708d5031',NULL),(15,'2015-04-28 13:41:29','Change has been successfully rebased as 610d5fa11f9c62f10cdbd0e555468976ab5e3ebd',447,2,447,'bada0100_d07bdc27',NULL),(15,'2015-04-24 10:17:58','Uploaded patch set 1.',448,1,448,'1a76adc5_b319987b',NULL),(6,'2015-04-24 10:55:52','Patch Set 1: Code-Review+1\n\nLooks good, not tested',448,1,448,'1a76adc5_b35e7811',NULL),(8,'2015-04-28 13:06:56','Patch Set 1: Code-Review+1',448,1,448,'bada0100_100f24e3',NULL),(15,'2015-04-28 13:42:47','Change has been successfully rebased as 4e46e6e140afd282ddb32fdcb9b2be295bcab07a',448,3,448,'bada0100_1099646e',NULL),(22,'2015-04-28 13:18:40','Patch Set 1: Code-Review+1',448,1,448,'bada0100_30e26804',NULL),(15,'2015-04-28 13:39:47','Uploaded patch set 2.',448,2,448,'bada0100_50884c22',NULL),(15,'2015-04-28 13:42:45','Patch Set 3: Code-Review+2',448,3,448,'bada0100_508fec23',NULL),(15,'2015-04-28 13:42:47','Patch Set 4: Patch Set 3 was rebased',448,3,448,'bada0100_70947037',NULL),(NULL,'2015-04-28 13:41:34','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I9d1527b5, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',448,2,448,'bada0100_90755434',NULL),(15,'2015-04-28 13:42:36','Uploaded patch set 3.',448,3,448,'bada0100_b072d847',NULL),(15,'2015-04-28 13:41:32','Patch Set 2: Code-Review+2',448,2,448,'bada0100_f078602d',NULL),(6,'2015-04-24 10:28:08','Change has been successfully merged into the git repository.',449,1,449,'1a76adc5_136e4cca',NULL),(6,'2015-04-24 10:27:15','Patch Set 1: Code-Review+2',449,1,449,'1a76adc5_5374c49b',NULL),(6,'2015-04-24 10:28:06','Patch Set 1:\n\nI have tested this on an x86 trove system and it does fix the crash in rpc.mountd.',449,1,449,'1a76adc5_7379c092',NULL),(37,'2015-04-24 10:27:04','Uploaded patch set 1.',449,1,449,'1a76adc5_b347584b',NULL),(15,'2015-04-24 10:56:29','Patch Set 1: Code-Review+2',450,1,450,'1a76adc5_13a5ec03',NULL),(15,'2015-04-24 10:56:31','Patch Set 2: Patch Set 1 was rebased',450,1,450,'1a76adc5_33aa68d5',NULL),(7,'2015-04-24 10:56:05','Patch Set 1: Code-Review+1',450,1,450,'1a76adc5_539b64c9',NULL),(6,'2015-04-24 10:52:39','Uploaded patch set 1.',450,1,450,'1a76adc5_9361fcd5',NULL),(15,'2015-04-24 10:56:32','Change has been successfully rebased as 8895d7ace9f409dc18c9706d39d0521b131dd573',450,1,450,'1a76adc5_d3ae94e7',NULL),(8,'2015-04-24 14:12:36','Patch Set 1: Code-Review+1',451,1,451,'1a76adc5_5337e4b0',NULL),(15,'2015-04-24 14:04:08','Uploaded patch set 1.',451,1,451,'1a76adc5_b3baf808',NULL),(15,'2015-04-25 18:16:40','Change has been successfully merged into the git repository.',451,1,451,'fad0f9df_12096c2c',NULL),(35,'2015-04-25 17:44:04','Patch Set 1: Code-Review+1\n\nLooks good!',451,1,451,'fad0f9df_52fff401',NULL),(15,'2015-04-25 18:16:38','Patch Set 1: Code-Review+2',451,1,451,'fad0f9df_72047815',NULL),(7,'2015-04-24 15:57:20','Patch Set 1:\n\nOther than my previous comment, everything else looks great',452,1,452,'1a76adc5_5305a4c0',NULL),(8,'2015-04-24 15:39:53','Uploaded patch set 1.',452,1,452,'1a76adc5_535e04eb',NULL),(8,'2015-04-24 15:59:34','Uploaded patch set 2.',452,2,452,'1a76adc5_730a20d4',NULL),(7,'2015-04-24 15:56:52','Patch Set 1:\n\n(1 comment)',452,1,452,'1a76adc5_b368b888',NULL),(6,'2015-04-27 11:12:21','Patch Set 2: Code-Review+2',452,2,452,'dad5f5cf_11cacca1',NULL),(7,'2015-04-27 08:36:55','Patch Set 2: Code-Review+1',452,2,452,'dad5f5cf_310ef035',NULL),(6,'2015-04-27 11:12:31','Patch Set 2:\n\nLooks fine to me, untested',452,2,452,'dad5f5cf_31cfd0b2',NULL),(28,'2015-04-27 11:15:57','Patch Set 2: Code-Review-1\n\n(3 comments)\n\nI am -1 until the comment on the openstack-ceilomenter-db-setup being answered. I would like that rest of my comments were addressed, although not being mandatory.',452,2,452,'dad5f5cf_713c7894',NULL),(8,'2015-04-27 13:22:15','Patch Set 3: -Code-Review\n\nAddress Tiago Gomes comments',452,3,452,'dad5f5cf_71947837',NULL),(8,'2015-04-27 11:18:37','Patch Set 2: Code-Review-2\n\n(3 comments)',452,2,452,'dad5f5cf_91547ccb',NULL),(8,'2015-04-27 14:47:46','Patch Set 4: Patch Set 3 was rebased',452,3,452,'dad5f5cf_91f1dc97',NULL),(8,'2015-04-27 11:19:31','Patch Set 2:\n\n> (3 comments)\n\nTiago\'s comments should be addresed before merging this',452,2,452,'dad5f5cf_b15180da',NULL),(8,'2015-04-27 14:47:46','Change has been successfully rebased as 717aef60fccc3c6932f21adf3d9852e710817800',452,3,452,'dad5f5cf_b1ee60b3',NULL),(28,'2015-04-27 14:46:11','Patch Set 3: Code-Review+1\n\nThe systemd units are not optimal, but as I am working in tidying\nup them, they will be improved in a future patch.',452,3,452,'dad5f5cf_d1f7648b',NULL),(8,'2015-04-27 13:21:35','Uploaded patch set 3.',452,3,452,'dad5f5cf_f178682d',NULL),(27,'2015-04-27 14:08:07','Patch Set 3: Code-Review+1',452,3,452,'dad5f5cf_f1c62849',NULL),(8,'2015-04-27 14:47:43','Patch Set 3: Code-Review+2',452,3,452,'dad5f5cf_f1f4e888',NULL),(8,'2015-04-24 15:59:34','Uploaded patch set 2.',453,2,453,'1a76adc5_130f2ce3',NULL),(8,'2015-04-24 15:39:53','Uploaded patch set 1.',453,1,453,'1a76adc5_736300b2',NULL),(7,'2015-04-24 15:43:12','Patch Set 1: Code-Review+1',453,1,453,'1a76adc5_d371b478',NULL),(8,'2015-04-24 16:59:51','Patch Set 3: Commit message was updated',453,3,453,'1a76adc5_d3f8d4c6',NULL),(8,'2015-04-27 14:48:39','Patch Set 5: Patch Set 4 was rebased',453,4,453,'dad5f5cf_1135ec45',NULL),(28,'2015-04-27 14:45:29','Patch Set 4: -Code-Review\n\n> The systemd units are not optimal, but as I am working in tidying\n > up them, they will be improved in a future patch.\n\nOps, this comment was not for this patch.',453,4,453,'dad5f5cf_31035075',NULL),(8,'2015-04-27 14:48:56','Patch Set 5: Code-Review+2',453,5,453,'dad5f5cf_313a7037',NULL),(8,'2015-04-27 14:48:21','Patch Set 4: Code-Review+2',453,4,453,'dad5f5cf_512b74eb',NULL),(27,'2015-04-27 14:09:25','Patch Set 4: Code-Review+1',453,4,453,'dad5f5cf_51ddb413',NULL),(NULL,'2015-04-27 14:48:23','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I065dcd89, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',453,4,453,'dad5f5cf_7130f856',NULL),(8,'2015-04-27 10:02:10','Patch Set 3:\n\n(1 comment)',453,3,453,'dad5f5cf_7179d892',NULL),(28,'2015-04-27 10:40:57','Patch Set 3: Code-Review+1',453,3,453,'dad5f5cf_9161dcd5',NULL),(6,'2015-04-27 11:14:07','Patch Set 3:\n\nLooks fine, not tested',453,3,453,'dad5f5cf_91bd5c05',NULL),(7,'2015-04-27 08:39:07','Patch Set 3: Code-Review+1',453,3,453,'dad5f5cf_b119807b',NULL),(28,'2015-04-27 09:58:08','Patch Set 3:\n\n(1 comment)',453,3,453,'dad5f5cf_b147404b',NULL),(8,'2015-04-27 13:21:35','Uploaded patch set 4.',453,4,453,'dad5f5cf_b172e047',NULL),(8,'2015-04-27 14:48:59','Change has been successfully merged into the git repository.',453,5,453,'dad5f5cf_d13e8429',NULL),(28,'2015-04-27 14:12:53','Patch Set 4: Code-Review+1\n\nThe systemd units are not optimal, but as I am working in tidying up them, they will be improved in a future patch.',453,4,453,'dad5f5cf_d1d0c4f9',NULL),(6,'2015-04-27 11:14:00','Patch Set 3: Code-Review+2',453,3,453,'dad5f5cf_f1c0687e',NULL),(8,'2015-04-24 15:39:53','Uploaded patch set 1.',454,1,454,'1a76adc5_13588cf9',NULL),(8,'2015-04-24 15:59:34','Uploaded patch set 2.',454,2,454,'1a76adc5_3314a8f4',NULL),(7,'2015-04-24 15:42:52','Patch Set 1: Code-Review+1\n\nIt looks ok to me',454,1,454,'1a76adc5_335d88ea',NULL),(28,'2015-04-27 10:03:18','Patch Set 2: Code-Review+1',454,2,454,'dad5f5cf_116e4cca',NULL),(8,'2015-04-27 14:49:15','Patch Set 4: Code-Review+2',454,4,454,'dad5f5cf_511294b5',NULL),(7,'2015-04-27 08:39:13','Patch Set 2: Code-Review+1',454,2,454,'dad5f5cf_512614bc',NULL),(8,'2015-04-27 13:21:35','Uploaded patch set 3.',454,3,454,'dad5f5cf_518ff423',NULL),(8,'2015-04-27 14:49:20','Change has been successfully merged into the git repository.',454,4,454,'dad5f5cf_711798a4',NULL),(NULL,'2015-04-27 14:49:08','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of I5e79ebf8, however the current patch set is 5.\n* Depends on commit c1dff5d075dfad7922d284a51c8224adebb95833 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',454,3,454,'dad5f5cf_9148fccd',NULL),(27,'2015-04-27 14:08:47','Patch Set 3: Code-Review+1',454,3,454,'dad5f5cf_91c31c38',NULL),(8,'2015-04-27 14:49:11','Patch Set 4: Patch Set 3 was rebased',454,3,454,'dad5f5cf_b14500b5',NULL),(6,'2015-04-27 11:14:24','Patch Set 2: Code-Review+2\n\nLooks fine, not tested',454,2,454,'dad5f5cf_b1bae008',NULL),(8,'2015-04-27 14:49:06','Patch Set 3: Code-Review+2',454,3,454,'dad5f5cf_f13b8836',NULL),(28,'2015-04-24 17:12:47','Uploaded patch set 1.',455,1,455,'1a76adc5_f3f5d0cb',NULL),(8,'2015-04-27 10:54:13','Change has been successfully merged into the git repository.',455,1,455,'dad5f5cf_31aa70d5',NULL),(7,'2015-04-27 08:24:10','Patch Set 1: Code-Review+2',455,1,455,'dad5f5cf_51fff401',NULL),(28,'2015-04-24 17:12:47','Uploaded patch set 1.',456,1,456,'1a76adc5_93025cb3',NULL),(7,'2015-04-27 08:28:59','Patch Set 1: Code-Review+1\n\nThis looks OK to me',456,1,456,'dad5f5cf_71047815',NULL),(8,'2015-04-27 08:38:28','Patch Set 1: Code-Review+1',456,1,456,'dad5f5cf_911c7c6c',NULL),(8,'2015-04-27 10:54:18','Patch Set 1: Code-Review+2',456,1,456,'dad5f5cf_d1ae84e7',NULL),(8,'2015-04-27 10:54:28','Change has been successfully merged into the git repository.',456,1,456,'dad5f5cf_f1ab88d4',NULL),(28,'2015-04-24 17:12:47','Uploaded patch set 1.',457,1,457,'1a76adc5_b3ff58aa',NULL),(7,'2015-04-27 08:30:17','Patch Set 1: Code-Review+1',457,1,457,'dad5f5cf_11096c2c',NULL),(29,'2015-04-27 08:55:22','Patch Set 1: Code-Review+1\n\n> > Swift certainly needs to start after openstack-keystone,\n > > naturally the keystone users and endpoints need to have been\n > > created but that ordering should be specified by making\n > > openstack-keystone depend on openstack-keystone-setup, if it\n > > doesn\'t already.\n > \n > Just clarify this a bit:\n > \n > To have keystone ready, keystone-setup needs to do some tasks\n > before launching the keystone service, and it also needs to do some\n > tasks after the keystone service is running. Without those tasks,\n > keystone won\'t be ready to use.\n > \n > Keystone can\'t depend on keystone-setup, because keystone-setup\n > needs keystone running.\n > \n > But keystone-setup can\'t depend on keystone, because keystone needs\n > things that keystone-setup creates.\n > \n > Yes, sounds confusing, but IMO depending only on keystone-setup\n > makes sense.\n\nFair enough',457,1,457,'dad5f5cf_11208c9a',NULL),(8,'2015-04-27 10:59:17','Change has been successfully merged into the git repository.',457,1,457,'dad5f5cf_51e93419',NULL),(7,'2015-04-27 08:44:32','Patch Set 1:\n\n> Swift certainly needs to start after openstack-keystone,\n > naturally the keystone users and endpoints need to have been\n > created but that ordering should be specified by making\n > openstack-keystone depend on openstack-keystone-setup, if it\n > doesn\'t already.\n\nJust clarify this a bit:\n\nTo have keystone ready, keystone-setup needs to do some tasks before launching the keystone service, and it also needs to do some tasks after the keystone service is running. Without those tasks, keystone won\'t be ready to use.\n\nKeystone can\'t depend on keystone-setup, because keystone-setup needs keystone running.\n\nBut keystone-setup can\'t depend on keystone, because keystone needs things that keystone-setup creates.\n\nYes, sounds confusing, but IMO depending only on keystone-setup makes sense.',457,1,457,'dad5f5cf_712b1883',NULL),(29,'2015-04-27 09:05:49','Patch Set 1:\n\n(1 comment)',457,1,457,'dad5f5cf_91331cf6',NULL),(8,'2015-04-27 10:59:15','Patch Set 1: Code-Review+2',457,1,457,'dad5f5cf_b18c2081',NULL),(8,'2015-04-27 08:37:04','Patch Set 1: Code-Review+1',457,1,457,'dad5f5cf_d1120458',NULL),(29,'2015-04-27 10:14:20','Patch Set 1:\n\n(1 comment)',457,1,457,'dad5f5cf_d16764e9',NULL),(29,'2015-04-27 08:37:43','Patch Set 1: Code-Review-2\n\nI\'m not sure I follow the commit message, should\n\n\"are only created after starting and enabling the openstack-keystone service\"\n\nbe\n\n\"are only created after starting and enabling the openstack-keystone-setup service\" ?\n\nDoesn\'t openstack-keystone already depend on openstack-keystone-setup?\n\nSwift certainly needs to start after openstack-keystone,\nnaturally the keystone users and endpoints need to have been\ncreated but that ordering should be specified by making openstack-keystone depend on openstack-keystone-setup, if it doesn\'t already.',457,1,457,'dad5f5cf_f10f082d',NULL),(28,'2015-04-27 09:42:08','Patch Set 1:\n\n(1 comment)',457,1,457,'dad5f5cf_f13dc8bc',NULL),(15,'2015-04-29 14:59:42','Patch Set 4: Patch Set 3 was rebased',458,3,458,'bada0100_16415c0b',NULL),(15,'2015-04-28 12:35:37','Patch Set 1:\n\n(1 comment)',458,1,458,'bada0100_3046e824',NULL),(27,'2015-04-28 09:26:48','Patch Set 1:\n\nIt seems to build fine to me and I would give it a plus 1, Javiers comments could improve this though.\nconditional +1 if comments are addressed',458,1,458,'bada0100_305ca825',NULL),(41,'2015-04-29 11:46:48','Uploaded patch set 2.',458,2,458,'bada0100_33d6f2c6',NULL),(15,'2015-04-29 14:59:43','Change has been successfully rebased as aae1e3dec176ebc40cd233a29cf48c04d856fac5',458,3,458,'bada0100_3646e024',NULL),(37,'2015-04-29 13:42:26','Patch Set 3: Code-Review+1',458,3,458,'bada0100_367340b3',NULL),(37,'2015-04-28 10:21:53','Patch Set 1:\n\n(2 comments)',458,1,458,'bada0100_509b6cc9',NULL),(41,'2015-04-28 12:29:54','Patch Set 1:\n\n(1 comment)',458,1,458,'bada0100_703c7094',NULL),(41,'2015-04-29 12:20:33','Uploaded patch set 3.',458,3,458,'bada0100_739a3a16',NULL),(15,'2015-04-29 14:59:36','Patch Set 3: Code-Review+2\n\nJust tested and XDG_RUNTIME_DIR is correctly autogenerated by logind (so the pam configuration is correct). Thanks a lot for fixing this!',458,3,458,'bada0100_763c6894',NULL),(41,'2015-04-28 12:50:50','Patch Set 1:\n\n(1 comment)',458,1,458,'bada0100_905474cb',NULL),(41,'2015-04-28 11:45:49','Patch Set 1:\n\n(1 comment)',458,1,458,'bada0100_f0d94084',NULL),(15,'2015-04-27 15:04:21','Patch Set 1: Code-Review-1\n\n(2 comments)',458,1,458,'dad5f5cf_1183accd',NULL),(37,'2015-04-27 12:58:34','Patch Set 1:\n\n(3 comments)\n\nLooks mostly good, I\'d just like you to see if your pam config is compatible with the snippets shipped by systemd.',458,1,458,'dad5f5cf_31b030f4',NULL),(6,'2015-04-27 13:43:06','Patch Set 1:\n\n(1 comment)\n\nLooks fine apart from what Richard already raised, thanks.',458,1,458,'dad5f5cf_31b590cd',NULL),(15,'2015-04-27 15:54:44','Patch Set 1:\n\n(1 comment)',458,1,458,'dad5f5cf_31bb5074',NULL),(15,'2015-04-27 15:47:48','Patch Set 1:\n\n(4 comments)',458,1,458,'dad5f5cf_71c1d8e3',NULL),(41,'2015-04-27 12:36:17','Uploaded patch set 1.',458,1,458,'dad5f5cf_91c79c64',NULL),(41,'2015-04-29 12:20:33','Uploaded patch set 3.',459,3,459,'bada0100_139f2e05',NULL),(15,'2015-04-29 14:59:01','Patch Set 3: Code-Review+1\n\nJust tested and XDG_RUNTIME_DIR is correctly autogenerated by logind. Thanks a lot for fixing this!',459,3,459,'bada0100_5637e4b0',NULL),(15,'2015-04-29 15:00:17','Change has been successfully merged into the git repository.',459,4,459,'bada0100_565e04eb',NULL),(15,'2015-04-29 15:00:14','Patch Set 4: Patch Set 3 was rebased',459,3,459,'bada0100_96546ccb',NULL),(37,'2015-04-29 11:57:21','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nFix the commit message please.',459,2,459,'bada0100_b3e1829c',NULL),(15,'2015-04-29 15:00:16','Patch Set 4: Code-Review+2',459,4,459,'bada0100_b65170da',NULL),(41,'2015-04-29 11:46:48','Uploaded patch set 2.',459,2,459,'bada0100_d3da06e9',NULL),(NULL,'2015-04-29 14:59:47','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I1b00ca01, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',459,3,459,'bada0100_d64af426',NULL),(37,'2015-04-29 13:42:57','Patch Set 3: Code-Review+2\n\nLooks good. This needs to be submitted for merge after https://gerrit.baserock.org/#/c/458/ is merged.',459,3,459,'bada0100_d66754e9',NULL),(6,'2015-04-27 13:40:49','Patch Set 1:\n\n(4 comments)\n\nThanks for the patch! It seems like these are all workarounds, so I don\'t think we should merge this without at least adding comments to explain what is being worked around and why.\n\nAre there specific use cases we have where systemd user sessions are useful? I\'ve never used them myself.',459,1,459,'dad5f5cf_71bb18c5',NULL),(37,'2015-04-27 14:58:12','Patch Set 1:\n\n(3 comments)',459,1,459,'dad5f5cf_911f9cb7',NULL),(15,'2015-04-27 15:17:28','Patch Set 1: Code-Review-1',459,1,459,'dad5f5cf_9176bc05',NULL),(41,'2015-04-27 12:36:17','Uploaded patch set 1.',459,1,459,'dad5f5cf_b1c42060',NULL),(15,'2015-04-27 14:14:46','Patch Set 1:\n\n(4 comments)\n\nThanks for working on this. Some comments before we merge this',459,1,459,'dad5f5cf_b1d740ed',NULL),(8,'2015-04-27 14:50:06','Patch Set 1: Code-Review+2',460,1,460,'dad5f5cf_110c0c94',NULL),(8,'2015-04-27 14:50:08','Patch Set 2: Patch Set 1 was rebased',460,1,460,'dad5f5cf_311110ad',NULL),(16,'2015-04-27 14:21:26','Patch Set 1: Code-Review+1\n\nOops, sorry for breaking this. Thanks for fixing it!',460,1,460,'dad5f5cf_5104d47d',NULL),(6,'2015-04-27 13:09:53','Uploaded patch set 1.',460,1,460,'dad5f5cf_b19bc071',NULL),(8,'2015-04-27 14:50:09','Change has been successfully rebased as b0301d608ff73e6bc70d4ca700846b778c5db374',460,1,460,'dad5f5cf_d125240b',NULL),(27,'2015-04-27 14:13:22','Patch Set 1: Code-Review+1\n\nsane and happy bug squishing!',460,1,460,'dad5f5cf_f1cdc85e',NULL),(15,'2015-04-29 15:23:01','Change has been successfully merged into the git repository.',461,2,461,'bada0100_5605a4c0',NULL),(35,'2015-04-29 13:23:12','Patch Set 1: Code-Review+1\n\ngood stuff!',461,1,461,'bada0100_762b0883',NULL),(15,'2015-04-29 15:22:55','Patch Set 2: Patch Set 1 was rebased',461,1,461,'bada0100_966b0c85',NULL),(15,'2015-04-29 15:22:59','Patch Set 2: Code-Review+2',461,2,461,'bada0100_b6689088',NULL),(15,'2015-04-29 15:22:15','Patch Set 1: Code-Review+2',461,1,461,'bada0100_f66e1896',NULL),(6,'2015-04-27 13:24:29','Patch Set 1: Code-Review+1\n\nNot tested, but looks OK',461,1,461,'dad5f5cf_11996c6e',NULL),(15,'2015-04-27 13:13:18','Uploaded patch set 1.',461,1,461,'dad5f5cf_51885422',NULL),(15,'2015-04-29 15:23:17','Patch Set 2: Patch Set 1 was rebased',462,1,462,'bada0100_160f1ce3',NULL),(35,'2015-04-29 13:15:17','Patch Set 1: Code-Review+1\n\nGreat stuff!',462,1,462,'bada0100_360ee035',NULL),(15,'2015-04-29 15:23:20','Patch Set 2: Code-Review+2',462,2,462,'bada0100_3614a0f4',NULL),(15,'2015-04-29 15:23:11','Patch Set 1: Code-Review+2',462,1,462,'bada0100_760a28d4',NULL),(15,'2015-04-29 15:23:22','Change has been successfully merged into the git repository.',462,2,462,'bada0100_d6f8b4c6',NULL),(15,'2015-04-29 10:01:52','Patch Set 1:\n\nFYI, I\'ve built as well a weston-system-armv7lhf-jetson system in a jetson board without any issue',462,1,462,'bada0100_f33b8a36',NULL),(15,'2015-04-27 13:14:39','Patch Set 1:\n\nIve built a base base-system-x86_64-generic and a weston-system-x86_64-generic with this',462,1,462,'dad5f5cf_1182cc00',NULL),(6,'2015-04-27 13:25:30','Patch Set 1: Code-Review+1\n\nVery impressive! I\'m not at all confident that this won\'t break things with obscure bugs, but as we just did a (rc) release, I think it\'s a good time to test it out.',462,1,462,'dad5f5cf_319ef057',NULL),(15,'2015-04-27 13:13:18','Uploaded patch set 1.',462,1,462,'dad5f5cf_718d5831',NULL),(6,'2015-04-28 15:53:08','Patch Set 3: Patch Set 2 was rebased',463,2,463,'bada0100_50604c35',NULL),(6,'2015-04-28 07:34:36','Patch Set 1: Code-Review+1\n\nLooks fine to me',463,1,463,'bada0100_50ffec01',NULL),(6,'2015-04-28 15:53:09','Change has been successfully rebased as 87f8dbefda89bf6cb9e4b88f23a5317b054da0d4',463,2,463,'bada0100_70655044',NULL),(16,'2015-04-28 15:30:45','Uploaded patch set 2.',463,2,463,'bada0100_b045f8b4',NULL),(6,'2015-04-28 15:52:57','Patch Set 2: Code-Review+2',463,2,463,'bada0100_b073b814',NULL),(8,'2015-04-28 15:33:17','Patch Set 2: Code-Review+1',463,2,463,'bada0100_d0251c0b',NULL),(8,'2015-04-28 11:03:43','Patch Set 1: Code-Review+1',463,1,463,'bada0100_d0951c89',NULL),(16,'2015-04-27 16:04:15','Uploaded patch set 1.',463,1,463,'dad5f5cf_f1ace837',NULL),(16,'2015-04-28 15:32:25','Uploaded patch set 3.',464,3,464,'bada0100_100c0494',NULL),(16,'2015-04-28 08:49:24','Patch Set 1: Code-Review-2\n\nThis breaks ./check --full. I\'ll resubmit soon.',464,1,464,'bada0100_1020849a',NULL),(6,'2015-04-28 15:53:42','Patch Set 3: Code-Review+2',464,3,464,'bada0100_105ac483',NULL),(16,'2015-04-29 08:54:18','Patch Set 3:\n\n> Perhaps there\'s a newer licencecheck.pl upstream that handles\n > GLPv3.\n\nIts not just GPLv3 which comes out as GPL (vever). I see that in morph for example, which is GPLv2.',464,3,464,'bada0100_1335ee45',NULL),(16,'2015-04-29 10:52:25','Uploaded patch set 4.',464,4,464,'bada0100_1383aecd',NULL),(37,'2015-04-29 16:05:36','Patch Set 6: Code-Review+1',464,6,464,'bada0100_16ab9c8a',NULL),(27,'2015-04-29 15:47:42','Patch Set 6: Code-Review+1',464,6,464,'bada0100_16dddc42',NULL),(NULL,'2015-04-28 15:53:45','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I1c79ce68, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',464,3,464,'bada0100_305fc874',NULL),(31,'2015-04-28 15:41:59','Patch Set 3: Code-Review+1',464,3,464,'bada0100_308828e7',NULL),(6,'2015-04-28 07:35:22','Patch Set 1: Code-Review+1\n\nLooks fine',464,1,464,'bada0100_70047015',NULL),(16,'2015-04-28 15:30:54','Patch Set 2: -Code-Review',464,2,464,'bada0100_701790a4',NULL),(8,'2015-04-28 11:07:01','Patch Set 1:\n\n(1 comment)',464,1,464,'bada0100_908f9475',NULL),(16,'2015-04-28 12:05:24','Patch Set 1:\n\n(1 comment)',464,1,464,'bada0100_90bd5405',NULL),(6,'2015-04-29 11:23:38','Patch Set 4: Code-Review+1\n\nI have no clue about that regex but as long as it works and the fix is submitted upstream, fine by me :)',464,4,464,'bada0100_9376be05',NULL),(NULL,'2015-04-29 03:56:23','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I1c79ce68, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',464,3,464,'bada0100_93c31e38',NULL),(16,'2015-04-29 15:26:04','Uploaded patch set 6.',464,6,464,'bada0100_96022cb3',NULL),(16,'2015-04-29 16:21:22','Change has been successfully rebased as 442e62c63a55a3dcb87b62da818c60e4149f399b',464,6,464,'bada0100_96f1cc97',NULL),(8,'2015-04-29 13:17:00','Patch Set 5: Code-Review-1\n\n(1 comment)',464,5,464,'bada0100_b619707b',NULL),(31,'2015-04-29 08:23:24','Patch Set 3:\n\nPerhaps there\'s a newer licencecheck.pl upstream that handles GLPv3.',464,3,464,'bada0100_d3f7668b',NULL),(31,'2015-04-29 15:56:46','Patch Set 6: Code-Review+1',464,6,464,'bada0100_d6e67416',NULL),(16,'2015-04-29 16:21:19','Patch Set 6: Code-Review+2',464,6,464,'bada0100_d6f7548b',NULL),(8,'2015-04-28 15:34:59','Patch Set 3: Code-Review+1',464,3,464,'bada0100_f022a000',NULL),(16,'2015-04-28 15:30:45','Uploaded patch set 2.',464,2,464,'bada0100_f03b8036',NULL),(37,'2015-04-29 13:11:08','Patch Set 5: Code-Review+1',464,5,464,'bada0100_f3214ab5',NULL),(16,'2015-04-29 12:47:03','Uploaded patch set 5.',464,5,464,'bada0100_f3738ae5',NULL),(16,'2015-04-29 16:21:22','Patch Set 7: Patch Set 6 was rebased',464,6,464,'bada0100_f6f4d888',NULL),(31,'2015-04-27 16:18:58','Patch Set 1: Code-Review+1',464,1,464,'dad5f5cf_514a9484',NULL),(16,'2015-04-27 16:04:15','Uploaded patch set 1.',464,1,464,'dad5f5cf_91a9dc26',NULL),(37,'2015-04-29 13:14:45','Patch Set 5:\n\n(9 comments)\n\nBah, making comments on v4 then v5 coming in before submission, so I submitted a comment on v5 without any patch comments made me sound so rude.',465,5,465,'bada0100_16095c2c',NULL),(16,'2015-04-28 15:32:25','Uploaded patch set 3.',465,3,465,'bada0100_301108ad',NULL),(37,'2015-04-29 13:08:43','Patch Set 5: Code-Review-1\n\nA deeper review of the code flow will follow.',465,5,465,'bada0100_33403256',NULL),(16,'2015-04-29 10:52:25','Uploaded patch set 4.',465,4,465,'bada0100_338832e7',NULL),(16,'2015-04-29 16:20:29','Uploaded patch set 7.',465,7,465,'bada0100_36034075',NULL),(31,'2015-04-28 15:37:25','Patch Set 3: Code-Review+1\n\n(2 comments)',465,3,465,'bada0100_50792cfb',NULL),(6,'2015-04-28 11:48:25','Patch Set 1:\n\nI ran:\n\n morph system-manifest baserock:baserock/definitions master systems/minimal-system-x86_64-generic.morph\n\nand got this:\n\n 2015-04-28 11:45:41 Updating cached git repository baserock:baserock/definitions for ref master\n 2015-04-28 11:45:43 Creating /src/ws/master/systems/minimal-system-x86_64-generic.morph-manifest.csv\n ERROR: [Errno 2] No such file or directory: \'/src/ws/master/systems/minimal-system-x86_64-generic.morph-manifest.csv\'\n\nIt seems to be assuming the presence of a \'systems\' directory, maybe assuming that it\'s being run from the top of a checkout of definitions.git?',465,1,465,'bada0100_50d04c53',NULL),(37,'2015-04-29 16:04:34','Patch Set 6: Code-Review+1\n\n(2 comments)\n\nLooks acceptable in its current state, though you may decide to heed my suggestions.',465,6,465,'bada0100_56a124a8',NULL),(31,'2015-04-28 08:48:05','Patch Set 1: Code-Review+1',465,1,465,'bada0100_702b1083',NULL),(6,'2015-04-28 11:51:07','Patch Set 1:\n\nHaving created that directory, I got this:\n\n 2015-04-28 11:48:47 Updating cached git repository baserock:baserock/definitions for ref master\n 2015-04-28 11:48:48 Creating /src/ws/master/systems/minimal-system-x86_64-generic.morph-manifest.csv\n Traceback (most recent call last):\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 190, in _run\n self.process_args(args)\n File \"/src/morph/morphlib/app.py\", line 284, in process_args\n cliapp.Application.process_args(self, args)\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 539, in process_args\n method(args[1:])\n File \"/src/morph/morphlib/plugins/system_manifests_plugin.py\", line 71, in manifests\n self.system_manifest(repo, ref, system_filename)\n File \"/src/morph/morphlib/plugins/system_manifests_plugin.py\", line 131, in system_manifest\n self.app.settings[\'trove-id\'][0], resolver)\n IndexError: list index out of range\n\nI don\'t have \'trove-id\' specified in my morph.conf, maybe that is causing it to break? If I pass --trove-id=baserock on the commandline it seems to work around the bug.',465,1,465,'bada0100_70d55042',NULL),(16,'2015-04-30 10:54:11','Uploaded patch set 8.',465,8,465,'bada0100_79877b62',NULL),(16,'2015-04-28 15:30:45','Uploaded patch set 2.',465,2,465,'bada0100_9048f4cd',NULL),(6,'2015-04-28 15:52:23','Patch Set 3: Code-Review-1\n\n(1 comment)\n\nThis looks fine, I got a good CSV manifest out of V1 eventually. I believe there is still a bug where GPLv3 is reported as \'GPL (vever)\' so we should wait til Adam fixes that for merging.',465,3,465,'bada0100_9076b405',NULL),(16,'2015-04-29 12:47:03','Uploaded patch set 5.',465,5,465,'bada0100_9380fe8c',NULL),(37,'2015-04-29 13:34:35','Patch Set 5:\n\n(6 comments)\n\nI can\'t find anything fundamentally wrong with your approach given the current constraints.\n\nIdeally you would ask lorry controller, but this can\'t be 100% reliable in our current model anyway, since when lorrying from another trove, there\'s no requirement that your lorry files be sent.\n\nI\'d merge this after a few fixups.',465,5,465,'bada0100_964a2c54',NULL),(16,'2015-04-29 14:44:56','Patch Set 5:\n\n(1 comment)',465,5,465,'bada0100_96bd4c05',NULL),(37,'2015-04-30 13:11:51','Patch Set 9: Patch Set 8 was rebased',465,8,465,'bada0100_9919ff24',NULL),(6,'2015-04-29 11:24:01','Patch Set 4: Code-Review+2',465,4,465,'bada0100_b373c214',NULL),(6,'2015-04-29 06:50:26','Patch Set 3: Code-Review+1\n\n> > (1 comment)\n > >\n > > This looks fine, I got a good CSV manifest out of V1 eventually.\n > I\n > > believe there is still a bug where GPLv3 is reported as \'GPL\n > > (vever)\' so we should wait til Adam fixes that for merging.\n > \n > That comes from the licensecheck.pl script. I don\'t know how that\n > script guesses the license, and don\'t know any Perl to have an idea\n > of how to fix it. If its definitely always GPLv3 which comes out as\n > that then I can replace it in the output I guess.\n\nSorry, I must have misinterpreted something you said in IRC:\n\n it seems that something is trying to say \'v2\' or \'v3\' or something but is coming up with \'vever\' instead\n ssssam: that text comes from licencecheck.pl\n its actually a v3 because I forgot to delete the comma franred pointed out\n\nif it\'s a bug/weird thing in licensecheck.pl rather than the Python code then I suggest we merge this patch, and investigate what \'vever\' means seperately.',465,3,465,'bada0100_b3c0a22b',NULL),(16,'2015-04-29 07:37:33','Patch Set 3:\n\n> > > (1 comment)\n > > >\n > > > This looks fine, I got a good CSV manifest out of V1\n > eventually.\n > > I\n > > > believe there is still a bug where GPLv3 is reported as \'GPL\n > > > (vever)\' so we should wait til Adam fixes that for merging.\n > >\n > > That comes from the licensecheck.pl script. I don\'t know how that\n > > script guesses the license, and don\'t know any Perl to have an\n > idea\n > > of how to fix it. If its definitely always GPLv3 which comes out\n > as\n > > that then I can replace it in the output I guess.\n > \n > Sorry, I must have misinterpreted something you said in IRC:\n > \n > it seems that something is trying to say \'v2\' or \'v3\' or\n > something but is coming up with \'vever\' instead\n > ssssam: that text comes from licencecheck.pl\n > its actually a v3 because I forgot to delete the comma\n > franred pointed out\n > \n > if it\'s a bug/weird thing in licensecheck.pl rather than the Python\n > code then I suggest we merge this patch, and investigate what\n > \'vever\' means seperately.\n\nAha! I meant this patch series was actually a v3 in case anyone accidentally fetched patch set 2 to test it.',465,3,465,'bada0100_b3d742ed',NULL),(37,'2015-04-29 16:27:16','Patch Set 7: Code-Review+2',465,7,465,'bada0100_b6ee50b3',NULL),(16,'2015-04-29 15:26:04','Uploaded patch set 6.',465,6,465,'bada0100_b6ff30aa',NULL),(37,'2015-04-30 13:11:52','Change has been successfully rebased as f964cf053db43e80262b8d06d29696c0da304c57',465,8,465,'bada0100_b91643f0',NULL),(16,'2015-04-28 12:47:41','Patch Set 1:\n\nThanks for the review! I\'ve fixed those two issues now, and improved the docstring. I\'ll resubmit this series in a moment.',465,1,465,'bada0100_d04afc26',NULL),(6,'2015-04-28 11:44:29','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThe code looks fine.\n\nI really dislike that we now have \'generate-manifest\' and \'system-manifest\' commands. I think it\'d be less confusing to name them \'generate-manifest-genivi\' and generate-manifest-csv\' or something like that.\n\nI\'m in the process of testing this.',465,1,465,'bada0100_d0dc3c77',NULL),(37,'2015-04-29 16:30:41','Patch Set 7: Code-Review+1\n\n(3 comments)',465,7,465,'bada0100_d63e7429',NULL),(16,'2015-04-28 18:22:58','Patch Set 3:\n\n> (1 comment)\n > \n > This looks fine, I got a good CSV manifest out of V1 eventually. I\n > believe there is still a bug where GPLv3 is reported as \'GPL\n > (vever)\' so we should wait til Adam fixes that for merging.\n\nThat comes from the licensecheck.pl script. I don\'t know how that script guesses the license, and don\'t know any Perl to have an idea of how to fix it. If its definitely always GPLv3 which comes out as that then I can replace it in the output I guess.',465,3,465,'bada0100_f33dcabc',NULL),(31,'2015-04-29 15:59:58','Patch Set 6: Code-Review+1',465,6,465,'bada0100_f6e37803',NULL),(37,'2015-04-30 13:11:34','Patch Set 8: Code-Review+2',465,8,465,'bada0100_f91ccb15',NULL),(31,'2015-04-30 11:10:32','Patch Set 8: Code-Review+1',465,8,465,'bada0100_f947eb1b',NULL),(16,'2015-04-27 16:04:15','Uploaded patch set 1.',465,1,465,'dad5f5cf_b1a66052',NULL),(35,'2015-04-27 16:06:35','Patch Set 1: Code-Review+1\n\nNeeded as it breaks the build',466,1,466,'dad5f5cf_116dec04',NULL),(6,'2015-04-27 16:07:35','Patch Set 1: Code-Review+2',466,1,466,'dad5f5cf_317270e6',NULL),(15,'2015-04-27 16:05:55','Uploaded patch set 1.',466,1,466,'dad5f5cf_7168f8f5',NULL),(6,'2015-04-27 16:07:39','Change has been successfully merged into the git repository.',466,1,466,'dad5f5cf_d17684d8',NULL),(7,'2015-04-28 14:21:49','Uploaded patch set 4.',468,4,468,'bada0100_10b084dc',NULL),(7,'2015-04-28 18:12:48','Change has been successfully rebased as 8ace3d897295e26d83c680db983093bd43a11b96',468,4,468,'bada0100_13208e9a',NULL),(8,'2015-04-28 15:24:01','Patch Set 4: Code-Review+1',468,4,468,'bada0100_502b6ceb',NULL),(7,'2015-04-28 14:10:02','Uploaded patch set 3.',468,3,468,'bada0100_50b60cde',NULL),(7,'2015-04-28 18:12:46','Patch Set 4: Code-Review+2\n\nRichard Maw said on IRC that he was happy with this change.',468,4,468,'bada0100_532616bc',NULL),(8,'2015-04-28 13:00:20','Patch Set 2: Code-Review+1',468,2,468,'bada0100_706310b2',NULL),(7,'2015-04-28 18:12:48','Patch Set 5: Patch Set 4 was rebased',468,4,468,'bada0100_732b1a83',NULL),(7,'2015-04-28 12:57:07','Uploaded patch set 2.',468,2,468,'bada0100_b05178da',NULL),(8,'2015-04-28 10:30:25','Patch Set 1: Code-Review+1\n\nAs Richard Maw suggested, I would prefer if we remove the symlink too.',468,1,468,'bada0100_d0ae7ce7',NULL),(37,'2015-04-28 13:22:34','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nIt can still fail to clean up resources in some circumstances, and forking off a subprocess to call symlink() is overkill, but I\'ll accept it in its current form if necessary.',468,2,468,'bada0100_f0caa06d',NULL),(7,'2015-04-27 16:58:27','Uploaded patch set 1.',468,1,468,'dad5f5cf_31403056',NULL),(37,'2015-04-27 17:02:24','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nI\'d prefer explicit cleanup logic for the symlink, but this looks ok, since AIUI the symlink is made in a tempdir that\'ll be thrown away soon.',468,1,468,'dad5f5cf_912ebca4',NULL),(8,'2015-04-28 10:49:21','Patch Set 1:\n\n(1 comment)',469,1,469,'bada0100_107c0472',NULL),(7,'2015-04-28 11:43:50','Patch Set 1:\n\n(2 comments)',469,1,469,'bada0100_10f3a40b',NULL),(7,'2015-04-28 14:21:49','Uploaded patch set 4.',469,4,469,'bada0100_30b588cd',NULL),(27,'2015-04-28 15:30:53','Patch Set 4: Code-Review+1',469,4,469,'bada0100_50128cb5',NULL),(7,'2015-04-28 12:57:07','Uploaded patch set 2.',469,2,469,'bada0100_505e0ceb',NULL),(7,'2015-04-28 18:15:00','Change has been successfully rebased as e441ea4d3956840b5181c104c785a4d44f4a3c2f',469,5,469,'bada0100_534db671',NULL),(7,'2015-04-28 14:10:02','Uploaded patch set 3.',469,3,469,'bada0100_70bb10c5',NULL),(7,'2015-04-28 13:04:12','Patch Set 2: Code-Review-1\n\n(1 comment)',469,2,469,'bada0100_906b1485',NULL),(37,'2015-04-28 13:26:00','Patch Set 2: Code-Review+1\n\nI\'ll accept it in its current form, it\'s up to Pedro whether he wants to tidy up the unnecessary interpolation values.',469,2,469,'bada0100_909eb462',NULL),(7,'2015-04-28 18:14:55','Patch Set 5: Code-Review+2',469,5,469,'bada0100_93331ef6',NULL),(8,'2015-04-28 15:23:28','Patch Set 4: Code-Review+1',469,4,469,'bada0100_b0ee58b3',NULL),(7,'2015-04-28 18:14:59','Patch Set 6: Patch Set 5 was rebased',469,5,469,'bada0100_b330a2e9',NULL),(8,'2015-04-28 13:02:12','Patch Set 2:\n\n(1 comment)',469,2,469,'bada0100_d0719c78',NULL),(27,'2015-04-28 13:08:53','Patch Set 2: Code-Review+1\n\neven with Fran\'s comment i see no reason to not +1 this. an un-needed change perhaps but i dont think it will break anything.',469,2,469,'bada0100_d0f8bcc6',NULL),(7,'2015-04-28 18:14:05','Uploaded patch set 5.',469,5,469,'bada0100_f3362ae7',NULL),(37,'2015-04-27 17:13:36','Patch Set 1:\n\n(2 comments)\n\nCheck the netmask, I don\'t think it\'s right.\n\nAlso, the device name unreliability is unfortunate, but sufficient for our purposes, as we\'re not going to be putting multiple USB ethernet devices in.',469,1,469,'dad5f5cf_1112cc62',NULL),(7,'2015-04-27 16:58:27','Uploaded patch set 1.',469,1,469,'dad5f5cf_d12444c8',NULL),(7,'2015-04-28 10:22:26','Patch Set 2: Code-Review+2\n\nOuch! Thanks for the reviews! Fixing and merging.',471,2,471,'bada0100_10a5e403',NULL),(7,'2015-04-28 10:22:29','Change has been successfully merged into the git repository.',471,2,471,'bada0100_30aa68d5',NULL),(7,'2015-04-28 10:21:57','Patch Set 2: Commit message was updated',471,2,471,'bada0100_70a0f0f4',NULL),(28,'2015-04-28 10:17:18','Patch Set 1: Code-Review+1\n\n+1 on the condition that you s/target-online/network-online/ in the commit message.',471,1,471,'bada0100_d0675ce9',NULL),(8,'2015-04-28 10:19:41','Patch Set 1: Code-Review+1\n\nSame condition as Tiago Gomes mention',471,1,471,'bada0100_f064e0e6',NULL),(7,'2015-04-27 17:10:34','Uploaded patch set 1.',471,1,471,'dad5f5cf_711d5873',NULL),(8,'2015-04-28 09:04:20','Patch Set 1: Code-Review+1',472,1,472,'bada0100_10572404',NULL),(15,'2015-04-28 14:35:04','Change has been successfully rebased as 2594f6d52878ef78d9809c52c7aebbe52434dba9',472,1,472,'bada0100_10e724e6',NULL),(15,'2015-04-28 14:35:02','Patch Set 1: Code-Review+2',472,1,472,'bada0100_50ddac13',NULL),(16,'2015-04-28 09:02:25','Patch Set 1: Code-Review+1\n\nGood spot! Looks like a sensible fix to me.',472,1,472,'bada0100_70523015',NULL),(15,'2015-04-28 14:35:04','Patch Set 2: Patch Set 1 was rebased',472,1,472,'bada0100_70e230d7',NULL),(6,'2015-04-28 08:56:05','Uploaded patch set 1.',472,1,472,'bada0100_903314f6',NULL),(8,'2015-04-28 10:45:10','Patch Set 1: Code-Review+1',473,1,473,'bada0100_50828c53',NULL),(15,'2015-04-28 10:43:39','Uploaded patch set 1.',473,1,473,'bada0100_90b8f42b',NULL),(15,'2015-04-28 11:46:33','Patch Set 1: Code-Review+2',473,1,473,'bada0100_90e6b443',NULL),(35,'2015-04-28 10:44:24','Patch Set 1: Code-Review+1\n\nGreat stuff',473,1,473,'bada0100_b0b5f832',NULL),(15,'2015-04-28 11:46:36','Change has been successfully merged into the git repository.',473,1,473,'bada0100_b0e3b832',NULL),(29,'2015-05-06 15:57:20','Change has been successfully merged into the git repository.',474,4,474,'bada0100_1f12cf62',NULL),(16,'2015-05-06 14:52:19','Patch Set 2: Code-Review+1',474,2,474,'bada0100_1f440f73',NULL),(29,'2015-05-06 15:53:17','Uploaded patch set 4.',474,4,474,'bada0100_5f185784',NULL),(29,'2015-05-06 15:37:08','Patch Set 3: Code-Review-1\n\nPlease don\'t merge this, the rebased version breaks the coverage tests because of the rename from _gitdir to gitdir, I should have run the tests before pushing this rebased set, sorry.',474,3,474,'bada0100_5f31370a',NULL),(29,'2015-05-05 14:40:55','Patch Set 1:\n\n(2 comments)',474,1,474,'bada0100_5fb617de',NULL),(6,'2015-05-06 08:34:08','Patch Set 2: Code-Review+1',474,2,474,'bada0100_7f175ba4',NULL),(29,'2015-05-06 15:57:10','Patch Set 4: Code-Review+2',474,4,474,'bada0100_7f1d1b73',NULL),(29,'2015-05-06 07:55:07','Patch Set 2: Code-Review+1',474,2,474,'bada0100_9f48ffcd',NULL),(NULL,'2015-05-06 15:26:12','The change could not be merged due to a path conflict.\n\nPlease rebase the change locally and upload the rebased commit for review.',474,2,474,'bada0100_9f579f26',NULL),(6,'2015-05-05 15:38:59','Patch Set 1:\n\n(1 comment)',474,1,474,'bada0100_9fda3f16',NULL),(15,'2015-04-28 13:04:31','Patch Set 1: Code-Review+1\n\nThis seems like generally useful, Maybe we want it to be always enabled?',474,1,474,'bada0100_b0689888',NULL),(6,'2015-04-28 14:33:19','Patch Set 1:\n\n> This seems like generally useful, Maybe we want it to be always\n > enabled?\n\nIf it was neatly done, yes, but the way it\'s implemented is a bit messy.\n\nExample output:\n\n 2015-04-28 14:14:36 [32/51][ccache] Inspecting chunk: ccache\n Connecting to git.baserock.org (185.43.218.183:80)\n - 100% |*******************************| 7194k 0:00:00 ETA\n remote: Counting objects: 14, done.\n remote: Compressing objects: 100% (12/12), done.\n remote: Total 14 (delta 4), reused 0 (delta 0)\n Unpacking objects: 100% (14/14), done.\n From git://git.baserock.org/delta/shadow\n * [new ref] refs/gitano/admin -> refs/gitano/admin\n * [new branch] baserock/4.2 -> baserock/4.2\n 2015-04-28 14:14:45 [33/51][shadow] Inspecting chunk: shadow\n Connecting to git.baserock.org (185.43.218.183:80)\n - 100% |*******************************| 8020k 0:00:00 ETA\n remote: Counting objects: 3858, done.\n remote: Compressing objects: 100% (1131/1131), done.\n remote: Total 3858 (delta 2655), reused 3858 (delta 2655)\n Receiving objects: 100% (3858/3858), 5.59 MiB | 1.38 MiB/s, done.\n Resolving deltas: 100% (2655/2655), completed with 191 local objects.\n From git://git.baserock.org/delta/texinfo-tarball\n * [new branch] baserock/tiagogomes/armv8l64 -> baserock/tiagogomes/armv8l64\n 2015-04-28 14:15:16 [34/51][texinfo-tarball] Inspecting chunk: texinfo-tarball\n Connecting to git.baserock.org (185.43.218.183:80)\n - 100% |*******************************| 1356k 0:00:00 ETA\n remote: Counting objects: 9200, done.\n remote: Compressing objects: 100% (3139/3139), done.\n remote: Total 9200 (delta 6077), reused 9136 (delta 6038)\n Receiving objects: 100% (9200/9200), 6.59 MiB | 1.27 MiB/s, done.\n Resolving deltas: 100% (6077/6077), completed with 8 local objects.\n From git://git.baserock.org/delta/patch\n * [new branch] baserock/bootstrap -> baserock/bootstrap\n * [new branch] baserock/bootstrap-pass1 -> baserock/bootstrap-pass1\n * [new branch] baserock/bootstrap-pass2 -> baserock/bootstrap-pass2\n * [new branch] baserock/build-essential -> baserock/build-essential\n * [new branch] baserock/morph -> baserock/morph\n * [new branch] baserock/samthursfield/build-essential -> baserock/samthursfield/build-essential\n * [new branch] baserock/v2.7.1 -> baserock/v2.7.1\n * [new branch] origin -> origin\n\nI think this output makes it hard to follow what\'s actually going on. Without\n--verbose the same command would output:\n\n 2015-04-28 14:14:36 [32/51][ccache] Inspecting chunk: ccache\n 2015-04-28 14:14:45 [33/51][shadow] Inspecting chunk: shadow\n 2015-04-28 14:15:16 [34/51][texinfo-tarball] Inspecting chunk: texinfo-tarball\n\nSo I think it\'s only really suitabe for --verbose right now. And it would be quite a bit of work to get a more neater form of progress output from \'git clone\' and \'git remote update\' I think.',474,1,474,'bada0100_b0c0982b',NULL),(29,'2015-05-06 15:30:54','Uploaded patch set 3.',474,3,474,'bada0100_bf54e321',NULL),(6,'2015-04-28 12:02:17','Uploaded patch set 1.',474,1,474,'bada0100_d0c3dc88',NULL),(29,'2015-05-06 07:52:29','Patch Set 1: Code-Review-1\n\n(2 comments)',474,1,474,'bada0100_df3e8729',NULL),(29,'2015-05-06 07:54:29','Uploaded patch set 2.',474,2,474,'bada0100_ff3b4b36',NULL),(29,'2015-05-06 15:26:10','Patch Set 2: Code-Review+2',474,2,474,'bada0100_ff5a6b4f',NULL),(8,'2015-04-28 13:04:52','Patch Set 1: Code-Review+1',475,1,475,'bada0100_5005acc0',NULL),(6,'2015-04-28 16:24:55','Patch Set 1: Code-Review+2',475,1,475,'bada0100_50636c1a',NULL),(6,'2015-04-28 16:24:59','Change has been successfully merged into the git repository.',475,1,475,'bada0100_7068f0f5',NULL),(15,'2015-04-28 12:21:09','Uploaded patch set 1.',475,1,475,'bada0100_b0bad808',NULL),(37,'2015-04-30 13:14:43','Patch Set 2: Code-Review+2',476,2,476,'bada0100_19dd0f43',NULL),(37,'2015-04-30 13:14:44','Patch Set 3: Patch Set 2 was rebased',476,2,476,'bada0100_39e25304',NULL),(37,'2015-04-30 13:14:33','Patch Set 2: Code-Review+1\n\n(1 comment)',476,2,476,'bada0100_79d8db53',NULL),(6,'2015-04-28 14:28:29','Patch Set 2: Code-Review+1\n\nLooks fine at a glance, i\'ve not tested yet',476,2,476,'bada0100_90c31438',NULL),(16,'2015-04-28 14:23:52','Uploaded patch set 1.',476,1,476,'bada0100_d0c99c5b',NULL),(37,'2015-04-30 13:14:45','Change has been successfully rebased as 74ac75d2e359bd1b8216e22cc2c22b650af8d48b',476,2,476,'bada0100_d9e6a716',NULL),(16,'2015-04-28 14:25:48','Patch Set 2: Commit message was updated',476,2,476,'bada0100_f0c62049',NULL),(8,'2015-04-28 18:20:06','Patch Set 1: Code-Review+2',477,1,477,'bada0100_13572e04',NULL),(8,'2015-04-28 18:20:08','Change has been successfully merged into the git repository.',477,1,477,'bada0100_335cb225',NULL),(27,'2015-04-28 14:42:54','Patch Set 1: Code-Review+1',477,1,477,'bada0100_90da3416',NULL),(6,'2015-04-28 16:24:33','Patch Set 1: Code-Review+1',477,1,477,'bada0100_b0a65852',NULL),(8,'2015-04-28 14:40:22','Uploaded patch set 1.',477,1,477,'bada0100_d0d0bcf9',NULL),(8,'2015-04-28 15:21:10','Patch Set 1: Code-Review+1\n\nThanks for including the changes between versions!!',479,1,479,'bada0100_90f1d497',NULL),(6,'2015-04-28 16:20:35','Patch Set 1: Code-Review+2',479,1,479,'bada0100_d0af5c2a',NULL),(6,'2015-04-28 16:20:40','Change has been successfully merged into the git repository.',479,1,479,'bada0100_f0ace037',NULL),(15,'2015-04-28 15:18:56','Uploaded patch set 1.',479,1,479,'bada0100_f0f4e088',NULL),(33,'2015-04-29 16:11:36','Patch Set 3: Patch Set 2 was rebased',480,2,480,'bada0100_16995c6e',NULL),(33,'2015-04-29 16:02:11','Patch Set 2: Code-Review+2',480,2,480,'bada0100_16b4fcf0',NULL),(33,'2015-04-28 16:20:19','Patch Set 1:\n\n> Seems an OK solution, it is definitely messy to print \'Started\n > building xx\' just before exiting.\n\nI don\'t like it much either, but it will do for now.',480,1,480,'bada0100_30bb4874',NULL),(33,'2015-04-29 16:11:38','Patch Set 3: Code-Review+2',480,3,480,'bada0100_369ee057',NULL),(6,'2015-04-28 16:19:30','Patch Set 1: Code-Review+1\n\nSeems an OK solution, it is definitely messy to print \'Started building xx\' just before exiting.',480,1,480,'bada0100_70c1d0e3',NULL),(33,'2015-04-28 17:27:49','Patch Set 2: Code-Review-2\n\nCommand output is sometimes delayed for several seconds,\nsuggest we solve this problem before merging these changes.',480,2,480,'bada0100_b02bb893',NULL),(29,'2015-04-28 15:24:01','Uploaded patch set 1.',480,1,480,'bada0100_d03e7c29',NULL),(33,'2015-04-28 16:33:07','Patch Set 2: Commit message was updated',480,2,480,'bada0100_d0767cd8',NULL),(33,'2015-04-29 16:11:39','Change has been successfully merged into the git repository.',480,3,480,'bada0100_d6a2f499',NULL),(15,'2015-04-29 08:09:11','Change has been successfully rebased as 7b23e26d1e2bb24ca72a186ed92c3369e05ab452',481,2,481,'bada0100_13fe4e6c',NULL),(15,'2015-04-28 17:05:22','Uploaded patch set 1.',481,1,481,'bada0100_3049088c',NULL),(6,'2015-04-29 08:40:04','Patch Set 3:\n\n> This comment may come a bit later, but shouldn\'t this file be\n > placed in /usr instead? systemd is moving towards having /usr to be\n > vendor operating system only, whilst /etc will be used for\n > configuration only (the contents of this directory could be erased\n > to do a factory reset) [1].\n > \n > /usr/lib is the recommended place to place this file [2]\n > \n > [1] http://0pointer.net/blog/projects/stateless.html\n > [2] http://www.freedesktop.org/software/systemd/man/os-release.html\n\nI agree, but for compatibility reasons Morph still generates /etc/os-release as well at the moment (if we stopped Morph generating /etc/os-release then old versions of definitions built with new versions of Morph would lose /etc/os-release completely). So it might be too complex to try to migrate /etc/os-release into /usr/lib/ now.',481,3,481,'bada0100_532b76eb',NULL),(15,'2015-04-29 17:20:28','Patch Set 3:\n\n> > This comment may come a bit later, but shouldn\'t this file be\n > > placed in /usr instead? systemd is moving towards having /usr to\n > be\n > > vendor operating system only, whilst /etc will be used for\n > > configuration only (the contents of this directory could be\n > erased\n > > to do a factory reset) [1].\n > >\n > > /usr/lib is the recommended place to place this file [2]\n > >\n > > [1] http://0pointer.net/blog/projects/stateless.html\n > > [2] http://www.freedesktop.org/software/systemd/man/os-release.html\n > \n > I agree, but for compatibility reasons Morph still generates\n > /etc/os-release as well at the moment (if we stopped Morph\n > generating /etc/os-release then old versions of definitions built\n > with new versions of Morph would lose /etc/os-release completely).\n > So it might be too complex to try to migrate /etc/os-release into\n > /usr/lib/ now.\n\nThanks for pointing this out\n\nI will try to make a patch to fix it and also create a symlink from /etc/os-release -> /usr/lib/os-release to keep compatibility',481,3,481,'bada0100_56604435',NULL),(15,'2015-04-29 08:09:10','Patch Set 3: Patch Set 2 was rebased',481,2,481,'bada0100_7309da94',NULL),(6,'2015-04-29 06:56:12','Patch Set 2: Code-Review+2',481,2,481,'bada0100_73e23ad7',NULL),(28,'2015-04-29 08:28:43','Patch Set 3:\n\nThis comment may come a bit later, but shouldn\'t this file be placed in /usr instead? systemd is moving towards having /usr to be vendor operating system only, whilst /etc will be used for configuration only (the contents of this directory could be erased to do a factory reset) [1].\n\n/usr/lib is the recommended place to place this file [2]\n\n[1] http://0pointer.net/blog/projects/stateless.html\n[2] http://www.freedesktop.org/software/systemd/man/os-release.html',481,3,481,'bada0100_b3ee62b3',NULL),(15,'2015-04-28 17:06:15','Uploaded patch set 2.',481,2,481,'bada0100_d05d1c4a',NULL),(8,'2015-04-28 18:08:08','Patch Set 2: Code-Review+1',481,2,481,'bada0100_d3120658',NULL),(8,'2015-04-28 18:02:09','Patch Set 1: Code-Review+1',482,1,482,'bada0100_13096e2c',NULL),(6,'2015-04-29 07:01:19','Patch Set 1: Code-Review+2',482,1,482,'bada0100_33ecb2c7',NULL),(7,'2015-04-28 17:19:30','Uploaded patch set 1.',482,1,482,'bada0100_50312c0a',NULL),(6,'2015-04-29 07:01:31','Patch Set 1:\n\nNice. And deployed on gerrit.baserock.org already I see :)',482,1,482,'bada0100_d3d0c6f9',NULL),(6,'2015-04-29 07:01:45','Change has been successfully merged into the git repository.',482,1,482,'bada0100_f3cdca5e',NULL),(8,'2015-04-28 18:44:40','Uploaded patch set 1.',483,1,483,'bada0100_136e4eca',NULL),(15,'2015-04-28 22:32:39','Patch Set 1: Code-Review+2',483,1,483,'bada0100_335d92ea',NULL),(15,'2015-04-28 22:32:43','Change has been successfully merged into the git repository.',483,1,483,'bada0100_d371a678',NULL),(8,'2015-05-15 10:23:19','Abandoned\n\nGit 2.4.0 is out',484,1,484,'bada0100_1a6f3a94',NULL),(8,'2015-04-29 10:20:46','Patch Set 1:\n\n> Until and unless I see a statement to the tune of \"I have built a\n > trove with this and verified that old git works against new trove,\n > new git works against old trove, and new git works against new\n > trove\" my -1 will remain.\n\nWhat does do a trove more than lorry files from the repos?\nI though that passing the lorry tests and build a system with the new\ngit version on it would be enough.\nThere are any way to test that trove works without have to build and set a trove? like some trove testing?\nIf not this is a very hard way to test...I\'ve spent half of the day just to build 2 systems, pass the tests for morph and lorry and check that the new built systems worked. If we have to set a trove it will cost more than one day test just for updating a repository...not worth it, IMHO.',484,1,484,'bada0100_331112ad',NULL),(32,'2015-04-29 10:14:27','Patch Set 1: Code-Review-1\n\nUntil and unless I see a statement to the tune of \"I have built a trove with this and verified that old git works against new trove, new git works against old trove, and new git works against new trove\" my -1 will remain.',484,1,484,'bada0100_73179aa4',NULL),(15,'2015-04-29 10:06:21','Patch Set 1: Code-Review+1',484,1,484,'bada0100_9348fecd',NULL),(32,'2015-04-29 10:23:17','Patch Set 1:\n\n> > Until and unless I see a statement to the tune of \"I have built a\n > > trove with this and verified that old git works against new\n > trove,\n > > new git works against old trove, and new git works against new\n > > trove\" my -1 will remain.\n > \n > What does do a trove more than lorry files from the repos?\n > I though that passing the lorry tests and build a system with the\n > new\n > git version on it would be enough.\n > There are any way to test that trove works without have to build\n > and set a trove? like some trove testing?\n > If not this is a very hard way to test...I\'ve spent half of the day\n > just to build 2 systems, pass the tests for morph and lorry and\n > check that the new built systems worked. If we have to set a trove\n > it will cost more than one day test just for updating a\n > repository...not worth it, IMHO.\n\nErm, trove has a git server on it -- which interfaces with git on various levels. Previous updates to git have caused the git server to need tweaks.',484,1,484,'bada0100_d325260b',NULL),(27,'2015-04-29 09:54:40','Patch Set 1: Code-Review+1',484,1,484,'bada0100_d33e8629',NULL),(8,'2015-04-29 10:34:46','Patch Set 1: Code-Review-2\n\nHold this until I test trove working',484,1,484,'bada0100_f322aa00',NULL),(8,'2015-04-28 18:55:35','Uploaded patch set 1.',484,1,484,'bada0100_f364eae6',NULL),(8,'2015-04-29 08:23:41','Patch Set 1:\n\nAlso build a devel system with a devel system which contains the 2.3.7 version.',484,1,484,'bada0100_f3f4ea88',NULL),(15,'2015-04-29 15:37:26','Patch Set 2: Patch Set 1 was rebased',485,1,485,'bada0100_16263c69',NULL),(15,'2015-04-29 15:37:26','Change has been successfully rebased as e6befc339259a9d45295ae25e575a847033ac420',485,1,485,'bada0100_362b4032',NULL),(15,'2015-04-29 08:07:43','Uploaded patch set 1.',485,1,485,'bada0100_5304d67d',NULL),(35,'2015-04-29 15:31:36','Patch Set 1: Code-Review+1',485,1,485,'bada0100_562cc44a',NULL),(15,'2015-04-29 15:37:23','Patch Set 1: Code-Review+2',485,1,485,'bada0100_7631c8a1',NULL),(8,'2015-04-29 08:25:48','Patch Set 1: Code-Review+1',485,1,485,'bada0100_93f1de97',NULL),(16,'2015-04-30 07:30:17','Patch Set 1: Code-Review+1',486,1,486,'bada0100_36ed808c',NULL),(37,'2015-04-30 09:11:20','Patch Set 2: Patch Set 1 was rebased',486,1,486,'bada0100_5663641a',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',486,1,486,'bada0100_73655a44',NULL),(37,'2015-04-30 09:11:20','Change has been successfully rebased as 7bf8fdaabe19d39f6f6face9f21b51ca24614bbc',486,1,486,'bada0100_7668e8f5',NULL),(29,'2015-04-30 08:52:32','Patch Set 1: Code-Review+2',486,1,486,'bada0100_76c1c8e3',NULL),(27,'2015-04-29 13:56:41','Patch Set 1: Code-Review+1\n\nmore information telling me why what I did is not working is always a good thing!',486,1,486,'bada0100_d6951489',NULL),(8,'2015-04-29 16:39:01','Patch Set 1: Code-Review+1',486,1,486,'bada0100_f63b7836',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',487,1,487,'bada0100_135ace83',NULL),(37,'2015-04-29 12:12:20','Patch Set 1: Code-Review-2\n\nI haven\'t run these through the full test suite.',487,1,487,'bada0100_13e88e7b',NULL),(NULL,'2015-04-30 09:12:06','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I04868730, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',487,2,487,'bada0100_166ddc04',NULL),(37,'2015-04-29 13:52:10','Patch Set 2: -Code-Review\n\nYep, definitely needed me to go through and fix the tests.',487,2,487,'bada0100_167cfc71',NULL),(29,'2015-04-30 08:58:05','Patch Set 2: Code-Review+2',487,2,487,'bada0100_16b63c8b',NULL),(27,'2015-04-29 14:33:35','Patch Set 2: Code-Review+1\n\nSeems fully logical to me',487,2,487,'bada0100_16cabca1',NULL),(37,'2015-04-30 09:13:50','Patch Set 3: Patch Set 2 was rebased',487,2,487,'bada0100_367260e6',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 2.',487,2,487,'bada0100_569b64c9',NULL),(37,'2015-04-30 09:15:19','Patch Set 3: Code-Review+2',487,3,487,'bada0100_d67674d8',NULL),(37,'2015-04-30 09:15:22','Change has been successfully merged into the git repository.',487,3,487,'bada0100_f67378e5',NULL),(37,'2015-04-30 09:19:26','Patch Set 3: Patch Set 2 was rebased',488,2,488,'bada0100_1644fc72',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',488,1,488,'bada0100_335fd274',NULL),(37,'2015-04-30 09:19:45','Patch Set 3: Code-Review+2\n\nHad to rebase, patch is identical so +2ing to merge.',488,3,488,'bada0100_3649008c',NULL),(27,'2015-04-29 13:54:31','Patch Set 2: Code-Review+1\n\nI like knowing why things broke.',488,2,488,'bada0100_3681004b',NULL),(29,'2015-04-30 09:01:49','Patch Set 2: Code-Review+2',488,2,488,'bada0100_36bb4074',NULL),(NULL,'2015-04-30 09:19:22','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ib32d27dd, however the current patch set is 3.\n* Depends on commit a2c3090a66f671c9be25bf9c022dc088a33dda5f which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',488,2,488,'bada0100_764f8893',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 2.',488,2,488,'bada0100_76a0e8f4',NULL),(37,'2015-04-30 09:19:07','Patch Set 2:\n\nremote and push_url were in that state before this patch, so while it may be worth considering as a change, it is irrelevant for this patch.\n\nAlso, the remote could be a name rather than a url, so it\'s important to have both.',488,2,488,'bada0100_b67df0b3',NULL),(16,'2015-04-30 07:31:55','Patch Set 2: Code-Review+1',488,2,488,'bada0100_d601943a',NULL),(37,'2015-04-30 09:19:48','Change has been successfully merged into the git repository.',488,3,488,'bada0100_d65d144a',NULL),(6,'2015-04-30 09:03:54','Patch Set 2: Code-Review+1\n\nThis error could be a bit less confusing (\'remote\' kind of overlaps with \'push_url\'), but I prefer too much info to too little in error messages.',488,2,488,'bada0100_f6acd837',NULL),(29,'2015-04-30 09:46:17','Patch Set 2: Code-Review+2',489,2,489,'bada0100_1612bc62',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 2.',489,2,489,'bada0100_16a5dc03',NULL),(NULL,'2015-04-30 09:46:32','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ife3a809c, however the current patch set is 3.\n* Depends on commit a03e45d08a97f4cc0b623bf0c84dc97e6a7e8d8c which has no change associated with it.\n* Depends on commit a2c3090a66f671c9be25bf9c022dc088a33dda5f which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',489,2,489,'bada0100_3617c053',NULL),(29,'2015-04-30 09:42:15','Patch Set 2: Code-Review+2',489,2,489,'bada0100_56184484',NULL),(29,'2015-04-30 09:42:40','Patch Set 2: -Code-Review',489,2,489,'bada0100_761d4873',NULL),(29,'2015-04-30 09:46:46','Change has been successfully merged into the git repository.',489,3,489,'bada0100_96054c16',NULL),(8,'2015-04-30 09:05:10','Patch Set 2: Code-Review+1',489,2,489,'bada0100_96a9cc26',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',489,1,489,'bada0100_d353e66a',NULL),(29,'2015-04-30 09:46:38','Patch Set 3: Patch Set 2 was rebased',489,2,489,'bada0100_d60bd429',NULL),(29,'2015-04-30 09:46:40','Patch Set 3: Code-Review+2',489,3,489,'bada0100_f608582f',NULL),(16,'2015-04-30 07:33:38','Patch Set 2: Code-Review+1',489,2,489,'bada0100_f6fe1838',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 3.',490,3,490,'bada0100_190f4fe3',NULL),(16,'2015-04-30 18:39:59','Patch Set 4: Code-Review+1',490,4,490,'bada0100_2441ca0b',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 4.',490,4,490,'bada0100_24ca2aa2',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 2.',490,2,490,'bada0100_36aa60d5',NULL),(29,'2015-05-01 09:58:41','Change has been successfully merged into the git repository.',490,4,490,'bada0100_44b08ef4',NULL),(8,'2015-04-30 09:19:18','Patch Set 2: Code-Review+1',490,2,490,'bada0100_564a8484',NULL),(16,'2015-04-30 12:34:09','Patch Set 3: Code-Review+1',490,3,490,'bada0100_592cf74a',NULL),(27,'2015-04-29 13:49:17','Patch Set 2: Code-Review+1',490,2,490,'bada0100_76878862',NULL),(29,'2015-05-01 09:58:10','Patch Set 4: Code-Review+2',490,4,490,'bada0100_84a676c0',NULL),(16,'2015-04-30 07:34:21','Patch Set 2: Code-Review+1',490,2,490,'bada0100_96fb0c47',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',490,1,490,'bada0100_f3506a60',NULL),(37,'2015-04-29 11:38:13','Patch Set 1:\n\nThis doesn\'t alter the morphology files to include the new anchors, as this is not actually necessary to be able to reproducibly build the system, as we don\'t need to be able to follow a ref to find the sha1 we need to build from.',491,1,491,'bada0100_13d16ecd',NULL),(27,'2015-04-29 12:23:03','Patch Set 1: Code-Review+1',491,1,491,'bada0100_33a4b256',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 5.',491,5,491,'bada0100_391493f4',NULL),(37,'2015-05-01 11:13:51','Patch Set 7:\n\n(1 comment)',491,7,491,'bada0100_4403ae73',NULL),(29,'2015-05-01 07:43:27','Patch Set 7: -Code-Review',491,7,491,'bada0100_44140ef5',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 7.',491,7,491,'bada0100_44cf2eb1',NULL),(37,'2015-04-29 11:32:21','Patch Set 1:\n\nI suspect there may be bugs if the branches already exist when pushing anchors, or if a push fails, in the cleanup when the anchors already existed.',491,1,491,'bada0100_53c7f612',NULL),(37,'2015-04-30 11:50:34','Patch Set 4:\n\n(2 comments)\n\nThanks for the review Richard. Any comments on the documentation or command-line interface while I look at caching the repository?',491,4,491,'bada0100_595e37eb',NULL),(7,'2015-05-01 15:49:40','Change has been successfully merged into the git repository.',491,8,491,'bada0100_5f37f7b0',NULL),(29,'2015-05-01 09:51:35','Patch Set 7:\n\n(1 comment)',491,7,491,'bada0100_64a112a9',NULL),(37,'2015-04-29 12:07:45','Patch Set 1:\n\nI\'d appreciate feedback on the name and the command-line.\nI called it `morph anchor` because that\'s the intention, but `morph push-anchor` may be more appropriate as a future `morph remove-anchor` command may be added to make removal of anchors easier.',491,1,491,'bada0100_73f31a74',NULL),(37,'2015-04-29 16:53:32','Uploaded patch set 4.',491,4,491,'bada0100_767ea8e6',NULL),(29,'2015-04-30 10:38:46','Patch Set 4: Code-Review-2\n\n(2 comments)',491,4,491,'bada0100_79a0dbf4',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',491,1,491,'bada0100_934d5ec7',NULL),(29,'2015-05-01 14:09:03','Patch Set 8: Code-Review+1',491,8,491,'bada0100_a4805a8c',NULL),(29,'2015-05-01 09:42:43','Patch Set 7: Code-Review+1\n\n(2 comments)',491,7,491,'bada0100_a4c7fa63',NULL),(29,'2015-05-01 12:31:24','Patch Set 7:\n\n(1 comment)',491,7,491,'bada0100_a4e4daac',NULL),(37,'2015-04-30 12:19:39','Patch Set 4:\n\n(1 comment)',491,4,491,'bada0100_b9688388',NULL),(37,'2015-05-01 14:10:43','Patch Set 8: Code-Review+2',491,8,491,'bada0100_c47d5eb3',NULL),(37,'2015-05-01 14:01:11','Uploaded patch set 8.',491,8,491,'bada0100_c4a6be53',NULL),(37,'2015-04-29 16:52:09','Uploaded patch set 3.',491,3,491,'bada0100_d625140b',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 2.',491,2,491,'bada0100_d6ae74e7',NULL),(37,'2015-04-30 17:59:30','Uploaded patch set 6.',491,6,491,'bada0100_e4dc2277',NULL),(27,'2015-04-30 09:28:14','Patch Set 4: Code-Review+1',491,4,491,'bada0100_f65a984f',NULL),(27,'2015-04-29 14:05:27','Patch Set 2: Code-Review+1\n\ngerrit overwrote my +1 and requested i re-evaluate a patch with no alterations...',491,2,491,'bada0100_f692989e',NULL),(NULL,'2015-05-01 14:27:28','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* If9d92d7c75b9c4276b69c482c076c6fc1d4ccbbf\n',492,12,492,'bada0100_045b6655',NULL),(29,'2015-05-01 14:08:17','Patch Set 12: Code-Review+1\n\n(1 comment)',492,12,492,'bada0100_0474c6cd',NULL),(37,'2015-04-30 17:59:30','Uploaded patch set 10.',492,10,492,'bada0100_04da8678',NULL),(37,'2015-04-29 17:20:52','Uploaded patch set 8.',492,8,492,'bada0100_165abc83',NULL),(37,'2015-04-29 16:53:32','Uploaded patch set 6.',492,6,492,'bada0100_16839ccd',NULL),(37,'2015-04-29 13:48:03','Uploaded patch set 3.',492,3,492,'bada0100_56828453',NULL),(37,'2015-05-01 14:11:08','Patch Set 12: Code-Review+2',492,12,492,'bada0100_644a7285',NULL),(37,'2015-05-01 14:01:11','Uploaded patch set 12.',492,12,492,'bada0100_6463521b',NULL),(37,'2015-04-29 11:33:36','Patch Set 1:\n\nThis likely also needs tests for pushing anchors when they already exist on the server, and correct cleanup of only branches that were pushed in the case of error.',492,1,492,'bada0100_73cc7a36',NULL),(37,'2015-04-29 11:30:04','Uploaded patch set 1.',492,1,492,'bada0100_b34ae2aa',NULL),(37,'2015-05-01 15:49:40','Change has been successfully merged into the git repository.',492,12,492,'bada0100_bfbaa308',NULL),(37,'2015-04-29 16:55:11','Uploaded patch set 7.',492,7,492,'bada0100_d66c3439',NULL),(37,'2015-04-29 16:09:49','Uploaded patch set 4.',492,4,492,'bada0100_d6943446',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 9.',492,9,492,'bada0100_d9f8e7c6',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 11.',492,11,492,'bada0100_e4c3c288',NULL),(37,'2015-04-29 16:52:09','Uploaded patch set 5.',492,5,492,'bada0100_f6229800',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 2.',492,2,492,'bada0100_f6ab78d4',NULL),(27,'2015-04-29 15:24:56','Patch Set 3: Code-Review+1',492,3,492,'bada0100_f6f5b8cb',NULL),(15,'2015-04-30 10:20:26','Patch Set 2: Patch Set 1 was rebased',493,1,493,'bada0100_19574f04',NULL),(16,'2015-04-29 12:17:54','Patch Set 1: Code-Review+1',493,1,493,'bada0100_33ed928c',NULL),(15,'2015-04-30 10:20:27','Change has been successfully rebased as 34870acb27329bb7e3766acb1c6b0b569764becb',493,1,493,'bada0100_395c9325',NULL),(6,'2015-04-29 12:00:47','Uploaded patch set 1.',493,1,493,'bada0100_53ee168d',NULL),(15,'2015-04-30 10:20:22','Patch Set 1: Code-Review+2',493,1,493,'bada0100_594dd771',NULL),(35,'2015-04-29 15:05:53','Patch Set 2: Code-Review+1\n\n> (1 comment)\n\nNice but... not essential?',494,2,494,'bada0100_365d80ea',NULL),(15,'2015-04-29 13:39:17','Patch Set 1: Code-Review-1\n\n(1 comment)',494,1,494,'bada0100_5674c49b',NULL),(15,'2015-04-30 11:06:25','Change has been successfully rebased as f8f9da28f93aa0ce767fad3b118085a66a396cb3',494,2,494,'bada0100_59e95719',NULL),(35,'2015-04-29 14:09:09','Uploaded patch set 2.',494,2,494,'bada0100_76eea824',NULL),(15,'2015-04-30 11:06:22','Patch Set 2: Code-Review+2',494,2,494,'bada0100_998fbf75',NULL),(15,'2015-04-29 14:22:35','Patch Set 2: Code-Review+1\n\nThanks for rework the patch',494,2,494,'bada0100_b6e3b032',NULL),(15,'2015-04-30 11:06:24','Patch Set 3: Patch Set 2 was rebased',494,2,494,'bada0100_b98c0381',NULL),(35,'2015-04-29 12:20:16','Uploaded patch set 1.',494,1,494,'bada0100_d301a63a',NULL),(35,'2015-04-29 15:37:27','Patch Set 2: -Code-Review\n\nI didn\'t mean to +1 my own patch btw...',494,2,494,'bada0100_d61f5408',NULL),(8,'2015-04-29 15:12:45','Patch Set 2: Code-Review+1\n\nIm not going to ban the patch for this, but we should aim to do clean patches and as most readables as we can, avoiding to leave mess around ;-)',494,2,494,'bada0100_d6719478',NULL),(8,'2015-04-29 14:34:25','Patch Set 2:\n\n(1 comment)',494,2,494,'bada0100_d6c3d488',NULL),(15,'2015-04-29 13:41:40','Patch Set 1: Code-Review+1\n\nNice hack :) I am a bit worried that a change in the ABI can break this, but I think is the best we can do at the moment.',495,1,495,'bada0100_166e3cca',NULL),(35,'2015-04-29 14:09:09','Uploaded patch set 2.',495,2,495,'bada0100_16f39c0b',NULL),(32,'2015-04-30 10:41:55','Patch Set 2: Code-Review+1\n\nLooks reasonable to me.',495,2,495,'bada0100_19a50f04',NULL),(NULL,'2015-04-30 11:08:13','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I3128058e, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',495,2,495,'bada0100_19f3cf0b',NULL),(35,'2015-04-29 14:11:01','Patch Set 2:\n\n> Nice hack :) I am a bit worried that a change in the ABI can break\n > this, but I think is the best we can do at the moment.\n\nI tested this in a x86 VM, everything seemed fine (weston-simple-egl etc..)',495,2,495,'bada0100_36f820e5',NULL),(15,'2015-04-30 11:08:18','Patch Set 3: Patch Set 2 was rebased',495,2,495,'bada0100_39f813e5',NULL),(15,'2015-04-30 11:08:07','Patch Set 2: Code-Review+2',495,2,495,'bada0100_79ee9b24',NULL),(15,'2015-04-30 11:08:21','Patch Set 3: Code-Review+2',495,3,495,'bada0100_d9dc6777',NULL),(35,'2015-04-29 12:20:16','Uploaded patch set 1.',495,1,495,'bada0100_f3fe2a38',NULL),(15,'2015-04-30 11:08:23','Change has been successfully merged into the git repository.',495,3,495,'bada0100_f9d92b84',NULL),(35,'2015-04-29 12:47:25','Uploaded patch set 3.',496,3,496,'bada0100_13440e73',NULL),(15,'2015-04-30 11:08:43','Change has been successfully merged into the git repository.',496,6,496,'bada0100_19caefa1',NULL),(32,'2015-04-30 10:42:34','Patch Set 5: Code-Review+1\n\nThis seems reasonable to me.',496,5,496,'bada0100_39aa53d5',NULL),(15,'2015-04-29 12:35:03','Patch Set 1: Code-Review-1\n\n(1 comment)',496,1,496,'bada0100_53bcd66c',NULL),(15,'2015-04-30 11:08:39','Patch Set 6: Patch Set 5 was rebased',496,5,496,'bada0100_59d07753',NULL),(35,'2015-04-29 12:44:03','Uploaded patch set 2.',496,2,496,'bada0100_7368faf5',NULL),(15,'2015-04-30 11:08:41','Patch Set 6: Code-Review+2',496,6,496,'bada0100_79d53b42',NULL),(35,'2015-04-29 12:20:16','Uploaded patch set 1.',496,1,496,'bada0100_93fb1e47',NULL),(35,'2015-04-29 14:09:09','Uploaded patch set 4.',496,4,496,'bada0100_968f8c75',NULL),(15,'2015-04-30 11:08:33','Patch Set 5: Code-Review+2',496,5,496,'bada0100_99e6df43',NULL),(27,'2015-04-29 13:47:16','Patch Set 3: Code-Review+1',496,3,496,'bada0100_b65e5011',NULL),(NULL,'2015-04-30 11:08:35','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I687fa98e, however the current patch set is 3.\n* Depends on commit f3650696a6e46d4da0d10079607c0b6bd6d30c77 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',496,5,496,'bada0100_b9e3a332',NULL),(15,'2015-04-29 13:43:15','Patch Set 3: Code-Review+1',496,3,496,'bada0100_f664d8e6',NULL),(15,'2015-04-30 10:29:20','Patch Set 5: Commit message was updated',496,5,496,'bada0100_f964cbe6',NULL),(35,'2015-04-29 12:47:25','Uploaded patch set 2.',497,2,497,'bada0100_3349128c',NULL),(15,'2015-04-30 11:09:11','Patch Set 3: Code-Review+2',497,3,497,'bada0100_39cfb3b2',NULL),(8,'2015-04-29 14:32:34','Patch Set 3:\n\n(1 comment)',497,3,497,'bada0100_76d54842',NULL),(15,'2015-04-30 11:09:19','Patch Set 4: Code-Review+2',497,4,497,'bada0100_99bd7f05',NULL),(35,'2015-04-29 12:20:16','Uploaded patch set 1.',497,1,497,'bada0100_b3f8a24a',NULL),(35,'2015-04-29 14:09:09','Uploaded patch set 3.',497,3,497,'bada0100_b68c1081',NULL),(15,'2015-04-30 11:09:21','Change has been successfully merged into the git repository.',497,4,497,'bada0100_b9bac308',NULL),(15,'2015-04-29 14:20:03','Patch Set 3: Code-Review+1\n\nLooks good at a glance, and it doesn\'t affect other systems',497,3,497,'bada0100_d6dc3477',NULL),(NULL,'2015-04-30 11:09:13','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of I1d066756, however the current patch set is 6.\n* Depends on commit 06183568de521a8d850f92c342a31f13bdc3e8a6 which has no change associated with it.\n* Depends on commit f3650696a6e46d4da0d10079607c0b6bd6d30c77 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',497,3,497,'bada0100_d9c30789',NULL),(27,'2015-04-29 13:29:56','Patch Set 2: Code-Review+1',497,2,497,'bada0100_f63db8bc',NULL),(15,'2015-04-30 11:09:16','Patch Set 4: Patch Set 3 was rebased',497,3,497,'bada0100_f9c04b7e',NULL),(15,'2015-04-30 11:09:40','Patch Set 4: Patch Set 3 was rebased',498,3,498,'bada0100_19418f0b',NULL),(27,'2015-04-29 13:29:41','Patch Set 2: Code-Review+1',498,2,498,'bada0100_365ca025',NULL),(15,'2015-04-30 11:09:42','Patch Set 4: Code-Review+2',498,4,498,'bada0100_3946d324',NULL),(35,'2015-04-29 12:20:16','Uploaded patch set 1.',498,1,498,'bada0100_5395b6e2',NULL),(35,'2015-04-29 14:09:09','Uploaded patch set 3.',498,3,498,'bada0100_56e92419',NULL),(15,'2015-04-30 11:09:35','Patch Set 3: Code-Review+2',498,3,498,'bada0100_593717b1',NULL),(NULL,'2015-04-30 11:09:37','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I7ab2b969, however the current patch set is 4.\n* Depends on commit 027be566b2501c437046d3c9a0a1619333d661f1 which has no change associated with it.\n* Depends on commit 06183568de521a8d850f92c342a31f13bdc3e8a6 which has no change associated with it.\n* Depends on commit f3650696a6e46d4da0d10079607c0b6bd6d30c77 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',498,3,498,'bada0100_793c5b94',NULL),(35,'2015-04-29 12:47:25','Uploaded patch set 2.',498,2,498,'bada0100_d35d264a',NULL),(15,'2015-04-30 11:09:44','Change has been successfully merged into the git repository.',498,4,498,'bada0100_d94a2727',NULL),(15,'2015-04-29 14:21:28','Patch Set 3: Code-Review+1',498,3,498,'bada0100_f6d93884',NULL),(27,'2015-04-29 13:28:00','Patch Set 1: Code-Review+1\n\nplain and simple, i like it :)',499,1,499,'bada0100_16571c04',NULL),(15,'2015-04-29 12:52:56','Uploaded patch set 1.',499,1,499,'bada0100_5331360a',NULL),(6,'2015-04-29 13:44:57','Patch Set 1: Code-Review+2',499,1,499,'bada0100_9661ccd5',NULL),(15,'2015-04-29 14:22:00','Change has been successfully merged into the git repository.',499,1,499,'bada0100_96e6ac43',NULL),(37,'2015-04-29 13:47:21','Uploaded patch set 1.',500,1,500,'bada0100_96b8ec2b',NULL),(37,'2015-04-29 13:47:43','Abandoned\n\nAccidentally included.',500,1,500,'bada0100_b6b5f032',NULL),(18,'2015-04-29 15:04:19','Change has been successfully merged into the git repository.',501,1,501,'bada0100_16587cf9',NULL),(18,'2015-04-29 15:04:16','Patch Set 1: Code-Review+2',501,1,501,'bada0100_766308b2',NULL),(40,'2015-04-29 14:49:33','Uploaded patch set 1.',501,1,501,'bada0100_b6bad008',NULL),(35,'2015-04-29 15:00:08','Patch Set 1: Code-Review+1',501,1,501,'bada0100_f647f81b',NULL),(6,'2015-05-07 15:02:32','Patch Set 2: Patch Set 1 was rebased',502,1,502,'bada0100_2ab433f1',NULL),(6,'2015-04-29 15:54:21','Uploaded patch set 1.',502,1,502,'bada0100_36e26004',NULL),(32,'2015-05-06 09:30:15','Patch Set 1:\n\n(1 comment)',502,1,502,'bada0100_3fd6b3c6',NULL),(6,'2015-05-07 15:02:32','Change has been successfully rebased as f6e36277bb06620f1f25ef10caed950fa22c1f5b',502,1,502,'bada0100_4ab977e8',NULL),(6,'2015-05-06 08:54:15','Patch Set 1:\n\n(1 comment)',502,1,502,'bada0100_5f605735',NULL),(32,'2015-05-06 08:48:41','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nI have a slight concern regarding the target location check removal, but would accept if there\'s no clean way to allow for what I requested.',502,1,502,'bada0100_5f7937fb',NULL),(6,'2015-05-07 15:02:30','Patch Set 1: Code-Review+2\n\nI\'m going to merge this as-is because it\'s already tested and is important for the 15.09 release, but will look at re-instating the check as a separate change.',502,1,502,'bada0100_8abf5fd0',NULL),(6,'2015-05-06 08:47:13','Patch Set 1:\n\n> `cp -al` sounds good, I may get the chance to test that tomorrow.\n\nI didn\'t get the chance to retest with `cp -al` in the end.',502,1,502,'bada0100_9f1f9fb7',NULL),(6,'2015-04-29 20:21:18','Patch Set 1:\n\n> (1 comment)\n > \n > cp -al might give us the benefit of speed as well as merging\n > directories, but I leave it up to you whether you think it\'s worth\n > investigating.\n > \n > I don\'t follow your description of the problem though, it\'s the\n > lack of merging that\'s the problem, not some removal.\n\nThanks for the review! I realise that the error from \'mv\' is caused by there already being stuff in the sys-root/ folder. But take a look at commit : we were already using \'mv\' to populate the sys-root/ folder, but because we ran `find \"$2\" -mindepth 1 -delete` first, it didn\'t cause a problem.',502,1,502,'bada0100_d6daf4e8',NULL),(37,'2015-04-29 17:24:26','Patch Set 1: Code-Review+1\n\n(1 comment)\n\ncp -al might give us the benefit of speed as well as merging directories, but I leave it up to you whether you think it\'s worth investigating.\n\nI don\'t follow your description of the problem though, it\'s the lack of merging that\'s the problem, not some removal.',502,1,502,'bada0100_f6505860',NULL),(6,'2015-04-29 20:22:11','Patch Set 1:\n\n`cp -al` sounds good, I may get the chance to test that tomorrow.',502,1,502,'bada0100_f6d7f8bd',NULL),(15,'2015-04-30 10:12:38','Patch Set 2: Code-Review+2',503,2,503,'bada0100_1920af9a',NULL),(15,'2015-04-30 10:12:40','Patch Set 3: Patch Set 2 was rebased',503,2,503,'bada0100_392573ab',NULL),(15,'2015-04-30 09:42:10','Patch Set 1: Code-Review-1\n\n(2 comments)',503,1,503,'bada0100_b62bb093',NULL),(37,'2015-04-30 09:37:25','Patch Set 1: Code-Review+1',503,1,503,'bada0100_b6541022',NULL),(26,'2015-04-30 09:59:24','Uploaded patch set 2.',503,2,503,'bada0100_d9122758',NULL),(15,'2015-04-30 10:12:41','Change has been successfully rebased as 6abe65e89459f3170e7a0abf12d3021a62d3beee',503,2,503,'bada0100_d939c7d9',NULL),(8,'2015-04-30 09:41:59','Patch Set 1: Code-Review+1\n\nNot sure why you need python-core but it does not hurt there.',503,1,503,'bada0100_f62138b5',NULL),(26,'2015-04-29 16:04:10','Uploaded patch set 1.',503,1,503,'bada0100_f6ca986d',NULL),(8,'2015-04-30 10:03:50','Patch Set 2: Code-Review+1',503,2,503,'bada0100_f90feb2c',NULL),(16,'2015-04-30 12:34:38','Patch Set 6: Code-Review+1',504,6,504,'bada0100_19266f69',NULL),(37,'2015-04-29 16:52:09','Uploaded patch set 2.',504,2,504,'bada0100_361100ad',NULL),(37,'2015-04-29 16:55:11','Uploaded patch set 4.',504,4,504,'bada0100_368820e7',NULL),(37,'2015-04-30 17:59:30','Uploaded patch set 7.',504,7,504,'bada0100_44f88ee5',NULL),(37,'2015-04-29 16:53:32','Uploaded patch set 3.',504,3,504,'bada0100_567924fb',NULL),(29,'2015-04-30 08:46:14','Patch Set 5: Code-Review+2',504,5,504,'bada0100_56bcc46c',NULL),(29,'2015-05-01 10:15:48','Patch Set 8: Code-Review+2',504,8,504,'bada0100_648fd224',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 8.',504,8,504,'bada0100_64d03254',NULL),(37,'2015-04-29 17:20:52','Uploaded patch set 5.',504,5,504,'bada0100_76654844',NULL),(16,'2015-04-30 07:29:23','Patch Set 5: Code-Review+1',504,5,504,'bada0100_76f30874',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 6.',504,6,504,'bada0100_790a1bd4',NULL),(16,'2015-04-30 18:39:36','Patch Set 8: Code-Review+1',504,8,504,'bada0100_843c3695',NULL),(37,'2015-05-01 11:04:38','Change has been successfully merged into the git repository.',504,8,504,'bada0100_e4d0a2f9',NULL),(37,'2015-04-29 16:09:49','Uploaded patch set 1.',504,1,504,'bada0100_f6913853',NULL),(7,'2015-04-30 16:47:20','Patch Set 2: Code-Review+2',505,2,505,'bada0100_0465a6e0',NULL),(7,'2015-04-30 14:01:03','Patch Set 1: Code-Review+2\n\nLooks OK!',505,1,505,'bada0100_1982ef00',NULL),(7,'2015-05-01 09:12:20','Change has been successfully merged into the git repository.',505,2,505,'bada0100_44e2ce04',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',505,2,505,'bada0100_84043616',NULL),(8,'2015-04-29 16:52:14','Patch Set 1: Code-Review+1',505,1,505,'bada0100_b61c10c3',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',505,1,505,'bada0100_f69ff84e',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',506,2,506,'bada0100_2409ca2c',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',506,1,506,'bada0100_96ac6c8e',NULL),(7,'2015-04-30 16:47:41','Patch Set 2: Code-Review+2',506,2,506,'bada0100_a4613ad5',NULL),(7,'2015-05-01 09:13:12','Change has been successfully merged into the git repository.',506,2,506,'bada0100_c4ed5ef1',NULL),(8,'2015-04-29 16:57:25','Patch Set 1: Code-Review+2',506,1,506,'bada0100_f6693826',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',507,2,507,'bada0100_440e4e36',NULL),(8,'2015-05-01 09:13:30','Patch Set 2: Code-Review+2',507,2,507,'bada0100_64ba72e3',NULL),(7,'2015-05-01 10:04:29','Change has been successfully merged into the git repository.',507,2,507,'bada0100_848d1634',NULL),(7,'2015-04-30 16:48:05','Patch Set 2: Code-Review+1',507,2,507,'bada0100_84a0b6f5',NULL),(8,'2015-04-29 17:03:07','Patch Set 1: Code-Review+1',507,1,507,'bada0100_b673b014',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',507,1,507,'bada0100_b6a9707d',NULL),(7,'2015-04-30 14:05:36','Patch Set 1: Code-Review+1\n\nThis change looks sensible to me',507,1,507,'bada0100_f9784b2d',NULL),(8,'2015-05-01 09:09:14','Patch Set 2: Code-Review+1',508,2,508,'bada0100_041da60f',NULL),(7,'2015-05-01 12:17:40','Change has been successfully rebased as 1a8ca07ea5b64d6c5ddb044a8d44de4304087e27',508,2,508,'bada0100_24354a46',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',508,1,508,'bada0100_56b604de',NULL),(7,'2015-05-01 12:16:37','Patch Set 2: Code-Review+2',508,2,508,'bada0100_642b52ec',NULL),(7,'2015-05-01 12:17:40','Patch Set 3: Patch Set 2 was rebased',508,2,508,'bada0100_8430b657',NULL),(8,'2015-04-29 17:31:41','Patch Set 1: Code-Review+1',508,1,508,'bada0100_b64ad0aa',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',508,2,508,'bada0100_e412e257',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',509,2,509,'bada0100_0410464d',NULL),(7,'2015-05-01 12:19:23','Patch Set 3: Patch Set 2 was rebased',509,2,509,'bada0100_043cc62e',NULL),(7,'2015-04-30 16:49:16','Patch Set 2: Code-Review+1',509,2,509,'bada0100_24a54a04',NULL),(8,'2015-04-29 17:38:19','Patch Set 1: Code-Review+1',509,1,509,'bada0100_36d6e0c6',NULL),(NULL,'2015-05-01 12:18:49','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ia02e93b5, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',509,2,509,'bada0100_443ace37',NULL),(7,'2015-04-30 14:13:19','Patch Set 1: Code-Review+1',509,1,509,'bada0100_598f1724',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',509,1,509,'bada0100_76bb08c5',NULL),(8,'2015-05-01 09:13:45','Patch Set 2: Code-Review+2',509,2,509,'bada0100_84bf56d0',NULL),(7,'2015-05-01 12:19:26','Patch Set 3: Code-Review+2',509,3,509,'bada0100_a4485acd',NULL),(7,'2015-05-01 12:19:27','Change has been successfully merged into the git repository.',509,3,509,'bada0100_c4455eb4',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',510,1,510,'bada0100_16b07cdc',NULL),(7,'2015-04-30 15:06:04','Patch Set 1: Code-Review+1',510,1,510,'bada0100_1983cfcd',NULL),(7,'2015-05-01 12:20:35','Patch Set 3: Patch Set 2 was rebased',510,2,510,'bada0100_240c6a94',NULL),(8,'2015-05-01 09:14:02','Patch Set 2: Code-Review+2',510,2,510,'bada0100_24b46af1',NULL),(7,'2015-05-01 12:20:38','Patch Set 3: Code-Review+2',510,3,510,'bada0100_44116eab',NULL),(7,'2015-04-30 16:49:31','Patch Set 2: Code-Review+1',510,2,510,'bada0100_44aaced5',NULL),(NULL,'2015-05-01 12:19:53','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ide6df1bb, however the current patch set is 3.\n* Depends on commit 7e821ef5682a90c2a41d382550a9b199a801eb66 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',510,2,510,'bada0100_641272b6',NULL),(8,'2015-04-30 08:34:53','Patch Set 1: Code-Review+1',510,1,510,'bada0100_96922cf5',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',510,2,510,'bada0100_a41cda6b',NULL),(7,'2015-05-01 12:20:40','Change has been successfully merged into the git repository.',510,3,510,'bada0100_e425020b',NULL),(7,'2015-05-01 12:21:46','Patch Set 3: Patch Set 2 was rebased',511,2,511,'bada0100_04236606',NULL),(28,'2015-04-30 14:51:30','Patch Set 1:\n\n(1 comment)',511,1,511,'bada0100_19350f46',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',511,1,511,'bada0100_36b580cd',NULL),(7,'2015-04-30 14:57:50','Patch Set 1: Code-Review+1\n\n(1 comment)',511,1,511,'bada0100_3911f3ac',NULL),(8,'2015-05-01 09:14:26','Patch Set 2: Code-Review+2',511,2,511,'bada0100_44b96ee8',NULL),(7,'2015-04-30 14:44:44','Patch Set 1: Code-Review-1\n\n(1 comment)',511,1,511,'bada0100_99f1ff97',NULL),(7,'2015-05-01 12:21:49','Patch Set 3: Code-Review+2',511,3,511,'bada0100_a41ffab6',NULL),(8,'2015-04-30 08:39:41','Patch Set 1: Code-Review+1',511,1,511,'bada0100_b68f30cc',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',511,2,511,'bada0100_c419de7a',NULL),(7,'2015-05-01 12:21:51','Change has been successfully merged into the git repository.',511,3,511,'bada0100_c41c7ec4',NULL),(7,'2015-04-30 16:49:58','Patch Set 2: Code-Review+1',511,2,511,'bada0100_e4ae62e7',NULL),(7,'2015-05-01 12:22:14','Change has been successfully merged into the git repository.',512,3,512,'bada0100_24830ace',NULL),(7,'2015-05-01 12:22:10','Patch Set 3: Patch Set 2 was rebased',512,2,512,'bada0100_647912fc',NULL),(7,'2015-04-30 15:03:40','Patch Set 1: Code-Review+1\n\n(1 comment)',512,1,512,'bada0100_797e9be6',NULL),(7,'2015-05-01 12:22:12','Patch Set 3: Code-Review+2',512,3,512,'bada0100_847e76e3',NULL),(8,'2015-04-30 15:00:11','Patch Set 1:\n\n(1 comment)',512,1,512,'bada0100_991fbfb7',NULL),(7,'2015-04-30 16:35:32','Patch Set 2: Code-Review+1',512,2,512,'bada0100_a4337af5',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',512,2,512,'bada0100_b92ba393',NULL),(7,'2015-04-30 14:56:22','Patch Set 1: Code-Review-1\n\n(1 comment)',512,1,512,'bada0100_b945e3b4',NULL),(8,'2015-04-30 14:48:43','Patch Set 1: Code-Review+1',512,1,512,'bada0100_b9ee43b3',NULL),(8,'2015-05-01 09:10:33','Patch Set 2: Code-Review+2',512,2,512,'bada0100_c416bef1',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',512,1,512,'bada0100_d6c9945b',NULL),(28,'2015-04-30 15:14:25','Patch Set 1:\n\n(1 comment)',512,1,512,'bada0100_f9d7ebbd',NULL),(7,'2015-05-01 12:22:40','Patch Set 3: Code-Review+2',513,3,513,'bada0100_046a861a',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',513,2,513,'bada0100_59187784',NULL),(8,'2015-05-01 09:11:02','Patch Set 2: Code-Review+2',513,2,513,'bada0100_64d35239',NULL),(8,'2015-04-30 15:13:34','Patch Set 1: Code-Review+1',513,1,513,'bada0100_79cc5b36',NULL),(7,'2015-05-01 12:22:45','Change has been successfully merged into the git repository.',513,3,513,'bada0100_a4761a05',NULL),(7,'2015-04-30 16:35:55','Patch Set 2: Code-Review+1',513,2,513,'bada0100_c430feea',NULL),(7,'2015-04-30 15:10:15','Patch Set 1: Code-Review+1',513,1,513,'bada0100_d96c6739',NULL),(7,'2015-05-01 12:22:38','Patch Set 3: Patch Set 2 was rebased',513,2,513,'bada0100_e46c2239',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',513,1,513,'bada0100_f6c61849',NULL),(8,'2015-04-30 15:13:48','Patch Set 1: Code-Review+1',514,1,514,'bada0100_19d18fcd',NULL),(7,'2015-04-30 16:36:25','Patch Set 2: Code-Review+1',514,2,514,'bada0100_644d9272',NULL),(7,'2015-05-01 12:23:03','Patch Set 3: Code-Review+2',514,3,514,'bada0100_64603236',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',514,2,514,'bada0100_791d3b73',NULL),(7,'2015-04-30 15:11:54','Patch Set 1: Code-Review+1',514,1,514,'bada0100_79653b44',NULL),(7,'2015-05-01 12:23:06','Change has been successfully merged into the git repository.',514,3,514,'bada0100_84651647',NULL),(8,'2015-05-01 09:11:31','Patch Set 2: Code-Review+2',514,2,514,'bada0100_84d8b654',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',514,1,514,'bada0100_96c30c38',NULL),(7,'2015-05-01 12:23:02','Patch Set 3: Patch Set 2 was rebased',514,2,514,'bada0100_c4731e14',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',515,2,515,'bada0100_1912ef62',NULL),(7,'2015-05-01 12:23:42','Patch Set 3: Patch Set 2 was rebased',515,2,515,'bada0100_245a2a84',NULL),(8,'2015-05-01 09:11:44','Patch Set 2: Code-Review+2',515,2,515,'bada0100_24dd4a43',NULL),(8,'2015-04-30 15:14:01','Patch Set 1: Code-Review+1',515,1,515,'bada0100_39d6d3c6',NULL),(7,'2015-05-01 12:23:44','Patch Set 3: Code-Review+2',515,3,515,'bada0100_445f2e73',NULL),(7,'2015-04-30 15:12:52','Patch Set 1: Code-Review+1',515,1,515,'bada0100_59c71713',NULL),(7,'2015-04-30 16:37:23','Patch Set 2: Code-Review+1',515,2,515,'bada0100_8452f611',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',515,1,515,'bada0100_b6c0902b',NULL),(7,'2015-05-01 12:23:46','Change has been successfully merged into the git repository.',515,3,515,'bada0100_e453c26a',NULL),(7,'2015-04-30 16:39:06','Patch Set 2: Code-Review+1',516,2,516,'bada0100_043e06b9',NULL),(7,'2015-05-01 14:37:43','Change has been successfully merged into the git repository.',516,4,516,'bada0100_24122a63',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',516,2,516,'bada0100_3917b353',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',516,1,516,'bada0100_56dda413',NULL),(7,'2015-05-01 14:37:37','Patch Set 4: Patch Set 3 was rebased',516,3,516,'bada0100_64183285',NULL),(7,'2015-05-01 14:37:40','Patch Set 4: Code-Review+2',516,4,516,'bada0100_841d1676',NULL),(7,'2015-05-01 12:25:40','Patch Set 2: -Code-Review\n\n(1 comment)',516,2,516,'bada0100_a44dbac6',NULL),(7,'2015-04-30 15:15:35','Patch Set 1: Code-Review+1\n\n(1 comment)',516,1,516,'bada0100_b9e1639c',NULL),(8,'2015-04-30 15:14:20','Patch Set 1: Code-Review+1',516,1,516,'bada0100_d9da27e9',NULL),(28,'2015-05-01 12:30:06','Uploaded patch set 3.',516,3,516,'bada0100_e4dae2e8',NULL),(8,'2015-05-01 09:12:27','Patch Set 2: Code-Review+2',516,2,516,'bada0100_e4e66216',NULL),(28,'2015-04-30 15:24:49','Patch Set 1:\n\n> This is change can have many consequences, I don\'t feel confident\n > yet to give it a vote.\n\nYou choose an interesting commit to not vote. I can tell you that without this commit the system doesn\'t work due postgres being pulled in before its setup.',517,1,517,'bada0100_19e8af7b',NULL),(8,'2015-05-01 15:02:17','Patch Set 3:\n\n(1 comment)',517,3,517,'bada0100_1f208f9a',NULL),(28,'2015-05-01 15:04:58','Patch Set 3:\n\n(1 comment)',517,3,517,'bada0100_1f572f04',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 4.',517,4,517,'bada0100_1ff3af0b',NULL),(7,'2015-05-08 09:55:43','Patch Set 5: Patch Set 4 was rebased',517,4,517,'bada0100_2a5af383',NULL),(8,'2015-05-01 15:06:04','Patch Set 3: Code-Review+1\n\nFair enough',517,3,517,'bada0100_3f5c7325',NULL),(7,'2015-05-08 09:55:44','Change has been successfully rebased as 70159902d45c6309bfafa8416b077d9706a98b4a',517,4,517,'bada0100_4a5f3773',NULL),(8,'2015-04-30 15:31:34','Patch Set 1:\n\n> I\'ve seen it runnin... but Im not confident that this is not\n > required. If the error was in postgres, why no make postgres\n > depends on its postgres-setup and network-online?\n\nI\'ve seen it running properly on first boot, I would like to test it rebooting multiple times and check that everything still working fine.',517,1,517,'bada0100_5995d7e2',NULL),(7,'2015-04-30 15:20:33','Patch Set 1:\n\nThis is change can have many consequences, I don\'t feel confident yet to give it a vote.',517,1,517,'bada0100_59ee378d',NULL),(8,'2015-05-01 15:04:28','Patch Set 3:\n\n(3 comments)',517,3,517,'bada0100_5f4db771',NULL),(7,'2015-05-01 14:40:54','Patch Set 3: Patch Set 2 was rebased',517,2,517,'bada0100_5ffff701',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',517,1,517,'bada0100_76e228d7',NULL),(8,'2015-04-30 15:30:17','Patch Set 1:\n\nI\'ve seen it runnin... but Im not confident that this is not required. If the error was in postgres, why no make postgres depends on its postgres-setup and network-online?',517,1,517,'bada0100_b9f8834a',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',517,2,517,'bada0100_d90b072a',NULL),(7,'2015-05-08 09:40:17','Patch Set 4: Code-Review+2\n\nThis patch looks OK to me now. Also I know you have tested this a few times, and I also know you will fix this if it breaks anythink.',517,4,517,'bada0100_ea25cb0a',NULL),(8,'2015-05-01 09:12:49','Patch Set 2: Code-Review+2',518,2,518,'bada0100_04e4c60b',NULL),(7,'2015-05-08 09:55:59','Patch Set 4: Code-Review+2',518,4,518,'bada0100_0a512f62',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',518,1,518,'bada0100_16e71ce6',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 3.',518,3,518,'bada0100_3ff8f3e4',NULL),(8,'2015-04-30 15:21:39','Patch Set 1: Code-Review+1',518,1,518,'bada0100_79f3fb73',NULL),(7,'2015-04-30 15:27:32','Patch Set 1: Code-Review+1',518,1,518,'bada0100_99fb3f47',NULL),(7,'2015-05-08 09:56:01','Change has been successfully merged into the git repository.',518,4,518,'bada0100_aa4d83c6',NULL),(7,'2015-05-08 09:48:54','Patch Set 3: Code-Review+2',518,3,518,'bada0100_aa76e304',NULL),(7,'2015-04-30 16:39:51','Patch Set 2: Code-Review+1',518,2,518,'bada0100_c4479e4a',NULL),(7,'2015-05-08 09:55:57','Patch Set 4: Patch Set 3 was rebased',518,3,518,'bada0100_ea538b6a',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',518,2,518,'bada0100_f9084b2f',NULL),(7,'2015-05-08 09:42:13','Patch Set 3: Code-Review+2\n\nThis patch looks OK',519,3,519,'bada0100_0a236f06',NULL),(7,'2015-04-30 15:36:01','Patch Set 1: Code-Review+1\n\n(1 comment)',519,1,519,'bada0100_199f4f05',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',519,1,519,'bada0100_36eca0c7',NULL),(7,'2015-05-08 09:56:10','Patch Set 4: Code-Review+2',519,4,519,'bada0100_6ac79b13',NULL),(8,'2015-04-30 14:57:02','Patch Set 1: Code-Review+1',519,1,519,'bada0100_79177ba4',NULL),(7,'2015-04-30 16:43:18','Patch Set 1:\n\n(1 comment)',519,1,519,'bada0100_84799695',NULL),(7,'2015-05-08 09:56:11','Change has been successfully merged into the git repository.',519,4,519,'bada0100_8acc3f37',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',519,2,519,'bada0100_99057f16',NULL),(28,'2015-04-30 15:51:46','Patch Set 1:\n\n(1 comment)',519,1,519,'bada0100_b9a64352',NULL),(28,'2015-05-01 10:02:02','Patch Set 2:\n\n> (1 comment)\n\nI think it is more correct to only depend on /etc/openstack/cinder.conf, as we are doing for the rest of the setup scripts',519,2,519,'bada0100_c49b1e71',NULL),(7,'2015-05-08 09:56:08','Patch Set 4: Patch Set 3 was rebased',519,3,519,'bada0100_ca4a47ac',NULL),(8,'2015-05-01 15:06:56','Patch Set 2: Code-Review+1',519,2,519,'bada0100_df40c737',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 3.',519,3,519,'bada0100_dfdc4777',NULL),(28,'2015-05-01 10:09:55','Patch Set 2:\n\n> > (1 comment)\n > \n > I think it is more correct to only depend on /etc/openstack/cinder.conf,\n > as we are doing for the rest of the setup scripts\n\nAlthough I can add /etc/cinder/cinder.conf in addition.',519,2,519,'bada0100_e47bc227',NULL),(7,'2015-04-30 16:43:57','Patch Set 2: Code-Review+1',520,2,520,'bada0100_246eaaca',NULL),(7,'2015-05-08 09:56:21','Patch Set 4: Patch Set 3 was rebased',520,3,520,'bada0100_2ad193cd',NULL),(7,'2015-05-08 09:56:22','Patch Set 4: Code-Review+2',520,4,520,'bada0100_4ad657c7',NULL),(8,'2015-05-01 09:13:11','Patch Set 2: Code-Review+2',520,2,520,'bada0100_a4f05aca',NULL),(7,'2015-05-08 09:43:00','Patch Set 3: Code-Review+2',520,3,520,'bada0100_aa1fc3b6',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',520,2,520,'bada0100_b902c309',NULL),(8,'2015-04-30 15:02:24','Patch Set 1: Code-Review+1',520,1,520,'bada0100_b91c03c3',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',520,1,520,'bada0100_d6d0b4f9',NULL),(7,'2015-04-30 15:38:11','Patch Set 1: Code-Review+1\n\nI assume this change is to avoid running the same setup service twice. I also assume this has been tested.',520,1,520,'bada0100_d988e7c8',NULL),(7,'2015-05-08 09:56:24','Change has been successfully merged into the git repository.',520,4,520,'bada0100_eadaabe8',NULL),(28,'2015-04-30 15:48:55','Patch Set 1:\n\n> I assume this change is to avoid running the same setup service\n > twice. I also assume this has been tested.\n\n > I assume this change is to avoid running the same setup service\n > twice. I also assume this has been tested.\n\n > I assume this change is to avoid running the same setup service\n > twice. I also assume this has been tested.\n\nIt is more to be consistent with other oneshot services that we have.',520,1,520,'bada0100_f9accb37',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 3.',520,3,520,'bada0100_ffd90b84',NULL),(7,'2015-05-08 09:56:30','Patch Set 4: Patch Set 3 was rebased',521,3,521,'bada0100_0ad84fee',NULL),(7,'2015-04-30 16:44:52','Patch Set 2: Code-Review+2',521,2,521,'bada0100_4473aeb1',NULL),(28,'2015-04-30 16:20:19','Uploaded patch set 2.',521,2,521,'bada0100_64ffd202',NULL),(7,'2015-04-30 15:40:57','Patch Set 1:\n\nLooks ok, +1 if you also remove the --logfile ones.',521,1,521,'bada0100_79c1bbe3',NULL),(8,'2015-04-30 15:12:31','Patch Set 1: Code-Review-1\n\n(8 comments)',521,1,521,'bada0100_994d7fc7',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 3.',521,3,521,'bada0100_9fe6bf43',NULL),(7,'2015-05-08 09:56:32','Patch Set 4: Code-Review+2',521,4,521,'bada0100_aae4a3ac',NULL),(7,'2015-05-08 09:44:15','Patch Set 3: Code-Review+2',521,3,521,'bada0100_ca1c87c4',NULL),(7,'2015-05-08 09:56:33','Change has been successfully merged into the git repository.',521,4,521,'bada0100_cae1e79b',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',521,1,521,'bada0100_f6cdb85e',NULL),(28,'2015-04-30 15:26:37','Patch Set 1:\n\nIt\'s true. I just removed the `--log-file` options, as I was not aware that the old name for that option was `--logfile`.',521,1,521,'bada0100_f9fe0b38',NULL),(27,'2015-04-29 16:48:53','Patch Set 1: Code-Review+1',522,1,522,'bada0100_160cfc93',NULL),(28,'2015-04-30 16:38:23','Patch Set 2: Commit message was updated',522,2,522,'bada0100_24578a04',NULL),(7,'2015-05-08 09:45:40','Patch Set 5: Code-Review+2',522,5,522,'bada0100_2a83d3cd',NULL),(7,'2015-05-08 09:56:45','Change has been successfully merged into the git repository.',522,6,522,'bada0100_2ae8b37b',NULL),(8,'2015-04-30 15:37:07','Patch Set 1: Code-Review-1\n\na) Ummm, Im interested in the reason why postgres.service would run before postgres-setup.service ...\n\nb) Could you change the commit message to explain that you alter ceilometer-db-setup.service dependencies?',522,1,522,'bada0100_39a49356',NULL),(7,'2015-05-08 09:56:42','Patch Set 6: Patch Set 5 was rebased',522,5,522,'bada0100_6aeebb8d',NULL),(7,'2015-04-30 15:58:03','Patch Set 1:\n\nI agree with Fran\'s b), +1 with a better commit message.',522,1,522,'bada0100_7968dbf5',NULL),(7,'2015-05-08 09:56:44','Patch Set 6: Code-Review+2',522,6,522,'bada0100_8af3df72',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',522,1,522,'bada0100_96da2c16',NULL),(8,'2015-04-30 16:09:07','Patch Set 1: Code-Review+1\n\na) Postgres does not run before postgres-setup but it is enabled and started from inside of it',522,1,522,'bada0100_99801f8d',NULL),(28,'2015-04-30 16:39:17','Patch Set 4: Commit message was updated',522,4,522,'bada0100_a44a9a53',NULL),(8,'2015-04-30 16:09:47','Patch Set 1: -Code-Review\n\nOhh I forgot that I still want a better commit',522,1,522,'bada0100_b97de3b3',NULL),(43,'2015-05-05 16:09:35','Patch Set 5: Code-Review+1',522,5,522,'bada0100_bfd703ed',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 5.',522,5,522,'bada0100_bfe38332',NULL),(28,'2015-04-30 16:38:36','Patch Set 3: Commit message was updated',522,3,522,'bada0100_e440a237',NULL),(7,'2015-04-30 16:46:01','Patch Set 4: Code-Review+2',522,4,522,'bada0100_e46742e9',NULL),(27,'2015-05-05 09:40:25','Patch Set 5: Code-Review+1',522,5,522,'bada0100_ffe34b03',NULL),(7,'2015-05-08 09:56:56','Change has been successfully merged into the git repository.',523,3,523,'bada0100_0affef35',NULL),(7,'2015-04-30 16:00:03','Patch Set 1: Code-Review+2',523,1,523,'bada0100_196d0f05',NULL),(7,'2015-05-08 09:46:11','Patch Set 2: Code-Review+2',523,2,523,'bada0100_4a8897e7',NULL),(7,'2015-05-08 09:56:49','Patch Set 3: Patch Set 2 was rebased',523,2,523,'bada0100_4aedf78a',NULL),(43,'2015-05-05 16:11:10','Patch Set 2: Code-Review+1',523,2,523,'bada0100_5f04d77d',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 2.',523,2,523,'bada0100_5fd05753',NULL),(27,'2015-04-29 16:45:23','Patch Set 1: Code-Review+1',523,1,523,'bada0100_761788a4',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',523,1,523,'bada0100_b6d730ed',NULL),(7,'2015-05-08 09:56:54','Patch Set 3: Code-Review+2',523,3,523,'bada0100_ea014b3a',NULL),(8,'2015-04-30 15:38:19','Patch Set 1: Code-Review+1',523,1,523,'bada0100_f985abad',NULL),(8,'2015-04-30 16:26:47','Patch Set 1: Code-Review-1\n\nEven if it is implicit it is much better if all the db-setup.services have the dependency on network-online.service implicit.\nIt is required for connecting to the postgres server and keystone as Pedro said in the previous comment.',524,1,524,'bada0100_4425eea9',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',524,1,524,'bada0100_5604c47d',NULL),(27,'2015-04-29 16:44:45','Patch Set 1: Code-Review+1',524,1,524,'bada0100_561284b5',NULL),(8,'2015-05-01 10:04:04','Patch Set 2: Code-Review+1',524,2,524,'bada0100_64883223',NULL),(7,'2015-05-08 09:57:06','Change has been successfully merged into the git repository.',524,4,524,'bada0100_6a955be3',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 3.',524,3,524,'bada0100_7fd51b42',NULL),(7,'2015-04-30 16:21:59','Patch Set 1: Code-Review-1\n\n(1 comment)',524,1,524,'bada0100_842bd681',NULL),(8,'2015-04-30 15:38:51','Patch Set 1: Code-Review+1',524,1,524,'bada0100_99925ff5',NULL),(28,'2015-05-01 09:59:22','Uploaded patch set 2.',524,2,524,'bada0100_a49e1a62',NULL),(7,'2015-05-08 09:57:02','Patch Set 4: Patch Set 3 was rebased',524,3,524,'bada0100_aafb4346',NULL),(7,'2015-05-08 09:57:04','Patch Set 4: Code-Review+2',524,4,524,'bada0100_caf8074c',NULL),(7,'2015-05-08 09:47:56','Patch Set 3: Code-Review+2\n\nThanks for doing it on this way.',524,3,524,'bada0100_ea6ceb38',NULL),(7,'2015-05-08 09:48:22','Patch Set 3: Code-Review+2',525,3,525,'bada0100_0a6a8f1a',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 3.',525,3,525,'bada0100_1fcacfa1',NULL),(7,'2015-05-01 12:29:04','Patch Set 2: Code-Review+2',525,2,525,'bada0100_24d1cacd',NULL),(7,'2015-05-08 09:57:25','Patch Set 4: Code-Review+2',525,4,525,'bada0100_2a9f5305',NULL),(NULL,'2015-05-01 12:29:10','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Iaa0ed242.\n* Depends on patch set 1 of Ia1107891.\n* Depends on patch set 1 of I6edd96e9, however the current patch set is 4.\n* Depends on commit 35621b0a9b1a3edae41f3d83e852ddc668a3e39d which has no change associated with it.\n* Depends on commit 181f96d63dabdf55e53a925b0b23e619b0c1cc1d which has no change associated with it.\n* Depends on commit 10b454794978232215ada397e5ecbbaabea45d9b which has no change associated with it.\n* Depends on commit 8ebc5c9ed5b80a2f14c35e186a86d512a641d1f1 which has no change associated with it.\n* Depends on commit 51e5e613313913f211c5b8b5b9ea60882caab409 which has no change associated with it.\n* Depends on commit b881d61547081f75bce48bd1d19575cbb3e80801 which has no change associated with it.\n* Depends on commit 482b567e795dfd13d7485a22bfd8ab1991640a70 which has no change associated with it.\n* Depends on commit 7c10eee2b377cf3aea069a3980a0879dca0b433b which has no change associated with it.\n* Depends on commit 6f90ad6178adcaac454d445702560d061b071003 which has no change associated with it.\n* Depends on commit b3f84c2f5e72ba88f782404a07b9a1c6b2f4d9b0 which has no change associated with it.\n* Depends on commit 1672a4a03d15b3ccbb0732d96aa3c89200be05bd which has no change associated with it.\n* Depends on commit 66767b89bbce36e5237c45f4fa60a179394a980b which has no change associated with it.\n* Depends on commit f23efcb9bdbc55569ca35200b61f8844e9242885 which has no change associated with it.\n* Depends on commit b75f34bfb85d7b3de54dff96c8d91dc858e9a1ea which has no change associated with it.\n* Depends on commit 389aeeec65567ad524d1c27091460bf7ab5085d1 which has no change associated with it.\n* Depends on commit cd4b5753c7908373d609485de2edf413fa2384a7 which has no change associated with it.\n* Depends on commit c50520ac4ca66421f4f2416db9ad08fea5f02e79 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',525,2,525,'bada0100_44d64ec7',NULL),(7,'2015-05-08 09:57:27','Change has been successfully merged into the git repository.',525,4,525,'bada0100_4aa41757',NULL),(8,'2015-04-30 15:40:46','Patch Set 1: Code-Review+2',525,1,525,'bada0100_59bcf76c',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',525,1,525,'bada0100_7609c894',NULL),(7,'2015-05-01 12:28:59','Patch Set 2: Patch Set 1 was rebased',525,1,525,'bada0100_84cc3637',NULL),(7,'2015-05-08 09:57:23','Patch Set 4: Patch Set 3 was rebased',525,3,525,'bada0100_8a9aff12',NULL),(27,'2015-04-29 16:44:23','Patch Set 1: Code-Review+1',525,1,525,'bada0100_b645f0b4',NULL),(NULL,'2015-05-01 12:28:26','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Iaa0ed242, however the current patch set is 2.\n* Depends on commit 6fdba75db836fa0fda9ddfe4f4df10bb8846826a which has no change associated with it.\n* Depends on commit a4e4437c6de65bf77be954a98e634b31a9be2a05 which has no change associated with it.\n* Depends on commit 35621b0a9b1a3edae41f3d83e852ddc668a3e39d which has no change associated with it.\n* Depends on commit 181f96d63dabdf55e53a925b0b23e619b0c1cc1d which has no change associated with it.\n* Depends on commit 10b454794978232215ada397e5ecbbaabea45d9b which has no change associated with it.\n* Depends on commit 8ebc5c9ed5b80a2f14c35e186a86d512a641d1f1 which has no change associated with it.\n* Depends on commit 51e5e613313913f211c5b8b5b9ea60882caab409 which has no change associated with it.\n* Depends on commit b881d61547081f75bce48bd1d19575cbb3e80801 which has no change associated with it.\n* Depends on commit 482b567e795dfd13d7485a22bfd8ab1991640a70 which has no change associated with it.\n* Depends on commit 7c10eee2b377cf3aea069a3980a0879dca0b433b which has no change associated with it.\n* Depends on commit 6f90ad6178adcaac454d445702560d061b071003 which has no change associated with it.\n* Depends on commit b3f84c2f5e72ba88f782404a07b9a1c6b2f4d9b0 which has no change associated with it.\n* Depends on commit 1672a4a03d15b3ccbb0732d96aa3c89200be05bd which has no change associated with it.\n* Depends on commit 66767b89bbce36e5237c45f4fa60a179394a980b which has no change associated with it.\n* Depends on commit f23efcb9bdbc55569ca35200b61f8844e9242885 which has no change associated with it.\n* Depends on commit b75f34bfb85d7b3de54dff96c8d91dc858e9a1ea which has no change associated with it.\n* Depends on commit 389aeeec65567ad524d1c27091460bf7ab5085d1 which has no change associated with it.\n* Depends on commit cd4b5753c7908373d609485de2edf413fa2384a7 which has no change associated with it.\n* Depends on commit c50520ac4ca66421f4f2416db9ad08fea5f02e79 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',525,1,525,'bada0100_c44a3eac',NULL),(7,'2015-05-08 09:57:35','Patch Set 4: Code-Review+2',526,4,526,'bada0100_0a860fba',NULL),(28,'2015-04-29 16:12:31','Uploaded patch set 1.',526,1,526,'bada0100_16fe3c6c',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 2.',526,2,526,'bada0100_3fcf93b2',NULL),(8,'2015-04-30 15:53:29','Patch Set 1: Code-Review+1',526,1,526,'bada0100_5963971a',NULL),(7,'2015-05-08 09:53:49','Patch Set 3: Code-Review+2',526,3,526,'bada0100_6a60fb35',NULL),(27,'2015-04-29 16:43:23','Patch Set 1: Code-Review+1\n\nlooks good to me!',526,1,526,'bada0100_9648eccd',NULL),(8,'2015-05-01 09:09:49','Patch Set 1: Code-Review+2',526,1,526,'bada0100_a4193a24',NULL),(7,'2015-05-08 09:57:38','Change has been successfully merged into the git repository.',526,4,526,'bada0100_aa9263f4',NULL),(28,'2015-05-01 17:10:22','Uploaded patch set 3.',526,3,526,'bada0100_df4a0727',NULL),(7,'2015-04-30 16:32:53','Patch Set 1: Code-Review+1',526,1,526,'bada0100_e43982d9',NULL),(7,'2015-05-08 09:57:33','Patch Set 4: Patch Set 3 was rebased',526,3,526,'bada0100_ea886bc8',NULL),(29,'2015-05-01 09:58:58','Change has been successfully merged into the git repository.',527,3,527,'bada0100_04928657',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 3.',527,3,527,'bada0100_04c12680',NULL),(29,'2015-04-30 09:47:55','Patch Set 1: Code-Review-1\n\nI\'m less sure about this change, why do you want this?',527,1,527,'bada0100_79045b15',NULL),(37,'2015-04-29 16:52:09','Uploaded patch set 1.',527,1,527,'bada0100_961f8cb7',NULL),(29,'2015-04-30 10:04:55','Patch Set 1: Code-Review+2\n\nIgnore my previous comment, I think this is fine.',527,1,527,'bada0100_991c9f6c',NULL),(29,'2015-05-01 07:51:11','Patch Set 3: Code-Review+2',527,3,527,'bada0100_e4f8a2c6',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 2.',527,2,527,'bada0100_f9f5abcb',NULL),(16,'2015-04-30 07:29:42','Patch Set 1: Code-Review+1',528,1,528,'bada0100_16e87c7b',NULL),(37,'2015-05-01 11:04:22','Change has been successfully merged into the git repository.',528,4,528,'bada0100_24e78ae6',NULL),(37,'2015-04-30 17:59:30','Uploaded patch set 3.',528,3,528,'bada0100_24f30a0c',NULL),(37,'2015-04-29 17:20:52','Uploaded patch set 1.',528,1,528,'bada0100_365fc074',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 2.',528,2,528,'bada0100_5905d7c0',NULL),(16,'2015-04-30 12:34:25','Patch Set 2: Code-Review+1',528,2,528,'bada0100_7931bba1',NULL),(29,'2015-05-01 10:15:31','Patch Set 4: Code-Review+2',528,4,528,'bada0100_c4723e49',NULL),(16,'2015-04-30 18:38:11','Patch Set 4: Code-Review+1',528,4,528,'bada0100_c4ba3e0a',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 4.',528,4,528,'bada0100_c4e31e32',NULL),(15,'2015-04-29 17:37:01','Change has been successfully merged into the git repository.',529,1,529,'bada0100_16d15ccd',NULL),(16,'2015-04-29 17:33:54','Patch Set 1: Code-Review+1',529,1,529,'bada0100_56c7e412',NULL),(8,'2015-04-29 17:36:36','Patch Set 1: Code-Review+2',529,1,529,'bada0100_76cc6836',NULL),(15,'2015-04-29 17:26:42','Uploaded patch set 1.',529,1,529,'bada0100_964d4cc7',NULL),(37,'2015-04-30 08:22:19','Patch Set 1: Code-Review+1\n\n(2 comments)',530,1,530,'bada0100_169f1c05',NULL),(15,'2015-04-30 10:54:22','Patch Set 1:\n\n(2 comments)',530,1,530,'bada0100_197c2f72',NULL),(15,'2015-04-30 17:15:46','Patch Set 4: Patch Set 3 was rebased',530,3,530,'bada0100_64e9121a',NULL),(15,'2015-04-30 17:15:46','Change has been successfully rebased as 93b034f045a2c7443122d7b082ad4460339907d0',530,3,530,'bada0100_84ee7621',NULL),(15,'2015-04-29 21:56:28','Uploaded patch set 1.',530,1,530,'bada0100_96e46cad',NULL),(15,'2015-04-30 10:30:12','Patch Set 2: Commit message was updated',530,2,530,'bada0100_9961ffd5',NULL),(8,'2015-04-30 10:51:19','Patch Set 3: Code-Review+1',530,3,530,'bada0100_99b81f2c',NULL),(15,'2015-04-30 17:15:44','Patch Set 3: Code-Review+2',530,3,530,'bada0100_c48c7e82',NULL),(37,'2015-04-30 08:22:41','Patch Set 1:\n\n(1 comment)',530,1,530,'bada0100_d688b4c8',NULL),(15,'2015-04-30 10:49:59','Uploaded patch set 3.',530,3,530,'bada0100_d9aea7e7',NULL),(15,'2015-06-23 22:46:35','Patch Set 4: Patch Set 3 was rebased',531,3,531,'1a622d24_130a6cd2',NULL),(28,'2015-06-23 09:45:28','Patch Set 3: Code-Review+1',531,3,531,'1a622d24_13526c13',NULL),(15,'2015-06-23 22:46:31','Patch Set 3: Code-Review+2',531,3,531,'1a622d24_3305e8c2',NULL),(15,'2015-06-23 22:46:36','Change has been successfully rebased as 8424953a31f4f3e6ea6b0fc749e48759f315ef40',531,3,531,'1a622d24_730f60e2',NULL),(6,'2015-06-23 09:36:23','Patch Set 3: Code-Review+1\n\nI\'d rather this had more useful info in it (name of the system, repo, tag, etc.) but this is a good start.',531,3,531,'1a622d24_d330f4ea',NULL),(15,'2015-05-18 14:17:01','Patch Set 1: Code-Review-2\n\n15:15 <•ssam2> once there\'s a new release of Baserock we can merge that\n15:15 <•ssam2> I think if we merged it now, Baserock 15.19 would crash when trying to deploy \'master\' of definitions\n15:16 <•ssam2> and if we bump VERSION to 4 now, Baserock 15.19 will refuse to build \'master\' of definitions',531,1,531,'9adffdf1_afd7d9ec',NULL),(15,'2015-06-17 17:49:59','Uploaded patch set 3.',531,3,531,'ba51214e_3805c9c2',NULL),(15,'2015-06-17 17:03:00','Patch Set 1: -Code-Review\n\nNew version of baserock has been released',531,1,531,'ba51214e_986e9595',NULL),(15,'2015-06-17 17:42:19','Uploaded patch set 2.',531,2,531,'ba51214e_f86b5183',NULL),(7,'2015-05-01 15:21:40','Patch Set 1:\n\nThis looks OK to me, but I haven\'t tested that this actually creates the symlink properly.',531,1,531,'bada0100_1fa5ef03',NULL),(6,'2015-05-14 10:02:17','Patch Set 1: Code-Review-1\n\nOld versions of Morph will crash if they try to build definitions that overwrite a symlink. I want to avoid having Morph crash randomly when building our reference system definitions, so I\'d rather have VERSION updated to \'4\' first, so that old versions of Morph will refuse to deploy the new definitions, rather than try to deploy them but then crash half way through.',531,1,531,'bada0100_373b37ed',NULL),(15,'2015-04-29 22:09:49','Patch Set 1:\n\nNote there is a bug in morph so you need the morph patch from https://gerrit.baserock.org/#/c/530/ to make this work',531,1,531,'bada0100_56ee048d',NULL),(6,'2015-05-05 10:32:42','Patch Set 1: Code-Review+1\n\nThis is great, as long as you\'ve tested it I\'m happy',531,1,531,'bada0100_9fc79f64',NULL),(28,'2015-04-30 09:10:30','Patch Set 1: Code-Review+1',531,1,531,'bada0100_b6a65052',NULL),(15,'2015-04-29 22:07:49','Uploaded patch set 1.',531,1,531,'bada0100_b6e1709c',NULL),(15,'2015-05-14 09:48:57','Patch Set 1: -Code-Review\n\nSeems this doesn\'t require a bump in the definitions format, (previous releases would fail anyway) so removing the veto',531,1,531,'bada0100_d7542b23',NULL),(15,'2015-05-06 12:25:29','Patch Set 1: Code-Review-2\n\nDont merge until morph support version 4 of definitions',531,1,531,'bada0100_ff858bad',NULL),(29,'2015-04-30 10:54:40','Patch Set 1: Code-Review+2',532,1,532,'bada0100_3981f34a',NULL),(32,'2015-04-30 10:22:42','Patch Set 1: Code-Review+1',532,1,532,'bada0100_5974f79b',NULL),(16,'2015-04-30 10:23:13','Patch Set 1: Code-Review+1',532,1,532,'bada0100_7979bb92',NULL),(29,'2015-04-30 08:07:12','Uploaded patch set 1.',532,1,532,'bada0100_b6f8904a',NULL),(37,'2015-04-30 10:21:44','Patch Set 1: Code-Review+1\n\n(1 comment)',532,1,532,'bada0100_b947234b',NULL),(29,'2015-04-30 10:54:49','Patch Set 2: Patch Set 1 was rebased',532,1,532,'bada0100_d9954789',NULL),(8,'2015-04-30 08:27:31','Patch Set 1: Code-Review+1',532,1,532,'bada0100_f685b8ad',NULL),(29,'2015-04-30 10:54:49','Change has been successfully rebased as 5ea105a7f6c20b6ea0b002a389f9a9dcd22537f9',532,1,532,'bada0100_f9928b9e',NULL),(7,'2015-05-01 13:15:38','Patch Set 2: Patch Set 1 was rebased',533,1,533,'bada0100_649592e3',NULL),(7,'2015-05-01 13:15:39','Change has been successfully rebased as 55496bf01f072f9b45e9ec7733c4bf02080bb3a0',533,1,533,'bada0100_849af612',NULL),(37,'2015-04-30 09:36:39','Patch Set 1: Code-Review+2',533,1,533,'bada0100_96578c26',NULL),(16,'2015-04-30 09:16:26','Patch Set 1: Code-Review+1',533,1,533,'bada0100_9680ec8c',NULL),(6,'2015-04-30 09:02:22','Uploaded patch set 1.',533,1,533,'bada0100_d6af542a',NULL),(6,'2015-05-06 09:14:31','Change has been successfully rebased as 18ec40bade8ca1f73c5da919e2810f0d7f0e4f22',534,1,534,'bada0100_5fc7f712',NULL),(6,'2015-05-06 09:14:28','Patch Set 1: Code-Review+2',534,1,534,'bada0100_9f4d5fc7',NULL),(43,'2015-04-30 10:09:52','Uploaded patch set 1.',534,1,534,'bada0100_b919637b',NULL),(15,'2015-04-30 10:19:09','Patch Set 1: Code-Review+1',534,1,534,'bada0100_b93083e9',NULL),(8,'2015-04-30 10:52:39','Patch Set 1: Code-Review+1',534,1,534,'bada0100_b9b5e332',NULL),(6,'2015-05-06 09:14:31','Patch Set 2: Patch Set 1 was rebased',534,1,534,'bada0100_bf4aa3aa',NULL),(43,'2015-04-30 10:09:52','Uploaded patch set 1.',535,1,535,'bada0100_592637bc',NULL),(43,'2015-05-07 10:42:59','Patch Set 1:\n\n(13 comments)\n\nPatches on their way.',535,1,535,'bada0100_ca5ec712',NULL),(8,'2015-04-30 14:34:40','Patch Set 1: Code-Review-1\n\n(13 comments)',535,1,535,'bada0100_d9d0e7f9',NULL),(43,'2015-05-11 11:09:55','Abandoned\n\nChanges to this patch are significant so a different patch series will be submitted.',535,1,535,'bada0100_e51f3c08',NULL),(43,'2015-05-13 16:59:06','Patch Set 1:\n\n(1 comment)',535,1,535,'bada0100_f7afef29',NULL),(43,'2015-05-11 11:11:00','Abandoned\n\nChanges to this patch are significant enough to warrant a new patch series.',536,1,536,'bada0100_051da00f',NULL),(8,'2015-04-30 14:43:07','Patch Set 1: Code-Review-1\n\n(3 comments)',536,1,536,'bada0100_39033375',NULL),(43,'2015-04-30 10:09:52','Uploaded patch set 1.',536,1,536,'bada0100_792bfb82',NULL),(15,'2015-04-30 10:23:29','Patch Set 1: Code-Review+2',537,1,537,'bada0100_196e6fca',NULL),(15,'2015-04-30 10:23:30','Change has been successfully merged into the git repository.',537,1,537,'bada0100_397333b3',NULL),(8,'2015-04-30 10:20:22','Uploaded patch set 1.',537,1,537,'bada0100_79521b15',NULL),(15,'2015-04-30 10:21:14','Patch Set 1: Code-Review+1',537,1,537,'bada0100_d940e737',NULL),(35,'2015-04-30 10:21:35','Patch Set 1: Code-Review+1',537,1,537,'bada0100_f93dabbc',NULL),(29,'2015-05-01 09:58:38','Patch Set 2: Code-Review+2',538,2,538,'bada0100_24ab0a8b',NULL),(16,'2015-04-30 18:38:20','Patch Set 2: Code-Review+1',538,2,538,'bada0100_6437d2b1',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 2.',538,2,538,'bada0100_84d51645',NULL),(37,'2015-04-30 12:32:00','Uploaded patch set 1.',538,1,538,'bada0100_99025fb3',NULL),(16,'2015-04-30 12:33:55','Patch Set 1: Code-Review+1',538,1,538,'bada0100_b9ff23aa',NULL),(29,'2015-05-01 09:58:41','Change has been successfully merged into the git repository.',538,2,538,'bada0100_e4942246',NULL),(16,'2015-04-30 16:53:38','Uploaded patch set 3.',539,3,539,'bada0100_04acc6ec',NULL),(16,'2015-04-30 13:45:22','Patch Set 1:\n\n> (3 comments)\n > \n > I don\'t like that we\'re doing this. I\'m not sure that the people\n > it\'s for want it to unpack the dependencies of partial deployments\n > and it lacks a test suite, so it has an increased likelihood of\n > being broken if someone tries to use it after we change something.\n > \n > However, it breaking later actually works for me, since hopefully\n > we\'ll have made deployment faster by then, so this won\'t be needed,\n > and we can just rip the code out.\n\nIf they don\'t want the dependencies it should be easy to change it so they aren\'t unpacked. I didn\'t do that for now though since that seems even more likely to have bad results when the \"partial deployment\" is applied to a working system.',539,1,539,'bada0100_19abcf8a',NULL),(37,'2015-04-30 13:32:00','Patch Set 1: Code-Review+1\n\n(3 comments)\n\nI don\'t like that we\'re doing this. I\'m not sure that the people it\'s for want it to unpack the dependencies of partial deployments and it lacks a test suite, so it has an increased likelihood of being broken if someone tries to use it after we change something.\n\nHowever, it breaking later actually works for me, since hopefully we\'ll have made deployment faster by then, so this won\'t be needed, and we can just rip the code out.',539,1,539,'bada0100_19b42ff1',NULL),(37,'2015-04-30 17:06:12','Change has been successfully rebased as 1d57b196b793b9a332dd969295001e0e36617254',539,3,539,'bada0100_247c6a72',NULL),(16,'2015-04-30 13:10:24','Uploaded patch set 1.',539,1,539,'bada0100_392b3332',NULL),(16,'2015-04-30 14:17:09','Uploaded patch set 2.',539,2,539,'bada0100_399ed357',NULL),(37,'2015-04-30 13:32:38','Patch Set 1:\n\nOh, I see there\'s a follow up patch to add a test.',539,1,539,'bada0100_39b9f3e9',NULL),(37,'2015-04-30 15:24:55','Patch Set 2: Code-Review+1',539,2,539,'bada0100_39ed738c',NULL),(37,'2015-04-30 17:06:08','Patch Set 3: Code-Review+2',539,3,539,'bada0100_64827254',NULL),(37,'2015-04-30 17:06:11','Patch Set 4: Patch Set 3 was rebased',539,3,539,'bada0100_84875661',NULL),(37,'2015-04-30 13:19:47','Patch Set 1:\n\n(1 comment)',539,1,539,'bada0100_99f01fcb',NULL),(29,'2015-04-30 15:40:41','Patch Set 2: Code-Review-1\n\nTesting',539,2,539,'bada0100_b98f23cc',NULL),(16,'2015-04-30 13:47:41','Patch Set 1:\n\n(1 comment)',539,1,539,'bada0100_d9946746',NULL),(37,'2015-04-30 17:06:42','Change has been successfully merged into the git repository.',540,4,540,'bada0100_049366a4',NULL),(37,'2015-04-30 17:06:33','Patch Set 4: Patch Set 3 was rebased',540,3,540,'bada0100_44816e49',NULL),(16,'2015-04-30 16:53:38','Uploaded patch set 3.',540,3,540,'bada0100_a4b85a2b',NULL),(37,'2015-04-30 13:39:26','Patch Set 1: Code-Review+1\n\n(3 comments)\n\nThere\'s a bug in a bit you aren\'t directly using, so either fix it or remove the dead code.\n\nThe test suite also doesn\'t completely cover what you claim to support in code, but I care little for keeping it working.',540,1,540,'bada0100_b9c40360',NULL),(37,'2015-04-30 15:24:59','Patch Set 2: Code-Review+1',540,2,540,'bada0100_d901c73a',NULL),(16,'2015-04-30 13:10:24','Uploaded patch set 1.',540,1,540,'bada0100_d91f8708',NULL),(16,'2015-04-30 14:17:09','Uploaded patch set 2.',540,2,540,'bada0100_d9a2279a',NULL),(37,'2015-04-30 17:06:40','Patch Set 4: Code-Review+2',540,4,540,'bada0100_e4950289',NULL),(39,'2015-04-30 16:14:47','Patch Set 3:\n\n(2 comments)\n\nThank you for your comments; I have no objection to merging this as-is unless anyone else does',541,3,541,'bada0100_19442f73',NULL),(NULL,'2015-04-30 16:15:52','The change could not be merged due to a path conflict.\n\nPlease rebase the change locally and upload the rebased commit for review.',541,3,541,'bada0100_3949f38b',NULL),(16,'2015-04-30 15:07:09','Patch Set 3: Code-Review+1\n\nThis seems like a useful command to have, thanks!',541,3,541,'bada0100_398813e7',NULL),(29,'2015-04-30 14:56:25','Patch Set 1:\n\n(1 comment)',541,1,541,'bada0100_5912b7b5',NULL),(16,'2015-04-30 14:48:44','Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThis looks pretty much OK to me, but sadly ./check doesn\'t pass! You\'ll need to add morphlib/plugins/show_build_log_plugin.py to without-test-modules to fix that.',541,2,541,'bada0100_592b97eb',NULL),(39,'2015-04-30 14:40:41','Uploaded patch set 2.',541,2,541,'bada0100_7909bb94',NULL),(29,'2015-04-30 13:56:10','Patch Set 1:\n\n(1 comment)',541,1,541,'bada0100_798d3b31',NULL),(37,'2015-04-30 16:18:38','Change has been successfully merged into the git repository.',541,4,541,'bada0100_9957bf26',NULL),(39,'2015-04-30 13:52:24','Uploaded patch set 1.',541,1,541,'bada0100_b99ba371',NULL),(39,'2015-04-30 14:59:53','Uploaded patch set 3.',541,3,541,'bada0100_d925470b',NULL),(39,'2015-04-30 14:54:31','Patch Set 2:\n\n(1 comment)\n\nAdded show_build_log_plugin to without-test-modules, and modified logic to check that cache_key exists, rather than if it isn\'t None',541,2,541,'bada0100_d93ea729',NULL),(39,'2015-04-30 16:18:00','Uploaded patch set 4.',541,4,541,'bada0100_d95d474a',NULL),(39,'2015-04-30 14:02:21','Patch Set 1:\n\n(1 comment)',541,1,541,'bada0100_d97b0728',NULL),(37,'2015-04-30 16:18:35','Patch Set 4: Code-Review+2',541,4,541,'bada0100_f95a8b4f',NULL),(37,'2015-04-30 16:03:09','Patch Set 3: Code-Review+2\n\n(2 comments)\n\nYou might get some more performance out of using shutil.copyfileobj to get the build log out.',541,3,541,'bada0100_f9736be5',NULL),(15,'2015-05-13 12:21:44','Patch Set 2: Patch Set 1 was rebased',542,1,542,'bada0100_77045f7e',NULL),(6,'2015-05-06 09:15:19','Patch Set 1: Code-Review+1\n\nGood idea',542,1,542,'bada0100_7fcc3b36',NULL),(15,'2015-05-13 12:21:44','Change has been successfully rebased as c15e0ed7b6912d014afb753441526c762178aa8d',542,1,542,'bada0100_9709c397',NULL),(15,'2015-04-30 14:18:45','Uploaded patch set 1.',542,1,542,'bada0100_99ac9f8e',NULL),(8,'2015-05-12 09:27:59','Patch Set 1: Code-Review+2',542,1,542,'bada0100_c52b1893',NULL),(29,'2015-05-05 07:05:35','Change has been successfully rebased as 573fc7780fe411b36f8b14101babc68cb4f61df7',543,1,543,'bada0100_1f0f2fe3',NULL),(29,'2015-05-05 07:05:32','Patch Set 1: Code-Review+2',543,1,543,'bada0100_5f05b7c0',NULL),(29,'2015-05-05 07:05:34','Patch Set 2: Patch Set 1 was rebased',543,1,543,'bada0100_7f0afbd3',NULL),(15,'2015-05-01 10:52:38','Patch Set 1: Code-Review+1',543,1,543,'bada0100_84bbd6c3',NULL),(35,'2015-05-01 14:36:54','Patch Set 1: Code-Review+1\n\nLooks ok to me',543,1,543,'bada0100_a42e1aa4',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',543,1,543,'bada0100_b9540322',NULL),(29,'2015-05-05 06:58:09','Patch Set 1: Code-Review+1\n\n(1 comment)',543,1,543,'bada0100_bf686388',NULL),(15,'2015-05-01 10:46:24','Patch Set 1: Code-Review+1',544,1,544,'bada0100_2499ca6e',NULL),(29,'2015-05-05 07:26:58','Patch Set 2: Code-Review+2',544,2,544,'bada0100_3f1473f4',NULL),(29,'2015-05-01 07:09:08','Patch Set 1: Code-Review+1',544,1,544,'bada0100_445deee8',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',544,1,544,'bada0100_5931570a',NULL),(7,'2015-05-01 15:31:08','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nIt looks Ok, I haven\'t tested swift though, but it should work. Nitpick - see my comment :P',544,1,544,'bada0100_5f829753',NULL),(29,'2015-05-05 07:27:09','Patch Set 3: Code-Review+2',544,3,544,'bada0100_9f023fb3',NULL),(29,'2015-05-05 07:27:11','Change has been successfully merged into the git repository.',544,3,544,'bada0100_bfff03aa',NULL),(8,'2015-05-01 15:36:47','Patch Set 2: Commit message was updated',544,2,544,'bada0100_df952789',NULL),(NULL,'2015-05-05 07:27:00','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I51be0894, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',544,2,544,'bada0100_dff8c7c6',NULL),(29,'2015-05-05 07:27:06','Patch Set 3: Patch Set 2 was rebased',544,2,544,'bada0100_fff58bcb',NULL),(29,'2015-05-05 07:31:20','Patch Set 2: Patch Set 1 was rebased',545,1,545,'bada0100_1f264f69',NULL),(29,'2015-05-05 07:31:23','Patch Set 2: Code-Review+2',545,2,545,'bada0100_3f2b1332',NULL),(15,'2015-05-01 10:47:15','Patch Set 1: Code-Review+1',545,1,545,'bada0100_449e4e58',NULL),(29,'2015-05-05 07:31:15','Patch Set 1: Code-Review+2',545,1,545,'bada0100_5f2cd74a',NULL),(29,'2015-05-01 07:22:34','Patch Set 1: Code-Review+1\n\n(1 comment)',545,1,545,'bada0100_640592c1',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',545,1,545,'bada0100_79369b05',NULL),(NULL,'2015-05-05 07:31:17','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I97468e5e, however the current patch set is 3.\n* Depends on commit 908cfadcb33cf28c62d1cf4b3acb97960bbfe846 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',545,1,545,'bada0100_7f319ba1',NULL),(29,'2015-05-05 07:31:25','Change has been successfully merged into the git repository.',545,2,545,'bada0100_df1f6708',NULL),(15,'2015-05-01 10:50:18','Patch Set 1: Code-Review+1\n\n(1 comment)',546,1,546,'bada0100_04a0468f',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',546,1,546,'bada0100_193bcfec',NULL),(29,'2015-05-05 07:34:08','Change has been successfully merged into the git repository.',546,2,546,'bada0100_5fd37738',NULL),(29,'2015-05-05 07:34:04','Patch Set 2: Patch Set 1 was rebased',546,1,546,'bada0100_9f19df24',NULL),(29,'2015-05-01 07:12:06','Patch Set 1: Code-Review+1',546,1,546,'bada0100_a46b7a84',NULL),(29,'2015-05-05 07:34:06','Patch Set 2: Code-Review+2',546,2,546,'bada0100_bf1623f0',NULL),(29,'2015-05-05 07:34:01','Patch Set 1: Code-Review+2',546,1,546,'bada0100_ff1cab15',NULL),(29,'2015-05-05 07:35:51','Patch Set 2: Code-Review+2',547,2,547,'bada0100_1fddef42',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',547,1,547,'bada0100_39401356',NULL),(29,'2015-05-05 07:35:53','Change has been successfully merged into the git repository.',547,2,547,'bada0100_3fe23304',NULL),(29,'2015-05-05 07:35:49','Patch Set 2: Patch Set 1 was rebased',547,1,547,'bada0100_7fd8bb53',NULL),(29,'2015-05-01 07:34:23','Patch Set 1: Code-Review+1',547,1,547,'bada0100_840af6d0',NULL),(15,'2015-05-01 10:50:39','Patch Set 1: Code-Review+1',547,1,547,'bada0100_a4acda8d',NULL),(7,'2015-05-01 10:56:33','Patch Set 1:\n\nwell, I think we should do something neater than using different names for the same thing in different strata and using different repositories.\n\nI think that adding stuff to cxmanage stratum is not a problem, but I may be wrong',548,1,548,'bada0100_04c7e646',NULL),(7,'2015-05-07 21:51:23','Patch Set 2: Commit message was updated',548,2,548,'bada0100_6a2b1bec',NULL),(7,'2015-05-08 10:13:49','Patch Set 3: Patch Set 2 was rebased',548,2,548,'bada0100_6a4a3b85',NULL),(7,'2015-05-07 21:52:11','Patch Set 2: Code-Review+1\n\nI\'ve fixed a couple of typos in the commit message. The change looks sensible to me as well',548,2,548,'bada0100_8a30bf57',NULL),(7,'2015-05-08 10:13:55','Patch Set 3: Code-Review+2',548,3,548,'bada0100_8a4f5f92',NULL),(7,'2015-05-01 08:07:28','Patch Set 1:\n\nNot sure what to vote. They are the same source, but different versions and different repositories in g.b.o. I\'d prefer if we can use the same repo/ref in both, and move it to python-common or similar.',548,1,548,'bada0100_a4029ab2',NULL),(7,'2015-05-08 10:17:47','Change has been successfully merged into the git repository.',548,3,548,'bada0100_aa57c325',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',548,1,548,'bada0100_d92467c8',NULL),(6,'2015-05-05 10:17:29','Patch Set 1: Code-Review+1\n\nLooks sensible.\n\n > At this point, given Calxeda died, do we need to maintain the\n > cxmanage systems at all?\n\nWe still have users of Baserock who are tied to using Calxeda hardware, so yes.',548,1,548,'bada0100_dfcd2788',NULL),(29,'2015-05-05 07:44:07','Patch Set 1:\n\nThis seems to be a nice demonstration of why we don\'t want globally scoped definitions.',548,1,548,'bada0100_dfe68716',NULL),(8,'2015-05-01 08:59:14','Patch Set 1:\n\n> Not sure what to vote. They are the same source, but different\n > versions and different repositories in g.b.o. I\'d prefer if we can\n > use the same repo/ref in both, and move it to python-common or\n > similar.\n\nYeah, I though to do that, but then, we will add a lot of not needed python packages to cxmanager.\nIf you think that this is not a problem I can rework this patch.',548,1,548,'bada0100_e41f4208',NULL),(32,'2015-05-01 10:55:01','Patch Set 1:\n\nAt this point, given Calxeda died, do we need to maintain the cxmanage systems at all?',548,1,548,'bada0100_e4c9825b',NULL),(29,'2015-05-01 07:36:18','Patch Set 1: Code-Review+1',549,1,549,'bada0100_240f8ae3',NULL),(7,'2015-05-08 10:14:00','Patch Set 2: Patch Set 1 was rebased',549,1,549,'bada0100_2a443373',NULL),(7,'2015-05-08 10:14:03','Patch Set 2: Code-Review+2',549,2,549,'bada0100_4a49778a',NULL),(15,'2015-05-01 10:51:59','Patch Set 1: Code-Review+1',549,1,549,'bada0100_c4a9de7c',NULL),(7,'2015-05-01 08:15:53','Patch Set 1: Code-Review+1\n\nLooks OK',549,1,549,'bada0100_c4ff9ea9',NULL),(7,'2015-05-08 10:17:50','Change has been successfully merged into the git repository.',549,2,549,'bada0100_ca548723',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',549,1,549,'bada0100_f9212bb5',NULL),(7,'2015-05-08 10:17:41','Patch Set 2: Code-Review+2\n\nIn that case, I\'m happy with this change being merged.',550,2,550,'bada0100_0a5b6f55',NULL),(15,'2015-05-01 10:52:18','Patch Set 1: Code-Review+1',550,1,550,'bada0100_64b6f2de',NULL),(28,'2015-05-08 09:25:12','Patch Set 1: Code-Review+1\n\nI did a `git diff 2014.1.1 2014.1.3 -- requirements.txt` for the OpenStack components that are being updated in this patch, and verified that the differences in dependencies are compliant with the versions that we have in Baserock.\n\nI also tested this change for one-node, two-node and three-node OpenStack systems.\n\nLooking at [1] and [2], there are several bugs fixed and security issues resolved in this update.\n\nThat said, I think this update is worth the risk and I\'m +1 it.\n\n[1]: https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.2\n[2]: https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.3',550,1,550,'bada0100_6a123bb6',NULL),(7,'2015-05-08 10:17:52','Change has been successfully merged into the git repository.',550,2,550,'bada0100_6a31db0a',NULL),(28,'2015-05-08 09:28:11','Patch Set 1:\n\n> I did a `git diff 2014.1.1 2014.1.3 -- requirements.txt` for the\n > OpenStack components that are being updated in this patch, and\n > verified that the differences in dependencies are compliant with\n > the versions that we have in Baserock.\n > \n > I also tested this change for one-node, two-node and three-node\n > OpenStack systems.\n > \n > Looking at [1] and [2], there are several bugs fixed and security\n > issues resolved in this update.\n > \n > That said, I think this update is worth the risk and I\'m +1 it.\n > \n > [1]: https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.2\n > [2]: https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.3\n\nOps, I should have done `git diff 2014.2.1 2014.2.3 -- requirements.txt`, instead of `git diff 2014.1.1 2014.1.3 -- requirements.txt`. But as this changes worked fine for me, I am still +1 it.',550,1,550,'bada0100_8a175fa3',NULL),(8,'2015-04-30 16:19:13','Uploaded patch set 1.',550,1,550,'bada0100_992edfa4',NULL),(7,'2015-05-07 21:49:02','Patch Set 1: Code-Review-1\n\nI know this has been tested, but after looking through the dependencies of some OpenStack components, I know how frequently the versions of these dependencies can change. I don\'t think we have checked all the versions of them for this upgrade, and I think we should.',550,1,550,'bada0100_caeec7b4',NULL),(7,'2015-05-08 10:17:05','Patch Set 2: Patch Set 1 was rebased',550,1,550,'bada0100_ea5dcb49',NULL),(34,'2015-04-30 16:34:36','Uploaded patch set 1.',551,1,551,'bada0100_0437e6e4',NULL),(15,'2015-05-01 10:09:42','Patch Set 1: Code-Review+2',551,1,551,'bada0100_24822a01',NULL),(15,'2015-05-01 10:09:44','Change has been successfully merged into the git repository.',551,1,551,'bada0100_44872e10',NULL),(29,'2015-05-01 07:03:13','Patch Set 1: Code-Review+1',551,1,551,'bada0100_c451ded9',NULL),(7,'2015-05-11 15:07:29','Patch Set 5: Code-Review+1\n\nThis looks ok now that the latest release knows about this new architecture.',554,5,554,'bada0100_053cc02e',NULL),(15,'2015-05-06 17:57:06','Uploaded patch set 2.',554,2,554,'bada0100_2a09932c',NULL),(15,'2015-05-12 10:44:59','Uploaded patch set 6.',554,6,554,'bada0100_3720179b',NULL),(15,'2015-05-01 10:53:59','Patch Set 1:\n\n> Adding this will prevent Morph from baserock-15.17-rc from building\n > \'master\' of definitions. I\'d be fine with it being merged in a\n > branch, but I don\'t want it in \'master\' until we have done a\n > release.\n\n\nYeah, sorry, forgot to -2 this until the new release is out',554,1,554,'bada0100_44b5eecb',NULL),(15,'2015-05-08 15:31:30','Uploaded patch set 5.',554,5,554,'bada0100_659b4cca',NULL),(15,'2015-05-12 14:19:03','Patch Set 7: Code-Review+2',554,7,554,'bada0100_77053fc1',NULL),(6,'2015-05-11 15:15:00','Patch Set 5: Code-Review+1\n\nWe can merge this now 15.19 is released. Looks fine.',554,5,554,'bada0100_851750a3',NULL),(8,'2015-05-12 09:22:13','Patch Set 5:\n\n(1 comment)',554,5,554,'bada0100_85367002',NULL),(15,'2015-05-12 14:19:06','Change has been successfully merged into the git repository.',554,7,554,'bada0100_970a23d1',NULL),(15,'2015-05-08 15:19:20','Uploaded patch set 4.',554,4,554,'bada0100_a56134d5',NULL),(15,'2015-05-06 18:25:48','Uploaded patch set 3.',554,3,554,'bada0100_aa1ca36b',NULL),(15,'2015-05-12 14:07:07','Uploaded patch set 7.',554,7,554,'bada0100_b76ba784',NULL),(15,'2015-04-30 16:47:44','Uploaded patch set 1.',554,1,554,'bada0100_c45ebe12',NULL),(8,'2015-05-12 10:49:07','Patch Set 6: Code-Review+1',554,6,554,'bada0100_d730abea',NULL),(6,'2015-05-01 07:09:53','Patch Set 1: Code-Review-2\n\nAdding this will prevent Morph from baserock-15.17-rc from building \'master\' of definitions. I\'d be fine with it being merged in a branch, but I don\'t want it in \'master\' until we have done a release.',554,1,554,'bada0100_e4718278',NULL),(15,'2015-05-06 17:57:37','Topic changed from wedge_system to openbmc_aspeed',554,2,554,'bada0100_ea12ab57',NULL),(6,'2015-05-01 07:10:02','Patch Set 1: Code-Review-2\n\nAdding this will prevent Morph from baserock-15.17-rc from building \'master\' of definitions. I\'d be fine with it being merged in a branch, but I don\'t want it in \'master\' until we have done a release.',555,1,555,'bada0100_046fe693',NULL),(15,'2015-05-06 17:57:47','Topic changed from wedge_system to openbmc_aspeed',555,2,555,'bada0100_0a104f4d',NULL),(15,'2015-05-12 10:40:24','Patch Set 5: Code-Review-2',555,5,555,'bada0100_1710734d',NULL),(15,'2015-05-01 10:53:42','Patch Set 1:\n\n> Adding this will prevent Morph from baserock-15.17-rc from building\n > \'master\' of definitions. I\'d be fine with it being merged in a\n > branch, but I don\'t want it in \'master\' until we have done a\n > release.\n\nYeah, sorry, forgot to -2 this until the new release is out',555,1,555,'bada0100_24b0eadc',NULL),(15,'2015-05-12 14:19:22','Patch Set 7: Code-Review+2',555,7,555,'bada0100_370fb7e3',NULL),(8,'2015-05-12 09:24:41','Patch Set 5:\n\n(1 comment)',555,5,555,'bada0100_45408856',NULL),(15,'2015-05-06 17:57:06','Uploaded patch set 2.',555,2,555,'bada0100_4a0e5736',NULL),(15,'2015-05-12 14:19:26','Change has been successfully merged into the git repository.',555,7,555,'bada0100_5714bbf4',NULL),(15,'2015-05-12 10:44:59','Uploaded patch set 6.',555,6,555,'bada0100_57259ba9',NULL),(15,'2015-04-30 16:47:44','Uploaded patch set 1.',555,1,555,'bada0100_649b52ca',NULL),(8,'2015-05-12 10:53:03','Patch Set 6: Code-Review+1',555,6,555,'bada0100_774d3f72',NULL),(15,'2015-05-08 15:31:30','Uploaded patch set 5.',555,5,555,'bada0100_85a0b0f5',NULL),(7,'2015-05-11 15:09:57','Patch Set 5:\n\nThis looks ok to me, although I\'d prefer if it had the same configuration-extension list as the other minimal systems',555,5,555,'bada0100_a54854cd',NULL),(6,'2015-05-11 15:14:28','Patch Set 5: Code-Review+1\n\nWe can merge this now 15.19 is released. Looks fine but I agree with Pedro\'s comment.',555,5,555,'bada0100_c54558b4',NULL),(15,'2015-05-08 15:19:20','Uploaded patch set 4.',555,4,555,'bada0100_c55eb812',NULL),(15,'2015-05-06 18:25:48','Uploaded patch set 3.',555,3,555,'bada0100_ca19e77a',NULL),(15,'2015-05-12 14:07:07','Uploaded patch set 7.',555,7,555,'bada0100_d768ab89',NULL),(15,'2015-05-12 10:40:14','Patch Set 5: Code-Review-1\n\nThanks for the reviews.\n\nI will update this patch to upgrade the definitions format as well to version 3, as we are using the new architecture here',555,5,555,'bada0100_f7128f57',NULL),(15,'2015-05-12 10:45:22','Patch Set 6: -Code-Review',555,6,555,'bada0100_f7392fd9',NULL),(15,'2015-05-01 14:35:16','Patch Set 3: Patch Set 2 was rebased',556,2,556,'bada0100_243b0aed',NULL),(6,'2015-05-01 07:08:57','Patch Set 1: Code-Review+1\n\nPersonally I format the description field like a Git commit message because I think it looks neater.\n\nAlso, I think this is worded better: \"The resulting image can be copied to a USB and booted from there, as well as in a virtual machine.\"',556,1,556,'bada0100_2458eaf9',NULL),(7,'2015-05-01 08:32:45','Patch Set 1:\n\n+2 If you fix Sam\'s comments',556,1,556,'bada0100_442bae30',NULL),(15,'2015-05-01 14:35:16','Change has been successfully rebased as fd85a8d8fd618b25582c1814481c0a76f86492be',556,2,556,'bada0100_44408e56',NULL),(35,'2015-05-01 12:22:36','Patch Set 2:\n\nI missed out the INITRAMFS thing, will test this again later',556,2,556,'bada0100_44888ee7',NULL),(15,'2015-05-01 14:35:11','Patch Set 2: Code-Review+2',556,2,556,'bada0100_84367602',NULL),(15,'2015-05-01 10:18:49','Patch Set 2:\n\n> I\'m assuming there\'s some further steps you need to document for\n > this to work? How will just adding an initramfs work?\n >\n > Also tried this and it failed to mount the rootfs, is it trying to\n > mount /dev/sda?\n\nIt just work, at least here\nSteps:\n1. build weston-system-x86_64-generic system\n2. build initramfs-x86_64 system\n3. deploy weston-system-x86_64-generic-deploy\n4. dd the generated image to a USB stick\n\nMaybe you forgot step 2?',556,2,556,'bada0100_84943638',NULL),(15,'2015-05-01 10:14:34','Uploaded patch set 2.',556,2,556,'bada0100_a475ba33',NULL),(35,'2015-05-01 14:28:14','Patch Set 2: Code-Review+1',556,2,556,'bada0100_c4547e23',NULL),(15,'2015-04-30 16:59:52','Uploaded patch set 1.',556,1,556,'bada0100_c4b55e32',NULL),(35,'2015-05-01 09:23:50','Patch Set 1: Code-Review-1\n\nI\'m assuming there\'s some further steps you need to document for this to work? How will just adding an initramfs work?\n\nAlso tried this and it failed to mount the rootfs, is it trying to mount /dev/sda?',556,1,556,'bada0100_e4cd0288',NULL),(15,'2015-05-01 12:10:17','Patch Set 2: Patch Set 1 was rebased',558,1,558,'bada0100_04f5a682',NULL),(7,'2015-05-01 08:31:11','Patch Set 1: Code-Review+1\n\nThe size for the initramfs images is only 2.9M thanks to Richard Maw :)',558,1,558,'bada0100_2426aa69',NULL),(6,'2015-05-01 07:07:20','Patch Set 1: Code-Review+1\n\nany idea how much size this adds to the released images? I think that because we don\'t do any debug stripping it\'s be quite a lot. Also, why not add this for the x86_32 images as well? anyway, i\'m in favour making things bootable on real hardware.',558,1,558,'bada0100_8463d6b0',NULL),(15,'2015-04-30 17:12:00','Uploaded patch set 1.',558,1,558,'bada0100_a48ffa74',NULL),(15,'2015-05-01 12:10:17','Change has been successfully rebased as 3678828f375d309463c4d756a11957a028296d47',558,1,558,'bada0100_a4f13a97',NULL),(15,'2015-05-01 12:11:14','Patch Set 2:\n\n> any idea how much size this adds to the released images? I think\n > that because we don\'t do any debug stripping it\'s be quite a lot.\n > Also, why not add this for the x86_32 images as well? anyway, i\'m\n > in favour making things bootable on real hardware.\n\nBasically because there is not initramfs-x86_32 at the moment. I can add it later if there is demand for it',558,2,558,'bada0100_c4eebeb4',NULL),(15,'2015-05-01 12:10:12','Patch Set 1: Code-Review+2',558,1,558,'bada0100_e4f7428b',NULL),(29,'2015-05-01 10:13:22','Patch Set 2: Code-Review+1',559,2,559,'bada0100_0479262f',NULL),(37,'2015-05-01 11:03:56','Patch Set 2: Code-Review+2',559,2,559,'bada0100_64dd9214',NULL),(37,'2015-05-01 11:04:02','Change has been successfully merged into the git repository.',559,2,559,'bada0100_84e2f6d3',NULL),(37,'2015-04-30 18:00:17','Uploaded patch set 2.',559,2,559,'bada0100_a4bdba04',NULL),(37,'2015-04-30 17:59:30','Uploaded patch set 1.',559,1,559,'bada0100_a4e61a43',NULL),(15,'2015-06-02 15:34:25','Abandoned\n\nAbandon as I do not have immediate plans to use this in baserock systems',560,1,560,'5aaae553_05a5b203',NULL),(29,'2015-06-02 15:33:11','Patch Set 1: Code-Review-1\n\nIt\'s probably for the best if lorry requests are sent only after a clear plan/implementation has been made.\n\nUnless there are serious plans to use this for initramfs generation \nthen I suggest we abandon it.',560,1,560,'5aaae553_65a026f5',NULL),(15,'2015-04-30 21:49:19','Uploaded patch set 1.',560,1,560,'bada0100_44464e25',NULL),(6,'2015-05-01 07:05:20','Patch Set 1: Code-Review+1',560,1,560,'bada0100_645ef2eb',NULL),(37,'2015-05-13 14:02:22','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nPedro Alvarez: We have a deliberately minimal initramfs, as the only thing we need it to do is to reliably mount the root disk by UUID or label, and if my shutdownramfs patches get merged, unmount it cleanly again.\n\nOne argument for Dracut is allow us to have a way to support the more complicated cases.\n\nHowever, what we currently do to make an initramfs is build a system with morph, and Dracut, as it is used in traditional distributions, takes over this role.\n\nBefore I\'d +1 a lorry to include Dracut, I\'d need to see a proposal for how it\'s going to work with our model.',560,1,560,'bada0100_b74887cd',NULL),(7,'2015-05-08 10:10:24','Patch Set 1:\n\nWhat are your plans for this. Don\'t we have already a initramfs system?',560,1,560,'bada0100_ea762bd8',NULL),(15,'2015-05-14 10:39:04','Patch Set 1:\n\n(1 comment)\n\nI though it would be a good idea to use what appears to be the upstream choice (for a lot of distros) to generate initramfs instead write our own.\nI was planning to play with it at some point when I have some free time, I can not promise any schelude',560,1,560,'bada0100_f724cfc7',NULL),(37,'2015-05-27 15:40:13','Patch Set 1:\n\n(1 comment)',560,1,560,'fab9d9a7_2acf5fb2',NULL),(7,'2015-05-01 13:26:18','Uploaded patch set 1.',561,1,561,'bada0100_048606ba',NULL),(7,'2015-05-01 15:12:29','Uploaded patch set 2.',561,2,561,'bada0100_1f6e4fca',NULL),(24,'2015-05-01 14:13:32','Patch Set 1: Code-Review+1\n\nI\'ve just tried this patch and I confirm that it fixes the problem',561,1,561,'bada0100_24446a73',NULL),(15,'2015-05-01 15:09:57','Patch Set 1: Code-Review-1\n\n(1 comment)',561,1,561,'bada0100_5f74d79b',NULL),(15,'2015-05-01 15:14:36','Change has been successfully rebased as e59372229e39549a97b8929208c5705ad827db99',561,2,561,'bada0100_9f61dfd5',NULL),(7,'2015-05-01 13:31:57','Patch Set 1:\n\nPLEASE, review properly',561,1,561,'bada0100_c48f9ecb',NULL),(15,'2015-05-01 15:14:33','Patch Set 2: Code-Review+2',561,2,561,'bada0100_df6767e9',NULL),(15,'2015-05-01 15:14:35','Patch Set 3: Patch Set 2 was rebased',561,2,561,'bada0100_ff64abe6',NULL),(15,'2015-05-01 14:36:17','Patch Set 1: Code-Review+1',562,1,562,'bada0100_042286b9',NULL),(26,'2015-05-01 13:43:53','Uploaded patch set 1.',562,1,562,'bada0100_44bbae72',NULL),(6,'2015-05-01 21:18:39','Patch Set 2: Patch Set 1 was rebased',562,1,562,'bada0100_5f5e17eb',NULL),(6,'2015-05-01 21:18:39','Change has been successfully rebased as 763a7efb36818224e514b3d58262b26317ac80ed',562,1,562,'bada0100_7f63dbb1',NULL),(6,'2015-05-01 21:18:36','Patch Set 1: Code-Review+2\n\nI think it looks neater to have the description field formatted like a Git commit message, but this is a big improvement anyway :)',562,1,562,'bada0100_bf5143da',NULL),(29,'2015-11-21 10:10:27','Patch Set 2:\n\n> > > Things that need fixing before we can merge this:\n > > > - strata/ntpd/ntpd.morph Creates a user and a group at\n > > > system-integration time\n > > > - vagrant.configure appends a line to /etc/passwd and to\n > > > /etc/group.\n > > >\n > > > I\'d prefer if we reach an agreement with everyone about how the\n > > > these users have to be created.\n > >\n > > Likely what is really needed here is some mechanism to\n > > declaratively define the users and groups in a system rather than\n > > with ad-hoc bits of shell or hacking it with install-files.\n > \n > Yeah, that was the idea, use systemd to create them:\n > http://www.freedesktop.org/software/systemd/man/sysusers.d.html\n > \n > (see previous comments)\n\nCool, we seem to have quite a lot of changes to make to the format,\nhopefully some of these will get implemented soon.',563,2,563,'1ae5cdf2_1bfffb02',NULL),(15,'2015-11-20 15:16:34','Patch Set 2:\n\n> > Things that need fixing before we can merge this:\n > > - strata/ntpd/ntpd.morph Creates a user and a group at\n > > system-integration time\n > > - vagrant.configure appends a line to /etc/passwd and to\n > > /etc/group.\n > >\n > > I\'d prefer if we reach an agreement with everyone about how the\n > > these users have to be created.\n > \n > Likely what is really needed here is some mechanism to\n > declaratively define the users and groups in a system rather than\n > with ad-hoc bits of shell or hacking it with install-files.\n\nYeah, that was the idea, use systemd to create them: http://www.freedesktop.org/software/systemd/man/sysusers.d.html\n\n(see previous comments)',563,2,563,'3ae8d1ca_1c2615bb',NULL),(29,'2015-11-20 13:44:45','Patch Set 2:\n\n> Things that need fixing before we can merge this:\n > - strata/ntpd/ntpd.morph Creates a user and a group at\n > system-integration time\n > - vagrant.configure appends a line to /etc/passwd and to\n > /etc/group.\n > \n > I\'d prefer if we reach an agreement with everyone about how the\n > these users have to be created.\n\nLikely what is really needed here is some mechanism to declaratively define the users and groups in a system rather than with ad-hoc bits of shell or hacking it with install-files.',563,2,563,'3ae8d1ca_fc19697a',NULL),(15,'2015-05-01 17:03:53','Uploaded patch set 2.',563,2,563,'bada0100_1f416f0b',NULL),(15,'2015-05-01 15:36:11','Uploaded patch set 1.',563,1,563,'bada0100_3f81d34a',NULL),(7,'2015-05-05 11:49:08','Patch Set 2: Code-Review-2\n\nAlso some chunks are creating users at system-integration time, before any configuration extension is run, this will override those users.',563,2,563,'bada0100_5fa137a8',NULL),(15,'2015-05-01 16:50:35','Patch Set 1:\n\n> This results in a system that you can no longer ssh into\n\nThanks for the review, I pretty sure we can make ssh to work without set a ssh user/group (is how it works in Arch at least). Will revert that for now and check our openssh config',563,1,563,'bada0100_7f3c3b94',NULL),(7,'2015-05-05 14:42:54','Patch Set 2:\n\nThings that need fixing before we can merge this:\n- strata/ntpd/ntpd.morph Creates a user and a group at system-integration time\n- vagrant.configure appends a line to /etc/passwd and to /etc/group.\n\nI\'d prefer if we reach an agreement with everyone about how the these users have to be created.',563,2,563,'bada0100_7fbbdbc4',NULL),(15,'2015-05-01 15:40:38','Patch Set 1:\n\nTested in a weston-system-x86_64-generic system: everything seems to work fine',563,1,563,'bada0100_bf8ce380',NULL),(15,'2015-05-05 14:38:29','Patch Set 2:\n\n> Also some chunks are creating users at system-integration time,\n > before any configuration extension is run, this will override those\n > users.\n\nOK, lets try to find the best solution for this then!\n\n15:25 pedroalvarez: about https://gerrit.baserock.org/#/c/563/ ; not sure touching systems files in random extensions is in general a good idea (vagrant.configure changes /etc/profile as well, apart from adding a system user)\n15:26 if a new system user is needed, maybe we should modify /usr/lib/sysusers.d/ instead?\n15:26 <•pedroalvarez> yes, that might be the right way to do it\n15:27 tiagogomes_: ah, whats the baserock installer?\n15:27 <•pedroalvarez> jjardon: I\'m not against a better solution, I\'m just against breaking the current solution\n15:29 pedroalvarez: sure, can you point in the review what extensions/chunks will break with the change?',563,2,563,'bada0100_ff9fcb4e',NULL),(35,'2015-05-01 15:47:14','Patch Set 1: Code-Review-1\n\nThis results in a system that you can no longer ssh into',563,1,563,'bada0100_ffc02b7e',NULL),(7,'2015-05-05 10:25:49','Patch Set 2: Code-Review-1\n\nI personally don\'t like this change. There is at least one configuration extension in definitons.git that creates an user by appending a line in /etc/passwd.',563,2,563,'bada0100_ffca6b6d',NULL),(43,'2015-05-08 10:51:01','Patch Set 3: Code-Review+1',564,3,564,'bada0100_0a228fb9',NULL),(28,'2015-05-01 17:10:22','Uploaded patch set 2.',564,2,564,'bada0100_3f46b324',NULL),(7,'2015-05-08 10:56:54','Patch Set 4: Patch Set 3 was rebased',564,3,564,'bada0100_6a18fb84',NULL),(7,'2015-05-08 09:57:52','Patch Set 3: Code-Review+1',564,3,564,'bada0100_6abc7b6d',NULL),(7,'2015-05-08 10:56:55','Change has been successfully rebased as 311537d3650cb106bacc852fed3ae16988ce5dbc',564,3,564,'bada0100_8a1d1f76',NULL),(7,'2015-05-08 09:55:16','Patch Set 2: Code-Review+1',564,2,564,'bada0100_8a651f47',NULL),(7,'2015-05-08 10:56:52','Patch Set 3: Code-Review+2',564,3,564,'bada0100_ca2b2793',NULL),(7,'2015-05-08 09:57:48','Patch Set 3: Patch Set 2 was rebased',564,2,564,'bada0100_ca8fa7cb',NULL),(28,'2015-05-01 15:45:38','Uploaded patch set 1.',564,1,564,'bada0100_dfc3e788',NULL),(8,'2015-05-12 09:30:27','Patch Set 1: Code-Review+1',568,1,568,'bada0100_65182c85',NULL),(37,'2015-05-13 14:03:31','Patch Set 2: Patch Set 1 was rebased',568,1,568,'bada0100_77121fb6',NULL),(6,'2015-05-05 13:53:33','Patch Set 1: Code-Review+1\n\nThanks!!',568,1,568,'bada0100_7f943b37',NULL),(37,'2015-05-13 14:03:32','Change has been successfully rebased as 6e210673394b36a7a5aad9c31bb619b5c5cbdb78',568,1,568,'bada0100_971783a3',NULL),(15,'2015-05-05 11:08:36','Uploaded patch set 1.',568,1,568,'bada0100_bfc4e35f',NULL),(37,'2015-05-13 14:03:27','Patch Set 1: Code-Review+2\n\nLooks ok to me, and I can\'t think of anything that this would break.',568,1,568,'bada0100_d7450bb4',NULL),(6,'2015-05-07 15:43:11','Patch Set 3: Code-Review+2\n\nThanks. In the interests of getting this in for the 15.19 release I\'ll merge it now.',569,3,569,'bada0100_0acb6f73',NULL),(6,'2015-05-05 14:12:56','Uploaded patch set 2.',569,2,569,'bada0100_1f996f6e',NULL),(6,'2015-05-07 15:01:42','Patch Set 3:\n\nGood point about sending a fake ID, the worst that happens is that the sender of the invalid build-request message will crash, but I think that\'s better than it running forever without giving the user any feedback.',569,3,569,'bada0100_6aba3be3',NULL),(6,'2015-05-05 13:01:19','Patch Set 1:\n\n(2 comments)\n\nI\'ll do a new version after lunch',569,1,569,'bada0100_7f8d1b31',NULL),(6,'2015-05-05 12:36:07','Uploaded patch set 1.',569,1,569,'bada0100_7fa67bc3',NULL),(29,'2015-05-05 12:58:27','Patch Set 1: Code-Review+1\n\n(2 comments)',569,1,569,'bada0100_9f9ebf62',NULL),(6,'2015-05-07 15:43:13','Patch Set 4: Patch Set 3 was rebased',569,3,569,'bada0100_aac7c363',NULL),(6,'2015-05-07 15:43:13','Change has been successfully rebased as 0b2b24a53316bee939d8921d8eb11254be7ce8a2',569,3,569,'bada0100_cac48761',NULL),(6,'2015-05-07 15:00:25','Uploaded patch set 3.',569,3,569,'bada0100_caed67f1',NULL),(29,'2015-05-05 14:32:32','Patch Set 2: Code-Review+1\n\n(1 comment)',569,2,569,'bada0100_dfa2079a',NULL),(32,'2015-05-07 15:04:08','Patch Set 3: Code-Review+1\n\nLooks good to me',569,3,569,'bada0100_eacdcb87',NULL),(32,'2015-05-06 08:44:51','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nIn general, +1, I support Richard\'s comment and there\'s a bogus whitespace cleanup which suggests a newer patch would be appreciated, but I wouldn\'t block merge on it.',569,2,569,'bada0100_ff226b00',NULL),(43,'2015-05-05 13:38:16','Uploaded patch set 1.',570,1,570,'bada0100_1f82cf00',NULL),(6,'2015-05-05 13:52:35','Change has been successfully merged into the git repository.',570,1,570,'bada0100_5f8ff723',NULL),(6,'2015-05-05 13:52:28','Patch Set 1: Code-Review+2',570,1,570,'bada0100_9f755f34',NULL),(6,'2015-05-05 13:52:34','Patch Set 1:\n\nThanks',570,1,570,'bada0100_bf72a347',NULL),(28,'2015-05-05 14:52:20','Uploaded patch set 1.',571,1,571,'bada0100_1fb08fdc',NULL),(7,'2015-05-08 10:19:06','Patch Set 2: Patch Set 1 was rebased',571,1,571,'bada0100_2a3bd3ec',NULL),(7,'2015-05-08 10:19:06','Change has been successfully rebased as f888f1d4639e1774f6fbb883fe11531a384ee87c',571,1,571,'bada0100_4a409756',NULL),(7,'2015-05-08 10:19:04','Patch Set 1: Code-Review+2',571,1,571,'bada0100_8a367f02',NULL),(15,'2015-05-05 14:55:55','Patch Set 1: Code-Review+1',571,1,571,'bada0100_dfc9a75b',NULL),(6,'2015-05-05 15:25:05','Patch Set 1: Code-Review+1\n\nI\'d rather you could keep delta/python-packages in alphabetical order! But OCD aside this looks fine',571,1,571,'bada0100_dfd0c7f9',NULL),(28,'2015-05-05 14:52:20','Uploaded patch set 1.',572,1,572,'bada0100_3fb553cd',NULL),(28,'2015-05-05 15:16:30','Patch Set 1:\n\n> Seems most distros use cdrkit instead\n > \n > cdrtools was forked for some license issues [1]\n > \n > [1] http://lists.debian.org/debian-devel-announce/2006/09/msg00002.html\n\nDoes it install a mkisofs binary? Are the command line options compatible?',572,1,572,'bada0100_3fec73c7',NULL),(28,'2015-05-08 17:18:39','Abandoned',572,1,572,'bada0100_85875061',NULL),(15,'2015-05-05 15:00:59','Patch Set 1: Code-Review-1\n\nSeems most distros use cdrkit instead\n\ncdrtools was forked for some license issues [1]\n\n[1] http://lists.debian.org/debian-devel-announce/2006/09/msg00002.html',572,1,572,'bada0100_ffc6eb48',NULL),(6,'2015-05-07 14:09:10','Patch Set 3: Code-Review+2\n\nThanks for the fix and thanks to everyone who tested it.',573,3,573,'bada0100_0a936fa4',NULL),(6,'2015-05-06 08:57:20','Patch Set 2: Code-Review+1\n\nApparently trove-setup doesn\'t work since commit aae1e3dec176ebc40cd233a29cf48c04d856fac5 (due to \'su\' not working correctly) and this fixes that issue.',573,2,573,'bada0100_1f5acf83',NULL),(41,'2015-05-06 11:58:07','Patch Set 2:\n\nIt works as described in the base-system. Please hold off on merging until I can try it with my genivi-demo-platform branch, though. There\'s still a possibility something may break there.',573,2,573,'bada0100_1f9f2f05',NULL),(6,'2015-05-05 15:10:24','Patch Set 2:\n\n(2 comments)\n\nLooks OK, but not tested and I have some comments.',573,2,573,'bada0100_1fe72fe6',NULL),(7,'2015-05-05 16:11:38','Patch Set 2:\n\n(2 comments)\n\nThanks for your comments. I\'m trying now to contact upstream to find a better way to do this.',573,2,573,'bada0100_3f031375',NULL),(32,'2015-05-06 13:36:08','Patch Set 3:\n\n(1 comment)',573,3,573,'bada0100_3f7233e6',NULL),(27,'2015-05-06 11:44:15','Patch Set 2: Code-Review+1',573,2,573,'bada0100_7f9afb15',NULL),(7,'2015-05-06 13:28:52','Uploaded patch set 3.',573,3,573,'bada0100_9fa9df26',NULL),(7,'2015-05-05 15:04:32','Uploaded patch set 1.',573,1,573,'bada0100_9fc31f38',NULL),(32,'2015-05-06 11:07:39','Patch Set 2:\n\n(1 comment)',573,2,573,'bada0100_9ffb1f47',NULL),(6,'2015-05-07 14:09:14','Patch Set 4: Patch Set 3 was rebased',573,3,573,'bada0100_aa8fc374',NULL),(7,'2015-05-06 13:30:09','Patch Set 3: Code-Review-2\n\nHolding possible merge until Jonathan tests this change with the GDP',573,3,573,'bada0100_bfa62352',NULL),(7,'2015-05-05 15:07:01','Uploaded patch set 2.',573,2,573,'bada0100_bfc0632b',NULL),(41,'2015-05-06 10:35:35','Patch Set 2:\n\n(1 comment)',573,2,573,'bada0100_bfe1439c',NULL),(41,'2015-05-07 10:04:54','Patch Set 3: Code-Review+1\n\nThis worked for me on my GENIVI Demo Platform branch.',573,3,573,'bada0100_ca47a74a',NULL),(6,'2015-05-07 14:09:15','Change has been successfully rebased as ef619b6115513dd36923c39190f907b55b0a4825',573,3,573,'bada0100_ca8c8782',NULL),(7,'2015-05-06 16:12:19','Patch Set 3:\n\n(1 comment)',573,3,573,'bada0100_df0be729',NULL),(7,'2015-05-07 14:07:49','Patch Set 3: -Code-Review\n\nRemoving my -2 now that Jonathan has tested it.',573,3,573,'bada0100_ea95cb88',NULL),(7,'2015-05-06 09:03:37','Patch Set 2:\n\nIndeed, I\'m going to send a second patch for this given some comments on IRC:\n\n I\'d rather we had static config that worked if the module was missing, rather than removing the config that uses the module at build time\n\n richard_maw: so, instead of removing the lines at system-integration time, modify them at post-install time to make selinux support optional\n\n if we can\'t upstream a change to make selinux optional, yes\n though I\'ll accept unconditionally making selinux optional, as we don\'t have the effort or a large enough stick to ask for proof that upstream won\'t take the change before accepting it as patched downstream',573,2,573,'bada0100_ff502b60',NULL),(6,'2015-05-07 14:10:28','Change has been successfully rebased as 42b915c2961c6fc72e08073cb98f9cbf7cb9c08a',574,1,574,'bada0100_2af3d30b',NULL),(29,'2015-05-06 08:10:57','Patch Set 1: Code-Review+1',574,1,574,'bada0100_5f1297b5',NULL),(16,'2015-05-06 14:50:22','Patch Set 1: Code-Review+1',574,1,574,'bada0100_5f4a9784',NULL),(6,'2015-05-07 14:10:25','Patch Set 1: Code-Review+2',574,1,574,'bada0100_6ae9db19',NULL),(6,'2015-05-07 14:10:28','Patch Set 2: Patch Set 1 was rebased',574,1,574,'bada0100_8aee7f21',NULL),(6,'2015-05-05 19:01:43','Uploaded patch set 1.',574,1,574,'bada0100_dff7678b',NULL),(32,'2015-05-06 08:41:43','Patch Set 1: Code-Review+1\n\nSeems a reasonable cleanup. Will this mean that initiators will have to upgrade lock-step with the controller+workers?',575,1,575,'bada0100_1f0c0f94',NULL),(6,'2015-05-06 08:49:09','Patch Set 1: Code-Review+2',575,1,575,'bada0100_1f83afcd',NULL),(6,'2015-05-06 08:49:12','Change has been successfully merged into the git repository.',575,1,575,'bada0100_3f88f3e6',NULL),(6,'2015-05-06 08:49:04','Patch Set 1:\n\n> Seems a reasonable cleanup. Will this mean that initiators will\n > have to upgrade lock-step with the controller+workers?\n\nInitiators have to upgrade lock-step with the controller+workers in any case, because the protocol was changed in the commit I referenced. The protocol.VERSION change means that users get a more helpful error.\n\nThanks for the review!',575,1,575,'bada0100_7f7e7be6',NULL),(29,'2015-05-06 08:06:07','Patch Set 1: Code-Review+1',575,1,575,'bada0100_bf45c3b4',NULL),(6,'2015-05-05 19:03:15','Uploaded patch set 1.',575,1,575,'bada0100_fff4ab88',NULL),(29,'2015-05-22 15:07:44','Change has been successfully rebased as 05b2b062afa2ab4cbd504735fd16cf53d969a2a5',576,2,576,'5ac10518_8d6b0185',NULL),(29,'2015-05-22 15:07:41','Patch Set 2: Code-Review+2',576,2,576,'5ac10518_cd710979',NULL),(29,'2015-05-22 15:07:43','Patch Set 3: Patch Set 2 was rebased',576,2,576,'5ac10518_ed6e4596',NULL),(29,'2015-05-21 15:18:19','Patch Set 2: Code-Review+1\n\nThis seems better to me',576,2,576,'7ac40928_2ef8c7e4',NULL),(37,'2015-05-20 14:21:58','Patch Set 2: Code-Review+1\n\n(2 comments)',576,2,576,'9adffdf1_12fe4a6c',NULL),(6,'2015-05-15 09:19:45','Patch Set 2:\n\n(1 comment)',576,2,576,'bada0100_1a489a2c',NULL),(16,'2015-05-13 13:29:00','Patch Set 1: Code-Review+1',576,1,576,'bada0100_9730e357',NULL),(6,'2015-05-05 19:12:21','Uploaded patch set 1.',576,1,576,'bada0100_9ff1df97',NULL),(6,'2015-05-14 16:42:42','Uploaded patch set 2.',576,2,576,'bada0100_da8c5282',NULL),(6,'2015-06-12 16:41:01','Patch Set 2:\n\n(1 comment)',577,2,577,'3a4c51b2_1c36f503',NULL),(6,'2015-06-12 17:05:52','Uploaded patch set 3.',577,3,577,'3a4c51b2_dc2bed92',NULL),(29,'2015-06-02 09:27:58','Patch Set 2: Code-Review+1',577,2,577,'5aaae553_c5123a58',NULL),(29,'2015-06-02 12:58:32','Patch Set 2:\n\n(1 comment)',577,2,577,'5aaae553_e53656e7',NULL),(16,'2015-05-13 14:53:07','Patch Set 1: Code-Review-1\n\n(1 comment)',577,1,577,'bada0100_7760df35',NULL),(6,'2015-05-14 16:42:42','Uploaded patch set 2.',577,2,577,'bada0100_7ae9a619',NULL),(6,'2015-05-05 19:12:21','Uploaded patch set 1.',577,1,577,'bada0100_bfee23b3',NULL),(6,'2015-06-16 16:29:34','Patch Set 4:\n\n> Let\'s merge this. I\'ll do the \'cwd\' fixup as a separate change to\n > avoid having to rebase the 3 dependent patches.\n\nI\'ve pushed the fix as a separate commit c933c6a5791b814996f64d09ba6589818ffab6e3 and tested it doesn\'t break building without a workspace',577,4,577,'da5c1566_59b9a3e8',NULL),(6,'2015-06-16 16:02:15','Patch Set 3: Code-Review+2\n\nLet\'s merge this. I\'ll do the \'cwd\' fixup as a separate change to avoid having to rebase the 3 dependent patches.',577,3,577,'da5c1566_996e9b95',NULL),(6,'2015-06-16 16:02:27','Change has been successfully rebased as 665ea01218dcba658d95b86014c7da5dd974a8a7',577,3,577,'da5c1566_d968138a',NULL),(6,'2015-06-16 16:02:26','Patch Set 4: Patch Set 3 was rebased',577,3,577,'da5c1566_f96b5783',NULL),(34,'2015-06-15 11:50:49','Patch Set 3: Code-Review+1\n\nSeems to work!',577,3,577,'fa57193c_3a74a19b',NULL),(6,'2015-06-15 14:40:22','Patch Set 3:\n\n(2 comments)',577,3,577,'fa57193c_5af875e5',NULL),(37,'2015-06-15 14:35:37','Patch Set 3:\n\n(1 comment)\n\nI\'m wrong, the implementation of the check for it being outside the repository is correct for its scope.\n\nIt\'s just the cwd that\'s missing functionality, and we don\'t expose that anywhere currently.',577,3,577,'fa57193c_9a920d9e',NULL),(29,'2015-06-15 07:46:03','Patch Set 3: Code-Review+1\n\nNote for anyone testing this, you may want to test from a fresh clone otherwise you will get an error when morph tries to\ncreate a ref in baserock/builds/foo/$uuid when foo is not a directory,\nwhich will be the case if you tested the previous version and you test this version in the same repo.',577,3,577,'fa57193c_ba127156',NULL),(37,'2015-06-15 14:02:25','Patch Set 3:\n\n(7 comments)\n\nI have a couple of nitpicks that won\'t hurt anything immediately so shouldn\'t block inclusion, but ought to be addressed promptly, before other code starts using the relative paths code, since it is thwartable.',577,3,577,'fa57193c_dab5a532',NULL),(37,'2015-06-15 14:47:59','Patch Set 3:\n\n(1 comment)',577,3,577,'fa57193c_dae3e531',NULL),(6,'2015-06-12 17:05:52','Uploaded patch set 3.',578,3,578,'3a4c51b2_3c181184',NULL),(6,'2015-06-12 16:42:02','Patch Set 2:\n\n(1 comment)',578,2,578,'3a4c51b2_bc2421c7',NULL),(29,'2015-06-02 09:33:01','Patch Set 2: Code-Review+1\n\n(2 comments)\n\nThank you for this long awaited change,\nand also for sorting out the build_plugin.\n\nThis looks fine to me, I\'ve tested it a little\nand it seems to work, I\'m very much looking forward\nto being able to build from a stand-alone definitions repo.\n\nA couple of the deployment yarns fail, but that\'s to\nbe expected at this point in the series.\n\nI think we could probably do with a couple of new yarns\nfor this use case too.',578,2,578,'5aaae553_e50f362d',NULL),(6,'2015-05-05 19:12:21','Uploaded patch set 1.',578,1,578,'bada0100_5f2b77eb',NULL),(6,'2015-05-14 16:42:42','Uploaded patch set 2.',578,2,578,'bada0100_9aeeca21',NULL),(6,'2015-06-16 16:03:49','Change has been successfully merged into the git repository.',578,5,578,'da5c1566_1931eba2',NULL),(6,'2015-06-16 16:03:46','Patch Set 5: Code-Review+2\n\nSeems I had to rebase anyway.',578,5,578,'da5c1566_392caf4a',NULL),(6,'2015-06-16 16:03:03','Patch Set 4: Code-Review+2',578,4,578,'da5c1566_790f47e2',NULL),(6,'2015-06-16 16:03:20','Patch Set 5: Patch Set 4 was rebased',578,4,578,'da5c1566_99f5fbcd',NULL),(NULL,'2015-06-16 16:03:12','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I52a898ef, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',578,4,578,'da5c1566_b9f8bfc5',NULL),(34,'2015-06-16 11:00:55','Patch Set 4: Code-Review+1',578,4,578,'da5c1566_f94a3754',NULL),(34,'2015-06-15 11:51:06','Patch Set 3: Code-Review+1',578,3,578,'fa57193c_1a79dd93',NULL),(34,'2015-06-15 14:14:22','Patch Set 3: -Code-Review\n\n> I don\'t 100% follow the changes to distbuild behaviour, but I trust\n > other reivewers that this hasn\'t regressed support there.\n\nI haven\'t tested this with distbuild (haven\'t done anything distbuild-related).',578,3,578,'fa57193c_1a871d63',NULL),(29,'2015-06-15 14:53:40','Patch Set 3:\n\n(1 comment)',578,3,578,'fa57193c_1ad55d43',NULL),(37,'2015-06-15 14:06:12','Patch Set 3:\n\nI don\'t 100% follow the changes to distbuild behaviour, but I trust other reivewers that this hasn\'t regressed support there.',578,3,578,'fa57193c_3a82e152',NULL),(29,'2015-06-15 14:28:16','Patch Set 3: Code-Review-1\n\n(1 comment)',578,3,578,'fa57193c_5a819549',NULL),(29,'2015-06-15 15:01:58','Uploaded patch set 4.',578,4,578,'fa57193c_7aca99a2',NULL),(29,'2015-06-15 07:46:17','Patch Set 3: Code-Review+1',578,3,578,'fa57193c_9a0fad2e',NULL),(29,'2015-06-15 15:04:10','Patch Set 4: Code-Review+1',578,4,578,'fa57193c_9ac04d7e',NULL),(29,'2015-06-15 14:40:41','Patch Set 3:\n\n(2 comments)',578,3,578,'fa57193c_9ad96d86',NULL),(6,'2015-06-12 17:05:52','Uploaded patch set 3.',579,3,579,'3a4c51b2_1c1d5574',NULL),(29,'2015-06-02 14:03:11','Patch Set 2: Code-Review+1',579,2,579,'5aaae553_65526615',NULL),(6,'2015-05-14 16:42:42','Uploaded patch set 2.',579,2,579,'bada0100_3af31e0c',NULL),(6,'2015-05-05 19:12:21','Uploaded patch set 1.',579,1,579,'bada0100_7f30bb56',NULL),(27,'2015-05-06 12:18:41','Patch Set 1: Code-Review+1\n\nit looks logical to me :)',579,1,579,'bada0100_df88c7c8',NULL),(6,'2015-05-12 15:54:55','Patch Set 1: Code-Review-1\n\nThis has a regression that breaks subsystem deployments, you\'ll end up with the parent system deployed inside itself as the subsystem!',579,1,579,'bada0100_f7cdaf87',NULL),(NULL,'2015-06-16 16:02:42','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of I5fdfae0f.\n* Depends on patch set 3 of I52a898ef, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',579,4,579,'da5c1566_190a8bd2',NULL),(6,'2015-06-16 16:02:39','Patch Set 4: Code-Review+2',579,4,579,'da5c1566_3905cfc2',NULL),(NULL,'2015-06-16 16:03:12','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I52a898ef, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',579,4,579,'da5c1566_591403f5',NULL),(34,'2015-06-16 11:00:01','Patch Set 4: Code-Review+1',579,4,579,'da5c1566_595c0326',NULL),(NULL,'2015-06-16 16:03:49','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of I5fdfae0f, however the current patch set is 5.\n* Depends on commit cdc763310e711cccd62e47d9eacdd27a95945d23 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',579,4,579,'da5c1566_7926276a',NULL),(6,'2015-06-16 16:04:06','Patch Set 5: Code-Review+2',579,5,579,'da5c1566_991cdb15',NULL),(6,'2015-06-16 16:03:57','Patch Set 5: Patch Set 4 was rebased',579,4,579,'da5c1566_b91f1f09',NULL),(6,'2015-06-16 16:04:12','Change has been successfully merged into the git repository.',579,5,579,'da5c1566_f9199723',NULL),(29,'2015-06-15 15:01:58','Uploaded patch set 4.',579,4,579,'fa57193c_5acfd5b0',NULL),(34,'2015-06-15 11:51:20','Patch Set 3: Code-Review+1',579,3,579,'fa57193c_7a6e19cb',NULL),(29,'2015-06-15 07:46:21','Patch Set 3: Code-Review+1',579,3,579,'fa57193c_fa1ce96c',NULL),(29,'2015-06-15 15:04:15','Patch Set 4: Code-Review+1',579,4,579,'fa57193c_fabd0904',NULL),(6,'2015-05-15 14:16:22','Patch Set 1: Code-Review+2',580,1,580,'9adffdf1_2f2529ab',NULL),(15,'2015-05-18 10:26:16','Change has been successfully rebased as c373f5a403b0ec84834d2f04fd1efac3792a7d35',580,1,580,'9adffdf1_4f374db1',NULL),(6,'2015-05-15 14:19:30','Patch Set 1:\n\nThis patch takes care of (1) on my list above, if that wasn\'t clear',580,1,580,'9adffdf1_4f4d0d72',NULL),(15,'2015-05-18 10:26:16','Patch Set 2: Patch Set 1 was rebased',580,1,580,'9adffdf1_afba7908',NULL),(6,'2015-05-15 14:18:52','Patch Set 1:\n\nI have totally confused myself and everyone else over this patch. Sorry.\n\nHere\'s what I think is the right thing to do.\n\n1. Add support to Morph for definitions version 4.\n\nIt still understands v1, v2, and v3 as well. We can assume nobody was relying on the fact that it would crash at deploy time in some situations. All definitions of v1, v2, and v3 that worked before will work after this patch is merged, as well.\n\n2. Release Baserock 15.21 (or whatever)\n\n3. Update VERSION in definitions.git to 4 and merge https://gerrit.baserock.org/#/c/531/',580,1,580,'9adffdf1_ef3641e7',NULL),(29,'2015-05-18 07:20:09','Patch Set 1: Code-Review+2\n\nSorry I misunderstood 93b034f045a2c7443122d7b082ad4460339907d0\nas you say link creation would cause failure which no one could\nbe relying on.\n\nSorry for the confusion.',580,1,580,'9adffdf1_ef92c19e',NULL),(6,'2015-05-11 15:20:38','Patch Set 1:\n\n> I mean that 93b034f045a2c7443122d7b082ad4460339907d0 didn\'t\n > preserve the behaviour for definitions versions ? 3, so we must\n > either drop\n > support for versions 0-3 or modify install-files so that it keeps\n > its\n > existing behaviour for definitions version ? 3 and provides the new\n > behaviour for versions > 3, I think\n\nI agree. It seems simplest to only support definitions V4 from now on. We\'ll need to be careful to ensure that users know how to migrate from V0 to V4.\n\nAlternately, we could move all/some of the .configure extensions into definitions.git, so that their behaviour doesn\'t have to be tracked as versions of the definitions format. that\'s not trivial either though',580,1,580,'bada0100_05236006',NULL),(15,'2015-05-06 12:05:12','Uploaded patch set 1.',580,1,580,'bada0100_3fa47356',NULL),(29,'2015-05-06 13:07:41','Patch Set 1: Code-Review-1\n\n93b034f045a2c7443122d7b082ad4460339907d0 doesn\'t seem to be backwards\ncompatible with older versions of definitions, so do we not need to drop support for versions 0-3 ?',580,1,580,'bada0100_3fbb1374',NULL),(29,'2015-05-11 13:19:59','Patch Set 1:\n\n> > 93b034f045a2c7443122d7b082ad4460339907d0 doesn\'t seem to be\n > > backwards\n > > compatible with older versions of definitions, so do we not need\n > to\n > > drop support for versions 0-3 ?\n > \n > Hi Richard, not sure what do you mean by backward compatibility?\n > You meant we have to add code to keep behaving incorrectly for\n > specific versions of the definitions format?\n\nI mean that 93b034f045a2c7443122d7b082ad4460339907d0 didn\'t preserve the behaviour for definitions versions ? 3, so we must either drop\nsupport for versions 0-3 or modify install-files so that it keeps its\nexisting behaviour for definitions version ? 3 and provides the new behaviour for versions > 3, I think',580,1,580,'bada0100_45b5e8cb',NULL),(29,'2015-05-12 07:52:29','Patch Set 1:\n\n> \n > I agree. It seems simplest to only support definitions V4 from now\n > on. We\'ll need to be careful to ensure that users know how to\n > migrate from V0 to V4.\n > \n > Alternately, we could move all/some of the .configure extensions\n > into definitions.git, so that their behaviour doesn\'t have to be\n > tracked as versions of the definitions format. that\'s not trivial\n > either though\n\nBoth approaches seem reasonable to me',580,1,580,'bada0100_65bcac6d',NULL),(6,'2015-05-14 09:56:14','Patch Set 1: Code-Review-1\n\n> 93b034f045a2c7443122d7b082ad4460339907d0 doesn\'t seem to be\n > backwards\n > compatible with older versions of definitions, so do we not need to\n > drop support for versions 0-3 ?\n\nHaving thought about it, is not an \'incompatible change\' at all, it\'s a bug fix. Before that commit, if you tried to overwrite a symlink at deploy time, Morph would crash due to the unhandled OSError and the deployment would fail. I think we can safely assume that nobody has been relying on that behaviour, so we don\'t need to consider this a new definitions version.\n\nThat said, I still think moving all the .configure extensions into definitions.git would be useful, so that we don\'t need to worry about compatibility every time we make a change to one of them.',580,1,580,'bada0100_7731bf0a',NULL),(15,'2015-05-11 11:29:35','Patch Set 1:\n\n> 93b034f045a2c7443122d7b082ad4460339907d0 doesn\'t seem to be\n > backwards\n > compatible with older versions of definitions, so do we not need to\n > drop support for versions 0-3 ?\n\nHi Richard, not sure what do you mean by backward compatibility? You meant we have to add code to keep behaving incorrectly for specific versions of the definitions format?',580,1,580,'bada0100_85bf50d0',NULL),(6,'2015-05-14 09:59:55','Patch Set 1:\n\n> > 93b034f045a2c7443122d7b082ad4460339907d0 doesn\'t seem to be\n > > backwards\n > > compatible with older versions of definitions, so do we not need\n > to\n > > drop support for versions 0-3 ?\n > \n > Having thought about it, \n > is not an \'incompatible change\' at all, it\'s a bug fix. Before that\n > commit, if you tried to overwrite a symlink at deploy time, Morph\n > would crash due to the unhandled OSError and the deployment would\n > fail. I think we can safely assume that nobody has been relying on\n > that behaviour, so we don\'t need to consider this a new definitions\n > version.\n\n\nArgh, this isn\'t really true either. We should indeed bump the definitions version before merging #531 because otherwise, old versions of Morph would crash when trying to build \'master\' of definitions. That\'s the sort of thing I want to avoid with the versioning of definitions. So I agree with Richard that Morph should be updated to build definitions V4 and only definitions V4.',580,1,580,'bada0100_9736a302',NULL),(27,'2015-05-06 12:27:45','Patch Set 1: Code-Review+1',580,1,580,'bada0100_9f923ff5',NULL),(6,'2015-06-12 13:58:10','Uploaded patch set 3.',581,3,581,'3a4c51b2_5c5fdd72',NULL),(6,'2015-06-12 13:58:24','Patch Set 2:\n\n(1 comment)\n\nTook me a while to do this little fixup, sorry.',581,2,581,'3a4c51b2_bc53816b',NULL),(6,'2015-05-18 11:10:45','Uploaded patch set 2.',581,2,581,'9adffdf1_2fb9a9e9',NULL),(37,'2015-05-19 09:30:24','Patch Set 1:\n\n(2 comments)',581,1,581,'9adffdf1_8fe455ad',NULL),(37,'2015-05-19 09:32:29','Patch Set 2: Code-Review-1\n\n(1 comment)\n\nYour add_to_environment function is a bit squiffy.\nIt never actually checks the value you intended to pass in as the environment, since the function includes a self parameter it never uses.\n\nThis didn\'t show up in testing, because you only ever pass None in anyway.',581,2,581,'9adffdf1_afe1199c',NULL),(6,'2015-05-18 11:12:44','Patch Set 1:\n\n(15 comments)\n\nWow, that was quite a review. I\'ve addressed most of the comments.',581,1,581,'9adffdf1_efcac16d',NULL),(37,'2015-06-17 10:11:28','Patch Set 3: Code-Review+1\n\nLooks good.',581,3,581,'ba51214e_1879e593',NULL),(16,'2015-06-17 10:29:05','Patch Set 3: Code-Review+1\n\nLooks OK to me at a glance, and it seems to work fine.',581,3,581,'ba51214e_786e21cb',NULL),(37,'2015-06-17 10:36:09','Patch Set 4: Patch Set 3 was rebased',581,3,581,'ba51214e_9864d5e6',NULL),(37,'2015-06-17 10:36:07','Patch Set 3: Code-Review+2',581,3,581,'ba51214e_b86719ea',NULL),(37,'2015-06-17 10:36:10','Change has been successfully rebased as 7a8a2eda8ecb7c36d789af49eab1b7c3c853e461',581,3,581,'ba51214e_f86191d4',NULL),(37,'2015-05-13 15:40:04','Patch Set 1: Code-Review-1\n\n(16 comments)\n\nPretty good, but there\'s still a few things I\'d like to be fixed.\n\nI\'ll remove my +1 for fixing it to assert that \'config\' has not been passed in as a setting, as it is order dependent, and the whitespace sensitivity in the morph helper script that is generated.',581,1,581,'bada0100_979a2313',NULL),(16,'2015-05-13 12:07:03','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThis is really useful, thanks!',581,1,581,'bada0100_d7d74bec',NULL),(6,'2015-05-06 13:16:26','Uploaded patch set 1.',581,1,581,'bada0100_dfaf672a',NULL),(6,'2015-05-06 13:16:56','Patch Set 1:\n\nThis was previously submitted to the baserock-dev mailing list: ',581,1,581,'bada0100_ffacab37',NULL),(16,'2015-05-08 10:11:23','Uploaded patch set 2.',582,2,582,'bada0100_0a74cfcd',NULL),(NULL,'2015-05-12 12:23:00','The change could not be merged due to a path conflict.\n\nPlease rebase the change locally and upload the rebased commit for review.',582,2,582,'bada0100_37a57704',NULL),(29,'2015-05-12 07:40:29','Patch Set 2: Code-Review+1',582,2,582,'bada0100_45a40857',NULL),(16,'2015-05-12 12:25:41','Uploaded patch set 3.',582,3,582,'bada0100_57aa7bd5',NULL),(16,'2015-05-06 13:34:37','Uploaded patch set 1.',582,1,582,'bada0100_5f63771a',NULL),(16,'2015-05-12 12:25:58','Change has been successfully rebased as 2d19611ace78aec071607fafd0e2798412cc4286',582,3,582,'bada0100_77821f54',NULL),(16,'2015-05-12 12:22:58','Patch Set 2: Code-Review+2',582,2,582,'bada0100_97a0e3f5',NULL),(37,'2015-05-12 12:13:37','Patch Set 2: Code-Review+1\n\n+1 assuming the test suite still passes.',582,2,582,'bada0100_b76167d5',NULL),(16,'2015-05-12 12:25:55','Patch Set 3: Code-Review+2',582,3,582,'bada0100_b7b8872b',NULL),(16,'2015-05-12 12:25:57','Patch Set 4: Patch Set 3 was rebased',582,3,582,'bada0100_d7b50b32',NULL),(6,'2015-05-07 14:20:33','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLooks fine (apart from the typo)',582,1,582,'bada0100_eac38b88',NULL),(16,'2015-05-12 12:26:14','Change has been successfully merged into the git repository.',583,4,583,'bada0100_179393a4',NULL),(NULL,'2015-05-12 12:26:04','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 3 of I11b4dbeb, however the current patch set is 4.\n\nPlease rebase the change and upload a replacement commit.',583,3,583,'bada0100_377c9772',NULL),(16,'2015-05-12 12:26:10','Patch Set 4: Patch Set 3 was rebased',583,3,583,'bada0100_57811b49',NULL),(6,'2015-05-12 12:22:10','Patch Set 2: Code-Review+1\n\nLooks good at a glance',583,2,583,'bada0100_779bffc9',NULL),(16,'2015-05-06 13:34:37','Uploaded patch set 1.',583,1,583,'bada0100_7f68bbf5',NULL),(16,'2015-05-12 12:26:02','Patch Set 3: Code-Review+2',583,3,583,'bada0100_97878361',NULL),(16,'2015-05-08 10:11:23','Uploaded patch set 2.',583,2,583,'bada0100_aa80238c',NULL),(6,'2015-05-07 14:22:25','Patch Set 1:\n\n(1 comment)\n\nLooks fine at a glance apart from 1 comment',583,1,583,'bada0100_aabd8304',NULL),(29,'2015-05-07 08:55:27','Patch Set 1: Code-Review+1\n\n(3 comments)\n\nThis looks good to me, I found one of the names a little confusing\n(append(sa)), and have a couple of other points that are minor.',583,1,583,'bada0100_ca3007eb',NULL),(29,'2015-05-08 10:42:30','Patch Set 2: Code-Review+1',583,2,583,'bada0100_ea24ebc7',NULL),(16,'2015-05-12 12:26:12','Patch Set 4: Code-Review+2',583,4,583,'bada0100_f795af88',NULL),(16,'2015-05-12 12:25:41','Uploaded patch set 3.',583,3,583,'bada0100_f7ae0fe7',NULL),(42,'2015-05-06 15:43:17','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThis looks like a correct reversion and the justification is sound to me.',584,1,584,'bada0100_1f3bafec',NULL),(24,'2015-05-06 15:48:45','Patch Set 1: Code-Review+1\n\nI reverted the gcc 5.1 commit, and built both a host development environment and a deployed system with 4.9.2 and everything was working again.',584,1,584,'bada0100_3f40f355',NULL),(28,'2015-05-07 10:22:54','Patch Set 1:\n\nJust wanted to leave a note that updating syslinux to the latest version does not fix the problem.',584,1,584,'bada0100_8a799f95',NULL),(6,'2015-05-06 15:49:57','Patch Set 1:\n\nThanks for reviewing.',584,1,584,'bada0100_9f2ebfa4',NULL),(6,'2015-05-06 15:49:58','Change has been successfully merged into the git repository.',584,1,584,'bada0100_bf2b8393',NULL),(7,'2015-05-06 15:48:48','Patch Set 1: Code-Review+1\n\nI agree with the reasons, we should revert this change until we fix the problems we are having.',584,1,584,'bada0100_df2447c8',NULL),(6,'2015-05-06 14:00:26','Uploaded patch set 1.',584,1,584,'bada0100_df7687d8',NULL),(6,'2015-05-06 15:49:50','Patch Set 1: Code-Review+2',584,1,584,'bada0100_ff210bb5',NULL),(29,'2015-05-06 15:23:20','Patch Set 1: Code-Review+2',585,1,585,'bada0100_3f49d38b',NULL),(29,'2015-05-06 14:50:43','Patch Set 1: Code-Review+1\n\nI don\'t completely understand this issue, but this patch does seem to fix the problem with morph checkout.',585,1,585,'bada0100_7f4f5b93',NULL),(6,'2015-05-06 14:34:46','Patch Set 1: Code-Review+1\n\nI\'m a little confused, but I trust it works',585,1,585,'bada0100_9f80ff8c',NULL),(29,'2015-05-06 15:23:22','Change has been successfully merged into the git repository.',585,1,585,'bada0100_df5d274a',NULL),(37,'2015-05-06 14:22:35','Uploaded patch set 1.',585,1,585,'bada0100_ff734be5',NULL),(16,'2015-05-12 12:25:41','Uploaded patch set 3.',586,3,586,'bada0100_17acf3ec',NULL),(16,'2015-05-12 12:26:22','Change has been successfully merged into the git repository.',586,4,586,'bada0100_77e9bf19',NULL),(16,'2015-05-12 12:26:18','Patch Set 4: Patch Set 3 was rebased',586,3,586,'bada0100_b78f2775',NULL),(16,'2015-05-06 14:45:03','Uploaded patch set 1.',586,1,586,'bada0100_bf7dc3b3',NULL),(16,'2015-05-08 10:11:23','Uploaded patch set 2.',586,2,586,'bada0100_ca7d67b3',NULL),(6,'2015-05-07 14:22:46','Patch Set 1: Code-Review+1',586,1,586,'bada0100_caba470a',NULL),(6,'2015-05-12 12:21:41','Patch Set 2: Code-Review+2',586,2,586,'bada0100_d75e6b12',NULL),(16,'2015-05-12 12:26:20','Patch Set 4: Code-Review+2',586,4,586,'bada0100_d78c2b82',NULL),(29,'2015-05-12 07:45:22','Patch Set 2: Code-Review+1',586,2,586,'bada0100_e5889cc8',NULL),(15,'2015-05-07 16:08:47','Patch Set 1: Code-Review+1',587,1,587,'bada0100_0a928f57',NULL),(15,'2015-05-07 16:27:38','Patch Set 2: Code-Review+1\n\nThanks for adding the info in the commit message',587,2,587,'bada0100_2a99936e',NULL),(6,'2015-05-07 16:47:15','Patch Set 3: Patch Set 2 was rebased',587,2,587,'bada0100_2ab0b3dc',NULL),(6,'2015-05-07 16:47:16','Change has been successfully rebased as 2df457330147cab89cd7ff3aeb7c2e0901c62a91',587,2,587,'bada0100_4ab5f7cb',NULL),(24,'2015-05-07 16:24:21','Patch Set 2: Commit message was updated',587,2,587,'bada0100_6a8f9b24',NULL),(6,'2015-05-07 16:47:08','Patch Set 2: Code-Review+2',587,2,587,'bada0100_6ab6bbde',NULL),(24,'2015-05-06 16:40:16','Patch Set 1:\n\nIMPORTANT NOTE: without this fix, minimal systems won\'t start as /etc/ld.so.conf with be missing, due to a bug I introduced when moving it from fhs-dirs to glibc.',587,1,587,'bada0100_8a043f16',NULL),(6,'2015-05-07 16:47:13','Patch Set 2:\n\nThanks for fixing this!',587,2,587,'bada0100_8abbdfc3',NULL),(24,'2015-05-06 16:36:40','Patch Set 1:\n\nI have tested this fix by building both a full development image, and a minimal image and confirming that they both work and /etc/ld.so.conf and /etc/ld.so.conf.d are part of the glibc chunk metadata, and not fhs-dirs.\n\nSee https://gerrit.baserock.org/588 for a fix to fhs-dirs as part of the same change',587,1,587,'bada0100_bf02a309',NULL),(15,'2015-05-07 16:08:41','Patch Set 1:\n\n> IMPORTANT NOTE: without this fix, minimal systems won\'t start as\n > /etc/ld.so.conf with be missing, due to a bug I introduced when\n > moving it from fhs-dirs to glibc.\n\nCan you put this info in the commit message pointing to the commit hash that introduced the regression? Thanks',587,1,587,'bada0100_ea94eb45',NULL),(24,'2015-05-06 16:30:38','Uploaded patch set 1.',587,1,587,'bada0100_ff082b2f',NULL),(6,'2015-05-07 16:47:27','Patch Set 1:\n\nThanks for fixing this!',588,1,588,'bada0100_0ac7ef46',NULL),(24,'2015-05-06 16:37:10','Patch Set 1:\n\nI have tested this fix by building both a full development image, and a minimal image and confirming that they both work and /etc/ld.so.conf and /etc/ld.so.conf.d are part of the glibc chunk metadata, and not fhs-dirs.\n\nSee https://gerrit.baserock.org/587 for a fix to fhs-dirs as part of the same change',588,1,588,'bada0100_6aff9b02',NULL),(24,'2015-05-06 16:33:42','Uploaded patch set 1.',588,1,588,'bada0100_9f055f16',NULL),(15,'2015-05-07 16:08:54','Patch Set 1: Code-Review+1',588,1,588,'bada0100_aa9ee361',NULL),(6,'2015-05-07 16:47:30','Change has been successfully merged into the git repository.',588,1,588,'bada0100_aac34337',NULL),(6,'2015-05-07 16:47:22','Patch Set 1: Code-Review+2',588,1,588,'bada0100_eac94b5b',NULL),(6,'2015-05-07 17:27:04','Patch Set 1:\n\nI\'ve also updated fhs-dirs and stage2-fhs-dirs in definitions.git to include this change.',588,1,588,'bada0100_eaf70b8b',NULL),(29,'2015-05-08 08:09:53','Patch Set 2: Patch Set 1 was rebased',589,1,589,'bada0100_0a3ccf2e',NULL),(29,'2015-05-07 07:25:11','Patch Set 1: Code-Review+1\n\nThis is a symptom of a more general problem,\na fix for which I attempted with change https://gerrit.baserock.org/#/c/219/\nbut that change has too much duplication and I haven\'t had time to improve it.\n\nThis change is anyway orthogonal to 219 so I think we can merge it',589,1,589,'bada0100_2a20b39a',NULL),(34,'2015-05-07 11:50:22','Patch Set 1: Code-Review+1\n\nThis looks good to me, and would have saved me a couple of minutes yesterday!',589,1,589,'bada0100_4aaad7d5',NULL),(6,'2015-05-07 14:01:41','Patch Set 1: Code-Review+1\n\nI\'d rather the more general problem was solved, but this change looks fine.',589,1,589,'bada0100_6a823b54',NULL),(16,'2015-05-06 20:46:59','Uploaded patch set 1.',589,1,589,'bada0100_8a2bdf81',NULL),(29,'2015-05-08 08:09:53','Change has been successfully rebased as f9a0607b654ee1adb85f4c1bfedd3571a22ac21a',589,1,589,'bada0100_aa4823cd',NULL),(29,'2015-05-08 08:09:47','Patch Set 1: Code-Review+2',589,1,589,'bada0100_ea3e2b29',NULL),(15,'2015-05-07 17:01:54','Patch Set 1: Code-Review+1',590,1,590,'bada0100_0ace0f5b',NULL),(28,'2015-05-13 11:16:16','Patch Set 1:\n\nI fail to see where the simplification is. As I don\'t have time to work on this and to avoid having it lingering on Open patch queue, I\'ll abandon it.',590,1,590,'bada0100_37e7b7e6',NULL),(28,'2015-05-13 11:16:28','Abandoned',590,1,590,'bada0100_57ecbbc7',NULL),(28,'2015-05-07 09:52:57','Uploaded patch set 1.',590,1,590,'bada0100_6a4d5b72',NULL),(15,'2015-05-12 16:20:33','Patch Set 1: Code-Review-1\n\n(1 comment)',590,1,590,'bada0100_7788df22',NULL),(28,'2015-05-07 09:55:42','Patch Set 1:\n\nThis came out when I tried to debug why images were not booting when deployed from a system with GCC 5.1.\n\nThis update creates bootable images with GCC 4.9.2.',590,1,590,'bada0100_aa4a6353',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 2.',591,2,591,'bada0100_2acaf3a1',NULL),(16,'2015-05-08 14:51:52','Patch Set 2: Code-Review+1',591,2,591,'bada0100_654d8c72',NULL),(37,'2015-05-11 10:47:58','Patch Set 3: Patch Set 2 was rebased',591,2,591,'bada0100_655eeceb',NULL),(16,'2015-05-07 10:09:12','Patch Set 1: Code-Review+1',591,1,591,'bada0100_6a747b9c',NULL),(37,'2015-05-11 10:47:58','Change has been successfully rebased as 6aec7d787094616b820fa15d2f24d3d320d2ba41',591,2,591,'bada0100_8563d0b0',NULL),(37,'2015-05-07 09:53:52','Uploaded patch set 1.',591,1,591,'bada0100_8a52ff11',NULL),(29,'2015-05-11 09:37:44','Patch Set 2: Code-Review+1',591,2,591,'bada0100_a5e61443',NULL),(37,'2015-05-11 10:47:52','Patch Set 2: Code-Review+2',591,2,591,'bada0100_c551d8d9',NULL),(37,'2015-05-11 10:49:02','Change has been successfully merged into the git repository.',592,3,592,'bada0100_056fe093',NULL),(37,'2015-05-07 09:53:52','Uploaded patch set 1.',592,1,592,'bada0100_2a575304',NULL),(37,'2015-05-11 10:48:53','Patch Set 3: Patch Set 2 was rebased',592,2,592,'bada0100_455de8e8',NULL),(29,'2015-05-11 09:42:09','Patch Set 2: Code-Review+1',592,2,592,'bada0100_65d02c54',NULL),(37,'2015-05-11 10:48:59','Patch Set 3: Code-Review+2',592,3,592,'bada0100_e5717c78',NULL),(16,'2015-05-08 16:00:09','Patch Set 2: Code-Review+1',592,2,592,'bada0100_e5ae5ce7',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 2.',592,2,592,'bada0100_eadceb76',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 2.',593,2,593,'bada0100_0ada8f78',NULL),(37,'2015-05-07 09:53:52','Uploaded patch set 1.',593,1,593,'bada0100_4a5c1726',NULL),(37,'2015-05-11 10:49:36','Change has been successfully merged into the git repository.',593,3,593,'bada0100_65058cc1',NULL),(16,'2015-05-08 14:53:39','Patch Set 2: Code-Review+1',593,2,593,'bada0100_8552f011',NULL),(37,'2015-05-11 10:49:27','Patch Set 3: Patch Set 2 was rebased',593,2,593,'bada0100_a56b7484',NULL),(37,'2015-05-11 10:49:33','Patch Set 3: Code-Review+2',593,3,593,'bada0100_c568f889',NULL),(29,'2015-05-11 09:50:13','Patch Set 2: Code-Review+1',593,2,593,'bada0100_e5c3bc88',NULL),(29,'2015-05-11 09:53:18','Patch Set 3: Code-Review+1',594,3,594,'bada0100_05c12080',NULL),(37,'2015-05-11 10:51:13','Patch Set 4: Code-Review+2',594,4,594,'bada0100_250f84e3',NULL),(37,'2015-05-11 10:51:16','Change has been successfully merged into the git repository.',594,4,594,'bada0100_451408f5',NULL),(16,'2015-05-08 15:59:21','Patch Set 3: Code-Review+1\n\nLooks fine to me. It is maybe worth moving this patch before the `morph anchor` change which uses it in the history though.',594,3,594,'bada0100_45aac8d5',NULL),(37,'2015-05-07 14:28:32','Uploaded patch set 3.',594,3,594,'bada0100_4a5df7e8',NULL),(6,'2015-05-07 14:16:59','Patch Set 1:\n\nI think it would be neater to remove the \'ref\' parameter and just keep \'refs\'. We don\'t make any promises about interface stability in \'morphlib\' yet, after all.',594,1,594,'bada0100_4af897e5',NULL),(37,'2015-05-11 10:51:08','Patch Set 4: Patch Set 3 was rebased',594,3,594,'bada0100_850af0d0',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 2.',594,2,594,'bada0100_aae6e342',NULL),(37,'2015-05-07 09:53:52','Uploaded patch set 1.',594,1,594,'bada0100_ea406b37',NULL),(29,'2015-05-08 13:55:24','Patch Set 5: Code-Review-1\n\nWe don\'t distinguish between stratum sources and chunk sources in our comparison, and since we\'re keying on name we can perform a comparison\nbetween a stratum and a chunk if a stratum source happens to have the same name as a chunk source.\n\nI\'ll send a new patch set to fix this.',595,5,595,'bada0100_0537e0e4',NULL),(29,'2015-05-08 18:33:24','Patch Set 6: Code-Review-2\n\nThere\'s an occasional failure from the yarns, which I\'ve been unable to reproduce outside the test suite. We should figure out what\'s going on before merging this.',595,6,595,'bada0100_059360a4',NULL),(29,'2015-05-08 16:49:20','Uploaded patch set 6.',595,6,595,'bada0100_05acc0ec',NULL),(37,'2015-05-07 09:53:52','Uploaded patch set 1.',595,1,595,'bada0100_0a3e0fb9',NULL),(37,'2015-05-07 10:33:24','Uploaded patch set 2.',595,2,595,'bada0100_4a73b7b1',NULL),(37,'2015-05-11 13:08:38','Patch Set 7: Code-Review+2',595,7,595,'bada0100_658fcc24',NULL),(37,'2015-05-11 13:08:40','Change has been successfully merged into the git repository.',595,7,595,'bada0100_85943038',NULL),(29,'2015-05-11 09:18:10','Patch Set 6: -Code-Review\n\nAdam Coldrick found the cause of the occasional failures and sent a fix https://gerrit.baserock.org/#/c/615/ to address it.',595,6,595,'bada0100_85ee7021',NULL),(37,'2015-05-07 14:25:30','Uploaded patch set 4.',595,4,595,'bada0100_aa54a3ca',NULL),(37,'2015-05-11 13:08:32','Patch Set 7: Patch Set 6 was rebased',595,6,595,'bada0100_c5723849',NULL),(37,'2015-05-11 09:39:10','Patch Set 6:\n\n(1 comment)',595,6,595,'bada0100_c5e31832',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 3.',595,3,595,'bada0100_cae32732',NULL),(16,'2015-05-08 17:53:09','Patch Set 6: Code-Review+1\n\n(2 comments)\n\nSeems OK to me, except for a couple of places I think the output could be improved. That can be done some other time though I think.',595,6,595,'bada0100_e595fc88',NULL),(29,'2015-05-11 11:16:17','Patch Set 6: Code-Review+1',595,6,595,'bada0100_e5e65c16',NULL),(37,'2015-05-07 14:28:32','Uploaded patch set 5.',595,5,595,'bada0100_ea714b78',NULL),(37,'2015-05-11 10:52:55','Patch Set 5: Code-Review+2',596,5,596,'bada0100_05f600d8',NULL),(37,'2015-05-07 14:28:32','Uploaded patch set 4.',596,4,596,'bada0100_0a6fef93',NULL),(16,'2015-05-08 14:56:02','Patch Set 4: Code-Review+1',596,4,596,'bada0100_25578404',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 2.',596,2,596,'bada0100_6ad0fb53',NULL),(37,'2015-05-11 10:52:59','Change has been successfully merged into the git repository.',596,5,596,'bada0100_a50294b2',NULL),(29,'2015-05-11 10:06:26','Patch Set 4: Code-Review+1\n\n(1 comment)',596,4,596,'bada0100_c5ba380a',NULL),(37,'2015-05-07 14:25:30','Uploaded patch set 3.',596,3,596,'bada0100_ca51e7d9',NULL),(37,'2015-05-11 10:52:50','Patch Set 5: Patch Set 4 was rebased',596,4,596,'bada0100_e5f89cc6',NULL),(37,'2015-05-07 10:33:24','Uploaded patch set 1.',596,1,596,'bada0100_ea670be9',NULL),(37,'2015-05-11 13:07:50','Patch Set 6: Code-Review+2',597,6,597,'bada0100_0579202f',NULL),(37,'2015-05-07 10:33:24','Uploaded patch set 1.',597,1,597,'bada0100_0a65afe0',NULL),(16,'2015-05-11 13:05:39','Patch Set 5: Code-Review+1',597,5,597,'bada0100_25822401',NULL),(37,'2015-05-11 09:45:16','Patch Set 4:\n\nThere\'s two functions that are usefully exposed, the synopsis one could do with a docstring, and while they are sufficiently isolated that unit tests would be valuable, I\'d prefer to see if we can integrate https://docs.python.org/2/library/doctest.html so we can in-line documentation also.',597,4,597,'bada0100_25ca24a2',NULL),(6,'2015-05-07 14:04:08','Patch Set 1:\n\nLooks like a sensible thing to do, but I would really appreciate docstrings for these so that I could understand how to use them without having to work it out from the code.',597,1,597,'bada0100_2a7c3372',NULL),(29,'2015-05-11 11:09:16','Uploaded patch set 5.',597,5,597,'bada0100_452ba830',NULL),(6,'2015-05-07 14:05:17','Patch Set 1:\n\nOn closer inspection, there\'s only 1 function that\'s useful outside the module that would need documenting, the other blocks are complex Exception objects.',597,1,597,'bada0100_4a817749',NULL),(37,'2015-05-07 14:25:30','Uploaded patch set 3.',597,3,597,'bada0100_6a5ebbeb',NULL),(37,'2015-05-07 14:19:18','Uploaded patch set 2.',597,2,597,'bada0100_8ad51f45',NULL),(29,'2015-05-11 11:11:06','Patch Set 5: Code-Review+1\n\nThis is neat',597,5,597,'bada0100_a5193424',NULL),(37,'2015-05-11 13:07:53','Change has been successfully merged into the git repository.',597,6,597,'bada0100_a575b433',NULL),(37,'2015-05-07 14:28:32','Uploaded patch set 4.',597,4,597,'bada0100_aa6b4384',NULL),(37,'2015-05-11 13:07:46','Patch Set 6: Patch Set 5 was rebased',597,5,597,'bada0100_e57bbc27',NULL),(7,'2015-05-07 16:04:43','Patch Set 1: Code-Review+1',598,1,598,'bada0100_4ab097f4',NULL),(15,'2015-05-07 16:09:19','Change has been successfully merged into the git repository.',598,1,598,'bada0100_6a88fb22',NULL),(6,'2015-05-07 15:50:50','Uploaded patch set 1.',598,1,598,'bada0100_6aa1dba8',NULL),(15,'2015-05-07 16:09:17','Patch Set 1: Code-Review+2',598,1,598,'bada0100_ca9b2771',NULL),(37,'2015-05-11 13:13:54','Patch Set 3: Code-Review+2',599,3,599,'bada0100_05a0408f',NULL),(16,'2015-05-08 15:56:43','Patch Set 1: Code-Review+1',599,1,599,'bada0100_25a54404',NULL),(29,'2015-05-11 13:12:50','Patch Set 2: Code-Review+1',599,2,599,'bada0100_459e4858',NULL),(16,'2015-05-08 17:07:07','Patch Set 2: Code-Review+1',599,2,599,'bada0100_65826c54',NULL),(37,'2015-05-11 12:09:14','Patch Set 2:\n\n(1 comment)',599,2,599,'bada0100_65a10ca9',NULL),(29,'2015-05-11 11:13:01','Patch Set 2:\n\n(1 comment)',599,2,599,'bada0100_85d8b054',NULL),(37,'2015-05-07 15:59:16','Uploaded patch set 1.',599,1,599,'bada0100_8aa67fc0',NULL),(37,'2015-05-11 13:13:57','Change has been successfully merged into the git repository.',599,3,599,'bada0100_a5acd48d',NULL),(29,'2015-05-08 16:49:20','Uploaded patch set 2.',599,2,599,'bada0100_a5b8542b',NULL),(37,'2015-05-11 13:13:50','Patch Set 3: Patch Set 2 was rebased',599,2,599,'bada0100_e5a2dc99',NULL),(16,'2015-05-11 09:21:18','Patch Set 2: Code-Review+1',600,2,600,'bada0100_25f3040c',NULL),(37,'2015-05-07 15:59:16','Uploaded patch set 1.',600,1,600,'bada0100_2aabd38a',NULL),(29,'2015-05-11 10:37:57','Patch Set 2: Code-Review+1',600,2,600,'bada0100_45464825',NULL),(37,'2015-05-11 13:14:16','Patch Set 3: Code-Review+2',600,3,600,'bada0100_65b6ecde',NULL),(37,'2015-05-11 13:14:18','Change has been successfully merged into the git repository.',600,3,600,'bada0100_85bbd0c3',NULL),(37,'2015-05-11 13:14:11','Patch Set 3: Patch Set 2 was rebased',600,2,600,'bada0100_c5a9d87c',NULL),(29,'2015-05-08 16:49:20','Uploaded patch set 2.',600,2,600,'bada0100_c5b55832',NULL),(7,'2015-05-08 11:18:01','Patch Set 2: Code-Review+2',601,2,601,'bada0100_0a092f31',NULL),(43,'2015-05-08 11:16:18','Patch Set 1: Code-Review+1',601,1,601,'bada0100_2a12f362',NULL),(28,'2015-05-07 16:11:54','Uploaded patch set 1.',601,1,601,'bada0100_2a82f300',NULL),(7,'2015-05-08 11:17:54','Patch Set 1: Code-Review+2',601,1,601,'bada0100_4a173752',NULL),(7,'2015-05-08 11:18:02','Change has been successfully merged into the git repository.',601,2,601,'bada0100_aa058315',NULL),(7,'2015-05-07 21:34:16','Patch Set 1: Code-Review+1\n\nI know this upgrade is needed, and Openstack should fail with v2.0.',601,1,601,'bada0100_aaf10397',NULL),(7,'2015-05-08 11:17:59','Patch Set 2: Patch Set 1 was rebased',601,1,601,'bada0100_ea0b8b29',NULL),(6,'2015-05-07 16:43:30','Patch Set 2: Patch Set 1 was rebased',602,1,602,'bada0100_0aa04f8f',NULL),(7,'2015-05-07 16:12:09','Uploaded patch set 1.',602,1,602,'bada0100_4a873710',NULL),(37,'2015-05-13 14:07:20','Patch Set 2:\n\nSam Thursfield: In my opinion, sticking with the commit sha1 is the best option, as to do otherwise makes pushing anchor refs more difficult.',602,2,602,'bada0100_57111bab',NULL),(15,'2015-05-07 16:27:01','Patch Set 1: Code-Review+1',602,1,602,'bada0100_8a943f38',NULL),(28,'2015-05-07 16:15:58','Patch Set 1:\n\n(1 comment)',602,1,602,'bada0100_aa758333',NULL),(6,'2015-05-07 16:43:31','Change has been successfully rebased as 594b3cc535d757141c9fe65ce36f2d5c77ddf12f',602,1,602,'bada0100_aaaca38d',NULL),(6,'2015-05-07 16:43:26','Patch Set 1: Code-Review+2\n\nI\'m not sure what you mean about the SHA1 of the tag, Tiago. I think using the commit SHA1 is fine, and that\'s what we mostly do already (I think). If there\'s a good reason to switch to using the SHA1 of the tag, best to propose it on the baserock-dev@ list, and if agreed we can migrate all of definitions to use the tag SHA1s in one go.',602,1,602,'bada0100_eaa2ab99',NULL),(34,'2015-05-12 11:07:44','Uploaded patch set 6.',603,6,603,'bada0100_173e33b9',NULL),(34,'2015-05-12 14:36:45','Patch Set 6:\n\n(1 comment)\n\nI have a couple of +1s, does this mean someone can merge this?',603,6,603,'bada0100_17f633d8',NULL),(34,'2015-05-11 14:03:45','Patch Set 1:\n\n(7 comments)\n\nHave changed things in line with review comments; hopefully caught everything.',603,1,603,'bada0100_25fea46c',NULL),(15,'2015-05-07 16:59:48','Patch Set 1: Code-Review-1\n\n(4 comments)\n\nThanks for the patch, I have some comments though',603,1,603,'bada0100_2ae753e6',NULL),(7,'2015-05-12 15:23:09','Patch Set 7: Patch Set 6 was rebased',603,6,603,'bada0100_37dd7743',NULL),(15,'2015-05-11 11:38:42','Patch Set 1:\n\n(1 comment)',603,1,603,'bada0100_45b968e8',NULL),(7,'2015-05-12 15:23:10','Change has been successfully rebased as cb33af346072a1d2250c2ec74925987e35567ef5',603,6,603,'bada0100_57e27b04',NULL),(34,'2015-05-11 14:03:04','Uploaded patch set 2.',603,2,603,'bada0100_6504ac7e',NULL),(34,'2015-05-11 10:08:11','Patch Set 1:\n\n(4 comments)',603,1,603,'bada0100_6537ccb1',NULL),(8,'2015-05-11 11:27:08','Patch Set 1: Code-Review-1\n\n(6 comments)',603,1,603,'bada0100_65ba6ce3',NULL),(8,'2015-05-12 10:29:25','Patch Set 4:\n\n(1 comment)',603,4,603,'bada0100_97046316',NULL),(7,'2015-05-12 15:23:03','Patch Set 6: Code-Review+2\n\nI\'ve reviewed this a couple of times now, and I think that all the comments were addressed. +2 and merging!',603,6,603,'bada0100_97d8e354',NULL),(34,'2015-05-11 15:30:13','Uploaded patch set 4.',603,4,603,'bada0100_a5761405',NULL),(7,'2015-05-12 10:27:19','Patch Set 4: Code-Review+1\n\nThanks for fixing!',603,4,603,'bada0100_c502380b',NULL),(34,'2015-05-07 16:21:20','Uploaded patch set 1.',603,1,603,'bada0100_ca724749',NULL),(8,'2015-05-12 13:31:48','Patch Set 6: Code-Review+1\n\n(1 comment)\n\nJust a nitpicking comment, but you can ignore it if you think that it is fine as it is.',603,6,603,'bada0100_d7518bd9',NULL),(7,'2015-05-11 15:19:43','Patch Set 3: Code-Review+1\n\n(1 comment)\n\n> Uploaded patch set 3.\n\nGood work! I only have a little nitpick, but other than that it looks great',603,3,603,'bada0100_e525fc0a',NULL),(34,'2015-05-11 14:56:40','Uploaded patch set 3.',603,3,603,'bada0100_e53e5c29',NULL),(34,'2015-05-12 11:00:09','Uploaded patch set 5.',603,5,603,'bada0100_f7404f37',NULL),(6,'2015-05-07 17:27:27','Patch Set 4:\n\nI\'ve also updated morph in definitions.git to include this change.',604,4,604,'bada0100_0af5af82',NULL),(16,'2015-05-07 17:00:29','Patch Set 2: Commit message was updated',604,2,604,'bada0100_4aec17c8',NULL),(6,'2015-05-07 17:10:26','Patch Set 4: Patch Set 3 was rebased',604,3,604,'bada0100_6a047b7e',NULL),(6,'2015-05-07 17:10:26','Change has been successfully rebased as 4c0d2a9f9c3b71345d1a59a403c81d2795917a75',604,3,604,'bada0100_8a099f97',NULL),(16,'2015-05-07 16:59:10','Uploaded patch set 1.',604,1,604,'bada0100_8ae2ffd3',NULL),(6,'2015-05-07 17:02:38','Patch Set 3: Code-Review+2',604,3,604,'bada0100_aada6315',NULL),(6,'2015-05-07 17:02:41','Patch Set 3:\n\nGood spot.',604,3,604,'bada0100_cad7a7ec',NULL),(16,'2015-05-07 17:00:41','Patch Set 3: Commit message was updated',604,3,604,'bada0100_ead06bf9',NULL),(16,'2015-05-12 12:13:16','Uploaded patch set 5.',605,5,605,'bada0100_1765d3e0',NULL),(39,'2015-05-11 13:16:35','Patch Set 3: Code-Review+1\n\nCode looks good and works fine, thanks for this patch',605,3,605,'bada0100_25b0e4dc',NULL),(29,'2015-05-08 07:27:41','Patch Set 1:\n\nIt would be better to do this when the process ends, which we can\'t do reliably, but could probably do well enough by handling sigterm ourselves.',605,1,605,'bada0100_2a351346',NULL),(16,'2015-05-07 17:14:53','Uploaded patch set 1.',605,1,605,'bada0100_2afe736c',NULL),(16,'2015-05-12 13:40:22','Change has been successfully merged into the git repository.',605,7,605,'bada0100_375817fa',NULL),(29,'2015-05-12 09:14:41','Patch Set 3:\n\n> \n > I was using _handle_build_started_message in version 1 of this\n > patch, but that caused a traceback if ctrl+c was done when\n > calculating the build graph since that message isn\'t sent until the\n > first item starts building.\n\nAhh well that\'s another point, we could get a sigint before _handle_graphing_started has been called couldn\'t we?\nTo get around that I guess we can set connection_id to None in\nthe initiator\'s __init__ and then output \"ID\" if it\'s None.\n\nI still think that duplicating what we have in InitiatorStart\nis most likely unnecessary',605,3,605,'bada0100_4549688a',NULL),(16,'2015-05-11 12:47:26','Uploaded patch set 3.',605,3,605,'bada0100_45b088f4',NULL),(6,'2015-05-07 17:18:09','Patch Set 1:\n\nThanks for this ! I think it would be better to tell the user when the `morph distbuild` process exits as well, though, as they might not read the rest of the output!',605,1,605,'bada0100_4a03b773',NULL),(29,'2015-05-08 07:31:33','Patch Set 1:\n\nThough arguably if we need to handle sigterm to do this nicely then\nwe may as well just use it to send the controller a cancel event.\n\nAlso \n\n > It would be better to do this when the process ends, which we can\'t\n > do reliably, but could probably do well enough by handling sigterm\n > ourselves.\n\nThough arguably if we need to handle sigterm to do this nicely then\nwe may as well just use it to send the controller a cancel event.',605,1,605,'bada0100_4a3ad737',NULL),(39,'2015-05-12 10:59:25','Patch Set 4:\n\n(1 comment)\n\nGiven that everything works fine I\'m wary about giving -1, but I wonder if we want this being sent to the user multiple times on running a regular distbuild',605,4,605,'bada0100_575cbb25',NULL),(29,'2015-05-11 13:34:41','Patch Set 2:\n\n(1 comment)',605,2,605,'bada0100_65dd8c14',NULL),(39,'2015-05-12 13:33:40','Patch Set 7: Code-Review+1\n\nThis works fine, thanks!',605,7,605,'bada0100_775e9feb',NULL),(16,'2015-05-08 12:17:18','Uploaded patch set 2.',605,2,605,'bada0100_852bd081',NULL),(16,'2015-05-12 10:43:07','Uploaded patch set 4.',605,4,605,'bada0100_972b0382',NULL),(29,'2015-05-12 13:12:58','Patch Set 6:\n\n(1 comment)',605,6,605,'bada0100_973c6395',NULL),(16,'2015-05-12 13:40:19','Patch Set 7: Code-Review+2',605,7,605,'bada0100_976303b1',NULL),(16,'2015-05-12 12:33:29','Patch Set 6: Commit message was updated',605,6,605,'bada0100_97eea321',NULL),(39,'2015-05-11 12:01:48','Patch Set 2: Code-Review-1\n\n(2 comments)\n\nThere are a couple of issues I feel should be addressed before I am comfortable giving a +1',605,2,605,'bada0100_a5c7f463',NULL),(29,'2015-05-08 10:52:46','Patch Set 1:\n\n> \n > We already have a SIGINT handler, which might be enough for now:\n > \n\nYes sorry sigint would be fine I think',605,1,605,'bada0100_aa2ee3a3',NULL),(29,'2015-05-12 13:29:58','Patch Set 7: Code-Review+1\n\nLooks good, thanks for the fix as well :)',605,7,605,'bada0100_b75407cb',NULL),(29,'2015-05-12 12:54:40','Patch Set 6: Code-Review-1\n\n(2 comments)',605,6,605,'bada0100_b7e64743',NULL),(16,'2015-05-12 08:55:09','Patch Set 3:\n\n> I wouldn\'t do it this way,\n > \n > We could now move the _handle_build_started_message function out of\n > the InitiatorStart class and into the Initiator class. You might\n > want to tweak the existing message slightly to mention morph\n > distbuild-cancel.\n\nI was using _handle_build_started_message in version 1 of this patch, but that caused a traceback if ctrl+c was done when calculating the build graph since that message isn\'t sent until the first item starts building.',605,3,605,'bada0100_c5a6b853',NULL),(6,'2015-05-08 08:53:39','Patch Set 1:\n\n> Though arguably if we need to handle sigterm to do this nicely then\n > we may as well just use it to send the controller a cancel event.\n > \n > Also\n > \n > > It would be better to do this when the process ends, which we\n > can\'t\n > > do reliably, but could probably do well enough by handling\n > sigterm\n > > ourselves.\n > \n > Though arguably if we need to handle sigterm to do this nicely then\n > we may as well just use it to send the controller a cancel event.\n\nWe already have a SIGINT handler, which might be enough for now: ',605,1,605,'bada0100_ca4567b4',NULL),(16,'2015-05-12 09:17:39','Patch Set 3:\n\n> Ahh well that\'s another point, we could get a sigint before\n > _handle_graphing_started has been called couldn\'t we?\n > To get around that I guess we can set connection_id to None in\n > the initiator\'s __init__ and then output \"ID\" if it\'s None.\n \nThat makes sense I guess. In practice the gap between running the command and _handle_graphing_started being called was negligible, but it\'s better to be safe! Outputting \"ID\" makes sense to me.',605,3,605,'bada0100_e55dfc49',NULL),(29,'2015-05-11 13:40:31','Patch Set 3: Code-Review-1\n\nI wouldn\'t do it this way,\n\nWe could now move the _handle_build_started_message function out of the InitiatorStart class and into the Initiator class. You might\nwant to tweak the existing message slightly to mention morph\ndistbuild-cancel.',605,3,605,'bada0100_e5d09cf9',NULL),(16,'2015-05-12 13:19:18','Uploaded patch set 7.',605,7,605,'bada0100_f74a8f26',NULL),(16,'2015-05-11 12:48:58','Patch Set 2: Code-Review-1\n\n(2 comments)\n\nTwo minor nitpicks which cause problems for ./check. Other than those this looks fine and works nicely.',606,2,606,'bada0100_05928057',NULL),(29,'2015-05-12 07:33:05','Change has been successfully rebased as f4360e39ecf9e53347c58d2480fde0cd8402579d',606,4,606,'bada0100_05ffe035',NULL),(29,'2015-05-08 09:58:58','Uploaded patch set 2.',606,2,606,'bada0100_2ab6738b',NULL),(16,'2015-05-11 13:07:19','Patch Set 4: Code-Review+1',606,4,606,'bada0100_45872810',NULL),(29,'2015-05-12 07:33:00','Patch Set 4: Code-Review+2',606,4,606,'bada0100_45ede88a',NULL),(16,'2015-05-11 12:59:21','Patch Set 3: Code-Review+1\n\nLooks good to me now!',606,3,606,'bada0100_65882c23',NULL),(29,'2015-05-08 09:44:23','Uploaded patch set 1.',606,1,606,'bada0100_6a79dbfb',NULL),(29,'2015-05-11 13:03:44','Uploaded patch set 4.',606,4,606,'bada0100_858d1034',NULL),(39,'2015-05-11 13:42:16','Patch Set 4: Code-Review+1\n\nLooks good, +1',606,4,606,'bada0100_a5da9415',NULL),(29,'2015-05-11 12:57:56','Uploaded patch set 3.',606,3,606,'bada0100_c59b1871',NULL),(29,'2015-05-08 09:48:59','Patch Set 1: Code-Review-1\n\nThis updates the protocol without updating the version.',606,1,606,'bada0100_ca732714',NULL),(29,'2015-05-12 07:33:04','Patch Set 5: Patch Set 4 was rebased',606,4,606,'bada0100_e5017c3a',NULL),(39,'2015-05-11 09:36:52','Patch Set 2: Code-Review+1\n\nTested working fine',606,2,606,'bada0100_e5dc1c77',NULL),(39,'2015-05-11 09:37:26','Patch Set 2: Code-Review+1\n\nCode looks good and works fine',607,2,607,'bada0100_05da8078',NULL),(29,'2015-05-12 07:34:41','Change has been successfully merged into the git repository.',607,3,607,'bada0100_259f8405',NULL),(29,'2015-05-08 09:58:58','Uploaded patch set 2.',607,2,607,'bada0100_4abbb772',NULL),(29,'2015-05-12 07:34:11','Patch Set 3: Patch Set 2 was rebased',607,2,607,'bada0100_65958ce3',NULL),(29,'2015-05-12 07:34:39','Patch Set 3: Code-Review+2',607,3,607,'bada0100_859af012',NULL),(29,'2015-05-08 09:44:23','Uploaded patch set 1.',607,1,607,'bada0100_8a7e7fe3',NULL),(16,'2015-05-11 12:57:15','Patch Set 2: Code-Review+1\n\nLooks fine to me',607,2,607,'bada0100_a59e1462',NULL),(29,'2015-05-12 07:33:55','Patch Set 2: Code-Review+2',607,2,607,'bada0100_a5fb7446',NULL),(NULL,'2015-05-12 07:33:58','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ib2af8736, however the current patch set is 5.\n\nPlease rebase the change and upload a replacement commit.',607,2,607,'bada0100_c5f8f84b',NULL),(7,'2015-05-08 10:04:38','Change has been successfully merged into the git repository.',608,1,608,'bada0100_0aadaf31',NULL),(6,'2015-05-08 09:58:48','Uploaded patch set 1.',608,1,608,'bada0100_8ac19fe6',NULL),(7,'2015-05-08 10:04:35','Patch Set 1: Code-Review+2\n\nThis looks like a really good idea.',608,1,608,'bada0100_eaaf0b2a',NULL),(16,'2015-05-08 10:08:54','Abandoned',609,1,609,'bada0100_4a72d7e6',NULL),(16,'2015-05-08 10:08:25','Uploaded patch set 1.',609,1,609,'bada0100_aaa90326',NULL),(16,'2015-05-08 10:08:49','Abandoned',610,1,610,'bada0100_2a6d1305',NULL),(16,'2015-05-08 10:08:25','Uploaded patch set 1.',610,1,610,'bada0100_caa6c753',NULL),(16,'2015-05-08 10:08:25','Uploaded patch set 1.',611,1,611,'bada0100_6a631b1b',NULL),(16,'2015-05-08 10:08:45','Abandoned',611,1,611,'bada0100_8a68bff6',NULL),(7,'2015-05-08 11:44:43','Patch Set 1: Code-Review+2',612,1,612,'bada0100_0510404d',NULL),(7,'2015-05-08 11:40:20','Patch Set 1: Code-Review+1',612,1,612,'bada0100_2509c42c',NULL),(6,'2015-05-08 11:41:10','Patch Set 1:\n\nThis fixes ./check',612,1,612,'bada0100_450e4836',NULL),(6,'2015-05-08 11:38:18','Uploaded patch set 1.',612,1,612,'bada0100_85043016',NULL),(7,'2015-05-08 11:44:45','Change has been successfully merged into the git repository.',612,1,612,'bada0100_a51cd46b',NULL),(28,'2015-05-08 11:43:16','Patch Set 1: Code-Review+1',612,1,612,'bada0100_e512dc57',NULL),(7,'2015-05-08 13:45:38','Patch Set 1: Code-Review+2\n\nThis makes sense to me, but I agree with Paul, we should do something with this versioning mess',613,1,613,'bada0100_4525e8a9',NULL),(18,'2015-05-08 12:15:48','Patch Set 1: Code-Review+1\n\nok, but this is a mess we need to clean up.',613,1,613,'bada0100_6526ecbc',NULL),(6,'2015-05-08 12:14:01','Uploaded patch set 1.',613,1,613,'bada0100_c519d87a',NULL),(7,'2015-05-08 13:45:42','Change has been successfully merged into the git repository.',613,1,613,'bada0100_e5397cd9',NULL),(34,'2015-05-08 15:12:21','Patch Set 2: Commit message was updated',614,2,614,'bada0100_053e00b9',NULL),(7,'2015-05-08 15:17:52','Change has been successfully rebased as a98dd15c06e6513f70402d21be76e5a305e2a98c',614,4,614,'bada0100_0565a0e0',NULL),(22,'2015-05-08 15:17:13','Patch Set 4: Code-Review+1\n\nThanks for fixing!',614,4,614,'bada0100_256ea4ca',NULL),(22,'2015-05-08 14:57:14','Patch Set 1:\n\n@Javier -- Good question. This was discussed extensively on IRC (in #baserock today) and you and I spoke about it last week. The answer is because the git repository does not contain all of the source code required to build from and it cannot, as far as we could see, be programatically created.\n\n@Zara, I think this should be explained in the commit message at least and other people more familiar with this repository might want it in a README or in documentation.',614,1,614,'bada0100_455c0826',NULL),(7,'2015-05-08 15:17:50','Patch Set 4: Code-Review+2',614,4,614,'bada0100_4573a8b1',NULL),(15,'2015-05-08 15:14:46','Patch Set 4: Code-Review+1\n\nThanks for the explanation',614,4,614,'bada0100_6574ac9c',NULL),(16,'2015-05-08 15:15:08','Patch Set 4: Code-Review+1',614,4,614,'bada0100_85799095',NULL),(34,'2015-05-08 14:24:19','Uploaded patch set 1.',614,1,614,'bada0100_a53374f5',NULL),(34,'2015-05-08 15:12:31','Patch Set 3: Commit message was updated',614,3,614,'bada0100_a54a9453',NULL),(15,'2015-05-08 14:50:40','Patch Set 1:\n\nWhy do we need to lorry the tarball for this when we already have the git repo?',614,1,614,'bada0100_c530f8ea',NULL),(15,'2015-05-08 15:14:32','Patch Set 4: Commit message was updated',614,4,614,'bada0100_c547984a',NULL),(16,'2015-05-08 15:03:07','Patch Set 1:\n\nI\'d be fine with it just being explained in the commit message.',614,1,614,'bada0100_e5409c37',NULL),(7,'2015-05-08 15:17:51','Patch Set 5: Patch Set 4 was rebased',614,4,614,'bada0100_e5673ce9',NULL),(37,'2015-05-11 09:15:03','Change has been successfully merged into the git repository.',615,1,615,'bada0100_65e90c1a',NULL),(16,'2015-05-11 09:10:29','Uploaded patch set 1.',615,1,615,'bada0100_a58ff474',NULL),(37,'2015-05-11 09:14:58','Patch Set 1: Code-Review+2',615,1,615,'bada0100_c58c7882',NULL),(6,'2015-05-11 11:00:22','Change has been successfully rebased as d22a4a27b77e229207d43d8040f2168ae30e64f5',616,1,616,'bada0100_2526a469',NULL),(6,'2015-05-11 09:48:06','Patch Set 1: Code-Review+1\n\nThanks for spotting this, looks like I screwed up rebasing https://gerrit.baserock.org/#/c/422/ and then merged it without checking. This bug is in the version of Morph released with Baserock reference systems 15.19, once the fix is tested and merged I\'ll reply to the release announcement mail pointing this out.',616,1,616,'bada0100_45cf28b1',NULL),(6,'2015-05-11 11:00:18','Patch Set 1: Code-Review+2',616,1,616,'bada0100_652cac4b',NULL),(6,'2015-05-11 11:00:22','Patch Set 2: Patch Set 1 was rebased',616,1,616,'bada0100_853190a4',NULL),(6,'2015-05-11 10:17:35','Patch Set 1:\n\nI\'ve updated Morph to this commit on and and it seems to have stopped the runaway failures (they were updated to Morph from 15.19 over the weekend)',616,1,616,'bada0100_853c3095',NULL),(39,'2015-05-11 09:42:14','Uploaded patch set 1.',616,1,616,'bada0100_85d51045',NULL),(7,'2015-05-11 10:56:25','Patch Set 1: Code-Review+1\n\nThis seems to be working fine on Mason! Thanks for the fix, I really wondered what was going on :)',616,1,616,'bada0100_c5ff98a9',NULL),(29,'2015-05-12 07:47:00','Patch Set 2: Patch Set 1 was rebased',617,1,617,'bada0100_058600ba',NULL),(29,'2015-05-11 13:09:54','Uploaded patch set 1.',617,1,617,'bada0100_2599c46e',NULL),(6,'2015-05-11 15:17:55','Patch Set 1: Code-Review+2',617,1,617,'bada0100_451168ab',NULL),(29,'2015-05-12 07:47:55','Patch Set 2: Code-Review+2',617,2,617,'bada0100_a59294f4',NULL),(29,'2015-05-12 07:47:58','Change has been successfully merged into the git repository.',617,2,617,'bada0100_c58f98cb',NULL),(29,'2015-05-11 14:09:21','Patch Set 1: Code-Review-1\n\n(2 comments)\n\nIf you\'re wanting to add a bottle stratum it\'s probably best to modify existing systems that get bottle from the python-wsgi stratum to use the bottle stratum.\n\nIs there some reason you can\'t use the existing python-wsgi stratum?',618,1,618,'bada0100_05f5a082',NULL),(6,'2015-05-11 15:17:21','Patch Set 1:\n\nBottle is needed for morph-cache-server which is fairly easy to test using the distbuild test harness from . I\'d prefer if we could just use the latest release of \'bottle\' everywhere.',618,1,618,'bada0100_250c6494',NULL),(8,'2015-05-12 09:13:01','Patch Set 1:\n\n> (2 comments)\n > \n > It looks like we\'ll need the Bottle stratum for putting OpenBMC on\n > Baserock. The version of Bottle used in the wedge system (that\n > we\'re looking at for guidance) is different from the version of\n > Bottle in the python-wsgi stratum. It might not actually be a\n > problem, but since we can\'t test it yet, I\'m just erring on the\n > side of caution. I could try using python-wsgi for now and revive\n > this patch later if things go horribly wrong. :)\n\nIf you are going to do what you are describing please, abandon this patch.',618,1,618,'bada0100_25446473',NULL),(34,'2015-05-12 09:40:48','Abandoned\n\nAbandoned, at least for now.',618,1,618,'bada0100_45172852',NULL),(34,'2015-05-11 14:36:10','Patch Set 1:\n\n(2 comments)\n\nIt looks like we\'ll need the Bottle stratum for putting OpenBMC on Baserock. The version of Bottle used in the wedge system (that we\'re looking at for guidance) is different from the version of Bottle in the python-wsgi stratum. It might not actually be a problem, but since we can\'t test it yet, I\'m just erring on the side of caution. I could try using python-wsgi for now and revive this patch later if things go horribly wrong. :)',618,1,618,'bada0100_453ac837',NULL),(34,'2015-05-11 14:03:04','Uploaded patch set 1.',618,1,618,'bada0100_85099097',NULL),(6,'2015-05-11 15:30:07','Patch Set 2: Code-Review+1',619,2,619,'bada0100_056a801a',NULL),(16,'2015-05-12 13:01:14','Change has been successfully rebased as 43fed1ea4c6c988a08bff1a2c61087116b4a1cb1',619,2,619,'bada0100_37ca57a2',NULL),(16,'2015-05-12 13:01:11','Patch Set 2: Code-Review+2',619,2,619,'bada0100_77d0df53',NULL),(6,'2015-05-11 15:27:42','Patch Set 2: Commit message was updated',619,2,619,'bada0100_857e70e3',NULL),(29,'2015-05-12 07:53:59','Patch Set 2: Code-Review+1',619,2,619,'bada0100_85c190e6',NULL),(16,'2015-05-12 13:01:13','Patch Set 3: Patch Set 2 was rebased',619,2,619,'bada0100_97d54345',NULL),(16,'2015-05-11 15:23:53','Uploaded patch set 1.',619,1,619,'bada0100_a51ff4b6',NULL),(6,'2015-05-11 15:29:59','Patch Set 1:\n\nThis is reverting https://gerrit.baserock.org/#/c/421/',619,1,619,'bada0100_e56c1c39',NULL),(16,'2015-05-12 09:08:56','Uploaded patch set 3.',620,3,620,'bada0100_0574c0cd',NULL),(16,'2015-05-12 08:35:35','Patch Set 2:\n\n(1 comment)',620,2,620,'bada0100_05ada031',NULL),(16,'2015-05-12 13:01:31','Change has been successfully rebased as eb9e43d4ffe992cd66945a7d7fa2feb00ee49473',620,3,620,'bada0100_17c15380',NULL),(6,'2015-05-11 15:28:51','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLooks good',620,1,620,'bada0100_458888e7',NULL),(29,'2015-05-12 08:26:33','Patch Set 2:\n\n(1 comment)',620,2,620,'bada0100_45bba872',NULL),(16,'2015-05-12 13:01:28','Patch Set 3: Code-Review+2',620,3,620,'bada0100_57cfdbb0',NULL),(16,'2015-05-11 15:35:26','Uploaded patch set 2.',620,2,620,'bada0100_85651047',NULL),(29,'2015-05-12 08:55:32','Patch Set 2: Code-Review+1\n\n(1 comment)',620,2,620,'bada0100_8568b0f6',NULL),(16,'2015-05-11 15:23:53','Uploaded patch set 1.',620,1,620,'bada0100_c51c78c4',NULL),(29,'2015-05-12 12:57:57','Patch Set 3: Code-Review+1\n\nI do still feel we should fix the underlying problem here,\nbut I have no objection to having this fix for the time being,\nindeed, thanks for the fix :)',620,3,620,'bada0100_d7e3cb31',NULL),(6,'2015-05-11 15:50:26','Patch Set 2: Code-Review+1',620,2,620,'bada0100_e553bc6a',NULL),(16,'2015-05-12 13:01:31','Patch Set 4: Patch Set 3 was rebased',620,3,620,'bada0100_f7c36f88',NULL),(29,'2015-05-11 16:13:20','Patch Set 1: Code-Review+2',621,1,621,'bada0100_05512062',NULL),(6,'2015-05-11 15:35:09','Patch Set 1: Code-Review+1\n\nLooks sensible. This might have been avoided if the different distbuild commands shared a common subclass!',621,1,621,'bada0100_65602c36',NULL),(39,'2015-05-11 15:25:08','Uploaded patch set 1.',621,1,621,'bada0100_65790cfc',NULL),(29,'2015-05-11 16:13:24','Change has been successfully merged into the git repository.',621,1,621,'bada0100_a54db4c6',NULL),(6,'2015-05-19 09:13:34','Patch Set 8: Code-Review+1',622,8,622,'9adffdf1_0f5aa583',NULL),(37,'2015-05-19 09:15:28','Patch Set 8: Code-Review+2',622,8,622,'9adffdf1_2f5f6974',NULL),(29,'2015-05-19 09:21:15','Change has been successfully merged into the git repository.',622,9,622,'9adffdf1_4fc74d13',NULL),(39,'2015-05-18 08:41:17','Patch Set 8: Code-Review+1',622,8,622,'9adffdf1_8f8f7575',NULL),(29,'2015-05-19 09:21:13','Patch Set 9: Code-Review+2',622,9,622,'9adffdf1_af4a79aa',NULL),(29,'2015-05-15 16:11:27','Uploaded patch set 8.',622,8,622,'9adffdf1_afb59932',NULL),(NULL,'2015-05-19 09:19:29','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Id3ee3298, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',622,8,622,'9adffdf1_cf533d6b',NULL),(29,'2015-05-19 09:19:56','Patch Set 9: Patch Set 8 was rebased',622,8,622,'9adffdf1_ef508160',NULL),(39,'2015-05-12 15:04:33','Patch Set 4: Code-Review+1\n\nThis looks fine',622,4,622,'bada0100_171dd30f',NULL),(29,'2015-05-12 10:47:06','Uploaded patch set 4.',622,4,622,'bada0100_173713e5',NULL),(6,'2015-05-12 09:35:39','Patch Set 3:\n\n(1 comment)',622,3,622,'bada0100_25122463',NULL),(29,'2015-05-12 07:10:18','Patch Set 3: Commit message was updated',622,3,622,'bada0100_25e8e47b',NULL),(39,'2015-05-14 08:12:42','Patch Set 7: Code-Review+1\n\nThis looks fine',622,7,622,'bada0100_376d7705',NULL),(29,'2015-05-11 15:49:25','Uploaded patch set 1.',622,1,622,'bada0100_455f2873',NULL),(39,'2015-05-13 13:30:25','Patch Set 6:\n\n(1 comment)',622,6,622,'bada0100_573a7b37',NULL),(16,'2015-05-14 08:43:47','Patch Set 7: Code-Review+1',622,7,622,'bada0100_57727be6',NULL),(37,'2015-05-13 14:43:45','Patch Set 6: Code-Review+1\n\n(2 comments)\n\nLooks mostly good to me. I\'d be happy to merge if we can have some clarification on the purpose of the except block in the original version.',622,6,622,'bada0100_57883be7',NULL),(6,'2015-05-12 15:31:40','Patch Set 4: Code-Review-1\n\nThis still removes the exception handler, despite the commit message saying nothing about that',622,4,622,'bada0100_77ba1fe3',NULL),(6,'2015-05-15 10:42:24','Patch Set 7:\n\n(1 comment)',622,7,622,'bada0100_7a2c464b',NULL),(6,'2015-05-12 09:10:06','Patch Set 3:\n\nIt makes sense now that the problem was trying to do int(None)',622,3,622,'bada0100_854f5092',NULL),(6,'2015-05-11 16:24:40','Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI don\'t see how this changes the behaviour when protocol_version isn\'t specified: get() returns None by default.\n\nThe \'except (KeyError, ValueError)\' block is unrelated to that and should not be removed (it should have a comment above it to make that clear, though, since obviously it wasn\'t clear)',622,1,622,'bada0100_85cc3037',NULL),(29,'2015-05-12 07:06:01','Patch Set 1:\n\n(2 comments)',622,1,622,'bada0100_85f3d072',NULL),(29,'2015-05-14 08:11:19','Patch Set 6:\n\n(1 comment)',622,6,622,'bada0100_9768e3f6',NULL),(29,'2015-05-12 09:52:25','Patch Set 3: Code-Review-1\n\n(2 comments)',622,3,622,'bada0100_a505b415',NULL),(29,'2015-05-12 09:26:55','Patch Set 3:\n\n(1 comment)',622,3,622,'bada0100_a52e14a4',NULL),(29,'2015-05-12 07:04:03','Uploaded patch set 2.',622,2,622,'bada0100_a5e4d4ac',NULL),(29,'2015-05-13 08:29:07','Patch Set 5:\n\nThe two changes in this topic started to make less sense as separate changes so I\'ve merged them, the issue Sam spotted with missing \'type\' field has been addressed as has the response message.\n\nDuring testing I\'ve found that this still isn\'t robust against all inputs,\nthe json machine will not generate a JsonNewMessage event if we are sent a message we can\'t decode or even just an empty dict, this means we create all the state machines for a new connection receive an invalid message but never refuse it / shut down our state machines. Not sure how best to handle this yet.',622,5,622,'bada0100_b7ac078e',NULL),(29,'2015-05-13 09:49:20','Uploaded patch set 6.',622,6,622,'bada0100_b7c3a737',NULL),(6,'2015-05-13 15:18:48','Patch Set 6:\n\n(2 comments)',622,6,622,'bada0100_b7e407ad',NULL),(6,'2015-05-15 10:45:30','Patch Set 7:\n\nI think it might still be possible to trigger an unhandled ValueError with an appropriately pathological input message, because the is_valid_message() function doesn\'t do any type checking. I think this patch makes the code much clearer on the whole, but I still think it\'s a good idea to wrap all the code that processes messages received on the initiator port in a \'try: except:\' block as well so that it\'s completely impossible to crash the controller by sending it wonky messages.',622,7,622,'bada0100_ba194e24',NULL),(29,'2015-05-15 11:19:33','Patch Set 7: Code-Review-1\n\n(1 comment)\n\n> I think it might still be possible to trigger an unhandled\n > ValueError with an appropriately pathological input message,\n > because the is_valid_message() function doesn\'t do any type\n > checking. I think this patch makes the code much clearer on the\n > whole, but I still think it\'s a good idea to wrap all the code that\n > processes messages received on the initiator port in a \'try:\n > except:\' block as well so that it\'s completely impossible to crash\n > the controller by sending it wonky messages.\n\nI agree, except that I think that to be on the safe side we should\ncatch and log Exception when we try to handle a message.\n\nAside from this, there\'s a pretty easy denial of service attack\n(ignoring the fact that you can cancel other users\' requests without auth)\nif you send the controller an empty string or a string representing an\nempty dict then the InitiatorConnection machine gets started up\nbut nothing gets passed to it so it won\'t refuse and shut down,\nit will just hang there.\n\nSo if the message doesn\'t pass our validation or handling it raises\nan Exception, then we should get rid of the state machine.',622,7,622,'bada0100_ba9e2e62',NULL),(6,'2015-05-12 09:09:29','Patch Set 3:\n\n(2 comments)\n\nThanks for reworking! it\'s still lacking the \'except:\' block though unless I\'m somehow looking at the wrong version of the patch',622,3,622,'bada0100_c57d58b3',NULL),(29,'2015-05-14 08:05:59','Uploaded patch set 7.',622,7,622,'bada0100_d7a66b53',NULL),(6,'2015-05-15 11:29:28','Patch Set 7:\n\n> (1 comment)\n > \n > I agree, except that I think that to be on the safe side we should\n > catch and log Exception when we try to handle a message.\n\nI think we agree then, logging exceptions that were swallowed is very sensible.\n \n > Aside from this, there\'s a pretty easy denial of service attack\n > (ignoring the fact that you can cancel other users\' requests\n > without auth)\n > if you send the controller an empty string or a string representing\n > an\n > empty dict then the InitiatorConnection machine gets started up\n > but nothing gets passed to it so it won\'t refuse and shut down,\n > it will just hang there.\n > \n > So if the message doesn\'t pass our validation or handling it raises\n > an Exception, then we should get rid of the state machine.\n\nGood spot. It\'s fine to defer fixing that to a different patch in my opinion. (We are still a long way from being able to actually safely expose the controller initiator port to the internet, but we\'ve already done that anyway, so it\'s useful to think about these things)',622,7,622,'bada0100_da721249',NULL),(29,'2015-05-13 08:21:49','Uploaded patch set 5.',622,5,622,'bada0100_f7a28f99',NULL),(16,'2015-05-13 11:46:31','Patch Set 6: Code-Review+1\n\nThis seems fine to me.',622,6,622,'bada0100_f7d04ff9',NULL),(16,'2015-05-11 16:38:57','Uploaded patch set 1.',623,1,623,'bada0100_25d1c4cd',NULL),(6,'2015-05-12 09:19:21','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks useful, thanks!',623,2,623,'bada0100_a557f425',NULL),(16,'2015-05-12 08:52:28','Uploaded patch set 2.',623,2,623,'bada0100_a5a93426',NULL),(16,'2015-05-12 15:02:13','Patch Set 2: Code-Review-1\n\nThere are some bugs in this which make it annoying to use and/or not work.',623,2,623,'bada0100_f71fef07',NULL),(37,'2015-05-22 14:29:06','Patch Set 3: Code-Review+2',624,3,624,'5ac10518_4d3759b1',NULL),(37,'2015-05-22 14:29:07','Change has been successfully merged into the git repository.',624,3,624,'5ac10518_6d3c9594',NULL),(8,'2015-05-22 13:37:48','Patch Set 3: Code-Review+1',624,3,624,'5ac10518_edd96584',NULL),(37,'2015-05-19 10:15:19','Patch Set 2:\n\nI\'m a stupid teapot, here\'s my spout.\nWe have a morphology file for initramfs-scripts in definitions.git',624,2,624,'9adffdf1_0f9f0505',NULL),(32,'2015-05-19 09:40:35','Patch Set 2:\n\n> Daniel: It would also need to have a ./configure file to be\n > detected as any of our build systems.\n > \n > I think it is appropriate to add one, so I\'ll update this patch\n > series and re-send.\n\nI have no problem with requiring a chunk morphology file in definitions, but\nI think the behaviour should be in a Makefile in the chunk repository.\n\nA .morph which simply has:\n\nkind: chunk\nname: initramfs-scripts\ninstall-commands:\n- make install\n\nseems fine to me.',624,2,624,'9adffdf1_2fed298c',NULL),(37,'2015-05-19 09:38:19','Patch Set 2:\n\nDaniel: It would also need to have a ./configure file to be detected as any of our build systems.\n\nI think it is appropriate to add one, so I\'ll update this patch series and re-send.',624,2,624,'9adffdf1_6ff33174',NULL),(7,'2015-05-18 10:29:54','Patch Set 2: Code-Review+1\n\nThis looks OK to me.',624,2,624,'9adffdf1_8f5455cb',NULL),(7,'2015-05-19 15:53:01','Patch Set 3: Code-Review+1',624,3,624,'9adffdf1_b28c1e81',NULL),(32,'2015-05-18 09:58:43','Patch Set 2: Code-Review+1\n\nIt makes me sad that this chunk has a .morph where it should have a Makefile. The change is reasonable but I don\'t like the .morph',624,2,624,'9adffdf1_cfc33d89',NULL),(37,'2015-05-19 15:44:43','Uploaded patch set 3.',624,3,624,'9adffdf1_d2952289',NULL),(37,'2015-05-12 10:39:51','Patch Set 1:\n\nPlease see http://listmaster.pepperfish.net/pipermail/baserock-dev-baserock.org/2015-May/012997.html for a rationale.',624,1,624,'bada0100_3709f72c',NULL),(37,'2015-05-11 16:57:27','Uploaded patch set 1.',624,1,624,'bada0100_45d648c7',NULL),(37,'2015-05-12 11:59:05','Patch Set 1:\n\n(1 comment)',624,1,624,'bada0100_57735bb1',NULL),(37,'2015-05-12 12:03:53','Uploaded patch set 2.',624,2,624,'bada0100_f767efe8',NULL),(7,'2015-05-22 11:34:20','Patch Set 2: Code-Review+1',625,2,625,'5ac10518_cdaee9e7',NULL),(37,'2015-05-19 15:44:27','Uploaded patch set 2.',625,2,625,'9adffdf1_127c0a72',NULL),(7,'2015-05-18 10:45:31','Patch Set 1: Code-Review+1\n\nI agree with Sam. A comment might be useful (if possible)',625,1,625,'9adffdf1_4f050dc1',NULL),(37,'2015-05-19 09:36:42','Patch Set 1: Code-Review-1\n\nComments can be added, and it would indeed be appropriate to add one. I\'ll update the series.',625,1,625,'9adffdf1_4fee6d8d',NULL),(6,'2015-05-20 12:37:48','Patch Set 2: Code-Review+1',625,2,625,'9adffdf1_52885222',NULL),(6,'2015-05-18 10:22:54','Patch Set 1: Code-Review+1\n\nIs it possible to add a comment to shutdownfs.conf to explain why it\'s needed? Just a link to the email that you linked to in the comment above would be fine.\n\nI don\'t know how to test this, but it seems fine to merge.',625,1,625,'9adffdf1_8fbd3505',NULL),(37,'2015-05-12 10:39:58','Patch Set 1:\n\nPlease see http://listmaster.pepperfish.net/pipermail/baserock-dev-baserock.org/2015-May/012997.html for a rationale.',625,1,625,'bada0100_570efb35',NULL),(37,'2015-05-11 17:03:36','Uploaded patch set 1.',625,1,625,'bada0100_e5dadce8',NULL),(37,'2015-05-27 14:16:44','Change has been successfully rebased as 9be39cd71592cfd77619afc732f66649c3bb66da',625,2,625,'fab9d9a7_0af37b0b',NULL),(37,'2015-05-27 14:16:35','Patch Set 2: Code-Review+2',625,2,625,'fab9d9a7_4ae97319',NULL),(37,'2015-05-27 14:16:43','Patch Set 3: Patch Set 2 was rebased',625,2,625,'fab9d9a7_6aeeb724',NULL),(24,'2015-05-11 17:06:40','Uploaded patch set 1.',626,1,626,'bada0100_05d840ee',NULL),(24,'2015-05-12 09:21:50','Uploaded patch set 2.',626,2,626,'bada0100_65310c0b',NULL),(8,'2015-05-12 09:09:35','Patch Set 1:\n\n(1 comment)\n\nother than then comment the patch looks ok.',626,1,626,'bada0100_654a6c85',NULL),(8,'2015-05-13 08:42:39','Change has been successfully merged into the git repository.',626,2,626,'bada0100_77b69fde',NULL),(34,'2015-05-12 11:57:10','Patch Set 2: Code-Review+1',626,2,626,'bada0100_9779c395',NULL),(8,'2015-05-13 08:42:36','Patch Set 2: Code-Review+2',626,2,626,'bada0100_d7a98b7c',NULL),(8,'2015-05-12 09:25:20','Patch Set 2: Code-Review+1',626,2,626,'bada0100_e5241cc8',NULL),(29,'2015-05-13 08:22:57','Abandoned\n\nMerged into https://gerrit.baserock.org/622',627,2,627,'bada0100_17a0738f',NULL),(29,'2015-05-12 16:10:12','Uploaded patch set 2.',627,2,627,'bada0100_17cb9373',NULL),(6,'2015-05-12 15:39:58','Patch Set 1:\n\nI know we\'re entering the realm of pathological test cases here, but if we ever want to be able to have a distbuild controller that\'s accessible over the internet, it needs to be robust against *everything* that can be sent to it.\n\nI can crash the controller now by sending a message without a \'type\' field, for example, try this (where \'host\' and \'port\' point to a distbuild controller):\n\n$ nc host port\n\"{nonsense: false}\\n\"\n\nThe controller crashes with:\n\n 2015-05-12 15:30:58 CRITICAL Traceback (most recent call last):\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 190, in _run\n self.process_args(args)\n File \"/src/morph/morphlib/app.py\", line 290, in process_args\n cliapp.Application.process_args(self, args)\n File \"/usr/lib/python2.7/site-packages/cliapp/app.py\", line 539, in process_args\n method(args[1:])\n File \"/src/morph/morphlib/plugins/distbuild_plugin.py\", line 440, in controller_daemon\n loop.run()\n File \"/src/morph/distbuild/mainloop.py\", line 121, in run\n self._run_once()\n File \"/src/morph/distbuild/mainloop.py\", line 106, in _run_once\n for new_event in machine.handle_event(event_source, event):\n File \"/src/morph/distbuild/sm.py\", line 115, in handle_event\n ret = callback(event_source, event)\n File \"/src/morph/distbuild/initiator_connection.py\", line 125, in _handle_msg\n msg_type = event.msg[\'type\']\n KeyError: \'type\'\n\nI don\'t have a problem with adding a \'message_is_valid()\' function, but I don\'t think we can get away without having an exception handling block as well, if the input we are processing is untrusted (which messages from the initiator are).\n\nI also think it\'s weird to respond with \'Protocol version mismatch between server and initiator: distbuild\\n network uses distbuild protocol version 4, but client uses version 0.\' when invalid input is received: it\'s clearer just to say \'Invalid message received\'. The \'protocol version mismatch\' error was added specifically for the case where a user has the wrong version of Morph for the distbuild network they are trying to use, and doesn\'t make sense in other contexts.',627,1,627,'bada0100_37b497f1',NULL),(29,'2015-05-13 07:35:02','Patch Set 2: Code-Review-1\n\nConcern over confusion around response message seems fair, will rework.',627,2,627,'bada0100_579efb57',NULL),(6,'2015-05-12 15:40:47','Patch Set 1:\n\n> $ nc host port\n > \"{nonsense: false}\\n\"\n\nThis was meant to be:\n\n $ nc host port\n \"{nonsense: false}\\n\"',627,1,627,'bada0100_57b91be8',NULL),(39,'2015-05-12 15:19:50','Patch Set 1: Code-Review+1\n\nI am a bit concerned about sending a protocol error message for invalid build messages, but given that invalid messages fall under the banner of protocol errors I have no other objections.',627,1,627,'bada0100_77d3ff38',NULL),(29,'2015-05-12 10:47:06','Uploaded patch set 1.',627,1,627,'bada0100_b733a7f5',NULL),(6,'2015-05-12 12:47:25','Uploaded patch set 1.',628,1,628,'bada0100_37f3370c',NULL),(7,'2015-05-12 14:50:21','Change has been successfully merged into the git repository.',628,1,628,'bada0100_772c5f4b',NULL),(37,'2015-05-12 13:12:32','Patch Set 1: Code-Review+1',628,1,628,'bada0100_d7baeb09',NULL),(7,'2015-05-12 14:50:19','Patch Set 1: Code-Review+2',628,1,628,'bada0100_d7ff4ba9',NULL),(8,'2015-05-12 13:54:07','Patch Set 1: Code-Review+1',628,1,628,'bada0100_f7712f78',NULL),(8,'2015-05-12 13:54:41','Patch Set 1: Code-Review+1',629,1,629,'bada0100_176f1394',NULL),(7,'2015-05-12 14:50:24','Change has been successfully merged into the git repository.',629,1,629,'bada0100_3726d769',NULL),(37,'2015-05-12 13:16:21','Patch Set 1: Code-Review+1\n\n(1 comment)',629,1,629,'bada0100_5746fb24',NULL),(6,'2015-05-12 13:51:00','Patch Set 1:\n\nThanks for reviewing!\n\nThe fact that the README is Markdown at all is kind of because this repo once lived on Github. And on Github this Markdown does work as expected: https://github.com/ssssam/test-baserock-infrastructure/tree/sam/isolate-masons#masons',629,1,629,'bada0100_575d9be8',NULL),(6,'2015-05-12 12:47:25','Uploaded patch set 1.',629,1,629,'bada0100_57f83be5',NULL),(7,'2015-05-12 14:50:23','Patch Set 1: Code-Review+2',629,1,629,'bada0100_9731c3a4',NULL),(6,'2015-05-12 13:03:57','Patch Set 1:\n\nThis is running on https://mason-x86-32.baserock.org and https://mason-x86-64.baserock.org right now (1 build has succeeded on each of those since the config was changed)',629,1,629,'bada0100_b7bde704',NULL),(16,'2015-05-15 14:38:05','Change has been successfully rebased as 4131947a0a5a9957c76cf03264e67cbcc1494d4b',630,1,630,'9adffdf1_0f6e25ca',NULL),(16,'2015-05-15 14:38:03','Patch Set 1: Code-Review+2',630,1,630,'9adffdf1_4f742d9c',NULL),(16,'2015-05-15 14:38:05','Patch Set 2: Patch Set 1 was rebased',630,1,630,'9adffdf1_6f79f192',NULL),(29,'2015-05-14 09:18:28','Patch Set 1:\n\n(1 comment)',630,1,630,'bada0100_1774f3cd',NULL),(16,'2015-05-12 15:38:13','Uploaded patch set 1.',630,1,630,'bada0100_97bf83d0',NULL),(37,'2015-05-13 14:20:40','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nFrom my understanding of what happens, this looks like a reasonable approach.\nHowever my understanding is not complete, and I have questions about some of the state transitions, I\'d be happy to submit this for merge after my question is answered.',630,1,630,'bada0100_b71f27b7',NULL),(6,'2015-05-13 15:11:38','Patch Set 1:\n\n(1 comment)',630,1,630,'bada0100_d74aebab',NULL),(29,'2015-05-14 09:24:48','Patch Set 1:\n\n(1 comment)',630,1,630,'bada0100_d77d0bb3',NULL),(29,'2015-05-14 09:35:59','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThank you for this fix',630,1,630,'bada0100_f75daf49',NULL),(6,'2015-05-12 16:15:50','Change has been successfully merged into the git repository.',631,1,631,'bada0100_37ab378b',NULL),(8,'2015-05-12 16:13:30','Patch Set 1:\n\n> Patch Set 1: Code-Review+1\n\nSorry for breaking this...',631,1,631,'bada0100_77a1bfa8',NULL),(6,'2015-05-12 16:15:48','Patch Set 1: Code-Review+2',631,1,631,'bada0100_97a6a3c0',NULL),(7,'2015-05-12 16:12:31','Uploaded patch set 1.',631,1,631,'bada0100_b7c72764',NULL),(6,'2015-05-12 16:19:56','Patch Set 1:\n\nI am going to cherry-pick this for a baserock-15.19.1 release tag (so that `morph diff` against that release tag has a chance of working correctly)',631,1,631,'bada0100_d79bcb70',NULL),(8,'2015-05-12 16:13:11','Patch Set 1: Code-Review+1',631,1,631,'bada0100_d7c42b61',NULL),(6,'2015-05-12 16:18:51','Patch Set 1:\n\nI am going to cherry-pick this for a baserock-15.19.1 release tag',632,1,632,'bada0100_1792b357',NULL),(16,'2015-05-12 16:32:35','Patch Set 1: Code-Review+1',632,1,632,'bada0100_37825701',NULL),(6,'2015-05-12 16:33:49','Patch Set 1: Code-Review+2',632,1,632,'bada0100_5787db0f',NULL),(15,'2015-05-12 16:20:49','Patch Set 1: Code-Review+1',632,1,632,'bada0100_978d4334',NULL),(6,'2015-05-12 16:33:51','Change has been successfully merged into the git repository.',632,1,632,'bada0100_f77b6f27',NULL),(6,'2015-05-12 16:18:29','Uploaded patch set 1.',632,1,632,'bada0100_f794cf45',NULL),(16,'2015-05-15 13:24:32','Patch Set 6: Code-Review+1',633,6,633,'9adffdf1_4fff4d02',NULL),(6,'2015-05-15 14:05:18','Patch Set 6: Code-Review+1\n\nLooks fine to me now, thanks',633,6,633,'9adffdf1_6f049115',NULL),(29,'2015-05-15 14:19:02','Patch Set 7: Patch Set 6 was rebased',633,6,633,'9adffdf1_8f33f5f5',NULL),(29,'2015-05-15 14:19:02','Change has been successfully rebased as 8625124549dd4ae1a5b347a51c95c3f1887fb9ea',633,6,633,'9adffdf1_af3039e9',NULL),(29,'2015-05-15 14:18:34','Patch Set 6: Code-Review+2',633,6,633,'9adffdf1_cf39fdd9',NULL),(39,'2015-05-14 09:40:07','Uploaded patch set 3.',633,3,633,'bada0100_175b9355',NULL),(39,'2015-05-12 17:01:39','Uploaded patch set 1.',633,1,633,'bada0100_1779532f',NULL),(39,'2015-05-13 07:10:07','Patch Set 1:\n\n(1 comment)',633,1,633,'bada0100_3799f76e',NULL),(16,'2015-05-13 08:46:39','Patch Set 2:\n\n(1 comment)',633,2,633,'bada0100_37b017dd',NULL),(39,'2015-05-15 10:11:19','Uploaded patch set 5.',633,5,633,'bada0100_3a58fef9',NULL),(6,'2015-05-15 11:32:28','Patch Set 5:\n\n(2 comments)\n\nThanks, this looks good but I think it could be improved a little for clarity.',633,5,633,'bada0100_3a99de6e',NULL),(39,'2015-05-15 12:51:15','Uploaded patch set 6.',633,6,633,'bada0100_5ab5c2cb',NULL),(37,'2015-05-13 14:24:28','Patch Set 2: Code-Review+1\n\n(1 comment)',633,2,633,'bada0100_7779bffb',NULL),(39,'2015-05-13 07:08:44','Uploaded patch set 2.',633,2,633,'bada0100_778f7f24',NULL),(39,'2015-05-14 09:41:59','Uploaded patch set 4.',633,4,633,'bada0100_b7572726',NULL),(29,'2015-05-15 10:40:35','Patch Set 5: Code-Review+1\n\nThank you for removing this duplicated code :)',633,5,633,'bada0100_ba02aeb2',NULL),(39,'2015-05-15 07:53:24','Patch Set 4:\n\n(1 comment)',633,4,633,'bada0100_babdce04',NULL),(16,'2015-05-12 17:48:30','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nLooks good except for one bit of duplication, which probably came from some crossed wires with one of my patches.',633,1,633,'bada0100_d772eb48',NULL),(29,'2015-05-15 09:55:30','Patch Set 4:\n\n(1 comment)',633,4,633,'bada0100_da51b2d9',NULL),(16,'2015-05-14 14:05:24','Patch Set 4: Code-Review+1',633,4,633,'bada0100_fa67d6e8',NULL),(16,'2015-05-15 10:14:57','Patch Set 5: Code-Review+1',633,5,633,'bada0100_fa711678',NULL),(29,'2015-05-15 07:29:59','Patch Set 4: Code-Review-1\n\n(1 comment)',633,4,633,'bada0100_fac35688',NULL),(39,'2015-05-15 12:51:20','Patch Set 5:\n\n(2 comments)',633,5,633,'bada0100_fac9165b',NULL),(37,'2015-05-13 14:47:31','Patch Set 2: Patch Set 1 was rebased',634,1,634,'bada0100_176ab31a',NULL),(6,'2015-05-13 09:53:26','Patch Set 1: Code-Review+1\n\nThanks!',634,1,634,'bada0100_77dd3f14',NULL),(16,'2015-05-13 09:54:23','Patch Set 1: Code-Review+1\n\nLooks fine to me.',634,1,634,'bada0100_97e223d4',NULL),(37,'2015-05-13 14:47:31','Change has been successfully rebased as d7e86046706680828b141a21a77ab95419dfb58f',634,1,634,'bada0100_b7764705',NULL),(29,'2015-05-13 09:49:20','Uploaded patch set 1.',634,1,634,'bada0100_d7c0ab2c',NULL),(37,'2015-05-13 14:47:27','Patch Set 1: Code-Review+2\n\nLooks good to me as well.',634,1,634,'bada0100_f76ccf38',NULL),(16,'2015-05-13 13:03:10','Patch Set 1: Code-Review+1',635,1,635,'bada0100_17f5d382',NULL),(7,'2015-05-13 13:00:33','Uploaded patch set 1.',635,1,635,'bada0100_37fed76c',NULL),(8,'2015-05-13 13:01:58','Patch Set 1: Code-Review+1',635,1,635,'bada0100_57035b73',NULL),(7,'2015-05-13 13:06:21','Change has been successfully rebased as c26d0cce7bcd2505d23bd925207f14986c6edc5b',635,1,635,'bada0100_772bffeb',NULL),(28,'2015-05-13 13:05:38','Patch Set 1: Code-Review+1',635,1,635,'bada0100_b7f16797',NULL),(7,'2015-05-13 13:06:21','Patch Set 2: Patch Set 1 was rebased',635,1,635,'bada0100_d7ee6bb4',NULL),(8,'2015-05-13 13:02:57','Patch Set 1: Code-Review+2',635,1,635,'bada0100_f7f7ef8a',NULL),(6,'2015-05-15 10:38:42','Change has been successfully merged into the git repository.',636,2,636,'bada0100_1af65ad8',NULL),(16,'2015-05-15 09:13:05','Patch Set 2: Code-Review+1',636,2,636,'bada0100_3a41de0b',NULL),(6,'2015-05-13 15:04:28','Uploaded patch set 1.',636,1,636,'bada0100_575fdb72',NULL),(37,'2015-05-15 09:18:56','Patch Set 2: Code-Review+2',636,2,636,'bada0100_5a462225',NULL),(6,'2015-05-14 16:42:42','Uploaded patch set 2.',636,2,636,'bada0100_5af862e5',NULL),(16,'2015-05-13 15:22:48','Patch Set 1: Code-Review+1\n\nSeems fine to me.',636,1,636,'bada0100_d7e18b9b',NULL),(6,'2015-05-15 10:38:40','Patch Set 2:\n\nThanks for reviewing!',636,2,636,'bada0100_faf836c6',NULL),(6,'2015-05-13 17:01:16','Uploaded patch set 1.',637,1,637,'bada0100_17add331',NULL),(16,'2015-05-14 12:09:23','Uploaded patch set 2.',637,2,637,'bada0100_37125763',NULL),(6,'2015-05-14 12:43:39','Patch Set 2:\n\nThanks for finishing off the half-arsed job I did of this',637,2,637,'bada0100_3a09de2c',NULL),(16,'2015-05-14 12:09:47','Patch Set 2: Code-Review+1',637,2,637,'bada0100_5717db51',NULL),(29,'2015-05-14 13:09:52','Patch Set 2: Code-Review+1',637,2,637,'bada0100_5a25c2a9',NULL),(6,'2015-05-14 13:25:20','Change has been successfully merged into the git repository.',637,2,637,'bada0100_9a524a12',NULL),(16,'2015-05-13 18:26:22','Patch Set 1: Code-Review-1\n\nThis breaks `morph show-dependencies`, and therefore the test suite. Looks good other than that though.',637,1,637,'bada0100_b7a96726',NULL),(6,'2015-05-14 13:02:46','Patch Set 2:\n\nI\'ve tested `morph list-artifacts` in the version of Morph that was in the Baserock 15.19.1 release and it fails with this error. So we need to tag and announce a 15.19.2 release once this is merged.',637,2,637,'bada0100_da19b27a',NULL),(37,'2015-05-14 13:16:04','Patch Set 2: Code-Review+2\n\nI prefer keyword arguments to positional and boxing values in one-tuples rather than lists, but this looks fine to me.',637,2,637,'bada0100_da30d2ea',NULL),(39,'2015-05-14 09:35:36','Abandoned\n\nDuplication of 633',638,1,638,'bada0100_57491b8a',NULL),(39,'2015-05-14 09:34:08','Uploaded patch set 1.',638,1,638,'bada0100_974f8392',NULL),(29,'2015-05-14 10:41:31','Uploaded patch set 1.',639,1,639,'bada0100_1722b3b9',NULL),(31,'2015-05-15 10:42:42','Patch Set 1: Code-Review+1',639,1,639,'bada0100_3a26be69',NULL),(29,'2015-05-15 11:20:38','Patch Set 2: Patch Set 1 was rebased',639,1,639,'bada0100_7a88c622',NULL),(29,'2015-05-15 11:20:38','Change has been successfully rebased as 2c2b11373d03d98787f5094a16fe41f05104e14a',639,1,639,'bada0100_9a8d6a34',NULL),(42,'2015-05-14 17:48:35','Patch Set 1: Code-Review+1',639,1,639,'bada0100_bae62e43',NULL),(29,'2015-05-15 11:20:33','Patch Set 1: Code-Review+2',639,1,639,'bada0100_da9bf270',NULL),(29,'2015-05-15 11:20:45','Patch Set 1: Code-Review+2',640,1,640,'bada0100_3a823e01',NULL),(31,'2015-05-15 10:42:57','Patch Set 1: Code-Review+1',640,1,640,'bada0100_5a2b8230',NULL),(29,'2015-05-15 11:20:48','Patch Set 2: Patch Set 1 was rebased',640,1,640,'bada0100_5a870210',NULL),(7,'2015-05-14 11:50:07','Patch Set 1: Code-Review+1\n\nI believe this file is going to make the gerrit experience much easier',640,1,640,'bada0100_7718df84',NULL),(29,'2015-05-14 10:50:23','Uploaded patch set 1.',640,1,640,'bada0100_b72e47a4',NULL),(42,'2015-05-14 17:48:42','Patch Set 1: Code-Review+1',640,1,640,'bada0100_dae3f231',NULL),(29,'2015-05-15 11:20:49','Change has been successfully rebased as b51d9f9338787999bd3ba24f48bd6c7a20fa272c',640,1,640,'bada0100_fa7b5627',NULL),(15,'2015-05-19 15:05:09','Patch Set 2: Code-Review+1',641,2,641,'9adffdf1_0f12a562',NULL),(15,'2015-05-19 15:05:52','Change has been successfully rebased as b3b69e8cc9c1adf7141caa4d3676b69d89246de9',641,2,641,'9adffdf1_8f053516',NULL),(15,'2015-05-19 15:05:49','Patch Set 2: Code-Review+2',641,2,641,'9adffdf1_cf0b3d2a',NULL),(15,'2015-05-19 15:05:51','Patch Set 3: Patch Set 2 was rebased',641,2,641,'9adffdf1_ef08812f',NULL),(6,'2015-05-14 13:24:10','Patch Set 2:\n\n> > (2 comments)\n > \n > re: ^ -- you\'re right, but $SYSTEM might contain metacharacters\n > such as .\n\noh, good point. Currently it\'s limited to [A-Za-z0-9_-.] so it should be impossible to break things, but we should be aware of that if changing the rules in future',641,2,641,'bada0100_7a4d2672',NULL),(15,'2015-05-14 11:54:05','Patch Set 1: Code-Review+1',641,1,641,'bada0100_971d4376',NULL),(6,'2015-05-14 13:09:29','Uploaded patch set 2.',641,2,641,'bada0100_9a2b2a82',NULL),(32,'2015-05-14 12:50:08','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nTwo nitpicks, otherwise fine',641,1,641,'bada0100_ba1cee6b',NULL),(32,'2015-05-14 13:13:57','Patch Set 2: Code-Review+1\n\n> (2 comments)\n\nre: ^ -- you\'re right, but $SYSTEM might contain metacharacters such as .\n\nI\'m okay with this as-is now.',641,2,641,'bada0100_ba338ef5',NULL),(6,'2015-05-14 11:47:22','Uploaded patch set 1.',641,1,641,'bada0100_d72bcb92',NULL),(6,'2015-05-14 13:09:58','Patch Set 1:\n\n(2 comments)',641,1,641,'bada0100_fa3916d9',NULL),(37,'2015-05-20 14:01:00','Patch Set 4: Patch Set 3 was rebased',642,3,642,'9adffdf1_528ff223',NULL),(6,'2015-05-15 14:22:38','Patch Set 3: Code-Review+1',642,3,642,'9adffdf1_6f525115',NULL),(37,'2015-05-20 14:01:01','Change has been successfully rebased as 6fd766d2b071f301ace520dacda89713dd9a91d9',642,3,642,'9adffdf1_72947637',NULL),(37,'2015-05-20 14:00:57','Patch Set 3: Code-Review+2',642,3,642,'9adffdf1_b272de47',NULL),(6,'2015-05-14 14:05:30','Patch Set 2: Code-Review+1\n\n(1 comment)',642,2,642,'bada0100_1a65fae0',NULL),(16,'2015-05-14 14:33:06','Uploaded patch set 3.',642,3,642,'bada0100_3aa55e04',NULL),(16,'2015-05-14 13:58:17','Uploaded patch set 2.',642,2,642,'bada0100_9a79ea95',NULL),(16,'2015-05-14 12:19:31','Uploaded patch set 1.',642,1,642,'bada0100_f70b6f29',NULL),(6,'2015-05-14 13:28:13','Patch Set 1: Code-Review+1\n\n(2 comments)\n\nThanks for this, I would appreciate clearer warning messages though',642,1,642,'bada0100_fa403637',NULL),(6,'2015-05-15 14:23:07','Patch Set 4: Code-Review+1',643,4,643,'9adffdf1_0f570504',NULL),(37,'2015-05-20 14:01:14','Patch Set 5: Patch Set 4 was rebased',643,4,643,'9adffdf1_12996a6e',NULL),(37,'2015-05-20 14:01:57','Patch Set 5: Code-Review+2',643,5,643,'9adffdf1_329eee57',NULL),(37,'2015-05-20 14:02:02','Change has been successfully merged into the git repository.',643,5,643,'9adffdf1_d2a2029a',NULL),(16,'2015-05-14 12:19:31','Uploaded patch set 1.',643,1,643,'bada0100_17095331',NULL),(6,'2015-05-14 13:28:47','Patch Set 2: Code-Review+1\n\nLooks good.',643,2,643,'bada0100_1a3e5ab9',NULL),(16,'2015-05-14 13:58:17','Uploaded patch set 3.',643,3,643,'bada0100_3a6ebeca',NULL),(16,'2015-05-14 14:33:06','Uploaded patch set 4.',643,4,643,'bada0100_5aaaa2d5',NULL),(16,'2015-05-14 12:31:47','Uploaded patch set 2.',643,2,643,'bada0100_9a048a16',NULL),(16,'2015-05-14 14:21:25','Patch Set 3:\n\n(1 comment)',643,3,643,'bada0100_9aa00af6',NULL),(6,'2015-05-14 14:06:46','Patch Set 3:\n\n(1 comment)',643,3,643,'bada0100_da5e9212',NULL),(15,'2015-05-15 10:47:36','Patch Set 1: Code-Review+2',644,1,644,'bada0100_3add5e43',NULL),(7,'2015-05-14 12:49:06','Patch Set 1: Code-Review+1\n\nI\'m happy with the testing that you have done, also I believe that Tiago did the same testing before.',644,1,644,'bada0100_5a0e2236',NULL),(15,'2015-05-15 10:47:38','Patch Set 2: Patch Set 1 was rebased',644,1,644,'bada0100_5ae2a204',NULL),(28,'2015-05-14 12:29:22','Patch Set 1: Code-Review+1',644,1,644,'bada0100_7aff6602',NULL),(15,'2015-05-14 12:24:42','Uploaded patch set 1.',644,1,644,'bada0100_b705e715',NULL),(15,'2015-05-14 12:26:37','Patch Set 1:\n\nResurrect this patch from Tiago because:\n\n- I think is important to have up-to-date latest btrfs rools as we relay on btrfs quite a lot\n- It fixes compilation problems in armv5\n\nI tested this creating a build system and then creating a base system on that build system: the resulting base system boots and seems to work corectly',644,1,644,'bada0100_d702eb0a',NULL),(15,'2015-05-15 10:47:39','Change has been successfully rebased as 4da9f458fd11944c3ef408d3c7122940d79a2154',644,1,644,'bada0100_fae6f615',NULL),(15,'2015-05-15 11:08:36','Change has been successfully rebased as b208c48c55465290ab6f049fcb8859871f8603fb',645,1,645,'bada0100_1acbba73',NULL),(15,'2015-05-15 11:08:32','Patch Set 1: Code-Review+2',645,1,645,'bada0100_5ab942e8',NULL),(16,'2015-05-14 13:46:30','Patch Set 1: Code-Review+1',645,1,645,'bada0100_7a74469c',NULL),(8,'2015-05-15 10:46:43','Patch Set 1: Code-Review+1',645,1,645,'bada0100_7ad3e638',NULL),(6,'2015-05-14 13:30:43','Uploaded patch set 1.',645,1,645,'bada0100_ba4aae53',NULL),(6,'2015-05-14 13:31:47','Patch Set 1:\n\nI will cherry-pick this on top of the baserock-15.19.1 tag and create a baserock-15.19.2 release tag, as quite a few commands are broken in the version of Morph present in the Baserock reference definitions 15.19.1 release.',645,1,645,'bada0100_da47724a',NULL),(15,'2015-05-15 11:08:35','Patch Set 2: Patch Set 1 was rebased',645,1,645,'bada0100_facd9687',NULL),(6,'2015-05-15 14:23:40','Patch Set 1: Code-Review+1\n\nI\'ve not tested that this passes, I assume it does! Code looks fine.',646,1,646,'9adffdf1_2f5c4925',NULL),(37,'2015-05-20 14:03:37','Patch Set 2: Code-Review+2',646,2,646,'9adffdf1_52b612de',NULL),(37,'2015-05-20 14:03:40','Change has been successfully merged into the git repository.',646,2,646,'9adffdf1_72bb16c5',NULL),(NULL,'2015-05-20 14:03:20','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I54d1a03b, however the current patch set is 5.\n* Depends on commit fe76d8ec78133d04732333e9a605928571e288a8 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',646,1,646,'9adffdf1_92ac7a8e',NULL),(37,'2015-05-20 14:03:27','Patch Set 2: Patch Set 1 was rebased',646,1,646,'9adffdf1_b2a97e7d',NULL),(37,'2015-05-20 14:03:16','Patch Set 1: Code-Review+2',646,1,646,'9adffdf1_f29f064f',NULL),(16,'2015-05-14 14:58:53','Uploaded patch set 1.',646,1,646,'bada0100_faaef6e6',NULL),(37,'2015-05-20 14:04:07','Patch Set 2: Patch Set 1 was rebased',647,1,647,'9adffdf1_12b08adc',NULL),(37,'2015-05-20 14:04:25','Patch Set 2: Code-Review+2\n\nThey\'re just smoke tests, but it\'s better than what we currently have, so +2.',647,2,647,'9adffdf1_32b58ecd',NULL),(6,'2015-05-15 14:24:05','Patch Set 1: Code-Review+1\n\nI\'ve not tested that this passes, I assume it does! Code looks fine.',647,1,647,'9adffdf1_cf401d38',NULL),(37,'2015-05-20 14:04:29','Change has been successfully merged into the git repository.',647,2,647,'9adffdf1_d2c9a25b',NULL),(16,'2015-05-14 14:58:53','Uploaded patch set 1.',647,1,647,'bada0100_1aac1aed',NULL),(37,'2015-05-20 14:05:03','Patch Set 2: Code-Review+2',648,2,648,'9adffdf1_92c31a38',NULL),(37,'2015-05-20 14:05:05','Change has been successfully merged into the git repository.',648,2,648,'9adffdf1_b2c09e2b',NULL),(6,'2015-05-15 14:24:25','Patch Set 1: Code-Review+2',648,1,648,'9adffdf1_ef3de1bc',NULL),(37,'2015-05-20 14:04:57','Patch Set 2: Patch Set 1 was rebased',648,1,648,'9adffdf1_f2c62649',NULL),(16,'2015-05-14 14:58:53','Uploaded patch set 1.',648,1,648,'bada0100_bab86e2b',NULL),(37,'2015-05-20 14:09:33','Patch Set 2: Patch Set 1 was rebased',649,1,649,'9adffdf1_12e72ae6',NULL),(37,'2015-05-20 14:10:27','Patch Set 2: Code-Review+2\n\nAdding support for --tempdir would be better, but this is already an improvement, so I\'ll take it as-is, and leave whether we get a --tempdir option for a possible future patch.',649,2,649,'9adffdf1_32ecaec7',NULL),(37,'2015-05-20 14:09:30','Patch Set 1:\n\n(1 comment)',649,1,649,'9adffdf1_72e236d7',NULL),(6,'2015-05-15 14:25:37','Patch Set 1:\n\nI think that there\'s a lot more to be done in order to make debugging yarns not be a massive effort. Surely without setting --tempdir, Yarn will delete the snapshots after the tests finish anyway? or am I missing something?',649,1,649,'9adffdf1_8f4a1554',NULL),(16,'2015-05-15 14:33:40','Patch Set 1:\n\n> I think that there\'s a lot more to be done in order to make\n > debugging yarns not be a massive effort. Surely without setting\n > --tempdir, Yarn will delete the snapshots after the tests finish\n > anyway? or am I missing something?\n\nI agree! But I think having the test datadirs to look in is a nice first step.\n\nSetting --snapshot is enough to keep the snapshots. If --tempdir isn\'t set, they end up in a temporary directory in TMPDIR.',649,1,649,'9adffdf1_af47d94a',NULL),(37,'2015-05-20 14:10:29','Change has been successfully merged into the git repository.',649,2,649,'9adffdf1_d2d0c2f9',NULL),(6,'2015-05-15 15:10:41','Patch Set 1: Code-Review+1\n\n> > I think that there\'s a lot more to be done in order to make\n > > debugging yarns not be a massive effort. Surely without setting\n > > --tempdir, Yarn will delete the snapshots after the tests finish\n > > anyway? or am I missing something?\n > \n > I agree! But I think having the test datadirs to look in is a nice\n > first step.\n > \n > Setting --snapshot is enough to keep the snapshots. If --tempdir\n > isn\'t set, they end up in a temporary directory in TMPDIR.\n\nAh, OK, I thought they got deleted. This seems useful then.',649,1,649,'9adffdf1_ef6401e7',NULL),(16,'2015-05-14 14:58:53','Uploaded patch set 1.',649,1,649,'bada0100_dab53232',NULL),(34,'2015-05-15 15:52:06','Patch Set 2: Code-Review+1\n\nThanks for making the changes. :)',650,2,650,'9adffdf1_0fa5c503',NULL),(31,'2015-05-15 15:13:42','Patch Set 1:\n\n(1 comment)',650,1,650,'9adffdf1_4f9bcdc9',NULL),(8,'2015-05-18 09:05:13','Patch Set 3: Patch Set 2 was rebased',650,2,650,'9adffdf1_4fe98d19',NULL),(16,'2015-05-15 15:37:03','Patch Set 2: Code-Review+1\n\nLooks good, thanks!',650,2,650,'9adffdf1_6fa011f5',NULL),(8,'2015-05-18 09:05:13','Change has been successfully rebased as 3f69fa2be28cd499bdc8420d7ed8074d3f4a55cd',650,2,650,'9adffdf1_6feed124',NULL),(31,'2015-05-15 15:12:27','Uploaded patch set 2.',650,2,650,'9adffdf1_8f61b5d5',NULL),(8,'2015-05-18 09:02:26','Patch Set 2: Code-Review+2',650,2,650,'9adffdf1_af8cb980',NULL),(34,'2015-05-15 11:17:17','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nIf the first git repo is usable, then I\'d prefer if you used that instead of the tarball, and I\'d like the rationale for the tarball explained in the commit. But +1 with those changes. :)',650,1,650,'bada0100_1a92da57',NULL),(34,'2015-05-14 16:36:29','Patch Set 1:\n\n(2 comments)\n\nI\'m not sure why the tarballs are necessary; if they are then please could you explain it in the commit message? Thanks :)',650,1,650,'bada0100_1a93baa4',NULL),(31,'2015-05-14 15:28:33','Uploaded patch set 1.',650,1,650,'bada0100_7a820654',NULL),(15,'2015-05-15 11:11:46','Patch Set 1: -Code-Review',650,1,650,'bada0100_7aa1a6a8',NULL),(16,'2015-05-15 12:07:33','Patch Set 1:\n\n(1 comment)',650,1,650,'bada0100_7ab686de',NULL),(31,'2015-05-15 08:56:43','Patch Set 1:\n\n(2 comments)',650,1,650,'bada0100_9a3c8a95',NULL),(16,'2015-05-14 15:59:17','Patch Set 1: Code-Review+1',650,1,650,'bada0100_9a87aa61',NULL),(31,'2015-05-15 10:58:54','Patch Set 1:\n\n(1 comment)',650,1,650,'bada0100_9abfaad0',NULL),(15,'2015-05-15 10:47:02','Patch Set 1: Code-Review-1\n\n(1 comment)',650,1,650,'bada0100_9ad80a55',NULL),(31,'2015-05-15 11:53:14','Patch Set 1:\n\n(1 comment)',650,1,650,'bada0100_baacee8d',NULL),(15,'2015-05-15 11:11:41','Patch Set 1: Code-Review+2\n\n(1 comment)',650,1,650,'bada0100_dac45261',NULL),(16,'2015-05-15 11:46:47','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nChanging my vote to -1 because I agree we should use the git repositories if at all possible.',650,1,650,'bada0100_faa27699',NULL),(7,'2015-05-19 10:27:32','Patch Set 1: Code-Review+2\n\nThis is indeed useful.',651,1,651,'9adffdf1_2fa44956',NULL),(7,'2015-05-19 10:27:40','Patch Set 2: Patch Set 1 was rebased',651,1,651,'9adffdf1_cf881dc9',NULL),(7,'2015-05-19 10:27:41','Change has been successfully rebased as f72b4dc8ad951244b4470f5dba7efd4bbd0f63f0',651,1,651,'9adffdf1_ef85e1ad',NULL),(34,'2015-05-14 16:59:01','Patch Set 1: Code-Review+1',651,1,651,'bada0100_1adada78',NULL),(16,'2015-05-14 17:59:21','Patch Set 1: Code-Review+1',651,1,651,'bada0100_7ad0c653',NULL),(15,'2015-05-14 18:15:40','Patch Set 1: Code-Review+1',651,1,651,'bada0100_9ad56a45',NULL),(6,'2015-05-14 16:41:27','Uploaded patch set 1.',651,1,651,'bada0100_ba8f0e75',NULL),(6,'2015-06-12 17:05:52','Uploaded patch set 3.',652,3,652,'3a4c51b2_7c129963',NULL),(34,'2015-06-02 12:47:16','Patch Set 1: Code-Review+1',652,1,652,'5aaae553_0520529a',NULL),(29,'2015-06-02 14:38:44','Patch Set 2: Code-Review+1\n\nI agree that it might be useful to add more information to the gitdir\'s InvalidRefError so we can raise a similar message for all repos, but this is a good improvement for now.',652,2,652,'5aaae553_854a0254',NULL),(34,'2015-06-02 14:41:35','Patch Set 2: Code-Review+1',652,2,652,'5aaae553_a547fe4a',NULL),(29,'2015-06-02 14:30:17','Patch Set 1: Code-Review-2\n\n(1 comment)\n\nlooks fine but will fix nitpick',652,1,652,'5aaae553_c540fa37',NULL),(29,'2015-06-02 14:31:48','Uploaded patch set 2.',652,2,652,'5aaae553_e53df6bc',NULL),(27,'2015-05-18 13:39:29','Patch Set 1: Code-Review+1\n\nMore info on what I did wrong? YES PLEASE!',652,1,652,'9adffdf1_ef9f214f',NULL),(6,'2015-05-14 16:42:42','Uploaded patch set 1.',652,1,652,'bada0100_fadcb676',NULL),(6,'2015-06-16 16:04:29','Change has been successfully merged into the git repository.',652,5,652,'da5c1566_19d8cb52',NULL),(6,'2015-06-16 16:04:25','Patch Set 5: Code-Review+2',652,5,652,'da5c1566_39d30f3a',NULL),(6,'2015-06-16 16:04:23','Patch Set 5: Patch Set 4 was rebased',652,4,652,'da5c1566_d91653f1',NULL),(29,'2015-06-15 15:01:58','Uploaded patch set 4.',652,4,652,'fa57193c_bac39189',NULL),(29,'2015-06-15 07:46:25','Patch Set 3: Code-Review+1',652,3,652,'fa57193c_da19257b',NULL),(34,'2015-06-15 09:39:43','Patch Set 3: Code-Review+1',652,3,652,'fa57193c_da3005eb',NULL),(29,'2015-06-15 15:04:19','Patch Set 4: Code-Review+1',652,4,652,'fa57193c_dabac509',NULL),(15,'2015-05-15 10:43:59','Change has been successfully merged into the git repository.',653,1,653,'bada0100_1a1dfa0f',NULL),(15,'2015-05-14 21:24:57','Uploaded patch set 1.',653,1,653,'bada0100_3aca3ea2',NULL),(32,'2015-05-15 10:37:01','Patch Set 1: Code-Review+1\n\nAfter discussion on #baserock, I am satisfied',653,1,653,'bada0100_9a0a4ad1',NULL),(35,'2015-05-15 10:09:28','Patch Set 1: Code-Review+1\n\nGood spot',653,1,653,'bada0100_9a632ab1',NULL),(15,'2015-05-15 10:43:56','Patch Set 1: Code-Review+2',653,1,653,'bada0100_fa1fd607',NULL),(7,'2015-05-18 09:44:38','Patch Set 2: Code-Review+1\n\nSorry, looks like gertty doesn\'t like me commenting on preivous versions of the patch.\n\nI wanted to point out that /srv/distbuild may not be present in a Mason node, but after a quick off-line discussion I don\'t want to block this patch just because of that (Mason needs a lot of improvements in general)',654,2,654,'9adffdf1_4fd0ad53',NULL),(7,'2015-05-18 09:35:02','Patch Set 2: Code-Review-1',654,2,654,'9adffdf1_8fe69543',NULL),(37,'2015-05-20 14:12:41','Patch Set 3: Patch Set 2 was rebased',654,2,654,'9adffdf1_92da3a16',NULL),(37,'2015-05-20 14:12:41','Change has been successfully rebased as 0f58def75fab90923f46faf556b0ce6642d638b6',654,2,654,'9adffdf1_b2d73eed',NULL),(37,'2015-05-20 14:12:38','Patch Set 2: Code-Review+2',654,2,654,'9adffdf1_f2cdc65e',NULL),(6,'2015-05-15 10:37:39','Uploaded patch set 2.',654,2,654,'bada0100_3a0f9ee3',NULL),(6,'2015-05-15 10:37:41','Patch Set 1:\n\n(1 comment)',654,1,654,'bada0100_5a14e2f4',NULL),(16,'2015-05-15 10:13:36','Patch Set 1: Code-Review+1\n\nSeems sensible to me.',654,1,654,'bada0100_5a5dc2e8',NULL),(6,'2015-05-15 10:08:19','Uploaded patch set 1.',654,1,654,'bada0100_7a5e86eb',NULL),(8,'2015-05-15 10:42:42','Patch Set 2: Code-Review+1',654,2,654,'bada0100_9a31eaa4',NULL),(8,'2015-05-15 10:29:08','Patch Set 1: Code-Review-1\n\n(1 comment)',654,1,654,'bada0100_da68d289',NULL),(6,'2015-05-15 14:12:20','Patch Set 2: Patch Set 1 was rebased',655,1,655,'9adffdf1_8f1c556c',NULL),(6,'2015-05-15 14:12:21','Change has been successfully rebased as 005fb9f67548c5c077a5ab989f1ef243b8d0ec11',655,1,655,'9adffdf1_af19197b',NULL),(6,'2015-05-15 14:12:15','Patch Set 1: Code-Review+2',655,1,655,'9adffdf1_ef0f212d',NULL),(35,'2015-05-15 10:55:14','Uploaded patch set 1.',655,1,655,'bada0100_1ae41a0c',NULL),(15,'2015-05-15 11:12:19','Patch Set 1: Code-Review+1',655,1,655,'bada0100_9aa6cac0',NULL),(15,'2015-05-18 12:13:57','Patch Set 2: Code-Review+1',656,2,656,'9adffdf1_0f82a500',NULL),(35,'2015-05-18 10:37:28','Patch Set 1:\n\nOk, will do this',656,1,656,'9adffdf1_2f5d29ea',NULL),(6,'2015-05-15 14:15:00','Patch Set 1:\n\nI don\'t think it\'s good to point to a branch in a \'wip\' (work in progress) prefix, it could reasonably be force-updated causing the commit we\'re pointing to do disappear. Can you create a branch or tag in delta/qt5/qtmultimedia.git called baserock/qt5.4-wip-gstreamer-1.0 or some such? If not I can do it',656,1,656,'9adffdf1_4f266dbc',NULL),(35,'2015-05-18 11:43:17','Uploaded patch set 2.',656,2,656,'9adffdf1_4f88ad22',NULL),(7,'2015-05-19 10:12:48','Patch Set 2:\n\nI think now this patch is ready to be merged, although I\'m not confident enough to give it a +1. On the other hand this stratum is not being used in any of the reference systems, so it shouldn\'t break anything.\n\nI guess that adding a reference system so that others can test changes might be helpful.',656,2,656,'9adffdf1_4f950de3',NULL),(37,'2015-05-19 16:59:19','Change has been successfully rebased as 47babac06e4f036598ab11655a79297b036c898b',656,2,656,'9adffdf1_726316b2',NULL),(37,'2015-05-19 16:59:17','Patch Set 3: Patch Set 2 was rebased',656,2,656,'9adffdf1_92547acb',NULL),(37,'2015-05-19 16:59:14','Patch Set 2: Code-Review+2',656,2,656,'9adffdf1_f247061c',NULL),(15,'2015-05-15 11:12:53','Patch Set 1: Code-Review+1\n\nAssuming you tested it',656,1,656,'bada0100_3aab1e8b',NULL),(35,'2015-05-15 10:55:14','Uploaded patch set 1.',656,1,656,'bada0100_baf06eca',NULL),(NULL,'2015-05-18 10:35:48','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of Ie3d118d5.\n* Depends on patch set 1 of I105b431f, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',657,1,657,'9adffdf1_0f5865f9',NULL),(15,'2015-05-18 12:14:07','Patch Set 2: Code-Review+1',657,2,657,'9adffdf1_2f876911',NULL),(15,'2015-05-19 16:59:19','Change has been successfully rebased as 5079743cdc4e88613b8a18c0ee78b11da8aeb94d',657,2,657,'9adffdf1_525e12eb',NULL),(6,'2015-05-15 14:15:27','Patch Set 1: Code-Review+2',657,1,657,'9adffdf1_6f2b3183',NULL),(35,'2015-05-18 11:43:17','Uploaded patch set 2.',657,2,657,'9adffdf1_6f8d7131',NULL),(7,'2015-05-19 10:14:41','Patch Set 2: Code-Review+2\n\nLooks ok, and it already had a +2',657,2,657,'9adffdf1_6f9a5116',NULL),(NULL,'2015-05-19 14:30:41','Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Ie3d118d53befa56744d97b107e58b701c904f9f7\n',657,2,657,'9adffdf1_8f577526',NULL),(15,'2015-05-19 16:59:18','Patch Set 3: Patch Set 2 was rebased',657,2,657,'9adffdf1_b2517eda',NULL),(15,'2015-05-15 11:13:13','Patch Set 1: Code-Review+1',657,1,657,'bada0100_5ab062f4',NULL),(35,'2015-05-15 10:55:14','Uploaded patch set 1.',657,1,657,'bada0100_daed32f1',NULL),(35,'2015-05-22 10:20:44','Abandoned',658,1,658,'5ac10518_ad303de9',NULL),(6,'2015-05-15 14:10:57','Patch Set 1:\n\nI would like if our files in /etc were self-documenting so that people know which files are needed and which are not needed for their specific use cases. So adding a header to the top of dbus.service and dbus.socket saying something like this would be nice:\n\n# This unit provides a D-Bus message bus for each logged in user\n# (also called a \'session bus\'). This is separate from the\n# system-wide message bus (\'system bus\') that the dbus.service\n# systemd unit provides.',658,1,658,'9adffdf1_0f09452c',NULL),(6,'2015-05-15 14:11:39','Patch Set 1: Code-Review+1\n\nFormatting messed up there. Anyway this looks like a good approach, thanks for the patch.',658,1,658,'9adffdf1_2f0e8935',NULL),(37,'2015-05-15 14:51:50','Patch Set 1: Code-Review-1\n\nI\'d prefer we updated our dbus chunk to at least 1.9.14 and configured it with --enable-user-session as http://git.baserock.org/cgi-bin/cgit.cgi/delta/dbus.git/commit/?id=263aca37ecf5f977f68d87b54f2fb30584725781 added support for providing that configuration.',658,1,658,'9adffdf1_2f73e9b2',NULL),(35,'2015-05-15 11:20:49','Uploaded patch set 1.',658,1,658,'bada0100_1a797a2f',NULL),(35,'2015-05-22 10:20:51','Abandoned',659,1,659,'5ac10518_4d4d1972',NULL),(6,'2015-05-15 14:11:57','Patch Set 1: Code-Review+1',659,1,659,'9adffdf1_cf125d58',NULL),(37,'2015-05-15 14:51:56','Patch Set 1: Code-Review-1\n\nI\'d prefer we updated our dbus chunk to at least 1.9.14 and configured it with --enable-user-session as http://git.baserock.org/cgi-bin/cgit.cgi/delta/dbus.git/commit/?id=263aca37ecf5f977f68d87b54f2fb30584725781 added support for providing that configuration.',659,1,659,'9adffdf1_cf67bde9',NULL),(35,'2015-05-15 11:20:49','Uploaded patch set 1.',659,1,659,'bada0100_ba75ce33',NULL),(37,'2015-05-18 09:52:05','Patch Set 2: Patch Set 1 was rebased',660,1,660,'9adffdf1_0fcaa5a1',NULL),(37,'2015-05-15 15:53:02','Uploaded patch set 1.',660,1,660,'9adffdf1_2faa09d5',NULL),(37,'2015-05-18 09:52:06','Change has been successfully rebased as ab9611e53a40f07789e9aafc24a1d72e4dde89ea',660,1,660,'9adffdf1_2fcf69b2',NULL),(37,'2015-05-18 09:51:50','Patch Set 1: Code-Review+2\n\nI just finished testing and it is working. Thanks for the reviews.',660,1,660,'9adffdf1_6fd57142',NULL),(15,'2015-05-15 15:59:33','Patch Set 1: Code-Review+1\n\nAssuming you tested it',660,1,660,'9adffdf1_8fb8d52b',NULL),(37,'2015-05-15 15:53:43','Patch Set 1:\n\nI am currently testing this, but I\'ve submitted it now as I don\'t expect it to fail.',660,1,660,'9adffdf1_cfaedde7',NULL),(7,'2015-05-15 15:56:39','Patch Set 1: Code-Review+1',660,1,660,'9adffdf1_efaba1d4',NULL),(43,'2015-05-15 17:08:18','Patch Set 1: Code-Review+1',661,1,661,'9adffdf1_0f7ce571',NULL),(18,'2015-05-17 19:05:50','Patch Set 1: Code-Review+2',661,1,661,'9adffdf1_2f81a94a',NULL),(7,'2015-05-15 17:02:39','Uploaded patch set 1.',661,1,661,'9adffdf1_4f82ed53',NULL),(28,'2015-05-15 17:07:53','Patch Set 1: Code-Review+1',661,1,661,'9adffdf1_6f87b162',NULL),(18,'2015-05-17 19:07:15','Change has been successfully merged into the git repository.',661,1,661,'9adffdf1_cf957d89',NULL),(7,'2015-05-18 09:11:42','Uploaded patch set 1.',662,1,662,'9adffdf1_0ff3850b',NULL),(8,'2015-05-18 09:14:00','Patch Set 1: Code-Review+2',662,1,662,'9adffdf1_2ff8c9e4',NULL),(6,'2015-05-18 09:20:01','Patch Set 1: Code-Review+2',662,1,662,'9adffdf1_cfdc9d77',NULL),(6,'2015-05-18 09:20:03','Change has been successfully merged into the git repository.',662,1,662,'9adffdf1_efd96184',NULL),(7,'2015-05-22 11:33:26','Patch Set 2: Code-Review+1',663,2,663,'5ac10518_2daa0dd5',NULL),(8,'2015-05-22 11:35:13','Patch Set 3: Patch Set 2 was rebased',663,2,663,'5ac10518_8db8e12b',NULL),(8,'2015-05-22 11:35:13','Change has been successfully rebased as 7867b79675269c9e5c2eac9bf1b98d60a6f22bc6',663,2,663,'5ac10518_adb59d32',NULL),(8,'2015-05-22 11:35:08','Patch Set 2: Code-Review+2',663,2,663,'5ac10518_edaba5d4',NULL),(28,'2015-05-20 10:19:28','Patch Set 2: Code-Review+1',663,2,663,'9adffdf1_12264a69',NULL),(28,'2015-05-18 10:32:20','Patch Set 1:\n\n(2 comments)',663,1,663,'9adffdf1_6f6331b2',NULL),(8,'2015-05-18 09:41:53','Uploaded patch set 1.',663,1,663,'9adffdf1_afe35932',NULL),(8,'2015-05-18 10:49:16','Patch Set 1:\n\n(2 comments)',663,1,663,'9adffdf1_afffd9a9',NULL),(8,'2015-05-19 15:37:08','Uploaded patch set 2.',663,2,663,'9adffdf1_b25e5e11',NULL),(8,'2015-05-18 10:27:40','Patch Set 1:\n\n> Looks fine, i\'ve not tested. Seems to me these could equally be\n > \'install-commands\' rather than \'post-install-commands;.\n\nTempest is installed as a python package apart from copy the required files, this is the reason why I use post-install-commands to copy over the required files to run the tests instead of install-commands.',663,1,663,'9adffdf1_ef47211c',NULL),(6,'2015-05-18 10:18:18','Patch Set 1: Code-Review+1\n\nLooks fine, i\'ve not tested. Seems to me these could equally be \'install-commands\' rather than \'post-install-commands;.',663,1,663,'9adffdf1_efc0817e',NULL),(29,'2015-05-18 10:27:38','Uploaded patch set 1.',664,1,664,'9adffdf1_0f41450b',NULL),(37,'2015-05-18 13:38:07','Patch Set 1: Code-Review+2\n\nThat sounds like a reasonable approach then.',664,1,664,'9adffdf1_0f99456e',NULL),(37,'2015-05-18 13:38:15','Patch Set 2: Patch Set 1 was rebased',664,1,664,'9adffdf1_2f9e8957',NULL),(37,'2015-05-18 10:45:39','Patch Set 1:\n\nGiven there\'s no way to re-enable the output without modifying the code, I\'m not sure it\'s correct to call it disabled by default, it\'s actually a verbose way to disable it permanently.',664,1,664,'9adffdf1_6f0a51d4',NULL),(29,'2015-05-18 10:49:58','Patch Set 1:\n\n> Given there\'s no way to re-enable the output without modifying the\n > code, I\'m not sure it\'s correct to call it disabled by default,\n > it\'s actually a verbose way to disable it permanently.\n\nI thought this was more a compromise between keeping these noise-generating log messages and removing them completely, we\'ve done this in several other parts of distbuild, but I do see your point.',664,1,664,'9adffdf1_6f31f1a1',NULL),(6,'2015-05-18 11:27:26','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nI think this approach is fine, debugging serious distbuild issues already tends to involve modifying the code to add/enable extra logging',664,1,664,'9adffdf1_6fa6d1c3',NULL),(37,'2015-05-18 13:38:16','Change has been successfully rebased as 88967bfe9bc5bc1b8baba1b3d221630067c429b0',664,1,664,'9adffdf1_cfa25d9a',NULL),(37,'2015-05-18 10:45:44','Patch Set 1:\n\nGiven there\'s no way to re-enable the output without modifying the code, I\'m not sure it\'s correct to call it disabled by default, it\'s actually a verbose way to disable it permanently.',665,1,665,'9adffdf1_0f0f05e3',NULL),(29,'2015-05-18 10:27:38','Uploaded patch set 1.',665,1,665,'9adffdf1_2f468924',NULL),(6,'2015-05-18 11:30:29','Patch Set 1: Code-Review+1\n\nseems fine. The build log messages will still be stored in the worker.log and worker-helper.log, and I think that\'s useful.\n\nI think we should buffer build output a bit better (not wrapping each line in its own JSON message, but sending one message every 250ms or so), we could then truncate those messages in the log files, so you can still debug whether messages are being transferred correctly without having the entire compile output mixed in with the controller\'s log messages. That\'s a separate task though.',665,1,665,'9adffdf1_2fb0c9f3',NULL),(37,'2015-05-18 13:59:37','Patch Set 1: Code-Review+2',665,1,665,'9adffdf1_2fb529cd',NULL),(37,'2015-05-18 13:59:51','Patch Set 2: Code-Review+2',665,2,665,'9adffdf1_8fc3f537',NULL),(37,'2015-05-18 13:59:53','Change has been successfully merged into the git repository.',665,2,665,'9adffdf1_afc0392b',NULL),(NULL,'2015-05-18 13:59:40','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I5b81ff93, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',665,1,665,'9adffdf1_cfc9fd5b',NULL),(37,'2015-05-18 13:59:47','Patch Set 2: Patch Set 1 was rebased',665,1,665,'9adffdf1_efc64149',NULL),(29,'2017-05-02 13:37:25','Abandoned',666,5,666,'7a25e98e_e60dbe38',NULL),(29,'2015-05-18 11:05:13','Patch Set 2: Commit message was updated',666,2,666,'9adffdf1_4fbaede2',NULL),(29,'2015-05-20 09:08:00','Patch Set 4: Code-Review-1\n\n(2 comments)',666,4,666,'9adffdf1_522cd24a',NULL),(29,'2015-05-18 11:05:37','Patch Set 3: Commit message was updated',666,3,666,'9adffdf1_6fbfb1d1',NULL),(29,'2015-05-18 12:15:23','Patch Set 3:\n\n> thanks for this, it seems sensible at a glance.\n\nthank you for taking the time to look at this :)\n\n > \n > I would be quite conservative about merging this, because I it\n > introduces some new failure risks to the distbuild codebase.\n > \n > First, the database needs to have some kind of expiry mechanism\n > built in. For lorry-controller we don\'t have this, and every few\n > months I log into a Trove and find that the lorry-controller webapp\n > process is stuck at 100% CPU, because the SQLite database it\n > maintains has reached 8GB in size and SQLite is really not\n > efficient at managing such a huge amount of data.\n\nAgreed, sounds like we need to do the same with lorry-controller too.\n\n > \n > Second, we need some way of handling changes to the database\n > schema. There are a few possibilities. I\'ve found \'yoyo\' to be a\n > good Python library for managing a versioned database schema, in\n > the past. Or, you could add a \"VERSION\" table to the data but not\n > actually implement migrations yet, leaving it up to the first\n > person who needs to change the schema for whatever reason. Or we\n > could stipulate that the build database is deleted every time a\n > distbuild network gets updated.\n\nVersioning would be good to have, I\'d prefer to have migrations\nas well, but probably in a separate change. For this change I\nimagine it\'d be enough to detect a version difference and\noverwrite the existing db?\n\n > \n > Third, a corrupt / missing database shouldn\'t crash things.\n > \n > \n > I\'d like it if we could, instead of implementing our own database\n > storage backend, use some existing Python library that could\n > already take care of the above problems. I don\'t know of any\n > library to suggest though, and for a task this simple, reusing an\n > existing library can end up being as much work as just implementing\n > things yourself in the sort term. It might pay off in the long run\n > though. \n\nThis task felt simple enough that I didn\'t think to seek out a library\nfor it, as this stands a missing database wouldn\'t break anything*,\nif the database isn\'t where we expect to find it then we create a new one.\n\nAs for corruptibility there\'s still a little more sanity checking needed\nwhen we open the db I feel, this rfc is quite a way from being complete\nthough, it doesn\'t even make the id a primary key, for example.\n\n* unless the database was (re)moved in-between constructing a BuildRequestDB\nobject and using the database.',666,3,666,'9adffdf1_8f753534',NULL),(6,'2015-05-18 11:41:21','Patch Set 3:\n\nthanks for this, it seems sensible at a glance.\n\nI would be quite conservative about merging this, because I it introduces some new failure risks to the distbuild codebase.\n\nFirst, the database needs to have some kind of expiry mechanism built in. For lorry-controller we don\'t have this, and every few months I log into a Trove and find that the lorry-controller webapp process is stuck at 100% CPU, because the SQLite database it maintains has reached 8GB in size and SQLite is really not efficient at managing such a huge amount of data.\n\nSecond, we need some way of handling changes to the database schema. There are a few possibilities. I\'ve found \'yoyo\' to be a good Python library for managing a versioned database schema, in the past. Or, you could add a \"VERSION\" table to the data but not actually implement migrations yet, leaving it up to the first person who needs to change the schema for whatever reason. Or we could stipulate that the build database is deleted every time a distbuild network gets updated.\n\nThird, a corrupt / missing database shouldn\'t crash things.\n\n\nI\'d like it if we could, instead of implementing our own database storage backend, use some existing Python library that could already take care of the above problems. I don\'t know of any library to suggest though, and for a task this simple, reusing an existing library can end up being as much work as just implementing things yourself in the sort term. It might pay off in the long run though.',666,3,666,'9adffdf1_8f9e9562',NULL),(29,'2015-05-18 10:27:39','Uploaded patch set 1.',666,1,666,'9adffdf1_cf4a5d27',NULL),(29,'2015-05-20 08:57:57','Uploaded patch set 4.',666,4,666,'9adffdf1_d2f8c2c6',NULL),(29,'2015-05-18 10:40:29','Patch Set 1: Code-Review-2',666,1,666,'9adffdf1_ef6e4196',NULL),(29,'2015-05-20 09:02:38','Patch Set 4: -Code-Review\n\nSubmitting this as a request for merge now,\nthere\'s a couple of FIXMEs where we construct the output\nfor distbuild-status and distbuild-list-jobs on the controller,\nthis should be done on the client side, but it\'s a separate change.\n\nThe distbuild-status and distbuild-list-jobs output is now\na little more terse, this is more because I intend to follow\nthis change up with a change to move message construction over\nto the client.',666,4,666,'9adffdf1_f2f5c6cb',NULL),(6,'2015-09-22 15:28:30','Patch Set 5:\n\nWhile I don\'t currently have a use for it, I think it\'s useful to have if it doesn\'t introduce any regressions',666,5,666,'fafc7978_2763e8b2',NULL),(6,'2015-09-23 09:11:27','Patch Set 5:\n\n> Okay, a method was introduced to expire requests, so this won\'t\n > suffer the same fate as lorry-controller.\n\nNice! We will probably need to tweak the figure once this has been tested thoroughly. And since the controller process only gets restarted on crashes or system upgrades, it might need to call _expire_requests() periodically at runtime, not just on startup. But at least the mechanism is there.\n\nI\'ll give this a quick test today using scripts/run-distbuild.',666,5,666,'fafc7978_27d80853',NULL),(6,'2015-09-22 15:27:50','Patch Set 5:\n\nI\'d be fine with this being merged, *if* it can be shown to not suffer from the same \'database grows enourmous and causes SQLite to eat 100% CPU constantly\' problem that we encounter with lorry-controller.',666,5,666,'fafc7978_475eecea',NULL),(29,'2015-09-23 09:42:13','Patch Set 5:\n\n> > Okay, a method was introduced to expire requests, so this won\'t\n > > suffer the same fate as lorry-controller.\n > \n > Nice! We will probably need to tweak the figure once this has been\n > tested thoroughly. And since the controller process only gets\n > restarted on crashes or system upgrades, it might need to call\n > _expire_requests() periodically at runtime, not just on startup.\n > But at least the mechanism is there.\n\nYes that\'s a good point it probably should be called periodically,\nwe could maybe even base the period on the number of build-requests\nwe\'ve received?\n\nI also don\'t think the age figure should be hardcoded, so there\'s a related change to put that stuff into a config file, but that needs a little more work.\n\n > \n > I\'ll give this a quick test today using scripts/run-distbuild.\n\nThanks, though I should point out that this needs a little more work before it should be considered for merge, in my opinion.',666,5,666,'fafc7978_47ba6ce2',NULL),(29,'2015-09-23 08:39:51','Patch Set 5:\n\n(1 comment)\n\nOkay, a method was introduced to expire requests, so this won\'t suffer the same fate as lorry-controller.',666,5,666,'fafc7978_47d38c38',NULL),(39,'2015-06-26 13:43:56','Uploaded patch set 5.',666,5,666,'fafc7978_52cfd4b0',NULL),(33,'2015-07-04 17:43:05','Patch Set 5:\n\nI\'m in favour of merging this, but then I would be :)',666,5,666,'fafc7978_9222dcff',NULL),(29,'2015-05-18 16:36:33','Patch Set 1: Code-Review+1',667,1,667,'9adffdf1_2f11a9ac',NULL),(15,'2015-05-18 13:07:05','Patch Set 1: Code-Review+1',667,1,667,'9adffdf1_4f8f4d24',NULL),(29,'2015-05-19 08:52:32','Change has been successfully merged into the git repository.',667,1,667,'9adffdf1_8f769505',NULL),(24,'2015-05-18 12:54:09','Uploaded patch set 1.',667,1,667,'9adffdf1_af727947',NULL),(29,'2015-05-19 08:52:31','Patch Set 1: Code-Review+2',667,1,667,'9adffdf1_ef696126',NULL),(37,'2015-05-20 14:30:12','Change has been successfully rebased as 14d18bbed180efa1a5988aca18058efd952e4393',668,2,668,'9adffdf1_1235ea45',NULL),(37,'2015-05-20 14:30:08','Patch Set 2: Code-Review+2\n\nI\'d prefer we fixed split /usr, but this is fine.',668,2,668,'9adffdf1_522b72eb',NULL),(27,'2015-05-19 15:27:49','Patch Set 2: Code-Review+1\n\nthis looks sane to me. having defaults is nice.',668,2,668,'9adffdf1_524db271',NULL),(15,'2015-05-18 13:24:52','Uploaded patch set 1.',668,1,668,'9adffdf1_6f949137',NULL),(37,'2015-05-20 14:30:11','Patch Set 3: Patch Set 2 was rebased',668,2,668,'9adffdf1_7230f656',NULL),(15,'2015-05-19 09:52:27','Patch Set 2: Commit message was updated',668,2,668,'9adffdf1_8ffbf546',NULL),(15,'2015-05-19 09:55:09','Patch Set 2:\n\n> The patch looks ok if we want to add /usr/local/[s]bin paths to the\n > PATH. Do we want that?\n\nI guess so, Its the default location for locally installed packages by the user.',668,2,668,'9adffdf1_aff8394a',NULL),(7,'2015-05-19 09:42:21','Patch Set 1:\n\nThe patch looks ok if we want to add /usr/local/[s]bin paths to the PATH. Do we want that?',668,1,668,'9adffdf1_effe4138',NULL),(15,'2015-05-18 14:04:05','Patch Set 1: Code-Review+1',669,1,669,'9adffdf1_2fec49c7',NULL),(37,'2015-05-20 14:33:13','Patch Set 1: Code-Review+2',669,1,669,'9adffdf1_323a6e37',NULL),(43,'2015-05-18 13:40:36','Uploaded patch set 1.',669,1,669,'9adffdf1_8fac558e',NULL),(8,'2015-05-19 13:34:40','Patch Set 1: Code-Review+1',669,1,669,'9adffdf1_cf76ddd8',NULL),(37,'2015-05-20 14:33:16','Patch Set 2: Patch Set 1 was rebased',669,1,669,'9adffdf1_d23e8229',NULL),(37,'2015-05-20 14:33:17','Change has been successfully rebased as 3e71b0a5fc45571ba951f975d1b605a6ffac1497',669,1,669,'9adffdf1_f23b8636',NULL),(28,'2015-05-20 11:24:20','Patch Set 2: Code-Review-1\n\n(21 comments)',670,2,670,'9adffdf1_12abaa8a',NULL),(8,'2015-05-19 13:52:52','Patch Set 1: Code-Review+1\n\n(3 comments)\n\nJust some nitpicking comments, for the rest I can\'t see anything wrong and I know you have tested a lot.',670,1,670,'9adffdf1_4f4aed84',NULL),(43,'2015-05-19 14:29:19','Uploaded patch set 2.',670,2,670,'9adffdf1_6f4fb193',NULL),(37,'2015-05-20 14:49:02','Patch Set 2: Code-Review-1\n\n(11 comments)',670,2,670,'9adffdf1_9276ba05',NULL),(43,'2015-05-19 14:30:46','Patch Set 1:\n\n(3 comments)',670,1,670,'9adffdf1_af54b921',NULL),(43,'2015-05-18 13:40:36','Uploaded patch set 1.',670,1,670,'9adffdf1_afa9197d',NULL),(8,'2015-05-19 14:59:52','Patch Set 2: Code-Review+1',670,2,670,'9adffdf1_ef2161b5',NULL),(43,'2015-06-17 13:23:47','Uploaded patch set 3.',670,3,670,'ba51214e_9847b51d',NULL),(15,'2015-08-19 03:59:03','Patch Set 3: Code-Review+1',670,3,670,'fafc7978_46d0b253',NULL),(18,'2015-08-23 06:10:37','Patch Set 3: Code-Review+2',670,3,670,'fafc7978_66b056f5',NULL),(18,'2015-08-23 06:10:44','Change has been successfully rebased as 2b5e86290672926182cd4a592884188654635bc5',670,3,670,'fafc7978_a6919e54',NULL),(18,'2015-08-23 06:10:43','Patch Set 4: Patch Set 3 was rebased',670,3,670,'fafc7978_c694a246',NULL),(NULL,'2015-05-21 02:36:05','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ibfd4db24.\n* Depends on patch set 1 of I5f3bb1ee, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',671,4,671,'7ac40928_ae5ef710',NULL),(43,'2015-05-19 14:29:19','Uploaded patch set 3.',671,3,671,'9adffdf1_0f44e572',NULL),(43,'2015-05-19 12:03:40','Patch Set 1:\n\n(4 comments)',671,1,671,'9adffdf1_0f6dc504',NULL),(28,'2015-05-19 11:14:31','Patch Set 1: Code-Review-1\n\n(4 comments)',671,1,671,'9adffdf1_0fb6258b',NULL),(43,'2015-05-19 12:17:41','Uploaded patch set 2.',671,2,671,'9adffdf1_2f7209e6',NULL),(28,'2015-05-19 15:21:49','Patch Set 3: Code-Review-1\n\n(2 comments)',671,3,671,'9adffdf1_32258eab',NULL),(43,'2015-05-19 15:44:38','Uploaded patch set 4.',671,4,671,'9adffdf1_32810e4b',NULL),(43,'2015-05-18 13:40:36','Uploaded patch set 1.',671,1,671,'9adffdf1_4fb66dde',NULL),(43,'2015-05-19 15:39:48','Patch Set 3:\n\n(3 comments)',671,3,671,'9adffdf1_52829253',NULL),(37,'2015-05-20 14:34:21','Patch Set 4: Code-Review+2',671,4,671,'9adffdf1_9248facd',NULL),(27,'2015-05-19 15:25:23','Patch Set 3: Code-Review-1\n\n(1 comment)\n\ni\'d let the IP setting through as it can be altered by the end user easy enough, but the tabs look off to me, just pointing out the spelling error in the start of file doc since the tabs need looking at anyway.',671,3,671,'9adffdf1_b2309ee9',NULL),(NULL,'2015-05-20 14:34:24','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of Ibfd4db24.\n* Depends on patch set 1 of I5f3bb1ee, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',671,4,671,'9adffdf1_b245feb4',NULL),(27,'2015-05-19 16:08:22','Patch Set 4: Code-Review+1\n\nPatrick has explained the indentation to me in person and it makes sense to me now.',671,4,671,'9adffdf1_b2e3be32',NULL),(28,'2015-05-19 16:03:42','Patch Set 4: Code-Review+1',671,4,671,'9adffdf1_f2d94684',NULL),(43,'2015-09-07 12:10:22','Abandoned\n\nAppears to be just a trivial formatting change to something that has been merged as part of a separate patch perhaps.',671,4,671,'fafc7978_ec68a789',NULL),(15,'2015-05-18 13:55:39','Patch Set 1:\n\nTested on x86_64 hardware',672,1,672,'9adffdf1_0fb065dc',NULL),(15,'2015-05-19 15:32:36','Patch Set 1:\n\n> I thought we used a different version of Mesa altogether on x86?\n > Are VMs and hardware treated separately? If so, this is all getting\n > pretty confusing and should be commented in the .morph files...\n > \n > The update looks fine to me anyway, not tested\n\nThe -vm variant is to have 3D acceleration in vm (an option in mesa was removed in 10.4 and swrast doesnt work anymore in those cases).\nNevertheless, in the future 10.6, the support has been reimplemented in another way, so we will be able to remove the -vm variant and all the confusions!',672,1,672,'9adffdf1_12572a04',NULL),(15,'2015-05-19 15:35:39','Uploaded patch set 3.',672,3,672,'9adffdf1_32734eb3',NULL),(15,'2015-05-19 15:34:18','Patch Set 2: Code-Review+2',672,2,672,'9adffdf1_5274d29b',NULL),(15,'2015-05-18 13:54:46','Uploaded patch set 1.',672,1,672,'9adffdf1_6fbb31c5',NULL),(NULL,'2015-05-19 15:33:48','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I476e8a2f, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',672,1,672,'9adffdf1_924a3a54',NULL),(15,'2015-05-19 15:34:15','Patch Set 2: Patch Set 1 was rebased',672,1,672,'9adffdf1_b2473e4b',NULL),(15,'2015-05-19 15:33:47','Patch Set 1: Code-Review+2',672,1,672,'9adffdf1_d240c237',NULL),(15,'2015-05-19 15:35:46','Patch Set 3: Code-Review+2',672,3,672,'9adffdf1_d26762e9',NULL),(6,'2015-05-19 15:18:48','Patch Set 1: Code-Review+1\n\nI thought we used a different version of Mesa altogether on x86? Are VMs and hardware treated separately? If so, this is all getting pretty confusing and should be commented in the .morph files...\n\nThe update looks fine to me anyway, not tested',672,1,672,'9adffdf1_f20f062d',NULL),(35,'2015-05-19 15:23:14','Patch Set 1: Code-Review+1\n\nNot tested this on a jetson yet, i\'ll assume it works since you apparently didn\'t have an trouble rebasing the nouveau patches on top',672,1,672,'9adffdf1_f23626e7',NULL),(15,'2015-05-19 15:35:49','Change has been successfully merged into the git repository.',672,3,672,'9adffdf1_f264e6e6',NULL),(6,'2015-05-19 15:17:40','Patch Set 1: Code-Review+2\n\n+2 since I don\'t know if anyone else will review this',673,1,673,'9adffdf1_12096a2c',NULL),(29,'2015-05-19 19:31:31','Change has been successfully rebased as 8f705773cafe9811c98663f5ebe938f0c646ca8f',673,1,673,'9adffdf1_120f2ae3',NULL),(29,'2015-05-18 14:00:51','Uploaded patch set 1.',673,1,673,'9adffdf1_4fdd0d14',NULL),(6,'2015-05-19 15:17:25','Patch Set 1: Code-Review+1\n\nLooks fine',673,1,673,'9adffdf1_72047615',NULL),(29,'2015-05-19 19:31:31','Patch Set 2: Patch Set 1 was rebased',673,1,673,'9adffdf1_720a36d4',NULL),(15,'2015-05-18 14:03:02','Patch Set 1:\n\nTested on x86_64 with intel GPU\n\nAfter this patch X detect the available DRI drivers correctly',674,1,674,'9adffdf1_0fe705e6',NULL),(15,'2015-05-18 14:01:49','Uploaded patch set 1.',674,1,674,'9adffdf1_6fe251d7',NULL),(35,'2015-05-18 15:02:11','Patch Set 1: Code-Review-1\n\nI\'m not sure this is the correct thing to do, at least on fedora dri drivers go in /usr/lib64/dri and xorg driers in /usr/lib64/xorg/modules/drivers\n\nIf you can convince me i\'m wrong i\'ll remove the -1',674,1,674,'9adffdf1_8ff1b597',NULL),(15,'2015-05-19 09:41:53','Abandoned\n\nI rebuilt a system again and this time it seems to recognize the dri drivers in /usr/lib/dri, so no need to change the default. So abandoning this, thanks for the reviews!',674,1,674,'9adffdf1_cf01fd3a',NULL),(8,'2015-05-18 14:48:05','Patch Set 1:\n\n(1 comment)',674,1,674,'9adffdf1_eff40189',NULL),(37,'2015-05-19 16:20:56','Patch Set 1: Code-Review+2',675,1,675,'9adffdf1_32cfceb2',NULL),(8,'2015-05-19 09:12:16','Patch Set 1: Code-Review+1',675,1,675,'9adffdf1_4f60ad35',NULL),(29,'2015-05-18 14:13:03','Uploaded patch set 1.',675,1,675,'9adffdf1_8fda1516',NULL),(37,'2015-05-19 16:20:58','Change has been successfully merged into the git repository.',675,1,675,'9adffdf1_d2c3e288',NULL),(37,'2015-05-18 14:30:07','Patch Set 2:\n\nI am not able to test on every architecture, but the option was added in Linux 2.6.29, which is old enough that all of our platforms should support it.',676,2,676,'9adffdf1_0ffe256c',NULL),(15,'2015-05-18 14:30:31','Patch Set 2: Code-Review+1',676,2,676,'9adffdf1_2f03e974',NULL),(7,'2015-05-19 09:21:56','Change has been successfully merged into the git repository.',676,2,676,'9adffdf1_2fd689c6',NULL),(37,'2015-05-18 14:27:18','Uploaded patch set 1.',676,1,676,'9adffdf1_4f042d7e',NULL),(37,'2015-05-18 14:28:57','Patch Set 2: Commit message was updated',676,2,676,'9adffdf1_6f09f194',NULL),(7,'2015-05-19 09:21:48','Patch Set 2: Code-Review+2',676,2,676,'9adffdf1_6fcc9136',NULL),(8,'2015-05-19 09:07:05','Patch Set 2: Code-Review+1',676,2,676,'9adffdf1_af735914',NULL),(8,'2015-05-26 15:43:39','Patch Set 2: Patch Set 1 was rebased',677,1,677,'1acb0d3e_0b261d69',NULL),(8,'2015-05-26 15:43:39','Change has been successfully rebased as 1360744f436d478c1dd04a4db396863684a1d845',677,1,677,'1acb0d3e_2b2bd931',NULL),(32,'2015-05-26 15:42:26','Patch Set 1: Code-Review+1\n\n> http://git.baserock.org/cgi-bin/cgit.cgi/delta/binutils-redhat.git/commit/?h=baserock/build-essential&id=b1d3b01332ae49a60ff5d6bf53d3a5b1805769c8\n\nOh dear :)\n\nYes, importing the tarball would likely be better.',677,1,677,'1acb0d3e_4b2c254b',NULL),(8,'2015-05-26 15:43:33','Patch Set 1: Code-Review+2',677,1,677,'1acb0d3e_6b31e1a1',NULL),(32,'2015-05-26 15:25:05','Patch Set 1:\n\nCan you explain what you mean by \"instead commit tarball contents in the git repo\" ?\n\nD.',677,1,677,'1acb0d3e_8b6bed84',NULL),(15,'2015-05-26 15:37:53','Patch Set 1:\n\n> Can you explain what you mean by \"instead commit tarball contents\n > in the git repo\" ?\n > \n > D.\n\n > Can you explain what you mean by \"instead commit tarball contents\n > in the git repo\" ?\n > \n > D.\n\nhttp://git.baserock.org/cgi-bin/cgit.cgi/delta/binutils-redhat.git/commit/?h=baserock/build-essential&id=b1d3b01332ae49a60ff5d6bf53d3a5b1805769c8',677,1,677,'1acb0d3e_cbf815c7',NULL),(8,'2015-05-19 09:12:44','Patch Set 1: Code-Review+1',677,1,677,'9adffdf1_6f657144',NULL),(15,'2015-05-18 15:06:04','Uploaded patch set 1.',677,1,677,'9adffdf1_afeef9b2',NULL),(35,'2015-05-18 16:30:01','Uploaded patch set 1.',678,1,678,'9adffdf1_0f0ce593',NULL),(15,'2015-05-19 11:19:33','Patch Set 1: Code-Review+2',678,1,678,'9adffdf1_2fbbe973',NULL),(15,'2015-05-18 18:50:28','Patch Set 1: Code-Review+1\n\n(1 comment)',678,1,678,'9adffdf1_cf6c9d39',NULL),(15,'2015-05-19 11:19:35','Patch Set 2: Patch Set 1 was rebased',678,1,678,'9adffdf1_cfafbd2a',NULL),(15,'2015-05-19 11:19:35','Change has been successfully rebased as f65f26d4cd6742ee26235ce70b98d58b82969caa',678,1,678,'9adffdf1_efac0138',NULL),(29,'2015-06-02 15:18:19','Uploaded patch set 4.',679,4,679,'5aaae553_25730eb3',NULL),(37,'2015-06-02 15:29:00','Change has been successfully rebased as 7c2bfac98e93e42ffcb23e0d43aee8f3d2c01c69',679,4,679,'5aaae553_459baac9',NULL),(37,'2015-06-02 15:27:55','Patch Set 4: Code-Review+2\n\nI thought we\'d also need to have a comment in the definition too so that there\'s bidirectional notification when changes need to be made, but I can\'t think of any reason why you\'d want to change the version number without changing the version in the stratum, so this is sufficient.',679,4,679,'5aaae553_8561a2d5',NULL),(37,'2015-06-02 15:29:00','Patch Set 5: Patch Set 4 was rebased',679,4,679,'5aaae553_a55e1e11',NULL),(29,'2015-06-02 15:21:01','Patch Set 4: Code-Review+1',679,4,679,'5aaae553_c5679ae9',NULL),(24,'2015-05-19 09:39:23','Patch Set 3:\n\n> I don\'t like the fact that you harcode the version number in the\n > chunk morphology, I think we shouldn\'t do that, and we should aim\n > for something generic that shouldn\'t be needed to modify when\n > upgrading the component.\n > \n\nI agree - I did mention that in one of my comments. I think it would be better to check it into the bison repo in a branch called \'baserock/\'\n\n > So, I take that your main goal here is remove bash an git from\n > core?\n\nWe can remove git and curl. We still need bash to build the Linux kernel.',679,3,679,'9adffdf1_0fe8657b',NULL),(24,'2015-05-18 17:01:42','Patch Set 2:\n\nIt might be better to check .tarball-version into the repo branch being built, rather than generate it at configure time',679,2,679,'9adffdf1_4f798dfb',NULL),(24,'2015-05-18 17:25:36','Uploaded patch set 3.',679,3,679,'9adffdf1_6f7ed1e6',NULL),(24,'2015-05-18 16:51:17','Patch Set 2:\n\nNote that the only chunk in core.morph that depends on git and curl, is bison. So those two chunks could be moved from core.morph to tools.morph. I think installing git onto a Baserock development system is fine, but using git at the level of the core stratum to build things is wrong.',679,2,679,'9adffdf1_8f1f75b7',NULL),(24,'2015-05-18 16:57:25','Patch Set 2:\n\nThis fix has been tested by building an OpenWRT system with it by myself. It has also been tested by Paul Martin who build a MIPS based system with it.',679,2,679,'9adffdf1_af1cb9c2',NULL),(24,'2015-05-18 16:46:59','Uploaded patch set 1.',679,1,679,'9adffdf1_cf257d0b',NULL),(7,'2015-05-19 09:27:42','Patch Set 3:\n\nI don\'t like the fact that you harcode the version number in the chunk morphology, I think we shouldn\'t do that, and we should aim for something generic that shouldn\'t be needed to modify when upgrading the component.\n\nSo, I take that your main goal here is remove bash an git from core?',679,3,679,'9adffdf1_cfda5de9',NULL),(24,'2015-05-18 16:47:40','Patch Set 2: Commit message was updated',679,2,679,'9adffdf1_ef22c100',NULL),(37,'2015-05-20 14:27:14','Patch Set 3: Code-Review+1\n\n> I agree - I did mention that in one of my comments. I think\n> it would be better to check it into the bison repo in a\n> branch called \'baserock/\'\n\nI\'d also prefer if we had comments in both the chunk morphology and the stratum morphology to say that the ref and the commands need to keep the version in sync.\nI\'m not opposed to this approach in general though.',679,3,679,'9adffdf1_f2f4e688',NULL),(8,'2015-05-22 09:53:49','Change has been successfully rebased as 9a8e4530ceccbf3e801e6944784b10132eb0c183',680,1,680,'5ac10518_4d2679bc',NULL),(8,'2015-05-22 09:53:40','Patch Set 1: Code-Review+2',680,1,680,'5ac10518_8d1c616c',NULL),(8,'2015-05-22 09:53:49','Patch Set 2: Patch Set 1 was rebased',680,1,680,'5ac10518_ad191d7b',NULL),(6,'2015-05-21 09:28:14','Patch Set 1: Code-Review+1',680,1,680,'7ac40928_4e9bd3c9',NULL),(36,'2015-05-21 10:22:13','Patch Set 1: Code-Review+1',680,1,680,'7ac40928_eeab9fd4',NULL),(15,'2015-05-18 18:46:09','Uploaded patch set 1.',680,1,680,'9adffdf1_0f8385cd',NULL),(15,'2015-05-19 14:53:51','Uploaded patch set 1.',681,1,681,'9adffdf1_0f3b85ec',NULL),(15,'2015-05-19 15:37:21','Patch Set 2: Patch Set 1 was rebased',681,1,681,'9adffdf1_12a5ea03',NULL),(7,'2015-05-19 15:05:20','Patch Set 1:\n\nI assume that everything builds fine, the only thing I\'d like to know before merging is if ostree works in a cross-bootstrap system.',681,1,681,'9adffdf1_2f176953',NULL),(15,'2015-05-19 15:37:22','Change has been successfully rebased as 508d657dd94478d41eb1ec93a1c1556c607d55e6',681,1,681,'9adffdf1_32aa6ed5',NULL),(15,'2015-05-19 15:37:12','Patch Set 1:\n\n> I assume that everything builds fine, the only thing I\'d like to\n > know before merging is if ostree works in a cross-bootstrap system.\n\nNo idea, I\'m trying to fix dependencies here as they are in current definitions. But AFAIK morph doesn\'t use ostree yet',681,1,681,'9adffdf1_529b72c9',NULL),(6,'2015-05-19 15:05:01','Patch Set 1: Code-Review-1\n\nI think that splitting a \'filesystem-tools\' stratum out of \'foundation\' would be a much better approach.\n\nI\'m happy for this to be merged if time to work on this is limited, though.',681,1,681,'9adffdf1_6f1d7173',NULL),(15,'2015-05-19 15:37:16','Patch Set 1: Code-Review+2\n\n> I assume that everything builds fine, the only thing I\'d like to\n > know before merging is if ostree works in a cross-bootstrap system.\n\nNo idea, I\'m trying to fix dependencies here as they are in current definitions. But AFAIK morph doesn\'t use ostree yet',681,1,681,'9adffdf1_72a0f6f4',NULL),(16,'2015-05-19 15:02:30','Patch Set 1: Code-Review+1\n\nLooks OK to me.',681,1,681,'9adffdf1_8f2e95a4',NULL),(32,'2015-05-19 14:59:43','Patch Set 1: Code-Review+1\n\nProviding Javier has verified more than one system works okay with this, it looks a reasonable shift to me.',681,1,681,'9adffdf1_cf249dc8',NULL),(7,'2015-05-26 15:31:54','Change has been successfully merged into the git repository.',682,1,682,'1acb0d3e_0b0ffde2',NULL),(7,'2015-05-26 15:31:47','Patch Set 1: Code-Review+2',682,1,682,'1acb0d3e_6b0a41d4',NULL),(32,'2015-05-26 15:29:16','Patch Set 1: Code-Review+1\n\nLooks reasonable to me -- this appears to be correct according to all shell manuals I can find.',682,1,682,'1acb0d3e_ab682988',NULL),(27,'2015-05-19 15:53:46','Patch Set 1: Code-Review+1\n\nthis seems a good change, that i cant see possibly breaking anything. +',682,1,682,'9adffdf1_12f3aa0b',NULL),(37,'2015-05-19 15:19:16','Uploaded patch set 1.',682,1,682,'9adffdf1_921c7a6c',NULL),(37,'2015-05-22 14:28:45','Patch Set 1: Code-Review+2',683,1,683,'5ac10518_8dbd4105',NULL),(6,'2015-05-22 12:24:27','Patch Set 1: Code-Review+1\n\nNot tested, but looks fine to me.',683,1,683,'5ac10518_ad8cbd80',NULL),(37,'2015-05-22 14:28:48','Change has been successfully merged into the git repository.',683,1,683,'5ac10518_adba7d08',NULL),(7,'2015-05-19 15:53:11','Patch Set 1: Code-Review+1',683,1,683,'9adffdf1_52e93219',NULL),(37,'2015-05-19 15:44:43','Uploaded patch set 1.',683,1,683,'9adffdf1_f292a69e',NULL),(15,'2015-05-19 17:31:04','Uploaded patch set 1.',684,1,684,'9adffdf1_12588af9',NULL),(15,'2015-05-19 17:31:33','Topic changed from btrfs-progs_02 to btrfs-progs_armv5l',684,1,684,'9adffdf1_325d8eea',NULL),(6,'2015-05-20 12:37:22','Patch Set 1: Code-Review+1\n\nThis seems more like a workaround rather than a fix, and a comment in the .morph file explaining that would be nice. Fine by me to merge this workaround, anyway.',684,1,684,'9adffdf1_b29bbe71',NULL),(34,'2015-05-27 11:27:59','Patch Set 1: Code-Review+1\n\nThis works. :) The build doesn\'t work without it.',684,1,684,'fab9d9a7_8a4a0b54',NULL),(15,'2015-05-27 12:31:54','Patch Set 2: Code-Review+2',684,2,684,'fab9d9a7_8a61abd5',NULL),(15,'2015-05-27 12:32:00','Change has been successfully merged into the git repository.',684,2,684,'fab9d9a7_aa5eef10',NULL),(15,'2015-05-27 12:31:06','Uploaded patch set 2.',684,2,684,'fab9d9a7_ca67a3e9',NULL),(15,'2015-05-27 12:31:52','Patch Set 2:\n\n> This seems more like a workaround rather than a fix, and a comment\n > in the .morph file explaining that would be nice. Fine by me to\n > merge this workaround, anyway.\n\nThanks for the review; fixed commit message and comment added',684,2,684,'fab9d9a7_ea64e7e6',NULL),(34,'2015-05-26 09:38:30','Patch Set 4: Code-Review+1\n\n> > I\'d like a clearer commit message, since I\'m not sure if I\'ve\n > > understood it correctly, but this looks like it would be useful\n > to\n > > me. If I *have* understood this correctly, one cross-bootstraps a\n > > system, uses that to build this system, then uses this system to\n > > build all further armv5 systems. (because this system is less\n > > fragile and allows one to deploy locally) So +1 if that looks\n > > right. :)\n > \n > Yeah, that\'s what I was trying to explain in the commit message,\n > sorry for my poor English :) Feel free to improve it as you wish\n > \n > BTW, Did you actually test this system? I ask because you didn\'t \n > comment on the patch from https://gerrit.baserock.org/#/c/684/ ,\n > needed to build this\n\nNo, I haven\'t tested it yet. I meant to and got sidetracked. Hopefully I can get to it today! :)\n\n(Suggested commit message: \'After cross-building an armv5l system, you should build this system, and use this system to build future armv5l-openbmc-aspeed systems. This is because the cross-built system is fragile and does not allow you to deploy a system locally, as the cross-built system does not contain btrfs-progs. This system does.\')',685,4,685,'1acb0d3e_ab19097b',NULL),(6,'2015-05-26 09:14:30','Patch Set 4: Code-Review+1',685,4,685,'1acb0d3e_cb125558',NULL),(15,'2015-05-25 15:17:51','Patch Set 2:\n\n> Given this contains the -openbmc-aspeed BSP, I think\n > build-system-armv5l-openbmc-aspeed would be a better name.\n \nAgreed, done',685,2,685,'3ace114c_0c09572c',NULL),(15,'2015-05-25 15:19:10','Uploaded patch set 4.',685,4,685,'3ace114c_2c0e9335',NULL),(15,'2015-05-25 16:31:18','Topic changed from build-system-armv5l to build-system-armv5l-openbmc-aspeed',685,4,685,'3ace114c_4c267fbc',NULL),(15,'2015-05-25 15:11:25','Patch Set 2:\n\n> I\'d like a clearer commit message, since I\'m not sure if I\'ve\n > understood it correctly, but this looks like it would be useful to\n > me. If I *have* understood this correctly, one cross-bootstraps a\n > system, uses that to build this system, then uses this system to\n > build all further armv5 systems. (because this system is less\n > fragile and allows one to deploy locally) So +1 if that looks\n > right. :)\n\nYeah, that\'s what I was trying to explain in the commit message, sorry for my poor English :) Feel free to improve it as you wish\n\nOne question is, did you actually test to build this system? I ask because you didn\'t comment on \n\n > I\'d like a clearer commit message, since I\'m not sure if I\'ve\n > understood it correctly, but this looks like it would be useful to\n > me. If I *have* understood this correctly, one cross-bootstraps a\n > system, uses that to build this system, then uses this system to\n > build all further armv5 systems. (because this system is less\n > fragile and allows one to deploy locally) So +1 if that looks\n > right. :)\n\nYep, that\'s exactly what I was trying to explain the commit message, sorry for my poor English. Feel free to improve it as you wish! :)\n\nBTW, Did you actually test this system? I ask because you didn\'t comment on the patch from https://gerrit.baserock.org/#/c/684/ , needed to build this',685,2,685,'3ace114c_4cff5f02',NULL),(15,'2015-05-25 15:17:32','Uploaded patch set 3.',685,3,685,'3ace114c_6c049b15',NULL),(34,'2015-05-21 11:53:17','Patch Set 2: Code-Review+1\n\nI\'d like a clearer commit message, since I\'m not sure if I\'ve understood it correctly, but this looks like it would be useful to me. If I *have* understood this correctly, one cross-bootstraps a system, uses that to build this system, then uses this system to build all further armv5 systems. (because this system is less fragile and allows one to deploy locally) So +1 if that looks right. :)',685,2,685,'7ac40928_6e87af62',NULL),(15,'2015-05-19 18:12:32','Uploaded patch set 2.',685,2,685,'9adffdf1_926b1a85',NULL),(6,'2015-05-20 12:36:20','Patch Set 2: Code-Review+1\n\nGiven this contains the -openbmc-aspeed BSP, I think build-system-armv5l-openbmc-aspeed would be a better name.\n\narmv5 is supported in the current version of definitions (version 3), so no new compatibility issues with this patch.',685,2,685,'9adffdf1_929eba62',NULL),(15,'2015-05-19 18:04:21','Uploaded patch set 1.',685,1,685,'9adffdf1_d271a278',NULL),(15,'2015-05-27 13:00:37','Change has been successfully merged into the git repository.',685,5,685,'fab9d9a7_8ab8cb2b',NULL),(15,'2015-05-27 13:00:14','Uploaded patch set 5.',685,5,685,'fab9d9a7_caaec3e7',NULL),(15,'2015-05-27 13:00:33','Patch Set 5: Code-Review+2',685,5,685,'fab9d9a7_eaab87d4',NULL),(15,'2015-06-01 10:55:06','Patch Set 3: Code-Review+2',686,3,686,'7aade967_267316b3',NULL),(15,'2015-06-01 10:55:10','Patch Set 4: Patch Set 3 was rebased',686,3,686,'7aade967_c667a2e9',NULL),(15,'2015-06-01 10:55:12','Change has been successfully rebased as 83bc18dc621b24700a286d1cb2de357a99dc968c',686,3,686,'7aade967_e6641ee7',NULL),(15,'2015-05-19 18:14:00','Patch Set 1: Code-Review-1\n\nWIP: no commit yet until we found the correct parameters to make the image to work',686,1,686,'9adffdf1_5205b2c0',NULL),(15,'2015-05-19 18:13:12','Patch Set 1: Code-Review+2',686,1,686,'9adffdf1_b2689e88',NULL),(15,'2015-05-19 18:11:36','Uploaded patch set 1.',686,1,686,'9adffdf1_f26e2696',NULL),(22,'2015-05-29 13:06:35','Patch Set 3: Code-Review+1\n\nLooks good! Have tested by replacing the armv5 minimal system with the x86_64 generic system and it works.',686,3,686,'bab3e1c7_884a1754',NULL),(34,'2015-05-29 11:39:12','Patch Set 2:\n\n(1 comment)',686,2,686,'bab3e1c7_a8303be9',NULL),(15,'2015-05-29 12:17:08','Uploaded patch set 3.',686,3,686,'bab3e1c7_c8400f38',NULL),(6,'2015-05-29 13:30:16','Patch Set 3: Code-Review+1\n\nLooks fine, I\'m not entirely sure it makes sense to have the openbmc-aspeed stuff in the reference definitions.git repo as it seems quite specialised, but it\'s fine for the moment.',686,3,686,'bab3e1c7_c867afe9',NULL),(15,'2015-05-29 11:07:31','Uploaded patch set 2.',686,2,686,'bab3e1c7_e83633e7',NULL),(22,'2015-05-28 15:32:53','Patch Set 1:\n\n(1 comment)',686,1,686,'dabed58f_4982e153',NULL),(32,'2015-05-26 15:33:08','Patch Set 1: Code-Review+1\n\nOn the assumption that you\'ve verified that nothing we have depends explicitly on the libexpat variant of the module, I\'m okay with this.',687,1,687,'1acb0d3e_2b1439f4',NULL),(15,'2015-05-26 15:49:27','Patch Set 2: Patch Set 1 was rebased',687,1,687,'1acb0d3e_4bd3c538',NULL),(15,'2015-05-26 15:49:28','Change has been successfully rebased as ce2d609fea5b5ed77d244f93c018d29c2f8a19b4',687,1,687,'1acb0d3e_6bd80154',NULL),(15,'2015-05-26 15:49:25','Patch Set 1: Code-Review+2',687,1,687,'1acb0d3e_ab16e9ef',NULL),(15,'2015-05-19 20:56:38','Uploaded patch set 1.',687,1,687,'9adffdf1_3214aef4',NULL),(6,'2015-05-20 12:34:44','Patch Set 1: Code-Review+1\n\nI\'ve not tested this, I trust you have. It does indeed seem weird that XML-Parse would need *two* XML libraries.',687,1,687,'9adffdf1_f2914653',NULL),(8,'2015-05-26 08:02:21','Change has been successfully merged into the git repository.',688,1,688,'1acb0d3e_0b093d2c',NULL),(8,'2015-05-26 08:02:18','Patch Set 1: Code-Review+2',688,1,688,'1acb0d3e_6b048115',NULL),(36,'2015-05-20 09:59:18','Uploaded patch set 1.',688,1,688,'9adffdf1_7231d6a1',NULL),(6,'2015-05-20 12:34:08','Patch Set 1: Code-Review+1\n\nThanks, this seems reasonable.',688,1,688,'9adffdf1_d2944246',NULL),(8,'2015-05-20 13:46:44','Patch Set 1: Code-Review+1',689,1,689,'9adffdf1_3287ce11',NULL),(16,'2015-05-20 10:32:09','Patch Set 1: Code-Review+1',689,1,689,'9adffdf1_72d8f653',NULL),(6,'2015-05-20 10:29:43','Uploaded patch set 1.',689,1,689,'9adffdf1_9219da24',NULL),(6,'2015-05-20 13:51:10','Change has been successfully merged into the git repository.',689,1,689,'9adffdf1_92755a34',NULL),(6,'2015-05-20 13:51:08','Patch Set 1: Code-Review+2',689,1,689,'9adffdf1_f278662d',NULL),(7,'2015-05-22 11:25:45','Patch Set 1: Code-Review+1',690,1,690,'5ac10518_2d73edb2',NULL),(7,'2015-05-22 11:26:02','Change has been successfully rebased as 34ce43225daac688e94960e5ecbf9f9c79208963',690,1,690,'5ac10518_8d61c1d5',NULL),(7,'2015-05-22 11:26:02','Patch Set 1: Code-Review+2',690,1,690,'5ac10518_cd67c9e9',NULL),(7,'2015-05-22 11:26:02','Patch Set 2: Patch Set 1 was rebased',690,1,690,'5ac10518_ed6405e7',NULL),(36,'2015-05-21 10:41:09','Patch Set 1: Code-Review+1',690,1,690,'7ac40928_8eb8db2b',NULL),(6,'2015-05-20 12:32:43','Uploaded patch set 1.',690,1,690,'9adffdf1_32b02ef4',NULL),(16,'2015-05-21 09:34:49','Patch Set 1: Code-Review+1',691,1,691,'7ac40928_0ea5cb03',NULL),(7,'2015-05-21 09:34:58','Patch Set 1: Code-Review+2',691,1,691,'7ac40928_2eaa07d5',NULL),(8,'2015-05-21 09:32:54','Uploaded patch set 1.',691,1,691,'7ac40928_6ea00ff5',NULL),(7,'2015-05-21 09:35:00','Change has been successfully merged into the git repository.',691,1,691,'7ac40928_ceaee3e7',NULL),(8,'2015-05-21 13:35:54','Patch Set 1: Code-Review+2',692,1,692,'7ac40928_0e7ceb71',NULL),(7,'2015-05-21 13:36:59','Patch Set 2: Commit message was updated',692,2,692,'7ac40928_2e81a74a',NULL),(8,'2015-05-21 11:40:46','Patch Set 1: Code-Review+1',692,1,692,'7ac40928_4e82f353',NULL),(7,'2015-05-21 13:40:48','Patch Set 3:\n\n+2 since I know that the previous reviews still apply',692,3,692,'7ac40928_4ee99319',NULL),(7,'2015-05-21 13:40:50','Change has been successfully merged into the git repository.',692,3,692,'7ac40928_6eeecf24',NULL),(22,'2015-05-21 13:39:39','Patch Set 3: Code-Review+1',692,3,692,'7ac40928_8e8f7b75',NULL),(7,'2015-05-21 13:40:25','Patch Set 3: Code-Review+2',692,3,692,'7ac40928_ae8cb780',NULL),(7,'2015-05-21 11:39:29','Uploaded patch set 1.',692,1,692,'7ac40928_aeb59732',NULL),(8,'2015-05-21 13:37:57','Patch Set 2: Code-Review+1',692,2,692,'7ac40928_ce958389',NULL),(7,'2015-05-21 13:38:54','Patch Set 3: Commit message was updated',692,3,692,'7ac40928_ee92bf9e',NULL),(7,'2015-05-26 14:03:10','Patch Set 1: Code-Review+1\n\nThis looks great, but Richard may want to rework it before merging.',693,1,693,'1acb0d3e_0b413d0b',NULL),(8,'2015-05-26 08:01:41','Patch Set 1: Code-Review+1\n\nI agree with Sam that it would be nice in a function.',693,1,693,'1acb0d3e_4bff4502',NULL),(6,'2015-05-22 12:23:58','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLooks fine, thanks. I\'ve not tested this.',693,1,693,'5ac10518_8d8f8175',NULL),(29,'2015-05-21 14:22:53','Uploaded patch set 1.',693,1,693,'7ac40928_0ef38b0b',NULL),(16,'2015-05-29 08:56:22','Patch Set 2: Code-Review+1\n\nLooks fine to me.',693,2,693,'bab3e1c7_68048315',NULL),(29,'2015-05-29 14:21:20','Change has been successfully rebased as 501181a7d920008838cc60106a5de8c5c7cf1eb7',693,2,693,'bab3e1c7_888f7775',NULL),(29,'2015-05-29 14:21:17','Patch Set 2: Code-Review+2',693,2,693,'bab3e1c7_c8956f89',NULL),(29,'2015-05-29 14:21:20','Patch Set 3: Patch Set 2 was rebased',693,2,693,'bab3e1c7_e892b39e',NULL),(7,'2015-05-28 09:39:01','Patch Set 2: Code-Review+1\n\nMuch neater than it was before, thanks!',693,2,693,'dabed58f_c9125158',NULL),(29,'2015-05-27 08:28:01','Patch Set 1: Code-Review-2\n\nChanges pending',693,1,693,'fab9d9a7_0a093b2c',NULL),(29,'2015-05-27 10:33:57','Uploaded patch set 2.',693,2,693,'fab9d9a7_4a2653bc',NULL),(6,'2015-05-27 13:07:07','Patch Set 2:\n\n> > This seems to introduce a change that isn\'t mentioned in the\n > commit\n > > message (checking the OPENSTACK_IMAGENAME). Please mention that\n > > change there (or split it into a separate commit, but that seems\n > > like more work).\n > >\n > > Other than that, looks like a good improvement. I\'ve not tested\n > > this.\n > \n > checking OPENSTACK_IMAGENAME isn\'t a new change, it\'s just that\n > I decided to split it out from obtaining the auth params.\n > \n > I have switched to raising an exception if the parameter\n > is empty as well as if it\'s undefined, this potentially\n > means that if someone wanted to specify an empty password\n > then they wouldn\'t be able to, in practice I don\'t think\n > this matters since from what I can gather openstack doesn\'t\n > permit empty passwords [1]\n > \n > [1]: https://bugs.launchpad.net/python-keystoneclient/+bug/1391116\n\nok, I understand now.',693,2,693,'fab9d9a7_4a82d353',NULL),(29,'2015-05-27 10:34:22','Patch Set 2: -Code-Review',693,2,693,'fab9d9a7_6a2b1783',NULL),(6,'2015-05-27 12:03:01','Patch Set 2: Code-Review+1\n\nThis seems to introduce a change that isn\'t mentioned in the commit message (checking the OPENSTACK_IMAGENAME). Please mention that change there (or split it into a separate commit, but that seems like more work).\n\nOther than that, looks like a good improvement. I\'ve not tested this.',693,2,693,'fab9d9a7_6a79d792',NULL),(29,'2015-05-27 12:54:45','Patch Set 2:\n\n> This seems to introduce a change that isn\'t mentioned in the commit\n > message (checking the OPENSTACK_IMAGENAME). Please mention that\n > change there (or split it into a separate commit, but that seems\n > like more work).\n > \n > Other than that, looks like a good improvement. I\'ve not tested\n > this.\n\nchecking OPENSTACK_IMAGENAME isn\'t a new change, it\'s just that\nI decided to split it out from obtaining the auth params.\n\nI have switched to raising an exception if the parameter\nis empty as well as if it\'s undefined, this potentially\nmeans that if someone wanted to specify an empty password\nthen they wouldn\'t be able to, in practice I don\'t think\nthis matters since from what I can gather openstack doesn\'t\npermit empty passwords [1]\n\n[1]: https://bugs.launchpad.net/python-keystoneclient/+bug/1391116',693,2,693,'fab9d9a7_6aa0f7f4',NULL),(29,'2015-05-21 15:56:38','Change has been successfully merged into the git repository.',694,1,694,'7ac40928_4ed0b353',NULL),(16,'2015-05-21 15:54:56','Patch Set 1: Code-Review+1',694,1,694,'7ac40928_8ee69b43',NULL),(29,'2015-05-21 15:55:28','Patch Set 1: Code-Review+2',694,1,694,'7ac40928_aee35732',NULL),(7,'2015-05-21 15:53:13','Uploaded patch set 1.',694,1,694,'7ac40928_cedca377',NULL),(8,'2015-05-21 15:54:25','Patch Set 1: Code-Review+1',694,1,694,'7ac40928_eed95f84',NULL),(7,'2015-05-21 16:35:07','Patch Set 1: Code-Review+2',695,1,695,'7ac40928_0ecaaba1',NULL),(7,'2015-05-21 16:35:09','Change has been successfully merged into the git repository.',695,1,695,'7ac40928_2ecf67b2',NULL),(8,'2015-05-21 16:33:19','Uploaded patch set 1.',695,1,695,'7ac40928_6ed56f42',NULL),(29,'2015-05-26 13:34:41','Patch Set 3: Patch Set 2 was rebased',696,2,696,'1acb0d3e_8b8f6d75',NULL),(29,'2015-05-26 13:34:41','Change has been successfully rebased as 9fd2b6f8934e3d3b47790ec2a83cc2fb0f9b49a8',696,2,696,'1acb0d3e_ab8ca980',NULL),(29,'2015-05-26 13:34:27','Patch Set 2: Code-Review+2',696,2,696,'1acb0d3e_eb92b19e',NULL),(29,'2015-05-22 13:23:57','Patch Set 2: Code-Review+1',696,2,696,'5ac10518_0df3910b',NULL),(36,'2015-05-22 11:02:54','Patch Set 1: Code-Review+1',696,1,696,'5ac10518_2d5c4d25',NULL),(29,'2015-05-22 13:17:05','Patch Set 1: Code-Review-2',696,1,696,'5ac10518_4de99919',NULL),(29,'2015-05-22 13:23:17','Uploaded patch set 2.',696,2,696,'5ac10518_6deed524',NULL),(8,'2015-05-22 13:35:16','Patch Set 2: Code-Review+1',696,2,696,'5ac10518_cddca977',NULL),(29,'2015-05-21 16:48:26','Patch Set 1: Code-Review-1\n\n(1 comment)',696,1,696,'7ac40928_4e3753b1',NULL),(29,'2015-05-21 17:04:05','Patch Set 1:\n\n(1 comment)\n\nOther than the unpetrify-ref this looks good to me',696,1,696,'7ac40928_8e545bcb',NULL),(19,'2015-05-21 16:39:44','Uploaded patch set 1.',696,1,696,'7ac40928_cec34389',NULL),(29,'2015-05-22 13:28:30','Patch Set 1: Code-Review-1',697,1,697,'5ac10518_2df8cde4',NULL),(8,'2015-05-22 11:24:17','Patch Set 1: Code-Review-1\n\n(1 comment)',697,1,697,'5ac10518_6d79f592',NULL),(8,'2015-05-22 11:19:42','Patch Set 1:\n\n(2 comments)\n\nThere is a typo in the commit message, \"necessary\"\n\nThe patch looks fine, although I have some comments which makes me being not sure about it in order to vote it.',697,1,697,'5ac10518_ad47dd4a',NULL),(36,'2015-05-22 11:03:23','Patch Set 1: Code-Review+1',697,1,697,'5ac10518_cd402938',NULL),(19,'2015-05-21 16:39:44','Uploaded patch set 1.',697,1,697,'7ac40928_eec07f7e',NULL),(19,'2015-05-27 10:18:30','Abandoned\n\nWill be reworked with a new source for openjdk.',697,1,697,'fab9d9a7_aa190f7b',NULL),(8,'2015-05-22 11:24:59','Patch Set 1: Code-Review+1',698,1,698,'5ac10518_0d6e31ca',NULL),(29,'2015-05-22 13:43:46','Patch Set 1: Code-Review+1',698,1,698,'5ac10518_8de6a143',NULL),(19,'2015-05-21 16:39:44','Uploaded patch set 1.',698,1,698,'7ac40928_8ebd3b05',NULL),(19,'2015-05-27 10:18:11','Abandoned\n\nWill be rebased with extra things added to assist the build.',698,1,698,'fab9d9a7_8a1c4b6c',NULL),(7,'2015-05-21 16:53:16','Patch Set 1: Code-Review+2\n\nLooks Great, thanks!',699,1,699,'7ac40928_0e414b0b',NULL),(7,'2015-05-21 16:53:19','Change has been successfully merged into the git repository.',699,1,699,'7ac40928_2e468724',NULL),(8,'2015-05-21 16:50:27','Uploaded patch set 1.',699,1,699,'7ac40928_6e3c8f94',NULL),(7,'2015-05-22 11:28:06','Change has been successfully rebased as 699aa6c13b0d265bae6fb6d1bd6e902760acd7f3',700,1,700,'5ac10518_0da5d103',NULL),(7,'2015-05-22 11:28:03','Patch Set 1: Code-Review+2',700,1,700,'5ac10518_4d9bd9c9',NULL),(24,'2015-05-22 07:22:30','Uploaded patch set 1.',700,1,700,'5ac10518_4dff5902',NULL),(29,'2015-05-22 08:12:23','Patch Set 1: Code-Review+1',700,1,700,'5ac10518_6d049515',NULL),(7,'2015-05-22 11:28:06','Patch Set 2: Patch Set 1 was rebased',700,1,700,'5ac10518_6da015f5',NULL),(29,'2015-05-22 08:47:01','Uploaded patch set 1.',701,1,701,'5ac10518_0d09512c',NULL),(16,'2015-05-22 08:52:40','Patch Set 1: Code-Review+1\n\nSeems fine to me.',701,1,701,'5ac10518_2d0e8d35',NULL),(37,'2015-05-27 14:15:51','Patch Set 2: Patch Set 1 was rebased',701,1,701,'fab9d9a7_8a8f6b75',NULL),(37,'2015-05-27 14:15:52','Change has been successfully rebased as 4ce4366ca03873da4c11000b564dbcd487399e59',701,1,701,'fab9d9a7_aa8caf80',NULL),(37,'2015-05-27 14:15:49','Patch Set 1: Code-Review+2',701,1,701,'fab9d9a7_ea92a79e',NULL),(32,'2015-05-26 13:13:48','Patch Set 2: Code-Review+1\n\nLooks okay to me.',702,2,702,'1acb0d3e_2baaf9d4',NULL),(6,'2015-05-26 13:06:56','Patch Set 2: Code-Review+1',702,2,702,'1acb0d3e_ab5ee910',NULL),(37,'2015-05-22 14:58:33','Patch Set 1:\n\n(2 comments)',702,1,702,'5ac10518_6d6335b2',NULL),(37,'2015-05-22 15:13:51','Uploaded patch set 2.',702,2,702,'5ac10518_ad683d88',NULL),(37,'2015-05-22 09:36:21','Uploaded patch set 1.',702,1,702,'5ac10518_cd126958',NULL),(6,'2015-05-22 09:59:01','Patch Set 1:\n\n(2 comments)',702,1,702,'5ac10518_cd3909da',NULL),(37,'2015-05-27 14:28:07','Patch Set 3: Patch Set 2 was rebased',702,2,702,'fab9d9a7_8ae68b43',NULL),(37,'2015-05-27 14:28:08','Change has been successfully rebased as 87bfac4ebf7969319d34e1c2562c3179739bd868',702,2,702,'fab9d9a7_aae34f32',NULL),(37,'2015-05-27 14:27:58','Patch Set 2: Code-Review+2',702,2,702,'fab9d9a7_ead94784',NULL),(32,'2015-05-26 13:13:37','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLooks reasonable, I have only one question which shouldn\'t block merge',703,2,703,'1acb0d3e_0ba5bd03',NULL),(6,'2015-05-26 13:06:30','Patch Set 2: Code-Review+1',703,2,703,'1acb0d3e_8b61add5',NULL),(37,'2015-05-22 15:13:51','Uploaded patch set 2.',703,2,703,'5ac10518_4d0519c1',NULL),(6,'2015-05-22 09:57:25','Patch Set 1: Code-Review+1\n\nSeems sensible and correct.',703,1,703,'5ac10518_6d2b3583',NULL),(8,'2015-05-22 11:26:44','Patch Set 1: Code-Review+1',703,1,703,'5ac10518_ad5efd10',NULL),(37,'2015-05-22 09:36:21','Uploaded patch set 1.',703,1,703,'5ac10518_ed0f252d',NULL),(NULL,'2015-05-27 16:33:12','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 2 of I2ec4b880, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',703,2,703,'fab9d9a7_0a413b0b',NULL),(37,'2015-05-27 16:33:17','Patch Set 3: Patch Set 2 was rebased',703,2,703,'fab9d9a7_2a467f24',NULL),(37,'2015-05-27 16:33:09','Patch Set 2: Code-Review+2',703,2,703,'fab9d9a7_6a3c7794',NULL),(37,'2015-05-27 16:33:22','Patch Set 3: Code-Review+2',703,3,703,'fab9d9a7_ca4a4327',NULL),(37,'2015-05-27 14:25:26','Patch Set 2:\n\n(1 comment)',703,2,703,'fab9d9a7_cadc8377',NULL),(37,'2015-05-27 16:33:24','Change has been successfully merged into the git repository.',703,3,703,'fab9d9a7_ea47071c',NULL),(32,'2015-05-26 13:30:47','Patch Set 2:\n\n(2 comments)\n\nI don\'t want to block this since clearly it\'s useful, but I worry about\nthe lack of futureproofing.',704,2,704,'1acb0d3e_0b7cdd71',NULL),(6,'2015-05-22 15:07:29','Patch Set 2: Code-Review+1\n\nLooks ok, thanks for redoing',704,2,704,'5ac10518_2d5d2dea',NULL),(6,'2015-05-22 12:18:51','Patch Set 1:\n\nI agree that it\'s useful to be able to get machine-readable output, but I think this shouldn\'t be done by adding a new user-facing command that will show up in `system-version-manager --help`.\n\nHow difficult do you think it\'d be to, instead, add a --json flag, which would cause a command to output machine-readable JSON instead of text formatted for console output?\n\nIt would be fine for only `system-version-manager list` to actually support the --json flag for the time being.',704,1,704,'5ac10518_4d82f953',NULL),(29,'2015-05-22 14:35:48','Uploaded patch set 2.',704,2,704,'5ac10518_cd4a6927',NULL),(29,'2015-05-22 09:59:44','Uploaded patch set 1.',704,1,704,'5ac10518_ed3645e7',NULL),(27,'2015-05-22 14:40:46','Patch Set 2: Code-Review+1\n\nseems sensible to me.',704,2,704,'5ac10518_ed47251c',NULL),(37,'2015-06-17 10:50:30','Patch Set 2: Code-Review+1\n\n(1 comment)\n\nI think this would be very useful, and look forward to Mr Ipsum finishing this to his satisfaction.',704,2,704,'ba51214e_98ab35d6',NULL),(29,'2015-05-27 11:15:48','Patch Set 2: Code-Review-2\n\n(1 comment)',704,2,704,'fab9d9a7_2a5c3f25',NULL),(32,'2015-05-27 12:21:53','Patch Set 2:\n\n(1 comment)',704,2,704,'fab9d9a7_2a73dfb2',NULL),(32,'2015-05-27 10:47:06','Patch Set 2:\n\n(1 comment)\n\nCurrently I am not happy, but still not blocking unless others agree with my discomfort.',704,2,704,'fab9d9a7_4a4df371',NULL),(29,'2015-05-27 10:42:45','Patch Set 2:\n\n(1 comment)',704,2,704,'fab9d9a7_8a33ebf5',NULL),(37,'2015-06-24 15:04:25','Uploaded patch set 3.',704,3,704,'fafc7978_727c9873',NULL),(6,'2015-06-24 16:21:25','Abandoned\n\nRichard Maw has agreed to adopt this change and will resubmit as a separate patch (as changing the owner of an existing change in Gerrit is hard)',704,3,704,'fafc7978_92d93c86',NULL),(6,'2015-05-26 13:07:37','Patch Set 2: Code-Review+1\n\nLooks fine, i\'ve not tested this',705,2,705,'1acb0d3e_4b9bc5c9',NULL),(32,'2015-05-26 13:34:45','Patch Set 2: Code-Review-1\n\n(2 comments)\n\nNot quite happy with this yet.',705,2,705,'1acb0d3e_4be98519',NULL),(29,'2015-05-22 15:05:19','Uploaded patch set 2.',705,2,705,'5ac10518_0d5871f9',NULL),(6,'2015-05-22 12:21:33','Patch Set 1:\n\n(1 comment)',705,1,705,'5ac10518_0d7cf171',NULL),(6,'2015-05-22 14:12:23','Patch Set 1:\n\n(1 comment)',705,1,705,'5ac10518_0dcab1a1',NULL),(6,'2015-05-22 12:21:47','Patch Set 1: Code-Review-1',705,1,705,'5ac10518_2d81ad4a',NULL),(29,'2015-05-22 13:57:39','Patch Set 1:\n\n(1 comment)',705,1,705,'5ac10518_4dd0b953',NULL),(29,'2015-05-22 10:00:13','Uploaded patch set 1.',705,1,705,'5ac10518_8d3301f6',NULL),(29,'2015-05-22 14:43:21','Patch Set 1:\n\n(1 comment)',705,1,705,'5ac10518_ad511dda',NULL),(29,'2015-06-17 11:24:10','Patch Set 3: Code-Review-2\n\nHi, sorry, I have every intention of fixing this to address Daniel\'s comments before merging, this will happen soon™ :)',705,3,705,'ba51214e_38d02953',NULL),(32,'2015-06-17 11:00:36','Patch Set 3:\n\n> I\'d accept this change now. The api of the version list command is\n > not likely to change incompatibly, and it handles the command not\n > working.\n\nWhile invoking the command isn\'t likely to change, there is an open question of what format of data it should return. I\'d hold off on this until we know the data format it is going to return.',705,3,705,'ba51214e_78f3c10a',NULL),(37,'2015-06-17 10:54:37','Patch Set 3: Code-Review+1\n\nI\'d accept this change now. The api of the version list command is not likely to change incompatibly, and it handles the command not working.',705,3,705,'ba51214e_f8b8712c',NULL),(7,'2015-05-29 15:02:31','Patch Set 3: Code-Review+1\n\nThis looks great.',705,3,705,'bab3e1c7_c8dc8f77',NULL),(7,'2015-05-29 15:04:17','Patch Set 3: -Code-Review\n\nAlthough it doesn\'t make sense to merge it before the tbdiff patch to add --json to system-version-manager :)',705,3,705,'bab3e1c7_e8d95384',NULL),(29,'2015-05-27 07:43:37','Uploaded patch set 3.',705,3,705,'fab9d9a7_4aff3302',NULL),(32,'2015-05-27 08:09:12','Patch Set 3: Code-Review+1\n\nThis appears to have nicely addressed my comments.\n\nI have no reason to believe this won\'t work -- if the OP has thoroughly tested against systems both with and without the proposed list --json feature of s-v-m then I\'m happy.',705,3,705,'fab9d9a7_6a047715',NULL),(6,'2015-06-24 16:21:33','Abandoned\n\nRichard Maw has agreed to adopt this change and will resubmit as a separate patch (as changing the owner of an existing change in Gerrit is hard)',705,3,705,'fafc7978_f2e6c843',NULL),(29,'2015-05-22 10:38:06','Patch Set 1: Code-Review+1',706,1,706,'5ac10518_0d571104',NULL),(29,'2015-05-22 14:28:31','Patch Set 1: Code-Review+2',706,1,706,'5ac10518_2dcf6db2',NULL),(35,'2015-05-22 10:21:41','Uploaded patch set 1.',706,1,706,'5ac10518_6d525515',NULL),(6,'2015-05-22 12:22:38','Patch Set 1: Code-Review+1\n\nNot tested, but looks fine',706,1,706,'5ac10518_cd958989',NULL),(29,'2015-05-22 14:28:34','Patch Set 2: Patch Set 1 was rebased',706,1,706,'5ac10518_cdc34989',NULL),(29,'2015-05-22 14:28:35','Change has been successfully rebased as 1a4cdcf32aa65d0130dae882a7a13e69162274cb',706,1,706,'5ac10518_edc0857e',NULL),(7,'2015-05-22 15:59:56','Patch Set 1:\n\n+2 if you fix the indentation of both files',707,1,707,'5ac10518_0d0f11e3',NULL),(29,'2015-05-22 16:02:13','Uploaded patch set 2.',707,2,707,'5ac10518_2d144df4',NULL),(28,'2015-05-22 14:49:07','Uploaded patch set 1.',707,1,707,'5ac10518_4d5e79eb',NULL),(7,'2015-05-22 16:04:12','Change has been successfully merged into the git repository.',707,2,707,'5ac10518_8d0221b3',NULL),(29,'2015-05-22 16:02:32','Patch Set 2: Code-Review+1',707,2,707,'5ac10518_cdf829c7',NULL),(7,'2015-05-22 16:04:09','Patch Set 2: Code-Review+2',707,2,707,'5ac10518_edf5e5cb',NULL),(7,'2015-05-26 13:48:41','Patch Set 1: Code-Review+2',708,1,708,'1acb0d3e_2bcf59b2',NULL),(32,'2015-05-26 13:24:16','Patch Set 1: Code-Review+1\n\nLooks reasonable to me',708,1,708,'1acb0d3e_8bb8cd2b',NULL),(7,'2015-05-26 13:48:42','Patch Set 2: Patch Set 1 was rebased',708,1,708,'1acb0d3e_cbc33589',NULL),(7,'2015-05-26 13:48:42','Change has been successfully rebased as f1bf81fd582c503ad8f729797676d26cb91b5010',708,1,708,'1acb0d3e_ebc0717e',NULL),(29,'2015-05-22 15:44:59','Uploaded patch set 1.',708,1,708,'5ac10518_6d0a55d4',NULL),(8,'2015-05-22 16:08:06','Patch Set 1: Code-Review+1',708,1,708,'5ac10518_adffdda9',NULL),(28,'2015-05-26 10:05:00','Patch Set 1: Code-Review+1',709,1,709,'1acb0d3e_0b205d9a',NULL),(7,'2015-05-26 13:55:07','Change has been successfully rebased as da770dc8126d5325036634f0e61493a2a88654ab',709,1,709,'1acb0d3e_4b3745b1',NULL),(8,'2015-05-26 10:44:52','Patch Set 1: Code-Review+1',709,1,709,'1acb0d3e_6b524115',NULL),(7,'2015-05-26 13:55:04','Patch Set 1: Code-Review+2\n\nThanks for fixing this',709,1,709,'1acb0d3e_8bbd2d05',NULL),(7,'2015-05-26 13:55:06','Patch Set 2: Patch Set 1 was rebased',709,1,709,'1acb0d3e_abba6908',NULL),(43,'2015-05-22 16:49:55','Uploaded patch set 1.',709,1,709,'5ac10518_4d2c394b',NULL),(43,'2015-05-26 11:37:53','Patch Set 2: Code-Review-1\n\nTiago, the swift manifest will take care of this.\n\noverlooked this, thanks for pointing it out.',710,2,710,'1acb0d3e_0b57fd03',NULL),(43,'2015-05-26 09:13:45','Patch Set 1:\n\nThanks for the review.\n\nI\'m afraid I don\'t follow your second point, could you perhaps\nreword it?',710,1,710,'1acb0d3e_2b0e7935',NULL),(28,'2015-05-26 10:29:18','Patch Set 2: Code-Review-1\n\nI have failed to comprehend this patch.\n\nIsn\'t ntp.conf already installed by swift manifest file?\n\nUntil I get an answer, I am temporarily -1-ing this patch.',710,2,710,'1acb0d3e_2b2519ab',NULL),(43,'2015-05-26 11:38:00','Abandoned',710,2,710,'1acb0d3e_2b5c3925',NULL),(15,'2015-05-26 10:38:25','Patch Set 2:\n\nI still think the commit message doesn\'t explain what is the problem and the fix:\nThe only difference between use the extension you mention or simply left what is currently in the ntpd chunk are the 2 lines I mentioned before in ntpd.conf:\n\n server {{ CONTROLLER_HOST_ADDRESS }} iburst\n\nand\n\n rlimit memlock 256\n\nSo if those 2 lines are the ones needed for the openstack system to work, that should be noted in the commit message',710,2,710,'1acb0d3e_cb39f5d9',NULL),(43,'2015-05-26 09:17:44','Patch Set 2: Commit message was updated',710,2,710,'1acb0d3e_eb0f112d',NULL),(15,'2015-05-25 16:30:37','Patch Set 1: Code-Review-1\n\nI think the commit message can be improved a little here: Why the deployment will fail exactly?\nThe only differences between the ntpd.conf file included in the ntpd chunk and this one is:\n\n> server {{ CONTROLLER_HOST_ADDRESS }} iburst\n\nand\n\n> rlimit memlock 256\n\nProbably is the first one that is missing. Is the second needed as well?',710,1,710,'3ace114c_ac19237b',NULL),(43,'2015-05-22 16:49:55','Uploaded patch set 1.',710,1,710,'5ac10518_6d31f5a1',NULL),(7,'2015-05-26 15:19:04','Patch Set 1: Code-Review+1\n\nThanks for this Javier. We can finally upgrade mesa in x86!',711,1,711,'1acb0d3e_2b5d19ea',NULL),(6,'2015-05-26 13:04:50','Patch Set 1: Code-Review+1\n\nNice !',711,1,711,'1acb0d3e_2b73d9b2',NULL),(15,'2015-05-26 15:48:55','Change has been successfully rebased as 5626aa3649525f488b1d362cac1f9b608889d08a',711,1,711,'1acb0d3e_8b19ad24',NULL),(15,'2015-05-26 15:48:52','Patch Set 1: Code-Review+2',711,1,711,'1acb0d3e_cb1fb508',NULL),(15,'2015-05-26 15:48:54','Patch Set 2: Patch Set 1 was rebased',711,1,711,'1acb0d3e_eb1cf115',NULL),(15,'2015-05-25 16:24:00','Patch Set 1:\n\nTested with a weston system in x86_64 natively and vm environment (qemu): weston-simple-egl works fine in both cases',711,1,711,'3ace114c_8c1c676c',NULL),(15,'2015-05-25 16:22:37','Uploaded patch set 1.',711,1,711,'3ace114c_ec0f2b2d',NULL),(15,'2015-05-25 17:01:51','Patch Set 1:\n\nFYI, I was about to keep this patch until the final 10.6.0 release, but normally the mesa -rc are stable enough and this fixes an important issue (the hack of having a -vm mesa variant for vm\'s).\nAlso, looking to another components (like dbus), seems its ok to sometimes not use the latest stable but a development version instead.',711,1,711,'3ace114c_ec364be7',NULL),(7,'2015-05-26 15:29:57','Patch Set 1:\n\nI agree with Sam, but I always appreciate some testing before doing this change.',712,1,712,'1acb0d3e_4b0505c1',NULL),(6,'2015-05-26 13:05:27','Patch Set 1: Code-Review+1\n\nShould be better than using \'master\' as we do currently!',712,1,712,'1acb0d3e_cb67b5e9',NULL),(7,'2015-06-03 08:53:45','Patch Set 2: Patch Set 1 was rebased',712,1,712,'3aa7f18b_841c466c',NULL),(7,'2015-06-03 08:53:46','Change has been successfully rebased as 86db0239ca262745c16bd42a31a3b09e43c71588',712,1,712,'3aa7f18b_a419427b',NULL),(7,'2015-06-03 08:53:36','Patch Set 1: Code-Review+2\n\nI\'ve done all the mentioned testing, and everything works great.',712,1,712,'3aa7f18b_e40f3a2d',NULL),(15,'2015-05-25 16:51:26','Patch Set 1:\n\nTested in weston system in x86_64 natively and in a x86_64 vm (qemu); no service seems to fail and network connection works as well (systemd-networks seems to work as expected)',712,1,712,'3ace114c_0c20779a',NULL),(15,'2015-05-25 16:47:45','Uploaded patch set 1.',712,1,712,'3ace114c_6c2b3b83',NULL),(7,'2015-06-01 14:41:48','Patch Set 1:\n\nThere are some things that we should test before upgrading to v220:\n- Devel system deployment\n- Trove system deployment\n- Distbuild deployment\n- Mason deployment\n- Openstack depoyment\n- Upgrade and rollback\n- Jetson board deployment',712,1,712,'7aade967_463732b1',NULL),(7,'2015-05-26 15:16:17','Patch Set 1: Code-Review+1\n\nThe change itself looks OK.',713,1,713,'1acb0d3e_0b585df9',NULL),(15,'2015-05-26 15:38:47','Patch Set 2: Patch Set 1 was rebased',713,1,713,'1acb0d3e_8b020db3',NULL),(15,'2015-05-26 15:38:47','Change has been successfully rebased as 4e131bc24466ed7e41a5dfafcaa2d514c2eaede5',713,1,713,'1acb0d3e_abffc9a9',NULL),(6,'2015-05-26 13:05:43','Patch Set 1: Code-Review+1\n\nThanks',713,1,713,'1acb0d3e_eb64f1e6',NULL),(15,'2015-05-26 15:38:42','Patch Set 1: Code-Review+2',713,1,713,'1acb0d3e_ebf5d1cb',NULL),(15,'2015-05-25 16:56:14','Uploaded patch set 1.',713,1,713,'3ace114c_2c2533ab',NULL),(15,'2015-05-25 16:56:50','Patch Set 1:\n\nTested with a weston system in x86_64 natively and in qemu',713,1,713,'3ace114c_cc390fda',NULL),(8,'2015-05-26 13:40:17','Patch Set 3: Commit message was updated',714,3,714,'1acb0d3e_0bf37d0b',NULL),(8,'2015-05-26 13:41:15','Patch Set 3: Code-Review+1',714,3,714,'1acb0d3e_2bf8b9e4',NULL),(28,'2015-05-26 09:48:19','Uploaded patch set 1.',714,1,714,'1acb0d3e_4b2665bc',NULL),(15,'2015-05-26 13:42:20','Patch Set 4: Patch Set 3 was rebased',714,3,714,'1acb0d3e_8be68d43',NULL),(15,'2015-05-26 12:48:25','Patch Set 2: Code-Review+1',714,2,714,'1acb0d3e_ab47c94a',NULL),(32,'2015-05-26 13:27:17','Patch Set 2:\n\nI find the conflation of coreutils vs. findutils annoying here. can we rename the stratum \"gnuutils-common\" ?',714,2,714,'1acb0d3e_abb58932',NULL),(15,'2015-05-26 13:42:21','Change has been successfully rebased as 74fac2adda7467f1eb55dca293057cbe81b0a13b',714,3,714,'1acb0d3e_abe34932',NULL),(28,'2015-05-26 12:43:14','Uploaded patch set 2.',714,2,714,'1acb0d3e_cb401538',NULL),(15,'2015-05-26 13:42:01','Patch Set 3: Code-Review+1\n\n> I find the conflation of coreutils vs. findutils annoying here. \n > can we rename the stratum \"gnuutils-common\" ?\n\nGood idea, but I think that a separate issue that can be fixed in a posterior patch',714,3,714,'1acb0d3e_cbdc9577',NULL),(15,'2015-05-26 10:40:43','Patch Set 1: Code-Review-1\n\nI\'m fine with the patch, but I think is better to put this chunk in the coreutils-common stratum, with the other \"core\" tools: sed, diff ...',714,1,714,'1acb0d3e_eb3631e7',NULL),(15,'2015-05-26 13:42:17','Patch Set 3: Code-Review+2',714,3,714,'1acb0d3e_ebd95184',NULL),(15,'2015-05-26 13:44:03','Change has been successfully rebased as fdbea24797f7559ec8edc0c34f71a8dc5e0a94dc',715,3,715,'1acb0d3e_0bca9da1',NULL),(15,'2015-05-26 10:42:48','Patch Set 1: Code-Review-1\n\n(2 comments)',715,1,715,'1acb0d3e_4b4d0572',NULL),(15,'2015-05-26 13:43:59','Patch Set 3: Code-Review+2',715,3,715,'1acb0d3e_4bd0a553',NULL),(28,'2015-05-26 09:48:19','Uploaded patch set 1.',715,1,715,'1acb0d3e_6b2b2183',NULL),(15,'2015-05-26 13:44:02','Patch Set 4: Patch Set 3 was rebased',715,3,715,'1acb0d3e_6bd56142',NULL),(8,'2015-05-26 13:37:31','Patch Set 3: Code-Review+1',715,3,715,'1acb0d3e_6beec124',NULL),(15,'2015-05-26 12:47:38','Patch Set 2: Code-Review-1\n\nThanks for fixing; sorry for not mention it before but it seems these chunks will fit better in the strata/networking-utils.morph stratum',715,2,715,'1acb0d3e_8b4a0d54',NULL),(28,'2015-05-26 13:17:18','Uploaded patch set 3.',715,3,715,'1acb0d3e_cbaed5e7',NULL),(28,'2015-05-26 12:43:14','Uploaded patch set 2.',715,2,715,'1acb0d3e_eb3dd1bc',NULL),(6,'2015-05-26 13:04:07','Patch Set 2: Code-Review+1',716,2,716,'1acb0d3e_0b6e1dca',NULL),(32,'2015-05-26 14:13:58','Patch Set 2:\n\n> ./buildconf.sh does exactly that (calling autoreconf). But it\n > doesnt work because the project is not using automake, so those\n > files are not generated\n\nI see.\n\nCould we have:\n\n- ./buildconf.sh\n- automake --add-missing --copy || true\n- ./configure\n\nThe invocation of automake --add-missing (at least on my test system) added conftools/install-sh before exiting with failure due to no AM_INIT_AUTOMAKE (understandable)\n\nThis would save us adding another lorry.',716,2,716,'1acb0d3e_2b467924',NULL),(15,'2015-05-26 12:53:57','Uploaded patch set 1.',716,1,716,'1acb0d3e_4b74259c',NULL),(15,'2015-05-26 13:57:29','Patch Set 2:\n\n> normally install[-.]sh is put into the source tree by autoreconf --\n > is expat not working like that?\n\nNo, because the project is not using automake (\n\n > normally install[-.]sh is put into the source tree by autoreconf --\n > is expat not working like that?\n\n./buildconf.sh does exactly that (calling autoreconf). But it doesnt work because the project is not using automake, so those files are not generated',716,2,716,'1acb0d3e_6b3c8194',NULL),(15,'2015-05-26 12:55:10','Uploaded patch set 2.',716,2,716,'1acb0d3e_6b79e192',NULL),(15,'2015-05-26 14:42:28','Abandoned',716,2,716,'1acb0d3e_8b544dcb',NULL),(15,'2015-05-26 14:42:24','Patch Set 2:\n\n> > ./buildconf.sh does exactly that (calling autoreconf). But it\n > > doesnt work because the project is not using automake, so those\n > > files are not generated\n > \n > I see.\n > \n > Could we have:\n > \n > - ./buildconf.sh\n > - automake --add-missing --copy || true\n > - ./configure\n > \n > The invocation of automake --add-missing (at least on my test\n > system) added conftools/install-sh before exiting with failure due\n > to no AM_INIT_AUTOMAKE (understandable)\n > \n > This would save us adding another lorry.\n\nThat worked, thanks for the suggestion!',716,2,716,'1acb0d3e_eb47111c',NULL),(32,'2015-05-26 13:21:53','Patch Set 2:\n\nnormally install[-.]sh is put into the source tree by autoreconf -- is expat not working like that?',716,2,716,'1acb0d3e_ebab91d4',NULL),(32,'2015-05-26 15:55:11','Patch Set 1: Code-Review+1\n\nThis looks reasonable and matches what I suggested.\n\nSo long as Javier has test-built plenty of stuff, including something which uses the XML translation capability then I\'m okay with this.',717,1,717,'1acb0d3e_0bddbd42',NULL),(15,'2015-05-26 16:43:11','Patch Set 1:\n\n> This looks reasonable and matches what I suggested.\n > \n > So long as Javier has test-built plenty of stuff, including\n > something which uses the XML translation capability then I\'m okay\n > with this.\n\nI tested current version of GTK+ and zenity, both of them need this feature',717,1,717,'1acb0d3e_2be2f903',NULL),(7,'2015-05-26 15:14:15','Patch Set 1: Code-Review+1\n\nLooks sensible, although I haven\'t tested the results.',717,1,717,'1acb0d3e_6b6321b2',NULL),(15,'2015-05-26 16:43:15','Change has been successfully rebased as 7e49752a2c92a1da2cf3dcc9cd25bb2f07ed69c8',717,1,717,'1acb0d3e_8bf0cdca',NULL),(15,'2015-05-26 14:58:31','Uploaded patch set 1.',717,1,717,'1acb0d3e_ab5109da',NULL),(15,'2015-05-26 16:43:13','Patch Set 1: Code-Review+2',717,1,717,'1acb0d3e_cbe6d516',NULL),(15,'2015-05-26 16:43:14','Patch Set 2: Patch Set 1 was rebased',717,1,717,'1acb0d3e_ebe39103',NULL),(7,'2015-05-26 21:29:35','Patch Set 1:\n\nNote that the only testing I\'ve done is: build libexpat and gettext.',718,1,718,'1acb0d3e_4bbae5e2',NULL),(7,'2015-05-26 21:25:58','Uploaded patch set 1.',718,1,718,'1acb0d3e_abed89f1',NULL),(32,'2015-05-27 08:53:08','Patch Set 1: Code-Review+1\n\nThere\'s no reason to believe this is bad.\n\nI apologise for not spotting this earlier and blame an assumption that when I asked if it had been tested properly it had.\n\nHave you managed to build further than expat/gettext yet?',718,1,718,'fab9d9a7_2a0e7f35',NULL),(7,'2015-05-27 09:17:49','Patch Set 1:\n\n> Have you managed to build further than expat/gettext yet?\n\nNope, I\'ll build and deploy a base system and report results here. Thanks for reviewing!',718,1,718,'fab9d9a7_ca124358',NULL),(7,'2015-05-27 10:42:34','Patch Set 1: Code-Review+2\n\nI managed to build and deploy a system with these changes. Merging.',718,1,718,'fab9d9a7_ca39e3d9',NULL),(8,'2015-05-27 09:28:43','Patch Set 1: Code-Review+1',718,1,718,'fab9d9a7_ea0f072d',NULL),(7,'2015-05-27 10:42:36','Change has been successfully merged into the git repository.',718,1,718,'fab9d9a7_ea3627e7',NULL),(8,'2015-05-27 10:36:09','Uploaded patch set 1.',719,1,719,'fab9d9a7_0a205b9a',NULL),(8,'2015-05-27 14:09:08','Patch Set 3: Code-Review+2',719,3,719,'fab9d9a7_0a7cdb71',NULL),(15,'2015-05-27 12:55:19','Patch Set 3: Code-Review+1',719,3,719,'fab9d9a7_0aa5bb03',NULL),(8,'2015-05-27 14:09:10','Change has been successfully merged into the git repository.',719,3,719,'fab9d9a7_2a819f4a',NULL),(7,'2015-05-27 12:59:56','Patch Set 3: Code-Review+1\n\nAs I pointed out in #baserock, I\'m not sure that this is the real fix to the bug. So, as I said, if this is the best way to solve it, the repo is tiny (here my +1). This is a good opportunity to contribute to openstack though.',719,3,719,'fab9d9a7_2aaaffd4',NULL),(6,'2015-05-27 12:00:14','Patch Set 2: Code-Review+1\n\nYour commit message is confusing. I thought you were suggesting that we lorried a repo as a way of working around a bug. But surely there are better ways to work around bugs, like fixing them. But the patch linked from that issue seems to \'fix\' the \'bug\' by adding \'requests-aws\' as a dependency of celiometer.. so I think it does indeed make sense to start mirroring this repo',719,2,719,'fab9d9a7_4a74139c',NULL),(8,'2015-05-27 12:52:03','Patch Set 3: Commit message was updated',719,3,719,'fab9d9a7_4a9bb3c9',NULL),(15,'2015-05-27 10:52:26','Patch Set 1: Code-Review+1',719,1,719,'fab9d9a7_6a523715',NULL),(8,'2015-05-27 11:35:20','Uploaded patch set 2.',719,2,719,'fab9d9a7_aa47cf4a',NULL),(6,'2015-05-27 13:05:00','Patch Set 3: Code-Review+1',719,3,719,'fab9d9a7_aab58f32',NULL),(7,'2015-05-27 11:26:57','Patch Set 1: Code-Review+1\n\n(1 comment)\n\nThe repo is really tiny, Just 1 nitpick',719,1,719,'fab9d9a7_ea3dc7bc',NULL),(15,'2015-05-27 16:18:27','Change has been successfully merged into the git repository.',720,2,720,'fab9d9a7_4a3733b1',NULL),(15,'2015-05-27 13:13:09','Uploaded patch set 1.',720,1,720,'fab9d9a7_6a879762',NULL),(15,'2015-05-27 16:18:06','Uploaded patch set 2.',720,2,720,'fab9d9a7_8abd2b05',NULL),(15,'2015-05-27 16:18:20','Patch Set 2: Code-Review+2',720,2,720,'fab9d9a7_aaba6f08',NULL),(8,'2015-05-27 14:09:40','Patch Set 1: Code-Review+1',720,1,720,'fab9d9a7_ca956389',NULL),(37,'2015-05-27 16:13:29','Patch Set 1: Code-Review+2',720,1,720,'fab9d9a7_eac0677e',NULL),(34,'2015-05-28 12:50:39','Patch Set 2: Code-Review+1',721,2,721,'dabed58f_09570904',NULL),(22,'2015-05-28 13:03:59','Patch Set 2:\n\n> Looks OK, but I wonder if maybe its worth adding the mtd-utilities\n > stratum to all of the build systems rather than just the openBMC\n > one?\n\nThanks for the review!\n\nI hold no opinion on this, it\'s a call for upstream. I can add it if wanted. My logic was that jffs2 is specifically needed for this system. I didn\'t want to add it where it isn\'t needed. I\'ll ask in #baserock for opinions',721,2,721,'dabed58f_295c4d25',NULL),(15,'2015-05-28 10:26:09','Patch Set 1:\n\n> (1 comment)\n > \n > Will change this to +1 if the ref thing is cleared up. :)\n\n9f107132a6a073cce37434ca9cda6917dd8d866b is what I\'d use as well',721,1,721,'dabed58f_492661bc',NULL),(16,'2015-05-28 12:31:47','Patch Set 2:\n\nLooks OK, but I wonder if maybe its worth adding the mtd-utilities stratum to all of the build systems rather than just the openBMC one?',721,2,721,'dabed58f_69524515',NULL),(34,'2015-05-28 10:08:56','Patch Set 1:\n\n(1 comment)\n\nWill change this to +1 if the ref thing is cleared up. :)',721,1,721,'dabed58f_891c596c',NULL),(22,'2015-05-28 12:19:08','Uploaded patch set 2.',721,2,721,'dabed58f_8933f9f5',NULL),(16,'2015-05-28 13:40:07','Patch Set 2: Code-Review+1\n\n> > Looks OK, but I wonder if maybe its worth adding the\n > mtd-utilities\n > > stratum to all of the build systems rather than just the openBMC\n > > one?\n > \n > Thanks for the review!\n > \n > I hold no opinion on this, it\'s a call for upstream. I can add it\n > if wanted. My logic was that jffs2 is specifically needed for this\n > system. I didn\'t want to add it where it isn\'t needed. I\'ll ask in\n > #baserock for opinions\n\nWe don\'t have policy on this, and this system is already pretty different to the rest of the build systems. I\'m fine with this following discussion on #baserock[0].\n\n[0]: https://irclogs.baserock.org/latest.log.html#t2015-05-28T13:04:51',721,2,721,'dabed58f_894a1954',NULL),(8,'2015-05-28 14:01:32','Change has been successfully rebased as c8852d7530c0b815fa49ca6d0dbe17b28a88fecc',721,2,721,'dabed58f_8961b9d5',NULL),(8,'2015-05-28 14:01:20','Patch Set 2: Code-Review+2',721,2,721,'dabed58f_c967b1e9',NULL),(8,'2015-05-28 14:01:32','Patch Set 3: Patch Set 2 was rebased',721,2,721,'dabed58f_e964f5e6',NULL),(22,'2015-05-27 15:26:53','Uploaded patch set 1.',721,1,721,'fab9d9a7_6ad55742',NULL),(15,'2015-05-27 16:12:49','Patch Set 1: Code-Review+1',721,1,721,'fab9d9a7_cac32389',NULL),(37,'2015-06-04 09:04:48','Patch Set 1: Code-Review+2',722,1,722,'1aa4ed85_230eaa35',NULL),(37,'2015-06-04 09:04:52','Patch Set 2: Patch Set 1 was rebased',722,1,722,'1aa4ed85_c3123658',NULL),(37,'2015-06-04 09:04:53','Change has been successfully rebased as 539a966200c0a5f0f2066f96b411bdc27a7be22e',722,1,722,'1aa4ed85_e30f322d',NULL),(37,'2015-05-28 09:31:41','Uploaded patch set 1.',722,1,722,'dabed58f_69048515',NULL),(8,'2015-05-28 14:00:33','Patch Set 1: Code-Review+1',722,1,722,'dabed58f_6979e592',NULL),(7,'2015-05-28 16:08:48','Patch Set 1: Code-Review+1',722,1,722,'dabed58f_6987a562',NULL),(37,'2015-06-04 09:06:47','Change has been successfully merged into the git repository.',723,2,723,'1aa4ed85_03204e9a',NULL),(37,'2015-06-04 09:06:40','Patch Set 2: Patch Set 1 was rebased',723,1,723,'1aa4ed85_432646bc',NULL),(37,'2015-06-04 09:06:45','Patch Set 2: Code-Review+2',723,2,723,'1aa4ed85_632b4283',NULL),(37,'2015-06-04 09:06:29','Patch Set 1: Code-Review+2',723,1,723,'1aa4ed85_831c3e6c',NULL),(NULL,'2015-06-04 09:06:34','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I0fe801dd, however the current patch set is 2.\n\nPlease rebase the change and upload a replacement commit.',723,1,723,'1aa4ed85_a3193a7b',NULL),(37,'2015-05-28 09:31:41','Uploaded patch set 1.',723,1,723,'dabed58f_0909492c',NULL),(8,'2015-05-28 14:00:36','Patch Set 1: Code-Review+1',723,1,723,'dabed58f_096e29ca',NULL),(7,'2015-05-28 16:08:57','Patch Set 1: Code-Review+1',723,1,723,'dabed58f_097ce971',NULL),(37,'2015-06-04 09:46:39','Patch Set 2: Patch Set 1 was rebased',724,1,724,'1aa4ed85_23254aab',NULL),(37,'2015-06-04 09:46:45','Patch Set 2: Code-Review+2',724,2,724,'1aa4ed85_c339d6d9',NULL),(37,'2015-06-04 09:46:48','Change has been successfully merged into the git repository.',724,2,724,'1aa4ed85_e33652e7',NULL),(37,'2015-05-28 09:31:41','Uploaded patch set 1.',724,1,724,'dabed58f_290e8d35',NULL),(8,'2015-05-28 14:00:42','Patch Set 1: Code-Review+1',724,1,724,'dabed58f_2973edb2',NULL),(7,'2015-05-28 16:09:09','Patch Set 1: Code-Review+1',724,1,724,'dabed58f_2981ad4a',NULL),(6,'2015-05-29 13:31:51','Patch Set 2: Code-Review+2',725,2,725,'bab3e1c7_8861b7d5',NULL),(6,'2015-05-29 13:31:53','Change has been successfully merged into the git repository.',725,2,725,'bab3e1c7_a85efb10',NULL),(6,'2015-05-29 13:31:38','Patch Set 2: Code-Review+1\n\nlorry-controller should be able to deal with an upstream repo that only sometimes works.',725,2,725,'bab3e1c7_e864f3e6',NULL),(15,'2015-05-28 11:46:00','Patch Set 1: Code-Review+1',725,1,725,'dabed58f_0920699a',NULL),(19,'2015-05-28 11:41:17','Uploaded patch set 1.',725,1,725,'dabed58f_692b2583',NULL),(19,'2015-05-28 12:19:37','Uploaded patch set 2.',725,2,725,'dabed58f_a9303de9',NULL),(8,'2015-05-28 13:49:27','Patch Set 2: Code-Review+1',725,2,725,'dabed58f_a947dd4a',NULL),(7,'2015-05-28 11:49:35','Patch Set 1:\n\n(1 comment)\n\nI believe the url is wrong, can you check my comment please?',725,1,725,'dabed58f_c939f1d9',NULL),(15,'2015-05-28 14:05:10','Change has been successfully rebased as 6b14ff59f2acf6d6403f014f50e4ad475a36b381',726,1,726,'dabed58f_09a5c903',NULL),(15,'2015-05-28 12:26:03','Uploaded patch set 1.',726,1,726,'dabed58f_494d0172',NULL),(15,'2015-05-28 14:05:06','Patch Set 1: Code-Review+2',726,1,726,'dabed58f_499bc1c9',NULL),(15,'2015-05-28 14:05:09','Patch Set 2: Patch Set 1 was rebased',726,1,726,'dabed58f_69a005f5',NULL),(8,'2015-05-28 14:01:44','Patch Set 1: Code-Review+1',726,1,726,'dabed58f_a95efd10',NULL),(34,'2015-05-28 13:35:29','Patch Set 1: Code-Review+1\n\nThis is necessary for the build and I have tested it. :)',726,1,726,'dabed58f_e93dd5bc',NULL),(8,'2015-06-01 09:06:44','Patch Set 2: Patch Set 1 was rebased',727,1,727,'7aade967_861c4a6c',NULL),(8,'2015-06-01 09:06:45','Change has been successfully rebased as 64406608de0dfe2975e5fd1696a9dcc2535e02e2',727,1,727,'7aade967_a619467b',NULL),(8,'2015-06-01 09:06:41','Patch Set 1: Code-Review+2',727,1,727,'7aade967_e60f3e2d',NULL),(15,'2015-05-28 14:07:01','Patch Set 1: Code-Review+1',727,1,727,'dabed58f_29aa0dd5',NULL),(8,'2015-05-28 13:51:14','Patch Set 1: Code-Review+1',727,1,727,'dabed58f_4974219c',NULL),(19,'2015-05-28 13:35:26','Uploaded patch set 1.',727,1,727,'dabed58f_c9401138',NULL),(24,'2015-06-03 09:18:00','Patch Set 1:\n\n> However, if you disagree, you can always `rm -rf \"$DESTDIR/var\"` in\n > your post-install-commands.\n\nOK, I shall abandon this patch and do that instead',728,1,728,'3aa7f18b_44264ebc',NULL),(24,'2015-06-03 09:19:11','Abandoned\n\nI will remove /var in the post install commands instead of this patch',728,1,728,'3aa7f18b_642b4a83',NULL),(32,'2015-06-02 14:23:12','Patch Set 1:\n\nIf the usage for this contentious change will never be merged then I\'d prefer this change never be merged, regardless of the fact that I dislike this change.',728,1,728,'5aaae553_255c6e25',NULL),(24,'2015-06-02 13:18:40','Patch Set 1:\n\n> If you\'re going to convince me that parameterising something as\n > *CORE* as fhs-dirs is a good idea, you\'re going to need to explain\n > to me how you intend to actually do it. This is only one half of\n > the coin -- where is the definitions change which it corresponds\n > to?\n\nThe definitions for OpenWRT are in a branch called \'baserock/rdale/openwrt\'. That could never be merged into the master unless I was to duplicate the build-essential stratum and create an OpenWRT specific build-essential-wrt stratum, as we don\'t have any easy way to parameterise strata at present.\n\nI think I should just leave the branch of fhs-dirs used by the master branch of definitions as it is, and create an OpenWRT specific branch called \'baserock/rdale/openwrt\' perhaps.',728,1,728,'5aaae553_8533e2f5',NULL),(24,'2015-06-02 11:17:18','Patch Set 1:\n\n> I really don\'t like this idea. Can\'t the OpenWRT systems simply\n > replace /var during deployment? Surely you want the skeleton for\n > populating the tmpfs /var anyway?\n\nI\'m not very keen on fixing up the file system on deployment. I think it would be a maintenance headache, as it would be very easy for new files and directories to be added to fhs-dirs, that weren\'t wanted by OpenWRT and forget to do anything about them. Also the metadata in /baserock would then be incorrect.',728,1,728,'5aaae553_a5193e7b',NULL),(32,'2015-06-02 12:56:24','Patch Set 1:\n\nIf you\'re going to convince me that parameterising something as *CORE* as fhs-dirs is a good idea, you\'re going to need to explain to me how you intend to actually do it. This is only one half of the coin -- where is the definitions change which it corresponds to?',728,1,728,'5aaae553_c539dad9',NULL),(37,'2015-06-02 15:25:01','Patch Set 1: Code-Review-2\n\nI don\'t believe this is the appropriate place to handle this.\n\nI\'ve been looking at ways of handling making / or /usr read-only. Systemd and ostree handle it by having /usr/share/factory/{var,etc} which gets copied into /var and /etc on boot if they are empty.\nYou could concievably have an ephemeral system by having /var and /etc be a tmpfs in that case.\n\nHowever to put everything in the skeleton directory, you would need to either patch *every* component that provided default configuration snippets and directory skeletons, or move them at deployment or system integration time.\n\nTo this end I think it would be more appropriate to either move or remove files not appropriate to how your rootfs is provisioned at deployment or system integration time, rather than build time.\n\nHowever, if you disagree, you can always `rm -rf \"$DESTDIR/var\"` in your post-install-commands.',728,1,728,'5aaae553_e56416e7',NULL),(32,'2015-06-01 15:25:56','Patch Set 1: Code-Review-1\n\nI really don\'t like this idea. Can\'t the OpenWRT systems simply replace /var during deployment? Surely you want the skeleton for populating the tmpfs /var anyway?',728,1,728,'7aade967_060ffae2',NULL),(6,'2015-05-29 09:47:34','Patch Set 1: Code-Review+1\n\nI wonder if this is really the best solution, but it seems OK to me. I can\'t really recommend a better approach off the top of my head.\n\nNot tested.',728,1,728,'bab3e1c7_28252bab',NULL),(24,'2015-05-29 10:25:46','Patch Set 1:\n\n> I wonder if this is really the best solution, but it seems OK to\n > me. I can\'t really recommend a better approach off the top of my\n > head.\n > \n\nI couldn\'t think of a tidier solution. The other option would be to either create a new branch where the create-fhs-dirs script has the \'var\' directory entries removed. Or put an extra script in the existing branch with the \'var\' entries removed. \n\nI felt both of those options were less easily maintained than the solution in the patch.\n\n > Not tested.\n\nI have tested it with and without a \'^var\' option and confirmed that the directories are created as expected.',728,1,728,'bab3e1c7_c839efd9',NULL),(24,'2015-05-28 14:58:04','Uploaded patch set 1.',728,1,728,'dabed58f_c9aed1e7',NULL),(15,'2015-06-01 10:53:14','Change has been successfully rebased as 33c81a9cf0ddcc83cd173943d46290152d45416c',729,4,729,'7aade967_066e1aca',NULL),(29,'2015-06-01 09:17:36','Patch Set 4: Code-Review+1\n\nThis change now depends on https://gerrit.baserock.org/#/c/736/',729,4,729,'7aade967_462652bc',NULL),(15,'2015-06-01 10:53:10','Patch Set 4: Code-Review+2',729,4,729,'7aade967_4674129c',NULL),(15,'2015-06-01 10:53:14','Patch Set 5: Patch Set 4 was rebased',729,4,729,'7aade967_66790e93',NULL),(29,'2015-05-29 09:17:33','Patch Set 2:\n\n(2 comments)\n\nnitpicks (could probably be ignored, except for the copyright range)',729,2,729,'bab3e1c7_0820679a',NULL),(29,'2015-05-29 15:45:28','Patch Set 4:\n\n(1 comment)',729,4,729,'bab3e1c7_28468b24',NULL),(29,'2015-05-29 15:26:51','Patch Set 3:\n\n(1 comment)',729,3,729,'bab3e1c7_28cf6bb2',NULL),(29,'2015-05-29 15:38:57','Patch Set 4: Code-Review-1',729,4,729,'bab3e1c7_48373fb1',NULL),(29,'2015-05-29 16:21:02','Patch Set 4:\n\n(1 comment)',729,4,729,'bab3e1c7_485e5feb',NULL),(29,'2015-05-29 15:22:15','Patch Set 3: Code-Review-1\n\n(1 comment)',729,3,729,'bab3e1c7_48d09f53',NULL),(16,'2015-05-29 08:40:26','Patch Set 2: Code-Review+1',729,2,729,'bab3e1c7_48ff3f02',NULL),(22,'2015-05-29 09:17:10','Patch Set 2:\n\n> (4 comments)\n > \n > A couple of minor issues\n\nThanks for the review! I\'ll fix these and upload a new version soon',729,2,729,'bab3e1c7_682b2383',NULL),(22,'2015-05-29 15:25:59','Uploaded patch set 4.',729,4,729,'bab3e1c7_68d56342',NULL),(29,'2015-05-29 09:10:06','Patch Set 2: Code-Review-1\n\n(4 comments)\n\nA couple of minor issues',729,2,729,'bab3e1c7_881c576c',NULL),(29,'2015-05-29 16:19:08','Patch Set 4:\n\n(1 comment)',729,4,729,'bab3e1c7_885457cb',NULL),(22,'2015-05-29 15:16:50','Uploaded patch set 3.',729,3,729,'bab3e1c7_88e69743',NULL),(29,'2015-05-29 15:38:31','Patch Set 4:\n\n(1 comment)',729,4,729,'bab3e1c7_a8ba7b08',NULL),(22,'2015-05-29 15:45:29','Patch Set 4:\n\n(1 comment)\n\n> (1 comment)',729,4,729,'bab3e1c7_c84a4f27',NULL),(22,'2015-05-29 15:35:02','Patch Set 3:\n\n(1 comment)\n\n> (1 comment)',729,3,729,'bab3e1c7_e8c0737e',NULL),(22,'2015-05-28 15:20:38','Patch Set 2: Commit message was updated',729,2,729,'dabed58f_89b8d92b',NULL),(22,'2015-05-28 15:20:22','Uploaded patch set 1.',729,1,729,'dabed58f_e9ab95d4',NULL),(29,'2015-06-01 16:35:49','Change has been successfully merged into the git repository.',730,2,730,'7aade967_462c124b',NULL),(6,'2015-06-01 13:47:07','Patch Set 2: Code-Review+2\n\nLooks fine, +2 again in case nobody else reviews',730,2,730,'7aade967_66d58e42',NULL),(29,'2015-05-29 14:14:22','Uploaded patch set 2.',730,2,730,'bab3e1c7_08a5c703',NULL),(29,'2015-05-29 12:16:39','Uploaded patch set 1.',730,1,730,'bab3e1c7_484dff71',NULL),(29,'2015-05-29 14:00:22','Patch Set 1: Code-Review-1\n\n(1 comment)',730,1,730,'bab3e1c7_68a003f5',NULL),(6,'2015-05-29 13:25:49','Patch Set 1: Code-Review+2\n\nLooks fine at a glance, I don\'t have time to give this any testing though.\n\n+2 in case nobody else feels like reviewing import tool stuff.',730,1,730,'bab3e1c7_a847db4a',NULL),(29,'2015-06-01 16:35:57','Change has been successfully merged into the git repository.',731,2,731,'7aade967_66310ea2',NULL),(29,'2015-05-29 14:14:22','Uploaded patch set 2.',731,2,731,'bab3e1c7_28aa0bd5',NULL),(6,'2015-05-29 13:27:05','Patch Set 1: Code-Review+2\n\nLooks fine at a glance, I don\'t have time to give this any testing though.\n\n+2 in case nobody else feels like reviewing import tool stuff.',731,1,731,'bab3e1c7_48741f9c',NULL),(29,'2015-05-29 12:16:39','Uploaded patch set 1.',731,1,731,'bab3e1c7_68524315',NULL),(29,'2015-05-29 14:15:38','Patch Set 2: Code-Review+2\n\nunchanged from v1',731,2,731,'bab3e1c7_a8b59b32',NULL),(29,'2015-06-01 16:36:02','Change has been successfully merged into the git repository.',732,2,732,'7aade967_06261a69',NULL),(29,'2015-05-29 12:16:39','Uploaded patch set 1.',732,1,732,'bab3e1c7_08570704',NULL),(6,'2015-05-29 13:28:05','Patch Set 1: Code-Review+2',732,1,732,'bab3e1c7_2873ebb2',NULL),(29,'2015-05-29 14:15:44','Patch Set 2: Code-Review+2\n\nunchanged from v1',732,2,732,'bab3e1c7_4882df53',NULL),(6,'2015-05-29 13:27:33','Patch Set 1:\n\nLooks fine at a glance, I don\'t have time to give this any testing though.\n\n+2 in case nobody else feels like reviewing import tool stuff.',732,1,732,'bab3e1c7_6879e392',NULL),(29,'2015-05-29 14:14:22','Uploaded patch set 2.',732,2,732,'bab3e1c7_c8aecfe7',NULL),(29,'2015-06-01 16:36:05','Change has been successfully merged into the git repository.',733,2,733,'7aade967_262b1632',NULL),(6,'2015-05-29 13:27:51','Patch Set 1: Code-Review+2\n\nLooks fine',733,1,733,'bab3e1c7_086e27ca',NULL),(29,'2015-05-29 12:16:39','Uploaded patch set 1.',733,1,733,'bab3e1c7_285c4b25',NULL),(29,'2015-05-29 14:15:50','Patch Set 2: Code-Review+2\n\nunchanged from v1',733,2,733,'bab3e1c7_6887a362',NULL),(16,'2015-05-29 12:55:53','Patch Set 1: Code-Review+1\n\nLooks sensible to me.',733,1,733,'bab3e1c7_e83dd3bc',NULL),(29,'2015-05-29 14:14:22','Uploaded patch set 2.',733,2,733,'bab3e1c7_e8ab93d4',NULL),(37,'2015-05-29 14:50:11','Patch Set 2: Patch Set 1 was rebased',734,1,734,'bab3e1c7_08f3870b',NULL),(29,'2015-05-29 14:19:01','Patch Set 1: Code-Review+1\n\nIt would be neat if this change could be followed up with a change to move specification of configuration-extensions into the cluster morph,\nthough I appreciate that\'s a slightly larger change than this one.',734,1,734,'bab3e1c7_2881ab4a',NULL),(37,'2015-05-29 14:50:11','Change has been successfully rebased as 7929082eac2d9dc90b276afae6c201f47177c48b',734,1,734,'bab3e1c7_28f8cbe4',NULL),(37,'2015-05-29 14:49:45','Patch Set 1: Code-Review+2',734,1,734,'bab3e1c7_48e97f19',NULL),(37,'2015-05-29 14:50:07','Patch Set 1:\n\nHappy rebuilds everyone!',734,1,734,'bab3e1c7_68eec324',NULL),(7,'2015-05-29 14:15:17','Uploaded patch set 1.',734,1,734,'bab3e1c7_88b8d72b',NULL),(7,'2015-05-29 14:23:09','Patch Set 1:\n\n> It would be neat if this change could be followed up with a change\n > to move specification of configuration-extensions into the cluster\n > morph\n\nI\'d love that too, and I think I\'ll give it a try. I\'m not sure how easy is going to be switching to that, though.',734,1,734,'bab3e1c7_a88cbb80',NULL),(7,'2015-06-01 14:45:31','Patch Set 4: Patch Set 3 was rebased',735,3,735,'7aade967_06413a0b',NULL),(7,'2015-06-01 14:45:31','Change has been successfully rebased as 148b3de0a9206fb5be1302e660a81669897c8c10',735,3,735,'7aade967_2646b624',NULL),(7,'2015-06-01 14:45:28','Patch Set 3: Code-Review+2',735,3,735,'7aade967_663cae94',NULL),(26,'2015-06-01 11:03:56','Uploaded patch set 3.',735,3,735,'7aade967_8661aad5',NULL),(26,'2015-06-01 10:18:04','Uploaded patch set 2.',735,2,735,'7aade967_a63066e9',NULL),(8,'2015-06-01 11:05:46','Patch Set 3: Code-Review+1',735,3,735,'7aade967_a65e2611',NULL),(8,'2015-06-01 09:05:51','Patch Set 1:\n\n(1 comment)',735,1,735,'7aade967_c6124258',NULL),(8,'2015-06-01 10:27:12','Patch Set 2: Code-Review-1\n\n(1 comment)',735,2,735,'7aade967_c6400238',NULL),(26,'2015-05-29 14:18:30','Uploaded patch set 1.',735,1,735,'bab3e1c7_087ce771',NULL),(22,'2015-06-01 08:13:10','Patch Set 1: Code-Review+1\n\nLooks good! One question, why not pass back the None type? \n\nOn the face of it, it seems more sensible to pass back \'\' as the string since this is a santization function, so +1 regardless',736,1,736,'7aade967_6604ae15',NULL),(15,'2015-06-01 10:52:46','Patch Set 1: Code-Review+2',736,1,736,'7aade967_864a0a54',NULL),(15,'2015-06-01 10:52:48','Change has been successfully merged into the git repository.',736,1,736,'7aade967_a647064b',NULL),(29,'2015-06-01 10:01:00','Patch Set 1:\n\n> Looks good! One question, why not pass back the None type?\n > \n\nIf I haven\'t misinterpreted \"pass back the None type\", then,\nbecause we can\'t put None into the environment, only strings.\n\n > On the face of it, it seems more sensible to pass back \'\' as the\n > string since this is a santization function, so +1 regardless',736,1,736,'7aade967_c639e2d9',NULL),(29,'2015-05-29 16:47:48','Uploaded patch set 1.',736,1,736,'bab3e1c7_686323b2',NULL),(8,'2015-06-01 10:26:13','Patch Set 1: Code-Review+1\n\nI haven\'t tested but the systems look fine',737,1,737,'7aade967_0657fa03',NULL),(29,'2015-06-01 11:41:28','Patch Set 1: Code-Review+1',737,1,737,'7aade967_a6b5c632',NULL),(26,'2015-05-31 09:05:56','Uploaded patch set 1.',737,1,737,'9ab8dda7_47ff2e02',NULL),(6,'2015-07-03 10:38:56','Patch Set 2: Code-Review+2\n\nThis triggered a discussion about what level of \'support\' we provide for the Baserock reference systems. Since I don\'t have access to any such board I can\'t make any guarantee about whether it works. But I think we agreed that we don\'t provide any support for anything right now. So fine to merge this in my opinion.',737,2,737,'fafc7978_12e26cd5',NULL),(6,'2015-07-03 10:41:57','Patch Set 2: Code-Review+1',737,2,737,'fafc7978_52ecf4c7',NULL),(6,'2015-07-03 10:39:43','Patch Set 2:\n\nI just noticed that these systems will fail to build unless #738 is merged too. It really didn\'t make sense to submit those as separate changes.',737,2,737,'fafc7978_72e778e5',NULL),(26,'2015-07-02 16:57:25','Uploaded patch set 2.',737,2,737,'fafc7978_b2e60015',NULL),(26,'2015-07-05 10:46:18','Abandoned\n\nSquashed with change 738',737,2,737,'fafc7978_d24aa4ab',NULL),(37,'2015-06-12 12:29:17','Patch Set 1: Code-Review+2\n\n(1 comment)\n\nI\'d prefer if we didn\'t apply patches at build time, but I accept the justification, and the files would need to be checked in anyway, so there\'s no loss of reproducibility as far as I\'m concerned.',738,1,738,'3a4c51b2_7c357945',NULL),(8,'2015-06-01 17:01:14','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_06ddba42',NULL),(8,'2015-06-01 12:45:51','Patch Set 1: -Code-Review\n\n(1 comment)',738,1,738,'7aade967_2681d64a',NULL),(8,'2015-06-01 13:49:57','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_26cf96b2',NULL),(26,'2015-06-01 13:41:24','Patch Set 1:\n\n(2 comments)',738,1,738,'7aade967_26f8f6e4',NULL),(29,'2015-06-01 16:45:13','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_46d3b238',NULL),(8,'2015-06-01 10:24:41','Patch Set 1: Code-Review-1\n\n(3 comments)\n\nPlease do not apply patches on chunk morphologies.\nThe rest of the patch looks fine.',738,1,738,'7aade967_66526e15',NULL),(29,'2015-06-01 11:57:47','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_6687ce62',NULL),(26,'2015-06-01 11:25:23','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_86b8ca2b',NULL),(8,'2015-06-01 12:55:15','Patch Set 1:\n\n(1 comment)\n\nIm changing from -1 to 0 to not veto this but I would like to know other opinions about it.',738,1,738,'7aade967_a68ce680',NULL),(26,'2015-06-01 11:18:42','Patch Set 1:\n\n(3 comments)',738,1,738,'7aade967_c6aec2e7',NULL),(26,'2015-06-01 15:20:16','Patch Set 1:\n\n(2 comments)',738,1,738,'7aade967_e66e5e96',NULL),(8,'2015-06-01 12:50:37','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_e692de9e',NULL),(29,'2015-06-01 13:45:09','Patch Set 1:\n\n(1 comment)',738,1,738,'7aade967_e6d97e84',NULL),(26,'2015-05-31 09:05:56','Uploaded patch set 1.',738,1,738,'9ab8dda7_6704b215',NULL),(26,'2015-09-24 16:33:36','Patch Set 8:\n\nDuplicated strata have been removed, but i can\'t upgrade the kernel without hardware to test on.',738,8,738,'da01753e_31ffb003',NULL),(15,'2015-10-06 23:50:41','Change has been successfully rebased as 9dd681bcc9c41e2ede4bd9320b8c0f3cf1f3a37a',738,8,738,'da01753e_3412feb4',NULL),(15,'2015-10-06 23:50:40','Patch Set 9: Patch Set 8 was rebased',738,8,738,'da01753e_d44572b4',NULL),(15,'2015-10-06 23:50:33','Patch Set 8: Code-Review+2',738,8,738,'da01753e_f44876ce',NULL),(26,'2015-07-22 13:21:25','Uploaded patch set 4.',738,4,738,'fafc7978_18872d63',NULL),(26,'2015-09-24 14:56:49','Uploaded patch set 8.',738,8,738,'fafc7978_27c128e5',NULL),(26,'2015-07-05 10:50:12','Patch Set 3:\n\nIncorporating changes from abandoned change #737. Some comments pertaining to this commit are still present there (https://gerrit.baserock.org/#/c/737).',738,3,738,'fafc7978_32c7b014',NULL),(26,'2015-08-07 18:06:36','Uploaded patch set 6.',738,6,738,'fafc7978_7b26336a',NULL),(15,'2015-08-09 01:33:32','Patch Set 6: Code-Review-1\n\n(2 comments)',738,6,738,'fafc7978_7bb473f2',NULL),(26,'2015-07-02 16:57:25','Uploaded patch set 2.',738,2,738,'fafc7978_92e3fc04',NULL),(26,'2015-09-24 10:29:41','Uploaded patch set 7.',738,7,738,'fafc7978_c7013c3b',NULL),(26,'2015-08-10 09:04:37','Patch Set 6:\n\n(2 comments)',738,6,738,'fafc7978_dbc47f61',NULL),(26,'2015-07-05 10:45:15','Uploaded patch set 3.',738,3,738,'fafc7978_f24d28c6',NULL),(26,'2015-08-07 18:01:59','Uploaded patch set 5.',738,5,738,'fafc7978_fb0223b3',NULL),(37,'2015-06-12 12:12:41','Patch Set 1: Code-Review-1\n\nThe build tool would always need to maintain its own notion of what input is valid, so I think a schema would be most useful inside the build tool.\n\nI wouldn\'t object to being able to provide extra validation in the definitions repository though, as you may want to impose extra constraints for style, or allow extra fields for future expansion.\n\nHowever before I\'d accept this patch, I\'d like to see an entry in http://wiki.baserock.org/definitions/planned for the change.',739,1,739,'3a4c51b2_7ce739e5',NULL),(29,'2015-06-01 09:39:25','Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThank you for the schema, is this purely to help us validate morph,\nor is there some other purpose?',739,1,739,'7aade967_06205a9a',NULL),(29,'2015-06-01 11:11:53','Patch Set 1:\n\n> > > (1 comment)\n > > >\n > > > Thank you for the schema, is this purely to help us validate\n > > morph,\n > > > or is there some other purpose?\n > >\n > > Nevermind, just spotted the RFC on the list.\n > \n > > (1 comment)\n > >\n > > Thank you for the schema, is this purely to help us validate\n > morph,\n > > or is there some other purpose?\n > \n > Thanks for the review. Is your -1 for the whole approach/concept,\n > or just this version of the patch?\n\n-1 here just means \"this would need more work before it could be merged\"\n\nI\'m not sure whether this should be in definitions or in morph,\nbut defining a schema for definitions seems useful to me.',739,1,739,'7aade967_06a5ba03',NULL),(29,'2015-06-01 09:54:31','Patch Set 1:\n\n> (1 comment)\n > \n > Thank you for the schema, is this purely to help us validate morph,\n > or is there some other purpose?\n\nNevermind, just spotted the RFC on the list.',739,1,739,'7aade967_262556ab',NULL),(18,'2015-06-01 10:31:01','Patch Set 1:\n\n> > (1 comment)\n > >\n > > Thank you for the schema, is this purely to help us validate\n > morph,\n > > or is there some other purpose?\n > \n > Nevermind, just spotted the RFC on the list.\n\n > (1 comment)\n > \n > Thank you for the schema, is this purely to help us validate morph,\n > or is there some other purpose?\n\nThanks for the review. Is your -1 for the whole approach/concept, or just this version of the patch?',739,1,739,'7aade967_e63dfebc',NULL),(18,'2015-05-31 09:44:53','Uploaded patch set 1.',739,1,739,'9ab8dda7_0709362c',NULL),(29,'2015-07-10 13:07:22','Patch Set 1:\n\nGiven the schema stuff Sam is doing, can we safely abandon this change?',739,1,739,'fafc7978_55aa1ed5',NULL),(18,'2015-07-11 17:12:33','Abandoned\n\nsuperseded by other work',739,1,739,'fafc7978_95c0067e',NULL),(18,'2015-07-11 17:12:17','Patch Set 1: Code-Review-2\n\n> Given the schema stuff Sam is doing, can we safely abandon this\n > change?\n\nYes, I think so.',739,1,739,'fafc7978_b5c38a89',NULL),(8,'2015-06-01 09:01:59','Patch Set 1: Code-Review+1',740,1,740,'7aade967_06093a2c',NULL),(15,'2015-06-01 08:05:18','Uploaded patch set 1.',740,1,740,'7aade967_46ff3202',NULL),(7,'2015-06-01 14:32:35','Patch Set 2: Patch Set 1 was rebased',740,1,740,'7aade967_86bd2a05',NULL),(7,'2015-06-01 14:32:36','Change has been successfully rebased as 4f43fdd08770c113f7443fecbda43d4316091d4b',740,1,740,'7aade967_a6baa608',NULL),(7,'2015-06-01 14:32:28','Patch Set 1: Code-Review+1\n\nThis looks Ok and makes sense to me',740,1,740,'7aade967_c6c32289',NULL),(7,'2015-06-01 14:32:34','Patch Set 1: Code-Review+2',740,1,740,'7aade967_e6c09e7e',NULL),(24,'2015-06-01 13:47:05','Patch Set 1:\n\nThe lorries look fine to me. \n\nMaybe there should be an \'jerasure\' namespace for \'jerasure\' things? But I\'ve no idea what the code in these two repos does, and maybe that doesn\'t make sense.',741,1,741,'7aade967_46d09253',NULL),(7,'2015-06-01 13:36:21','Uploaded patch set 1.',741,1,741,'7aade967_66eeee24',NULL),(6,'2015-06-01 13:46:10','Patch Set 1: Code-Review+2\n\nLooks fine',741,1,741,'7aade967_86e68a43',NULL),(8,'2015-06-01 13:46:51','Change has been successfully merged into the git repository.',741,1,741,'7aade967_a6e38632',NULL),(37,'2015-06-12 12:16:54','Patch Set 1: Code-Review+2\n\nSure, it won\'t break anything.',742,1,742,'3a4c51b2_5c035d73',NULL),(37,'2015-06-12 12:16:56','Change has been successfully merged into the git repository.',742,1,742,'3a4c51b2_bcf7018c',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',742,1,742,'7aade967_c64a4227',NULL),(26,'2015-06-02 17:16:31','Uploaded patch set 2.',743,2,743,'5aaae553_e592d69e',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',743,1,743,'7aade967_e6473e1c',NULL),(6,'2015-09-28 10:55:34','Change has been successfully merged into the git repository.',743,3,743,'da01753e_913bfc37',NULL),(6,'2015-09-28 10:55:32','Patch Set 3: Code-Review+2',743,3,743,'da01753e_b13e0028',NULL),(28,'2015-09-28 10:40:24','Patch Set 3: Code-Review+1\n\nI didn\'t test this but those patches should cause no harm and they have been lingering too much time on Gerrit.',743,3,743,'da01753e_d1d744ec',NULL),(26,'2015-09-24 08:28:42','Uploaded patch set 3.',743,3,743,'fafc7978_875a9481',NULL),(26,'2015-06-02 17:16:31','Uploaded patch set 2.',744,2,744,'5aaae553_858f6275',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',744,1,744,'7aade967_86544acb',NULL),(28,'2015-09-28 10:40:46','Patch Set 3: Code-Review+1\n\nI didn\'t test this but those patches should cause no harm and they have been lingering too much time on Gerrit.',744,3,744,'da01753e_3104d07d',NULL),(6,'2015-09-28 10:55:39','Change has been successfully merged into the git repository.',744,3,744,'da01753e_d14584b4',NULL),(6,'2015-09-28 10:55:37','Patch Set 3: Code-Review+2',744,3,744,'da01753e_f14888ce',NULL),(26,'2015-09-24 08:28:42','Uploaded patch set 3.',744,3,744,'fafc7978_675fb073',NULL),(26,'2015-06-02 09:12:08','Patch Set 1:\n\nThe tool used to generate the DTS is GPLv2. It seems to be general consensus that code generated by GPL software doesn\'t fall under the same license unless it itself contains GPL code. I\'m not sure what to do in this case.',745,1,745,'5aaae553_250eae35',NULL),(26,'2015-06-02 11:22:17','Patch Set 1:\n\nI guess it\'s arguable that the generated files in this repo are original work, and could be licensed under GPL. In that case i could put a blanket note in the readme, or a license file saying all files are GPL licensed',745,1,745,'5aaae553_45264abc',NULL),(26,'2015-06-02 17:16:31','Uploaded patch set 2.',745,2,745,'5aaae553_a58cde80',NULL),(32,'2015-06-01 15:21:37','Patch Set 1:\n\nThere\'s no licence on this DTS file.',745,1,745,'7aade967_866bea84',NULL),(26,'2015-06-01 17:55:05','Patch Set 1:\n\nThis is automatically generated, does that mean it would inherit the licence of the tool that made it? It\'s not immediately obvious what that is though, there\'s no license file, the tool is java and i can\'t find source for it currently',745,1,745,'7aade967_86f0caca',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',745,1,745,'7aade967_a65146da',NULL),(6,'2015-09-28 10:55:44','Change has been successfully merged into the git repository.',745,3,745,'da01753e_11170ca5',NULL),(6,'2015-09-28 10:55:42','Patch Set 3: Code-Review+2',745,3,745,'da01753e_311210b5',NULL),(28,'2015-09-28 10:41:10','Patch Set 3: Code-Review+1\n\nI didn\'t test this but those patches should cause no harm and they have been lingering too much time on Gerrit.',745,3,745,'da01753e_71fe586d',NULL),(26,'2015-09-24 08:28:42','Uploaded patch set 3.',745,3,745,'fafc7978_c753fc6a',NULL),(26,'2015-06-02 17:16:31','Uploaded patch set 2.',746,2,746,'5aaae553_45e96a19',NULL),(32,'2015-06-01 15:22:36','Patch Set 1:\n\nThere\'s no obvious licence for this environment',746,1,746,'7aade967_4605f2c0',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',746,1,746,'7aade967_465e52eb',NULL),(26,'2015-06-01 17:47:11','Patch Set 1:\n\nThis is derived from the default environment built with the SoCFPGA U-Boot source. The header where most of it is originally defined is GPLv2, however',746,1,746,'7aade967_e6e3be03',NULL),(28,'2015-09-28 10:41:20','Patch Set 3: Code-Review+1\n\nI didn\'t test this but those patches should cause no harm and they have been lingering too much time on Gerrit.',746,3,746,'da01753e_51035473',NULL),(6,'2015-09-28 10:55:48','Change has been successfully merged into the git repository.',746,3,746,'da01753e_511194ab',NULL),(6,'2015-09-28 10:55:46','Patch Set 3: Code-Review+2',746,3,746,'da01753e_710c9895',NULL),(26,'2015-09-24 08:28:42','Uploaded patch set 3.',746,3,746,'fafc7978_a750785f',NULL),(26,'2015-06-02 17:16:31','Uploaded patch set 2.',747,2,747,'5aaae553_65eee624',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',747,1,747,'7aade967_66634eb2',NULL),(32,'2015-06-01 15:22:21','Patch Set 1:\n\nThere\'s no obvious licence for these patches.',747,1,747,'7aade967_a6686688',NULL),(26,'2015-06-01 17:40:39','Patch Set 1:\n\nThey are my own work, so i\'m happy for them to be licensed any way. Not sure where this would be stated, though, besides the readme.',747,1,747,'7aade967_c6e6c216',NULL),(6,'2015-09-28 10:56:43','Change has been successfully merged into the git repository.',747,3,747,'da01753e_9122dcff',NULL),(6,'2015-09-28 10:56:28','Patch Set 3: Code-Review+2',747,3,747,'da01753e_b125600c',NULL),(28,'2015-09-28 10:41:29','Patch Set 3: Code-Review+1\n\nI didn\'t test this but those patches should cause no harm and they have been lingering too much time on Gerrit.',747,3,747,'da01753e_b1f7208c',NULL),(26,'2015-09-24 08:28:42','Uploaded patch set 3.',747,3,747,'fafc7978_074ea4c1',NULL),(26,'2015-06-02 17:16:31','Uploaded patch set 2.',748,2,748,'5aaae553_05f3720b',NULL),(26,'2015-06-01 14:56:37','Uploaded patch set 1.',748,1,748,'7aade967_06585af9',NULL),(26,'2015-06-01 17:36:57','Patch Set 1:\n\nI\'m fairly sure it\'s intended to be multi purpose. For the purposes of this BSP though, that\'s what this repo is for, all the changes are committed on an orphan branch to keep it separate.',748,1,748,'7aade967_26e23604',NULL),(32,'2015-06-01 15:23:16','Patch Set 1:\n\nthis implication is that bsp-support is only for the socfpga. have I misunderstood?',748,1,748,'7aade967_660a6ed4',NULL),(28,'2015-09-28 10:41:45','Patch Set 3: Code-Review+1\n\nI didn\'t test this but those patches should cause no harm and they have been lingering too much time on Gerrit.',748,3,748,'da01753e_91f49c88',NULL),(6,'2015-09-28 10:56:53','Change has been successfully merged into the git repository.',748,3,748,'da01753e_d11c64c4',NULL),(6,'2015-09-28 10:56:51','Patch Set 3: Code-Review+2',748,3,748,'da01753e_f11fe8b5',NULL),(6,'2015-09-14 10:32:29','Patch Set 2:\n\nI would also prefer this to be in a directory rather than in an orphan branch.\n\nIt\'s sad that we have to commit a bunch of generated code to Git, but I think the bsp-support repo is intended as a sort of dumping ground so I\'ve no objection to any of this being merged. I obviously can\'t do useful code review for any of it :)',748,2,748,'fafc7978_0cad2b89',NULL),(26,'2015-09-24 08:32:17','Patch Set 3:\n\nThanks, that does make sense. Now in a separate folder, to merge to master.',748,3,748,'fafc7978_27cc8835',NULL),(28,'2015-09-07 11:56:51','Patch Set 2:\n\nWhy on an orphan branch and not on a separate directory? I\'d prefer the later.',748,2,748,'fafc7978_cc716379',NULL),(26,'2015-09-24 08:28:42','Uploaded patch set 3.',748,3,748,'fafc7978_e74a80ab',NULL),(15,'2015-06-04 19:20:05','Uploaded patch set 3.',749,3,749,'1aa4ed85_c34a3627',NULL),(15,'2015-06-01 16:18:13','Uploaded patch set 1.',749,1,749,'7aade967_261476f4',NULL),(15,'2015-06-01 16:40:56','Patch Set 2:\n\nTested building a weston system with the GTK+ stratum',749,2,749,'7aade967_8619aa24',NULL),(15,'2015-06-01 16:39:19','Uploaded patch set 2.',749,2,749,'7aade967_c61fa208',NULL),(8,'2015-06-01 16:22:58','Patch Set 1:\n\n(1 comment)',749,1,749,'7aade967_e6f5fecb',NULL),(15,'2015-06-07 23:30:59','Change has been successfully rebased as 975c40201ecfee899932f0a8a532b82a3b8141bf',749,3,749,'da33351e_212bce83',NULL),(15,'2015-06-07 23:30:58','Patch Set 4: Patch Set 3 was rebased',749,3,749,'da33351e_4126d2bb',NULL),(15,'2015-06-07 23:30:30','Patch Set 3: Code-Review+2\n\n(1 comment)',749,3,749,'da33351e_a10fde2d',NULL),(6,'2015-06-05 17:07:27','Patch Set 3: Code-Review+1\n\nNice! I\'ve not tested this myself.',749,3,749,'fa2e39b8_22310ea3',NULL),(29,'2015-06-05 07:45:37','Patch Set 3: Code-Review+1\n\n(1 comment)\n\nThis looks good, though it would be nice if you could add a little more detail to the commit message, explaining why it\'s valid to depend on core instead of foundation in each case.',749,3,749,'fa2e39b8_c212e257',NULL),(27,'2015-06-03 13:55:40','Patch Set 1: Code-Review+1\n\nlooks good to me.',750,1,750,'3aa7f18b_046e16ca',NULL),(34,'2015-06-03 12:59:35','Patch Set 1: -Code-Review\n\n> Do we know how heavy is this repo? Size, time to lorry, etc?\n\nHave just looked; the librsync repo is 1.46 MB . I don\'t know the size of the rdiff-backup repo.',750,1,750,'3aa7f18b_c440fe37',NULL),(7,'2015-06-02 16:45:09','Patch Set 1:\n\nDo we know how heavy is this repo? Size, time to lorry, etc?',750,1,750,'5aaae553_2581ce4a',NULL),(34,'2015-06-02 11:22:37','Patch Set 1: Code-Review+1\n\nLook fine to me. :)',750,1,750,'5aaae553_652b4683',NULL),(31,'2015-06-01 16:26:13','Uploaded patch set 1.',750,1,750,'7aade967_86020ab3',NULL),(37,'2015-06-17 10:55:32','Change has been successfully rebased as 723487a78bf577d2cc69ec6f5effb643a2fd69e8',750,1,750,'ba51214e_18872563',NULL),(37,'2015-06-17 10:55:31','Patch Set 2: Patch Set 1 was rebased',750,1,750,'ba51214e_3882e952',NULL),(37,'2015-06-17 10:55:29','Patch Set 1: Code-Review+2\n\nLooks good to me, approved.',750,1,750,'ba51214e_d8b5ad32',NULL),(6,'2015-06-03 13:40:08','Patch Set 2: Code-Review+2',751,2,751,'3aa7f18b_44740e9c',NULL),(29,'2015-06-03 13:49:24','Change has been successfully merged into the git repository.',751,2,751,'3aa7f18b_64790a93',NULL),(32,'2015-06-03 13:04:30','Patch Set 1: Code-Review+1\n\nLooks reasonable.',751,1,751,'3aa7f18b_844a0654',NULL),(29,'2015-06-03 13:25:33','Uploaded patch set 2.',751,2,751,'3aa7f18b_a447024b',NULL),(6,'2015-06-03 12:59:43','Patch Set 1: Code-Review+1\n\nI would prefer \'separate_mount_namespace\' to \'unshare\', as unshare can mean a bunch of different things. Looks fine other than that.',751,1,751,'3aa7f18b_e43dfabc',NULL),(29,'2015-06-01 16:28:21','Uploaded patch set 1.',751,1,751,'7aade967_a6ff06aa',NULL),(15,'2015-06-03 11:41:28','Patch Set 1:\n\n> > > Hi, what prompted this?\n > > > The master branch still seems to include rsync in its build\n > > > requirements.\n > >\n > > After this change, the tools stratum can depend on core instead\n > > foundation\n > \n > I\'m a little wary of removing a requirement that\'s in upstream\'s\n > list of build requirements, has this been tested?\n\nYeah me too, but I think its worth in this case.\nWe actually do not need rsync as we are not updating the po files (--skip-po), but even if we do, the bootstrap script will fallback to wget to do the same operation',752,1,752,'3aa7f18b_0457f603',NULL),(15,'2015-06-03 11:12:48','Patch Set 1:\n\n> Hi, what prompted this?\n > The master branch still seems to include rsync in its build\n > requirements.\n\nAfter this change, the tools stratum can depend on core instead foundation',752,1,752,'3aa7f18b_444dee71',NULL),(29,'2015-06-03 11:28:45','Patch Set 1:\n\n> > Hi, what prompted this?\n > > The master branch still seems to include rsync in its build\n > > requirements.\n > \n > After this change, the tools stratum can depend on core instead\n > foundation\n\nI\'m a little wary of removing a requirement that\'s in upstream\'s\nlist of build requirements, has this been tested?',752,1,752,'3aa7f18b_64526a15',NULL),(29,'2015-06-03 14:01:05','Patch Set 1:\n\nI was able to build parted with tools build-depending on core instead of foundation',752,1,752,'3aa7f18b_8461a6d5',NULL),(29,'2015-06-03 10:50:06','Patch Set 1:\n\nHi, what prompted this?\nThe master branch still seems to include rsync in its build requirements.',752,1,752,'3aa7f18b_a43062e9',NULL),(29,'2015-06-03 14:00:20','Patch Set 1: Code-Review+1',752,1,752,'3aa7f18b_e4641ae7',NULL),(15,'2015-06-01 16:39:19','Uploaded patch set 1.',752,1,752,'7aade967_e61c1e16',NULL),(15,'2015-06-07 23:30:54','Patch Set 1: Code-Review+2',752,1,752,'da33351e_011dea66',NULL),(15,'2015-06-07 23:30:59','Change has been successfully rebased as 1d2f9510fcf92da922c805ac2431e04e34687bb8',752,1,752,'da33351e_8120da9c',NULL),(15,'2015-06-07 23:30:57','Patch Set 2: Patch Set 1 was rebased',752,1,752,'da33351e_e119e67a',NULL),(6,'2015-06-05 17:06:51','Patch Set 1: Code-Review+1\n\nI remember seeing this workaround in another chunk that used gnulib, and thinking it is sensible because rsync is literally only used to fetch a file from the internet at one point. A comment in the .morph file for the workaround would be nice though',752,1,752,'fa2e39b8_422c124b',NULL),(27,'2015-06-04 15:34:17','Patch Set 2: Code-Review+1',753,2,753,'1aa4ed85_a3e37a32',NULL),(15,'2015-06-01 21:14:37','Uploaded patch set 2.',753,2,753,'7aade967_46bad2e2',NULL),(15,'2015-06-01 21:25:18','Patch Set 2:\n\nI built a base system on x86_64 to test this',753,2,753,'7aade967_66bfced1',NULL),(15,'2015-06-01 21:12:57','Uploaded patch set 1.',753,1,753,'7aade967_a6edc6f1',NULL),(15,'2015-06-07 23:31:18','Patch Set 2: Code-Review+2',753,2,753,'da33351e_6125d6aa',NULL),(15,'2015-06-07 23:31:24','Change has been successfully rebased as 67bcbf986a19ada7574224d1b6cc3ec7039398b8',753,2,753,'da33351e_a136bee5',NULL),(15,'2015-06-07 23:31:24','Patch Set 3: Patch Set 2 was rebased',753,2,753,'da33351e_c13942da',NULL),(6,'2015-06-05 17:02:19','Patch Set 2: Code-Review+1\n\nLooks fine to me, thanks',753,2,753,'fa2e39b8_c2f822c7',NULL),(29,'2015-06-03 06:46:25','Patch Set 1: Reverted\n\nThis patchset was reverted in change: I35dc7b70f3653028968fbde3cc3326ff49207e30',754,1,754,'3aa7f18b_0409362c',NULL),(18,'2015-06-03 02:58:33','Patch Set 1: Code-Review+2',754,1,754,'3aa7f18b_44ff2e02',NULL),(18,'2015-06-03 02:58:36','Change has been successfully merged into the git repository.',754,1,754,'3aa7f18b_6404aa15',NULL),(34,'2015-06-02 13:49:07','Patch Set 1: Code-Review+1',754,1,754,'5aaae553_454dea71',NULL),(19,'2015-06-02 16:34:21','Patch Set 1: Code-Review+1',754,1,754,'5aaae553_6587c662',NULL),(31,'2015-06-02 13:37:20','Uploaded patch set 1.',754,1,754,'5aaae553_a5305ee9',NULL),(27,'2015-06-03 13:59:00','Patch Set 1: Code-Review+1\n\nseems logical to me.',755,1,755,'3aa7f18b_c4679ee9',NULL),(15,'2015-06-02 15:15:27','Uploaded patch set 1.',755,1,755,'5aaae553_65790693',NULL),(15,'2015-06-10 10:41:04','Patch Set 3: Patch Set 2 was rebased',755,2,755,'7a42497e_9e3dddbe',NULL),(15,'2015-06-10 10:41:04','Change has been successfully rebased as 3c9e4fbfc0b8e8b585f109ed5a6557eedb8ba9b5',755,2,755,'7a42497e_fe4a2154',NULL),(6,'2015-06-08 09:18:47','Patch Set 2: Commit message was updated',755,2,755,'ba3841fe_600e7236',NULL),(6,'2015-06-08 09:18:01','Patch Set 1: Code-Review+2\n\nAha, it removes the need for this: http://git.baserock.org/cgi-bin/cgit.cgi/delta/binutils-redhat.git/commit/?h=e7277\n\n(That patch seems to have been squashed into the current baserock/build-essential branch, incidentally).\n\nIn that case, great',755,1,755,'ba3841fe_8009f62e',NULL),(6,'2015-06-08 09:18:53','Patch Set 2: Code-Review+2',755,2,755,'ba3841fe_c012de57',NULL),(15,'2015-06-07 23:33:00','Patch Set 1:\n\n> Seems sensible, but does this gain us anything?\n\nThis allow us to use a pristine binutils tarball withou any modification (see the next patch in the series)',755,1,755,'da33351e_0134cadc',NULL),(6,'2015-06-05 17:02:59','Patch Set 1:\n\nSeems sensible, but does this gain us anything?',755,1,755,'fa2e39b8_a2f51ecd',NULL),(15,'2015-06-02 15:15:27','Uploaded patch set 1.',756,1,756,'5aaae553_056e12ca',NULL),(15,'2015-06-02 15:38:42','Patch Set 1:\n\nI\'ve build and run a base x86_64 system and generate a armv8l64 bootstrap tarball as well',756,1,756,'5aaae553_25aa2ed5',NULL),(15,'2015-06-10 10:41:21','Patch Set 2: Code-Review+2',756,2,756,'7a42497e_1e79cd93',NULL),(15,'2015-06-10 10:41:18','Patch Set 2: Patch Set 1 was rebased',756,1,756,'7a42497e_3e74899b',NULL),(15,'2015-06-10 10:41:23','Change has been successfully merged into the git repository.',756,2,756,'7a42497e_7e6e11cb',NULL),(NULL,'2015-06-10 10:41:09','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 1 of I1ce9d294, however the current patch set is 3.\n\nPlease rebase the change and upload a replacement commit.',756,1,756,'7a42497e_de47654a',NULL),(8,'2015-06-08 13:23:48','Patch Set 1: Code-Review+2',756,1,756,'ba3841fe_202bca83',NULL),(6,'2015-06-08 09:19:20','Patch Set 1: Code-Review+1\n\nNice',756,1,756,'ba3841fe_a00fda2d',NULL),(27,'2015-06-04 16:37:52','Patch Set 2: Code-Review+1',757,2,757,'1aa4ed85_2346aa24',NULL),(6,'2015-06-12 09:07:39','Patch Set 4: Code-Review+2',757,4,757,'3a4c51b2_5cf87de5',NULL),(6,'2015-06-12 09:07:44','Change has been successfully rebased as a96cba233e16adc9382db0049edbad31a10fdccf',757,4,757,'3a4c51b2_9cd96586',NULL),(6,'2015-06-12 09:07:43','Patch Set 5: Patch Set 4 was rebased',757,4,757,'3a4c51b2_bcdc2176',NULL),(8,'2015-06-12 08:43:46','Patch Set 4: Code-Review+1',757,4,757,'3a4c51b2_fc3349f4',NULL),(19,'2015-06-03 14:15:48','Uploaded patch set 2.',757,2,757,'3aa7f18b_449baec9',NULL),(19,'2015-06-03 14:07:57','Patch Set 1:\n\nI can move libSM into its own strata, if you like.',757,1,757,'3aa7f18b_a45e2211',NULL),(19,'2015-06-11 18:05:38','Uploaded patch set 4.',757,4,757,'5a3f45e8_3dee4f8c',NULL),(15,'2015-06-02 17:17:45','Patch Set 1:\n\nWhat do you need this for?\nThis packages is for X11 session management, so not sure we should put them in this stratum',757,1,757,'5aaae553_25f8eee4',NULL),(19,'2015-06-02 16:11:44','Uploaded patch set 1.',757,1,757,'5aaae553_c5aebae7',NULL),(15,'2015-06-08 17:45:49','Patch Set 3: Code-Review+1',757,3,757,'ba3841fe_0055e6c5',NULL),(8,'2015-06-08 13:24:44','Patch Set 3: Code-Review+1\n\nThis looks fine to me',757,3,757,'ba3841fe_8020d69c',NULL),(19,'2015-06-05 08:50:59','Uploaded patch set 3.',757,3,757,'fa2e39b8_a20fde2d',NULL),(6,'2015-06-05 15:31:24','Patch Set 3: Code-Review+1\n\nLooks ok, if libSM is large then it should probably go in its own stratum though (not sure if it is or not).',757,3,757,'fa2e39b8_a26ebe94',NULL),(27,'2015-06-04 15:33:05','Patch Set 2: Code-Review+1',758,2,758,'1aa4ed85_83e67e43',NULL),(6,'2015-06-12 10:28:26','Change has been successfully merged into the git repository.',758,6,758,'3a4c51b2_1c6395b2',NULL),(6,'2015-06-12 10:28:19','Patch Set 6: Code-Review+2\n\nPrevious version got stuck in \'Submitted, Merge Pending\' state. I have rebased to try to get it merged.\n\nThe merge did not actually go through in Gerrit\'s copy of baserock:baserock/definitions, and there is no error logged in the journal of gerrit.baserock.org.',758,6,758,'3a4c51b2_3c5e51ea',NULL),(NULL,'2015-06-12 09:29:29','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of I2d398b8b, however the current patch set is 5.\n\nPlease rebase the change and upload a replacement commit.',758,5,758,'3a4c51b2_3cd01153',NULL),(8,'2015-06-12 08:44:01','Patch Set 4: Code-Review+1',758,4,758,'3a4c51b2_dc300deb',NULL),(6,'2015-06-12 10:27:34','Patch Set 6: Patch Set 5 was rebased',758,5,758,'3a4c51b2_dc512dda',NULL),(6,'2015-06-12 09:29:19','Patch Set 5: Code-Review+2',758,5,758,'3a4c51b2_dce3ed31',NULL),(6,'2015-06-12 09:29:12','Patch Set 5: Commit message was updated',758,5,758,'3a4c51b2_fce6a943',NULL),(19,'2015-06-03 14:15:48','Uploaded patch set 2.',758,2,758,'3aa7f18b_64a02af5',NULL),(19,'2015-06-11 18:05:38','Uploaded patch set 4.',758,4,758,'5a3f45e8_1df39374',NULL),(19,'2015-06-02 16:11:44','Uploaded patch set 1.',758,1,758,'5aaae553_e5abb6d4',NULL),(8,'2015-06-08 13:26:17','Patch Set 3:\n\nI agree with Sam here, it would be nice if this information is available in commit message and .morph file',758,3,758,'ba3841fe_6025d2aa',NULL),(19,'2015-06-05 08:50:59','Uploaded patch set 3.',758,3,758,'fa2e39b8_021dea66',NULL),(6,'2015-06-05 15:32:12','Patch Set 3:\n\nThis is needed because the sandbox prevents chown calls, is that correct? Please note why this is needed in the commit message and/or as a commit in the .morph file.',758,3,758,'fa2e39b8_026cca9b',NULL),(19,'2015-06-12 08:11:55','Abandoned',759,1,759,'3a4c51b2_9c0fa52e',NULL),(19,'2015-06-02 16:11:44','Uploaded patch set 1.',759,1,759,'5aaae553_85b8c22b',NULL),(15,'2015-06-02 17:33:59','Patch Set 1: Code-Review-1\n\n(2 comments)\n\nIs it possible to rearrange some of the chunk so they are not duplicated in several strata?',760,1,760,'5aaae553_85e68243',NULL),(19,'2015-06-02 16:11:44','Uploaded patch set 1.',760,1,760,'5aaae553_a5b5be32',NULL),(19,'2015-06-05 08:55:32','Abandoned\n\nSuperceded',760,1,760,'fa2e39b8_8220da9c',NULL),(19,'2015-06-12 08:11:43','Abandoned',761,3,761,'3a4c51b2_bc126156',NULL),(19,'2015-06-03 14:15:48','Uploaded patch set 2.',761,2,761,'3aa7f18b_04a5b603',NULL),(27,'2015-06-03 13:57:53','Patch Set 1: Code-Review+1\n\nsanity appears to have been achieved here!',761,1,761,'3aa7f18b_247312b3',NULL),(27,'2015-06-03 14:35:40','Patch Set 2: Code-Review+1',761,2,761,'3aa7f18b_a4b5c232',NULL),(19,'2015-06-02 16:11:44','Uploaded patch set 1.',761,1,761,'5aaae553_4582ca53',NULL),(8,'2015-06-08 13:34:47','Patch Set 3: Code-Review-1\n\nI think you can merge this commit and the one I point in the same commit, if you follow the comments I pointed in https://gerrit.baserock.org/#/c/766 .',761,3,761,'ba3841fe_e030c2ea',NULL),(6,'2015-06-05 15:37:19','Patch Set 3:\n\n(2 comments)\n\nThanks for doing this!! The approach looks good, I have a couple small nitpicks though.',761,3,761,'fa2e39b8_820f3ae1',NULL),(19,'2015-06-05 08:50:59','Uploaded patch set 3.',761,3,761,'fa2e39b8_e219e67a',NULL),(15,'2015-06-04 14:35:08','Patch Set 1:\n\nI built a weston system with this change',762,1,762,'1aa4ed85_4374069c',NULL),(15,'2015-06-02 16:44:27','Uploaded patch set 1.',762,1,762,'5aaae553_057cd271',NULL),(24,'2015-06-02 17:09:30','Patch Set 1: Code-Review+1\n\nLooks fine to me.',762,1,762,'5aaae553_c5955a89',NULL),(15,'2015-06-07 23:33:38','Change has been successfully rebased as 313b5376612e381b7ce4ec341cea48bf2f1d33da',762,1,762,'da33351e_2152ae13',NULL),(15,'2015-06-07 23:33:37','Patch Set 2: Patch Set 1 was rebased',762,1,762,'da33351e_414d3272',NULL),(15,'2015-06-07 23:33:34','Patch Set 1: Code-Review+2',762,1,762,'da33351e_e130c6ea',NULL),(6,'2015-06-05 17:10:00','Patch Set 1: Code-Review+1\n\nNice!!! Not tested by me.',762,1,762,'fa2e39b8_c21f8208',NULL),(29,'2015-06-03 06:46:34','Patch Set 1: Code-Review+2',763,1,763,'3aa7f18b_240eb235',NULL),(29,'2015-06-03 06:46:36','Change has been successfully merged into the git repository.',763,1,763,'3aa7f18b_c4123e58',NULL),(16,'2015-06-03 09:24:28','Uploaded patch set 1.',764,1,764,'3aa7f18b_0420569a',NULL),(7,'2015-06-03 10:03:42','Patch Set 1: Code-Review+1\n\nMakes sense to me.',764,1,764,'3aa7f18b_242552ab',NULL),(15,'2015-06-03 10:05:48','Change has been successfully rebased as 4ff0ecb45170b024d29399a696306d927909479e',764,1,764,'3aa7f18b_8433e6f5',NULL),(15,'2015-06-03 10:05:44','Patch Set 1: Code-Review+2',764,1,764,'3aa7f18b_c439ded9',NULL),(15,'2015-06-03 10:05:48','Patch Set 2: Patch Set 1 was rebased',764,1,764,'3aa7f18b_e4365ae7',NULL),(37,'2015-06-04 08:59:38','Change has been successfully rebased as 8a4bee5b407226aa437b7812fb63bc502c111b70',765,3,765,'1aa4ed85_03092e2c',NULL),(37,'2015-06-04 08:59:33','Patch Set 3: Code-Review+2\n\nThis looks to be the fix we want.',765,3,765,'1aa4ed85_43ff2602',NULL),(37,'2015-06-04 08:59:37','Patch Set 4: Patch Set 3 was rebased',765,3,765,'1aa4ed85_6304a215',NULL),(15,'2015-06-03 15:00:28','Uploaded patch set 2.',765,2,765,'3aa7f18b_0441360b',NULL),(15,'2015-06-03 14:46:57','Patch Set 1:\n\nBuilt a base- and weston- system on x86_64 with this change',765,1,765,'3aa7f18b_047cd671',NULL),(15,'2015-06-03 15:00:43','Patch Set 3: Commit message was updated',765,3,765,'3aa7f18b_2446b224',NULL),(15,'2015-06-03 11:52:18','Uploaded patch set 1.',765,1,765,'3aa7f18b_245c7225',NULL),(15,'2015-06-03 17:04:26','Patch Set 3:\n\nBuilt a base system on x86_64 fine with this',765,3,765,'3aa7f18b_4405eec0',NULL),(24,'2015-06-03 15:03:30','Patch Set 3: Code-Review+1\n\nLooks good to me',765,3,765,'3aa7f18b_a45142da',NULL),(24,'2015-06-03 14:34:06','Patch Set 1:\n\nI configured bison with both busybox sh and bash, and then compared the two bison.build directories and there were no differences.\n\nThen I added git and bash as dependencies to the bison chunk in the core.morph and I was able to build bison and gobject-introspection with sh. So there is a missing dependency on bash in either glib or gobject-introspection, that needs adding.',765,1,765,'3aa7f18b_c4aebee7',NULL),(15,'2015-06-03 15:01:14','Topic changed from bison_fix to gobject-introspection_bash',765,3,765,'3aa7f18b_e4473a1c',NULL),(27,'2015-06-04 16:34:42','Patch Set 1: -Code-Review',766,1,766,'1aa4ed85_03412e0b',NULL),(27,'2015-06-04 16:34:29','Patch Set 1: Code-Review+1\n\nthis seems sensible to me, but i\'m not confident enough in it to +1',766,1,766,'1aa4ed85_633ca294',NULL),(6,'2015-06-12 10:38:41','Change has been successfully merged into the git repository.',766,5,766,'3a4c51b2_1c0a75d2',NULL),(6,'2015-06-12 10:38:38','Patch Set 5: Code-Review+2',766,5,766,'3a4c51b2_3c05b1c2',NULL),(8,'2015-06-12 08:44:45','Patch Set 3: Code-Review+1',766,3,766,'3a4c51b2_3c4db173',NULL),(6,'2015-06-12 10:38:24','Patch Set 4: Code-Review+2',766,4,766,'3a4c51b2_9c6e8595',NULL),(6,'2015-06-12 10:38:13','Patch Set 4: Commit message was updated',766,4,766,'3a4c51b2_bc71c179',NULL),(6,'2015-06-12 10:38:34','Patch Set 5: Patch Set 4 was rebased',766,4,766,'3a4c51b2_dc680d8a',NULL),(NULL,'2015-06-12 10:38:27','Change cannot be merged due to unsatisfiable dependencies.\n\nThe following dependency errors were found:\n\n* Depends on patch set 4 of If56f7eb6, however the current patch set is 6.\n* Depends on commit 0c2ebb5e6290cf42497c8956ab15702616123a76 which has no change associated with it.\n\nPlease rebase the change and upload a replacement commit.',766,4,766,'3a4c51b2_fc6b4983',NULL),(19,'2015-06-03 14:15:48','Uploaded patch set 1.',766,1,766,'3aa7f18b_24aa32d5',NULL),(19,'2015-06-11 18:05:38','Uploaded patch set 3.',766,3,766,'5a3f45e8_7de8d77c',NULL),(8,'2015-06-08 13:31:52','Patch Set 2: Code-Review-1\n\n(2 comments)\n\nPlease see comments.\nI also agree with Sam\'s comment.',766,2,766,'ba3841fe_0034c6dc',NULL),(19,'2015-06-05 08:50:59','Uploaded patch set 2.',766,2,766,'fa2e39b8_4226d2bb',NULL),(6,'2015-06-05 15:34:17','Patch Set 2:\n\nNice.\n\nThe java-binary repo is going against a policy we have for our definitions.git that everything should be mirrored on git.baserock.org. It\'s OK for now (I know you didn\'t introduce this \"violation\" either) but please add a comment saying that it\'s a special case to the stratum\n\nLooks fine other than that',766,2,766,'fa2e39b8_e268c689',NULL),(29,'2015-06-03 14:36:35','Patch Set 1: Code-Review+2',767,1,767,'3aa7f18b_4482ce53',NULL),(29,'2015-06-03 14:36:37','Change has been successfully merged into the git repository.',767,1,767,'3aa7f18b_6487ca62',NULL),(29,'2015-06-03 14:35:24','Uploaded patch set 1.',767,1,767,'3aa7f18b_e4abbad4',NULL),(29,'2015-06-03 14:35:24','Uploaded patch set 1.',768,1,768,'3aa7f18b_84b8c62b',NULL),(27,'2015-06-03 14:51:00','Patch Set 1: Code-Review+1',768,1,768,'3aa7f18b_c4955e89',NULL),(29,'2015-06-09 10:34:04','Change has been successfully merged into the git repository.',768,1,768,'9a3d3df0_9f92f39d',NULL),(6,'2015-06-05 17:03:25','Patch Set 1: Code-Review+2\n\nLooks sensible',768,1,768,'fa2e39b8_02032ab9',NULL),(29,'2015-06-03 15:17:44','Patch Set 2: Code-Review+1',769,2,769,'3aa7f18b_045856f9',NULL),(7,'2015-06-03 14:47:40','Uploaded patch set 1.',769,1,769,'3aa7f18b_2481d24a',NULL),(8,'2015-06-03 14:58:33','Patch Set 1:\n\n> As I put in the commit message, it was creating some confusion in\n > the network, because I didn\'t know it was there, and I didn\'t want\n > it. I don\'t think this is OpenStack specific.\n\nI know it is not OpenStack specific, but fixes an important bug in our OpenStack in Baserock system (for example if we want to deploy a Juno release at some point this patch should be in that release for OpenStack to work). I like the commit message, I just would like a note which name OpenStack so it will be easy to find it out.',769,1,769,'3aa7f18b_44372eb1',NULL),(7,'2015-06-03 15:12:43','Patch Set 2: Commit message was updated',769,2,769,'3aa7f18b_445e4eeb',NULL),(32,'2015-06-03 15:00:02','Patch Set 1: Code-Review+1\n\nLooks reasonable.\n\nIs the lack of -f deliberate (in case a future libvirt doesn\'t set up that symlink?)\n\nIf so, +1, if not deliberate, decide if you wanted that or not. +1 either way.',769,1,769,'3aa7f18b_643caa94',NULL),(8,'2015-06-03 15:13:35','Patch Set 2: Code-Review+1',769,2,769,'3aa7f18b_64634ab2',NULL),(8,'2015-06-03 15:01:53','Patch Set 1:\n\n> I don\'t think this is a bug, and I believe that if you carefully\n > don\'t use the same iprange for your openstack subnetworks, nothing\n > happens.\n > \n > I can make a note, saying that this was causing problems with\n > OpenStack, though.\n\nSounds good to me',769,1,769,'3aa7f18b_845446cb',NULL),(8,'2015-06-03 1